)]}'
{"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"79c1700cca35e07368b9cdc440011bab2d1493b2","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        except exception.PortNotFound:"},{"line_number":355,"context_line":"            return []"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _check_allowed_port_fields(self, fields):"},{"line_number":358,"context_line":"        \"\"\"Check if fetching a particular field of a port is allowed."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        Check if the required version is being requested for fields"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_2bebe5b0","line":357,"updated":"2017-05-03 22:25:22.000000000","message":"Please add direct unit tests of this function.","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f84e4e5d3392072e1ddf40995aa81693315fc265","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        except exception.PortNotFound:"},{"line_number":355,"context_line":"            return []"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _check_allowed_port_fields(self, fields):"},{"line_number":358,"context_line":"        \"\"\"Check if fetching a particular field of a port is allowed."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        Check if the required version is being requested for fields"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_2e92bef7","line":357,"in_reply_to":"3f044301_2bebe5b0","updated":"2017-05-04 13:57:54.000000000","message":"For whatever reason, there are no unit tests for any of the internal methods. Which is why I didn\u0027t add any for this. I suppose I could...","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"23d63f70eba62bbdfd3d6e45d6f611ceff745aa5","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        except exception.PortNotFound:"},{"line_number":355,"context_line":"            return []"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _check_allowed_port_fields(self, fields):"},{"line_number":358,"context_line":"        \"\"\"Check if fetching a particular field of a port is allowed."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        Check if the required version is being requested for fields"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_c02c4249","line":357,"in_reply_to":"3f044301_2e92bef7","updated":"2017-05-04 15:54:09.000000000","message":"I think it is what we should be doing. Don\u0027t you?","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5b50ca055ef97cce2b877c3fdbc5e08e168ee270","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        except exception.PortNotFound:"},{"line_number":355,"context_line":"            return []"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _check_allowed_port_fields(self, fields):"},{"line_number":358,"context_line":"        \"\"\"Check if fetching a particular field of a port is allowed."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        Check if the required version is being requested for fields"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_c87683a5","line":357,"in_reply_to":"3f044301_c02c4249","updated":"2017-05-16 15:34:24.000000000","message":"No, I don\u0027t think so.\n\nIn the ideal world yes, but given the state of the base and everything else that could be done in the time to add this, no. The code is being tested via other unit tests.\n\nHaving said that, because you want it, I added them :)","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"}],"releasenotes/notes/sort_key_allowed_field-091f8eeedd0a2ace.yaml":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"79c1700cca35e07368b9cdc440011bab2d1493b2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When returning lists of nodes, port groups, or ports, checks the sort key"},{"line_number":5,"context_line":"    to make sure the field is available in the requested API version. A 406"},{"line_number":6,"context_line":"    HTTP status is returned if the field is not available."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f044301_2b9d2559","line":5,"range":{"start_line":5,"start_character":70,"end_line":5,"end_character":75},"updated":"2017-05-03 22:25:22.000000000","message":"A 406 (NOT ACCEPTABLE)","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5b50ca055ef97cce2b877c3fdbc5e08e168ee270","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When returning lists of nodes, port groups, or ports, checks the sort key"},{"line_number":5,"context_line":"    to make sure the field is available in the requested API version. A 406"},{"line_number":6,"context_line":"    HTTP status is returned if the field is not available."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f013ff3_8d464d7c","line":5,"range":{"start_line":5,"start_character":70,"end_line":5,"end_character":75},"in_reply_to":"3f044301_2b9d2559","updated":"2017-05-16 15:34:24.000000000","message":"done","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"79c1700cca35e07368b9cdc440011bab2d1493b2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When returning lists of nodes, port groups, or ports, checks the sort key"},{"line_number":5,"context_line":"    to make sure the field is available in the requested API version. A 406"},{"line_number":6,"context_line":"    HTTP status is returned if the field is not available."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f044301_4bb191e1","line":6,"updated":"2017-05-03 22:25:22.000000000","message":"It seems to do more than this though. It adds a check in port.py to make sure that \u0027fields\u0027 is valid.","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f84e4e5d3392072e1ddf40995aa81693315fc265","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When returning lists of nodes, port groups, or ports, checks the sort key"},{"line_number":5,"context_line":"    to make sure the field is available in the requested API version. A 406"},{"line_number":6,"context_line":"    HTTP status is returned if the field is not available."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f044301_ced7da23","line":6,"in_reply_to":"3f044301_4bb191e1","updated":"2017-05-04 13:57:54.000000000","message":"It already did this; I only refactored the code into a helper method so it wasn\u0027t duplicated.","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"23d63f70eba62bbdfd3d6e45d6f611ceff745aa5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When returning lists of nodes, port groups, or ports, checks the sort key"},{"line_number":5,"context_line":"    to make sure the field is available in the requested API version. A 406"},{"line_number":6,"context_line":"    HTTP status is returned if the field is not available."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f044301_4047124d","line":6,"in_reply_to":"3f044301_ced7da23","updated":"2017-05-04 15:54:09.000000000","message":"Ah, I see it now. Thanks.","commit_id":"2adf1cbd820857d05782fe6656e5a37ece6e5395"}]}