)]}'
{"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a28511b40ae4bd9d8f4310d3fa83b41ee18ca2e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            {\u0027address\u0027: address, \u0027node\u0027: node.uuid})"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    system_id \u003d driver_info[\u0027redfish_system_id\u0027]"},{"line_number":106,"context_line":"    if not isinstance(system_id, six.string_types):"},{"line_number":107,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":108,"context_line":"            _(\u0027Invalid value \"%(value)s\" set in \u0027"},{"line_number":109,"context_line":"              \u0027driver_info/redfish_system_id on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_29516d63","line":106,"updated":"2017-05-05 19:17:25.000000000","message":"\u003e\u003e\u003e isinstance(\u0027/edfish/   abc/\u0027, six.string_types)\nTrue\nbut it is not valid system_id right?","commit_id":"b0d7a8559c651677e52aa68f3e0bf4a8e50a66fe"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"bfcda209f836c6e2314c0f56aff755aa26becdac","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            {\u0027address\u0027: address, \u0027node\u0027: node.uuid})"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    system_id \u003d driver_info[\u0027redfish_system_id\u0027]"},{"line_number":106,"context_line":"    if not isinstance(system_id, six.string_types):"},{"line_number":107,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":108,"context_line":"            _(\u0027Invalid value \"%(value)s\" set in \u0027"},{"line_number":109,"context_line":"              \u0027driver_info/redfish_system_id on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_5fcb6852","line":106,"updated":"2017-05-29 16:47:03.000000000","message":"urllib.quote would be a good option here.","commit_id":"b0d7a8559c651677e52aa68f3e0bf4a8e50a66fe"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"acd9943e2be8a84c07f04304de26dd60e5ce565e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            {\u0027address\u0027: address, \u0027node\u0027: node.uuid})"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    system_id \u003d driver_info[\u0027redfish_system_id\u0027]"},{"line_number":106,"context_line":"    if not isinstance(system_id, six.string_types):"},{"line_number":107,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":108,"context_line":"            _(\u0027Invalid value \"%(value)s\" set in \u0027"},{"line_number":109,"context_line":"              \u0027driver_info/redfish_system_id on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_d0ee4087","line":106,"in_reply_to":"3f044301_29516d63","updated":"2017-05-18 10:05:52.000000000","message":"Right I guess so, but I\u0027m not sure we should be doing such detailed validation here, operator will see that the requests go to the wrong address. Though maybe we should do the urllib.quote.","commit_id":"b0d7a8559c651677e52aa68f3e0bf4a8e50a66fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"25d9b79eff170a1fc122f8b8768b2aab556213fd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            {\u0027address\u0027: address, \u0027node\u0027: node.uuid})"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    system_id \u003d driver_info[\u0027redfish_system_id\u0027]"},{"line_number":106,"context_line":"    if not isinstance(system_id, six.string_types):"},{"line_number":107,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":108,"context_line":"            _(\u0027Invalid value \"%(value)s\" set in \u0027"},{"line_number":109,"context_line":"              \u0027driver_info/redfish_system_id on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_21d76df0","line":106,"in_reply_to":"df140735_5fcb6852","updated":"2017-05-30 09:34:35.000000000","message":"Sorry for the lack of updates on this patch, I got busy with some other stuff...\n\n@Vasyl, as vdrok said, I wish we could come up with a more specific validation a actual path but the specification seems pretty laid back and I don\u0027t know if all vendors shares similar paths to the System resources. That\u0027s why I was just looking at the type of the input here.\n\n++ for ullib.quote, I will update the patch.","commit_id":"b0d7a8559c651677e52aa68f3e0bf4a8e50a66fe"}]}
