)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93aab78be3affc802d1821f766fdefa9a517f767","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve graceful shutdown of conductor process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conductor is going to down it is trying to wait of completion of"},{"line_number":10,"context_line":"all periodical tasks which are already in the running state. If there"},{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_7b7cacb4","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":29},"updated":"2017-07-03 16:55:13.000000000","message":"being stopped","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93aab78be3affc802d1821f766fdefa9a517f767","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve graceful shutdown of conductor process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conductor is going to down it is trying to wait of completion of"},{"line_number":10,"context_line":"all periodical tasks which are already in the running state. If there"},{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_bb7244e2","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":53},"updated":"2017-07-03 16:55:13.000000000","message":"for","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d071addd3dd51d5ecfb8fe933789373cf288227d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve graceful shutdown of conductor process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conductor is going to down it is trying to wait of completion of"},{"line_number":10,"context_line":"all periodical tasks which are already in the running state. If there"},{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_674a9fac","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":53},"in_reply_to":"3f1d235d_bb7244e2","updated":"2017-07-05 09:02:43.000000000","message":"Done","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93aab78be3affc802d1821f766fdefa9a517f767","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conductor is going to down it is trying to wait of completion of"},{"line_number":10,"context_line":"all periodical tasks which are already in the running state. If there"},{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"},{"line_number":13,"context_line":"that stops iterations over nodes in periodical tasks if conductor"},{"line_number":14,"context_line":"is going to down. These changes reduce probabilyty to get locked"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_3b507432","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":18},"updated":"2017-07-03 16:55:13.000000000","message":"assigned to the","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d071addd3dd51d5ecfb8fe933789373cf288227d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conductor is going to down it is trying to wait of completion of"},{"line_number":10,"context_line":"all periodical tasks which are already in the running state. If there"},{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"},{"line_number":13,"context_line":"that stops iterations over nodes in periodical tasks if conductor"},{"line_number":14,"context_line":"is going to down. These changes reduce probabilyty to get locked"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_2235b58f","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":18},"in_reply_to":"3f1d235d_3b507432","updated":"2017-07-05 09:02:43.000000000","message":"Done","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93aab78be3affc802d1821f766fdefa9a517f767","unresolved":false,"context_lines":[{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"},{"line_number":13,"context_line":"that stops iterations over nodes in periodical tasks if conductor"},{"line_number":14,"context_line":"is going to down. These changes reduce probabilyty to get locked"},{"line_number":15,"context_line":"nodes after shutdown and time of shutdown."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1701495"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_1b47f87a","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":16},"updated":"2017-07-03 16:55:13.000000000","message":"being stopped","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c3a05c0b2aed692bbea0ebd9cbc99f460d36456b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"},{"line_number":13,"context_line":"that stops iterations over nodes in periodical tasks if conductor"},{"line_number":14,"context_line":"is going to down. These changes reduce probabilyty to get locked"},{"line_number":15,"context_line":"nodes after shutdown and time of shutdown."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1701495"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_c47bf1bb","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":50},"updated":"2017-07-03 09:28:49.000000000","message":"nit: s/probabilyty/probability/","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d071addd3dd51d5ecfb8fe933789373cf288227d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"are many nodes for conductor this may take a long time, and oslo"},{"line_number":12,"context_line":"service library can kill thread by timeout. This patch adds code"},{"line_number":13,"context_line":"that stops iterations over nodes in periodical tasks if conductor"},{"line_number":14,"context_line":"is going to down. These changes reduce probabilyty to get locked"},{"line_number":15,"context_line":"nodes after shutdown and time of shutdown."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1701495"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_4230b19f","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":16},"in_reply_to":"3f1d235d_1b47f87a","updated":"2017-07-05 09:02:43.000000000","message":"Done","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"79791c3abe51a10f29234a4aae8e624f6e991509","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"    @mock.patch.object(dbapi.IMPL, \u0027get_nodeinfo_list\u0027)"},{"line_number":2852,"context_line":"    def test_iter_nodes_shutdown(self, mock_nodeinfo_list):"},{"line_number":2853,"context_line":"        self._start_service()"},{"line_number":2854,"context_line":"        self.columns \u003d [\u0027uuid\u0027, \u0027driver\u0027, \u0027id\u0027]"},{"line_number":2855,"context_line":"        nodes \u003d [self._create_node(driver\u003d\u0027fake\u0027)]"},{"line_number":2856,"context_line":"        mock_nodeinfo_list.return_value \u003d self._get_nodeinfo_list_response("},{"line_number":2857,"context_line":"            nodes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_18f5d083","line":2854,"range":{"start_line":2854,"start_character":8,"end_line":2854,"end_character":47},"updated":"2017-07-03 07:19:59.000000000","message":"This line is not required now.","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d071addd3dd51d5ecfb8fe933789373cf288227d","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"    @mock.patch.object(dbapi.IMPL, \u0027get_nodeinfo_list\u0027)"},{"line_number":2852,"context_line":"    def test_iter_nodes_shutdown(self, mock_nodeinfo_list):"},{"line_number":2853,"context_line":"        self._start_service()"},{"line_number":2854,"context_line":"        self.columns \u003d [\u0027uuid\u0027, \u0027driver\u0027, \u0027id\u0027]"},{"line_number":2855,"context_line":"        nodes \u003d [self._create_node(driver\u003d\u0027fake\u0027)]"},{"line_number":2856,"context_line":"        mock_nodeinfo_list.return_value \u003d self._get_nodeinfo_list_response("},{"line_number":2857,"context_line":"            nodes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_2791474f","line":2854,"range":{"start_line":2854,"start_character":8,"end_line":2854,"end_character":47},"in_reply_to":"3f1d235d_18f5d083","updated":"2017-07-05 09:02:43.000000000","message":"It\u0027s used, test fails.","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"}],"releasenotes/notes/improve-conductor-shutdown-42687d8b9dac4054.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93aab78be3affc802d1821f766fdefa9a517f767","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Shutdown of conductor process improved, do not wait completion of all"},{"line_number":4,"context_line":"    periodical tasks in the running state, stop iterations over nodes instead."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_763161ec","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":43},"updated":"2017-07-03 16:55:13.000000000","message":"... should take less time, as we do not wait for completion of all periodic tasks.\n\nI think this should be enough, the fact that we\u0027re iterating over some nodes is not really interesting for an operator I think :)","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c3a05c0b2aed692bbea0ebd9cbc99f460d36456b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Shutdown of conductor process improved, do not wait completion of all"},{"line_number":4,"context_line":"    periodical tasks in the running state, stop iterations over nodes instead."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_1f6a52b2","line":3,"updated":"2017-07-03 09:28:49.000000000","message":"s/completion/for completion/","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d071addd3dd51d5ecfb8fe933789373cf288227d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Shutdown of conductor process improved, do not wait completion of all"},{"line_number":4,"context_line":"    periodical tasks in the running state, stop iterations over nodes instead."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_a73d572c","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":43},"in_reply_to":"3f1d235d_763161ec","updated":"2017-07-05 09:02:43.000000000","message":"Done","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c3a05c0b2aed692bbea0ebd9cbc99f460d36456b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Shutdown of conductor process improved, do not wait completion of all"},{"line_number":4,"context_line":"    periodical tasks in the running state, stop iterations over nodes instead."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_df63badb","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":14},"updated":"2017-07-03 09:28:49.000000000","message":"nit: s/periodical/periodic/","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d071addd3dd51d5ecfb8fe933789373cf288227d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Shutdown of conductor process improved, do not wait completion of all"},{"line_number":4,"context_line":"    periodical tasks in the running state, stop iterations over nodes instead."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_8746dbbf","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":14},"in_reply_to":"3f1d235d_df63badb","updated":"2017-07-05 09:02:43.000000000","message":"Done","commit_id":"0e5e770995b92218e37ca61c6ae48d633a3d1539"}]}