)]}'
{"doc/source/dev/webapi-version-history.rst":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.33** (Pike)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Added storage_interface field to the node object to allow getting and"},{"line_number":8,"context_line":"    setting the interface."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"**1.32** (Pike)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_16182d73","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":28},"updated":"2017-05-26 18:10:15.000000000","message":"nit:s/storage_interface/``storage_interface``","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"45463d9dc930f048684db6ac63bbb1a4516f8a45","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.33** (Pike)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Added storage_interface field to the node object to allow getting and"},{"line_number":8,"context_line":"    setting the interface."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"**1.32** (Pike)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_c22a138f","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":28},"in_reply_to":"ff0f0b1f_16182d73","updated":"2017-05-28 13:57:00.000000000","message":"Done","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":847,"context_line":"    raid_interface \u003d wsme.wsattr(wtypes.text)"},{"line_number":848,"context_line":"    \"\"\"The raid interface to be used for this node\"\"\""},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    storage_interface \u003d wsme.wsattr(wtypes.text)"},{"line_number":851,"context_line":"    \"\"\"The storage interface to be used for this node\"\"\""},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    vendor_interface \u003d wsme.wsattr(wtypes.text)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_d3e087cf","line":850,"range":{"start_line":850,"start_character":4,"end_line":850,"end_character":21},"updated":"2017-05-26 18:10:15.000000000","message":"do we usually do a check for valid interface name? I am not sure if we do that but just came to my mind.","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"45463d9dc930f048684db6ac63bbb1a4516f8a45","unresolved":false,"context_lines":[{"line_number":847,"context_line":"    raid_interface \u003d wsme.wsattr(wtypes.text)"},{"line_number":848,"context_line":"    \"\"\"The raid interface to be used for this node\"\"\""},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    storage_interface \u003d wsme.wsattr(wtypes.text)"},{"line_number":851,"context_line":"    \"\"\"The storage interface to be used for this node\"\"\""},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    vendor_interface \u003d wsme.wsattr(wtypes.text)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_42184380","line":850,"range":{"start_line":850,"start_character":4,"end_line":850,"end_character":21},"in_reply_to":"ff0f0b1f_d3e087cf","updated":"2017-05-28 13:57:00.000000000","message":"An interface is validated in conductor.","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        if (not api_utils.allow_storage_interface() and"},{"line_number":1613,"context_line":"                node.storage_interface is not wtypes.Unset):"},{"line_number":1614,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        # NOTE(deva): get_topic_for checks if node.driver is in the hash ring"},{"line_number":1617,"context_line":"        #             and raises NoValidHost if it is not."}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_3358e354","line":1614,"range":{"start_line":1614,"start_character":18,"end_line":1614,"end_character":43},"updated":"2017-05-26 18:10:15.000000000","message":"Please add this raised exception in the docstring","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"45463d9dc930f048684db6ac63bbb1a4516f8a45","unresolved":false,"context_lines":[{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"        if (not api_utils.allow_storage_interface() and"},{"line_number":1613,"context_line":"                node.storage_interface is not wtypes.Unset):"},{"line_number":1614,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        # NOTE(deva): get_topic_for checks if node.driver is in the hash ring"},{"line_number":1617,"context_line":"        #             and raises NoValidHost if it is not."}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_220d4f3e","line":1614,"range":{"start_line":1614,"start_character":18,"end_line":1614,"end_character":43},"in_reply_to":"ff0f0b1f_3358e354","updated":"2017-05-28 13:57:00.000000000","message":"No exceptions are listed in the docstring. So it would be better to fix docstirng of the file with another patch, IMO.","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"                    raise exception.NotAcceptable()"},{"line_number":1679,"context_line":""},{"line_number":1680,"context_line":"        s_interface \u003d api_utils.get_patch_values(patch, \u0027/storage_interface\u0027)"},{"line_number":1681,"context_line":"        if s_interface and not api_utils.allow_storage_interface():"},{"line_number":1682,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_f6d01956","line":1681,"range":{"start_line":1681,"start_character":8,"end_line":1681,"end_character":67},"updated":"2017-05-26 18:10:15.000000000","message":"Why is check_allowed_fields() being called here, that would be effective, we are doing this check there too.","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"45463d9dc930f048684db6ac63bbb1a4516f8a45","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"                    raise exception.NotAcceptable()"},{"line_number":1679,"context_line":""},{"line_number":1680,"context_line":"        s_interface \u003d api_utils.get_patch_values(patch, \u0027/storage_interface\u0027)"},{"line_number":1681,"context_line":"        if s_interface and not api_utils.allow_storage_interface():"},{"line_number":1682,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_c203330f","line":1681,"range":{"start_line":1681,"start_character":8,"end_line":1681,"end_character":67},"in_reply_to":"ff0f0b1f_f6d01956","updated":"2017-05-28 13:57:00.000000000","message":"check_allowed_fields() is for validate \u0027fields\u0027 parameter of GET method. It\u0027s not avaialable here.","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":1679,"context_line":""},{"line_number":1680,"context_line":"        s_interface \u003d api_utils.get_patch_values(patch, \u0027/storage_interface\u0027)"},{"line_number":1681,"context_line":"        if s_interface and not api_utils.allow_storage_interface():"},{"line_number":1682,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_d34f6790","line":1682,"range":{"start_line":1682,"start_character":18,"end_line":1682,"end_character":43},"updated":"2017-05-26 18:10:15.000000000","message":"Please add NotAcceptable in the docstring","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"45463d9dc930f048684db6ac63bbb1a4516f8a45","unresolved":false,"context_lines":[{"line_number":1679,"context_line":""},{"line_number":1680,"context_line":"        s_interface \u003d api_utils.get_patch_values(patch, \u0027/storage_interface\u0027)"},{"line_number":1681,"context_line":"        if s_interface and not api_utils.allow_storage_interface():"},{"line_number":1682,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":1685,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_a5fe0903","line":1682,"range":{"start_line":1682,"start_character":18,"end_line":1682,"end_character":43},"in_reply_to":"ff0f0b1f_d34f6790","updated":"2017-05-28 13:57:00.000000000","message":"ditto","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":562,"context_line":"def allow_storage_interface():"},{"line_number":563,"context_line":"    \"\"\"Check if we should support storage_interface node field."},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    Version 1.20 of the API added support for network interfaces."},{"line_number":566,"context_line":"    \"\"\""},{"line_number":567,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":568,"context_line":"            versions.MINOR_33_STORAGE_INTERFACE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_b63f4186","line":565,"range":{"start_line":565,"start_character":46,"end_line":565,"end_character":64},"updated":"2017-05-26 18:10:15.000000000","message":"Should be storage_interface","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f003b506c3b7b671096cd98ecaffde0f36733bdd","unresolved":false,"context_lines":[{"line_number":562,"context_line":"def allow_storage_interface():"},{"line_number":563,"context_line":"    \"\"\"Check if we should support storage_interface node field."},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    Version 1.20 of the API added support for network interfaces."},{"line_number":566,"context_line":"    \"\"\""},{"line_number":567,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":568,"context_line":"            versions.MINOR_33_STORAGE_INTERFACE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_16bb8d0e","line":565,"range":{"start_line":565,"start_character":12,"end_line":565,"end_character":16},"updated":"2017-05-26 18:10:15.000000000","message":"nit:1.33","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"45463d9dc930f048684db6ac63bbb1a4516f8a45","unresolved":false,"context_lines":[{"line_number":562,"context_line":"def allow_storage_interface():"},{"line_number":563,"context_line":"    \"\"\"Check if we should support storage_interface node field."},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    Version 1.20 of the API added support for network interfaces."},{"line_number":566,"context_line":"    \"\"\""},{"line_number":567,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":568,"context_line":"            versions.MINOR_33_STORAGE_INTERFACE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_62134768","line":565,"range":{"start_line":565,"start_character":46,"end_line":565,"end_character":64},"in_reply_to":"ff0f0b1f_b63f4186","updated":"2017-05-28 13:57:00.000000000","message":"Done","commit_id":"7988e76d6e61958edac8139d1cd8cb8d68b50dc4"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7fc70c8bfdfbae53c75f8309cc6669ce25114585","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# v1.30: Add dynamic driver interactions."},{"line_number":64,"context_line":"# v1.31: Add dynamic interfaces fields to node."},{"line_number":65,"context_line":"# v1.32: Add volume support."},{"line_number":66,"context_line":"# v1.33: Add node storage interface"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":69,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf091321_65f68d92","line":66,"range":{"start_line":66,"start_character":25,"end_line":66,"end_character":26},"updated":"2017-06-08 21:17:09.000000000","message":"nit: we should say storage_interface","commit_id":"e035af1e3909a8d44cbb996a05fe49f2ce1d7ab6"}],"releasenotes/notes/node-storage-interface-api-1d6e217303bd53ff.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7fc70c8bfdfbae53c75f8309cc6669ce25114585","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are 2 storage interfaces available:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * ``noop``: This interface provides nothing regarding storage."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * ``cinder``: This interface enables a node to attach and detach volumes"},{"line_number":12,"context_line":"      by leveraging cinder API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf091321_c5b79986","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":47},"updated":"2017-06-08 21:17:09.000000000","message":"I\u0027m slightly conflicted regarding \"nothing\", but it is also a valid way to express what the noop storage interface does, minus default behaviors.","commit_id":"e035af1e3909a8d44cbb996a05fe49f2ce1d7ab6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7fc70c8bfdfbae53c75f8309cc6669ce25114585","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * ``noop``: This interface provides nothing regarding storage."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * ``cinder``: This interface enables a node to attach and detach volumes"},{"line_number":12,"context_line":"      by leveraging cinder API."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Storage interfaces are enabled via the"},{"line_number":15,"context_line":"    ``[DEFAULT]/enabled_storage_interfaces`` configuration option. A default"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf091321_c5455972","line":12,"updated":"2017-06-08 21:17:09.000000000","message":"I feel like we should kind of highlight, or point to how, in that it only occurs if a volume_target is defined for the node.","commit_id":"e035af1e3909a8d44cbb996a05fe49f2ce1d7ab6"}]}
