)]}'
{"ironic/common/cinder.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"66f29c5a1f8aed5ce5b22efd6ea371842c1fc893","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                 as it is a free-form value returned by the driver."},{"line_number":191,"context_line":"                 The accompanying \u0027data\u0027 key contains the actual target"},{"line_number":192,"context_line":"                 details which will indicate either target WWNs and a LUN"},{"line_number":193,"context_line":"                 or a target portal and IQN. It also always contains"},{"line_number":194,"context_line":"                 volume ID in cinder and ironic. Except for these two IDs,"},{"line_number":195,"context_line":"                 each driver may return somewhat different data although"},{"line_number":196,"context_line":"                 the same keys are used if the target is FC or iSCSI,"},{"line_number":197,"context_line":"                 so any logic should be based upon the returned contents."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_c50a0025","line":194,"range":{"start_line":193,"start_character":45,"end_line":194,"end_character":48},"updated":"2017-05-16 05:20:12.000000000","message":"There are different uuids.","commit_id":"703b8898e38837519c0aaff6967cf359058ba699"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"66f29c5a1f8aed5ce5b22efd6ea371842c1fc893","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                     \u0027encrypted\u0027: False,"},{"line_number":210,"context_line":"                     \u0027target_lun\u0027: 1,"},{"line_number":211,"context_line":"                     \u0027target_wwn\u0027: [\u00271234567890123\u0027, \u00271234567890124\u0027],"},{"line_number":212,"context_line":"                     \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000001\u0027,"},{"line_number":213,"context_line":"                     \u0027ironic_volume_id\u0027:"},{"line_number":214,"context_line":"                     \u002711111111-0000-0000-0000-000000000001\u0027}"},{"line_number":215,"context_line":"                 },"},{"line_number":216,"context_line":"                 {"},{"line_number":217,"context_line":"                 \u0027driver_volume_type\u0027: \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_a04a4252","line":214,"range":{"start_line":212,"start_character":21,"end_line":214,"end_character":59},"updated":"2017-05-16 05:20:12.000000000","message":"example","commit_id":"703b8898e38837519c0aaff6967cf359058ba699"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"66f29c5a1f8aed5ce5b22efd6ea371842c1fc893","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            # NOTE(jtaryma): Actual connection info of already connected"},{"line_number":253,"context_line":"            # volume will be provided by nova. Adding this dictionary to"},{"line_number":254,"context_line":"            # \u0027connected\u0027 list so it contains also already connected volumes."},{"line_number":255,"context_line":"            connection \u003d {\u0027data\u0027: {\u0027ironic_volume_uuid\u0027: volume.id,"},{"line_number":256,"context_line":"                                   \u0027volume_id\u0027: volume_id},"},{"line_number":257,"context_line":"                          \u0027already_attached\u0027: True}"},{"line_number":258,"context_line":"            connected.append(connection)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_e0404a38","line":255,"updated":"2017-05-16 05:20:12.000000000","message":"\u0027ironic_volume_uuid\u0027 is uuid in ironic (see above).","commit_id":"703b8898e38837519c0aaff6967cf359058ba699"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ea04a6baccfe6c2e3c4fd36ecc574dd69d825519","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            # NOTE(jtaryma): Actual connection info of already connected"},{"line_number":253,"context_line":"            # volume will be provided by nova. Adding this dictionary to"},{"line_number":254,"context_line":"            # \u0027connected\u0027 list so it contains also already connected volumes."},{"line_number":255,"context_line":"            connection \u003d {\u0027data\u0027: {\u0027ironic_volume_uuid\u0027: volume.id,"},{"line_number":256,"context_line":"                                   \u0027volume_id\u0027: volume_id},"},{"line_number":257,"context_line":"                          \u0027already_attached\u0027: True}"},{"line_number":258,"context_line":"            connected.append(connection)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_b6e95e1b","line":255,"in_reply_to":"1f013ff3_73abe888","updated":"2017-05-16 13:10:30.000000000","message":"Please make related change in docstring.","commit_id":"703b8898e38837519c0aaff6967cf359058ba699"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6e2fc9f8e3f5d48bc9ddc52bfcce7b626e47900b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            # NOTE(jtaryma): Actual connection info of already connected"},{"line_number":253,"context_line":"            # volume will be provided by nova. Adding this dictionary to"},{"line_number":254,"context_line":"            # \u0027connected\u0027 list so it contains also already connected volumes."},{"line_number":255,"context_line":"            connection \u003d {\u0027data\u0027: {\u0027ironic_volume_uuid\u0027: volume.id,"},{"line_number":256,"context_line":"                                   \u0027volume_id\u0027: volume_id},"},{"line_number":257,"context_line":"                          \u0027already_attached\u0027: True}"},{"line_number":258,"context_line":"            connected.append(connection)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_ee8714d7","line":255,"in_reply_to":"1f013ff3_e0404a38","updated":"2017-05-16 10:45:03.000000000","message":"Yeah, the naming is unfortunate here. volume_id is the id of the cinder volume already? was ironic_volume_uuid intended to be the uuid of the ironic volume target object?","commit_id":"703b8898e38837519c0aaff6967cf359058ba699"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8bc42e0b98c59062ee72a3ccbc04cb5cb45250f4","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            # NOTE(jtaryma): Actual connection info of already connected"},{"line_number":253,"context_line":"            # volume will be provided by nova. Adding this dictionary to"},{"line_number":254,"context_line":"            # \u0027connected\u0027 list so it contains also already connected volumes."},{"line_number":255,"context_line":"            connection \u003d {\u0027data\u0027: {\u0027ironic_volume_uuid\u0027: volume.id,"},{"line_number":256,"context_line":"                                   \u0027volume_id\u0027: volume_id},"},{"line_number":257,"context_line":"                          \u0027already_attached\u0027: True}"},{"line_number":258,"context_line":"            connected.append(connection)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_73abe888","line":255,"in_reply_to":"1f013ff3_ee8714d7","updated":"2017-05-16 12:53:29.000000000","message":"Original intent was to help humans relate, especially if there is not an instance uuid buried in the records.  I _think_ Joanna changed it help track what has been done for reporting back to the caller.","commit_id":"703b8898e38837519c0aaff6967cf359058ba699"}]}
