)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3c24e76a09f81e5327e9d807f454076f7512db04","unresolved":false,"context_lines":[{"line_number":153,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Options to use hardware types"},{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_00aecae6","line":156,"updated":"2017-05-17 12:02:39.000000000","message":"I\u0027d prefer we don\u0027t add this. Also I suspect it\u0027s going to break the IPMI hardware type job.","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5502ec119372886aa1922f52686d93b6e231cc59","unresolved":false,"context_lines":[{"line_number":153,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Options to use hardware types"},{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_5ed00cf8","line":156,"in_reply_to":"ff0f0b1f_00aecae6","updated":"2017-05-18 04:57:37.000000000","message":"++","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":153,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Options to use hardware types"},{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_3e0af825","line":156,"in_reply_to":"ff0f0b1f_00aecae6","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":153,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Options to use hardware types"},{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_1e07341f","line":156,"in_reply_to":"ff0f0b1f_5ed00cf8","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"452efb17311119d5406f9e92a06f34d63f0875c4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"# Options to use hardware types"},{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"},{"line_number":160,"context_line":"# If IRONIC_VM_ENGING is explicitly set to \"auto\" or \"kvm\","},{"line_number":161,"context_line":"# devstack will attempt to use hardware virtualization"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_f9f93a4d","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":52},"updated":"2017-05-18 05:52:38.000000000","message":"You would also need to have variables for management and power interfaces.","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5502ec119372886aa1922f52686d93b6e231cc59","unresolved":false,"context_lines":[{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"},{"line_number":160,"context_line":"# If IRONIC_VM_ENGING is explicitly set to \"auto\" or \"kvm\","},{"line_number":161,"context_line":"# devstack will attempt to use hardware virtualization"},{"line_number":162,"context_line":"# (aka nested kvm). We do not enable it in the infra gates"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_9ee6a4e8","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":46},"updated":"2017-05-18 04:57:37.000000000","message":"I think this is also not required. We can use IRONIC_DEPLOY_DRIVER variable for this purpose as its equivalent.","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":156,"context_line":"IRONIC_USE_HARDWARE_TYPES\u003d$(trueorfalse False IRONIC_USE_HARDWARE_TYPES)"},{"line_number":157,"context_line":"IRONIC_BOOT_INTERFACE\u003d${IRONIC_BOOT_INTERFACE:-}"},{"line_number":158,"context_line":"IRONIC_DEPLOY_INTERFACE\u003d${IRONIC_DEPLOY_INTERFACE:-}"},{"line_number":159,"context_line":"IRONIC_HARDWARE_TYPE\u003d${IRONIC_HARDWARE_TYPE:-}"},{"line_number":160,"context_line":"# If IRONIC_VM_ENGING is explicitly set to \"auto\" or \"kvm\","},{"line_number":161,"context_line":"# devstack will attempt to use hardware virtualization"},{"line_number":162,"context_line":"# (aka nested kvm). We do not enable it in the infra gates"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_fe03600e","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":46},"in_reply_to":"ff0f0b1f_9ee6a4e8","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5502ec119372886aa1922f52686d93b6e231cc59","unresolved":false,"context_lines":[{"line_number":1697,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":1698,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1699,"context_line":"                if [[ $IRONIC_USE_HARDWARE_TYPES \u003d\u003d \"False\" ]]; then"},{"line_number":1700,"context_line":"                    if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" ]]; then"},{"line_number":1701,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1702,"context_line":"                    fi"},{"line_number":1703,"context_line":"                else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_de2adce5","line":1700,"range":{"start_line":1700,"start_character":20,"end_line":1700,"end_character":63},"updated":"2017-05-18 04:57:37.000000000","message":"This check should change to:-\n\nif [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" ]] || [[ $IRONIC_BOOT_INTERFACE !\u003d \"ilo-pxe\" ]] ; then\n   ...","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":1697,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":1698,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1699,"context_line":"                if [[ $IRONIC_USE_HARDWARE_TYPES \u003d\u003d \"False\" ]]; then"},{"line_number":1700,"context_line":"                    if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" ]]; then"},{"line_number":1701,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1702,"context_line":"                    fi"},{"line_number":1703,"context_line":"                else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_d9fe7604","line":1700,"range":{"start_line":1700,"start_character":20,"end_line":1700,"end_character":63},"in_reply_to":"ff0f0b1f_de2adce5","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5502ec119372886aa1922f52686d93b6e231cc59","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"                    if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" ]]; then"},{"line_number":1701,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1702,"context_line":"                    fi"},{"line_number":1703,"context_line":"                else"},{"line_number":1704,"context_line":"                    if [[ $IRONIC_BOOT_INTERFACE !\u003d \"ilo-pxe\" ]]; then"},{"line_number":1705,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1706,"context_line":"                    fi"},{"line_number":1707,"context_line":"                fi"},{"line_number":1708,"context_line":"            elif is_deployed_by_drac; then"},{"line_number":1709,"context_line":"                node_options+\u003d\" -i drac_host\u003d$bmc_address -i drac_password\u003d$bmc_passwd\\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_7e39903f","line":1706,"range":{"start_line":1703,"start_character":15,"end_line":1706,"end_character":22},"updated":"2017-05-18 04:57:37.000000000","message":"This is not required.","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"                    if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" ]]; then"},{"line_number":1701,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1702,"context_line":"                    fi"},{"line_number":1703,"context_line":"                else"},{"line_number":1704,"context_line":"                    if [[ $IRONIC_BOOT_INTERFACE !\u003d \"ilo-pxe\" ]]; then"},{"line_number":1705,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1706,"context_line":"                    fi"},{"line_number":1707,"context_line":"                fi"},{"line_number":1708,"context_line":"            elif is_deployed_by_drac; then"},{"line_number":1709,"context_line":"                node_options+\u003d\" -i drac_host\u003d$bmc_address -i drac_password\u003d$bmc_passwd\\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_b903c20d","line":1706,"range":{"start_line":1703,"start_character":15,"end_line":1706,"end_character":22},"in_reply_to":"ff0f0b1f_7e39903f","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5502ec119372886aa1922f52686d93b6e231cc59","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        fi"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"        local node_id"},{"line_number":1724,"context_line":"        if [[ $IRONIC_USE_HARDWARE_TYPES \u003d\u003d \"False\" ]]; then"},{"line_number":1725,"context_line":"            node_id\u003d$(ironic \\"},{"line_number":1726,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1727,"context_line":"            --chassis_uuid $chassis_id \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_7e12b0b3","line":1724,"range":{"start_line":1724,"start_character":8,"end_line":1724,"end_character":60},"updated":"2017-05-18 04:57:37.000000000","message":"This check is not required.","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        fi"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"        local node_id"},{"line_number":1724,"context_line":"        if [[ $IRONIC_USE_HARDWARE_TYPES \u003d\u003d \"False\" ]]; then"},{"line_number":1725,"context_line":"            node_id\u003d$(ironic \\"},{"line_number":1726,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1727,"context_line":"            --chassis_uuid $chassis_id \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_f9181a76","line":1724,"range":{"start_line":1724,"start_character":8,"end_line":1724,"end_character":60},"in_reply_to":"ff0f0b1f_7e12b0b3","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5502ec119372886aa1922f52686d93b6e231cc59","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            $node_capabilities \\"},{"line_number":1735,"context_line":"            $node_options \\"},{"line_number":1736,"context_line":"            | grep \" uuid \" | get_field 2)"},{"line_number":1737,"context_line":"        else"},{"line_number":1738,"context_line":"            node_id\u003d$(ironic \\"},{"line_number":1739,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1740,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1741,"context_line":"            --driver $IRONIC_HARDWARE_TYPE \\"},{"line_number":1742,"context_line":"            --boot-interface $IRONIC_BOOT_INTERFACE \\"},{"line_number":1743,"context_line":"            --deploy-interface $IRONIC_DEPLOY_INTERFACE \\"},{"line_number":1744,"context_line":"            --name $node_name \\"},{"line_number":1745,"context_line":"            -p cpus\u003d$ironic_node_cpu\\"},{"line_number":1746,"context_line":"            -p memory_mb\u003d$ironic_node_ram\\"},{"line_number":1747,"context_line":"            -p local_gb\u003d$ironic_node_disk\\"},{"line_number":1748,"context_line":"            -p cpu_arch\u003d$ironic_node_arch \\"},{"line_number":1749,"context_line":"            $node_capabilities \\"},{"line_number":1750,"context_line":"            $node_options \\"},{"line_number":1751,"context_line":"            | grep \" uuid \" | get_field 2)"},{"line_number":1752,"context_line":"        fi"},{"line_number":1753,"context_line":"        # NOTE(vsaienko) IPA didn\u0027t automatically recognize root devices less than 4Gb."},{"line_number":1754,"context_line":"        # Setting root hint allows to install OS on such devices."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_fe4480b9","line":1751,"range":{"start_line":1737,"start_character":8,"end_line":1751,"end_character":42},"updated":"2017-05-18 04:57:37.000000000","message":"This is not required as it would use the enabled deploy and boot interfaces related to the hardware type specified in the IRONIC_DEPLOY_DRIVER","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            $node_capabilities \\"},{"line_number":1735,"context_line":"            $node_options \\"},{"line_number":1736,"context_line":"            | grep \" uuid \" | get_field 2)"},{"line_number":1737,"context_line":"        else"},{"line_number":1738,"context_line":"            node_id\u003d$(ironic \\"},{"line_number":1739,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1740,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1741,"context_line":"            --driver $IRONIC_HARDWARE_TYPE \\"},{"line_number":1742,"context_line":"            --boot-interface $IRONIC_BOOT_INTERFACE \\"},{"line_number":1743,"context_line":"            --deploy-interface $IRONIC_DEPLOY_INTERFACE \\"},{"line_number":1744,"context_line":"            --name $node_name \\"},{"line_number":1745,"context_line":"            -p cpus\u003d$ironic_node_cpu\\"},{"line_number":1746,"context_line":"            -p memory_mb\u003d$ironic_node_ram\\"},{"line_number":1747,"context_line":"            -p local_gb\u003d$ironic_node_disk\\"},{"line_number":1748,"context_line":"            -p cpu_arch\u003d$ironic_node_arch \\"},{"line_number":1749,"context_line":"            $node_capabilities \\"},{"line_number":1750,"context_line":"            $node_options \\"},{"line_number":1751,"context_line":"            | grep \" uuid \" | get_field 2)"},{"line_number":1752,"context_line":"        fi"},{"line_number":1753,"context_line":"        # NOTE(vsaienko) IPA didn\u0027t automatically recognize root devices less than 4Gb."},{"line_number":1754,"context_line":"        # Setting root hint allows to install OS on such devices."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_b92ce299","line":1751,"range":{"start_line":1737,"start_character":8,"end_line":1751,"end_character":42},"in_reply_to":"ff0f0b1f_fe4480b9","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3c24e76a09f81e5327e9d807f454076f7512db04","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"    fi"},{"line_number":2201,"context_line":""},{"line_number":2202,"context_line":"    iniset $TEMPEST_CONFIG baremetal enabled_drivers $IRONIC_ENABLED_DRIVERS"},{"line_number":2203,"context_line":"    if [[ \"$IRONIC_USE_HARDWARE_TYPES\" \u003d\u003d \"True\" ]]; then"},{"line_number":2204,"context_line":"        iniset $TEMPEST_CONFIG baremetal enabled_hardware_types $IRONIC_ENABLED_HARDWARE_TYPES"},{"line_number":2205,"context_line":"        iniset $TEMPEST_CONFIG baremetal enabled_boot_interfaces $IRONIC_BOOT_INTERFACE"},{"line_number":2206,"context_line":"        iniset $TEMPEST_CONFIG baremetal enabled_deploy_interfaces $IRONIC_DEPLOY_INTERFACE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_e0aab6d0","line":2203,"updated":"2017-05-17 12:02:39.000000000","message":"ditto about IPMI job","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"75675e2256317f2dc21f2313d9e11c81040c8563","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"    fi"},{"line_number":2201,"context_line":""},{"line_number":2202,"context_line":"    iniset $TEMPEST_CONFIG baremetal enabled_drivers $IRONIC_ENABLED_DRIVERS"},{"line_number":2203,"context_line":"    if [[ \"$IRONIC_USE_HARDWARE_TYPES\" \u003d\u003d \"True\" ]]; then"},{"line_number":2204,"context_line":"        iniset $TEMPEST_CONFIG baremetal enabled_hardware_types $IRONIC_ENABLED_HARDWARE_TYPES"},{"line_number":2205,"context_line":"        iniset $TEMPEST_CONFIG baremetal enabled_boot_interfaces $IRONIC_BOOT_INTERFACE"},{"line_number":2206,"context_line":"        iniset $TEMPEST_CONFIG baremetal enabled_deploy_interfaces $IRONIC_DEPLOY_INTERFACE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_99211ea3","line":2203,"in_reply_to":"ff0f0b1f_e0aab6d0","updated":"2017-05-18 06:24:15.000000000","message":"Done","commit_id":"0b2e9964f956fb46a63da3dd63693c7f70d6705f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"00d66902ebcbeb19d39ceb615d33dc7aedef5203","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces $IRONIC_ENABLED_POWER_INTERFACES"},{"line_number":1145,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT default_power_interface $IRONIC_DEFAULT_POWER_INTERFACE"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1148,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1149,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1150,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"redfish\""},{"line_number":1151,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"redfish\""},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT rootwrap_config $IRONIC_ROOTWRAP_CONF"},{"line_number":1155,"context_line":"    iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff0f0b1f_dfe653e9","line":1152,"range":{"start_line":1147,"start_character":4,"end_line":1152,"end_character":6},"updated":"2017-05-18 08:37:54.000000000","message":"This block should get removed and redfish CI gate should set following into their local.conf\nIRONIC_ENABLED_MANAGEMENT_INTERFACES \u003d \u0027redfish\u0027\nIRONIC_DEFAULT_MANAGEMENT_INTERFACE \u003d\u0027redfish\u0027\nIRONIC_ENABLED_POWER_INTERFACES \u003d\u0027redfish\u0027\nIRONIC_DEFAULT_POWER_INTERFACE \u003d \u0027redfish\u0027","commit_id":"9b30e50a192aa7d530383f4330844c7cfedb07b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"43fa761a538518ea349cb975e41292a1488bbd43","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces $IRONIC_ENABLED_POWER_INTERFACES"},{"line_number":1145,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT default_power_interface $IRONIC_DEFAULT_POWER_INTERFACE"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1148,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1149,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1150,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"redfish\""},{"line_number":1151,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"redfish\""},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT rootwrap_config $IRONIC_ROOTWRAP_CONF"},{"line_number":1155,"context_line":"    iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff0f0b1f_50047017","line":1152,"range":{"start_line":1147,"start_character":4,"end_line":1152,"end_character":6},"in_reply_to":"ff0f0b1f_45195077","updated":"2017-05-18 10:12:02.000000000","message":"-1 to removing this block, let\u0027s not overload project-config with too many details. also we should not set defaults, this is not required, and may cause problems if people enable more hardware types.","commit_id":"9b30e50a192aa7d530383f4330844c7cfedb07b6"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c0621e0fe5f97040be9c3a4e932ac9b36be06173","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces $IRONIC_ENABLED_POWER_INTERFACES"},{"line_number":1145,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT default_power_interface $IRONIC_DEFAULT_POWER_INTERFACE"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1148,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1149,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1150,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"redfish\""},{"line_number":1151,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"redfish\""},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT rootwrap_config $IRONIC_ROOTWRAP_CONF"},{"line_number":1155,"context_line":"    iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff0f0b1f_9c41e50e","line":1152,"range":{"start_line":1147,"start_character":4,"end_line":1152,"end_character":6},"in_reply_to":"ff0f0b1f_50047017","updated":"2017-05-19 05:59:22.000000000","message":"Done","commit_id":"9b30e50a192aa7d530383f4330844c7cfedb07b6"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"3c5f281d3455e01c75dfe111d1b7f2f44e9a24d7","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces $IRONIC_ENABLED_POWER_INTERFACES"},{"line_number":1145,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT default_power_interface $IRONIC_DEFAULT_POWER_INTERFACE"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1148,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1149,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1150,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"redfish\""},{"line_number":1151,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"redfish\""},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT rootwrap_config $IRONIC_ROOTWRAP_CONF"},{"line_number":1155,"context_line":"    iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff0f0b1f_45195077","line":1152,"range":{"start_line":1147,"start_character":4,"end_line":1152,"end_character":6},"in_reply_to":"ff0f0b1f_dfe653e9","updated":"2017-05-18 09:19:49.000000000","message":"For now I set it here, once it will merged need to set in openstack-infra/project-config.","commit_id":"9b30e50a192aa7d530383f4330844c7cfedb07b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5e1ed7809b300f94bb6e4e5688e489430bc22541","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                node_capabilities+\u003d\"server_profile_template_uri:$server_profile_template_uri\""},{"line_number":1681,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1682,"context_line":"                if [[ -n $IRONIC_ENABLED_BOOT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_DEPLOY_INTERFACES \u0026\u0026\\"},{"line_number":1683,"context_line":"                   -n $IRONIC_ENABLED_MANAGEMENT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_POWER_INTERFACES ]]; then"},{"line_number":1684,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces $IRONIC_ENABLED_BOOT_INTERFACES"},{"line_number":1685,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces $IRONIC_ENABLED_DEPLOY_INTERFACES"},{"line_number":1686,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces $IRONIC_ENABLED_MANAGEMENT_INTERFACES"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ff0f0b1f_82cf37af","line":1683,"updated":"2017-05-19 09:30:03.000000000","message":"let\u0027s split these conditions. each of these options can be set separately","commit_id":"32f41216424d137dcb30119592e4374f6bbfd0ca"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"4b2f42a0e724684752611586a689167710bf0a1f","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                node_capabilities+\u003d\"server_profile_template_uri:$server_profile_template_uri\""},{"line_number":1681,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1682,"context_line":"                if [[ -n $IRONIC_ENABLED_BOOT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_DEPLOY_INTERFACES \u0026\u0026\\"},{"line_number":1683,"context_line":"                   -n $IRONIC_ENABLED_MANAGEMENT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_POWER_INTERFACES ]]; then"},{"line_number":1684,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces $IRONIC_ENABLED_BOOT_INTERFACES"},{"line_number":1685,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces $IRONIC_ENABLED_DEPLOY_INTERFACES"},{"line_number":1686,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces $IRONIC_ENABLED_MANAGEMENT_INTERFACES"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ff0f0b1f_132c7100","line":1683,"in_reply_to":"ff0f0b1f_19102001","updated":"2017-05-22 05:24:53.000000000","message":"Done","commit_id":"32f41216424d137dcb30119592e4374f6bbfd0ca"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"4b2f42a0e724684752611586a689167710bf0a1f","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                node_capabilities+\u003d\"server_profile_template_uri:$server_profile_template_uri\""},{"line_number":1681,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1682,"context_line":"                if [[ -n $IRONIC_ENABLED_BOOT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_DEPLOY_INTERFACES \u0026\u0026\\"},{"line_number":1683,"context_line":"                   -n $IRONIC_ENABLED_MANAGEMENT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_POWER_INTERFACES ]]; then"},{"line_number":1684,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces $IRONIC_ENABLED_BOOT_INTERFACES"},{"line_number":1685,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces $IRONIC_ENABLED_DEPLOY_INTERFACES"},{"line_number":1686,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces $IRONIC_ENABLED_MANAGEMENT_INTERFACES"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ff0f0b1f_33ef75b1","line":1683,"in_reply_to":"ff0f0b1f_82cf37af","updated":"2017-05-22 05:24:53.000000000","message":"Done","commit_id":"32f41216424d137dcb30119592e4374f6bbfd0ca"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0cf3537d1319d7d0ef5343394fc60d755381c607","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                node_capabilities+\u003d\"server_profile_template_uri:$server_profile_template_uri\""},{"line_number":1681,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1682,"context_line":"                if [[ -n $IRONIC_ENABLED_BOOT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_DEPLOY_INTERFACES \u0026\u0026\\"},{"line_number":1683,"context_line":"                   -n $IRONIC_ENABLED_MANAGEMENT_INTERFACES \u0026\u0026 -n $IRONIC_ENABLED_POWER_INTERFACES ]]; then"},{"line_number":1684,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces $IRONIC_ENABLED_BOOT_INTERFACES"},{"line_number":1685,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces $IRONIC_ENABLED_DEPLOY_INTERFACES"},{"line_number":1686,"context_line":"                    iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces $IRONIC_ENABLED_MANAGEMENT_INTERFACES"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ff0f0b1f_19102001","line":1683,"in_reply_to":"ff0f0b1f_82cf37af","updated":"2017-05-20 18:55:24.000000000","message":"My second question is, why don\u0027t we do it always, not just for ilo? If there are no hardware types enabled, these options will basically get ignored anyway.","commit_id":"32f41216424d137dcb30119592e4374f6bbfd0ca"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"707f0d51d83b40e799b842eb16b642011e4156d9","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# driver / hardware type options"},{"line_number":151,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ipmitool,agent_ipmitool}"},{"line_number":152,"context_line":"# TODO(jroll) add enabled/default interfaces here"},{"line_number":153,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":154,"context_line":"IRONIC_ENABLED_BOOT_INTERFACES\u003d${IRONIC_ENABLED_BOOT_INTERFACES:-}"},{"line_number":155,"context_line":"IRONIC_ENABLED_DEPLOY_INTERFACES\u003d${IRONIC_ENABLED_DEPLOY_INTERFACES:-}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ff0f0b1f_cb26a7bb","line":152,"updated":"2017-05-26 01:11:20.000000000","message":"there\u0027s a TODO here, and you added a few, but not all of the interfaces. Why not just do it all in this patch?","commit_id":"e0bc87b9ae596accd00fb398cd5bd9076cfd9398"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"6dd9bdbf02dca8c3c6c3a50c6787c91c9d103864","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# driver / hardware type options"},{"line_number":151,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ipmitool,agent_ipmitool}"},{"line_number":152,"context_line":"# TODO(jroll) add enabled/default interfaces here"},{"line_number":153,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":154,"context_line":"IRONIC_ENABLED_BOOT_INTERFACES\u003d${IRONIC_ENABLED_BOOT_INTERFACES:-}"},{"line_number":155,"context_line":"IRONIC_ENABLED_DEPLOY_INTERFACES\u003d${IRONIC_ENABLED_DEPLOY_INTERFACES:-}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"df140735_f12de3a8","line":152,"in_reply_to":"ff0f0b1f_cb26a7bb","updated":"2017-05-29 05:51:11.000000000","message":"Done","commit_id":"e0bc87b9ae596accd00fb398cd5bd9076cfd9398"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"90eb3f5f6cf3185332953ff3f4fc8e50d379bec0","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"    fi"},{"line_number":1133,"context_line":"    if [[ -n $IRONIC_ENABLED_POWER_INTERFACES ]]; then"},{"line_number":1134,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces $IRONIC_ENABLED_POWER_INTERFACES"},{"line_number":1135,"context_line":"    fi"},{"line_number":1136,"context_line":""},{"line_number":1137,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1138,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ff0f0b1f_1855a81d","line":1135,"updated":"2017-05-22 10:50:21.000000000","message":"I guess we could have a simple helper function to reduce the amount of copy-pasting here..","commit_id":"e0bc87b9ae596accd00fb398cd5bd9076cfd9398"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"6dd9bdbf02dca8c3c6c3a50c6787c91c9d103864","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"    fi"},{"line_number":1133,"context_line":"    if [[ -n $IRONIC_ENABLED_POWER_INTERFACES ]]; then"},{"line_number":1134,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces $IRONIC_ENABLED_POWER_INTERFACES"},{"line_number":1135,"context_line":"    fi"},{"line_number":1136,"context_line":""},{"line_number":1137,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1138,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"df140735_112177b5","line":1135,"in_reply_to":"ff0f0b1f_1855a81d","updated":"2017-05-29 05:51:11.000000000","message":"Done","commit_id":"e0bc87b9ae596accd00fb398cd5bd9076cfd9398"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7047ca9666ba625e629e36ad2c9a82e54ee0c450","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    return 1"},{"line_number":568,"context_line":"}"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"function set_hardware_type {"},{"line_number":571,"context_line":"    local interface_name\u003d$1"},{"line_number":572,"context_line":"    local interface_value\u003d$2"},{"line_number":573,"context_line":"    if [[ -n $interface_value ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"df140735_076374de","line":570,"updated":"2017-05-29 07:34:59.000000000","message":"I\u0027d call this \"configure_enabled_interfaces\"","commit_id":"a1f601d93d5f9115242f9581e6ba151095bc8816"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"0a971431f89e753c9cfde11922370232bc8df359","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    return 1"},{"line_number":568,"context_line":"}"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"function set_hardware_type {"},{"line_number":571,"context_line":"    local interface_name\u003d$1"},{"line_number":572,"context_line":"    local interface_value\u003d$2"},{"line_number":573,"context_line":"    if [[ -n $interface_value ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"df140735_30523069","line":570,"in_reply_to":"df140735_076374de","updated":"2017-05-29 09:56:24.000000000","message":"Done","commit_id":"a1f601d93d5f9115242f9581e6ba151095bc8816"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7047ca9666ba625e629e36ad2c9a82e54ee0c450","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"function set_hardware_type {"},{"line_number":571,"context_line":"    local interface_name\u003d$1"},{"line_number":572,"context_line":"    local interface_value\u003d$2"},{"line_number":573,"context_line":"    if [[ -n $interface_value ]]; then"},{"line_number":574,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT $interface_name $interface_value"},{"line_number":575,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"df140735_e75f600c","line":572,"updated":"2017-05-29 07:34:59.000000000","message":"s/value/implementations/","commit_id":"a1f601d93d5f9115242f9581e6ba151095bc8816"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"0a971431f89e753c9cfde11922370232bc8df359","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"function set_hardware_type {"},{"line_number":571,"context_line":"    local interface_name\u003d$1"},{"line_number":572,"context_line":"    local interface_value\u003d$2"},{"line_number":573,"context_line":"    if [[ -n $interface_value ]]; then"},{"line_number":574,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT $interface_name $interface_value"},{"line_number":575,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"df140735_50da44e9","line":572,"in_reply_to":"df140735_e75f600c","updated":"2017-05-29 09:56:24.000000000","message":"Done","commit_id":"a1f601d93d5f9115242f9581e6ba151095bc8816"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7047ca9666ba625e629e36ad2c9a82e54ee0c450","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    local interface_name\u003d$1"},{"line_number":572,"context_line":"    local interface_value\u003d$2"},{"line_number":573,"context_line":"    if [[ -n $interface_value ]]; then"},{"line_number":574,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT $interface_name $interface_value"},{"line_number":575,"context_line":"    fi"},{"line_number":576,"context_line":"}"},{"line_number":577,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"df140735_c79a1cc4","line":574,"updated":"2017-05-29 07:34:59.000000000","message":"nit: you can simplify using this function, if you do something like enabled_${interface_name}_interfaces, and then use only pass \"deploy\", \"boot\", etc","commit_id":"a1f601d93d5f9115242f9581e6ba151095bc8816"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"0a971431f89e753c9cfde11922370232bc8df359","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    local interface_name\u003d$1"},{"line_number":572,"context_line":"    local interface_value\u003d$2"},{"line_number":573,"context_line":"    if [[ -n $interface_value ]]; then"},{"line_number":574,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT $interface_name $interface_value"},{"line_number":575,"context_line":"    fi"},{"line_number":576,"context_line":"}"},{"line_number":577,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"df140735_50036443","line":574,"in_reply_to":"df140735_c79a1cc4","updated":"2017-05-29 09:56:24.000000000","message":"Done","commit_id":"a1f601d93d5f9115242f9581e6ba151095bc8816"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a359b9f4071cf8ad9e1610ab5487ac17e7fff8b9","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# driver / hardware type options"},{"line_number":151,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ipmitool,agent_ipmitool}"},{"line_number":152,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":153,"context_line":"IRONIC_ENABLED_BOOT_INTERFACES\u003d${IRONIC_ENABLED_BOOT_INTERFACES:-}"},{"line_number":154,"context_line":"IRONIC_ENABLED_DEPLOY_INTERFACES\u003d${IRONIC_ENABLED_DEPLOY_INTERFACES:-}"},{"line_number":155,"context_line":"IRONIC_ENABLED_MANAGEMENT_INTERFACES\u003d${IRONIC_ENABLED_MANAGEMENT_INTERFACES:-}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_8682dd4e","line":152,"updated":"2017-05-29 14:37:21.000000000","message":"The TODO from jroll mentioned adding enabled and default interfaces. Should we keep the TODO, to remind us that we want to add default interfaces?","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"4fa3bfd6c8d3b2803dd24763a2c26d75cdbd9e69","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# driver / hardware type options"},{"line_number":151,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ipmitool,agent_ipmitool}"},{"line_number":152,"context_line":"IRONIC_ENABLED_HARDWARE_TYPES\u003d${IRONIC_ENABLED_HARDWARE_TYPES:-ipmi}"},{"line_number":153,"context_line":"IRONIC_ENABLED_BOOT_INTERFACES\u003d${IRONIC_ENABLED_BOOT_INTERFACES:-}"},{"line_number":154,"context_line":"IRONIC_ENABLED_DEPLOY_INTERFACES\u003d${IRONIC_ENABLED_DEPLOY_INTERFACES:-}"},{"line_number":155,"context_line":"IRONIC_ENABLED_MANAGEMENT_INTERFACES\u003d${IRONIC_ENABLED_MANAGEMENT_INTERFACES:-}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_89ae652c","line":152,"in_reply_to":"df140735_8682dd4e","updated":"2017-05-30 04:42:48.000000000","message":"i included, storage and network too, I guess now we dont need todo","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a359b9f4071cf8ad9e1610ab5487ac17e7fff8b9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"IRONIC_ENABLED_CONSOLE_INTERFACES\u003d${IRONIC_ENABLED_CONSOLE_INTERFACES:-}"},{"line_number":158,"context_line":"IRONIC_ENABLED_INSPECT_INTERFACES\u003d${IRONIC_ENABLED_INSPECT_INTERFACES:-}"},{"line_number":159,"context_line":"IRONIC_ENABLED_RAID_INTERFACES\u003d${IRONIC_ENABLED_RAID_INTERFACES:-}"},{"line_number":160,"context_line":"IRONIC_ENABLED_VENDOR_INTERFACES\u003d${IRONIC_ENABLED_VENDOR_INTERFACES:-}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# If IRONIC_VM_ENGING is explicitly set to \"auto\" or \"kvm\","},{"line_number":163,"context_line":"# devstack will attempt to use hardware virtualization"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_06180d1b","line":160,"updated":"2017-05-29 14:37:21.000000000","message":"what about storage? If you don\u0027t add it, we need the TODO still.","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"4fa3bfd6c8d3b2803dd24763a2c26d75cdbd9e69","unresolved":false,"context_lines":[{"line_number":157,"context_line":"IRONIC_ENABLED_CONSOLE_INTERFACES\u003d${IRONIC_ENABLED_CONSOLE_INTERFACES:-}"},{"line_number":158,"context_line":"IRONIC_ENABLED_INSPECT_INTERFACES\u003d${IRONIC_ENABLED_INSPECT_INTERFACES:-}"},{"line_number":159,"context_line":"IRONIC_ENABLED_RAID_INTERFACES\u003d${IRONIC_ENABLED_RAID_INTERFACES:-}"},{"line_number":160,"context_line":"IRONIC_ENABLED_VENDOR_INTERFACES\u003d${IRONIC_ENABLED_VENDOR_INTERFACES:-}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# If IRONIC_VM_ENGING is explicitly set to \"auto\" or \"kvm\","},{"line_number":163,"context_line":"# devstack will attempt to use hardware virtualization"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_a9b12992","line":160,"in_reply_to":"df140735_06180d1b","updated":"2017-05-30 04:42:48.000000000","message":"Done","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a359b9f4071cf8ad9e1610ab5487ac17e7fff8b9","unresolved":false,"context_lines":[{"line_number":343,"context_line":"IRONIC_DHCP_PROVIDER\u003d${IRONIC_DHCP_PROVIDER:-neutron}"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"# This flag is used to specify enabled network drivers"},{"line_number":346,"context_line":"IRONIC_ENABLED_NETWORK_INTERFACES\u003d${IRONIC_ENABLED_NETWORK_INTERFACES:-}"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"# This is the network interface to use for a node"},{"line_number":349,"context_line":"IRONIC_NETWORK_INTERFACE\u003d${IRONIC_NETWORK_INTERFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_06ffedaa","line":346,"updated":"2017-05-29 14:37:21.000000000","message":"Would it be good to have this above, with the other enabled interfaces?","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"4fa3bfd6c8d3b2803dd24763a2c26d75cdbd9e69","unresolved":false,"context_lines":[{"line_number":343,"context_line":"IRONIC_DHCP_PROVIDER\u003d${IRONIC_DHCP_PROVIDER:-neutron}"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"# This flag is used to specify enabled network drivers"},{"line_number":346,"context_line":"IRONIC_ENABLED_NETWORK_INTERFACES\u003d${IRONIC_ENABLED_NETWORK_INTERFACES:-}"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"# This is the network interface to use for a node"},{"line_number":349,"context_line":"IRONIC_NETWORK_INTERFACE\u003d${IRONIC_NETWORK_INTERFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_29be3965","line":346,"in_reply_to":"df140735_06ffedaa","updated":"2017-05-30 04:42:48.000000000","message":"Done","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a359b9f4071cf8ad9e1610ab5487ac17e7fff8b9","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"        iniset $IRONIC_CONF_FILE neutron port_setup_delay 15"},{"line_number":1238,"context_line":"    fi"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"    if [[ -n \"$IRONIC_ENABLED_NETWORK_INTERFACES\" ]]; then"},{"line_number":1241,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces $IRONIC_ENABLED_NETWORK_INTERFACES"},{"line_number":1242,"context_line":"    fi"},{"line_number":1243,"context_line":"    iniset $IRONIC_CONF_FILE dhcp dhcp_provider $IRONIC_DHCP_PROVIDER"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_667d891b","line":1240,"updated":"2017-05-29 14:37:21.000000000","message":"ditto","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"4fa3bfd6c8d3b2803dd24763a2c26d75cdbd9e69","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"        iniset $IRONIC_CONF_FILE neutron port_setup_delay 15"},{"line_number":1238,"context_line":"    fi"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"    if [[ -n \"$IRONIC_ENABLED_NETWORK_INTERFACES\" ]]; then"},{"line_number":1241,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces $IRONIC_ENABLED_NETWORK_INTERFACES"},{"line_number":1242,"context_line":"    fi"},{"line_number":1243,"context_line":"    iniset $IRONIC_CONF_FILE dhcp dhcp_provider $IRONIC_DHCP_PROVIDER"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"df140735_498f2dcc","line":1240,"in_reply_to":"df140735_667d891b","updated":"2017-05-30 04:42:48.000000000","message":"Done","commit_id":"b619f8dc24e3c0989b95aff319353637b6f9c01e"}]}