)]}'
{"install-guide/source/enabling-drivers.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    [DEFAULT]"},{"line_number":172,"context_line":"    enabled_hardware_types \u003d ipmi"},{"line_number":173,"context_line":"    enabled_deploy_interfaces \u003d agent"},{"line_number":174,"context_line":"    enabled_boot_interfaces \u003d ipmitool"},{"line_number":175,"context_line":"    enabled_management_interfaces \u003d ipmitool"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_03ca8619","line":173,"range":{"start_line":173,"start_character":4,"end_line":173,"end_character":26},"updated":"2017-05-24 11:16:02.000000000","message":"nit:\ns/ \u0027agent\u0027 / \u0027direct\u0027 /","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    [DEFAULT]"},{"line_number":172,"context_line":"    enabled_hardware_types \u003d ipmi"},{"line_number":173,"context_line":"    enabled_deploy_interfaces \u003d agent"},{"line_number":174,"context_line":"    enabled_boot_interfaces \u003d ipmitool"},{"line_number":175,"context_line":"    enabled_management_interfaces \u003d ipmitool"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_838b36c1","line":174,"range":{"start_line":174,"start_character":30,"end_line":174,"end_character":38},"updated":"2017-05-24 11:16:02.000000000","message":"nit:\ns/ \u0027ipmitool\u0027 / \u0027pxe\u0027 /\nOr may be you mean \u0027enabled_power_interfaces\u0027","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    [DEFAULT]"},{"line_number":180,"context_line":"    enabled_hardware_types \u003d redfish"},{"line_number":181,"context_line":"    enabled_deploy_interfaces \u003d iscsi"},{"line_number":182,"context_line":"    enabled_boot_interfaces \u003d redfish"},{"line_number":183,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"But you cannot have two conductors with the following configuration:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_03c166e5","line":182,"range":{"start_line":182,"start_character":30,"end_line":182,"end_character":37},"updated":"2017-05-24 11:16:02.000000000","message":"nit:\ns/ \u0027redfish\u0027 / \u0027pxe\u0027 /\nOr may be you mean \u0027enabled_power_interfaces\u0027","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    [DEFAULT]"},{"line_number":190,"context_line":"    enabled_hardware_types \u003d ipmi,redfish"},{"line_number":191,"context_line":"    enabled_deploy_interfaces \u003d agent"},{"line_number":192,"context_line":"    enabled_boot_interfaces \u003d ipmitool"},{"line_number":193,"context_line":"    enabled_management_interfaces \u003d ipmitool"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_43aabe18","line":191,"range":{"start_line":191,"start_character":32,"end_line":191,"end_character":37},"updated":"2017-05-24 11:16:02.000000000","message":"ditto","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    [DEFAULT]"},{"line_number":190,"context_line":"    enabled_hardware_types \u003d ipmi,redfish"},{"line_number":191,"context_line":"    enabled_deploy_interfaces \u003d agent"},{"line_number":192,"context_line":"    enabled_boot_interfaces \u003d ipmitool"},{"line_number":193,"context_line":"    enabled_management_interfaces \u003d ipmitool"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_c3b6ce8a","line":192,"range":{"start_line":192,"start_character":30,"end_line":192,"end_character":38},"updated":"2017-05-24 11:16:02.000000000","message":"ditto","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    [DEFAULT]"},{"line_number":198,"context_line":"    enabled_hardware_types \u003d redfish"},{"line_number":199,"context_line":"    enabled_deploy_interfaces \u003d iscsi"},{"line_number":200,"context_line":"    enabled_boot_interfaces \u003d redfish"},{"line_number":201,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_437f5eaa","line":200,"range":{"start_line":200,"start_character":30,"end_line":200,"end_character":37},"updated":"2017-05-24 11:16:02.000000000","message":"ditto","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"When configuring hardware types and their interfaces, make sure that for"},{"line_number":163,"context_line":"every enabled hardware type, the whole set of enable interfaces matches for"},{"line_number":164,"context_line":"all conductors. Different conductors can, however, have different hardware"},{"line_number":165,"context_line":"types enabled."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_c747f376","line":163,"updated":"2017-05-24 15:10:06.000000000","message":"nit: s/enable/enabled","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"When configuring hardware types and their interfaces, make sure that for"},{"line_number":163,"context_line":"every enabled hardware type, the whole set of enable interfaces matches for"},{"line_number":164,"context_line":"all conductors. Different conductors can, however, have different hardware"},{"line_number":165,"context_line":"types enabled."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"For example, you can have two conductors with the following configuration:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_4753e339","line":164,"updated":"2017-05-24 15:10:06.000000000","message":"\"However, different conductors can...\" would flow better","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"},{"line_number":207,"context_line":"can cause inconsistent behavior in the API, when node functionality will"},{"line_number":208,"context_line":"depend on which conductor it gets assigned to."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Configuring interface defaults"},{"line_number":211,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_aab16649","line":208,"updated":"2017-05-24 15:10:06.000000000","message":"Do we want to mention that the lack of this detection is intentional so upgrades can happen?","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    default_network_interface \u003d neutron"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"This configuration forces the default *deploy* interface to be ``direct`` and"},{"line_number":226,"context_line":"the default *network* interface to be ``neutron``."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":".. warning::"},{"line_number":229,"context_line":"   The default interface implementation has to be configured the same way"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_4ab2ca4a","line":226,"updated":"2017-05-24 15:10:06.000000000","message":"maybe add \"for all hardware types\" at the end?","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":228,"context_line":".. warning::"},{"line_number":229,"context_line":"   The default interface implementation has to be configured the same way"},{"line_number":230,"context_line":"   across all conductors in the cloud, except maybe for a short period of time"},{"line_number":231,"context_line":"   during an upgrade or configuration update."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":".. warning::"},{"line_number":234,"context_line":"   These options should be used with care. If a hardware type does not"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_6a90ee95","line":231,"updated":"2017-05-24 15:10:06.000000000","message":"Ah, I see you\u0027ve done it here, maybe still add it above though.","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":234,"context_line":"   These options should be used with care. If a hardware type does not"},{"line_number":235,"context_line":"   support the provided default implementation, its users will have to always"},{"line_number":236,"context_line":"   provide an explicit value for this interface when creating a node."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Enabling classic drivers"},{"line_number":239,"context_line":"------------------------"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_aac846a5","line":237,"updated":"2017-05-24 15:10:06.000000000","message":"We should probably mention that defaults are calculated at the time the hardware type is changed (or is it only at node create time?). Just changing default_foo_interface won\u0027t have an impact on existing nodes.","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e6b170c89bd561503a5ccf4e87f87b05e2a4a2fa","unresolved":false,"context_lines":[{"line_number":187,"context_line":".. code-block:: ini"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    [DEFAULT]"},{"line_number":190,"context_line":"    enabled_hardware_types \u003d ipmi,redfish"},{"line_number":191,"context_line":"    enabled_deploy_interfaces \u003d direct"},{"line_number":192,"context_line":"    enabled_power_interfaces \u003d ipmitool"},{"line_number":193,"context_line":"    enabled_management_interfaces \u003d ipmitool"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_365dbf14","line":190,"range":{"start_line":190,"start_character":34,"end_line":190,"end_character":41},"updated":"2017-05-24 17:13:00.000000000","message":"I wonder if conductor will actually start with this, redfish only supports redfish power and management, but only ipmitool is enabled","commit_id":"6a306dbc05e86199fd6a0ffdd84cfd9062bf2985"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Enabling drivers and hardware types"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Introduction"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_ce6b6383","line":1,"updated":"2017-05-25 18:52:21.000000000","message":"Is it too late to change this to \u0027Enabling hardware types and drivers\u0027 ? :-)","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be assigned to the ``driver`` field of a node. However, they are configured"},{"line_number":26,"context_line":"differently."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Enabling hardware types"},{"line_number":29,"context_line":"-----------------------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Hardware types are enabled in the configuration file of the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_ee1ce714","line":28,"updated":"2017-05-25 18:52:21.000000000","message":"maybe \u0027Enabling hardware types and hardware interfaces\u0027 ?","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be assigned to the ``driver`` field of a node. However, they are configured"},{"line_number":26,"context_line":"differently."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Enabling hardware types"},{"line_number":29,"context_line":"-----------------------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Hardware types are enabled in the configuration file of the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_05a598b5","line":28,"in_reply_to":"ff0f0b1f_ee1ce714","updated":"2017-05-26 15:07:07.000000000","message":"I\u0027d prefer not to change titles, as it\u0027ll break the links. Also, I feel like we\u0027re configuring the hardware types, and enable hardware interfaces is just one part of it.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Configuring interfaces in multi-conductor environments"},{"line_number":160,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"When configuring hardware types and their interfaces, make sure that for"},{"line_number":163,"context_line":"every enabled hardware type, the whole set of enabled interfaces matches for"},{"line_number":164,"context_line":"all conductors. However, different conductors can have different hardware"},{"line_number":165,"context_line":"types enabled."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_2eb9bfe8","line":162,"updated":"2017-05-25 18:52:21.000000000","message":"dumb question. What do you mean by \u0027configuring\u0027?\n\nHmm. Guess I got confused between the first section above (L28 \u0027Enabling...\u0027) and this one \u0027Configuring\u0027.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Configuring interfaces in multi-conductor environments"},{"line_number":160,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"When configuring hardware types and their interfaces, make sure that for"},{"line_number":163,"context_line":"every enabled hardware type, the whole set of enabled interfaces matches for"},{"line_number":164,"context_line":"all conductors. However, different conductors can have different hardware"},{"line_number":165,"context_line":"types enabled."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_8579a830","line":162,"in_reply_to":"ff0f0b1f_2eb9bfe8","updated":"2017-05-26 15:07:07.000000000","message":"I can s/Configuring/Enabling/ here","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":164,"context_line":"all conductors. However, different conductors can have different hardware"},{"line_number":165,"context_line":"types enabled."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"For example, you can have two conductors with the following configuration:"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. code-block:: ini"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_6ebb37c4","line":167,"updated":"2017-05-25 18:52:21.000000000","message":"s/configuration/configurations respectively/\n\nif I understand it, you have two sets of configurations below, one for each conductor, right?","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":164,"context_line":"all conductors. However, different conductors can have different hardware"},{"line_number":165,"context_line":"types enabled."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"For example, you can have two conductors with the following configuration:"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. code-block:: ini"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_25b77cdb","line":167,"in_reply_to":"ff0f0b1f_6ebb37c4","updated":"2017-05-26 15:07:07.000000000","message":"right","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    enabled_power_interfaces \u003d redfish"},{"line_number":183,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"But you cannot have two conductors with the following configuration:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":".. code-block:: ini"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_eecbc747","line":185,"updated":"2017-05-25 18:52:21.000000000","message":"s/configuration/configurations respectively/","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    enabled_power_interfaces \u003d redfish"},{"line_number":183,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"But you cannot have two conductors with the following configuration:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":".. code-block:: ini"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_05bc78b9","line":185,"in_reply_to":"ff0f0b1f_eecbc747","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    enabled_power_interfaces \u003d redfish"},{"line_number":201,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":204,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_0e6b9b1f","line":203,"updated":"2017-05-25 18:52:21.000000000","message":"by \u0027second case\u0027, do you mean L185 to here, or do you mean L197 to here?","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    enabled_power_interfaces \u003d redfish"},{"line_number":201,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":204,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_25dc1c17","line":203,"in_reply_to":"ff0f0b1f_0e6b9b1f","updated":"2017-05-26 15:07:07.000000000","message":"I mean L185 to here, and I\u0027m not sure how to better rephrase it","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":204,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"},{"line_number":207,"context_line":"can cause inconsistent behavior in the API, when node functionality will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_eed507b9","line":204,"updated":"2017-05-25 18:52:21.000000000","message":"So if L199 was \u0027direct\u0027 instead of \u0027iscsi\u0027, it would be ok, right?","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":204,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"},{"line_number":207,"context_line":"can cause inconsistent behavior in the API, when node functionality will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_c5ea00ab","line":204,"in_reply_to":"ff0f0b1f_eed507b9","updated":"2017-05-26 15:07:07.000000000","message":"Right","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":204,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"},{"line_number":207,"context_line":"can cause inconsistent behavior in the API, when node functionality will"},{"line_number":208,"context_line":"depend on which conductor it gets assigned to."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_493f4d87","line":206,"updated":"2017-05-25 18:52:21.000000000","message":"nit s/currently//","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":203,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":204,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"This situation is currently not detected by the Bare Metal service, but it"},{"line_number":207,"context_line":"can cause inconsistent behavior in the API, when node functionality will"},{"line_number":208,"context_line":"depend on which conductor it gets assigned to."},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_a5cf0c56","line":206,"in_reply_to":"ff0f0b1f_493f4d87","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":214,"context_line":"Configuring interface defaults"},{"line_number":215,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"When a user does not provide an explicit value for one of interfaces, the"},{"line_number":218,"context_line":"default value is calculated as described in"},{"line_number":219,"context_line":":ref:`hardware_interfaces_defaults`. An operator can override the defaults for"},{"line_number":220,"context_line":"any interfaces by setting one of options named ``default_\u003cIFACE\u003e_interface``,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_49586df9","line":217,"updated":"2017-05-25 18:52:21.000000000","message":"you mean in the context of creating a node? (vs setting a configuration option)","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":214,"context_line":"Configuring interface defaults"},{"line_number":215,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"When a user does not provide an explicit value for one of interfaces, the"},{"line_number":218,"context_line":"default value is calculated as described in"},{"line_number":219,"context_line":":ref:`hardware_interfaces_defaults`. An operator can override the defaults for"},{"line_number":220,"context_line":"any interfaces by setting one of options named ``default_\u003cIFACE\u003e_interface``,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_050a3889","line":217,"in_reply_to":"ff0f0b1f_49586df9","updated":"2017-05-26 15:07:07.000000000","message":"yep","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c7ca04f75b42b11224982fabcab3a0a6583ef47","unresolved":false,"context_lines":[{"line_number":25,"context_line":"be assigned to the ``driver`` field of a node. However, they are configured"},{"line_number":26,"context_line":"differently."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Enabling hardware types"},{"line_number":29,"context_line":"-----------------------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Hardware types are enabled in the configuration file of the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df140735_86609d34","line":28,"updated":"2017-05-29 15:22:27.000000000","message":"It will break the links if we reword this, but I\u0027m not worried about that since it has been what, 1-2 weeks since we added this link, and it is still in \u0027draft\u0027 (https://docs.openstack.org/project-install-guide/baremetal/draft/enabling-drivers.html) :-)\n\nThe reason why I mention it, is take a look at the \u0027Contents\u0027: http://docs-draft.openstack.org/41/466741/7/check/gate-ironic-install-guide/82ea66b//install-guide/build/html/enabling-drivers.html\n\nHmm. Thinking about it a bit more. Maybe it is OK to leave that title. It seems to me that the \u0027Enabling hardware types\u0027 section breaks down into these sections/groups. What do you think?:\nEnabling hardware types\n  - enabling hardware types\n  - enabling hardware interfaces\n     - hardware interfaces in multi-conductor environments\n  - configuring hardware interface defaults\n\nwhere the existing \u0027Enabling hardware types\u0027 would be split between the subsections \u0027enabling hardware types\u0027 \u0026 \u0027enabline hardware interfaces\u0027.\n\nAnd/or the top level \u0027Enabling hardware types\u0027 can include the description for enabling hardware types, and get rid of the subsection I mentioned above. (I like having the descriptions at the same level, but we aren\u0027t consistent in that regard so I am fine either way.)","commit_id":"44475cc995b7aad28032b0ce9dfd0cb14ae88324"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c7ca04f75b42b11224982fabcab3a0a6583ef47","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    enabled_power_interfaces \u003d redfish"},{"line_number":203,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":206,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"This situation is not detected by the Bare Metal service, but it can cause"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df140735_c61e956f","line":205,"updated":"2017-05-29 15:22:27.000000000","message":"It might be less confusing (wrt what \u0027second case refers to), if you just drop it. L186 mentions that you can\u0027t have two conductors... This is because the redfish hardware type ...","commit_id":"44475cc995b7aad28032b0ce9dfd0cb14ae88324"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c7ca04f75b42b11224982fabcab3a0a6583ef47","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    enabled_management_interfaces \u003d redfish"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"This is because in the second case, the ``redfish`` hardware type will have"},{"line_number":206,"context_line":"different enabled *deploy* interfaces on these conductors."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"This situation is not detected by the Bare Metal service, but it can cause"},{"line_number":209,"context_line":"inconsistent behavior in the API, when node functionality will depend on"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df140735_0947fe4d","line":206,"updated":"2017-05-29 15:22:27.000000000","message":"would it be useful to add \u0027(It would have been fine If the second conductor had enabled_deploy_interface\u003ddirect instead of iscsi.)\u0027","commit_id":"44475cc995b7aad28032b0ce9dfd0cb14ae88324"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f149b0ae8129385a9bd619053cab0c50b13dadd0","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"This is because the ``redfish`` hardware type will have different enabled"},{"line_number":209,"context_line":"*deploy* interfaces on these conductors. It would have been fine, if the second"},{"line_number":210,"context_line":"conductor had ``enabled_deploy_interface\u003ddirect`` instead of ``iscsi``."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"This situation is not detected by the Bare Metal service, but it can cause"},{"line_number":213,"context_line":"inconsistent behavior in the API, when node functionality will depend on"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_63ae852f","line":210,"updated":"2017-05-30 13:46:18.000000000","message":"nit. oops, my bad. i guess you copied my comment. s/enabled_deploy_interface/enabled_deploy_interfaces/","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"015ccac9dd0314ae5b9daaaf4e50e1746569a7f9","unresolved":false,"context_lines":[{"line_number":214,"context_line":"which conductor it gets assigned to."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. note::"},{"line_number":217,"context_line":"   We don\u0027t treat it as an error, because such *temporary* inconsistency is"},{"line_number":218,"context_line":"   inevitable during a rolling upgrade or a configuration update."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Configuring interface defaults"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_2d187c1b","line":217,"range":{"start_line":217,"start_character":18,"end_line":217,"end_character":20},"updated":"2017-05-30 12:42:20.000000000","message":"nit: s/it/this/","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"55d661a7970a2f00d67b2c2007bb7e90ef6dc3b3","unresolved":false,"context_lines":[{"line_number":217,"context_line":"   We don\u0027t treat it as an error, because such *temporary* inconsistency is"},{"line_number":218,"context_line":"   inevitable during a rolling upgrade or a configuration update."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Configuring interface defaults"},{"line_number":221,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"When a user does not provide an explicit value for one of interfaces (when"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_437b808b","line":220,"updated":"2017-05-30 13:50:06.000000000","message":"maybe, to be consistent with other headings, s/interface/hardware interface/\n\nOr just \u0027Defaults for hardware interfaces\u0027?","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"015ccac9dd0314ae5b9daaaf4e50e1746569a7f9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"Configuring interface defaults"},{"line_number":221,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"When a user does not provide an explicit value for one of interfaces (when"},{"line_number":224,"context_line":"creating a node or updating its driver), the default value is calculated"},{"line_number":225,"context_line":"as described in :ref:`hardware_interfaces_defaults`. An operator can override"},{"line_number":226,"context_line":"the defaults for any interfaces by setting one of options named"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_4dc97076","line":223,"range":{"start_line":223,"start_character":5,"end_line":223,"end_character":11},"updated":"2017-05-30 12:42:20.000000000","message":"nit: We may want to say \"an operator\", because a user may not have an understanding of the underlying hardware or environment, but an operator as an operator managing the system would be the actual ones performing the configuration.","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f149b0ae8129385a9bd619053cab0c50b13dadd0","unresolved":false,"context_lines":[{"line_number":220,"context_line":"Configuring interface defaults"},{"line_number":221,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"When a user does not provide an explicit value for one of interfaces (when"},{"line_number":224,"context_line":"creating a node or updating its driver), the default value is calculated"},{"line_number":225,"context_line":"as described in :ref:`hardware_interfaces_defaults`. An operator can override"},{"line_number":226,"context_line":"the defaults for any interfaces by setting one of options named"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_a3181d81","line":223,"range":{"start_line":223,"start_character":5,"end_line":223,"end_character":11},"in_reply_to":"df140735_4dc97076","updated":"2017-05-30 13:46:18.000000000","message":"that\u0027s true but we (Dmitry) uses \u0027user\u0027 elsewhere. Eg, L250.\n\nMaybe we should never use \u0027user\u0027...","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"015ccac9dd0314ae5b9daaaf4e50e1746569a7f9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"existing nodes."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":".. warning::"},{"line_number":244,"context_line":"   The default interface implementation has to be configured the same way"},{"line_number":245,"context_line":"   across all conductors in the cloud, except maybe for a short period of time"},{"line_number":246,"context_line":"   during an upgrade or configuration update."},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_0d8a581a","line":244,"range":{"start_line":244,"start_character":40,"end_line":244,"end_character":46},"updated":"2017-05-30 12:42:20.000000000","message":"nit s/has to/must/","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"015ccac9dd0314ae5b9daaaf4e50e1746569a7f9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"existing nodes."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":".. warning::"},{"line_number":244,"context_line":"   The default interface implementation has to be configured the same way"},{"line_number":245,"context_line":"   across all conductors in the cloud, except maybe for a short period of time"},{"line_number":246,"context_line":"   during an upgrade or configuration update."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":".. warning::"},{"line_number":249,"context_line":"   These options should be used with care. If a hardware type does not"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_ed35e4f8","line":246,"range":{"start_line":244,"start_character":65,"end_line":246,"end_character":45},"updated":"2017-05-30 12:42:20.000000000","message":"My inner operator asks why?  I know why, but someone reading this is not going to know why. We should provide a hint that it has to do with node creation and default interfaces utilized.","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"}],"install-guide/source/enrollment.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"af0f9af7e0775d51e9ccc6278f571e370dd4fb02","unresolved":false,"context_lines":[{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded in the source code and cannot be changes."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_e752453b","line":490,"updated":"2017-05-22 16:14:22.000000000","message":"I guess storage too https://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L104","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb82a2cae57d112e7b1161c51e7f95b5aed70134","unresolved":false,"context_lines":[{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded in the source code and cannot be changes."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_d6da5149","line":490,"in_reply_to":"ff0f0b1f_e752453b","updated":"2017-05-23 11:05:44.000000000","message":"the storage interface is not accessible yet, so I\u0027d prefer not to talk about it for now","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"af0f9af7e0775d51e9ccc6278f571e370dd4fb02","unresolved":false,"context_lines":[{"line_number":497,"context_line":"#. If the ``default_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE`` is the"},{"line_number":498,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"},{"line_number":501,"context_line":"   an error is returned to a user. In this case, an explicit value has to be"},{"line_number":502,"context_line":"   provided for the ``\u003cIFACE\u003e_interface`` field."},{"line_number":503,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_0a01c005","line":500,"updated":"2017-05-22 16:14:22.000000000","message":"I think it should be clarified that this error is returned when either a user is trying to update a hw type of a node to something not compatible with defaults at the same time not specifying valid interfaces, or when a user updates the config options to something unsupported by some nodes, then actions with these nodes will be failing until the node\u0027s interface or config gets updated. just needs more detail here :)","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb82a2cae57d112e7b1161c51e7f95b5aed70134","unresolved":false,"context_lines":[{"line_number":497,"context_line":"#. If the ``default_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE`` is the"},{"line_number":498,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"},{"line_number":501,"context_line":"   an error is returned to a user. In this case, an explicit value has to be"},{"line_number":502,"context_line":"   provided for the ``\u003cIFACE\u003e_interface`` field."},{"line_number":503,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_6d071a84","line":500,"in_reply_to":"ff0f0b1f_0a01c005","updated":"2017-05-23 11:05:44.000000000","message":"It\u0027s mentioned on line 494, I\u0027ll expand it.","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"af0f9af7e0775d51e9ccc6278f571e370dd4fb02","unresolved":false,"context_lines":[{"line_number":503,"context_line":""},{"line_number":504,"context_line":"#. Otherwise, an intersection is calculated between the implementations"},{"line_number":505,"context_line":"   supported by the node\u0027s hardware type and implementations enabled by the"},{"line_number":506,"context_line":"   ``enabled_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE`` is the interface"},{"line_number":507,"context_line":"   name). The calculation preserves the order of items, as provided by the"},{"line_number":508,"context_line":"   hardware type."},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_4ae4583c","line":506,"range":{"start_line":506,"start_character":21,"end_line":506,"end_character":30},"updated":"2017-05-22 16:14:22.000000000","message":"interfaces","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"af0f9af7e0775d51e9ccc6278f571e370dd4fb02","unresolved":false,"context_lines":[{"line_number":503,"context_line":""},{"line_number":504,"context_line":"#. Otherwise, an intersection is calculated between the implementations"},{"line_number":505,"context_line":"   supported by the node\u0027s hardware type and implementations enabled by the"},{"line_number":506,"context_line":"   ``enabled_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE`` is the interface"},{"line_number":507,"context_line":"   name). The calculation preserves the order of items, as provided by the"},{"line_number":508,"context_line":"   hardware type."},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_ead8cc7b","line":506,"range":{"start_line":506,"start_character":50,"end_line":506,"end_character":55},"updated":"2017-05-22 16:14:22.000000000","message":"missed closing bracket","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb82a2cae57d112e7b1161c51e7f95b5aed70134","unresolved":false,"context_lines":[{"line_number":503,"context_line":""},{"line_number":504,"context_line":"#. Otherwise, an intersection is calculated between the implementations"},{"line_number":505,"context_line":"   supported by the node\u0027s hardware type and implementations enabled by the"},{"line_number":506,"context_line":"   ``enabled_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE`` is the interface"},{"line_number":507,"context_line":"   name). The calculation preserves the order of items, as provided by the"},{"line_number":508,"context_line":"   hardware type."},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_2dfda26d","line":506,"range":{"start_line":506,"start_character":21,"end_line":506,"end_character":30},"in_reply_to":"ff0f0b1f_4ae4583c","updated":"2017-05-23 11:05:44.000000000","message":"Done","commit_id":"00e2e370bfaa30a29369e1c4a4bdabaf213c4dbd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5deeacb88c37cb918c6575082bf84e1d4e64d7ae","unresolved":false,"context_lines":[{"line_number":494,"context_line":"When no value is provided for a certain interface when creating a node, or"},{"line_number":495,"context_line":"updating node\u0027s hardware type, the default for it is calculated as follows:"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"#. If the ``default_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE`` is the"},{"line_number":498,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff0f0b1f_4d37b600","line":497,"range":{"start_line":497,"start_character":57,"end_line":497,"end_character":62},"updated":"2017-05-23 11:17:11.000000000","message":"woops, another closing bracket missed","commit_id":"9fce48001d6c7502bfb766e582269bd3c4974637"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3711326690ed0bea79421b40a08d4bcf4fb6cbb","unresolved":false,"context_lines":[{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded in the source code and cannot be changes."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff0f0b1f_c655bcfb","line":490,"range":{"start_line":490,"start_character":68,"end_line":490,"end_character":75},"updated":"2017-05-24 11:16:02.000000000","message":"s/ changes./ changed./","commit_id":"a5c83b3990bdfc3abe4f3fab6de4fc97ba5baebb"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":512,"context_line":"   has to be provided for the ``\u003cIFACE\u003e_interface`` field."},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"   In other words, the first supported implementation that is enabled by an"},{"line_number":515,"context_line":"   operator is used as the default."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"Use the driver details command to list the current enabled and default"},{"line_number":518,"context_line":"interfaces for a hardware type:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_4afc0ab4","line":515,"updated":"2017-05-24 15:10:06.000000000","message":"Maybe put this as the first paragraph here.\n\n    In short, the first supported...\n\n    \u003cthe details\u003e","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94c8e1b571b4b0eb3b37c1da02f9df547c54dc5c","unresolved":false,"context_lines":[{"line_number":515,"context_line":"   operator is used as the default."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"Use the driver details command to list the current enabled and default"},{"line_number":518,"context_line":"interfaces for a hardware type:"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":".. code-block:: console"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff0f0b1f_ca101a03","line":518,"updated":"2017-05-24 15:10:06.000000000","message":"Maybe this should go first, as it will be the answer most users are looking for?","commit_id":"f666e507a7cf7683db75667c9c1879156dfa6f71"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e6b170c89bd561503a5ccf4e87f87b05e2a4a2fa","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    enabled_hardware_types \u003d ipmi,redfish"},{"line_number":563,"context_line":"    enabled_console_interfaces \u003d no-console,ipmitool-shellinabox"},{"line_number":564,"context_line":"    enabled_deploy_interfaces \u003d iscsi,direct"},{"line_number":565,"context_line":"    enabled_power_interfaces \u003d ipmitool,redfish"},{"line_number":566,"context_line":"    default_deploy_interface \u003d direct"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"A new node is created with the ``ipmi`` driver and no interfaces specified:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_964dab3f","line":565,"updated":"2017-05-24 17:13:00.000000000","message":"We might need to add the enabled_management_interfaces with ipmitool and redfish for the same reason, as redfish only supports redfish management.","commit_id":"6a306dbc05e86199fd6a0ffdd84cfd9062bf2985"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":".. _hardware_interfaces_defaults:"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"Hardware interfaces defaults"},{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_34cfd0b1","line":486,"updated":"2017-05-25 18:52:21.000000000","message":"I wonder if \u0027Defaults for hardware interfaces\u0027 might read better.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":".. _hardware_interfaces_defaults:"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"Hardware interfaces defaults"},{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_e533c461","line":486,"in_reply_to":"ff0f0b1f_34cfd0b1","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded in the source code and cannot be changed."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_3444701b","line":490,"updated":"2017-05-25 18:52:21.000000000","message":"nit s/in the source code//","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":487,"context_line":"----------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded in the source code and cannot be changed."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_a53dcc2d","line":490,"in_reply_to":"ff0f0b1f_3444701b","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"When no value is provided for a certain interface when creating a node, or"},{"line_number":495,"context_line":"updating node\u0027s hardware type, the default for it is calculated as explained"},{"line_number":496,"context_line":"below."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Use the driver details command to list the current enabled and default"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_d46bf482","line":495,"updated":"2017-05-25 18:52:21.000000000","message":"maybe s/updating/changing a/\n\ni wonder if it might be better as s/hardware type/driver/ (because the field is \u0027driver\u0027)","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"When no value is provided for a certain interface when creating a node, or"},{"line_number":495,"context_line":"updating node\u0027s hardware type, the default for it is calculated as explained"},{"line_number":496,"context_line":"below."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Use the driver details command to list the current enabled and default"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_8523e805","line":495,"in_reply_to":"ff0f0b1f_d46bf482","updated":"2017-05-26 15:07:07.000000000","message":"I\u0027m emphasizing the hardware type, as this logic does not apply to classic drivers.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"When no value is provided for a certain interface when creating a node, or"},{"line_number":495,"context_line":"updating node\u0027s hardware type, the default for it is calculated as explained"},{"line_number":496,"context_line":"below."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Use the driver details command to list the current enabled and default"},{"line_number":499,"context_line":"interfaces for a hardware type:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_d4c3f437","line":496,"updated":"2017-05-25 18:52:21.000000000","message":"what do you think about changing it and combining it with the next sentence, to something like\n\nWhen no value is provided..., the default value is used. You can use the ``driver show`` command to list the enabled and default interfaces in your BareMetal service (as configured via ironic.conf):\n  ...\n\n[cuz at L530 you mention how they are calculated so it isn\u0027t needed here too.]","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"When no value is provided for a certain interface when creating a node, or"},{"line_number":495,"context_line":"updating node\u0027s hardware type, the default for it is calculated as explained"},{"line_number":496,"context_line":"below."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Use the driver details command to list the current enabled and default"},{"line_number":499,"context_line":"interfaces for a hardware type:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_45727013","line":496,"in_reply_to":"ff0f0b1f_d4c3f437","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":496,"context_line":"below."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Use the driver details command to list the current enabled and default"},{"line_number":499,"context_line":"interfaces for a hardware type:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. code-block:: console"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_d419b422","line":499,"updated":"2017-05-25 18:52:21.000000000","message":"i wonder if we should qualify that these would be the enabled/default interfaces as configured via ironic.conf in their Bare Metal service set up.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":496,"context_line":"below."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Use the driver details command to list the current enabled and default"},{"line_number":499,"context_line":"interfaces for a hardware type:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":".. code-block:: console"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_85d648c3","line":499,"in_reply_to":"ff0f0b1f_d419b422","updated":"2017-05-26 15:07:07.000000000","message":"Enabled - yes, but the defaults are dynamic. I can\u0027t think of a good wording, help appreciated.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    | enabled_power_interfaces      | ipmitool       |"},{"line_number":523,"context_line":"    | enabled_raid_interfaces       | no-raid, agent |"},{"line_number":524,"context_line":"    | enabled_vendor_interfaces     | no-vendor      |"},{"line_number":525,"context_line":"    | hosts                         | undercloud     |"},{"line_number":526,"context_line":"    | name                          | ipmi           |"},{"line_number":527,"context_line":"    | type                          | dynamic        |"},{"line_number":528,"context_line":"    +-------------------------------+----------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_d4d8941f","line":525,"updated":"2017-05-25 18:52:21.000000000","message":"i know this is an example, but maybe we should change \u0027undercloud\u0027 to something generic like \u0027hostA\u0027 ?","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    | enabled_power_interfaces      | ipmitool       |"},{"line_number":523,"context_line":"    | enabled_raid_interfaces       | no-raid, agent |"},{"line_number":524,"context_line":"    | enabled_vendor_interfaces     | no-vendor      |"},{"line_number":525,"context_line":"    | hosts                         | undercloud     |"},{"line_number":526,"context_line":"    | name                          | ipmi           |"},{"line_number":527,"context_line":"    | type                          | dynamic        |"},{"line_number":528,"context_line":"    +-------------------------------+----------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_05f4785a","line":525,"in_reply_to":"ff0f0b1f_d4d8941f","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"The defaults are calculated as follows:"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"#. If the ``default_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE\u003e`` is the"},{"line_number":533,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_f4f4b889","line":532,"updated":"2017-05-25 18:52:21.000000000","message":"nit s/option/configuration option/","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"The defaults are calculated as follows:"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"#. If the ``default_\u003cIFACE\u003e_interface`` option (where ``\u003cIFACE\u003e`` is the"},{"line_number":533,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_a5026c3d","line":532,"in_reply_to":"ff0f0b1f_f4f4b889","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":533,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"},{"line_number":536,"context_line":"   an error is returned to a user. An explicit value has to be provided"},{"line_number":537,"context_line":"   for the ``\u003cIFACE\u003e_interface`` field in this case."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"#. Otherwise, the first supported implementation that is enabled by an"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_14260c18","line":536,"updated":"2017-05-25 18:52:21.000000000","message":"as a response to an API request, right? I don\u0027t recall, when do we return the error? In the node create or node update?","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":533,"context_line":"   interface name) is set, its value is used as the default."},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"},{"line_number":536,"context_line":"   an error is returned to a user. An explicit value has to be provided"},{"line_number":537,"context_line":"   for the ``\u003cIFACE\u003e_interface`` field in this case."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"#. Otherwise, the first supported implementation that is enabled by an"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_45f9504b","line":536,"in_reply_to":"ff0f0b1f_14260c18","updated":"2017-05-26 15:07:07.000000000","message":"in both cases","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"},{"line_number":536,"context_line":"   an error is returned to a user. An explicit value has to be provided"},{"line_number":537,"context_line":"   for the ``\u003cIFACE\u003e_interface`` field in this case."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"#. Otherwise, the first supported implementation that is enabled by an"},{"line_number":540,"context_line":"   operator is used as the default."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_747c28eb","line":537,"updated":"2017-05-25 18:52:21.000000000","message":"s/the/the node\u0027s/","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"   If this implementation is not compatible with the node\u0027s hardware type,"},{"line_number":536,"context_line":"   an error is returned to a user. An explicit value has to be provided"},{"line_number":537,"context_line":"   for the ``\u003cIFACE\u003e_interface`` field in this case."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"#. Otherwise, the first supported implementation that is enabled by an"},{"line_number":540,"context_line":"   operator is used as the default."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_6591f4f1","line":537,"in_reply_to":"ff0f0b1f_747c28eb","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":539,"context_line":"#. Otherwise, the first supported implementation that is enabled by an"},{"line_number":540,"context_line":"   operator is used as the default."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"   An intersection is calculated between the implementations"},{"line_number":543,"context_line":"   supported by the node\u0027s hardware type and implementations enabled by the"},{"line_number":544,"context_line":"   ``enabled_\u003cIFACE\u003e_interfaces`` option (where ``\u003cIFACE\u003e`` is the interface"},{"line_number":545,"context_line":"   name). The calculation preserves the order of items, as provided by the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_d4e2d4a0","line":542,"updated":"2017-05-25 18:52:21.000000000","message":"This is the list of supported implementations, right? Maybe s/An ... between/A list of supported implementations is calculated by taking the intersection/","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":539,"context_line":"#. Otherwise, the first supported implementation that is enabled by an"},{"line_number":540,"context_line":"   operator is used as the default."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"   An intersection is calculated between the implementations"},{"line_number":543,"context_line":"   supported by the node\u0027s hardware type and implementations enabled by the"},{"line_number":544,"context_line":"   ``enabled_\u003cIFACE\u003e_interfaces`` option (where ``\u003cIFACE\u003e`` is the interface"},{"line_number":545,"context_line":"   name). The calculation preserves the order of items, as provided by the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_c53e80d9","line":542,"in_reply_to":"ff0f0b1f_d4e2d4a0","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":545,"context_line":"   name). The calculation preserves the order of items, as provided by the"},{"line_number":546,"context_line":"   hardware type."},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"   If the intersection is not empty, the first implementation is used."},{"line_number":549,"context_line":"   Otherwise, an error is returned to a user. In this case, an explicit value"},{"line_number":550,"context_line":"   has to be provided for the ``\u003cIFACE\u003e_interface`` field."},{"line_number":551,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_74c1c8e4","line":548,"updated":"2017-05-25 18:52:21.000000000","message":"s/intersection/the list of supported implementations/ (if you use my suggestion above)","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":545,"context_line":"   name). The calculation preserves the order of items, as provided by the"},{"line_number":546,"context_line":"   hardware type."},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"   If the intersection is not empty, the first implementation is used."},{"line_number":549,"context_line":"   Otherwise, an error is returned to a user. In this case, an explicit value"},{"line_number":550,"context_line":"   has to be provided for the ``\u003cIFACE\u003e_interface`` field."},{"line_number":551,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_e53984f2","line":548,"in_reply_to":"ff0f0b1f_74c1c8e4","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"   If the intersection is not empty, the first implementation is used."},{"line_number":549,"context_line":"   Otherwise, an error is returned to a user. In this case, an explicit value"},{"line_number":550,"context_line":"   has to be provided for the ``\u003cIFACE\u003e_interface`` field."},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"See :doc:`enabling-drivers` for more details on configuration."},{"line_number":553,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_34a2304d","line":550,"updated":"2017-05-25 18:52:21.000000000","message":"same questions as at L536.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":".. code-block:: console"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    $ export IRONIC_API_VERSION\u003d1.11"},{"line_number":574,"context_line":"    $ ironic node-create -d ipmi"},{"line_number":575,"context_line":"    +--------------+--------------------------------------+"},{"line_number":576,"context_line":"    | Property     | Value                                |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_cfb6bd3f","line":573,"updated":"2017-05-25 18:52:21.000000000","message":"maybe s/11/31/ ?\n\nI can\u0027t recall if this will work with 1.11 but I think we should use the API version where we introduced the hardware types.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"04eaf5c27d1657cb4a9c4ed60f750989f1bc5bdd","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":".. code-block:: console"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    $ export IRONIC_API_VERSION\u003d1.11"},{"line_number":574,"context_line":"    $ ironic node-create -d ipmi"},{"line_number":575,"context_line":"    +--------------+--------------------------------------+"},{"line_number":576,"context_line":"    | Property     | Value                                |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_09e37e35","line":573,"in_reply_to":"ff0f0b1f_657fb4ab","updated":"2017-05-29 15:14:05.000000000","message":"Yes, that is true for that particular command, but won\u0027t it cause more confusion later, when they try to update the node\u0027s hardware interfaces? We don\u0027t really want to encourage folks to use 1.11 anyway. I guess I feel that if you\u0027re using hardware types, using 1.11 is somewhat unrealistic.\n\nJust looking at the text above; we mention 1.31 at L179.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":".. code-block:: console"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    $ export IRONIC_API_VERSION\u003d1.11"},{"line_number":574,"context_line":"    $ ironic node-create -d ipmi"},{"line_number":575,"context_line":"    +--------------+--------------------------------------+"},{"line_number":576,"context_line":"    | Property     | Value                                |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_657fb4ab","line":573,"in_reply_to":"ff0f0b1f_cfb6bd3f","updated":"2017-05-26 15:07:07.000000000","message":"This will work with 1.11, as hardware types are available in all versions. So I\u0027d prefer not to show a dependency which is not really present.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":584,"context_line":"    | name         | None                                 |"},{"line_number":585,"context_line":"    +--------------+--------------------------------------+"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"Then the defaults for the interfaces used in this example are calculated"},{"line_number":588,"context_line":"as follows:"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"deploy"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_4f262d6b","line":587,"updated":"2017-05-25 18:52:21.000000000","message":"maybe s/used/that will be used by the node/","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":584,"context_line":"    | name         | None                                 |"},{"line_number":585,"context_line":"    +--------------+--------------------------------------+"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"Then the defaults for the interfaces used in this example are calculated"},{"line_number":588,"context_line":"as follows:"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"deploy"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_254bfc87","line":587,"in_reply_to":"ff0f0b1f_4f262d6b","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e254fc933fcb217cce4c5eba6d95d7d30935c943","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    intersection contains ``ipmitool-shellinabox`` and ``no-console``."},{"line_number":604,"context_line":"    The first item is used, and it is ``ipmitool-shellinabox``."},{"line_number":605,"context_line":"management"},{"line_number":606,"context_line":"    Follows the same calculation as *power*."},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"Hardware Inspection"},{"line_number":609,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_6f8d7130","line":606,"updated":"2017-05-25 18:52:21.000000000","message":"Might be worth mentioning that the ipmi hardware type supports the ipmitool management interface, so ipmitool is used.","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7abeb537a68258b57ce48f7e0cebcfbb5586b120","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    intersection contains ``ipmitool-shellinabox`` and ``no-console``."},{"line_number":604,"context_line":"    The first item is used, and it is ``ipmitool-shellinabox``."},{"line_number":605,"context_line":"management"},{"line_number":606,"context_line":"    Follows the same calculation as *power*."},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"Hardware Inspection"},{"line_number":609,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_e544e476","line":606,"in_reply_to":"ff0f0b1f_6f8d7130","updated":"2017-05-26 15:07:07.000000000","message":"Done","commit_id":"a2e34c16b74044fe7eedb6be1de45b852c37f7a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c7ca04f75b42b11224982fabcab3a0a6583ef47","unresolved":false,"context_lines":[{"line_number":494,"context_line":"When no value is provided for a certain interface when creating a node, or"},{"line_number":495,"context_line":"changing a node\u0027s hardware type, the default value is used. You can use"},{"line_number":496,"context_line":"the driver details command to list the current enabled and default"},{"line_number":497,"context_line":"interfaces for a hardware type:"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":".. code-block:: console"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"df140735_c9d7c623","line":497,"updated":"2017-05-29 15:22:27.000000000","message":"maybe add \u0027(for your particular deployment)\u0027. I guess we don\u0027t have to go into detail about the particulars here since you do that later.\n\nOr maybe you don\u0027t need to add this. When I first read this, I wondered if the user knew whether this info was all hardcoded, or derived. Now I don\u0027t know...","commit_id":"44475cc995b7aad28032b0ce9dfd0cb14ae88324"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"015ccac9dd0314ae5b9daaaf4e50e1746569a7f9","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        --deploy-interface direct \\"},{"line_number":199,"context_line":"        --raid-interface agent"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"   If no value is provided for certain interfaces, `Defaults for hardware"},{"line_number":202,"context_line":"   interfaces`_ are used instead."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"   It\u0027s an error to try changing this field for a node with a *classic driver*,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_8da2e899","line":201,"range":{"start_line":201,"start_character":31,"end_line":201,"end_character":39},"updated":"2017-05-30 12:42:20.000000000","message":"To understand the word certain here, one has to have context. Maybe we should be a little more verbose here?","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"015ccac9dd0314ae5b9daaaf4e50e1746569a7f9","unresolved":false,"context_lines":[{"line_number":487,"context_line":"--------------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded and cannot be changed."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_adb6ccd8","line":490,"range":{"start_line":490,"start_character":34,"end_line":490,"end_character":57},"updated":"2017-05-30 12:42:20.000000000","message":"nit: \"and cannot be changed\" seems redundant after saying hard coded. Besides, an operator or specialized consumer could easily change them around by mucking with the code.","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f149b0ae8129385a9bd619053cab0c50b13dadd0","unresolved":false,"context_lines":[{"line_number":487,"context_line":"--------------------------------"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"For *classic drivers* all hardware interface implementations (except for the"},{"line_number":490,"context_line":"*network interface*) are hardcoded and cannot be changed."},{"line_number":491,"context_line":"For *hardware types*, users can request one of enabled implementations when"},{"line_number":492,"context_line":"creating or updating a node as explained in `Creating a node`_."},{"line_number":493,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"df140735_8303d942","line":490,"range":{"start_line":490,"start_character":34,"end_line":490,"end_character":57},"in_reply_to":"df140735_adb6ccd8","updated":"2017-05-30 13:46:18.000000000","message":"Maybe it needs rewording because just because something is hardcoded it doesn\u0027t necessarily mean that it cannot be changed. I mean we have defaults that are hardcoded, but we provide a mechanism for them to be overridden.","commit_id":"d3e78688ca5bb87dfff915b4f450942635ec3cb3"}]}
