)]}'
{"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# is being introduced together with the python-oneviewclient to be used"},{"line_number":34,"context_line":"# generally by other patches."},{"line_number":35,"context_line":"hponeview_client \u003d importutils.try_import(\u0027hpOneView.oneview_client\u0027)"},{"line_number":36,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":37,"context_line":"ilorest_client \u003d importutils.try_import(\u0027redfish.rest.v1\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"SET_POWER_STATE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_eae7a1ab","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":16},"updated":"2017-07-05 02:26:46.000000000","message":"nit: it would be helpful to know that these are coming from the hpOneView without knowing about this explicit import.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"f25cc02518cb8c6b458214117c0b0d9dc708e5d1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# is being introduced together with the python-oneviewclient to be used"},{"line_number":34,"context_line":"# generally by other patches."},{"line_number":35,"context_line":"hponeview_client \u003d importutils.try_import(\u0027hpOneView.oneview_client\u0027)"},{"line_number":36,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":37,"context_line":"ilorest_client \u003d importutils.try_import(\u0027redfish.rest.v1\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"SET_POWER_STATE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_a0252c5e","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":16},"in_reply_to":"3f1d235d_eae7a1ab","updated":"2017-07-05 16:44:59.000000000","message":"Thanks Julia. Done","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":37,"context_line":"redfish \u003d importutils.try_import(\u0027redfish\u0027)"},{"line_number":38,"context_line":"hpOneView_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"SET_POWER_STATE_MAP \u003d {"},{"line_number":41,"context_line":"    states.POWER_ON: ["},{"line_number":42,"context_line":"        {\u0027powerState\u0027: \u0027On\u0027}"},{"line_number":43,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_80a7fe4f","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"updated":"2017-07-25 21:10:43.000000000","message":"Maybe it\u0027s better to keep on power.py. WDYT?","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"redfish \u003d importutils.try_import(\u0027redfish\u0027)"},{"line_number":38,"context_line":"hpOneView_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"SET_POWER_STATE_MAP \u003d {"},{"line_number":41,"context_line":"    states.POWER_ON: ["},{"line_number":42,"context_line":"        {\u0027powerState\u0027: \u0027On\u0027}"},{"line_number":43,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_185482fe","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"ff346bd7_09f79a61","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a3431b1007d53804f236f23b2a57541b9d96a517","unresolved":false,"context_lines":[{"line_number":37,"context_line":"redfish \u003d importutils.try_import(\u0027redfish\u0027)"},{"line_number":38,"context_line":"hpOneView_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"SET_POWER_STATE_MAP \u003d {"},{"line_number":41,"context_line":"    states.POWER_ON: ["},{"line_number":42,"context_line":"        {\u0027powerState\u0027: \u0027On\u0027}"},{"line_number":43,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_09f79a61","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"ff346bd7_80a7fe4f","updated":"2017-07-26 17:07:57.000000000","message":"+1","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    :returns: the power state translated"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    power_states_map \u003d {"},{"line_number":278,"context_line":"        \u0027On\u0027: states.POWER_ON,"},{"line_number":279,"context_line":"        \u0027PoweringOff\u0027: states.POWER_ON,"},{"line_number":280,"context_line":"        \u0027Off\u0027: states.POWER_OFF,"},{"line_number":281,"context_line":"        \u0027PoweringOn\u0027: states.POWER_OFF,"},{"line_number":282,"context_line":"        \u0027Resetting\u0027: states.REBOOT"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    return power_states_map.get(power_state, states.ERROR)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_d5fa6a73","line":282,"range":{"start_line":278,"start_character":8,"end_line":282,"end_character":34},"updated":"2017-07-25 21:10:43.000000000","message":"Unnecessary.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    :returns: the power state translated"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    power_states_map \u003d {"},{"line_number":278,"context_line":"        \u0027On\u0027: states.POWER_ON,"},{"line_number":279,"context_line":"        \u0027PoweringOff\u0027: states.POWER_ON,"},{"line_number":280,"context_line":"        \u0027Off\u0027: states.POWER_OFF,"},{"line_number":281,"context_line":"        \u0027PoweringOn\u0027: states.POWER_OFF,"},{"line_number":282,"context_line":"        \u0027Resetting\u0027: states.REBOOT"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    return power_states_map.get(power_state, states.ERROR)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_f6a1ca47","line":282,"range":{"start_line":278,"start_character":8,"end_line":282,"end_character":34},"in_reply_to":"ff346bd7_c98512d1","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"a8f3c6591b1f210d56d13904b3b2989741694978","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    :returns: the power state translated"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    power_states_map \u003d {"},{"line_number":278,"context_line":"        \u0027On\u0027: states.POWER_ON,"},{"line_number":279,"context_line":"        \u0027PoweringOff\u0027: states.POWER_ON,"},{"line_number":280,"context_line":"        \u0027Off\u0027: states.POWER_OFF,"},{"line_number":281,"context_line":"        \u0027PoweringOn\u0027: states.POWER_OFF,"},{"line_number":282,"context_line":"        \u0027Resetting\u0027: states.REBOOT"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    return power_states_map.get(power_state, states.ERROR)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_ff7f68dd","line":282,"range":{"start_line":278,"start_character":8,"end_line":282,"end_character":34},"in_reply_to":"ff346bd7_c98512d1","updated":"2017-07-26 17:42:15.000000000","message":"I agree with Hugo.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a3431b1007d53804f236f23b2a57541b9d96a517","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    :returns: the power state translated"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    power_states_map \u003d {"},{"line_number":278,"context_line":"        \u0027On\u0027: states.POWER_ON,"},{"line_number":279,"context_line":"        \u0027PoweringOff\u0027: states.POWER_ON,"},{"line_number":280,"context_line":"        \u0027Off\u0027: states.POWER_OFF,"},{"line_number":281,"context_line":"        \u0027PoweringOn\u0027: states.POWER_OFF,"},{"line_number":282,"context_line":"        \u0027Resetting\u0027: states.REBOOT"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    return power_states_map.get(power_state, states.ERROR)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_c98512d1","line":282,"range":{"start_line":278,"start_character":8,"end_line":282,"end_character":34},"in_reply_to":"ff346bd7_d5fa6a73","updated":"2017-07-26 17:07:57.000000000","message":"I think this is necessary since the hponeview doesn\u0027t have a mapping to power states.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    :returns: the power state translated"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    power_states_map \u003d {"},{"line_number":278,"context_line":"        \u0027On\u0027: states.POWER_ON,"},{"line_number":279,"context_line":"        \u0027PoweringOff\u0027: states.POWER_ON,"},{"line_number":280,"context_line":"        \u0027Off\u0027: states.POWER_OFF,"},{"line_number":281,"context_line":"        \u0027PoweringOn\u0027: states.POWER_OFF,"},{"line_number":282,"context_line":"        \u0027Resetting\u0027: states.REBOOT"},{"line_number":283,"context_line":"    }"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    return power_states_map.get(power_state, states.ERROR)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_361bd2d0","line":282,"range":{"start_line":278,"start_character":8,"end_line":282,"end_character":34},"in_reply_to":"ff346bd7_ff7f68dd","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"eb475f1b203a2450531f0bdf2f518089f71b00e0","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        raise exception.OneViewError(error\u003dmsg)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def translate_oneview_power_state(power_state):"},{"line_number":260,"context_line":"    \"\"\"Translate OneView\u0027s power states strings to Ironic\u0027s format."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    :param: power_state: power state string to be translated"}],"source_content_type":"text/x-python","patch_set":21,"id":"ff346bd7_f6baea6b","line":259,"range":{"start_line":259,"start_character":4,"end_line":259,"end_character":33},"updated":"2017-07-26 21:50:46.000000000","message":"# TODO(xavier): Let\u0027s try to remove that.","commit_id":"873038c963bbb89a22470c4a382ef89cbcd0b973"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"40d311c98b6546441c113f43fd28e89d4704e1ce","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                {\"node\": task.node.uuid, \"message\": exc}"},{"line_number":295,"context_line":"            )"},{"line_number":296,"context_line":"            raise exception.OneViewError(error\u003dexc)"},{"line_number":297,"context_line":"        if not node_has_server_profile:"},{"line_number":298,"context_line":"            raise exception.OperationNotPermitted("},{"line_number":299,"context_line":"                _(\"A Server Profile is not associated with node %s.\") %"},{"line_number":300,"context_line":"                task.node.uuid"}],"source_content_type":"text/x-python","patch_set":24,"id":"ff346bd7_fc784b90","line":297,"range":{"start_line":297,"start_character":15,"end_line":297,"end_character":38},"updated":"2017-07-28 19:32:21.000000000","message":"nit: this variable is being shadowed, maybe to change it to server_profile?","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"8700b758fe97670ff2a6488855a3aee80084b65a","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                {\"node\": task.node.uuid, \"message\": exc}"},{"line_number":295,"context_line":"            )"},{"line_number":296,"context_line":"            raise exception.OneViewError(error\u003dexc)"},{"line_number":297,"context_line":"        if not node_has_server_profile:"},{"line_number":298,"context_line":"            raise exception.OperationNotPermitted("},{"line_number":299,"context_line":"                _(\"A Server Profile is not associated with node %s.\") %"},{"line_number":300,"context_line":"                task.node.uuid"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_67d5e943","line":297,"range":{"start_line":297,"start_character":15,"end_line":297,"end_character":38},"in_reply_to":"ff346bd7_fc784b90","updated":"2017-08-04 20:08:12.000000000","message":"Done","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def get_oneview_client():"},{"line_number":77,"context_line":"    \"\"\"Generate an instance of the OneView client."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    Generates an instance of the OneView client using the imported"},{"line_number":80,"context_line":"    oneview_client library."}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_7da5aa46","line":77,"updated":"2017-09-07 13:48:30.000000000","message":"I\u0027d prefer all the docstring fixes to go in a separate patch","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    return inner"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"def has_server_profile(task, client):"},{"line_number":308,"context_line":"    \"\"\"Checks if the node\u0027s Server Hardware has a Server Profile associated."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    Function to check if the Server Profile is applied to the Server Hardware."}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_5d642e22","line":307,"updated":"2017-09-07 13:48:30.000000000","message":"this function should be renamed, \"has\" implies it returns a boolean. I\u0027d do s/has/ensure/","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    Function to check if the Server Profile is applied to the Server Hardware."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    :param client: an instance of the OneView client"},{"line_number":313,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":314,"context_line":"    \"\"\""},{"line_number":315,"context_line":"    try:"},{"line_number":316,"context_line":"        profile \u003d task.node.driver_info.get(\u0027applied_server_profile_uri\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_3d6962f8","line":313,"updated":"2017-09-07 13:48:30.000000000","message":":raises: ?","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    except client_exception.HPOneViewException as exc:"},{"line_number":319,"context_line":"        LOG.error("},{"line_number":320,"context_line":"            \"Failed to get server profile from OneView appliance for\""},{"line_number":321,"context_line":"            \" node %(node)s. Error: %(message)s\","},{"line_number":322,"context_line":"            {\"node\": task.node.uuid, \"message\": exc}"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":"        raise exception.OneViewError(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_1d6a26ec","line":321,"updated":"2017-09-07 13:48:30.000000000","message":"nit: I\u0027d include the profile uri","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"}],"ironic/drivers/modules/oneview/deploy_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":137,"context_line":"def _create_profile_from_template("},{"line_number":138,"context_line":"    hponeview_client, server_profile_name,"},{"line_number":139,"context_line":"    server_hardware_uri, server_profile_template"},{"line_number":140,"context_line":"):"},{"line_number":141,"context_line":"    \"\"\"Create a server profile from a server profile template."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param hponeview_client: an hpOneView Client instance"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_4a29f598","line":140,"updated":"2017-07-05 02:26:46.000000000","message":"nit: The tendency for ironic is to not place this on the next line.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"f25cc02518cb8c6b458214117c0b0d9dc708e5d1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"def _create_profile_from_template("},{"line_number":138,"context_line":"    hponeview_client, server_profile_name,"},{"line_number":139,"context_line":"    server_hardware_uri, server_profile_template"},{"line_number":140,"context_line":"):"},{"line_number":141,"context_line":"    \"\"\"Create a server profile from a server profile template."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param hponeview_client: an hpOneView Client instance"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_52a755be","line":140,"in_reply_to":"3f1d235d_4a29f598","updated":"2017-07-05 16:44:59.000000000","message":"Thanks for the advice, I\u0027ll change this now.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"hpOneView_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_35f4165b","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":0},"updated":"2017-07-25 21:10:43.000000000","message":"Remove blank line.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"hpOneView_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_4f11fb51","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":0},"in_reply_to":"ff346bd7_35f4165b","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                     \"from node %(node_uuid)s in OneView.\","},{"line_number":375,"context_line":"                     {\u0027server_profile_uri\u0027: server_profile_uri,"},{"line_number":376,"context_line":"                      \u0027node_uuid\u0027: node.uuid})"},{"line_number":377,"context_line":"        except (ValueError, hpOneView_exception.HPOneViewException) as e:"},{"line_number":378,"context_line":"            msg \u003d (_(\"Error while deleting applied Server Profile from node \""},{"line_number":379,"context_line":"                     \"%(node_uuid)s. Error: %(error)s\") %"},{"line_number":380,"context_line":"                   {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_353536f8","line":377,"range":{"start_line":377,"start_character":16,"end_line":377,"end_character":26},"updated":"2017-07-25 21:10:43.000000000","message":"Please, remove it. It was only necessary because of https://github.com/openstack/python-oneviewclient/blob/7fcda18be06620e5526e574d2ff8bd612f3eb52a/oneview_client/client.py#L597 on python-oneviewclient.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                     \"from node %(node_uuid)s in OneView.\","},{"line_number":375,"context_line":"                     {\u0027server_profile_uri\u0027: server_profile_uri,"},{"line_number":376,"context_line":"                      \u0027node_uuid\u0027: node.uuid})"},{"line_number":377,"context_line":"        except (ValueError, hpOneView_exception.HPOneViewException) as e:"},{"line_number":378,"context_line":"            msg \u003d (_(\"Error while deleting applied Server Profile from node \""},{"line_number":379,"context_line":"                     \"%(node_uuid)s. Error: %(error)s\") %"},{"line_number":380,"context_line":"                   {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_ef4e6f6d","line":377,"range":{"start_line":377,"start_character":16,"end_line":377,"end_character":26},"in_reply_to":"ff346bd7_353536f8","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"40d311c98b6546441c113f43fd28e89d4704e1ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":29,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ff346bd7_bc5ac37f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":16},"updated":"2017-07-28 19:32:21.000000000","message":"Why is it client_exception here and hpOneView_exception on common.py?","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"8700b758fe97670ff2a6488855a3aee80084b65a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":29,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_67acc8ec","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":16},"in_reply_to":"ff346bd7_bc5ac37f","updated":"2017-08-04 20:08:12.000000000","message":"Done","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"40d311c98b6546441c113f43fd28e89d4704e1ce","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    :param client: an OneView Client instance"},{"line_number":141,"context_line":"    :param server_profile_name: the name of the new server profile"},{"line_number":142,"context_line":"    :param server_hardware_uri: the server_hardware assigned to server profile"},{"line_number":143,"context_line":"    :param server_profile_template: the server profile template"},{"line_number":144,"context_line":"    :returns: The new server profile generated with the name and server"},{"line_number":145,"context_line":"              hardware passed on parameters"},{"line_number":146,"context_line":"    :raises HPOneViewException: if the communication with OneView fails"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_f402763e","line":143,"range":{"start_line":143,"start_character":40,"end_line":143,"end_character":63},"updated":"2017-07-28 19:32:21.000000000","message":"nit:s/server_profile_template/server_profile_template id or uri/","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"8700b758fe97670ff2a6488855a3aee80084b65a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    :param client: an OneView Client instance"},{"line_number":141,"context_line":"    :param server_profile_name: the name of the new server profile"},{"line_number":142,"context_line":"    :param server_hardware_uri: the server_hardware assigned to server profile"},{"line_number":143,"context_line":"    :param server_profile_template: the server profile template"},{"line_number":144,"context_line":"    :returns: The new server profile generated with the name and server"},{"line_number":145,"context_line":"              hardware passed on parameters"},{"line_number":146,"context_line":"    :raises HPOneViewException: if the communication with OneView fails"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_8710cc58","line":143,"range":{"start_line":143,"start_character":40,"end_line":143,"end_character":63},"in_reply_to":"df3967d1_f402763e","updated":"2017-08-04 20:08:12.000000000","message":"Done","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"40d311c98b6546441c113f43fd28e89d4704e1ce","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    server_profile[\u0027serverHardwareUri\u0027] \u003d server_hardware_uri"},{"line_number":154,"context_line":"    server_profile[\u0027serverProfileTemplateUri\u0027] \u003d \"\""},{"line_number":155,"context_line":"    client.server_profiles.create(server_profile)"},{"line_number":156,"context_line":"    return client.server_profiles.get_by_name(server_profile_name)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def _is_node_in_use(server_hardware, applied_sp_uri, by_oneview\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_d43ad232","line":156,"range":{"start_line":156,"start_character":11,"end_line":156,"end_character":66},"updated":"2017-07-28 19:32:21.000000000","message":"This may be replaced by client.server_profiles.create(server_profile) since the create method returns the created resource (in this case server_profile) after it is created.","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"8700b758fe97670ff2a6488855a3aee80084b65a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    server_profile[\u0027serverHardwareUri\u0027] \u003d server_hardware_uri"},{"line_number":154,"context_line":"    server_profile[\u0027serverProfileTemplateUri\u0027] \u003d \"\""},{"line_number":155,"context_line":"    client.server_profiles.create(server_profile)"},{"line_number":156,"context_line":"    return client.server_profiles.get_by_name(server_profile_name)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def _is_node_in_use(server_hardware, applied_sp_uri, by_oneview\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_472d44a6","line":156,"range":{"start_line":156,"start_character":11,"end_line":156,"end_character":66},"in_reply_to":"df3967d1_d43ad232","updated":"2017-08-04 20:08:12.000000000","message":"doh. done (:","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        # applied_server_profile_uri exists and is equal to Server profile"},{"line_number":318,"context_line":"        # applied on Hardware. Do not apply again."},{"line_number":319,"context_line":"        if ("},{"line_number":320,"context_line":"            applied_sp_uri and server_hardware.get(\u0027serverProfileUri\u0027) and"},{"line_number":321,"context_line":"            server_hardware.get(\u0027serverProfileUri\u0027) \u003d\u003d applied_sp_uri"},{"line_number":322,"context_line":"        ):"},{"line_number":323,"context_line":"            LOG.info("}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_fd6e3afe","line":320,"updated":"2017-09-07 13:48:30.000000000","message":"nit: one of the first 2 checks is redundant because of the 3rd check","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"}],"ironic/drivers/modules/oneview/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":46,"context_line":"oneview_exceptions \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def set_pxe_onetime_boot(oneview_client, server_hardware):"},{"line_number":50,"context_line":"    \"\"\"Change the boot of the server hardware to pxe and enables onetime boot."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Change the boot on hardware to pxe and enables the onetime boot using"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_259dcabb","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":24},"updated":"2017-07-05 02:26:46.000000000","message":"Based on recent discussions, perhaps retooling, or maybe this is premature to include in this patch series?","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"f25cc02518cb8c6b458214117c0b0d9dc708e5d1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"oneview_exceptions \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def set_pxe_onetime_boot(oneview_client, server_hardware):"},{"line_number":50,"context_line":"    \"\"\"Change the boot of the server hardware to pxe and enables onetime boot."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Change the boot on hardware to pxe and enables the onetime boot using"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_607f1415","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":24},"in_reply_to":"3f1d235d_259dcabb","updated":"2017-07-05 16:44:59.000000000","message":"The method was changed to receive a device instead of putting always Pxe.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        server_hardware"},{"line_number":60,"context_line":"    )"},{"line_number":61,"context_line":"    host_ip, ilo_token \u003d common.get_ilo_access(remote_console)"},{"line_number":62,"context_line":"    ilo_client \u003d common.get_ilorest_client(\"http://\" + host_ip, ilo_token)"},{"line_number":63,"context_line":"    body \u003d {"},{"line_number":64,"context_line":"        \"Boot\": {"},{"line_number":65,"context_line":"            \"BootSourceOverrideTarget\": \"Pxe\","}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_853ffeb2","line":62,"range":{"start_line":62,"start_character":44,"end_line":62,"end_character":51},"updated":"2017-07-05 02:26:46.000000000","message":"I\u0027m fairly sure ilo\u0027s can be set to https, so is this a correct assumption to default to http?\n\nAlso, perhaps the client invocation should figure that out?","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"    headers \u003d {\"Content-Type\": \"application/json\"}"},{"line_number":70,"context_line":"    ilo_client.patch(path\u003d\u0027/rest/v1/Systems/1\u0027, body\u003dbody, headers\u003dheaders)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def set_boot_device_to_profile(oneview_client, boot_device, server_profile):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_05540efe","line":70,"range":{"start_line":70,"start_character":44,"end_line":70,"end_character":45},"updated":"2017-07-05 02:26:46.000000000","message":"I\u0027m 99% sure this won\u0027t work on moonshot gear, but I\u0027m also not sure that matters :)","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def set_onetime_boot(oneview_client, server_hardware, device):"},{"line_number":61,"context_line":"    \"\"\"Change the boot of the server hardware to pxe and enables onetime boot."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    Change the boot on hardware to pxe and enables the onetime boot using"},{"line_number":64,"context_line":"    python-ilorest-library client to set it."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    :param oneview_client: an instance of a python-hpOneView-client"},{"line_number":67,"context_line":"    :param server_hardware: an Oneview Server Hardware uri"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_0088ae1c","line":64,"range":{"start_line":63,"start_character":4,"end_line":64,"end_character":44},"updated":"2017-07-25 21:10:43.000000000","message":"Now it doesn\u0027t only set pxe as boot device option. Update the docstring.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    Change the boot on hardware to pxe and enables the onetime boot using"},{"line_number":64,"context_line":"    python-ilorest-library client to set it."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    :param oneview_client: an instance of a python-hpOneView-client"},{"line_number":67,"context_line":"    :param server_hardware: an Oneview Server Hardware uri"},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    ilo_client \u003d common.get_ilorest_client(oneview_client, server_hardware)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_40a596b4","line":66,"range":{"start_line":66,"start_character":44,"end_line":66,"end_character":67},"updated":"2017-07-25 21:10:43.000000000","message":"s/python-hpOneView-client/python-hpOneView/","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a3431b1007d53804f236f23b2a57541b9d96a517","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                  {\"device\": device, \"node\": task.node.uuid})"},{"line_number":175,"context_line":"        try:"},{"line_number":176,"context_line":"            oneview_device \u003d BOOT_DEVICE_MAPPING_TO_OV.get(device)"},{"line_number":177,"context_line":"            ilo_device \u003d BOOT_DEVICE_MAPPING_TO_ILO.get(device)"},{"line_number":178,"context_line":"            set_boot_device_to_profile("},{"line_number":179,"context_line":"                self.hponeview_client, oneview_device, uri)"},{"line_number":180,"context_line":"            if not persistent:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_4ce1302a","line":177,"updated":"2017-07-26 17:07:57.000000000","message":"Change this to line 181, since this only will be used if not persistent.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                % {\"device\": primary_device, \"node\": task.node.uuid}"},{"line_number":218,"context_line":"            )"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        boot_device \u003d {"},{"line_number":221,"context_line":"            \u0027boot_device\u0027: BOOT_DEVICE_OV_TO_GENERIC.get(primary_device),"},{"line_number":222,"context_line":"            \u0027persistent\u0027: True,"},{"line_number":223,"context_line":"        }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return boot_device"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @METRICS.timer(\u0027OneViewManagement.get_sensors_data\u0027)"},{"line_number":228,"context_line":"    def get_sensors_data(self, task):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_80ec9ef3","line":225,"range":{"start_line":220,"start_character":0,"end_line":225,"end_character":26},"updated":"2017-07-25 21:10:43.000000000","message":"Please, report a bug on ironic launchpad for the implementation of get_boot_device considering the persistent information from the server hardware\u0027s iLO.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a3431b1007d53804f236f23b2a57541b9d96a517","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                % {\"device\": primary_device, \"node\": task.node.uuid}"},{"line_number":218,"context_line":"            )"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        boot_device \u003d {"},{"line_number":221,"context_line":"            \u0027boot_device\u0027: BOOT_DEVICE_OV_TO_GENERIC.get(primary_device),"},{"line_number":222,"context_line":"            \u0027persistent\u0027: True,"},{"line_number":223,"context_line":"        }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return boot_device"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @METRICS.timer(\u0027OneViewManagement.get_sensors_data\u0027)"},{"line_number":228,"context_line":"    def get_sensors_data(self, task):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_8cc4b892","line":225,"range":{"start_line":220,"start_character":0,"end_line":225,"end_character":26},"in_reply_to":"ff346bd7_80ec9ef3","updated":"2017-07-26 17:07:57.000000000","message":"If this is a new bug, maybe another patch. WDYT?","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"a8f3c6591b1f210d56d13904b3b2989741694978","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                % {\"device\": primary_device, \"node\": task.node.uuid}"},{"line_number":218,"context_line":"            )"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        boot_device \u003d {"},{"line_number":221,"context_line":"            \u0027boot_device\u0027: BOOT_DEVICE_OV_TO_GENERIC.get(primary_device),"},{"line_number":222,"context_line":"            \u0027persistent\u0027: True,"},{"line_number":223,"context_line":"        }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        return boot_device"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @METRICS.timer(\u0027OneViewManagement.get_sensors_data\u0027)"},{"line_number":228,"context_line":"    def get_sensors_data(self, task):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_3fb3b04f","line":225,"range":{"start_line":220,"start_character":0,"end_line":225,"end_character":26},"in_reply_to":"ff346bd7_80ec9ef3","updated":"2017-07-26 17:42:15.000000000","message":"The bug is open: https://bugs.launchpad.net/ironic/+bug/1706725","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"40d311c98b6546441c113f43fd28e89d4704e1ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ironic.drivers.modules.oneview import common"},{"line_number":26,"context_line":"from ironic.drivers.modules.oneview import deploy_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":29,"context_line":"oneview_exceptions \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_9ad6b1f1","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":16},"updated":"2017-07-28 19:32:21.000000000","message":"ditto","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"8700b758fe97670ff2a6488855a3aee80084b65a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ironic.drivers.modules.oneview import common"},{"line_number":26,"context_line":"from ironic.drivers.modules.oneview import deploy_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":29,"context_line":"oneview_exceptions \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_47b7843b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":16},"in_reply_to":"df3967d1_9ad6b1f1","updated":"2017-08-04 20:08:12.000000000","message":"Done","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e4476ef99da109176955d33704d3af2d20275024","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            server_hardware \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":70,"context_line":"            ilo_client \u003d common.get_ilorest_client(client, server_hardware)"},{"line_number":71,"context_line":"            boot_device \u003d BOOT_DEVICE_MAP_ILO.get(boot_device)"},{"line_number":72,"context_line":"            path \u003d \u0027/rest/v1/Systems/1\u0027"},{"line_number":73,"context_line":"            body \u003d {"},{"line_number":74,"context_line":"                \"Boot\": {"},{"line_number":75,"context_line":"                    \"BootSourceOverrideTarget\": boot_device,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7f287b81_0dea3174","line":72,"range":{"start_line":72,"start_character":19,"end_line":72,"end_character":39},"updated":"2017-09-05 19:29:02.000000000","message":"my only objection is that it is hardcoded to the first system node. Of course, I don\u0027t think any of the hardware this driver officially supports uses it, although no sense in blocking over it, and I don\u0027t know if you can even detect it.","commit_id":"de39d932d06f42fcfe2bfd3bcbe9ece7681dabf1"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"60995c38ad9e51ceac422181113d44ba61869657","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            server_hardware \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":70,"context_line":"            ilo_client \u003d common.get_ilorest_client(client, server_hardware)"},{"line_number":71,"context_line":"            boot_device \u003d BOOT_DEVICE_MAP_ILO.get(boot_device)"},{"line_number":72,"context_line":"            path \u003d \u0027/rest/v1/Systems/1\u0027"},{"line_number":73,"context_line":"            body \u003d {"},{"line_number":74,"context_line":"                \"Boot\": {"},{"line_number":75,"context_line":"                    \"BootSourceOverrideTarget\": boot_device,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7f287b81_33ac158b","line":72,"range":{"start_line":72,"start_character":19,"end_line":72,"end_character":39},"in_reply_to":"7f287b81_0dea3174","updated":"2017-09-06 15:04:15.000000000","message":"The iLO session opened by single sign on to OneView is exclusive to a given Server Hardware, so the \"Systems\" collection will only have a single element.\n\nThis is different from an ideal scenario where OneView answers redfish requests and exposes all resources to be queried using this lib. In fact, newer iLO versions answers redfish requests, though each machine is a different redfish infra resulting in a single element at System collection...","commit_id":"de39d932d06f42fcfe2bfd3bcbe9ece7681dabf1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":61,"context_line":"    next_boot_device \u003d driver_internal_info.get(\u0027next_boot_device\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    if next_boot_device:"},{"line_number":64,"context_line":"        boot_device \u003d next_boot_device.get(\u0027boot_device\u0027)"},{"line_number":65,"context_line":"        persistent \u003d next_boot_device.get(\u0027persistent\u0027)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_dd77fed3","line":63,"updated":"2017-09-07 13:48:30.000000000","message":"nit: I\u0027d reverse it for readability\n\n if not next_boot_device:\n     return","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        boot_device \u003d next_boot_device.get(\u0027boot_device\u0027)"},{"line_number":65,"context_line":"        persistent \u003d next_boot_device.get(\u0027persistent\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not persistent:"},{"line_number":68,"context_line":"            client \u003d common.get_hponeview_client()"},{"line_number":69,"context_line":"            server_hardware \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":70,"context_line":"            ilo_client \u003d common.get_ilorest_client(client, server_hardware)"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_bd7432d0","line":67,"updated":"2017-09-07 13:48:30.000000000","message":"ditto","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            server_profile \u003d client.server_profiles.get(profile)"},{"line_number":116,"context_line":"            boot \u003d server_profile.get(\u0027boot\u0027)"},{"line_number":117,"context_line":"            order \u003d boot.get(\u0027order\u0027)"},{"line_number":118,"context_line":"            order.remove(boot_device)"},{"line_number":119,"context_line":"            order.insert(0, boot_device)"},{"line_number":120,"context_line":"            boot[\u0027order\u0027] \u003d order"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_9d7df6b3","line":117,"updated":"2017-09-07 13:48:30.000000000","message":"this will raise TypeError if boot is None (you use get() above)","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20491c5f1cc5f010f622a8757b07b95c75595821","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            server_profile \u003d client.server_profiles.get(profile)"},{"line_number":116,"context_line":"            boot \u003d server_profile.get(\u0027boot\u0027)"},{"line_number":117,"context_line":"            order \u003d boot.get(\u0027order\u0027)"},{"line_number":118,"context_line":"            order.remove(boot_device)"},{"line_number":119,"context_line":"            order.insert(0, boot_device)"},{"line_number":120,"context_line":"            boot[\u0027order\u0027] \u003d order"},{"line_number":121,"context_line":"            server_profile[\u0027boot\u0027] \u003d boot"}],"source_content_type":"text/x-python","patch_set":35,"id":"7f287b81_7d7a4aba","line":118,"updated":"2017-09-07 13:48:30.000000000","message":"this will raise ValueError if boot_device is not in order and AttributeError if order is None (again, you use get() above)","commit_id":"0ed998dfc81109f3a09100cb3b128e692be92e20"}],"ironic/drivers/modules/oneview/power.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        hardware \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            for operation in SET_POWER_STATE_MAP.get(power_state):"},{"line_number":150,"context_line":"                self.client.server_hardware.update_power_state("},{"line_number":151,"context_line":"                    operation,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_3c756bcd","line":148,"updated":"2017-05-26 03:56:56.000000000","message":"redundant newline","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        hardware \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            for operation in SET_POWER_STATE_MAP.get(power_state):"},{"line_number":150,"context_line":"                self.client.server_hardware.update_power_state("},{"line_number":151,"context_line":"                    operation,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_849d355b","line":148,"in_reply_to":"ff0f0b1f_3c756bcd","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"40d311c98b6546441c113f43fd28e89d4704e1ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ironic.drivers.modules.oneview import common"},{"line_number":26,"context_line":"from ironic.drivers.modules.oneview import deploy_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":29,"context_line":"oneview_exceptions \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_da09d931","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":16},"updated":"2017-07-28 19:32:21.000000000","message":"ditto","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"8700b758fe97670ff2a6488855a3aee80084b65a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ironic.drivers.modules.oneview import common"},{"line_number":26,"context_line":"from ironic.drivers.modules.oneview import deploy_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":29,"context_line":"oneview_exceptions \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_27b2404a","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":16},"in_reply_to":"df3967d1_da09d931","updated":"2017-08-04 20:08:12.000000000","message":"Done","commit_id":"30d9418fc6468b3d875edac5ad0e231495269590"}],"ironic/drivers/oneview.py":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"OneView Driver and supporting meta-classes.\"\"\""},{"line_number":17,"context_line":"from oslo_utils import importutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_c0c74645","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":45},"updated":"2017-07-25 21:10:43.000000000","message":"What is this?","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"OneView Driver and supporting meta-classes.\"\"\""},{"line_number":17,"context_line":"from oslo_utils import importutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_00b66eda","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":17},"updated":"2017-07-25 21:10:43.000000000","message":"s/Driver/Drivers/","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"OneView Driver and supporting meta-classes.\"\"\""},{"line_number":17,"context_line":"from oslo_utils import importutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_8f800348","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":45},"in_reply_to":"ff346bd7_494fe233","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"a8f3c6591b1f210d56d13904b3b2989741694978","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"OneView Driver and supporting meta-classes.\"\"\""},{"line_number":17,"context_line":"from oslo_utils import importutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_494fe233","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":45},"in_reply_to":"ff346bd7_c0c74645","updated":"2017-07-26 17:42:15.000000000","message":"It is not related to the patch.\nJust format of docstring","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"}],"ironic/tests/unit/drivers/modules/oneview/test_deploy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_reboot_and_finish_deploy_soft_poweroff_doesnt_complete("},{"line_number":312,"context_line":"        self, node_set_boot_device, power_off_mock, get_power_state_mock,"},{"line_number":313,"context_line":"        node_power_action_mock, mock_get_ov_client"},{"line_number":314,"context_line":"    ):"},{"line_number":315,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":316,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":317,"context_line":"        self.node.driver_info[\u0027applied_server_profile_uri\u0027] \u003d \u0027applied_sp_uri\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_65bd0201","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":6},"updated":"2017-07-05 02:26:46.000000000","message":"I noted on this in one of the other files, but stylistic changes such as this does make this harder for the reviewers to review because it is largely unrelated.  If possible, please be conscious of this, and attempt to avoid it when possible.  Purely style changes are also easy to review if you want to go change the style before/after. Thanks!","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"f25cc02518cb8c6b458214117c0b0d9dc708e5d1","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_reboot_and_finish_deploy_soft_poweroff_doesnt_complete("},{"line_number":312,"context_line":"        self, node_set_boot_device, power_off_mock, get_power_state_mock,"},{"line_number":313,"context_line":"        node_power_action_mock, mock_get_ov_client"},{"line_number":314,"context_line":"    ):"},{"line_number":315,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":316,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":317,"context_line":"        self.node.driver_info[\u0027applied_server_profile_uri\u0027] \u003d \u0027applied_sp_uri\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_7d958732","line":314,"range":{"start_line":314,"start_character":0,"end_line":314,"end_character":6},"in_reply_to":"3f1d235d_65bd0201","updated":"2017-07-05 16:44:59.000000000","message":"Thanks for the tip, Julia, the style was already changed.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"}],"ironic/tests/unit/drivers/modules/oneview/test_deploy_utils.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        profile \u003d \u0027/rest/server-profile/123456789\u0027"},{"line_number":215,"context_line":"        hardware \u003d dict(serverProfileUri\u003dprofile)"},{"line_number":216,"context_line":"        self.client.server_hardware.get.return_value \u003d hardware"},{"line_number":217,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":218,"context_line":"            self.assertTrue("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_9c4fd791","line":215,"range":{"start_line":215,"start_character":19,"end_line":215,"end_character":49},"updated":"2017-05-26 03:56:56.000000000","message":"just use literal dictionary","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        \"\"\"Node has no Server Profile."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        hardware \u003d dict(serverProfileUri\u003dNone)"},{"line_number":232,"context_line":"        self.client.server_hardware.get.return_value \u003d hardware"},{"line_number":233,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":234,"context_line":"            self.assertFalse("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_fc57f325","line":231,"range":{"start_line":231,"start_character":19,"end_line":231,"end_character":46},"updated":"2017-05-26 03:56:56.000000000","message":"ditto","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        profile \u003d self.node.driver_info.get(\u0027applied_server_profile_uri\u0027)"},{"line_number":248,"context_line":"        hardware \u003d dict(serverProfileUri\u003dprofile)"},{"line_number":249,"context_line":"        self.client.server_hardware.get.return_value \u003d hardware"},{"line_number":250,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":251,"context_line":"            self.assertFalse("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_9c3477fd","line":248,"range":{"start_line":248,"start_character":19,"end_line":248,"end_character":49},"updated":"2017-05-26 03:56:56.000000000","message":"ditto","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"}],"ironic/tests/unit/drivers/modules/oneview/test_management.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                       spect_set\u003dTrue, autospec\u003dTrue)"},{"line_number":65,"context_line":"    def test_validate(self, mock_validate, mock_get_ov_client):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        "},{"line_number":68,"context_line":"        oneview_client \u003d mock_get_ov_client()"},{"line_number":69,"context_line":"        self.driver.management.oneview_client \u003d oneview_client"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_7c39a3f0","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":8},"updated":"2017-05-26 03:56:56.000000000","message":"remove this","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                       spect_set\u003dTrue, autospec\u003dTrue)"},{"line_number":65,"context_line":"    def test_validate(self, mock_validate, mock_get_ov_client):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        "},{"line_number":68,"context_line":"        oneview_client \u003d mock_get_ov_client()"},{"line_number":69,"context_line":"        self.driver.management.oneview_client \u003d oneview_client"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_04ffe5aa","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":8},"in_reply_to":"ff0f0b1f_7c39a3f0","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            )"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_get_supported_boot_devices(self, mock_get_ov_client):"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":206,"context_line":"            expected \u003d [boot_devices.PXE, boot_devices.DISK,"},{"line_number":207,"context_line":"                        boot_devices.CDROM]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_1c2067b0","line":204,"updated":"2017-05-26 03:56:56.000000000","message":"just don\u0027t add a newline","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            )"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_get_supported_boot_devices(self, mock_get_ov_client):"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":206,"context_line":"            expected \u003d [boot_devices.PXE, boot_devices.DISK,"},{"line_number":207,"context_line":"                        boot_devices.CDROM]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_441efd0c","line":204,"in_reply_to":"ff0f0b1f_1c2067b0","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                self.assertTrue(self.client.server_profiles.get.called)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def test_get_boot_device_fail(self, mock_get_ov_client):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        exc \u003d client_exception.HPOneViewException() "},{"line_number":230,"context_line":"        self.client.server_profiles.get.side_effect \u003d exc"},{"line_number":231,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_fc2c93ad","line":228,"updated":"2017-05-26 03:56:56.000000000","message":"ditto","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                self.assertTrue(self.client.server_profiles.get.called)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def test_get_boot_device_fail(self, mock_get_ov_client):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        exc \u003d client_exception.HPOneViewException() "},{"line_number":230,"context_line":"        self.client.server_profiles.get.side_effect \u003d exc"},{"line_number":231,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_04eda5ee","line":228,"in_reply_to":"ff0f0b1f_fc2c93ad","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            self.assertTrue(self.client.server_profiles.get.called)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_get_boot_device_unknown_device(self, mock_get_ov_client):"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        order \u003d [\u0027Eggs\u0027, \u0027Bacon\u0027]"},{"line_number":240,"context_line":"        profile \u003d dict(boot\u003ddict(order\u003dorder))"},{"line_number":241,"context_line":"        self.client.server_profiles.get.return_value \u003d profile"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_bc185b84","line":238,"updated":"2017-05-26 03:56:56.000000000","message":"ditto","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            self.assertTrue(self.client.server_profiles.get.called)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_get_boot_device_unknown_device(self, mock_get_ov_client):"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        order \u003d [\u0027Eggs\u0027, \u0027Bacon\u0027]"},{"line_number":240,"context_line":"        profile \u003d dict(boot\u003ddict(order\u003dorder))"},{"line_number":241,"context_line":"        self.client.server_profiles.get.return_value \u003d profile"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_44ccbd88","line":238,"in_reply_to":"ff0f0b1f_bc185b84","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def test_get_boot_device_unknown_device(self, mock_get_ov_client):"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        order \u003d [\u0027Eggs\u0027, \u0027Bacon\u0027]"},{"line_number":240,"context_line":"        profile \u003d dict(boot\u003ddict(order\u003dorder))"},{"line_number":241,"context_line":"        self.client.server_profiles.get.return_value \u003d profile"},{"line_number":242,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":243,"context_line":"            self.assertRaises("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_3c0c4b41","line":240,"range":{"start_line":240,"start_character":18,"end_line":240,"end_character":46},"updated":"2017-05-26 03:56:56.000000000","message":"literal dictionary","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            )"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_get_sensors_data_not_implemented(self, mock_get_ov_client):"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":252,"context_line":"            self.assertRaises("},{"line_number":253,"context_line":"                NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_1c098730","line":250,"updated":"2017-05-26 03:56:56.000000000","message":"extra newline for what?","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            )"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_get_sensors_data_not_implemented(self, mock_get_ov_client):"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":252,"context_line":"            self.assertRaises("},{"line_number":253,"context_line":"                NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_04c6c568","line":250,"in_reply_to":"ff0f0b1f_1c098730","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@mock.patch.object(common, \u0027get_hponeview_client\u0027)"},{"line_number":41,"context_line":"class OneViewManagementDriverTestCase(db_base.DbTestCase):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        super(OneViewManagementDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_407d96e5","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":37},"updated":"2017-07-25 21:10:43.000000000","message":"Missing tests for `set_onetime_boot` and `set_boot_device_to_profile.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@mock.patch.object(common, \u0027get_hponeview_client\u0027)"},{"line_number":41,"context_line":"class OneViewManagementDriverTestCase(db_base.DbTestCase):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        super(OneViewManagementDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_ef38afa0","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":37},"in_reply_to":"ff346bd7_299dbebb","updated":"2017-07-27 20:56:58.000000000","message":"Sorry.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a3431b1007d53804f236f23b2a57541b9d96a517","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@mock.patch.object(common, \u0027get_hponeview_client\u0027)"},{"line_number":41,"context_line":"class OneViewManagementDriverTestCase(db_base.DbTestCase):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        super(OneViewManagementDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_6c9cf469","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":37},"in_reply_to":"ff346bd7_407d96e5","updated":"2017-07-26 17:07:57.000000000","message":"Line 99 and 141?","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"a8f3c6591b1f210d56d13904b3b2989741694978","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@mock.patch.object(common, \u0027get_hponeview_client\u0027)"},{"line_number":41,"context_line":"class OneViewManagementDriverTestCase(db_base.DbTestCase):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        super(OneViewManagementDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_299dbebb","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":37},"in_reply_to":"ff346bd7_407d96e5","updated":"2017-07-26 17:42:15.000000000","message":"test_set_onetime_boot is at line 152\n `set_boot_device_to_profile line 99","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@mock.patch.object(common, \u0027get_hponeview_client\u0027)"},{"line_number":41,"context_line":"class OneViewManagementDriverTestCase(db_base.DbTestCase):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        super(OneViewManagementDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_0fbad308","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":37},"in_reply_to":"ff346bd7_6c9cf469","updated":"2017-07-27 20:56:58.000000000","message":"Sorry.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"}],"ironic/tests/unit/drivers/modules/oneview/test_power.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":87,"context_line":"                              task.driver.power.validate, task)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_power_interface_validate_fail_exception(self, "},{"line_number":90,"context_line":"                                                     mock_get_ov_client):"},{"line_number":91,"context_line":"        exc \u003d client_exception.HPOneViewException()"},{"line_number":92,"context_line":"        self.client.server_hardware.update_power_state.side_effect \u003d exc"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_dc02ef0b","line":89,"range":{"start_line":89,"start_character":58,"end_line":89,"end_character":59},"updated":"2017-05-26 03:56:56.000000000","message":"remove this","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":87,"context_line":"                              task.driver.power.validate, task)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_power_interface_validate_fail_exception(self, "},{"line_number":90,"context_line":"                                                     mock_get_ov_client):"},{"line_number":91,"context_line":"        exc \u003d client_exception.HPOneViewException()"},{"line_number":92,"context_line":"        self.client.server_hardware.update_power_state.side_effect \u003d exc"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_046a457f","line":89,"range":{"start_line":89,"start_character":58,"end_line":89,"end_character":59},"in_reply_to":"ff0f0b1f_dc02ef0b","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        exc \u003d client_exception.HPOneViewException()"},{"line_number":204,"context_line":"        self.client.server_hardware.update_power_state.side_effect \u003d exc"},{"line_number":205,"context_line":"        "},{"line_number":206,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":207,"context_line":"                                  self.node.uuid) as task:"},{"line_number":208,"context_line":"            self.assertRaises(exception.OneViewError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_d7176845","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":8},"updated":"2017-05-26 03:56:56.000000000","message":"remove this","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        exc \u003d client_exception.HPOneViewException()"},{"line_number":204,"context_line":"        self.client.server_hardware.update_power_state.side_effect \u003d exc"},{"line_number":205,"context_line":"        "},{"line_number":206,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":207,"context_line":"                                  self.node.uuid) as task:"},{"line_number":208,"context_line":"            self.assertRaises(exception.OneViewError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_8445351a","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":8},"in_reply_to":"ff0f0b1f_d7176845","updated":"2017-05-29 16:17:42.000000000","message":"Done","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"a782f3f20592b8987d6aceab35f753c7b7210780","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":130,"context_line":"            uri \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":131,"context_line":"            self.driver.power.set_power_state(task, states.POWER_ON)"},{"line_number":132,"context_line":"            oneview_client.server_hardware.\\"},{"line_number":133,"context_line":"                update_power_state.assert_called_once_with(expected, uri)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_set_power_off(self, mock_get_ov_client):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_20a05243","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":44},"updated":"2017-07-25 21:10:43.000000000","message":"Please, do not do that.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a3431b1007d53804f236f23b2a57541b9d96a517","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":130,"context_line":"            uri \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":131,"context_line":"            self.driver.power.set_power_state(task, states.POWER_ON)"},{"line_number":132,"context_line":"            oneview_client.server_hardware.\\"},{"line_number":133,"context_line":"                update_power_state.assert_called_once_with(expected, uri)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_set_power_off(self, mock_get_ov_client):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_acd2dcfe","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":44},"in_reply_to":"ff346bd7_20a05243","updated":"2017-07-26 17:07:57.000000000","message":"I don\u0027t think there\u0027s another way to break this line.","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":130,"context_line":"            uri \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":131,"context_line":"            self.driver.power.set_power_state(task, states.POWER_ON)"},{"line_number":132,"context_line":"            oneview_client.server_hardware.\\"},{"line_number":133,"context_line":"                update_power_state.assert_called_once_with(expected, uri)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_set_power_off(self, mock_get_ov_client):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_b602223c","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":44},"in_reply_to":"ff346bd7_42457742","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"f938d0e8318ef627653f35e513286ada2ff3e98f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":130,"context_line":"            uri \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":131,"context_line":"            self.driver.power.set_power_state(task, states.POWER_ON)"},{"line_number":132,"context_line":"            oneview_client.server_hardware.\\"},{"line_number":133,"context_line":"                update_power_state.assert_called_once_with(expected, uri)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_set_power_off(self, mock_get_ov_client):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_76f83a48","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":44},"in_reply_to":"ff346bd7_acd2dcfe","updated":"2017-07-27 20:56:58.000000000","message":"Done","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"a8f3c6591b1f210d56d13904b3b2989741694978","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":130,"context_line":"            uri \u003d task.node.driver_info.get(\u0027server_hardware_uri\u0027)"},{"line_number":131,"context_line":"            self.driver.power.set_power_state(task, states.POWER_ON)"},{"line_number":132,"context_line":"            oneview_client.server_hardware.\\"},{"line_number":133,"context_line":"                update_power_state.assert_called_once_with(expected, uri)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_set_power_off(self, mock_get_ov_client):"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_42457742","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":44},"in_reply_to":"ff346bd7_acd2dcfe","updated":"2017-07-26 17:42:15.000000000","message":"I agree with Hugo","commit_id":"62c056f9a86d961346f799b5361a9377e6003868"}],"ironic/tests/unit/drivers/third_party_driver_mock_specs.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"02dff25266bb518bb851e20662b15a2e93e15418","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \u0027exceptions\u0027,"},{"line_number":148,"context_line":")"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"HPONEVIEW_CLS_SPEC \u003d ("},{"line_number":151,"context_line":")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"HPONEVIEW_STATES_SPEC \u003d ("},{"line_number":154,"context_line":"    \u0027ONEVIEW_POWER_OFF\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_373a24cd","line":151,"range":{"start_line":150,"start_character":22,"end_line":151,"end_character":1},"updated":"2017-05-26 03:56:56.000000000","message":"newline for what?","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"3155260a8b1911572e17c85cbf75bbbdb53ca27c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \u0027exceptions\u0027,"},{"line_number":148,"context_line":")"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"HPONEVIEW_CLS_SPEC \u003d ("},{"line_number":151,"context_line":")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"HPONEVIEW_STATES_SPEC \u003d ("},{"line_number":154,"context_line":"    \u0027ONEVIEW_POWER_OFF\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_845e55e4","line":151,"range":{"start_line":150,"start_character":22,"end_line":151,"end_character":1},"in_reply_to":"ff0f0b1f_373a24cd","updated":"2017-05-29 16:17:42.000000000","message":"consistency with L113-L114","commit_id":"c45f5375a1a535ecdd27c1a99bbd48794a51c17b"}],"releasenotes/notes/migrate-oneview-driver-to-use-python-hpOneView-7a90a2c3d4d4737c.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Migrate the code on OneView drivers to stop using python-oneviewclient in"},{"line_number":4,"context_line":"    order to use python-hpOneView and python-ilorest-library. The library"},{"line_number":5,"context_line":"    python-hpOneView is more recent and is being more actively developed and"},{"line_number":6,"context_line":"    maintained."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f1d235d_05676ebf","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":60},"updated":"2017-07-05 02:26:46.000000000","message":"I\u0027m afraid this doesn\u0027t really make sense to me.  This section is intended for someone operating an Ironic deployment, to be aware of what they need to know in order to upgrade the node.  I\u0027m not sure even having a release note on this change makes sense.  The ultimate reasoning behind the change may be better suited for the first patch in the series.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":22970,"name":"Rodrigo Farias de Macedo","email":"rodrigofm@lsd.ufcg.edu.br","username":"rodrigofm"},"change_message_id":"f25cc02518cb8c6b458214117c0b0d9dc708e5d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Migrate the code on OneView drivers to stop using python-oneviewclient in"},{"line_number":4,"context_line":"    order to use python-hpOneView and python-ilorest-library. The library"},{"line_number":5,"context_line":"    python-hpOneView is more recent and is being more actively developed and"},{"line_number":6,"context_line":"    maintained."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f1d235d_00baa008","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":60},"in_reply_to":"3f1d235d_05676ebf","updated":"2017-07-05 16:44:59.000000000","message":"The release note was removed. Done","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Migrate the code on OneView drivers to stop using python-oneviewclient in"},{"line_number":4,"context_line":"    order to use python-hpOneView and python-ilorest-library. The library"},{"line_number":5,"context_line":"    python-hpOneView is more recent and is being more actively developed and"},{"line_number":6,"context_line":"    maintained."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f1d235d_6552a2e0","line":5,"range":{"start_line":5,"start_character":63,"end_line":5,"end_character":76},"updated":"2017-07-05 02:26:46.000000000","message":"nit: \"developed and\" seems like extra information an operator does not need.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1232effd3d46e6a1e5aafa42c18cb44185394847","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Migrate the code on OneView drivers to stop using python-oneviewclient in"},{"line_number":4,"context_line":"    order to use python-hpOneView and python-ilorest-library. The library"},{"line_number":5,"context_line":"    python-hpOneView is more recent and is being more actively developed and"},{"line_number":6,"context_line":"    maintained."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f1d235d_a54c3a42","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":49},"updated":"2017-07-05 02:26:46.000000000","message":"nit: being is redundant in the sentence.","commit_id":"3293ec3b8119215f522756ae8ca8d1efe0403778"}]}
