)]}'
{"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        if len(task.volume_targets) \u003d\u003d 0:"},{"line_number":531,"context_line":"            return False"},{"line_number":532,"context_line":"        else:"},{"line_number":533,"context_line":"            return True"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _validate_volume_boot(self, task):"},{"line_number":536,"context_line":"        \"\"\"Validate information for volume boot with this interface."}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_8312d308","line":533,"updated":"2017-07-08 20:10:09.000000000","message":"nit:\n\n return bool(task.volume_targets)","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        if len(task.volume_targets) \u003d\u003d 0:"},{"line_number":531,"context_line":"            return False"},{"line_number":532,"context_line":"        else:"},{"line_number":533,"context_line":"            return True"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _validate_volume_boot(self, task):"},{"line_number":536,"context_line":"        \"\"\"Validate information for volume boot with this interface."}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_c849e832","line":533,"in_reply_to":"3f1d235d_8312d308","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        This interface requires physical inforamtion of connectors to"},{"line_number":539,"context_line":"        configure remote boot to iRMC. Physical information of LAN ports"},{"line_number":540,"context_line":"        is also required since VIOM feature manages all adapters."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":543,"context_line":"        :raises: InvalidParameterValue: If invalid value is set to resources."}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_63f7b7d6","line":540,"updated":"2017-07-08 20:10:09.000000000","message":"please expand VIOM here and below (at least once), otherwise it\u0027s hard to guess how and why it managers the adapters","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        This interface requires physical inforamtion of connectors to"},{"line_number":539,"context_line":"        configure remote boot to iRMC. Physical information of LAN ports"},{"line_number":540,"context_line":"        is also required since VIOM feature manages all adapters."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":543,"context_line":"        :raises: InvalidParameterValue: If invalid value is set to resources."}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_e82b842d","line":540,"in_reply_to":"3f1d235d_63f7b7d6","updated":"2017-07-21 14:27:18.000000000","message":"I\u0027ll add description.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        \"\"\""},{"line_number":546,"context_line":"        irmc_common.parse_driver_info(task.node)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        for port in task.ports:"},{"line_number":549,"context_line":"            self._validate_lan_port(task.node, port)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        connectors \u003d self._get_connectors(task)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_43f4bbcf","line":548,"updated":"2017-07-08 20:10:09.000000000","message":"I wonder if you want to process portgroups in any way..","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        \"\"\""},{"line_number":546,"context_line":"        irmc_common.parse_driver_info(task.node)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        for port in task.ports:"},{"line_number":549,"context_line":"            self._validate_lan_port(task.node, port)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        connectors \u003d self._get_connectors(task)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_a8f46cd0","line":548,"in_reply_to":"3f1d235d_43f4bbcf","updated":"2017-07-21 14:27:18.000000000","message":"Portgroups are not processed here. We\u0027d like to see if a physical information is registered to ports.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":568,"context_line":"                _(\u0027Failed to validate for node %(node)s because of missing \u0027"},{"line_number":569,"context_line":"                  \u0027volume connector(s) with type(s) %(types)s\u0027) %"},{"line_number":570,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":571,"context_line":"                 \u0027types\u0027: \u0027,\u0027.join(connector_types)})"},{"line_number":572,"context_line":"        if not connector.get(PHYSICAL_PORT_ID_KEY):"},{"line_number":573,"context_line":"            raise exception.MissingParameterValue("},{"line_number":574,"context_line":"                _(\u0027Failed to validate for node %(node)s because of missing \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_2301bfb0","line":571,"updated":"2017-07-08 20:10:09.000000000","message":"nit: \u0027, \u0027 (added space for better readability)","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":568,"context_line":"                _(\u0027Failed to validate for node %(node)s because of missing \u0027"},{"line_number":569,"context_line":"                  \u0027volume connector(s) with type(s) %(types)s\u0027) %"},{"line_number":570,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":571,"context_line":"                 \u0027types\u0027: \u0027,\u0027.join(connector_types)})"},{"line_number":572,"context_line":"        if not connector.get(PHYSICAL_PORT_ID_KEY):"},{"line_number":573,"context_line":"            raise exception.MissingParameterValue("},{"line_number":574,"context_line":"                _(\u0027Failed to validate for node %(node)s because of missing \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_c820c84c","line":571,"in_reply_to":"3f1d235d_2301bfb0","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        LAN ports information must be registered to VIOM configuration to"},{"line_number":585,"context_line":"        activate them under VIOM management."},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        physical_id \u003d port.extra.get(PHYSICAL_PORT_ID_KEY)"},{"line_number":588,"context_line":"        if not physical_id:"},{"line_number":589,"context_line":"            raise exception.MissingParameterValue("},{"line_number":590,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_03fec3ad","line":587,"updated":"2017-07-08 20:10:09.000000000","message":"I understand your intention here, but port.extra is not really for ironic use, but rather a transparent storage for the operator.. A proper solution would probably involve a port.driver_info though.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        LAN ports information must be registered to VIOM configuration to"},{"line_number":585,"context_line":"        activate them under VIOM management."},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        physical_id \u003d port.extra.get(PHYSICAL_PORT_ID_KEY)"},{"line_number":588,"context_line":"        if not physical_id:"},{"line_number":589,"context_line":"            raise exception.MissingParameterValue("},{"line_number":590,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_e60cd53c","line":587,"in_reply_to":"1f1a1f67_e2008f04","updated":"2017-07-21 14:27:18.000000000","message":"I\u0027m wondering we need to add drvier_info field to ports.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"021752b25c5abc9d93b12b982adc9b600e935b70","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        LAN ports information must be registered to VIOM configuration to"},{"line_number":585,"context_line":"        activate them under VIOM management."},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        physical_id \u003d port.extra.get(PHYSICAL_PORT_ID_KEY)"},{"line_number":588,"context_line":"        if not physical_id:"},{"line_number":589,"context_line":"            raise exception.MissingParameterValue("},{"line_number":590,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_e2008f04","line":587,"in_reply_to":"3f1d235d_03fec3ad","updated":"2017-07-19 16:12:47.000000000","message":"I understood extra is not suitable here.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":605,"context_line":"                 \u0027physical_key\u0027: PHYSICAL_PORT_ID_KEY,"},{"line_number":606,"context_line":"                 \u0027port\u0027: port.uuid,"},{"line_number":607,"context_line":"                 \u0027reason\u0027: six.text_type(e)})"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def _get_netmask(self, node, connector):"},{"line_number":610,"context_line":"        netmask \u003d connector.extra.get(\u0027netmask\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_e32ce74b","line":607,"updated":"2017-07-08 20:10:09.000000000","message":"nit: six.text_type is redundant, it\u0027s done by the % operator","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":605,"context_line":"                 \u0027physical_key\u0027: PHYSICAL_PORT_ID_KEY,"},{"line_number":606,"context_line":"                 \u0027port\u0027: port.uuid,"},{"line_number":607,"context_line":"                 \u0027reason\u0027: six.text_type(e)})"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def _get_netmask(self, node, connector):"},{"line_number":610,"context_line":"        netmask \u003d connector.extra.get(\u0027netmask\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_a81d8c10","line":607,"in_reply_to":"3f1d235d_e32ce74b","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                 \u0027reason\u0027: six.text_type(e)})"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def _get_netmask(self, node, connector):"},{"line_number":610,"context_line":"        netmask \u003d connector.extra.get(\u0027netmask\u0027)"},{"line_number":611,"context_line":"        if netmask is None:"},{"line_number":612,"context_line":"            raise exception.MissingParameterValue("},{"line_number":613,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_c331eba4","line":610,"updated":"2017-07-08 20:10:09.000000000","message":"The same problem with using \"extra\", I guess..\n\nAlso, this value does not seem to be what people usually assume about a netmask (10.0.0.0/24), maybe rather a \"network_size\"?","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                 \u0027reason\u0027: six.text_type(e)})"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def _get_netmask(self, node, connector):"},{"line_number":610,"context_line":"        netmask \u003d connector.extra.get(\u0027netmask\u0027)"},{"line_number":611,"context_line":"        if netmask is None:"},{"line_number":612,"context_line":"            raise exception.MissingParameterValue("},{"line_number":613,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_4675c997","line":610,"in_reply_to":"3f1d235d_c331eba4","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            raise exception.MissingParameterValue("},{"line_number":613,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"},{"line_number":614,"context_line":"                  \u0027missing \"netmask\" parameter in the extra field of \u0027"},{"line_number":615,"context_line":"                  \u0027volume connector %(connector)s.\u0027) %"},{"line_number":616,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":617,"context_line":"                 \u0027connector\u0027: connector.uuid})"},{"line_number":618,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_a326ef67","line":615,"updated":"2017-07-08 20:10:09.000000000","message":"I think it\u0027s worth mentioning that it\u0027s required for \"ip\" type","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            raise exception.MissingParameterValue("},{"line_number":613,"context_line":"                _(\u0027Failed to validate for node %(node)s because of \u0027"},{"line_number":614,"context_line":"                  \u0027missing \"netmask\" parameter in the extra field of \u0027"},{"line_number":615,"context_line":"                  \u0027volume connector %(connector)s.\u0027) %"},{"line_number":616,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":617,"context_line":"                 \u0027connector\u0027: connector.uuid})"},{"line_number":618,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_a8790c30","line":615,"in_reply_to":"3f1d235d_a326ef67","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":630,"context_line":"                _(\u0027Failed to validate for node %(node)s because \"netmask\" \u0027"},{"line_number":631,"context_line":"                  \u0027parameter in the extra field of volume connector \u0027"},{"line_number":632,"context_line":"                  \u0027%(connector)s is invalid.\u0027) %"},{"line_number":633,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":634,"context_line":"                 \u0027connector\u0027: connector.uuid})"},{"line_number":635,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_832bf32e","line":632,"updated":"2017-07-08 20:10:09.000000000","message":"please state what valid values are","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":630,"context_line":"                _(\u0027Failed to validate for node %(node)s because \"netmask\" \u0027"},{"line_number":631,"context_line":"                  \u0027parameter in the extra field of volume connector \u0027"},{"line_number":632,"context_line":"                  \u0027%(connector)s is invalid.\u0027) %"},{"line_number":633,"context_line":"                {\u0027node\u0027: node.uuid,"},{"line_number":634,"context_line":"                 \u0027connector\u0027: connector.uuid})"},{"line_number":635,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_482a78e7","line":632,"in_reply_to":"3f1d235d_832bf32e","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        return netmask"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _get_connectors(self, task):"},{"line_number":639,"context_line":"        connectors \u003d {\u0027iscsi\u0027: {},"},{"line_number":640,"context_line":"                      \u0027fibre_channel\u0027: {}}"},{"line_number":641,"context_line":"        for vc in task.volume_connectors:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_6320d74a","line":638,"updated":"2017-07-08 20:10:09.000000000","message":"a docstring could be useful here","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        return netmask"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _get_connectors(self, task):"},{"line_number":639,"context_line":"        connectors \u003d {\u0027iscsi\u0027: {},"},{"line_number":640,"context_line":"                      \u0027fibre_channel\u0027: {}}"},{"line_number":641,"context_line":"        for vc in task.volume_connectors:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_6b69ae89","line":638,"in_reply_to":"3f1d235d_6320d74a","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            elif vc.type in (\u0027wwnn\u0027, \u0027wwpn\u0027):"},{"line_number":645,"context_line":"                connector \u003d connectors[\u0027fibre_channel\u0027]"},{"line_number":646,"context_line":"            else:"},{"line_number":647,"context_line":"                continue"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"            connector[vc.type] \u003d vc.connector_id"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_431ddb0d","line":647,"updated":"2017-07-08 20:10:09.000000000","message":"nit: LOG.debug here?","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":644,"context_line":"            elif vc.type in (\u0027wwnn\u0027, \u0027wwpn\u0027):"},{"line_number":645,"context_line":"                connector \u003d connectors[\u0027fibre_channel\u0027]"},{"line_number":646,"context_line":"            else:"},{"line_number":647,"context_line":"                continue"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"            connector[vc.type] \u003d vc.connector_id"},{"line_number":650,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_e85f0470","line":647,"in_reply_to":"3f1d235d_431ddb0d","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                    raise exception.InvalidParameterValue("},{"line_number":659,"context_line":"                        \u0027Physical port information of volume connector \u0027"},{"line_number":660,"context_line":"                        \u0027%(connector)s is invalid: %(error)\u0027,"},{"line_number":661,"context_line":"                        connector\u003dvc.uuid, error\u003de)"},{"line_number":662,"context_line":"                connector[PHYSICAL_PORT_ID_KEY] \u003d physical_id"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"            if vc.type \u003d\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_231adf16","line":661,"updated":"2017-07-08 20:10:09.000000000","message":"these should be passed as a dictionary, not as keyword arguments","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                    raise exception.InvalidParameterValue("},{"line_number":659,"context_line":"                        \u0027Physical port information of volume connector \u0027"},{"line_number":660,"context_line":"                        \u0027%(connector)s is invalid: %(error)\u0027,"},{"line_number":661,"context_line":"                        connector\u003dvc.uuid, error\u003de)"},{"line_number":662,"context_line":"                connector[PHYSICAL_PORT_ID_KEY] \u003d physical_id"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"            if vc.type \u003d\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_4b2dd244","line":661,"in_reply_to":"3f1d235d_231adf16","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":664,"context_line":"            if vc.type \u003d\u003d \u0027ip\u0027:"},{"line_number":665,"context_line":"                # netmask is required in extra field for iSCSI initiator"},{"line_number":666,"context_line":"                # configuration"},{"line_number":667,"context_line":"                connector[\u0027netmask\u0027] \u003d self._get_netmask(task.node, vc)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        return connectors"},{"line_number":670,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_0317e3ef","line":667,"updated":"2017-07-08 20:10:09.000000000","message":"should we maybe require the net size to be part of vc.connector_id? i.e. we require users to provide \"10.0.0.1/24\", which is split into ip\u003d10.0.0.1 and netmask\u003d24. I don\u0027t know how well it\u0027s going to play with Nova/Cinder, of course.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":664,"context_line":"            if vc.type \u003d\u003d \u0027ip\u0027:"},{"line_number":665,"context_line":"                # netmask is required in extra field for iSCSI initiator"},{"line_number":666,"context_line":"                # configuration"},{"line_number":667,"context_line":"                connector[\u0027netmask\u0027] \u003d self._get_netmask(task.node, vc)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        return connectors"},{"line_number":670,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_eb3eded8","line":667,"in_reply_to":"3f1d235d_0317e3ef","updated":"2017-07-21 14:27:18.000000000","message":"I\u0027ll investigate more.As far as I know, iRMC API requires subnet mask.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                                    connectors[\u0027fibre_channel\u0027], vt)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        try:"},{"line_number":698,"context_line":"            LOG.info(\u0027Set VIOM configuration for node %(node)s: %(table)s\u0027,"},{"line_number":699,"context_line":"                     {\u0027node\u0027: task.node.uuid,"},{"line_number":700,"context_line":"                      \u0027table\u0027: viom_conf.dump_json()})"},{"line_number":701,"context_line":"            viom_conf.apply()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_e3d18731","line":698,"updated":"2017-07-08 20:10:09.000000000","message":"s/info/debug/ I think","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                                    connectors[\u0027fibre_channel\u0027], vt)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        try:"},{"line_number":698,"context_line":"            LOG.info(\u0027Set VIOM configuration for node %(node)s: %(table)s\u0027,"},{"line_number":699,"context_line":"                     {\u0027node\u0027: task.node.uuid,"},{"line_number":700,"context_line":"                      \u0027table\u0027: viom_conf.dump_json()})"},{"line_number":701,"context_line":"            viom_conf.apply()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_0baa3a84","line":698,"in_reply_to":"3f1d235d_e3d18731","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def _set_iscsi_target(self, task, viom_conf, connector, target):"},{"line_number":711,"context_line":"        initiator_ip \u003d connector[\u0027ip\u0027]"},{"line_number":712,"context_line":"        initiator_iqn \u003d connector[\u0027iqn\u0027]"},{"line_number":713,"context_line":"        initiator_netmask \u003d connector[\u0027netmask\u0027]"},{"line_number":714,"context_line":"        target_portal \u003d target.properties[\u0027target_portal\u0027]"},{"line_number":715,"context_line":"        target_iqn \u003d target.properties[\u0027target_iqn\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_c3d68b28","line":712,"updated":"2017-07-08 20:10:09.000000000","message":"This code assumes that both \"ip\" and \"iqn\" were set previously. It\u0027s not validated above actually. Do we have any code to make sure they are both present?","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def _set_iscsi_target(self, task, viom_conf, connector, target):"},{"line_number":711,"context_line":"        initiator_ip \u003d connector[\u0027ip\u0027]"},{"line_number":712,"context_line":"        initiator_iqn \u003d connector[\u0027iqn\u0027]"},{"line_number":713,"context_line":"        initiator_netmask \u003d connector[\u0027netmask\u0027]"},{"line_number":714,"context_line":"        target_portal \u003d target.properties[\u0027target_portal\u0027]"},{"line_number":715,"context_line":"        target_iqn \u003d target.properties[\u0027target_iqn\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_6bd64ef4","line":712,"in_reply_to":"3f1d235d_c3d68b28","updated":"2017-07-21 14:27:18.000000000","message":"This validation is in L554.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86b120a91025967e4f0f4fc5cc392a6af8202d9f","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        :raises: InvalidParameterValue, if config option has invalid value."},{"line_number":777,"context_line":"        \"\"\""},{"line_number":778,"context_line":"        check_share_fs_mounted()"},{"line_number":779,"context_line":"        self.capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fc_volume_boot\u0027]"},{"line_number":780,"context_line":"        super(IRMCVirtualMediaBoot, self).__init__()"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_7b79b091","line":779,"range":{"start_line":779,"start_character":50,"end_line":779,"end_character":66},"updated":"2017-07-07 16:24:18.000000000","message":"I guess this is kind of okay, since we built most of the substrate to support this as-is, and defined the standard to support it.\n\nNaturally it makes sense since it looks like you built FC support into this.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86b120a91025967e4f0f4fc5cc392a6af8202d9f","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        if deploy_utils.get_remote_boot_volume(task):"},{"line_number":801,"context_line":"            self._validate_volume_boot(task)"},{"line_number":802,"context_line":"            return"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"},{"line_number":805,"context_line":"        if task.node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_db8fa473","line":802,"range":{"start_line":802,"start_character":12,"end_line":802,"end_character":18},"updated":"2017-07-07 16:24:18.000000000","message":"I think returning is slightly premature in that we one day want to support the ability for a node to be written out via the agent booting with connected volume storage.  Perhaps an inline TODO to explore that possibility once it is realistically available in ironic.\n\nPart of this is the reason we added the should_write_image logic to the storage interface, so the storage interface could help guide that.  But, I don\u0027t know what permutations that creates for your driver.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"021752b25c5abc9d93b12b982adc9b600e935b70","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        if deploy_utils.get_remote_boot_volume(task):"},{"line_number":801,"context_line":"            self._validate_volume_boot(task)"},{"line_number":802,"context_line":"            return"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"},{"line_number":805,"context_line":"        if task.node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_a2f5f758","line":802,"range":{"start_line":802,"start_character":12,"end_line":802,"end_character":18},"in_reply_to":"3f1d235d_db8fa473","updated":"2017-07-19 16:12:47.000000000","message":"It seems better to use should_write_image like other interfaces.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86b120a91025967e4f0f4fc5cc392a6af8202d9f","unresolved":false,"context_lines":[{"line_number":897,"context_line":"        :raises: IRMCOperationError if iRMC operation failed."},{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027):"},{"line_number":900,"context_line":"            # TODO(hshiina) add is_fc_boot"},{"line_number":901,"context_line":"            self._cleanup_boot_from_volume(task)"},{"line_number":902,"context_line":"            return"},{"line_number":903,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_fb64a0e7","line":900,"range":{"start_line":900,"start_character":12,"end_line":900,"end_character":42},"updated":"2017-07-07 16:24:18.000000000","message":"Perhaps the tag I left a note on above should be removed?\n\nAlso, why would this matter for cleaning up?","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"021752b25c5abc9d93b12b982adc9b600e935b70","unresolved":false,"context_lines":[{"line_number":897,"context_line":"        :raises: IRMCOperationError if iRMC operation failed."},{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027):"},{"line_number":900,"context_line":"            # TODO(hshiina) add is_fc_boot"},{"line_number":901,"context_line":"            self._cleanup_boot_from_volume(task)"},{"line_number":902,"context_line":"            return"},{"line_number":903,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_cc5c21ef","line":900,"range":{"start_line":900,"start_character":12,"end_line":900,"end_character":42},"in_reply_to":"3f1d235d_fb64a0e7","updated":"2017-07-19 16:12:47.000000000","message":"Yes, it should be removed.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":62,"context_line":"    \u0027pci_physical_ids\u0027: _(\"Physical IDs of PCI cards. List of pairs of \""},{"line_number":63,"context_line":"                          \"resource UUID and its physical ID like \""},{"line_number":64,"context_line":"                          \"\u0027\u003cUUID\u003e:\u003cPhysical ID\u003e,...\u0027. The resources are \""},{"line_number":65,"context_line":"                          \"Ports and Volume connectors. The Physical ID \""},{"line_number":66,"context_line":"                          \"consists of card type, slot No, and port No. \""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_e351fada","line":63,"updated":"2017-08-03 14:43:59.000000000","message":"our API supports nested dicts nowadays, so let\u0027s maybe make it a proper dict UUID: ID?","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":62,"context_line":"    \u0027pci_physical_ids\u0027: _(\"Physical IDs of PCI cards. List of pairs of \""},{"line_number":63,"context_line":"                          \"resource UUID and its physical ID like \""},{"line_number":64,"context_line":"                          \"\u0027\u003cUUID\u003e:\u003cPhysical ID\u003e,...\u0027. The resources are \""},{"line_number":65,"context_line":"                          \"Ports and Volume connectors. The Physical ID \""},{"line_number":66,"context_line":"                          \"consists of card type, slot No, and port No. \""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_1c1a01cb","line":63,"in_reply_to":"df3967d1_e351fada","updated":"2017-08-08 08:28:36.000000000","message":"dict is appropriate. Thanks.","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                          \"consists of card type, slot No, and port No. \""},{"line_number":67,"context_line":"                          \"The format is [LAN|FC|CNA]\u003cslot-No\u003e-\u003cPort-No\u003e. \""},{"line_number":68,"context_line":"                          \"This parameter is necessary for booting a node \""},{"line_number":69,"context_line":"                          \"from a remote volume. Optional.\"),"},{"line_number":70,"context_line":"    \u0027storage_network_size\u0027:"},{"line_number":71,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":72,"context_line":"          \"positive integer. This is necessary for booting a node from a \""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_c34ef636","line":69,"updated":"2017-08-03 14:43:59.000000000","message":"this seems to be irmc specific, so let\u0027s prefix its name with irmc_","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"416efd2abf1115c540fceda397218825095a0b71","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                          \"consists of card type, slot No, and port No. \""},{"line_number":67,"context_line":"                          \"The format is [LAN|FC|CNA]\u003cslot-No\u003e-\u003cPort-No\u003e. \""},{"line_number":68,"context_line":"                          \"This parameter is necessary for booting a node \""},{"line_number":69,"context_line":"                          \"from a remote volume. Optional.\"),"},{"line_number":70,"context_line":"    \u0027storage_network_size\u0027:"},{"line_number":71,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":72,"context_line":"          \"positive integer. This is necessary for booting a node from a \""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf3e73b7_92279813","line":69,"in_reply_to":"df3967d1_c34ef636","updated":"2017-08-07 13:55:51.000000000","message":"+1, or perhaps irmc_boot_pci_physical_ids since otherwise there is no real connotation short of looking at documentation as to what it could be.","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                          \"consists of card type, slot No, and port No. \""},{"line_number":67,"context_line":"                          \"The format is [LAN|FC|CNA]\u003cslot-No\u003e-\u003cPort-No\u003e. \""},{"line_number":68,"context_line":"                          \"This parameter is necessary for booting a node \""},{"line_number":69,"context_line":"                          \"from a remote volume. Optional.\"),"},{"line_number":70,"context_line":"    \u0027storage_network_size\u0027:"},{"line_number":71,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":72,"context_line":"          \"positive integer. This is necessary for booting a node from a \""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_fc0cdd94","line":69,"in_reply_to":"df3967d1_c34ef636","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027storage_network_size\u0027:"},{"line_number":71,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":72,"context_line":"          \"positive integer. This is necessary for booting a node from a \""},{"line_number":73,"context_line":"          \"remote iSCSI volume. Optional.\"),"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_a361b2ab","line":73,"updated":"2017-08-03 14:43:59.000000000","message":"maybe this one too.. it\u0027s more generic, but dunno. we seem to prefix everything in driver_info.","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027storage_network_size\u0027:"},{"line_number":71,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":72,"context_line":"          \"positive integer. This is necessary for booting a node from a \""},{"line_number":73,"context_line":"          \"remote iSCSI volume. Optional.\"),"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_dc0fd985","line":73,"in_reply_to":"df3967d1_a361b2ab","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"416efd2abf1115c540fceda397218825095a0b71","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \u0027storage_network_size\u0027:"},{"line_number":71,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":72,"context_line":"          \"positive integer. This is necessary for booting a node from a \""},{"line_number":73,"context_line":"          \"remote iSCSI volume. Optional.\"),"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf3e73b7_f266e451","line":73,"in_reply_to":"df3967d1_a361b2ab","updated":"2017-08-07 13:55:51.000000000","message":"This should likely detail _what_ the size value can be translated from since it is an a integer. Something along the lines of \"This is the size of the IPv4 subnet mask that the storage network is configured to utilize, in a range between 1 and 32.\"","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        irmc_common.parse_driver_info(task.node)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        for port in task.ports:"},{"line_number":563,"context_line":"            self._validate_lan_port(task.node, port)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        connectors \u003d self._get_connectors(task)"},{"line_number":566,"context_line":"        for vt in task.volume_targets:"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_8366aec0","line":563,"updated":"2017-08-03 14:43:59.000000000","message":"if you only do this validation when there are any connectors, youi will be able to call _validate_volume_boot unconditionally from the boot interfaces (see also my comments below)","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        irmc_common.parse_driver_info(task.node)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        for port in task.ports:"},{"line_number":563,"context_line":"            self._validate_lan_port(task.node, port)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        connectors \u003d self._get_connectors(task)"},{"line_number":566,"context_line":"        for vt in task.volume_targets:"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_ed29c536","line":563,"in_reply_to":"df3967d1_8366aec0","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            raise exception.MissingParameterValue("},{"line_number":588,"context_line":"                _(\u0027Failed to validate for node %(node)s because of missing \u0027"},{"line_number":589,"context_line":"                  \u0027physical port information of a volume connector in \u0027"},{"line_number":590,"context_line":"                  \u0027\"pci_physical_ids\" parameter of node\\\u0027s driver_info.\u0027) %"},{"line_number":591,"context_line":"                {\u0027node\u0027: node.uuid})"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def _validate_lan_port(self, node, port):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_63574acc","line":590,"updated":"2017-08-03 14:43:59.000000000","message":"here you seem to be reading connector[\u0027physical_id\u0027], no? I think you need to change line 586 to something like\n\n if not node.driver_info[\u0027irmc_pci_physical_ids\u0027].get(connector.uuid)","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            raise exception.MissingParameterValue("},{"line_number":588,"context_line":"                _(\u0027Failed to validate for node %(node)s because of missing \u0027"},{"line_number":589,"context_line":"                  \u0027physical port information of a volume connector in \u0027"},{"line_number":590,"context_line":"                  \u0027\"pci_physical_ids\" parameter of node\\\u0027s driver_info.\u0027) %"},{"line_number":591,"context_line":"                {\u0027node\u0027: node.uuid})"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def _validate_lan_port(self, node, port):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_38eb48b1","line":590,"in_reply_to":"df3967d1_63574acc","updated":"2017-08-08 08:28:36.000000000","message":"A physical ID of PCI card should be registered to one of volume connectors for IQN or IP. I made some changes to the patch.","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                 \u0027port\u0027: port.uuid,"},{"line_number":617,"context_line":"                 \u0027reason\u0027: e})"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _get_physical_id_dict(self, node):"},{"line_number":620,"context_line":"        \"\"\"Create a dictionary of physical IDs of PCI cards.\"\"\""},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        physical_ids \u003d node.driver_info.get(\u0027pci_physical_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_435c46ec","line":619,"updated":"2017-08-03 14:43:59.000000000","message":"this may be not needed - see above","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                 \u0027port\u0027: port.uuid,"},{"line_number":617,"context_line":"                 \u0027reason\u0027: e})"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _get_physical_id_dict(self, node):"},{"line_number":620,"context_line":"        \"\"\"Create a dictionary of physical IDs of PCI cards.\"\"\""},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        physical_ids \u003d node.driver_info.get(\u0027pci_physical_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_eda6650f","line":619,"in_reply_to":"df3967d1_435c46ec","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                 \u0027connector\u0027: connector.uuid})"},{"line_number":647,"context_line":"        try:"},{"line_number":648,"context_line":"            network_size \u003d int(network_size)"},{"line_number":649,"context_line":"        except ValueError:"},{"line_number":650,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":651,"context_line":"                _(\u0027Failed to validate for node %(node)s because \u0027"},{"line_number":652,"context_line":"                  \u0027\"storage_network_size\" parameter in the node\\\u0027s \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_2375c264","line":649,"updated":"2017-08-03 14:43:59.000000000","message":"there can be also a TypeError (e.g. if network_size is {})","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                 \u0027connector\u0027: connector.uuid})"},{"line_number":647,"context_line":"        try:"},{"line_number":648,"context_line":"            network_size \u003d int(network_size)"},{"line_number":649,"context_line":"        except ValueError:"},{"line_number":650,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":651,"context_line":"                _(\u0027Failed to validate for node %(node)s because \u0027"},{"line_number":652,"context_line":"                  \u0027\"storage_network_size\" parameter in the node\\\u0027s \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_5cf7695a","line":649,"in_reply_to":"df3967d1_2375c264","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            elif vc.type in (\u0027wwnn\u0027, \u0027wwpn\u0027):"},{"line_number":692,"context_line":"                connector \u003d connectors[\u0027fibre_channel\u0027]"},{"line_number":693,"context_line":"            else:"},{"line_number":694,"context_line":"                LOG.debug(\u0027Node %(node)s has a volume_connector (%(uuid)s) \u0027"},{"line_number":695,"context_line":"                          \u0027defined with an unsupported type: %(type)s.\u0027,"},{"line_number":696,"context_line":"                          {\u0027node\u0027: task.node.uuid,"},{"line_number":697,"context_line":"                           \u0027uuid\u0027: vc.uuid,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_0372be7b","line":694,"updated":"2017-08-03 14:43:59.000000000","message":"I think it should be a warning, looks like a potentially dangerous condition","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            elif vc.type in (\u0027wwnn\u0027, \u0027wwpn\u0027):"},{"line_number":692,"context_line":"                connector \u003d connectors[\u0027fibre_channel\u0027]"},{"line_number":693,"context_line":"            else:"},{"line_number":694,"context_line":"                LOG.debug(\u0027Node %(node)s has a volume_connector (%(uuid)s) \u0027"},{"line_number":695,"context_line":"                          \u0027defined with an unsupported type: %(type)s.\u0027,"},{"line_number":696,"context_line":"                          {\u0027node\u0027: task.node.uuid,"},{"line_number":697,"context_line":"                           \u0027uuid\u0027: vc.uuid,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_fcb61d8a","line":694,"in_reply_to":"df3967d1_0372be7b","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"416efd2abf1115c540fceda397218825095a0b71","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            elif vc.type in (\u0027wwnn\u0027, \u0027wwpn\u0027):"},{"line_number":692,"context_line":"                connector \u003d connectors[\u0027fibre_channel\u0027]"},{"line_number":693,"context_line":"            else:"},{"line_number":694,"context_line":"                LOG.debug(\u0027Node %(node)s has a volume_connector (%(uuid)s) \u0027"},{"line_number":695,"context_line":"                          \u0027defined with an unsupported type: %(type)s.\u0027,"},{"line_number":696,"context_line":"                          {\u0027node\u0027: task.node.uuid,"},{"line_number":697,"context_line":"                           \u0027uuid\u0027: vc.uuid,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf3e73b7_12c72815","line":694,"in_reply_to":"df3967d1_0372be7b","updated":"2017-08-07 13:55:51.000000000","message":"Only really dangerous in terms of expectations as it may not work. Perhaps a validate call should fail if this is the case.","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":856,"context_line":"        check_share_fs_mounted()"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        if not task.driver.storage.should_write_image(task):"},{"line_number":859,"context_line":"            self._validate_volume_boot(task)"},{"line_number":860,"context_line":"            return"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_e36a1a7f","line":859,"updated":"2017-08-03 14:43:59.000000000","message":"see my comments above - I think validate_volume_boot can be called unconditionally. in the future we may have storage interface supporting writing images.\n\n self._validate_volume_boot(task)  # does nothing when there are no connectors\n if not task.driver.storage.should_write_image(task):\n     LOG.debug(\"Not validating image information, because of booting from a remote volume\")\n     return\n\nor something like that","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":856,"context_line":"        check_share_fs_mounted()"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        if not task.driver.storage.should_write_image(task):"},{"line_number":859,"context_line":"            self._validate_volume_boot(task)"},{"line_number":860,"context_line":"            return"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_22bebcb3","line":859,"in_reply_to":"df3967d1_e36a1a7f","updated":"2017-08-08 08:28:36.000000000","message":"I see. Thanks.","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":900,"context_line":"        if task.node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":901,"context_line":"            irmc_management.backup_bios_config(task)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"            if not task.driver.storage.should_write_image(task):"},{"line_number":904,"context_line":"                return"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_c36716b7","line":903,"updated":"2017-08-03 14:43:59.000000000","message":"please add LOG.debug here","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":900,"context_line":"        if task.node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":901,"context_line":"            irmc_management.backup_bios_config(task)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"            if not task.driver.storage.should_write_image(task):"},{"line_number":904,"context_line":"                return"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_7fb7bf3b","line":903,"in_reply_to":"df3967d1_c36716b7","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":931,"context_line":"        :param task: a task from TaskManager."},{"line_number":932,"context_line":"        :returns: None"},{"line_number":933,"context_line":"        \"\"\""},{"line_number":934,"context_line":"        if not task.driver.storage.should_write_image(task):"},{"line_number":935,"context_line":"            self._configure_boot_from_volume(task)"},{"line_number":936,"context_line":"            return"},{"line_number":937,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_a30652cd","line":934,"updated":"2017-08-03 14:43:59.000000000","message":"the same suggestion here","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":931,"context_line":"        :param task: a task from TaskManager."},{"line_number":932,"context_line":"        :returns: None"},{"line_number":933,"context_line":"        \"\"\""},{"line_number":934,"context_line":"        if not task.driver.storage.should_write_image(task):"},{"line_number":935,"context_line":"            self._configure_boot_from_volume(task)"},{"line_number":936,"context_line":"            return"},{"line_number":937,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_df858b08","line":934,"in_reply_to":"df3967d1_a30652cd","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fee42461234a80d1d3f36b5ae9a1e4e970455f07","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027irmc_storage_network_size\u0027:"},{"line_number":70,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":71,"context_line":"          \"positive integer. This is necessary for booting a node from a \""},{"line_number":72,"context_line":"          \"remote iSCSI volume. Optional.\"),"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_b3e0d727","line":72,"updated":"2017-08-14 18:43:43.000000000","message":"Nit: This was never revised although the note in revision 15 indicates done.","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027irmc_storage_network_size\u0027:"},{"line_number":70,"context_line":"        _(\"Size of the network for iSCSI storage network. It should be a \""},{"line_number":71,"context_line":"          \"positive integer. This is necessary for booting a node from a \""},{"line_number":72,"context_line":"          \"remote iSCSI volume. Optional.\"),"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_028021f4","line":72,"in_reply_to":"9f436f4f_b3e0d727","updated":"2017-08-17 11:08:07.000000000","message":"Done","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fee42461234a80d1d3f36b5ae9a1e4e970455f07","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        :raises: MissingParameterValue: If some value is not set to resources."},{"line_number":558,"context_line":"        \"\"\""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if not deploy_utils.get_remote_boot_volume(task):"},{"line_number":561,"context_line":"            # No boot volume. Nothing to validate."},{"line_number":562,"context_line":"            return"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        irmc_common.parse_driver_info(task.node)"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_733dcf8d","line":562,"range":{"start_line":560,"start_character":0,"end_line":562,"end_character":18},"updated":"2017-08-14 18:43:43.000000000","message":"This seems like it should actually be around line 568.","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        :raises: MissingParameterValue: If some value is not set to resources."},{"line_number":558,"context_line":"        \"\"\""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if not deploy_utils.get_remote_boot_volume(task):"},{"line_number":561,"context_line":"            # No boot volume. Nothing to validate."},{"line_number":562,"context_line":"            return"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        irmc_common.parse_driver_info(task.node)"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_22b325eb","line":562,"range":{"start_line":560,"start_character":0,"end_line":562,"end_character":18},"in_reply_to":"9f436f4f_733dcf8d","updated":"2017-08-17 11:08:07.000000000","message":"If there is no remote volume, validation for ports is not necessary.","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        :param types: a list of types of volume connectors required for the"},{"line_number":585,"context_line":"            target volume. One of connectors must have a physical ID."},{"line_number":586,"context_line":"        :raises InvalidParameterValue if a physical ID is invalid."},{"line_number":587,"context_line":"        :returns: A physical ID of a volume connector."},{"line_number":588,"context_line":"        \"\"\""},{"line_number":589,"context_line":"        for vc in task.volume_connectors:"},{"line_number":590,"context_line":"            if vc.type not in types:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_9a927156","line":587,"updated":"2017-08-15 12:04:06.000000000","message":"or None","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        :param types: a list of types of volume connectors required for the"},{"line_number":585,"context_line":"            target volume. One of connectors must have a physical ID."},{"line_number":586,"context_line":"        :raises InvalidParameterValue if a physical ID is invalid."},{"line_number":587,"context_line":"        :returns: A physical ID of a volume connector."},{"line_number":588,"context_line":"        \"\"\""},{"line_number":589,"context_line":"        for vc in task.volume_connectors:"},{"line_number":590,"context_line":"            if vc.type not in types:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_c2f1f996","line":587,"in_reply_to":"9f436f4f_9a927156","updated":"2017-08-17 11:08:07.000000000","message":"Done","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            if vc.type not in types:"},{"line_number":591,"context_line":"                continue"},{"line_number":592,"context_line":"            pid \u003d task.node.driver_info[\u0027irmc_pci_physical_ids\u0027].get(vc.uuid)"},{"line_number":593,"context_line":"            if pid:"},{"line_number":594,"context_line":"                try:"},{"line_number":595,"context_line":"                    viom.validate_physical_port_id(pid)"},{"line_number":596,"context_line":"                except scci.SCCIInvalidInputError as e:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_ba977548","line":593,"range":{"start_line":593,"start_character":12,"end_line":593,"end_character":19},"updated":"2017-08-15 12:04:06.000000000","message":"nit: I\u0027d prefer to reduce indentation:\n\n if not pid:\n     continue","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            if vc.type not in types:"},{"line_number":591,"context_line":"                continue"},{"line_number":592,"context_line":"            pid \u003d task.node.driver_info[\u0027irmc_pci_physical_ids\u0027].get(vc.uuid)"},{"line_number":593,"context_line":"            if pid:"},{"line_number":594,"context_line":"                try:"},{"line_number":595,"context_line":"                    viom.validate_physical_port_id(pid)"},{"line_number":596,"context_line":"                except scci.SCCIInvalidInputError as e:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_e2f63d8f","line":593,"range":{"start_line":593,"start_character":12,"end_line":593,"end_character":19},"in_reply_to":"9f436f4f_ba977548","updated":"2017-08-17 11:08:07.000000000","message":"Done","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fee42461234a80d1d3f36b5ae9a1e4e970455f07","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        \"\"\"Validate if volume connectors are properly registered for iSCSI."},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        For connecting a node to a iSCSI volume, volume connectors containing"},{"line_number":608,"context_line":"        an IQNN and an IP address are necessary. One of connectors must have"},{"line_number":609,"context_line":"        a physical ID of the PCI card. Network size of a storage network is"},{"line_number":610,"context_line":"        also required by iRMC. which should be registered in the node\u0027s"},{"line_number":611,"context_line":"        driver_info."}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_f3489f2d","line":608,"range":{"start_line":608,"start_character":11,"end_line":608,"end_character":15},"updated":"2017-08-14 18:43:43.000000000","message":"s/IQNN/IQN/","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        \"\"\"Validate if volume connectors are properly registered for iSCSI."},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        For connecting a node to a iSCSI volume, volume connectors containing"},{"line_number":608,"context_line":"        an IQNN and an IP address are necessary. One of connectors must have"},{"line_number":609,"context_line":"        a physical ID of the PCI card. Network size of a storage network is"},{"line_number":610,"context_line":"        also required by iRMC. which should be registered in the node\u0027s"},{"line_number":611,"context_line":"        driver_info."}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_822d31ff","line":608,"range":{"start_line":608,"start_character":11,"end_line":608,"end_character":15},"in_reply_to":"9f436f4f_f3489f2d","updated":"2017-08-17 11:08:07.000000000","message":"Done","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            vc \u003d vc_dict.get(vc_type)"},{"line_number":625,"context_line":"            if not vc:"},{"line_number":626,"context_line":"                missing_types.append(vc_type)"},{"line_number":627,"context_line":"                continue"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        if missing_types:"},{"line_number":630,"context_line":"            raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_5a988973","line":627,"range":{"start_line":627,"start_character":16,"end_line":627,"end_character":24},"updated":"2017-08-15 12:04:06.000000000","message":"nit: this continue is redundant","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            vc \u003d vc_dict.get(vc_type)"},{"line_number":625,"context_line":"            if not vc:"},{"line_number":626,"context_line":"                missing_types.append(vc_type)"},{"line_number":627,"context_line":"                continue"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        if missing_types:"},{"line_number":630,"context_line":"            raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_4233c962","line":627,"range":{"start_line":627,"start_character":16,"end_line":627,"end_character":24},"in_reply_to":"9f436f4f_5a988973","updated":"2017-08-17 11:08:07.000000000","message":"Done","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        :raises: InvalidParameterValue, if config option has invalid value."},{"line_number":872,"context_line":"        \"\"\""},{"line_number":873,"context_line":"        check_share_fs_mounted()"},{"line_number":874,"context_line":"        self.capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fc_volume_boot\u0027]"},{"line_number":875,"context_line":"        super(IRMCVirtualMediaBoot, self).__init__()"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_3a92654d","line":874,"range":{"start_line":874,"start_character":0,"end_line":874,"end_character":67},"updated":"2017-08-15 12:04:06.000000000","message":"nit: I\u0027d make this a class-level constant for visibility","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f8b927a984a085c983af491df6bbb26ef18cc5af","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        :raises: InvalidParameterValue, if config option has invalid value."},{"line_number":872,"context_line":"        \"\"\""},{"line_number":873,"context_line":"        check_share_fs_mounted()"},{"line_number":874,"context_line":"        self.capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fc_volume_boot\u0027]"},{"line_number":875,"context_line":"        super(IRMCVirtualMediaBoot, self).__init__()"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_3d3fc487","line":874,"range":{"start_line":874,"start_character":0,"end_line":874,"end_character":67},"in_reply_to":"9f436f4f_3a92654d","updated":"2017-08-17 11:08:07.000000000","message":"Done","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"}],"releasenotes/notes/irmc-boot-from-volume-4bc5d20a0a780669.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for boot-from-volume to ``irmc-virtual-media`` boot interface."},{"line_number":5,"context_line":"    It enables boot configuration for iSCSI or FibreChannel via out-of-band"},{"line_number":6,"context_line":"    network."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_236c1f9b","line":4,"updated":"2017-07-08 20:10:09.000000000","message":"s/boot-from-volume/booting from remote volumes/ (more user-friendly IMO)","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for boot-from-volume to ``irmc-virtual-media`` boot interface."},{"line_number":5,"context_line":"    It enables boot configuration for iSCSI or FibreChannel via out-of-band"},{"line_number":6,"context_line":"    network."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f1a1f67_a6c13d83","line":4,"in_reply_to":"3f1d235d_236c1f9b","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    In addition to the same configuration as generic boot-from-volume, this"},{"line_number":9,"context_line":"    interface requires the following settings."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        * It is necessary to set a physical port ID to network ports and"},{"line_number":12,"context_line":"          volume connectors. All cards including those not for volume boot"},{"line_number":13,"context_line":"          should be registered."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_0369238a","line":11,"updated":"2017-07-08 20:10:09.000000000","message":"this is overly indented (see the rendered version). please move * to the same level as the previous paragraph","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    interface requires the following settings."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        * It is necessary to set a physical port ID to network ports and"},{"line_number":12,"context_line":"          volume connectors. All cards including those not for volume boot"},{"line_number":13,"context_line":"          should be registered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"             * A physical ID format is: ``\u003cCard Type\u003e\u003cSlot No\u003e-\u003cPort No\u003e``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_e303c7bd","line":12,"updated":"2017-07-08 20:10:09.000000000","message":"s/not/not used/","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    interface requires the following settings."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        * It is necessary to set a physical port ID to network ports and"},{"line_number":12,"context_line":"          volume connectors. All cards including those not for volume boot"},{"line_number":13,"context_line":"          should be registered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"             * A physical ID format is: ``\u003cCard Type\u003e\u003cSlot No\u003e-\u003cPort No\u003e``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f1a1f67_e62bb52d","line":12,"in_reply_to":"3f1d235d_e303c7bd","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                     A port number starting from 1."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"             * Set the IDs to ``port.extra.physical_id`` and"},{"line_number":25,"context_line":"               ``volume_connector.extra.physical_id``."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        * A volume connector with type ``ip`` requires subnet mask. It should"},{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_c308cbda","line":25,"updated":"2017-07-08 20:10:09.000000000","message":"I wonder if we can do it only on one object..","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86b120a91025967e4f0f4fc5cc392a6af8202d9f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"             * Set the IDs to ``port.extra.physical_id`` and"},{"line_number":25,"context_line":"               ``volume_connector.extra.physical_id``."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        * A volume connector with type ``ip`` requires subnet mask. It should"},{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This feature requires specific FC card or CNA (Converged Network Adapter)."},{"line_number":31,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_1b263c18","line":28,"range":{"start_line":27,"start_character":10,"end_line":28,"end_character":66},"updated":"2017-07-07 16:24:18.000000000","message":"Aside: Part of me wonders if we should be supporting CIDR style addresses.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86b120a91025967e4f0f4fc5cc392a6af8202d9f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        * A volume connector with type ``ip`` requires subnet mask. It should"},{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This feature requires specific FC card or CNA (Converged Network Adapter)."},{"line_number":31,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_7b653045","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":50},"updated":"2017-07-07 16:24:18.000000000","message":"maybe: Maybe s/card/cards/ and s/CNA/CNAs/ ?","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        * A volume connector with type ``ip`` requires subnet mask. It should"},{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This feature requires specific FC card or CNA (Converged Network Adapter)."},{"line_number":31,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f1a1f67_c6ce7982","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":50},"in_reply_to":"3f1d235d_7b653045","updated":"2017-07-21 14:27:18.000000000","message":"Done","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ee20d8ace3b5b08362994b99f967ed2e7ac81fa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This feature requires specific FC card or CNA (Converged Network Adapter)."},{"line_number":31,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_a30dcfe9","line":31,"updated":"2017-07-08 20:10:09.000000000","message":"+1 for the docs","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"86b120a91025967e4f0f4fc5cc392a6af8202d9f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This feature requires specific FC card or CNA (Converged Network Adapter)."},{"line_number":31,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_fb502061","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":53},"updated":"2017-07-07 16:24:18.000000000","message":"I don\u0027t see the documentation patch for this.  Does it exist yet?","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"fd31bb7eb2aa54acc8636f2d5483a2a341fe6fd7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"          be set to ``volume_connector.extra.netmask`` as integer."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This feature requires specific FC card or CNA (Converged Network Adapter)."},{"line_number":31,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f1a1f67_a6e25d00","line":31,"in_reply_to":"3f1d235d_a30dcfe9","updated":"2017-07-21 14:27:18.000000000","message":"The document hasn\u0027t been written. I will write.","commit_id":"071eb01e9e275169a3e845fad52f7d2fb5213252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40b1cd1d36a47d920160078490c8f345ddc5f113","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for boot from remote volumes to ``irmc-virtual-media`` boot"},{"line_number":5,"context_line":"    interface. It enables boot configuration for iSCSI or FibreChannel via"},{"line_number":6,"context_line":"    out-of-band network."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df3967d1_03499e2f","line":4,"updated":"2017-08-03 14:43:59.000000000","message":"s/boot/booting/","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"64072589818cfc05df3529c3ec5223fa92eb38a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for boot from remote volumes to ``irmc-virtual-media`` boot"},{"line_number":5,"context_line":"    interface. It enables boot configuration for iSCSI or FibreChannel via"},{"line_number":6,"context_line":"    out-of-band network."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df3967d1_9f25c30b","line":4,"in_reply_to":"df3967d1_03499e2f","updated":"2017-08-08 08:28:36.000000000","message":"Done","commit_id":"3f83f9a55dfb5da7f7363eb60d32027ee854635a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      connectors. All cards including those not used for volume boot should be"},{"line_number":13,"context_line":"      registered."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"        * A physical ID format is: ``\u003cCard Type\u003e\u003cSlot No\u003e-\u003cPort No\u003e``"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"            ``\u003cCard Type\u003e``"},{"line_number":18,"context_line":"                LAN, FC or CNA"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f436f4f_3abb85c5","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":8},"updated":"2017-08-15 12:04:06.000000000","message":"nit: the list is too indented","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"        * A physical ID format is: ``\u003cCard Type\u003e\u003cSlot No\u003e-\u003cPort No\u003e``"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"            ``\u003cCard Type\u003e``"},{"line_number":18,"context_line":"                LAN, FC or CNA"},{"line_number":19,"context_line":"            ``\u003cSlot No\u003e``"},{"line_number":20,"context_line":"                0 indicates onboard slot. Use 1 to 9 for addon slots."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f436f4f_5abf69a9","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":12},"updated":"2017-08-15 12:04:06.000000000","message":"these items are also overly indented","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a724293ed4f8beb5af7b8c503d0abde34a25736b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        * Set the IDs to ``node.driver_info.pci_physical_ids``. This parameter"},{"line_number":25,"context_line":"          is a list of pair of UUID of a resource (Port or Volume connector)"},{"line_number":26,"context_line":"          and a physical ID like:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"            pci_physical_ids \u003d 1ecd14ee-c191-4007-8413-16bb5d5a73a2:LAN0-1,1ecd14ee-c191-4007-8413-16bb5d5a73a2:CNA1-1"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f436f4f_dab359e8","line":26,"updated":"2017-08-15 12:04:06.000000000","message":"nit: please use double colon","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fee42461234a80d1d3f36b5ae9a1e4e970455f07","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      required. The configuration with DHCP is not supported yet."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    * For iSCSI, a subnet mask of the storage network is necessary. It should"},{"line_number":34,"context_line":"      be set to ``node.driver_info.storage_network_size`` as integer."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This feature requires specific FC cards or CNAs (Converged Network Adapter)."},{"line_number":37,"context_line":"    See the documentation of iRMC driver for details."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f436f4f_53a2cbfd","line":34,"range":{"start_line":34,"start_character":61,"end_line":34,"end_character":69},"updated":"2017-08-14 18:43:43.000000000","message":"nit: integer representing the subnet mask?","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b832a3b39b4e48a210dd3a2f6e33d9c45a293e63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9f436f4f_45f66165","line":38,"updated":"2017-08-15 20:02:59.000000000","message":"There are inaccuracies in this (based on what I see in the code) and the rendering is ugly.\n\nI\u0027ve pushed up a followup patch for this. I honestly feel that this release note is too long; we should be linking to documentation on this, but anyway... https://review.openstack.org/#/c/494007/","commit_id":"70530f9a668af6d59a3e72c230592a4b0dc2a1b8"}]}
