)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71332137ac32f66062e89598d620df9e3d6baf98","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Madhuri Kumari \u003cmadhuri.rai07@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-31 11:17:45 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a note for int conversion of permission"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In patch[1], we allowed to specify permission to be applied to"},{"line_number":10,"context_line":"TFTP directories using ``[pxe]/dir_permission``. This configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_a4d59ee7","line":7,"updated":"2017-05-31 15:30:56.000000000","message":"this isn\u0027t quite correct?","commit_id":"571eb167cdfe56c63fdc27c55efff30c9ed200a6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"596eb0e3b77f8998126ccfc589960fc959526c73","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is an integer value. This patch adds a note stating that this value"},{"line_number":12,"context_line":"should be an octal number."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://review.openstack.org/#/c/427077/11"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iba8d88bd6faba600d6b66d27f1700dae8dd29eee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_803005ea","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":46},"updated":"2017-06-02 09:35:18.000000000","message":"Better to give reference to git commit ID instead of review link. I think it is 0f7a85e1ecd7b3e7bdbc297f47a498139ed40107","commit_id":"69e8cf6041a0ad0a2c41d52e42366e25d8910526"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0da1ff3c7672874fc9419c5b8600722741f5d1c4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is an integer value. This patch adds a note stating that this value"},{"line_number":12,"context_line":"should be an octal number."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] I3119ec7ae31bf82f716bf082fa4c3296d6aa3587"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iba8d88bd6faba600d6b66d27f1700dae8dd29eee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_30a719c0","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":45},"updated":"2017-06-05 08:36:24.000000000","message":"This is Change-ID. If you could add git commit Id, one can use git commands to get information about that patch. Ex:\n$ git show 0f7a85e1ecd7b3e7bdbc297f47a498139ed40107","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d836c704038a0f2152a379fdec327b6ebff23350","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is an integer value. This patch adds a note stating that this value"},{"line_number":12,"context_line":"should be an octal number."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] I3119ec7ae31bf82f716bf082fa4c3296d6aa3587"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iba8d88bd6faba600d6b66d27f1700dae8dd29eee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_5ff615d9","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":45},"in_reply_to":"df140735_30a719c0","updated":"2017-06-05 12:24:09.000000000","message":"I\u0027m a little confused by Shivanad\u0027s comment, considering a change-id is on line 16, and the end commit would be what is viewable in the client.","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4a3b848ba935ea7e04f0b53cee22992697531dab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is an integer value. This patch adds a note stating that this value"},{"line_number":12,"context_line":"should be an octal number."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] I3119ec7ae31bf82f716bf082fa4c3296d6aa3587"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iba8d88bd6faba600d6b66d27f1700dae8dd29eee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_f333e212","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":45},"in_reply_to":"df140735_5ff615d9","updated":"2017-06-05 14:55:39.000000000","message":"This is the change ID of the original patch (not this one). Shiv is asking for the commit ID instead. We don\u0027t have a rule about this and personally I don\u0027t care which is used (I\u0027m even good if there is a link to the review patch). Seems like a nit to me but maybe others -1 for it, dunno.","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3dc364843228acb1bc0837962c61e76d144662ca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is an integer value. This patch adds a note stating that this value"},{"line_number":12,"context_line":"should be an octal number."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] I3119ec7ae31bf82f716bf082fa4c3296d6aa3587"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iba8d88bd6faba600d6b66d27f1700dae8dd29eee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_e04d2b3b","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":45},"in_reply_to":"df140735_f333e212","updated":"2017-06-06 08:35:59.000000000","message":"Added git commit id.","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"ff80799a2e16d3caf96116eec20c70e802b91794","unresolved":false,"context_lines":[{"line_number":894,"context_line":"# Number of retries in the case of a failed action (currently"},{"line_number":895,"context_line":"# only used when deatchingvolumes). This option is part of"},{"line_number":896,"context_line":"# boot-from-volume work, which is not currently exposed to"},{"line_number":897,"context_line":"# users. (integer value)"},{"line_number":898,"context_line":"#action_retries \u003d 3"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Retry interval in seconds in the case of a failed action"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df140735_cdd23b35","line":897,"updated":"2017-05-29 09:08:00.000000000","message":"Not patch related","commit_id":"0e8a46e525f44010fc2d4f7eb4f7a1a7b7469253"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f8a4ef68181da3faeb85de336ca7266e93d06ccb","unresolved":false,"context_lines":[{"line_number":894,"context_line":"# Number of retries in the case of a failed action (currently"},{"line_number":895,"context_line":"# only used when deatchingvolumes). This option is part of"},{"line_number":896,"context_line":"# boot-from-volume work, which is not currently exposed to"},{"line_number":897,"context_line":"# users. (integer value)"},{"line_number":898,"context_line":"#action_retries \u003d 3"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Retry interval in seconds in the case of a failed action"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df140735_24c9c977","line":897,"in_reply_to":"df140735_cdd23b35","updated":"2017-05-29 16:16:06.000000000","message":"Yes, that\u0027s because some other patch did not update this file. Sigh. Ghe, we don\u0027t -1 for these now, since we don\u0027t have a test in gate. Having said that, I just pushed up a patch to fix because (another sigh) I see there is a typo (https://review.openstack.org/468919).","commit_id":"0e8a46e525f44010fc2d4f7eb4f7a1a7b7469253"}],"ironic/conf/pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f8a4ef68181da3faeb85de336ca7266e93d06ccb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \"creating files that cannot be read by the TFTP server. \""},{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. Input should be an integer conversion of \""},{"line_number":91,"context_line":"                      \"valid octal permission. For example: \""},{"line_number":92,"context_line":"                      \"int(0o755) is 493.\")),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_246d4998","line":90,"updated":"2017-05-29 16:16:06.000000000","message":"not really \u0027input\u0027.\n\nHow about \u0027The value must be the integer, not the octal, representation; for example, use 493 instead of 0o755.\u0027","commit_id":"0e8a46e525f44010fc2d4f7eb4f7a1a7b7469253"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6fee627490af0a9058344810b63b439615cde2b9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. The value must an integer and not the \""},{"line_number":91,"context_line":"                      \"octal representation of permission. For example: \""},{"line_number":92,"context_line":"                      \"use 493 instead of 0o755.\")),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":94,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":95,"context_line":"               help\u003d_(\u0027Bootfile DHCP parameter.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_c321d1a1","line":92,"range":{"start_line":91,"start_character":59,"end_line":92,"end_character":52},"updated":"2017-05-30 13:20:40.000000000","message":"I\u0027m kind of curious, why can\u0027t we just indicate that the number has to be in Ocatal format to begin with?  An integer representation of the octal number representing permissions is just going to be be confusing...   especially when it comes to config management and larger environments where configuration audits may take place.","commit_id":"649da51e458c2435db80bb49b154f88adfdc6934"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb3201c0b2f3903dcd2f31733df3b04677a456dc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. The value can be an octal as well as \""},{"line_number":91,"context_line":"                      \"decimal number. For example: Both 0o755 and 493 are \""},{"line_number":92,"context_line":"                      \"valid and same permission.\")),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":94,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_6bade0e7","line":91,"updated":"2017-06-02 01:04:20.000000000","message":"nit, s/as well as/or/\n\nmaybe \u0027For example, 0o755 and 493 are valid and equivalent.\u0027","commit_id":"571eb167cdfe56c63fdc27c55efff30c9ed200a6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d836c704038a0f2152a379fdec327b6ebff23350","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \"creating files that cannot be read by the TFTP server. \""},{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. We recommend that an octal value is \""},{"line_number":91,"context_line":"                      \"specified. For example: 0o755\")),"},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_5f717575","line":90,"range":{"start_line":90,"start_character":40,"end_line":90,"end_character":49},"updated":"2017-06-05 12:24:09.000000000","message":"I  know this is nit-picking wording, but we should say that this value must be an octal value. An integer value will result in unexpected behavior.","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d52667320067b67814074f99e2adc4eb3d4c5894","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \"creating files that cannot be read by the TFTP server. \""},{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. We recommend that an octal value is \""},{"line_number":91,"context_line":"                      \"specified. For example: 0o755\")),"},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_0eeaa9d6","line":90,"range":{"start_line":90,"start_character":40,"end_line":90,"end_character":49},"in_reply_to":"df140735_2e620dd9","updated":"2017-06-05 15:02:44.000000000","message":"Yeah, silly base-10 world :)  I guess my fear is an operator gets up set they set it to \"755\" and they don\u0027t get rwxr-x-r-x.","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4a3b848ba935ea7e04f0b53cee22992697531dab","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \"creating files that cannot be read by the TFTP server. \""},{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. We recommend that an octal value is \""},{"line_number":91,"context_line":"                      \"specified. For example: 0o755\")),"},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_2e620dd9","line":90,"range":{"start_line":90,"start_character":40,"end_line":90,"end_character":49},"in_reply_to":"df140735_5f717575","updated":"2017-06-05 14:55:39.000000000","message":"An integer value works too? Maybe we are confusing octal vs decimal representation of an integer value?","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4a3b848ba935ea7e04f0b53cee22992697531dab","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. We recommend that an octal value is \""},{"line_number":91,"context_line":"                      \"specified. For example: 0o755\")),"},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Bootfile DHCP parameter.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_8ef479f2","line":91,"updated":"2017-06-05 14:55:39.000000000","message":"Maybe \u0027It is recommended that this be in octal representatation, for example 0o755.\u0027","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d52667320067b67814074f99e2adc4eb3d4c5894","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. We recommend that an octal value is \""},{"line_number":91,"context_line":"                      \"specified. For example: 0o755\")),"},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Bootfile DHCP parameter.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ce3391aa","line":91,"in_reply_to":"df140735_8ef479f2","updated":"2017-06-05 15:02:44.000000000","message":"++++++++++++","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3dc364843228acb1bc0837962c61e76d144662ca","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \"Setting to \u003cNone\u003e will result in the operating \""},{"line_number":89,"context_line":"                      \"system\u0027s umask to be utilized for the creation of new \""},{"line_number":90,"context_line":"                      \"tftp folders. We recommend that an octal value is \""},{"line_number":91,"context_line":"                      \"specified. For example: 0o755\")),"},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":93,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Bootfile DHCP parameter.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_60423b11","line":91,"in_reply_to":"df140735_ce3391aa","updated":"2017-06-06 08:35:59.000000000","message":"I have rephrased the sentence.","commit_id":"2b7f578a95b30cb11dd97c4b9bb02a55987be305"}]}
