)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"5320784187227eff305c2ea2c63065a9b35d4331","unresolved":false,"context_lines":[{"line_number":13,"context_line":"breaking sphinx-build."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I472ea434900ae64e8688f1e58d1e48c34ffeb3cd"},{"line_number":16,"context_line":"Closes-Bug: #1694724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_bdba4c07","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2017-05-31 19:39:54.000000000","message":"I think we can remove netboot from the default_boot_options but I don\u0027t think we should call the bug closed. This is a solution to a symptom of the true problem that Doug and Ruby outlined in the bug.","commit_id":"550dd9ccef0dd4c66a3f7962b263c7032d87fc11"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"22880094e32797454a605133844acee00f830f42","unresolved":false,"context_lines":[{"line_number":13,"context_line":"breaking sphinx-build."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I472ea434900ae64e8688f1e58d1e48c34ffeb3cd"},{"line_number":16,"context_line":"Closes-Bug: #1694724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_fc528a12","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"df140735_bc600403","updated":"2017-06-06 14:24:19.000000000","message":"Yeah fair point! Doesn\u0027t seem to matter now though since your other fix merged. Thanks!","commit_id":"550dd9ccef0dd4c66a3f7962b263c7032d87fc11"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d2fd7e28df7a9f8cab469976c8a514d4e27d5395","unresolved":false,"context_lines":[{"line_number":13,"context_line":"breaking sphinx-build."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I472ea434900ae64e8688f1e58d1e48c34ffeb3cd"},{"line_number":16,"context_line":"Closes-Bug: #1694724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_bc600403","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"df140735_bdba4c07","updated":"2017-06-01 05:46:43.000000000","message":"I beg to differ. It seems (in the bug comments and IRC) we have agreed that logging warnings right on module import is bad, especially when they are emitted for default config option values. And we\u0027d like to keep the current behavior (failing on warnings) to not introduce more things like that in the future.\n\nThis patch exactly removes the warning by not emitting it at all. There is an alternative patch from Ruby that moves the stuff in the code path, but this warning is a deprecation one and is \u003e8mo old, so IMO it is better to simply flip the default as promised.\n\nI\u0027d say this patch does close this bug.","commit_id":"550dd9ccef0dd4c66a3f7962b263c7032d87fc11"}],"ironic/conf/deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eef1996274a4e96d216cec706a4aac4c6e15c45c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               choices\u003d[\u0027netboot\u0027, \u0027local\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\"Default boot option to use when no boot option is \""},{"line_number":72,"context_line":"                      \"requested in node\u0027s driver_info.\")),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_9e3e42d8","line":72,"updated":"2017-06-01 17:27:02.000000000","message":"nit (was already there). maybe s/requested/specified/","commit_id":"856093c751b36ace0c82c25fde4897823f8410b1"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eef1996274a4e96d216cec706a4aac4c6e15c45c","unresolved":false,"context_lines":[{"line_number":925,"context_line":"    :raises: InvalidParameterValue if the capabilities string is not a"},{"line_number":926,"context_line":"         dict or is malformed."},{"line_number":927,"context_line":"    :returns: A string representing the boot option type. Defaults to"},{"line_number":928,"context_line":"        \u0027netboot\u0027."},{"line_number":929,"context_line":"    \"\"\""},{"line_number":930,"context_line":"    capabilities \u003d parse_instance_info_capabilities(node)"},{"line_number":931,"context_line":"    return capabilities.get(\u0027boot_option\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_7913885d","line":928,"updated":"2017-06-01 17:27:02.000000000","message":"i think we should change this; just delete the \u0027Defaults to..\u0027 sentence.","commit_id":"856093c751b36ace0c82c25fde4897823f8410b1"}],"ironic/tests/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eef1996274a4e96d216cec706a4aac4c6e15c45c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.config(enabled_drivers\u003d[\u0027fake\u0027])"},{"line_number":130,"context_line":"        self.config(enabled_hardware_types\u003d[\u0027fake-hardware\u0027])"},{"line_number":131,"context_line":"        self.config(enabled_network_interfaces\u003d[\u0027flat\u0027, \u0027noop\u0027, \u0027neutron\u0027])"},{"line_number":132,"context_line":"        # NOTE(pas-ha) to not complicate tests setup,"},{"line_number":133,"context_line":"        # continue to use \u0027netboot\u0027 as default_boot_option"},{"line_number":134,"context_line":"        self.config(default_boot_option\u003d\u0027netboot\u0027, group\u003d\u0027deploy\u0027)"},{"line_number":135,"context_line":"        for iface in drivers_base.ALL_INTERFACES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_59468423","line":132,"updated":"2017-06-01 17:27:02.000000000","message":"should this be a TODO? I mean, now that we\u0027ve changed the default value, do we want it to be netboot or local for our testing purposes? (I\u0027m assuming we were already testing both...)","commit_id":"856093c751b36ace0c82c25fde4897823f8410b1"}],"releasenotes/notes/default-boot-option-local-beb0753efec1b3eb.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eef1996274a4e96d216cec706a4aac4c6e15c45c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default of ``[deploy]default_boot_option`` was changed to ``local``."},{"line_number":5,"context_line":"    Operators requiring netboot and still relying on former default (``None``"},{"line_number":6,"context_line":"    treated as ``netboot``) are required to specify ``netboot`` value for this"},{"line_number":7,"context_line":"    option explicitly in ironic configuration file."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_b9280034","line":4,"updated":"2017-06-01 17:27:02.000000000","message":"maybe s/was/configuration option was/","commit_id":"856093c751b36ace0c82c25fde4897823f8410b1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eef1996274a4e96d216cec706a4aac4c6e15c45c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default of ``[deploy]default_boot_option`` was changed to ``local``."},{"line_number":5,"context_line":"    Operators requiring netboot and still relying on former default (``None``"},{"line_number":6,"context_line":"    treated as ``netboot``) are required to specify ``netboot`` value for this"},{"line_number":7,"context_line":"    option explicitly in ironic configuration file."},{"line_number":8,"context_line":"    Failure to do so without changes to node properties and associated nova"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_b9dda043","line":5,"updated":"2017-06-01 17:27:02.000000000","message":"nit s/default/default behaviour/","commit_id":"856093c751b36ace0c82c25fde4897823f8410b1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eef1996274a4e96d216cec706a4aac4c6e15c45c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default of ``[deploy]default_boot_option`` was changed to ``local``."},{"line_number":5,"context_line":"    Operators requiring netboot and still relying on former default (``None``"},{"line_number":6,"context_line":"    treated as ``netboot``) are required to specify ``netboot`` value for this"},{"line_number":7,"context_line":"    option explicitly in ironic configuration file."},{"line_number":8,"context_line":"    Failure to do so without changes to node properties and associated nova"},{"line_number":9,"context_line":"    flavors might result in a failure to boot a node (depending on the user"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_f9a1d8aa","line":6,"updated":"2017-06-01 17:27:02.000000000","message":"really nit cuz you used \u0027requiring\u0027 above, s/are required to/should/","commit_id":"856093c751b36ace0c82c25fde4897823f8410b1"}]}