)]}'
{"ironic/common/keystone.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5da49dd01fa3bead81528db5a7a413e8185dcbb","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@ks_exceptions"},{"line_number":54,"context_line":"def get_session(group, auth\u003dNone, **session_kwargs):"},{"line_number":55,"context_line":"    auth \u003d auth or load_auth_from_config(group)"},{"line_number":56,"context_line":"    if not auth:"},{"line_number":57,"context_line":"        msg \u003d _(\"Failed to load auth from [%(section)s] config section.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_394bd059","line":54,"range":{"start_line":54,"start_character":34,"end_line":54,"end_character":50},"updated":"2017-06-01 17:17:33.000000000","message":"do we need this? Is it to override the things specified in config?","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"76376a94ce9a56b5e128d87ec39ac0536b470768","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@ks_exceptions"},{"line_number":54,"context_line":"def get_session(group, auth\u003dNone, **session_kwargs):"},{"line_number":55,"context_line":"    auth \u003d auth or load_auth_from_config(group)"},{"line_number":56,"context_line":"    if not auth:"},{"line_number":57,"context_line":"        msg \u003d _(\"Failed to load auth from [%(section)s] config section.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_46456a42","line":54,"range":{"start_line":54,"start_character":34,"end_line":54,"end_character":50},"in_reply_to":"df140735_394bd059","updated":"2017-06-02 08:17:28.000000000","message":"yes, while not used right now in this patch, it will be used in the following patches.\n\nthe thing is, we have some options in config that effectively duplicate those registered by keystoneauth for sessions, for example [glance]glance_api_insecure or [neutron]url_timeout.\n\nso in order to provide a proper deprecation for those, we need a way to override default values read from config (mostly None) with these options when they are set.\n\nOf course to be strict I could move this change to the first patch that actually uses it if you prefer.","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5da49dd01fa3bead81528db5a7a413e8185dcbb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    try:"},{"line_number":68,"context_line":"        auth \u003d kaloading.load_auth_from_conf_options(CONF, group)"},{"line_number":69,"context_line":"    except kaexception.MissingRequiredOptions as exc:"},{"line_number":70,"context_line":"        LOG.debug(\u0027Failed to load credentials from group %(grp)s: %(err)s\u0027,"},{"line_number":71,"context_line":"                  {\u0027grp\u0027: group, \u0027err\u0027: exc})"},{"line_number":72,"context_line":"        raise"},{"line_number":73,"context_line":"    return auth"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_f928b886","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":17},"updated":"2017-06-01 17:17:33.000000000","message":"I\u0027d make it an error","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"76376a94ce9a56b5e128d87ec39ac0536b470768","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    try:"},{"line_number":68,"context_line":"        auth \u003d kaloading.load_auth_from_conf_options(CONF, group)"},{"line_number":69,"context_line":"    except kaexception.MissingRequiredOptions as exc:"},{"line_number":70,"context_line":"        LOG.debug(\u0027Failed to load credentials from group %(grp)s: %(err)s\u0027,"},{"line_number":71,"context_line":"                  {\u0027grp\u0027: group, \u0027err\u0027: exc})"},{"line_number":72,"context_line":"        raise"},{"line_number":73,"context_line":"    return auth"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_668f4e75","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":17},"in_reply_to":"df140735_f928b886","updated":"2017-06-02 08:17:28.000000000","message":"indeed, this is remnant of previous logic when such error was not fatal as values could be attempted to load from legacy config section. Will change.\n\nIt also seems to me now there\u0027s too much logs and raises in this and previous function combined. I\u0027ll think of how to unify those raises.","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36febee23a6addc3050982aac16ca85cfa96a1cd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        auth \u003d kaloading.load_auth_from_conf_options(CONF, group)"},{"line_number":56,"context_line":"    except kaexception.MissingRequiredOptions:"},{"line_number":57,"context_line":"        LOG.error(\u0027Failed to load auth plugin from group %s\u0027, group)"},{"line_number":58,"context_line":"        raise"},{"line_number":59,"context_line":"    session \u003d kaloading.load_session_from_conf_options("},{"line_number":60,"context_line":"        CONF, group, auth\u003dauth)"},{"line_number":61,"context_line":"    return session"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_4a7996c5","line":58,"updated":"2017-06-06 07:47:04.000000000","message":"this changes exception type from ConfigInvalid to MissingRequiredOptions. I guess it\u0027s fine, but something to be mindful of.","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"aa8381447859471e5e6dbacf8dfd41bc54841cf2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        auth \u003d kaloading.load_auth_from_conf_options(CONF, group)"},{"line_number":56,"context_line":"    except kaexception.MissingRequiredOptions:"},{"line_number":57,"context_line":"        LOG.error(\u0027Failed to load auth plugin from group %s\u0027, group)"},{"line_number":58,"context_line":"        raise"},{"line_number":59,"context_line":"    session \u003d kaloading.load_session_from_conf_options("},{"line_number":60,"context_line":"        CONF, group, auth\u003dauth)"},{"line_number":61,"context_line":"    return session"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_85b68189","line":58,"in_reply_to":"df140735_4a7996c5","updated":"2017-06-06 08:24:50.000000000","message":"the change in exception is not really like this, due to the decorator the actual exception is changed from more general KeystoneFailure that wraps ConfigInvalid to simply ConfigInvalid.","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"}],"releasenotes/notes/no-more-legacy-auth-eeb32f907d0ab5de.yaml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8c222f8d8db6140c790e9c39ec3c48fca70f88bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - swift"},{"line_number":12,"context_line":"      - inspector"},{"line_number":13,"context_line":"      - service_catalog"},{"line_number":14,"context_line":"      - cinder"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_cd5c1280","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":14},"updated":"2017-06-01 15:35:44.000000000","message":"not sure if I have to mention cinder here","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"76376a94ce9a56b5e128d87ec39ac0536b470768","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - swift"},{"line_number":12,"context_line":"      - inspector"},{"line_number":13,"context_line":"      - service_catalog"},{"line_number":14,"context_line":"      - cinder"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_666bce84","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":14},"in_reply_to":"df140735_590e8432","updated":"2017-06-02 08:17:28.000000000","message":"I removed it from this list, but added filling up the cinder section in devstack plugin as it seems people developing the cinder integration have either indeed used the legacy auth loading or have not yet started actually calling cinderclient :) let\u0027s not break their effort.","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5da49dd01fa3bead81528db5a7a413e8185dcbb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - swift"},{"line_number":12,"context_line":"      - inspector"},{"line_number":13,"context_line":"      - service_catalog"},{"line_number":14,"context_line":"      - cinder"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_590e8432","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":14},"in_reply_to":"df140735_cd5c1280","updated":"2017-06-01 17:17:33.000000000","message":"I\u0027d say not, as it does not seem to be used by anything yet, we don\u0027t have APIs. But should not hurt :)","commit_id":"c4e39da333c35fb5da0dd8ff5931a1521b9101e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36febee23a6addc3050982aac16ca85cfa96a1cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic no longer supports loading of auth credentials from"},{"line_number":5,"context_line":"    ``[keystone_authtoken]`` config section."},{"line_number":6,"context_line":"    All operators are now required to populate appropriate config sections"},{"line_number":7,"context_line":"    with auth options for given service."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_aa6832f4","line":4,"updated":"2017-06-06 07:47:04.000000000","message":"this needs rewording a bit. we do not stop supporting [keystone_authtoken] completely. maybe\n\n Ironic no longer falls back to load authentication configuration options for accessing other services from the ``[keystone_authtoken]`` section.","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"aa8381447859471e5e6dbacf8dfd41bc54841cf2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic no longer supports loading of auth credentials from"},{"line_number":5,"context_line":"    ``[keystone_authtoken]`` config section."},{"line_number":6,"context_line":"    All operators are now required to populate appropriate config sections"},{"line_number":7,"context_line":"    with auth options for given service."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_057f11ab","line":4,"in_reply_to":"df140735_aa6832f4","updated":"2017-06-06 08:24:50.000000000","message":"agree, will do","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"b822607b62cc4ff96c7c69ba80e61056f320712b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic no longer supports loading of auth credentials from"},{"line_number":5,"context_line":"    ``[keystone_authtoken]`` config section."},{"line_number":6,"context_line":"    All operators are now required to populate appropriate config sections"},{"line_number":7,"context_line":"    with auth options for given service."},{"line_number":8,"context_line":"    Currently those config sections are"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_6f6583b4","line":5,"range":{"start_line":5,"start_character":29,"end_line":5,"end_character":35},"updated":"2017-06-06 11:53:29.000000000","message":"I think that you can put \u0027configuration\u0027 here too.","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36febee23a6addc3050982aac16ca85cfa96a1cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Ironic no longer supports loading of auth credentials from"},{"line_number":5,"context_line":"    ``[keystone_authtoken]`` config section."},{"line_number":6,"context_line":"    All operators are now required to populate appropriate config sections"},{"line_number":7,"context_line":"    with auth options for given service."},{"line_number":8,"context_line":"    Currently those config sections are"},{"line_number":9,"context_line":"      - glance"},{"line_number":10,"context_line":"      - neutron"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_8a6b2eef","line":7,"updated":"2017-06-06 07:47:04.000000000","message":"then this sentence can be dropped, I guess","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36febee23a6addc3050982aac16ca85cfa96a1cd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``[keystone_authtoken]`` config section."},{"line_number":6,"context_line":"    All operators are now required to populate appropriate config sections"},{"line_number":7,"context_line":"    with auth options for given service."},{"line_number":8,"context_line":"    Currently those config sections are"},{"line_number":9,"context_line":"      - glance"},{"line_number":10,"context_line":"      - neutron"},{"line_number":11,"context_line":"      - swift"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_6a6e9a00","line":8,"updated":"2017-06-06 07:47:04.000000000","message":"s/config/configuration/","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"aa8381447859471e5e6dbacf8dfd41bc54841cf2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``[keystone_authtoken]`` config section."},{"line_number":6,"context_line":"    All operators are now required to populate appropriate config sections"},{"line_number":7,"context_line":"    with auth options for given service."},{"line_number":8,"context_line":"    Currently those config sections are"},{"line_number":9,"context_line":"      - glance"},{"line_number":10,"context_line":"      - neutron"},{"line_number":11,"context_line":"      - swift"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_c54eb995","line":8,"in_reply_to":"df140735_6a6e9a00","updated":"2017-06-06 08:24:50.000000000","message":"will do","commit_id":"14e29e83cfc48c09d4822736630788d251990c53"}]}