)]}'
{"ironic/common/images.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0528fd75f6ea0b5c4dda440b90554f604f242a05","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            ldlinux_src \u003d CONF.ldlinux_c32"},{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            for directory in LDLINUX_SRC_DIRS:"},{"line_number":205,"context_line":"                ldlinux_src \u003d directory + \u0027/ldlinux.c32\u0027"},{"line_number":206,"context_line":"                if os.path.exists(ldlinux_src):"},{"line_number":207,"context_line":"                    break"},{"line_number":208,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_cf46cfc0","line":205,"updated":"2017-06-06 12:05:33.000000000","message":"Please use os.path.join().","commit_id":"a1953768ebeaba28ab12d35a72b46563f0fcf70f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8f8c9fbd16f48324268fbd9923f1af16b7f5301c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            ldlinux_src \u003d CONF.ldlinux_c32"},{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            for directory in LDLINUX_SRC_DIRS:"},{"line_number":205,"context_line":"                ldlinux_src \u003d directory + \u0027/ldlinux.c32\u0027"},{"line_number":206,"context_line":"                if os.path.exists(ldlinux_src):"},{"line_number":207,"context_line":"                    break"},{"line_number":208,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_3d26a069","line":205,"in_reply_to":"df140735_cf46cfc0","updated":"2017-06-06 14:59:36.000000000","message":"Done","commit_id":"a1953768ebeaba28ab12d35a72b46563f0fcf70f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0528fd75f6ea0b5c4dda440b90554f604f242a05","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            for directory in LDLINUX_SRC_DIRS:"},{"line_number":205,"context_line":"                ldlinux_src \u003d directory + \u0027/ldlinux.c32\u0027"},{"line_number":206,"context_line":"                if os.path.exists(ldlinux_src):"},{"line_number":207,"context_line":"                    break"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                ldlinux_src \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_af1a7bc2","line":206,"updated":"2017-06-06 12:05:33.000000000","message":"Better to use os.path.isfile() here.","commit_id":"a1953768ebeaba28ab12d35a72b46563f0fcf70f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8f8c9fbd16f48324268fbd9923f1af16b7f5301c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            for directory in LDLINUX_SRC_DIRS:"},{"line_number":205,"context_line":"                ldlinux_src \u003d directory + \u0027/ldlinux.c32\u0027"},{"line_number":206,"context_line":"                if os.path.exists(ldlinux_src):"},{"line_number":207,"context_line":"                    break"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                ldlinux_src \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_5d3394ab","line":206,"in_reply_to":"df140735_af1a7bc2","updated":"2017-06-06 14:59:36.000000000","message":"Done","commit_id":"a1953768ebeaba28ab12d35a72b46563f0fcf70f"}],"ironic/conf/default.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"077908af36515af42485c9f2aaa967d0a3f4b2c2","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    cfg.StrOpt(\u0027ldlinux_c32\u0027,"},{"line_number":203,"context_line":"               help\u003d_(\u0027Path to ldlinux.c32 file. This file is required for \u0027"},{"line_number":204,"context_line":"                      \u0027syslinux 5.0 or later. If not specified, the file is \u0027"},{"line_number":205,"context_line":"                      \u0027searched in general paths, \u0027"},{"line_number":206,"context_line":"                      \u0027\"/usr/lib/syslinux/modules/bios/ldlinux.c32\" and \u0027"},{"line_number":207,"context_line":"                      \u0027\"/usr/share/syslinux/ldlinux.c32\".\u0027)),"},{"line_number":208,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_d2062c87","line":205,"updated":"2017-06-13 01:04:50.000000000","message":"nit, s/searched in general paths,/looked for in /","commit_id":"dd264ac90906ec7940a08b607b861ed69accca98"}],"releasenotes/notes/bug-1694645-57289200e35bd883.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f82aaccc57ae43bc36c546118334305316765346","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    environment using syslinux 5.00 or later such as Ubuntu 16.04. This is"},{"line_number":6,"context_line":"    caused by a change in syslinux that ldlinux.c32 is required for creating"},{"line_number":7,"context_line":"    boot ISO. This file is searched in the following general paths:"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"      * /usr/lib/syslinux/modules/bios/ldlinux.c32"},{"line_number":10,"context_line":"      * /usr/share/syslinux/ldlinux.c32"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_e9b1b848","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"updated":"2017-06-05 10:12:34.000000000","message":"Remove empty \u0027space\u0027","commit_id":"f58ed88d03a02e8f1e1a02666344e8498ca47625"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4d1c58bee6b9fd7f42cf357e2e2da43b287d86fb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    environment using syslinux 5.00 or later such as Ubuntu 16.04. This is"},{"line_number":6,"context_line":"    caused by a change in syslinux that ldlinux.c32 is required for creating"},{"line_number":7,"context_line":"    boot ISO. This file is searched in the following general paths:"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"      * /usr/lib/syslinux/modules/bios/ldlinux.c32"},{"line_number":10,"context_line":"      * /usr/share/syslinux/ldlinux.c32"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_62f6ded9","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"in_reply_to":"df140735_e9b1b848","updated":"2017-06-05 12:58:36.000000000","message":"Done","commit_id":"f58ed88d03a02e8f1e1a02666344e8498ca47625"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f82aaccc57ae43bc36c546118334305316765346","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      * /usr/lib/syslinux/modules/bios/ldlinux.c32"},{"line_number":10,"context_line":"      * /usr/share/syslinux/ldlinux.c32"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This path can be set with the configuration parameter "},{"line_number":13,"context_line":"    ``[DEFAULT]/ldlinux_c32`` for another distribution or for a case where the"},{"line_number":14,"context_line":"    path is changed with future update."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_c9acb4ee","line":12,"range":{"start_line":12,"start_character":57,"end_line":12,"end_character":58},"updated":"2017-06-05 10:12:34.000000000","message":"Remove empty \u0027space\u0027","commit_id":"f58ed88d03a02e8f1e1a02666344e8498ca47625"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4d1c58bee6b9fd7f42cf357e2e2da43b287d86fb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      * /usr/lib/syslinux/modules/bios/ldlinux.c32"},{"line_number":10,"context_line":"      * /usr/share/syslinux/ldlinux.c32"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This path can be set with the configuration parameter "},{"line_number":13,"context_line":"    ``[DEFAULT]/ldlinux_c32`` for another distribution or for a case where the"},{"line_number":14,"context_line":"    path is changed with future update."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_023162a3","line":12,"range":{"start_line":12,"start_character":57,"end_line":12,"end_character":58},"in_reply_to":"df140735_c9acb4ee","updated":"2017-06-05 12:58:36.000000000","message":"Done","commit_id":"f58ed88d03a02e8f1e1a02666344e8498ca47625"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"077908af36515af42485c9f2aaa967d0a3f4b2c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix a bug that netboot is unavailable with virtual media boot in an"},{"line_number":5,"context_line":"    environment using syslinux 5.00 or later such as Ubuntu 16.04. This is"},{"line_number":6,"context_line":"    caused by a change in syslinux that ldlinux.c32 is required for creating"},{"line_number":7,"context_line":"    boot ISO. This file is searched in the following general paths:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f231b9d_12226401","line":4,"updated":"2017-06-13 01:04:50.000000000","message":"nit s/Fix/Fixes/\n\nMaybe \u0027Fixes a bug whereby netboot was unavailable with ...\u0027","commit_id":"dd264ac90906ec7940a08b607b861ed69accca98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"077908af36515af42485c9f2aaa967d0a3f4b2c2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      * /usr/lib/syslinux/modules/bios/ldlinux.c32"},{"line_number":10,"context_line":"      * /usr/share/syslinux/ldlinux.c32"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This path can be set with the configuration parameter"},{"line_number":13,"context_line":"    ``[DEFAULT]/ldlinux_c32`` for another distribution or for a case where the"},{"line_number":14,"context_line":"    path is changed with future update."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f231b9d_b27cd0eb","line":12,"updated":"2017-06-13 01:04:50.000000000","message":"s/parameter/option/","commit_id":"dd264ac90906ec7940a08b607b861ed69accca98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"077908af36515af42485c9f2aaa967d0a3f4b2c2","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This path can be set with the configuration parameter"},{"line_number":13,"context_line":"    ``[DEFAULT]/ldlinux_c32`` for another distribution or for a case where the"},{"line_number":14,"context_line":"    path is changed with future update."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f231b9d_f2dfe8d3","line":14,"updated":"2017-06-13 01:04:50.000000000","message":"I think it might be easier to understand if you mention the config option first, and then mention that if it isn\u0027t set, the default is to look for the file in these paths:\n\nEg:\n\nFixes a bug whereby netboot was unavailable with virtual media boot in an environment using syslinux 5.00 or later, such as Ubuntu 16.04. This was caused by a syslinux change; the ldlinux.c32 file is required for creating a boot ISO. To address this, the new configuration option ``[DEFAULT]/ldlinux_32`` can be set to the path of the ldlinux.c32 file. If not specified, the default is to look for the file in the paths:\n- /usr/lib/...\n- /usr/share/...","commit_id":"dd264ac90906ec7940a08b607b861ed69accca98"}]}