)]}'
{"ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fadea29fdde250ff3469e29aff9b50421f27fb61","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        if kwargs.get(\u0027volume_id\u0027):"},{"line_number":309,"context_line":"            volume_target[\u0027volume_id\u0027] \u003d kwargs[\u0027volume_id\u0027]"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        if kwargs.get(\u0027boot_index\u0027):"},{"line_number":312,"context_line":"            volume_target[\u0027boot_index\u0027] \u003d kwargs[\u0027boot_index\u0027]"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return self._create_request(\u0027volume/targets\u0027, volume_target)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_bb6bd682","line":311,"updated":"2017-06-19 15:53:16.000000000","message":"Any reason for not using \"if \u0027boot_index\u0027 in kwargs:\" ?  If the key is actually present,  where as 0/1 behave differently and the value is skipped.\n\n  \u003e\u003e\u003e if 0:\n  ...     print(\"test\")\n  ...\n  \u003e\u003e\u003e if 1:\n  ...     print(\"test\")\n  ...\n  test\n  \u003e\u003e\u003e if 63:\n  ...     print(\"test\")\n  ...\n  test\n  \u003e\u003e\u003e","commit_id":"9c13e2701acb2c31bb22aece7b307c685566a8eb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"eee7701974faa385f70acc990a619540927fa3be","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def show_volume_connector(self, volume_connector_ident):"},{"line_number":138,"context_line":"        \"\"\"Gets a specific volume connector."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :param volume_connector_ident: Name or UUID of the volume connector."},{"line_number":141,"context_line":"        :return: Serialized volume connector as a dictionary."},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        return self._show_request(\u0027volume/connectors\u0027, volume_connector_ident)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_39b9ace8","line":140,"updated":"2017-06-23 02:45:30.000000000","message":"volume connector doesn\u0027t have a name.","commit_id":"468fc331c25ff4bcf8bee2b8e5268b32c89ab898"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"eee7701974faa385f70acc990a619540927fa3be","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    def show_volume_target(self, volume_target_ident):"},{"line_number":147,"context_line":"        \"\"\"Gets a specific volume target."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param volume_target_ident: Name or UUID of the volume target."},{"line_number":150,"context_line":"        :return: Serialized volume target as a dictionary."},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        return self._show_request(\u0027volume/targets\u0027, volume_target_ident)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_79a4c4b9","line":149,"updated":"2017-06-23 02:45:30.000000000","message":"volume target doesn\u0027t have a name, either.","commit_id":"468fc331c25ff4bcf8bee2b8e5268b32c89ab898"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2ef5cc5dfdeb0de536cc39b8b862e9cead1df5f0","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    @base.handle_errors"},{"line_number":356,"context_line":"    def delete_volume_connector(self, volume_connector_ident):"},{"line_number":357,"context_line":"        \"\"\"Deletes a volume connector having the specified UUID or name."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        :param volume_connector_ident: Name or UUID of the volume connector."},{"line_number":360,"context_line":"        :return: A tuple with the server response and the response body."}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_4efa9042","line":357,"range":{"start_line":357,"start_character":63,"end_line":357,"end_character":72},"updated":"2017-08-01 03:29:47.000000000","message":"volume connector does not support names.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"dd7a8b2184096daba74a992fd3cc2c8f86d1f3fb","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    @base.handle_errors"},{"line_number":356,"context_line":"    def delete_volume_connector(self, volume_connector_ident):"},{"line_number":357,"context_line":"        \"\"\"Deletes a volume connector having the specified UUID or name."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        :param volume_connector_ident: Name or UUID of the volume connector."},{"line_number":360,"context_line":"        :return: A tuple with the server response and the response body."}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_4755a0c5","line":357,"range":{"start_line":357,"start_character":63,"end_line":357,"end_character":72},"in_reply_to":"df3967d1_4efa9042","updated":"2017-08-02 12:27:39.000000000","message":"Done.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2ef5cc5dfdeb0de536cc39b8b862e9cead1df5f0","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @base.handle_errors"},{"line_number":366,"context_line":"    def delete_volume_target(self, volume_target_ident):"},{"line_number":367,"context_line":"        \"\"\"Deletes a volume target having the specified UUID or name."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        :param volume_target_ident: Name or UUID of the volume target."},{"line_number":370,"context_line":"        :return: A tuple with the server response and the response body."}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_0e9a4813","line":367,"range":{"start_line":367,"start_character":60,"end_line":367,"end_character":69},"updated":"2017-08-01 03:29:47.000000000","message":"neither volume_target","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"dd7a8b2184096daba74a992fd3cc2c8f86d1f3fb","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @base.handle_errors"},{"line_number":366,"context_line":"    def delete_volume_target(self, volume_target_ident):"},{"line_number":367,"context_line":"        \"\"\"Deletes a volume target having the specified UUID or name."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        :param volume_target_ident: Name or UUID of the volume target."},{"line_number":370,"context_line":"        :return: A tuple with the server response and the response body."}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_0761d8a9","line":367,"range":{"start_line":367,"start_character":60,"end_line":367,"end_character":69},"in_reply_to":"df3967d1_0e9a4813","updated":"2017-08-02 12:27:39.000000000","message":"Done.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return self._create_request(\u0027portgroups\u0027, portgroup)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @base.handle_errors"},{"line_number":270,"context_line":"    def create_volume_connector(self, node_uuid, **kwargs):"},{"line_number":271,"context_line":"        \"\"\"Create a volume connector with the specified parameters."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :param node_uuid: The UUID of the node which owns the volume connector."}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_e7c1d855","line":270,"updated":"2017-08-04 20:15:03.000000000","message":"Why **kwargs? Why not.\n\n def create_volume_connector(self, node_uuid, type\u003dNone, connector_id\u003dNone):\n\nThough slightly ugly to override the built-in \u0027type\u0027. Not saying to change, just asking why. Is it to match with the rest of the code.\n\nAre extra **kwargs passed in that are ignored?","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return self._create_request(\u0027portgroups\u0027, portgroup)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @base.handle_errors"},{"line_number":270,"context_line":"    def create_volume_connector(self, node_uuid, **kwargs):"},{"line_number":271,"context_line":"        \"\"\"Create a volume connector with the specified parameters."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :param node_uuid: The UUID of the node which owns the volume connector."}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_5bc94b76","line":270,"in_reply_to":"df3967d1_e7c1d855","updated":"2017-08-07 15:28:58.000000000","message":"Yes, it is to match with the rest of the code.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        volume_connector[\u0027node_uuid\u0027] \u003d node_uuid"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if kwargs.get(\u0027type\u0027):"},{"line_number":286,"context_line":"            volume_connector[\u0027type\u0027] \u003d kwargs[\u0027type\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if kwargs.get(\u0027connector_id\u0027):"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_07ecdc27","line":285,"updated":"2017-08-04 20:15:03.000000000","message":"Probably not an issue but if \u0027type\u0027 is equal to 0, \u0027\u0027, [], or {}. Then it doesn\u0027t get set.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        volume_connector[\u0027node_uuid\u0027] \u003d node_uuid"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if kwargs.get(\u0027type\u0027):"},{"line_number":286,"context_line":"            volume_connector[\u0027type\u0027] \u003d kwargs[\u0027type\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if kwargs.get(\u0027connector_id\u0027):"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_3bc68769","line":285,"in_reply_to":"df3967d1_07ecdc27","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            volume_connector[\u0027type\u0027] \u003d kwargs[\u0027type\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if kwargs.get(\u0027connector_id\u0027):"},{"line_number":289,"context_line":"            volume_connector[\u0027connector_id\u0027] \u003d kwargs[\u0027connector_id\u0027]"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        return self._create_request(\u0027volume/connectors\u0027, volume_connector)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_59153be4","line":289,"updated":"2017-08-04 11:19:41.000000000","message":"nit:\n\n for arg in (\u0027type\u0027, \u0027connector_id\u0027):\n     if kwargs.get(arg):\n         volume_connector[arg] \u003d kwargs[arg]","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            volume_connector[\u0027type\u0027] \u003d kwargs[\u0027type\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if kwargs.get(\u0027connector_id\u0027):"},{"line_number":289,"context_line":"            volume_connector[\u0027connector_id\u0027] \u003d kwargs[\u0027connector_id\u0027]"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        return self._create_request(\u0027volume/connectors\u0027, volume_connector)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_1ba183aa","line":289,"in_reply_to":"df3967d1_59153be4","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            volume_connector[\u0027type\u0027] \u003d kwargs[\u0027type\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if kwargs.get(\u0027connector_id\u0027):"},{"line_number":289,"context_line":"            volume_connector[\u0027connector_id\u0027] \u003d kwargs[\u0027connector_id\u0027]"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        return self._create_request(\u0027volume/connectors\u0027, volume_connector)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_87b1ec49","line":289,"in_reply_to":"df3967d1_59153be4","updated":"2017-08-04 20:15:03.000000000","message":"Or;\n\n for arg in (\u0027type\u0027, \u0027connector_id\u0027):\n     if arg in kwargs:\n         volume_connector[arg] \u003d kwargs[arg]","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            volume_connector[\u0027type\u0027] \u003d kwargs[\u0027type\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if kwargs.get(\u0027connector_id\u0027):"},{"line_number":289,"context_line":"            volume_connector[\u0027connector_id\u0027] \u003d kwargs[\u0027connector_id\u0027]"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        return self._create_request(\u0027volume/connectors\u0027, volume_connector)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_dbaadb83","line":289,"in_reply_to":"df3967d1_87b1ec49","updated":"2017-08-07 15:28:58.000000000","message":"Done, thank to your suggestion.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        return self._create_request(\u0027volume/connectors\u0027, volume_connector)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.handle_errors"},{"line_number":294,"context_line":"    def create_volume_target(self, node_uuid, **kwargs):"},{"line_number":295,"context_line":"        \"\"\"Create a volume target with the specified parameters."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        :param node_uuid: The UUID of the node which owns the volume target."}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_27bfe0aa","line":294,"updated":"2017-08-04 20:15:03.000000000","message":"Same question as line 270","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        return self._create_request(\u0027volume/connectors\u0027, volume_connector)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.handle_errors"},{"line_number":294,"context_line":"    def create_volume_target(self, node_uuid, **kwargs):"},{"line_number":295,"context_line":"        \"\"\"Create a volume target with the specified parameters."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        :param node_uuid: The UUID of the node which owns the volume target."}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_1b8aa31a","line":294,"in_reply_to":"df3967d1_27bfe0aa","updated":"2017-08-07 15:28:58.000000000","message":"Replied as line 270.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            volume_target[\u0027volume_id\u0027] \u003d kwargs[\u0027volume_id\u0027]"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        if \u0027boot_index\u0027 in kwargs:"},{"line_number":317,"context_line":"            volume_target[\u0027boot_index\u0027] \u003d kwargs[\u0027boot_index\u0027]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        return self._create_request(\u0027volume/targets\u0027, volume_target)"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_39d6f729","line":317,"updated":"2017-08-04 11:19:41.000000000","message":"similar to above","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            volume_target[\u0027volume_id\u0027] \u003d kwargs[\u0027volume_id\u0027]"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        if \u0027boot_index\u0027 in kwargs:"},{"line_number":317,"context_line":"            volume_target[\u0027boot_index\u0027] \u003d kwargs[\u0027boot_index\u0027]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        return self._create_request(\u0027volume/targets\u0027, volume_target)"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_3b744735","line":317,"in_reply_to":"df3967d1_39d6f729","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        \"\"\"Create a volume connector with the specified parameters."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :param node_uuid: The UUID of the node which owns the volume connector."},{"line_number":274,"context_line":"        :param kwargs:"},{"line_number":275,"context_line":"            type: type of the volume connector."},{"line_number":276,"context_line":"            connector_id: connector_id of the volume connector."},{"line_number":277,"context_line":"            uuid: UUID of the volume connector."}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_5ce893e0","line":274,"updated":"2017-08-15 02:17:32.000000000","message":"what about \u0027extra\u0027? I don\u0027t see it described here.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        \"\"\"Create a volume connector with the specified parameters."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :param node_uuid: The UUID of the node which owns the volume connector."},{"line_number":274,"context_line":"        :param kwargs:"},{"line_number":275,"context_line":"            type: type of the volume connector."},{"line_number":276,"context_line":"            connector_id: connector_id of the volume connector."},{"line_number":277,"context_line":"            uuid: UUID of the volume connector."}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_6cf6edd9","line":274,"in_reply_to":"9f436f4f_5ce893e0","updated":"2017-08-16 01:03:35.000000000","message":"Done","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        :param kwargs:"},{"line_number":275,"context_line":"            type: type of the volume connector."},{"line_number":276,"context_line":"            connector_id: connector_id of the volume connector."},{"line_number":277,"context_line":"            uuid: UUID of the volume connector."},{"line_number":278,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":279,"context_line":"        connector."},{"line_number":280,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_5cfad3bc","line":277,"updated":"2017-08-15 02:17:32.000000000","message":"Are you going to use this?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        :param kwargs:"},{"line_number":275,"context_line":"            type: type of the volume connector."},{"line_number":276,"context_line":"            connector_id: connector_id of the volume connector."},{"line_number":277,"context_line":"            uuid: UUID of the volume connector."},{"line_number":278,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":279,"context_line":"        connector."},{"line_number":280,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_2cfc65b3","line":277,"in_reply_to":"9f436f4f_5cfad3bc","updated":"2017-08-16 01:03:35.000000000","message":"Done","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            connector_id: connector_id of the volume connector."},{"line_number":277,"context_line":"            uuid: UUID of the volume connector."},{"line_number":278,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":279,"context_line":"        connector."},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":"        volume_connector \u003d {\u0027node_uuid\u0027: node_uuid,"},{"line_number":282,"context_line":"                            \u0027extra\u0027: kwargs.get(\u0027extra\u0027, {})}"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_1c19eb20","line":279,"updated":"2017-08-15 02:17:32.000000000","message":"Maybe indent this?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            connector_id: connector_id of the volume connector."},{"line_number":277,"context_line":"            uuid: UUID of the volume connector."},{"line_number":278,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":279,"context_line":"        connector."},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":"        volume_connector \u003d {\u0027node_uuid\u0027: node_uuid,"},{"line_number":282,"context_line":"                            \u0027extra\u0027: kwargs.get(\u0027extra\u0027, {})}"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_0c31a1a3","line":279,"in_reply_to":"9f436f4f_1c19eb20","updated":"2017-08-16 01:03:35.000000000","message":"Done","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        volume_connector \u003d {\u0027node_uuid\u0027: node_uuid,"},{"line_number":282,"context_line":"                            \u0027extra\u0027: kwargs.get(\u0027extra\u0027, {})}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        for arg in (\u0027type\u0027, \u0027connector_id\u0027):"},{"line_number":285,"context_line":"            if arg in kwargs:"},{"line_number":286,"context_line":"                volume_connector[arg] \u003d kwargs[arg]"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_fcc3c755","line":284,"updated":"2017-08-15 02:17:32.000000000","message":"Just to make sure. These two are not optional when creating a volume connector. Are you not checking that they are specified because you want to test that if they aren\u0027t specified, the request returns an error?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        volume_connector \u003d {\u0027node_uuid\u0027: node_uuid,"},{"line_number":282,"context_line":"                            \u0027extra\u0027: kwargs.get(\u0027extra\u0027, {})}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        for arg in (\u0027type\u0027, \u0027connector_id\u0027):"},{"line_number":285,"context_line":"            if arg in kwargs:"},{"line_number":286,"context_line":"                volume_connector[arg] \u003d kwargs[arg]"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_cc26f968","line":284,"in_reply_to":"9f436f4f_fcc3c755","updated":"2017-08-16 01:03:35.000000000","message":"I looked at the other tests; am guessing that the error/check is to be done at the request, not here.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        \"\"\"Create a volume target with the specified parameters."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param node_uuid: The UUID of the node which owns the volume target."},{"line_number":295,"context_line":"        :param kwargs:"},{"line_number":296,"context_line":"            volume_type: type of the volume target."},{"line_number":297,"context_line":"            volume_id: volume_id of the volume target."},{"line_number":298,"context_line":"            boot_index: boot index of the volume target"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_3ce5cf09","line":295,"updated":"2017-08-15 02:17:32.000000000","message":"what about \u0027extra\u0027? I don\u0027t see it described here.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        \"\"\"Create a volume target with the specified parameters."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param node_uuid: The UUID of the node which owns the volume target."},{"line_number":295,"context_line":"        :param kwargs:"},{"line_number":296,"context_line":"            volume_type: type of the volume target."},{"line_number":297,"context_line":"            volume_id: volume_id of the volume target."},{"line_number":298,"context_line":"            boot_index: boot index of the volume target"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_ac297537","line":295,"in_reply_to":"9f436f4f_3ce5cf09","updated":"2017-08-16 01:03:35.000000000","message":"Done","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            volume_type: type of the volume target."},{"line_number":297,"context_line":"            volume_id: volume_id of the volume target."},{"line_number":298,"context_line":"            boot_index: boot index of the volume target"},{"line_number":299,"context_line":"            uuid: UUID of the volume target."},{"line_number":300,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":301,"context_line":"        target."},{"line_number":302,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_7c023771","line":299,"updated":"2017-08-15 02:17:32.000000000","message":"? I looked at api-ref, I don\u0027t think we allow setting the UUID of the volume target. (I was too lazy to look at the actual code.)","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            volume_type: type of the volume target."},{"line_number":297,"context_line":"            volume_id: volume_id of the volume target."},{"line_number":298,"context_line":"            boot_index: boot index of the volume target"},{"line_number":299,"context_line":"            uuid: UUID of the volume target."},{"line_number":300,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":301,"context_line":"        target."},{"line_number":302,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_4c1a0917","line":299,"in_reply_to":"9f436f4f_7c023771","updated":"2017-08-16 01:03:35.000000000","message":"I looked at the CLI, and it is there, so added code to use it.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            boot_index: boot index of the volume target"},{"line_number":299,"context_line":"            uuid: UUID of the volume target."},{"line_number":300,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":301,"context_line":"        target."},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        volume_target \u003d {\u0027node_uuid\u0027: node_uuid,"},{"line_number":304,"context_line":"                         \u0027extra\u0027: kwargs.get(\u0027extra\u0027, {})}"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_dcd48322","line":301,"updated":"2017-08-15 02:17:32.000000000","message":"maybe indent this?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            boot_index: boot index of the volume target"},{"line_number":299,"context_line":"            uuid: UUID of the volume target."},{"line_number":300,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":301,"context_line":"        target."},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        volume_target \u003d {\u0027node_uuid\u0027: node_uuid,"},{"line_number":304,"context_line":"                         \u0027extra\u0027: kwargs.get(\u0027extra\u0027, {})}"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_2c1585e5","line":301,"in_reply_to":"9f436f4f_dcd48322","updated":"2017-08-16 01:03:35.000000000","message":"Done","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        for arg in (\u0027volume_type\u0027, \u0027volume_id\u0027, \u0027boot_index\u0027):"},{"line_number":307,"context_line":"            if arg in kwargs:"},{"line_number":308,"context_line":"                volume_target[arg] \u003d kwargs[arg]"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        return self._create_request(\u0027volume/targets\u0027, volume_target)"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_bcc2df57","line":308,"updated":"2017-08-15 02:17:32.000000000","message":"I\u0027m curious. Why do you need to add at L304 above, but don\u0027t need to add any of these if they aren\u0027t in kwargs?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        for arg in (\u0027volume_type\u0027, \u0027volume_id\u0027, \u0027boot_index\u0027):"},{"line_number":307,"context_line":"            if arg in kwargs:"},{"line_number":308,"context_line":"                volume_target[arg] \u003d kwargs[arg]"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        return self._create_request(\u0027volume/targets\u0027, volume_target)"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_ecd89d53","line":308,"in_reply_to":"9f436f4f_bcc2df57","updated":"2017-08-16 01:03:35.000000000","message":"I cleaned it up","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cde41cd7271314c46479ebd660489be794c6f34e","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Update the specified volume connector."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        :param uuid: The unique identifier of the volume connector."},{"line_number":424,"context_line":"        :param patch: List of dicts representing json patches."},{"line_number":425,"context_line":"        :return: A tuple with the server response and the updated volume"},{"line_number":426,"context_line":"        connector."},{"line_number":427,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_67faa4bd","line":424,"updated":"2017-08-15 02:20:04.000000000","message":"each dict has \u0027path\u0027, \u0027op\u0027 and \u0027value\u0027 keys right, which represents the json patch for updating one field?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        :param uuid: The unique identifier of the volume connector."},{"line_number":424,"context_line":"        :param patch: List of dicts representing json patches."},{"line_number":425,"context_line":"        :return: A tuple with the server response and the updated volume"},{"line_number":426,"context_line":"        connector."},{"line_number":427,"context_line":"        \"\"\""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return self._patch_request(\u0027volume/connectors\u0027, uuid, patch)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_1c9c4b68","line":426,"updated":"2017-08-15 02:17:32.000000000","message":"nit, maybe indent this?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        :param uuid: The unique identifier of the volume target."},{"line_number":436,"context_line":"        :param patch: List of dicts representing json patches."},{"line_number":437,"context_line":"        :return: A tuple with the server response and the updated volume"},{"line_number":438,"context_line":"        target."},{"line_number":439,"context_line":"        \"\"\""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        return self._patch_request(\u0027volume/targets\u0027, uuid, patch)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_7c86b715","line":438,"updated":"2017-08-15 02:17:32.000000000","message":"ditto","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"}],"ironic_tempest_plugin/tests/api/admin/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# NOTE(jroll): resources must be deleted in a specific order, this list"},{"line_number":35,"context_line":"# defines the resource types to clean up, and the correct order."},{"line_number":36,"context_line":"RESOURCE_TYPES \u003d [\u0027port\u0027, \u0027node\u0027, \u0027chassis\u0027, \u0027portgroup\u0027, \u0027volume_connector\u0027,"},{"line_number":37,"context_line":"                  \u0027volume_target\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def creates(resource):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_5ccd3364","line":37,"updated":"2017-08-15 02:17:32.000000000","message":"I am not that familiar with the volume stuff, but since a node is the owner of a volume resource, wouldn\u0027t it make more sense to delete the volume resources first, before deleting the node?\n\nAlthough I think that\u0027s a similar thing wrt portgroups, and they are after node too. Hmm.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"85915c2e35a5f0a1c1f22721a5d14cf77bbcd0f9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# NOTE(jroll): resources must be deleted in a specific order, this list"},{"line_number":35,"context_line":"# defines the resource types to clean up, and the correct order."},{"line_number":36,"context_line":"RESOURCE_TYPES \u003d [\u0027port\u0027, \u0027node\u0027, \u0027chassis\u0027, \u0027portgroup\u0027, \u0027volume_connector\u0027,"},{"line_number":37,"context_line":"                  \u0027volume_target\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def creates(resource):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_bbd3fc5f","line":37,"in_reply_to":"9f436f4f_5ccd3364","updated":"2017-08-15 10:50:57.000000000","message":"++, I\u0027d suppose this should be [port, portgroup, volume_connector, volume_target, node, chassis]","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        :param node_uuid: The unique identifier of the node."},{"line_number":231,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":232,"context_line":"        connector."},{"line_number":233,"context_line":"        \"\"\""},{"line_number":234,"context_line":"        resp, body \u003d cls.client.create_volume_connector(node_uuid\u003dnode_uuid,"},{"line_number":235,"context_line":"                                                        **kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_9ce4bbe1","line":232,"updated":"2017-08-15 02:17:32.000000000","message":"indent?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param node_uuid: The unique identifier of the node."},{"line_number":245,"context_line":"        :return: A tuple with the server response and the created volume"},{"line_number":246,"context_line":"        target."},{"line_number":247,"context_line":"        \"\"\""},{"line_number":248,"context_line":"        resp, body \u003d cls.client.create_volume_target(node_uuid\u003dnode_uuid,"},{"line_number":249,"context_line":"                                                     **kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_7ce917b5","line":246,"updated":"2017-08-15 02:17:32.000000000","message":"ditto","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    def delete_volume_connector(cls, volume_connector_ident):"},{"line_number":317,"context_line":"        \"\"\"Deletes a volume connector having the specified UUID or name."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        :param volume_connector_ident: The name or UUID of the volume"},{"line_number":320,"context_line":"        connector."},{"line_number":321,"context_line":"        :return: Server response."},{"line_number":322,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_bc0c1fa5","line":319,"updated":"2017-08-15 02:17:32.000000000","message":"Do we allow naming of volume connectors? I thought it was just a UUID.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    def delete_volume_target(cls, volume_target_ident):"},{"line_number":333,"context_line":"        \"\"\"Deletes a volume target having the specified UUID or name."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        :param volume_target_ident: The name or UUID of the volume target."},{"line_number":336,"context_line":"        :return: Server response."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        resp, body \u003d cls.client.delete_volume_target(volume_target_ident)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_5c4093a5","line":335,"updated":"2017-08-15 02:17:32.000000000","message":"ditto, i think it can only be a UUID","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"}],"ironic_tempest_plugin/tests/api/admin/test_volume_connector.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"50c495c842c8d6398a3adcc078743b9447935657","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_delete_volume_connector(self):"},{"line_number":62,"context_line":"        \"\"\"Delete a volume connector.\"\"\""},{"line_number":63,"context_line":"        # Powering off the Node before deleting a volume conductor."},{"line_number":64,"context_line":"        self._node_power_off(\u0027delete a volume conductor\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.delete_volume_connector(self.volume_connector[\u0027uuid\u0027])"},{"line_number":67,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_connector,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f1d235d_451af1cb","line":64,"updated":"2017-07-05 13:56:26.000000000","message":"We could use:\n  self.client.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027manage\u0027)","commit_id":"b9ea484f9118a750c04016d0791e9c3fc1e8b235"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"520a56b0ffa8805ad57714c71f81d5dd4f0fadb8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        _, volume_connector \u003d self.create_volume_connector("},{"line_number":87,"context_line":"            self.node[\u0027uuid\u0027], type\u003d\u0027iqn\u0027,"},{"line_number":88,"context_line":"            connector_id\u003ddata_utils.rand_name(\u0027connector_id\u0027))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_6b81b84a","line":89,"updated":"2017-08-01 10:43:32.000000000","message":"+1","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2ef5cc5dfdeb0de536cc39b8b862e9cead1df5f0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        _, volume_connector \u003d self.create_volume_connector("},{"line_number":87,"context_line":"            self.node[\u0027uuid\u0027], type\u003d\u0027iqn\u0027,"},{"line_number":88,"context_line":"            connector_id\u003ddata_utils.rand_name(\u0027connector_id\u0027))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_e9e93e80","line":89,"updated":"2017-08-01 03:29:47.000000000","message":"no need to create volume_connector here, we can reuse self.volume_connector here.\nditto for following tests.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"dd7a8b2184096daba74a992fd3cc2c8f86d1f3fb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        _, volume_connector \u003d self.create_volume_connector("},{"line_number":87,"context_line":"            self.node[\u0027uuid\u0027], type\u003d\u0027iqn\u0027,"},{"line_number":88,"context_line":"            connector_id\u003ddata_utils.rand_name(\u0027connector_id\u0027))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_c741900d","line":89,"in_reply_to":"df3967d1_e9e93e80","updated":"2017-08-02 12:27:39.000000000","message":"Done, thanks.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"520a56b0ffa8805ad57714c71f81d5dd4f0fadb8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                  \u0027op\u0027: \u0027replace\u0027,"},{"line_number":94,"context_line":"                  \u0027value\u0027: new_connector_id}]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Powering off the Node before updating a volume conductor."},{"line_number":97,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.client.update_volume_connector(volume_connector[\u0027uuid\u0027], patch)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_4b9834bf","line":96,"updated":"2017-08-01 10:43:32.000000000","message":"let\u0027s also add a negative test that update and delete fail for powered on nodes","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"dd7a8b2184096daba74a992fd3cc2c8f86d1f3fb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                  \u0027op\u0027: \u0027replace\u0027,"},{"line_number":94,"context_line":"                  \u0027value\u0027: new_connector_id}]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Powering off the Node before updating a volume conductor."},{"line_number":97,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.client.update_volume_connector(volume_connector[\u0027uuid\u0027], patch)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_874b8829","line":96,"in_reply_to":"df3967d1_4b9834bf","updated":"2017-08-02 12:27:39.000000000","message":"Done, thanks.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_connector,"},{"line_number":60,"context_line":"                          self.volume_connector[\u0027uuid\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @decorators.idempotent_id(\u0027ccbda5e6-52b7-400c-94d7-25eec1d590f0\u0027)"},{"line_number":63,"context_line":"    def test_delete_volume_connector_error(self):"},{"line_number":64,"context_line":"        \"\"\"Delete a volume connector on powered on Node.\"\"\""},{"line_number":65,"context_line":"        # Powering on the Node before deleting a volume conductor."}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_19d9f355","line":62,"updated":"2017-08-04 11:19:41.000000000","message":"please add negative tag to this test similar to https://github.com/openstack/ironic/commit/63a852eb8c4e3b885340aec62d19d6d1f15bf995","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_connector,"},{"line_number":60,"context_line":"                          self.volume_connector[\u0027uuid\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @decorators.idempotent_id(\u0027ccbda5e6-52b7-400c-94d7-25eec1d590f0\u0027)"},{"line_number":63,"context_line":"    def test_delete_volume_connector_error(self):"},{"line_number":64,"context_line":"        \"\"\"Delete a volume connector on powered on Node.\"\"\""},{"line_number":65,"context_line":"        # Powering on the Node before deleting a volume conductor."}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_3ba9e77a","line":62,"in_reply_to":"df3967d1_19d9f355","updated":"2017-08-07 15:28:58.000000000","message":"Added.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Powering on the Node before deleting a volume conductor."},{"line_number":66,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":69,"context_line":"                                         \u0027\\\\\\\\\"volume connector deletion\\\\\\\\\" \u0027"},{"line_number":70,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_ea899d74","line":68,"updated":"2017-08-04 20:15:03.000000000","message":"Same as line 132","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Powering on the Node before deleting a volume conductor."},{"line_number":66,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":69,"context_line":"                                         \u0027\\\\\\\\\"volume connector deletion\\\\\\\\\" \u0027"},{"line_number":70,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_1bb863c6","line":68,"in_reply_to":"df3967d1_ea899d74","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertIn(next_marker, body[\u0027next\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u00273c6f8354-e9bd-4f21-aae2-6deb96b04be7\u0027)"},{"line_number":104,"context_line":"    def test_update_volume_connector_replace(self):"},{"line_number":105,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_f9dbcf4b","line":104,"updated":"2017-08-04 11:19:41.000000000","message":"docstring please","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertIn(next_marker, body[\u0027next\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u00273c6f8354-e9bd-4f21-aae2-6deb96b04be7\u0027)"},{"line_number":104,"context_line":"    def test_update_volume_connector_replace(self):"},{"line_number":105,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_7bc88f54","line":104,"in_reply_to":"df3967d1_f9dbcf4b","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":119,"context_line":"        self.assertEqual(new_connector_id, body[\u0027connector_id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00275af8dc7a-9965-4787-8184-e60aeaf30957\u0027)"},{"line_number":122,"context_line":"    def test_update_volume_connector_replace_error(self):"},{"line_number":123,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_d9decb3c","line":121,"updated":"2017-08-04 11:19:41.000000000","message":"ditto re negative","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":119,"context_line":"        self.assertEqual(new_connector_id, body[\u0027connector_id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00275af8dc7a-9965-4787-8184-e60aeaf30957\u0027)"},{"line_number":122,"context_line":"    def test_update_volume_connector_replace_error(self):"},{"line_number":123,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_dbe65be9","line":121,"in_reply_to":"df3967d1_d9decb3c","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(new_connector_id, body[\u0027connector_id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00275af8dc7a-9965-4787-8184-e60aeaf30957\u0027)"},{"line_number":122,"context_line":"    def test_update_volume_connector_replace_error(self):"},{"line_number":123,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_b9e9c7e6","line":122,"updated":"2017-08-04 11:19:41.000000000","message":"docstring please","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(new_connector_id, body[\u0027connector_id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00275af8dc7a-9965-4787-8184-e60aeaf30957\u0027)"},{"line_number":122,"context_line":"    def test_update_volume_connector_replace_error(self):"},{"line_number":123,"context_line":"        new_connector_id \u003d data_utils.rand_name(\u0027connector_id\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/connector_id\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_9bd0d3f9","line":122,"in_reply_to":"df3967d1_b9e9c7e6","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # Powering on the Node before updating a volume conductor."},{"line_number":130,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":133,"context_line":"                                         \u0027\\\\\\\\\"volume connector update\\\\\\\\\" \u0027"},{"line_number":134,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":135,"context_line":"        self.assertRaisesRegex(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_8ab1f149","line":132,"updated":"2017-08-04 20:15:03.000000000","message":"I don\u0027t understand why need to use re.escape()\n\nWhy not use a r\u0027\u0027 string?\n\n regex_str \u003d (r\u0027.*The requested action \"volume connector\" \u0027\n              r\u0027can not be performed on node.*\u0027)","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # Powering on the Node before updating a volume conductor."},{"line_number":130,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":133,"context_line":"                                         \u0027\\\\\\\\\"volume connector update\\\\\\\\\" \u0027"},{"line_number":134,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":135,"context_line":"        self.assertRaisesRegex(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_1b062388","line":132,"in_reply_to":"df3967d1_8ab1f149","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                               patch)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027b95c75eb-4048-482e-99ff-fe1d32538383\u0027)"},{"line_number":142,"context_line":"    def test_update_volume_connector_remove(self):"},{"line_number":143,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":144,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":145,"context_line":"            self.volume_connector[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_99e4c30e","line":142,"updated":"2017-08-04 11:19:41.000000000","message":"ditto re docstring","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                               patch)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027b95c75eb-4048-482e-99ff-fe1d32538383\u0027)"},{"line_number":142,"context_line":"    def test_update_volume_connector_remove(self):"},{"line_number":143,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":144,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":145,"context_line":"            self.volume_connector[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_fb0a3f88","line":142,"in_reply_to":"df3967d1_99e4c30e","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":158,"context_line":"        self.assertEqual(new_extra, body[\u0027extra\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Removing the collection"},{"line_number":161,"context_line":"        self.client.update_volume_connector(self.volume_connector[\u0027uuid\u0027],"},{"line_number":162,"context_line":"                                            [{\u0027path\u0027: \u0027/extra\u0027,"},{"line_number":163,"context_line":"                                              \u0027op\u0027: \u0027remove\u0027}])"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_79efdfe8","line":160,"updated":"2017-08-04 11:19:41.000000000","message":"nit: I\u0027d split this into two tests","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":158,"context_line":"        self.assertEqual(new_extra, body[\u0027extra\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Removing the collection"},{"line_number":161,"context_line":"        self.client.update_volume_connector(self.volume_connector[\u0027uuid\u0027],"},{"line_number":162,"context_line":"                                            [{\u0027path\u0027: \u0027/extra\u0027,"},{"line_number":163,"context_line":"                                              \u0027op\u0027: \u0027remove\u0027}])"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_fb2fdff3","line":160,"in_reply_to":"df3967d1_79efdfe8","updated":"2017-08-07 15:28:58.000000000","message":"I will remember that next time. Thanks.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeConnector(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for boot from volume.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_d0d648f2","line":25,"updated":"2017-08-08 16:13:00.000000000","message":"It looks that description for some other tests.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeConnector(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for boot from volume.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_aaf21e05","line":25,"in_reply_to":"9f436f4f_d0d648f2","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":126,"context_line":"    @decorators.idempotent_id(\u00275af8dc7a-9965-4787-8184-e60aeaf30957\u0027)"},{"line_number":127,"context_line":"    def test_update_volume_connector_replace_error(self):"},{"line_number":128,"context_line":"        \"\"\"Updating a volume connector"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        Fail when updating a volume connector on node"},{"line_number":131,"context_line":"         with power on state."}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_907d60e9","line":128,"updated":"2017-08-08 16:13:00.000000000","message":".","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":126,"context_line":"    @decorators.idempotent_id(\u00275af8dc7a-9965-4787-8184-e60aeaf30957\u0027)"},{"line_number":127,"context_line":"    def test_update_volume_connector_replace_error(self):"},{"line_number":128,"context_line":"        \"\"\"Updating a volume connector"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        Fail when updating a volume connector on node"},{"line_number":131,"context_line":"         with power on state."}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_aa7d7e6f","line":128,"in_reply_to":"9f436f4f_907d60e9","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @decorators.idempotent_id(\u0027b95c75eb-4048-482e-99ff-fe1d32538383\u0027)"},{"line_number":152,"context_line":"    def test_update_volume_connector_remove(self):"},{"line_number":153,"context_line":"        \"\"\"Update a volume connector.\"\"\""},{"line_number":154,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":155,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":156,"context_line":"            self.volume_connector[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_d072c811","line":153,"range":{"start_line":153,"start_character":11,"end_line":153,"end_character":36},"updated":"2017-08-08 16:13:00.000000000","message":"Could you make docstring more specific?","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @decorators.idempotent_id(\u0027b95c75eb-4048-482e-99ff-fe1d32538383\u0027)"},{"line_number":152,"context_line":"    def test_update_volume_connector_remove(self):"},{"line_number":153,"context_line":"        \"\"\"Update a volume connector.\"\"\""},{"line_number":154,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":155,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":156,"context_line":"            self.volume_connector[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_8a82ba4e","line":153,"range":{"start_line":153,"start_character":11,"end_line":153,"end_character":36},"in_reply_to":"9f436f4f_d072c811","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        connector_id \u003d body[\u0027connector_id\u0027]"},{"line_number":158,"context_line":"        type \u003d \u0027iqn\u0027"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Powering off the Node before updating a volume conductor."},{"line_number":161,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        # Removing one item from the collection"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_50601833","line":160,"range":{"start_line":160,"start_character":57,"end_line":160,"end_character":66},"updated":"2017-08-08 16:13:00.000000000","message":"connector?","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        connector_id \u003d body[\u0027connector_id\u0027]"},{"line_number":158,"context_line":"        type \u003d \u0027iqn\u0027"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Powering off the Node before updating a volume conductor."},{"line_number":161,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        # Removing one item from the collection"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_4a94d28b","line":160,"range":{"start_line":160,"start_character":57,"end_line":160,"end_character":66},"in_reply_to":"9f436f4f_50601833","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u0027bfb0ca6b-086d-4663-9b25-e0eaf42da55b\u0027)"},{"line_number":184,"context_line":"    def test_update_volume_connector_add(self):"},{"line_number":185,"context_line":"        \"\"\"Update a volume connector.\"\"\""},{"line_number":186,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/extra/key3\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_10529068","line":185,"range":{"start_line":185,"start_character":11,"end_line":185,"end_character":36},"updated":"2017-08-08 16:13:00.000000000","message":"Same as above.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @decorators.idempotent_id(\u0027bfb0ca6b-086d-4663-9b25-e0eaf42da55b\u0027)"},{"line_number":184,"context_line":"    def test_update_volume_connector_add(self):"},{"line_number":185,"context_line":"        \"\"\"Update a volume connector.\"\"\""},{"line_number":186,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/extra/key3\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_0a8eca77","line":185,"range":{"start_line":185,"start_character":11,"end_line":185,"end_character":36},"in_reply_to":"9f436f4f_10529068","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                  \u0027op\u0027: \u0027add\u0027,"},{"line_number":193,"context_line":"                  \u0027value\u0027: new_extra[\u0027key3\u0027]}]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Powering off the Node before updating a volume conductor."},{"line_number":196,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self.client.update_volume_connector("}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_f04eecbf","line":195,"range":{"start_line":195,"start_character":57,"end_line":195,"end_character":66},"updated":"2017-08-08 16:13:00.000000000","message":"connector","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                  \u0027op\u0027: \u0027add\u0027,"},{"line_number":193,"context_line":"                  \u0027value\u0027: new_extra[\u0027key3\u0027]}]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Powering off the Node before updating a volume conductor."},{"line_number":196,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self.client.update_volume_connector("}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_caed6226","line":195,"range":{"start_line":195,"start_character":57,"end_line":195,"end_character":66},"in_reply_to":"9f436f4f_f04eecbf","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeConnector(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for volume connector.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_bc9bff15","line":25,"updated":"2017-08-15 02:17:32.000000000","message":"maybe s/positive/ because i saw at least one negative test.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeConnector(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for volume connector.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_bd44fd74","line":25,"in_reply_to":"9f436f4f_bc9bff15","updated":"2017-08-16 01:03:35.000000000","message":"Done","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeConnector(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for volume connector.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_47c44091","line":26,"updated":"2017-08-15 02:17:32.000000000","message":"What does \u0027basic\u0027 test cases mean anyway? Are there going to be more tests after this? I\u0027m asking because I don\u0027t know whether to check for completeness of tests.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273c3cbf45-488a-4386-a811-bf0aa2589c58\u0027)"},{"line_number":43,"context_line":"    def test_create_volume_connector(self):"},{"line_number":44,"context_line":"        \"\"\"Create a volume connector.\"\"\""},{"line_number":45,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":46,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(self.volume_connector[\u0027connector_id\u0027],"},{"line_number":48,"context_line":"                         body[\u0027connector_id\u0027])"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_1ce20ba1","line":45,"updated":"2017-08-15 02:17:32.000000000","message":"this isn\u0027t creating a volume connector, but the test is test_create_volume_connector()?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a2ab5d61a2007f99a80db1c7e3bf4ee0dd162b8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273c3cbf45-488a-4386-a811-bf0aa2589c58\u0027)"},{"line_number":43,"context_line":"    def test_create_volume_connector(self):"},{"line_number":44,"context_line":"        \"\"\"Create a volume connector.\"\"\""},{"line_number":45,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":46,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(self.volume_connector[\u0027connector_id\u0027],"},{"line_number":48,"context_line":"                         body[\u0027connector_id\u0027])"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_3d580d54","line":45,"in_reply_to":"9f436f4f_1ce20ba1","updated":"2017-08-16 01:03:35.000000000","message":"i changed it to create a volume connector with same id \u0026 type as existing volume connector so that it will error out.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(self.volume_connector[\u0027connector_id\u0027],"},{"line_number":48,"context_line":"                         body[\u0027connector_id\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @decorators.idempotent_id(\u00275795f816-0789-42e6-bb9c-91b4876ad13f\u0027)"},{"line_number":51,"context_line":"    def test_delete_volume_connector(self):"},{"line_number":52,"context_line":"        \"\"\"Delete a volume connector.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_c7d8307c","line":49,"updated":"2017-08-15 02:17:32.000000000","message":"what about a test trying to create a volume connector with the same connector type \u0026 ID of an existing volume connector?\n\nor using an invalid node UUID?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Show a specified volume connector.\"\"\""},{"line_number":83,"context_line":"        _, volume_connector \u003d self.client.show_volume_connector("},{"line_number":84,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":85,"context_line":"        self._assertExpected(self.volume_connector, volume_connector)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @decorators.idempotent_id(\u0027a4725778-e164-4ee5-96a0-66119a35f783\u0027)"},{"line_number":88,"context_line":"    def test_list_volume_connectors(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_dc96c3f0","line":85,"updated":"2017-08-15 02:17:32.000000000","message":"this test is quite similar to the one at L43","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.assertIn(self.volume_connector[\u0027type\u0027],"},{"line_number":94,"context_line":"                      [i[\u0027type\u0027] for i in body[\u0027connectors\u0027]])"},{"line_number":95,"context_line":"        self.assertIn(self.volume_connector[\u0027connector_id\u0027],"},{"line_number":96,"context_line":"                      [i[\u0027connector_id\u0027] for i in body[\u0027connectors\u0027]])"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @decorators.idempotent_id(\u00271d0459ad-01c0-46db-b930-7301bc2a3c98\u0027)"},{"line_number":99,"context_line":"    def test_list_with_limit(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_fca50748","line":96,"updated":"2017-08-15 02:17:32.000000000","message":"these seem like some odd assertions. I would have thought you would get the connector of interest from body[\u0027connectors\u0027], and just compare that connector with self.volume_connector. Are you expecting more than one volume connector here? Eg, it is possible that there could be another volume connector with the same type as self.volume_connector.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":156,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":157,"context_line":"        connector_id \u003d body[\u0027connector_id\u0027]"},{"line_number":158,"context_line":"        connector_type \u003d body[\u0027type\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Powering off the Node before updating a volume connector."},{"line_number":161,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_e777b49f","line":158,"updated":"2017-08-15 02:17:32.000000000","message":"I suppose this is ok, but I think we should be safe in assuming that self.volume_connector[\u0027connector_id\u0027] and self.volume_connector[\u0027type\u0027] are the same values as body[]. (I\u0027m wondering whether it is worth making the .show_volume_connector() request.","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        _, body \u003d self.client.show_volume_connector("},{"line_number":179,"context_line":"            self.volume_connector[\u0027uuid\u0027])"},{"line_number":180,"context_line":"        connector_id \u003d body[\u0027connector_id\u0027]"},{"line_number":181,"context_line":"        connector_type \u003d body[\u0027type\u0027]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        # Powering off the Node before updating a volume connector."},{"line_number":184,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_075e3811","line":181,"updated":"2017-08-15 02:17:32.000000000","message":"ditto","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                  \u0027value\u0027: new_extra[\u0027key3\u0027]},"},{"line_number":206,"context_line":"                 {\u0027path\u0027: \u0027/extra/key3\u0027,"},{"line_number":207,"context_line":"                  \u0027op\u0027: \u0027add\u0027,"},{"line_number":208,"context_line":"                  \u0027value\u0027: new_extra[\u0027key3\u0027]}]"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        # Powering off the Node before updating a volume connector."},{"line_number":211,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_47ad60e7","line":208,"updated":"2017-08-15 02:17:32.000000000","message":"Are you purposely testing what happens if the patch is trying to update the same thing twice?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3aa7df9a2daa6a1ca3d13b4ef4369de38a328f0c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # Powering off the Node before updating a volume connector."},{"line_number":211,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.client.update_volume_connector("},{"line_number":214,"context_line":"            self.volume_connector[\u0027uuid\u0027], patch)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        _, body \u003d self.client.show_volume_connector("}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_a7f08cfe","line":213,"updated":"2017-08-15 02:17:32.000000000","message":"it just occurred to me that this returns the response with updated volume connector. Why not just use this result instead of making the .show_volume_connector() call at L216?","commit_id":"dc2859c0f28cf240b07ea3cabe3982c23daaed1a"}],"ironic_tempest_plugin/tests/api/admin/test_volume_target.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fadea29fdde250ff3469e29aff9b50421f27fb61","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            volume_id\u003ddata_utils.rand_name(\u0027volume_id\u0027),"},{"line_number":84,"context_line":"            boot_index\u003ddata_utils.rand_int_id(0, 63))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        new_volume_id\u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/volume_id\u0027,"},{"line_number":89,"context_line":"                  \u0027op\u0027: \u0027replace\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_60bd89b5","line":86,"range":{"start_line":86,"start_character":21,"end_line":86,"end_character":22},"updated":"2017-06-19 15:53:16.000000000","message":"Pep8 failure - Add a space before \u003d to correct pep8 test failures.","commit_id":"9c13e2701acb2c31bb22aece7b307c685566a8eb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"eee7701974faa385f70acc990a619540927fa3be","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        _, volume_target \u003d self.create_volume_target("},{"line_number":82,"context_line":"            self.node[\u0027uuid\u0027], volume_type\u003ddata_utils.rand_name(\u0027volume_type\u0027),"},{"line_number":83,"context_line":"            volume_id\u003ddata_utils.rand_name(\u0027volume_id\u0027),"},{"line_number":84,"context_line":"            boot_index\u003ddata_utils.rand_int_id(0, 63))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_5928e832","line":84,"updated":"2017-06-23 02:45:30.000000000","message":"Is it necessary to create another volume target though a target is created in setUp?\nWhen the same boot_index is used as the value of the target created in setUp, it causes an error due to boot_index duplication.","commit_id":"468fc331c25ff4bcf8bee2b8e5268b32c89ab898"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"2b70e4a3e03240c3762b877601eac6593925d9af","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        _, volume_target \u003d self.create_volume_target("},{"line_number":82,"context_line":"            self.node[\u0027uuid\u0027], volume_type\u003ddata_utils.rand_name(\u0027volume_type\u0027),"},{"line_number":83,"context_line":"            volume_id\u003ddata_utils.rand_name(\u0027volume_id\u0027),"},{"line_number":84,"context_line":"            boot_index\u003ddata_utils.rand_int_id(0, 63))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_4dc81821","line":84,"in_reply_to":"5f201791_5928e832","updated":"2017-06-23 10:07:29.000000000","message":"I create another volume target because its value is independant to other functions. If I use the target created in setUp, the function that runs previously will change the data of the target and fails in the next function.","commit_id":"468fc331c25ff4bcf8bee2b8e5268b32c89ab898"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2ef5cc5dfdeb0de536cc39b8b862e9cead1df5f0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.node[\u0027uuid\u0027], volume_type\u003ddata_utils.rand_name(\u0027volume_type\u0027),"},{"line_number":87,"context_line":"            volume_id\u003ddata_utils.rand_name(\u0027volume_id\u0027),"},{"line_number":88,"context_line":"            boot_index\u003d20)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/volume_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_c9a31a4f","line":89,"updated":"2017-08-01 03:29:47.000000000","message":"reuse self.volume_target for this and following tests.","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"520a56b0ffa8805ad57714c71f81d5dd4f0fadb8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                  \u0027op\u0027: \u0027replace\u0027,"},{"line_number":94,"context_line":"                  \u0027value\u0027: new_volume_id}]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Powering off the Node before updating a volume target."},{"line_number":97,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.client.update_volume_target(volume_target[\u0027uuid\u0027], patch)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df3967d1_2b93b0a5","line":96,"updated":"2017-08-01 10:43:32.000000000","message":"ditto about some negative tests","commit_id":"b56f0d39be263066f61d9284c38e90bde9290cc6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # Powering off the Node before deleting a volume target."},{"line_number":54,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        \"\"\"Delete a volume target.\"\"\""},{"line_number":57,"context_line":"        self.delete_volume_target(self.volume_target[\u0027uuid\u0027])"},{"line_number":58,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_target,"},{"line_number":59,"context_line":"                          self.volume_target[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_59eadbd7","line":56,"updated":"2017-08-04 11:19:41.000000000","message":"misplaced docstring, should be right after \"def\"","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # Powering off the Node before deleting a volume target."},{"line_number":54,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power off\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        \"\"\"Delete a volume target.\"\"\""},{"line_number":57,"context_line":"        self.delete_volume_target(self.volume_target[\u0027uuid\u0027])"},{"line_number":58,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_target,"},{"line_number":59,"context_line":"                          self.volume_target[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_3b4567b4","line":56,"in_reply_to":"df3967d1_59eadbd7","updated":"2017-08-07 15:28:58.000000000","message":"Fixed.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_target,"},{"line_number":59,"context_line":"                          self.volume_target[\u0027uuid\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u0027532a06bc-a9b2-44b0-828a-c53279c87cb2\u0027)"},{"line_number":62,"context_line":"    def test_delete_volume_target_error(self):"},{"line_number":63,"context_line":"        # Powering on the Node before deleting a volume target."},{"line_number":64,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_39bf17d2","line":61,"updated":"2017-08-04 11:19:41.000000000","message":"ditto re negative tag","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_volume_target,"},{"line_number":59,"context_line":"                          self.volume_target[\u0027uuid\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u0027532a06bc-a9b2-44b0-828a-c53279c87cb2\u0027)"},{"line_number":62,"context_line":"    def test_delete_volume_target_error(self):"},{"line_number":63,"context_line":"        # Powering on the Node before deleting a volume target."},{"line_number":64,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_db0d3b91","line":61,"in_reply_to":"df3967d1_39bf17d2","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Powering on the Node before deleting a volume target."},{"line_number":64,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":67,"context_line":"                                         \u0027\\\\\\\\\"volume target deletion\\\\\\\\\" \u0027"},{"line_number":68,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_8adfb167","line":66,"updated":"2017-08-04 20:15:03.000000000","message":"I don\u0027t understand why need to use re.escape()\n\nWhy not use a r\u0027\u0027 string?\n\n regex_str \u003d (r\u0027.*The requested action \"volume target_deletion\" \u0027\n              r\u0027can not be performed on node.*\u0027)","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Powering on the Node before deleting a volume target."},{"line_number":64,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":67,"context_line":"                                         \u0027\\\\\\\\\"volume target deletion\\\\\\\\\" \u0027"},{"line_number":68,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_5b214bfb","line":66,"in_reply_to":"df3967d1_8adfb167","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertIn(next_marker, body[\u0027next\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @decorators.idempotent_id(\u00278559cd08-feae-4f1a-a0ad-5bad8ea12b76\u0027)"},{"line_number":102,"context_line":"    def test_update_volume_target_replace(self):"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_19c2135a","line":102,"updated":"2017-08-04 11:19:41.000000000","message":"docstring?","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertIn(next_marker, body[\u0027next\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @decorators.idempotent_id(\u00278559cd08-feae-4f1a-a0ad-5bad8ea12b76\u0027)"},{"line_number":102,"context_line":"    def test_update_volume_target_replace(self):"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_bb8717d8","line":102,"in_reply_to":"df3967d1_19c2135a","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb881b66e59afd724d73a3976e26d79970e6599b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertEqual(new_volume_id, body[\u0027volume_id\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @decorators.idempotent_id(\u0027fd5266d3-4f3c-4dce-9c87-bfdea2b756c7\u0027)"},{"line_number":119,"context_line":"    def test_update_volume_target_replace_error(self):"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_f9b4eff3","line":119,"updated":"2017-08-04 11:19:41.000000000","message":"ditto re docstring and negative tag","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertEqual(new_volume_id, body[\u0027volume_id\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @decorators.idempotent_id(\u0027fd5266d3-4f3c-4dce-9c87-bfdea2b756c7\u0027)"},{"line_number":119,"context_line":"    def test_update_volume_target_replace_error(self):"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_9b6c5337","line":119,"in_reply_to":"df3967d1_f9b4eff3","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4c2fbd32d3013ec9b25fa8e801cd1905b3ba8a2b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        # Powering on the Node before updating a volume target."},{"line_number":128,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":131,"context_line":"                                         \u0027\\\\\\\\\"volume target update\\\\\\\\\" \u0027"},{"line_number":132,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":133,"context_line":"        self.assertRaisesRegex(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":17,"id":"df3967d1_ead75d4a","line":130,"updated":"2017-08-04 20:15:03.000000000","message":"Same as line 66 comment","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"21a4dced36dc03179d20e55b4e861cc98a5ffe02","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        # Powering on the Node before updating a volume target."},{"line_number":128,"context_line":"        self.client.set_node_power_state(self.node[\u0027uuid\u0027], \u0027power on\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        regex_str \u003d \".*%s.*\" % re.escape(\u0027The requested action \u0027"},{"line_number":131,"context_line":"                                         \u0027\\\\\\\\\"volume target update\\\\\\\\\" \u0027"},{"line_number":132,"context_line":"                                         \u0027can not be performed on node\u0027)"},{"line_number":133,"context_line":"        self.assertRaisesRegex(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf3e73b7_7b69af23","line":130,"in_reply_to":"df3967d1_ead75d4a","updated":"2017-08-07 15:28:58.000000000","message":"Done.","commit_id":"7240b5fa9ff4e7766ca7de3bb801df6838bdb896"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeTarget(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for boot from volume.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_3027d415","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":54},"updated":"2017-08-08 16:13:00.000000000","message":"Is this description relevant with tests?","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestVolumeTarget(base.BaseBaremetalTest):"},{"line_number":25,"context_line":"    \"\"\"Basic positive test cases for boot from volume.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    min_microversion \u003d \u00271.32\u0027"},{"line_number":28,"context_line":"    extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_ead14659","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":54},"in_reply_to":"9f436f4f_3027d415","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @decorators.idempotent_id(\u00278559cd08-feae-4f1a-a0ad-5bad8ea12b76\u0027)"},{"line_number":102,"context_line":"    def test_update_volume_target_replace(self):"},{"line_number":103,"context_line":"        \"\"\"Update a volume target.\"\"\""},{"line_number":104,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/volume_id\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_3076b4da","line":103,"updated":"2017-08-08 16:13:00.000000000","message":"by replacing","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @decorators.idempotent_id(\u00278559cd08-feae-4f1a-a0ad-5bad8ea12b76\u0027)"},{"line_number":102,"context_line":"    def test_update_volume_target_replace(self):"},{"line_number":103,"context_line":"        \"\"\"Update a volume target.\"\"\""},{"line_number":104,"context_line":"        new_volume_id \u003d data_utils.rand_name(\u0027volume_id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/volume_id\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_6ac5568e","line":103,"in_reply_to":"9f436f4f_3076b4da","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @decorators.idempotent_id(\u00271c13a4ee-1a49-4739-8c19-77960fbd1af8\u0027)"},{"line_number":141,"context_line":"    def test_update_volume_target_remove(self):"},{"line_number":142,"context_line":"        \"\"\"Update a volume target.\"\"\""},{"line_number":143,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":144,"context_line":"        _, body \u003d self.client.show_volume_target(self.volume_target[\u0027uuid\u0027])"},{"line_number":145,"context_line":"        volume_id \u003d body[\u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_d07c08b7","line":142,"updated":"2017-08-08 16:13:00.000000000","message":"by removal","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @decorators.idempotent_id(\u00271c13a4ee-1a49-4739-8c19-77960fbd1af8\u0027)"},{"line_number":141,"context_line":"    def test_update_volume_target_remove(self):"},{"line_number":142,"context_line":"        \"\"\"Update a volume target.\"\"\""},{"line_number":143,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":144,"context_line":"        _, body \u003d self.client.show_volume_target(self.volume_target[\u0027uuid\u0027])"},{"line_number":145,"context_line":"        volume_id \u003d body[\u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_0abc8a03","line":142,"in_reply_to":"9f436f4f_d07c08b7","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"fca40186717327dc134794e8c478675060127319","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @decorators.idempotent_id(\u00279629715d-57ba-423b-b985-232674cc3a25\u0027)"},{"line_number":171,"context_line":"    def test_update_volume_target_add(self):"},{"line_number":172,"context_line":"        \"\"\"Update a volume target.\"\"\""},{"line_number":173,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/extra/key3\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_9050c034","line":172,"updated":"2017-08-08 16:13:00.000000000","message":"by addition","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"1ff49ee5de3273f5d8432f381cae41b57bbbc508","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @decorators.idempotent_id(\u00279629715d-57ba-423b-b985-232674cc3a25\u0027)"},{"line_number":171,"context_line":"    def test_update_volume_target_add(self):"},{"line_number":172,"context_line":"        \"\"\"Update a volume target.\"\"\""},{"line_number":173,"context_line":"        new_extra \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        patch \u003d [{\u0027path\u0027: \u0027/extra/key3\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_ca3b229a","line":172,"in_reply_to":"9f436f4f_9050c034","updated":"2017-08-09 07:41:02.000000000","message":"Done.","commit_id":"e44fd360840ad783d1a9fe81b18e7dffe3cb173c"}]}
