)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"37916304327759df08bc0977c0a15c6c64d58dc0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"When set to False, generation and validation of a Swift TempURL for image"},{"line_number":16,"context_line":"will be skipped, and the instance_info.image_url field will be set to"},{"line_number":17,"context_line":"`\u003cglance-api-url\u003e/\u003crest-path-to-image\u003e/file` instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I803aa28fcd52e5244c473c90cafb80fb5893c7ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f231b9d_78a67d11","line":18,"updated":"2017-06-18 08:57:06.000000000","message":"Can you please link to this bug?","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bdc2f9bc1983fd53094c14c73bb84ec3cc3c77f8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"When set to False, generation and validation of a Swift TempURL for image"},{"line_number":16,"context_line":"will be skipped, and the instance_info.image_url field will be set to"},{"line_number":17,"context_line":"`\u003cglance-api-url\u003e/\u003crest-path-to-image\u003e/file` instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I803aa28fcd52e5244c473c90cafb80fb5893c7ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f231b9d_43d3c504","line":18,"in_reply_to":"7f231b9d_78a67d11","updated":"2017-06-29 09:47:21.000000000","message":"There\u0027s no bug for it currently as it is just an idea to possibly allow out-of-tree drivers that could work w/o requiring tight glance+swift+ironic integration.","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"37916304327759df08bc0977c0a15c6c64d58dc0","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"    \"\"\"Build instance_info necessary for deploying to a node."},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":"    :param task: a TaskManager object containing the node"},{"line_number":1159,"context_line":"    :param tempurl: whether to use Object Store service tempurls"},{"line_number":1160,"context_line":"                    for glance images"},{"line_number":1161,"context_line":"    :returns: a dictionary containing the properties to be updated"},{"line_number":1162,"context_line":"        in instance_info"},{"line_number":1163,"context_line":"    :raises: exception.ImageRefValidationFailed if image_source is not"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_38ac85eb","line":1160,"range":{"start_line":1159,"start_character":4,"end_line":1160,"end_character":37},"updated":"2017-06-18 08:57:06.000000000","message":"I think its better to add more detail like:\n  Use Object Store service tempurls when set to True\n  otherwise ...","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bdc2f9bc1983fd53094c14c73bb84ec3cc3c77f8","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"    \"\"\"Build instance_info necessary for deploying to a node."},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":"    :param task: a TaskManager object containing the node"},{"line_number":1159,"context_line":"    :param tempurl: whether to use Object Store service tempurls"},{"line_number":1160,"context_line":"                    for glance images"},{"line_number":1161,"context_line":"    :returns: a dictionary containing the properties to be updated"},{"line_number":1162,"context_line":"        in instance_info"},{"line_number":1163,"context_line":"    :raises: exception.ImageRefValidationFailed if image_source is not"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_83cf9d27","line":1160,"range":{"start_line":1159,"start_character":4,"end_line":1160,"end_character":37},"in_reply_to":"7f231b9d_38ac85eb","updated":"2017-06-29 09:47:21.000000000","message":"Done","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"37916304327759df08bc0977c0a15c6c64d58dc0","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"            image_url \u003d glance.swift_temp_url(image_info)"},{"line_number":1195,"context_line":"            validate_image_url(image_url, secret\u003dTrue)"},{"line_number":1196,"context_line":"        else:"},{"line_number":1197,"context_line":"            # NOTE(pas-ha) we\u0027ve already made a successfull get on image,"},{"line_number":1198,"context_line":"            # so we are shure it is accessible."},{"line_number":1199,"context_line":"            # Now resolve glance API from keystone catalog and prepend it"},{"line_number":1200,"context_line":"            # to the \u0027file\u0027 attribute of the image returned by glance API v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_18b7893c","line":1197,"range":{"start_line":1197,"start_character":48,"end_line":1197,"end_character":59},"updated":"2017-06-18 08:57:06.000000000","message":"nit: s/successfull/successful/","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bdc2f9bc1983fd53094c14c73bb84ec3cc3c77f8","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"            image_url \u003d glance.swift_temp_url(image_info)"},{"line_number":1195,"context_line":"            validate_image_url(image_url, secret\u003dTrue)"},{"line_number":1196,"context_line":"        else:"},{"line_number":1197,"context_line":"            # NOTE(pas-ha) we\u0027ve already made a successfull get on image,"},{"line_number":1198,"context_line":"            # so we are shure it is accessible."},{"line_number":1199,"context_line":"            # Now resolve glance API from keystone catalog and prepend it"},{"line_number":1200,"context_line":"            # to the \u0027file\u0027 attribute of the image returned by glance API v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_23d8c9ec","line":1197,"range":{"start_line":1197,"start_character":48,"end_line":1197,"end_character":59},"in_reply_to":"7f231b9d_18b7893c","updated":"2017-06-29 09:47:21.000000000","message":"Done","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"37916304327759df08bc0977c0a15c6c64d58dc0","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"            validate_image_url(image_url, secret\u003dTrue)"},{"line_number":1196,"context_line":"        else:"},{"line_number":1197,"context_line":"            # NOTE(pas-ha) we\u0027ve already made a successfull get on image,"},{"line_number":1198,"context_line":"            # so we are shure it is accessible."},{"line_number":1199,"context_line":"            # Now resolve glance API from keystone catalog and prepend it"},{"line_number":1200,"context_line":"            # to the \u0027file\u0027 attribute of the image returned by glance API v2"},{"line_number":1201,"context_line":"            session \u003d keystone.get_session(\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_f8b16d45","line":1198,"range":{"start_line":1198,"start_character":24,"end_line":1198,"end_character":29},"updated":"2017-06-18 08:57:06.000000000","message":"s/shure/sure/","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bdc2f9bc1983fd53094c14c73bb84ec3cc3c77f8","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"            validate_image_url(image_url, secret\u003dTrue)"},{"line_number":1196,"context_line":"        else:"},{"line_number":1197,"context_line":"            # NOTE(pas-ha) we\u0027ve already made a successfull get on image,"},{"line_number":1198,"context_line":"            # so we are shure it is accessible."},{"line_number":1199,"context_line":"            # Now resolve glance API from keystone catalog and prepend it"},{"line_number":1200,"context_line":"            # to the \u0027file\u0027 attribute of the image returned by glance API v2"},{"line_number":1201,"context_line":"            session \u003d keystone.get_session(\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_03e38da5","line":1198,"range":{"start_line":1198,"start_character":24,"end_line":1198,"end_character":29},"in_reply_to":"7f231b9d_f8b16d45","updated":"2017-06-29 09:47:21.000000000","message":"Done","commit_id":"ff05d665501e04419b203f6956396c308b431bb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1ac330eab495ce2d36405206d3b9c234b0c6502b","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"            # so we are sure it is accessible."},{"line_number":1206,"context_line":"            # Now resolve glance API from keystone catalog and prepend it"},{"line_number":1207,"context_line":"            # to the \u0027file\u0027 attribute of the image returned by glance API v2"},{"line_number":1208,"context_line":"            adapter \u003d keystone.get_adapter("},{"line_number":1209,"context_line":"                \u0027glance\u0027,"},{"line_number":1210,"context_line":"                session\u003dkeystone.get_session(\u0027glance\u0027),"},{"line_number":1211,"context_line":"                auth\u003dkeystone.get_auth(\u0027glance\u0027))"},{"line_number":1212,"context_line":"            image_url \u003d adapter.get_endpoint() + image_info[\u0027file\u0027]"},{"line_number":1213,"context_line":"        instance_info[\u0027image_url\u0027] \u003d image_url"},{"line_number":1214,"context_line":"        instance_info[\u0027image_checksum\u0027] \u003d image_info[\u0027checksum\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_da579226","line":1211,"range":{"start_line":1208,"start_character":22,"end_line":1211,"end_character":49},"updated":"2017-09-01 07:06:07.000000000","message":"can be replaced with \"glance.client.http_client\" after https://review.openstack.org/#/c/467728/ is merged","commit_id":"7cfaa7fbc1a517ced2d08795031ff5a44efa59c4"}]}