)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bfe28a3568b683f3a7a41de8ad78725172c677af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-21 07:21:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a condition for ILO for pxe hardware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a condition to not to use deploy iso in pxe hardware type"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_d6f5de84","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":47},"updated":"2017-06-23 09:08:04.000000000","message":"s/ \"ILO for pxe hardware type\" / \"\u0027ilo\u0027 hardware type\"","commit_id":"18811515cd4b2cce31fdd0722c70d60e4f42e34d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c636b87e7a58f826c97089d074d465a6e7d05fd5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-21 07:21:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a condition for ILO for pxe hardware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a condition to not to use deploy iso in pxe hardware type"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f1d235d_b8c30689","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":47},"in_reply_to":"5f201791_d6f5de84","updated":"2017-07-06 09:53:36.000000000","message":"Done","commit_id":"18811515cd4b2cce31fdd0722c70d60e4f42e34d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bfe28a3568b683f3a7a41de8ad78725172c677af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a condition for ILO for pxe hardware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a condition to not to use deploy iso in pxe hardware type"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I97e20f4723967ee14de0d41d6b99149f12f4d2f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_360f728a","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":63},"updated":"2017-06-23 09:08:04.000000000","message":"s/ \"in pxe hardware type\" / \"when boot interface \u0027ilo-virtual-media\u0027 is not enabled.\"","commit_id":"18811515cd4b2cce31fdd0722c70d60e4f42e34d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c636b87e7a58f826c97089d074d465a6e7d05fd5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a condition for ILO for pxe hardware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a condition to not to use deploy iso in pxe hardware type"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I97e20f4723967ee14de0d41d6b99149f12f4d2f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f1d235d_b871c678","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":63},"in_reply_to":"5f201791_360f728a","updated":"2017-07-06 09:53:36.000000000","message":"Done","commit_id":"18811515cd4b2cce31fdd0722c70d60e4f42e34d"}],"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7797a9f3aa1b67d5737548d4af6152c58b5c2e94","unresolved":false,"context_lines":[{"line_number":1711,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1712,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":1713,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1714,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" \u0026\u0026 $IRONIC_ENABLED_BOOT_INTERFACES !\u003d \"ilo-pxe\" ]]; then"},{"line_number":1715,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1716,"context_line":"                fi"},{"line_number":1717,"context_line":"            elif is_deployed_by_drac; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f231b9d_6d2b2b30","line":1714,"updated":"2017-06-20 08:05:26.000000000","message":"I think the check has to be a bit smarter. You have to check if IRONIC_ENABLED_BOOT_INTERFACES contains ilo-pxe but does not contain ilo-virtual-media (as it has priority over ilo-pxe).","commit_id":"70daa2792e936b2fb039b73c31506f34f1071c61"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"77ae01b25a0d332497c7a1450940262a6ad44959","unresolved":false,"context_lines":[{"line_number":1711,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1712,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":1713,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1714,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" \u0026\u0026 $IRONIC_ENABLED_BOOT_INTERFACES !\u003d \"ilo-pxe\" ]]; then"},{"line_number":1715,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1716,"context_line":"                fi"},{"line_number":1717,"context_line":"            elif is_deployed_by_drac; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f231b9d_e403cdbd","line":1714,"in_reply_to":"7f231b9d_6d2b2b30","updated":"2017-06-20 12:01:24.000000000","message":"Done","commit_id":"70daa2792e936b2fb039b73c31506f34f1071c61"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"eee11ae18d73e6ec1429028db1c960fd7a794718","unresolved":false,"context_lines":[{"line_number":1713,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1714,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" \u0026\u0026\\"},{"line_number":1715,"context_line":"                    $IRONIC_ENABLED_BOOT_INTERFACES \u003d\u003d *\"ilo-virtual-media\"* \u0026\u0026\\"},{"line_number":1716,"context_line":"                    $IRONIC_ENABLED_BOOT_INTERFACES !\u003d *\"ilo-pxe\"* ]]; then"},{"line_number":1717,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1718,"context_line":"                fi"},{"line_number":1719,"context_line":"            elif is_deployed_by_drac; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f201791_78d087ca","line":1716,"range":{"start_line":1716,"start_character":20,"end_line":1716,"end_character":67},"updated":"2017-06-21 04:51:59.000000000","message":"I don\u0027t think this is required. One can have :\nIRONIC_ENABLED_BOOT_INTERFACES\u003d\u0027ilo-virtual-media, ilo-pxe\u0027 \n\nIn above case, we should setting the \u0027ilo_deploy_iso\u0027 as \u0027ilo-virtual-media\u0027 would be used as a default boot interface if none is specified during node-creation for \u0027ilo\u0027 hardware type.","commit_id":"697a1b522c2c5384ed34fcbf0886275032f8524d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"cbad157cba76dfbdb6cd6a0e088f4ec55942aeb7","unresolved":false,"context_lines":[{"line_number":1713,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1714,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" \u0026\u0026\\"},{"line_number":1715,"context_line":"                    $IRONIC_ENABLED_BOOT_INTERFACES \u003d\u003d *\"ilo-virtual-media\"* \u0026\u0026\\"},{"line_number":1716,"context_line":"                    $IRONIC_ENABLED_BOOT_INTERFACES !\u003d *\"ilo-pxe\"* ]]; then"},{"line_number":1717,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1718,"context_line":"                fi"},{"line_number":1719,"context_line":"            elif is_deployed_by_drac; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f201791_c2c0c553","line":1716,"range":{"start_line":1716,"start_character":20,"end_line":1716,"end_character":67},"in_reply_to":"5f201791_78d087ca","updated":"2017-06-21 07:19:12.000000000","message":"Done","commit_id":"697a1b522c2c5384ed34fcbf0886275032f8524d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"caa422e132f5b16141052b77d4f5cc29abcfbc22","unresolved":false,"context_lines":[{"line_number":1711,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1712,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":1713,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1714,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" \u0026\u0026\\"},{"line_number":1715,"context_line":"                    $IRONIC_ENABLED_BOOT_INTERFACES \u003d\u003d *\"ilo-virtual-media\"* ]]; then"},{"line_number":1716,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1717,"context_line":"                fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f1a1f67_8ffe5fac","line":1714,"updated":"2017-07-21 08:00:01.000000000","message":"nit: missing space before \\","commit_id":"70d83d996b237e2b87e551f957129e73dd3b1538"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a012a0cfb9fa058da66c60382f2a7e5e49f16295","unresolved":false,"context_lines":[{"line_number":1711,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":1712,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":1713,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":1714,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER !\u003d \"pxe_ilo\" \u0026\u0026\\"},{"line_number":1715,"context_line":"                    $IRONIC_ENABLED_BOOT_INTERFACES \u003d\u003d *\"ilo-virtual-media\"* ]]; then"},{"line_number":1716,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":1717,"context_line":"                fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff346bd7_16e4c3ab","line":1714,"in_reply_to":"1f1a1f67_8ffe5fac","updated":"2017-07-24 03:48:18.000000000","message":"Done","commit_id":"70d83d996b237e2b87e551f957129e73dd3b1538"}]}