)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"625c6f3612ea4d8638a856ff5fd8993a321cc91e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Tantsur \u003cdivius.inside@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-22 17:17:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fetch Glance endpoint from Keystone if it\u0027s not provided in the configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is needed to fix the CI broken by glance switching to running under wsgi,"},{"line_number":10,"context_line":"and thus breaking our assumption that glance is accessible by host:port only."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f201791_70a3c99f","line":7,"updated":"2017-06-22 15:28:18.000000000","message":"nit: line wrapping :)","commit_id":"fd790163d11cff6f4a6a9e2435f5c3742c1356bb"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"a153b8a7e224cc4ca963d1c76d4b30b070371122","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"#glance_cafile \u003d \u003cNone\u003e"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"# DEPRECATED: Default glance hostname or IP address. The"},{"line_number":1562,"context_line":"# servicecatalog is used when not defined. (string value)"},{"line_number":1563,"context_line":"# This option is deprecated for removal."},{"line_number":1564,"context_line":"# Its value may be silently ignored in the future."},{"line_number":1565,"context_line":"#glance_host \u003d \u003cNone\u003e"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5f201791_742293a6","line":1562,"range":{"start_line":1562,"start_character":2,"end_line":1562,"end_character":16},"updated":"2017-06-22 20:34:58.000000000","message":"Oops!","commit_id":"b9a270115409df24015bea393453df07152aadd9"}],"ironic/common/glance_service/base_image_service.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4c139f7821121978c95216d97935ce13f0b94b6b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            try:"},{"line_number":110,"context_line":"                return getattr(self.client.images, method)(*args, **kwargs)"},{"line_number":111,"context_line":"            except retry_excs as e:"},{"line_number":112,"context_line":"                host \u003d self.glance_host"},{"line_number":113,"context_line":"                port \u003d self.glance_port"},{"line_number":114,"context_line":"                error_msg \u003d (\"Error contacting glance server \""},{"line_number":115,"context_line":"                             \"\u0027%(host)s:%(port)s\u0027 for \u0027%(method)s\u0027, attempt\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_bc50200c","line":112,"updated":"2017-06-22 13:31:45.000000000","message":"These two lines won\u0027t work, because self.glance_host \u0026 self.glance_port don\u0027t exist any more :-(","commit_id":"67d4aed328292702e80c9434d6c2b42b95726a74"}],"ironic/common/glance_service/service_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7719f54eae5fb7668129eb9855fe143041265178","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    as the server: CONF.glance.glance_host:CONF.glance.glance_port."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    :returns: iterator that cycles (indefinitely) over shuffled glance API"},{"line_number":116,"context_line":"              servers. The iterator returns tuples of (host, port, use_ssl)."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    api_servers \u003d []"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_098eb4cf","line":116,"updated":"2017-06-22 13:27:11.000000000","message":"now it returns url of the server?","commit_id":"67d4aed328292702e80c9434d6c2b42b95726a74"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"47380c7f1a22c3d21222ec8c2157da961290e98c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    as the server: CONF.glance.glance_host:CONF.glance.glance_port."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    :returns: iterator that cycles (indefinitely) over shuffled glance API"},{"line_number":116,"context_line":"              servers. The iterator returns tuples of (host, port, use_ssl)."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    api_servers \u003d []"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_9c09e42d","line":116,"in_reply_to":"5f201791_098eb4cf","updated":"2017-06-22 13:31:21.000000000","message":"good catch!","commit_id":"67d4aed328292702e80c9434d6c2b42b95726a74"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7719f54eae5fb7668129eb9855fe143041265178","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                use_ssl \u003d (url.scheme \u003d\u003d \u0027https\u0027)"},{"line_number":172,"context_line":"                endpoint \u003d \u0027%s://%s:%s\u0027 % (url.scheme, glance_host,"},{"line_number":173,"context_line":"                                           glance_port)"},{"line_number":174,"context_line":"                return (image_id, glance_host, glance_port, use_ssl)"},{"line_number":175,"context_line":"        except ValueError:"},{"line_number":176,"context_line":"            raise exception.InvalidImageRef(image_href\u003dimage_href)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_c94f9c90","line":174,"updated":"2017-06-22 13:27:11.000000000","message":"s/glance_host, glance_port/endpoint/","commit_id":"67d4aed328292702e80c9434d6c2b42b95726a74"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c12ac800c8d654ce737186d24e9d159c35114ae","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if not CONF.glance.glance_api_servers and not CONF.glance.glance_host:"},{"line_number":111,"context_line":"        session \u003d keystone.get_session(\u0027service_catalog\u0027)"},{"line_number":112,"context_line":"        api_servers \u003d [keystone.get_service_url(session, service_type\u003d\u0027image\u0027)]"},{"line_number":113,"context_line":"    else:"},{"line_number":114,"context_line":"        configured_servers \u003d (CONF.glance.glance_api_servers or"},{"line_number":115,"context_line":"                              [\u0027%s:%s\u0027 % (CONF.glance.glance_host,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_ce5439cd","line":112,"updated":"2017-06-22 16:46:00.000000000","message":"I think it defaults to endpoint_type\u003d\u0027internal\u0027, and I think we want endpoint_type\u003d\u0027public\u0027 cuz not sure if devstack has internal or not.","commit_id":"fd790163d11cff6f4a6a9e2435f5c3742c1356bb"}],"ironic/conf/glance.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"625c6f3612ea4d8638a856ff5fd8993a321cc91e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                      \u0027will determine how many containers are created.\u0027)),"},{"line_number":106,"context_line":"    cfg.StrOpt(\u0027glance_host\u0027,"},{"line_number":107,"context_line":"               help\u003d_(\u0027Default glance hostname or IP address.\u0027),"},{"line_number":108,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":109,"context_line":"    cfg.PortOpt(\u0027glance_port\u0027,"},{"line_number":110,"context_line":"                default\u003d9292,"},{"line_number":111,"context_line":"                help\u003d_(\u0027Default glance port.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_704bc92a","line":108,"updated":"2017-06-22 15:28:18.000000000","message":"nit: we likely ought to update the help text to indicate that if the service catalog is used when not defined.","commit_id":"fd790163d11cff6f4a6a9e2435f5c3742c1356bb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"679be4696cae5bd62528f18f12341d89d7513a74","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                      \u0027will determine how many containers are created.\u0027)),"},{"line_number":106,"context_line":"    cfg.StrOpt(\u0027glance_host\u0027,"},{"line_number":107,"context_line":"               help\u003d_(\u0027Default glance hostname or IP address. The keystone \u0027"},{"line_number":108,"context_line":"                      \u0027catalog is used when not defined.\u0027),"},{"line_number":109,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":110,"context_line":"    cfg.PortOpt(\u0027glance_port\u0027,"},{"line_number":111,"context_line":"                default\u003d9292,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_f1647ae7","line":108,"updated":"2017-06-22 18:55:32.000000000","message":"it is actually the \u0027service catalog\u0027 but anyway.","commit_id":"85a52e72a97a48176b3b6e76f0868c02f3446348"}],"ironic/tests/unit/common/test_glance_service.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"679be4696cae5bd62528f18f12341d89d7513a74","unresolved":false,"context_lines":[{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        mock_session.assert_called_once_with(\u0027service_catalog\u0027)"},{"line_number":870,"context_line":"        mock_service_url.assert_called_once_with(mock_session.return_value,"},{"line_number":871,"context_line":"                                                 service_type\u003d\u0027image\u0027)"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"    def test__get_api_servers_with_host_port(self):"},{"line_number":874,"context_line":"        CONF.set_override(\u0027glance_host\u0027, \u0027example.com\u0027, \u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_ba35b7dc","line":871,"updated":"2017-06-22 18:55:32.000000000","message":"failing cuz this needs to also include \"endpoint_type\u003d\u0027public\u0027\".","commit_id":"85a52e72a97a48176b3b6e76f0868c02f3446348"}],"releasenotes/notes/glance-keystone-dd30b884f07f83fb.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"60a608480e0d2c5f586ebcf3db41be1f706945d1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option ``[glance]glance_host`` is now empty by default."},{"line_number":5,"context_line":"    If neither it nor ``[glance]glance_api_servers`` are provided, ironic will"},{"line_number":6,"context_line":"    not try fetching the Image service endpoint from the service catalog."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The configuration options ``[glance]glance_host``, ``[glance]glance_port``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f201791_12c238ea","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"updated":"2017-06-23 14:41:16.000000000","message":"s/not//","commit_id":"9df53d322cdce47fad3cff65a7d2ad8c4906d43a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"717aff0d2e961b1857759a9295b0f70cc6f27db9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option ``[glance]glance_host`` is now empty by default."},{"line_number":5,"context_line":"    If neither it nor ``[glance]glance_api_servers`` are provided, ironic will"},{"line_number":6,"context_line":"    not try fetching the Image service endpoint from the service catalog."},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The configuration options ``[glance]glance_host``, ``[glance]glance_port``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f201791_123598f7","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"in_reply_to":"5f201791_12c238ea","updated":"2017-06-23 14:42:10.000000000","message":"One day I will stop misspelling \"now\" as \"not\". But this day is not today.","commit_id":"9df53d322cdce47fad3cff65a7d2ad8c4906d43a"}]}
