)]}'
{"ironic/drivers/modules/network/common.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a7753b7b31061f70cd5938a59ab4977f93f33e15","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        raise exception.NetworkError(msg)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"def save_vif_to_port_like_obj(port_like_obj, vif_id):"},{"line_number":214,"context_line":"    \"\"\"Save the ID of a VIF to a port or portgroup."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    :param port_like_obj: port-like object to check."},{"line_number":217,"context_line":"    :param vif_id: VIF ID to save."},{"line_number":218,"context_line":"    \"\"\""},{"line_number":219,"context_line":"    int_info \u003d port_like_obj.internal_info"},{"line_number":220,"context_line":"    int_info[TENANT_VIF_KEY] \u003d vif_id"},{"line_number":221,"context_line":"    port_like_obj.internal_info \u003d int_info"},{"line_number":222,"context_line":"    port_like_obj.save()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"def clear_vif_from_port_like_obj(port_like_obj):"},{"line_number":226,"context_line":"    \"\"\"Clear the VIF ID field from a port or portgroup."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    :param port_like_obj: port-like object to check."},{"line_number":229,"context_line":"    \"\"\""},{"line_number":230,"context_line":"    int_info \u003d port_like_obj.internal_info"},{"line_number":231,"context_line":"    extra \u003d port_like_obj.extra"},{"line_number":232,"context_line":"    int_info.pop(TENANT_VIF_KEY, None)"},{"line_number":233,"context_line":"    extra.pop(\u0027vif_port_id\u0027, None)"},{"line_number":234,"context_line":"    port_like_obj.extra \u003d extra"},{"line_number":235,"context_line":"    port_like_obj.internal_info \u003d int_info"},{"line_number":236,"context_line":"    port_like_obj.save()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def get_port_like_obj_by_vif_id(task, vif_id):"},{"line_number":240,"context_line":"    \"\"\"Lookup a port or portgroup by its attached VIF ID."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    :param task: A TaskManager instance."},{"line_number":243,"context_line":"    :param vif_id: ID of the attached VIF."},{"line_number":244,"context_line":"    :returns: A Port or Portgroup object to which the VIF is attached."},{"line_number":245,"context_line":"    :raises: VifNotAttached if the VIF is not attached."},{"line_number":246,"context_line":"    \"\"\""},{"line_number":247,"context_line":"    for port_like_obj in task.portgroups + task.ports:"},{"line_number":248,"context_line":"        # FIXME(sambetts) Remove this when we no longer support a nova"},{"line_number":249,"context_line":"        # driver that uses port.extra"},{"line_number":250,"context_line":"        vif_port_id \u003d port_like_obj.internal_info.get("},{"line_number":251,"context_line":"            TENANT_VIF_KEY, port_like_obj.extra.get(\"vif_port_id\"))"},{"line_number":252,"context_line":"        if vif_port_id \u003d\u003d vif_id:"},{"line_number":253,"context_line":"            return port_like_obj"},{"line_number":254,"context_line":"    raise exception.VifNotAttached(vif\u003dvif_id, node\u003dtask.node.uuid)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class VIFPortIDMixin(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_7d310b5a","line":254,"range":{"start_line":213,"start_character":0,"end_line":254,"end_character":67},"updated":"2017-06-26 16:57:31.000000000","message":"I\u0027m not a massive fan of module level functions like this, it makes functionality hard to override if you need too.","commit_id":"4c1a7fc328f68d417465ee88346b377af7336844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a7753b7b31061f70cd5938a59ab4977f93f33e15","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        # Here we should only detach VIF and shouldn\u0027t duplicate/follow"},{"line_number":501,"context_line":"        # attach rules, just walk over all objects and detach VIF."},{"line_number":502,"context_line":"        port_like_obj \u003d get_port_like_obj_by_vif_id(task, vif_id)"},{"line_number":503,"context_line":"        clear_vif_from_port_like_obj(port_like_obj)"},{"line_number":504,"context_line":"        # NOTE(vsaienko) allow to unplug VIFs from ACTIVE instance."},{"line_number":505,"context_line":"        if task.node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":506,"context_line":"            neutron.unbind_neutron_port(vif_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_3de953b6","line":506,"range":{"start_line":503,"start_character":0,"end_line":506,"end_character":47},"updated":"2017-06-26 16:57:31.000000000","message":"These two actions should probably be flipped, if there is an error unbinding the neutron port, then we don\u0027t want the vif removed from the port.","commit_id":"4c1a7fc328f68d417465ee88346b377af7336844"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8be5f1a072893e93d666d765372df3807b36a553","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            vif_port_id \u003d self._get_vif_id_by_port_like_obj(port_like_obj)"},{"line_number":258,"context_line":"            if vif_port_id \u003d\u003d vif_id:"},{"line_number":259,"context_line":"                return port_like_obj"},{"line_number":260,"context_line":"        raise exception.VifNotAttached(vif\u003dvif_id, node\u003dtask.node.uuid)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    @staticmethod"},{"line_number":263,"context_line":"    def _get_vif_id_by_port_like_obj(port_like_obj):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_e9637419","line":260,"range":{"start_line":260,"start_character":24,"end_line":260,"end_character":38},"updated":"2017-07-14 02:42:31.000000000","message":"i don\u0027t think we should raise exception here. see comments @567","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33d66a0b7bd2532699f727aba94bec185661a54a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            vif_port_id \u003d self._get_vif_id_by_port_like_obj(port_like_obj)"},{"line_number":258,"context_line":"            if vif_port_id \u003d\u003d vif_id:"},{"line_number":259,"context_line":"                return port_like_obj"},{"line_number":260,"context_line":"        raise exception.VifNotAttached(vif\u003dvif_id, node\u003dtask.node.uuid)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    @staticmethod"},{"line_number":263,"context_line":"    def _get_vif_id_by_port_like_obj(port_like_obj):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_88c41042","line":260,"range":{"start_line":260,"start_character":24,"end_line":260,"end_character":38},"in_reply_to":"1f1a1f67_e9637419","updated":"2017-07-21 12:34:43.000000000","message":"This is what the previous code did.","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8be5f1a072893e93d666d765372df3807b36a553","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            to database."},{"line_number":421,"context_line":"        :raises: FailedToUpdateDHCPOptOnPort, Conflict"},{"line_number":422,"context_line":"        \"\"\""},{"line_number":423,"context_line":"        self._validate_port_change(task, port_obj)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def portgroup_changed(self, task, portgroup_obj):"},{"line_number":426,"context_line":"        \"\"\"Handle any actions required when a portgroup changes"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_8912c008","line":423,"range":{"start_line":423,"start_character":13,"end_line":423,"end_character":34},"updated":"2017-07-14 02:42:31.000000000","message":"it\u0027s not conventional to call superclass interfaces marked as internal.\nsince we are building mixin inheritance tree, i\u0027d suggest change _validate_port_change in base class to port_changed, so we don\u0027t have to override if no extra work will do.","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33d66a0b7bd2532699f727aba94bec185661a54a","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            to database."},{"line_number":421,"context_line":"        :raises: FailedToUpdateDHCPOptOnPort, Conflict"},{"line_number":422,"context_line":"        \"\"\""},{"line_number":423,"context_line":"        self._validate_port_change(task, port_obj)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def portgroup_changed(self, task, portgroup_obj):"},{"line_number":426,"context_line":"        \"\"\"Handle any actions required when a portgroup changes"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_08e6c0e9","line":423,"range":{"start_line":423,"start_character":13,"end_line":423,"end_character":34},"in_reply_to":"1f1a1f67_8912c008","updated":"2017-07-21 12:34:43.000000000","message":"Done","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8be5f1a072893e93d666d765372df3807b36a553","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            it is saved to database."},{"line_number":431,"context_line":"        :raises: FailedToUpdateDHCPOptOnPort, Conflict"},{"line_number":432,"context_line":"        \"\"\""},{"line_number":433,"context_line":"        self._validate_portgroup_change(task, portgroup_obj)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def vif_attach(self, task, vif_info):"},{"line_number":436,"context_line":"        \"\"\"Attach a virtual network interface to a node"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_e92ed441","line":433,"range":{"start_line":433,"start_character":13,"end_line":433,"end_character":39},"updated":"2017-07-14 02:42:31.000000000","message":"ditto\nwe can change it to portgroup_changed in base class.","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33d66a0b7bd2532699f727aba94bec185661a54a","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            it is saved to database."},{"line_number":431,"context_line":"        :raises: FailedToUpdateDHCPOptOnPort, Conflict"},{"line_number":432,"context_line":"        \"\"\""},{"line_number":433,"context_line":"        self._validate_portgroup_change(task, portgroup_obj)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def vif_attach(self, task, vif_info):"},{"line_number":436,"context_line":"        \"\"\"Attach a virtual network interface to a node"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_e8ea64aa","line":433,"range":{"start_line":433,"start_character":13,"end_line":433,"end_character":39},"in_reply_to":"1f1a1f67_e92ed441","updated":"2017-07-21 12:34:43.000000000","message":"Done","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8be5f1a072893e93d666d765372df3807b36a553","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self._clear_vif_from_port_like_obj(port_like_obj)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"class NeutronVIFPortIDMixin(BaseVIFPortIDMixin):"},{"line_number":467,"context_line":"    \"\"\"VIF port ID mixin class for neutron network interfaces."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    Mixin class that provides VIF-related network interface methods for neutron"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_89b520d0","line":466,"range":{"start_line":466,"start_character":6,"end_line":466,"end_character":27},"updated":"2017-07-14 02:42:31.000000000","message":"ditto for this class","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33d66a0b7bd2532699f727aba94bec185661a54a","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self._clear_vif_from_port_like_obj(port_like_obj)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"class NeutronVIFPortIDMixin(BaseVIFPortIDMixin):"},{"line_number":467,"context_line":"    \"\"\"VIF port ID mixin class for neutron network interfaces."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    Mixin class that provides VIF-related network interface methods for neutron"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_c8cfa855","line":466,"range":{"start_line":466,"start_character":6,"end_line":466,"end_character":27},"in_reply_to":"1f1a1f67_89b520d0","updated":"2017-07-21 12:34:43.000000000","message":"Done","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8be5f1a072893e93d666d765372df3807b36a553","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        # NOTE(vsaienko) We picking object to attach on vif-attach side."},{"line_number":565,"context_line":"        # Here we should only detach VIF and shouldn\u0027t duplicate/follow"},{"line_number":566,"context_line":"        # attach rules, just walk over all objects and detach VIF."},{"line_number":567,"context_line":"        port_like_obj \u003d self._get_port_like_obj_by_vif_id(task, vif_id)"},{"line_number":568,"context_line":"        self._clear_vif_from_port_like_obj(port_like_obj)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        # NOTE(vsaienko) allow to unplug VIFs from ACTIVE instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_e94c949f","line":567,"range":{"start_line":567,"start_character":29,"end_line":567,"end_character":57},"updated":"2017-07-14 02:42:31.000000000","message":"then we can raise VifNotAttached if port_like_obj is None after this call.","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"}],"ironic/tests/unit/drivers/modules/network/test_common.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b55fc8aa16888329cd3b08e2b41a5a42537093c2","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        self.assertEqual({}, pg.extra)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test__clear_vif_from_port_like_obj_in_extra_port(self):"},{"line_number":313,"context_line":"        self.interface._clear_vif_from_port_like_obj(self.port)"},{"line_number":314,"context_line":"        self.port.refresh()"},{"line_number":315,"context_line":"        self.assertFalse(\u0027vif_port_id\u0027 in self.port.extra)"},{"line_number":316,"context_line":"        self.assertFalse(common.TENANT_VIF_KEY in self.port.internal_info)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_10601001","line":313,"range":{"start_line":313,"start_character":23,"end_line":313,"end_character":52},"updated":"2017-07-14 03:18:48.000000000","message":"the case is dependent to previous cases, which is not a good idea, can you create test port for each case? or explicitly preset required fields.\nditto for the rest cases related.","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33d66a0b7bd2532699f727aba94bec185661a54a","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        self.assertEqual({}, pg.extra)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test__clear_vif_from_port_like_obj_in_extra_port(self):"},{"line_number":313,"context_line":"        self.interface._clear_vif_from_port_like_obj(self.port)"},{"line_number":314,"context_line":"        self.port.refresh()"},{"line_number":315,"context_line":"        self.assertFalse(\u0027vif_port_id\u0027 in self.port.extra)"},{"line_number":316,"context_line":"        self.assertFalse(common.TENANT_VIF_KEY in self.port.internal_info)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_88f2d099","line":313,"range":{"start_line":313,"start_character":23,"end_line":313,"end_character":52},"in_reply_to":"1f1a1f67_10601001","updated":"2017-07-21 12:34:43.000000000","message":"There should be no dependency here - a new port will be created for each test case in setUp().","commit_id":"755581e6496d8361cdc81ff0be3f2eafb9bdaaf1"}]}
