)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f7a3b31b229bec5c3d30c3b42cb834ee34b9326","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Secure boot support for pxe_irmc driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements secure boot support for pxe_irmc driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie82ff07421d23b5c0d26e2d2fbde33fc9f8e3c42"},{"line_number":12,"context_line":"Partial-Bug: #1694649"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f1d235d_92c9545a","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":61},"updated":"2017-07-06 04:49:09.000000000","message":"We do not add any more features in classic drivers. May be you can mention this as :-\n\u0027This patch implements secure boot support for irmc-pxe boot interface.\u0027","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f7a3b31b229bec5c3d30c3b42cb834ee34b9326","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch implements secure boot support for pxe_irmc driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie82ff07421d23b5c0d26e2d2fbde33fc9f8e3c42"},{"line_number":12,"context_line":"Partial-Bug: #1694649"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f1d235d_12e304db","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":21},"updated":"2017-07-06 04:49:09.000000000","message":"Please get this RFE approved from Dmitry.","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch implements secure boot support for pxe_irmc driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie82ff07421d23b5c0d26e2d2fbde33fc9f8e3c42"},{"line_number":12,"context_line":"Partial-Bug: #1694649"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f1d235d_53894572","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":21},"in_reply_to":"3f1d235d_12e304db","updated":"2017-07-07 10:36:39.000000000","message":"Yes, It is approved by Dmitry","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"}],"doc/source/admin/drivers/irmc.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"074fa2f9313d884cde852ec16bf210e10668e299","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  - ``properties/capabilities`` property to be ``boot_mode:uefi`` if"},{"line_number":57,"context_line":"    UEFI boot is required."},{"line_number":58,"context_line":"  - ``properties/capabilities`` property to be ``secure_boot:true`` if"},{"line_number":59,"context_line":"    UEFI Secure Boot is required."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* All of nodes are configured by setting the following configuration"},{"line_number":62,"context_line":"  options in ``[irmc]`` section of ``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"df3967d1_f062073e","line":59,"updated":"2017-08-02 16:35:39.000000000","message":"I think it\u0027s worth mentioning that secure_boot implies UEFI. It should be obvious, but just in case..","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"232b2dc2e22f4a417b6f56576eaf53f07a2cd940","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  - ``properties/capabilities`` property to be ``boot_mode:uefi`` if"},{"line_number":57,"context_line":"    UEFI boot is required."},{"line_number":58,"context_line":"  - ``properties/capabilities`` property to be ``secure_boot:true`` if"},{"line_number":59,"context_line":"    UEFI Secure Boot is required."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* All of nodes are configured by setting the following configuration"},{"line_number":62,"context_line":"  options in ``[irmc]`` section of ``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"df3967d1_d985ded0","line":59,"in_reply_to":"df3967d1_f062073e","updated":"2017-08-03 03:02:33.000000000","message":"Done","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f7a3b31b229bec5c3d30c3b42cb834ee34b9326","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        - If the boot_option requested for this deploy is \u0027local\u0027 or image"},{"line_number":705,"context_line":"          is a whole disk image, then it sets the node to boot from disk."},{"line_number":706,"context_line":"        - Otherwise it finds/creates the boot ISO to boot the instance"},{"line_number":707,"context_line":"          image, attaches the boot ISO to the bare metal and then sets"},{"line_number":708,"context_line":"          the node to boot from CDROM."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        :param task: a task from TaskManager."},{"line_number":711,"context_line":"        :returns: None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_52edfcb4","line":708,"range":{"start_line":706,"start_character":8,"end_line":708,"end_character":38},"updated":"2017-07-06 04:49:09.000000000","message":"This would not be applicable to PXE based boot interface.","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        - If the boot_option requested for this deploy is \u0027local\u0027 or image"},{"line_number":705,"context_line":"          is a whole disk image, then it sets the node to boot from disk."},{"line_number":706,"context_line":"        - Otherwise it finds/creates the boot ISO to boot the instance"},{"line_number":707,"context_line":"          image, attaches the boot ISO to the bare metal and then sets"},{"line_number":708,"context_line":"          the node to boot from CDROM."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        :param task: a task from TaskManager."},{"line_number":711,"context_line":"        :returns: None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_58304456","line":708,"range":{"start_line":706,"start_character":8,"end_line":708,"end_character":38},"in_reply_to":"3f1d235d_52edfcb4","updated":"2017-07-07 10:36:39.000000000","message":"Done","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ea4a55df164e0449961131ac59ce870485bb5565","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        super(IRMCPXEBoot, self).prepare_instance(task)"},{"line_number":716,"context_line":"        node \u003d task.node"},{"line_number":717,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":718,"context_line":"            LOG.info(\u0027Enable secure boot mode on node %s \u0027, node.uuid)"},{"line_number":719,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    @METRICS.timer(\u0027IRMCPXEBoot.clean_up_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_3ee59f38","line":718,"range":{"start_line":718,"start_character":56,"end_line":718,"end_character":57},"updated":"2017-07-06 10:21:27.000000000","message":"nit: remove extra space","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        super(IRMCPXEBoot, self).prepare_instance(task)"},{"line_number":716,"context_line":"        node \u003d task.node"},{"line_number":717,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":718,"context_line":"            LOG.info(\u0027Enable secure boot mode on node %s \u0027, node.uuid)"},{"line_number":719,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    @METRICS.timer(\u0027IRMCPXEBoot.clean_up_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_d83b3435","line":718,"range":{"start_line":718,"start_character":56,"end_line":718,"end_character":57},"in_reply_to":"3f1d235d_3ee59f38","updated":"2017-07-07 10:36:39.000000000","message":"Done","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ea4a55df164e0449961131ac59ce870485bb5565","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        \"\"\""},{"line_number":733,"context_line":"        node \u003d task.node"},{"line_number":734,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":735,"context_line":"            LOG.info(\u0027Disable secure boot mode on node %s \u0027, node.uuid)"},{"line_number":736,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dFalse)"},{"line_number":737,"context_line":"        super(IRMCPXEBoot, self).clean_up_instance(task)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_3ebebffe","line":735,"range":{"start_line":735,"start_character":57,"end_line":735,"end_character":58},"updated":"2017-07-06 10:21:27.000000000","message":"ditto","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        \"\"\""},{"line_number":733,"context_line":"        node \u003d task.node"},{"line_number":734,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":735,"context_line":"            LOG.info(\u0027Disable secure boot mode on node %s \u0027, node.uuid)"},{"line_number":736,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dFalse)"},{"line_number":737,"context_line":"        super(IRMCPXEBoot, self).clean_up_instance(task)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_b84638bf","line":735,"range":{"start_line":735,"start_character":57,"end_line":735,"end_character":58},"in_reply_to":"3f1d235d_3ebebffe","updated":"2017-07-07 10:36:39.000000000","message":"Done","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"074fa2f9313d884cde852ec16bf210e10668e299","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        super(IRMCPXEBoot, self).prepare_instance(task)"},{"line_number":711,"context_line":"        node \u003d task.node"},{"line_number":712,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":713,"context_line":"            LOG.info(\u0027Enable secure boot mode on node %s\u0027, node.uuid)"},{"line_number":714,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    @METRICS.timer(\u0027IRMCPXEBoot.clean_up_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_70fa9775","line":713,"range":{"start_line":713,"start_character":12,"end_line":713,"end_character":69},"updated":"2017-08-02 16:35:39.000000000","message":"LOG.info usually designates finished actions, so please move it after the next line, and do s/Enable/Enabled/","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"232b2dc2e22f4a417b6f56576eaf53f07a2cd940","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        super(IRMCPXEBoot, self).prepare_instance(task)"},{"line_number":711,"context_line":"        node \u003d task.node"},{"line_number":712,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":713,"context_line":"            LOG.info(\u0027Enable secure boot mode on node %s\u0027, node.uuid)"},{"line_number":714,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    @METRICS.timer(\u0027IRMCPXEBoot.clean_up_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_f9a8a28c","line":713,"range":{"start_line":713,"start_character":12,"end_line":713,"end_character":69},"in_reply_to":"df3967d1_70fa9775","updated":"2017-08-03 03:02:33.000000000","message":"Done","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"074fa2f9313d884cde852ec16bf210e10668e299","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        \"\"\""},{"line_number":728,"context_line":"        node \u003d task.node"},{"line_number":729,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":730,"context_line":"            LOG.info(\u0027Disable secure boot mode on node %s\u0027, node.uuid)"},{"line_number":731,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dFalse)"},{"line_number":732,"context_line":"        super(IRMCPXEBoot, self).clean_up_instance(task)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_9003bb73","line":730,"range":{"start_line":730,"start_character":12,"end_line":730,"end_character":70},"updated":"2017-08-02 16:35:39.000000000","message":"ditto","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"232b2dc2e22f4a417b6f56576eaf53f07a2cd940","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        \"\"\""},{"line_number":728,"context_line":"        node \u003d task.node"},{"line_number":729,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"},{"line_number":730,"context_line":"            LOG.info(\u0027Disable secure boot mode on node %s\u0027, node.uuid)"},{"line_number":731,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dFalse)"},{"line_number":732,"context_line":"        super(IRMCPXEBoot, self).clean_up_instance(task)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_b9969a4b","line":730,"range":{"start_line":730,"start_character":12,"end_line":730,"end_character":70},"in_reply_to":"df3967d1_9003bb73","updated":"2017-08-03 03:02:33.000000000","message":"Done","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"}],"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f7a3b31b229bec5c3d30c3b42cb834ee34b9326","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: An ironic node object."},{"line_number":209,"context_line":"    :param enable: Boolean value. True if the secure boot to be"},{"line_number":210,"context_line":"                       enabled in next boot."},{"line_number":211,"context_line":"    :raises: IRMCOperationError if the operation fails."},{"line_number":212,"context_line":"    \"\"\""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_129b0418","line":210,"range":{"start_line":210,"start_character":14,"end_line":210,"end_character":43},"updated":"2017-07-06 04:49:09.000000000","message":"nit: Fix formatting.","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: An ironic node object."},{"line_number":209,"context_line":"    :param enable: Boolean value. True if the secure boot to be"},{"line_number":210,"context_line":"                       enabled in next boot."},{"line_number":211,"context_line":"    :raises: IRMCOperationError if the operation fails."},{"line_number":212,"context_line":"    \"\"\""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_981a5cc3","line":210,"range":{"start_line":210,"start_character":14,"end_line":210,"end_character":43},"in_reply_to":"3f1d235d_129b0418","updated":"2017-07-07 10:36:39.000000000","message":"Done","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f7a3b31b229bec5c3d30c3b42cb834ee34b9326","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        elcm.set_secure_boot_mode(driver_info, enable)"},{"line_number":221,"context_line":"        LOG.info(operation)"},{"line_number":222,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":223,"context_line":"        raise exception.IRMCOperationError(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_324f2094","line":220,"range":{"start_line":220,"start_character":13,"end_line":220,"end_character":33},"updated":"2017-07-06 04:49:09.000000000","message":"Query: Isn\u0027t changing of boot mode to secure boot requires 2 reboots, in case current boot mode is \u0027bios\u0027? It is the case in Proliants servers. In Proliants if current boot mod is \u0027bios\u0027 then it works like:-\nBIOS to UEFi -\u003e Reboot -\u003e UEFI to Secure boot -\u003e Reboot","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    driver_info \u003d parse_driver_info(node)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        elcm.set_secure_boot_mode(driver_info, enable)"},{"line_number":221,"context_line":"        LOG.info(operation)"},{"line_number":222,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":223,"context_line":"        raise exception.IRMCOperationError(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_d85c544c","line":220,"range":{"start_line":220,"start_character":13,"end_line":220,"end_character":33},"in_reply_to":"3f1d235d_324f2094","updated":"2017-07-07 10:36:39.000000000","message":"In Fujitsu PRIMERGY, changing of boot mode to secure boot requires one reboot because when Secure Boot Mode set Enable then Boot Mode from BIOS or UEFI will change to UEFI. By the way, when Secure Boot Mode Enable we cannot config boot mode is UEFI or BIOS any more.","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"074fa2f9313d884cde852ec16bf210e10668e299","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def set_secure_boot_mode(node, enable):"},{"line_number":204,"context_line":"    \"\"\"Enable or disable UEFI Secure Boot for the next boot"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    Enable or disable UEFI Secure Boot for the next boot"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_90117baf","line":204,"range":{"start_line":204,"start_character":42,"end_line":204,"end_character":59},"updated":"2017-08-02 16:35:39.000000000","message":"is it only for *one* boot? it sounds like secure boot will be disabled if somebody does \u0027nova reboot\u0027 for the node. I hope it\u0027s not the case..","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"232b2dc2e22f4a417b6f56576eaf53f07a2cd940","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def set_secure_boot_mode(node, enable):"},{"line_number":204,"context_line":"    \"\"\"Enable or disable UEFI Secure Boot for the next boot"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    Enable or disable UEFI Secure Boot for the next boot"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_f9f0a2ff","line":204,"range":{"start_line":204,"start_character":42,"end_line":204,"end_character":59},"in_reply_to":"df3967d1_90117baf","updated":"2017-08-03 03:02:33.000000000","message":"This is a document mistake.","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"074fa2f9313d884cde852ec16bf210e10668e299","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        elcm.set_secure_boot_mode(driver_info, enable)"},{"line_number":221,"context_line":"        LOG.info(operation)"},{"line_number":222,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":223,"context_line":"        raise exception.IRMCOperationError(operation\u003doperation,"},{"line_number":224,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_10446bb6","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":27},"updated":"2017-08-02 16:35:39.000000000","message":"this duplicates logging in boot.py. Maybe it\u0027s worth leaving only this log line (s/Setting/Set/ though) and remove logging from boot.py?","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"232b2dc2e22f4a417b6f56576eaf53f07a2cd940","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        elcm.set_secure_boot_mode(driver_info, enable)"},{"line_number":221,"context_line":"        LOG.info(operation)"},{"line_number":222,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":223,"context_line":"        raise exception.IRMCOperationError(operation\u003doperation,"},{"line_number":224,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_d45c85ee","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":27},"in_reply_to":"df3967d1_10446bb6","updated":"2017-08-03 03:02:33.000000000","message":"Done","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"074fa2f9313d884cde852ec16bf210e10668e299","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        elcm.set_secure_boot_mode(driver_info, enable)"},{"line_number":221,"context_line":"        LOG.info(operation)"},{"line_number":222,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":223,"context_line":"        raise exception.IRMCOperationError(operation\u003doperation,"},{"line_number":224,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_d01703a3","line":222,"updated":"2017-08-02 16:35:39.000000000","message":"nit: maybe LOG.error here?","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"232b2dc2e22f4a417b6f56576eaf53f07a2cd940","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        elcm.set_secure_boot_mode(driver_info, enable)"},{"line_number":221,"context_line":"        LOG.info(operation)"},{"line_number":222,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":223,"context_line":"        raise exception.IRMCOperationError(operation\u003doperation,"},{"line_number":224,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_b4758166","line":222,"in_reply_to":"df3967d1_d01703a3","updated":"2017-08-03 03:02:33.000000000","message":"Done","commit_id":"0f372c72a112a76cd33e1a7aa310491e13ec6cb6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d8870b17f467de6615f68e0e5d7af4eb81d35deb","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    :raises: IRMCOperationError if the operation fails."},{"line_number":212,"context_line":"    \"\"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    operation \u003d (_(\"Set secure boot to %(flag)s for node %(node)s.\") %"},{"line_number":215,"context_line":"                 {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    driver_info \u003d parse_driver_info(node)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_9a6168ac","line":214,"range":{"start_line":214,"start_character":17,"end_line":214,"end_character":19},"updated":"2017-08-03 19:41:50.000000000","message":"There is a desire to not translate logging messages, and this appears to be just for logging...","commit_id":"798c7eba481d102dfdfb4d44e0d5822fbb03bc8f"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"024676ef737be9c8f21cedd1eeac6952bc9d8d07","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    :raises: IRMCOperationError if the operation fails."},{"line_number":212,"context_line":"    \"\"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    operation \u003d (_(\"Set secure boot to %(flag)s for node %(node)s.\") %"},{"line_number":215,"context_line":"                 {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    driver_info \u003d parse_driver_info(node)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_3f114553","line":214,"range":{"start_line":214,"start_character":17,"end_line":214,"end_character":19},"in_reply_to":"df3967d1_9a6168ac","updated":"2017-08-04 01:59:12.000000000","message":"Done","commit_id":"798c7eba481d102dfdfb4d44e0d5822fbb03bc8f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"90fe7c45e6c255f745f37365b36bde7ae4a106f8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    :raises: IRMCOperationError if the operation fails."},{"line_number":212,"context_line":"    \"\"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    operation \u003d (\"Set secure boot to %(flag)s for node %(node)s.\""},{"line_number":215,"context_line":"                 % {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    driver_info \u003d parse_driver_info(node)"}],"source_content_type":"text/x-python","patch_set":16,"id":"df3967d1_e5a20cae","line":214,"range":{"start_line":214,"start_character":15,"end_line":214,"end_character":65},"updated":"2017-08-04 04:09:36.000000000","message":"@Julia: I think this message needs translation as its used in the exception below @ L225.","commit_id":"82dd8913734819fa20cac7c2ea6ecf58d3059847"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"4772294dafe64612250a0f2a426b769df1bd6674","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    :raises: IRMCOperationError if the operation fails."},{"line_number":212,"context_line":"    \"\"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    operation \u003d (\"Set secure boot to %(flag)s for node %(node)s.\""},{"line_number":215,"context_line":"                 % {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    driver_info \u003d parse_driver_info(node)"}],"source_content_type":"text/x-python","patch_set":16,"id":"df3967d1_c5c4a8f7","line":214,"range":{"start_line":214,"start_character":15,"end_line":214,"end_character":65},"in_reply_to":"df3967d1_e5a20cae","updated":"2017-08-04 08:30:53.000000000","message":"@Shivanand: Thanks for your help","commit_id":"82dd8913734819fa20cac7c2ea6ecf58d3059847"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2aa22eb3a23b3a209fd30b78285df5d5c8af8a8f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":220,"context_line":"        LOG.error(\"Failed to set secure boot to %(flag)s for node %(node)s\","},{"line_number":221,"context_line":"                  {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":222,"context_line":"        raise exception.IRMCOperationError(operation\u003d\"set_secure_boot_mode\","},{"line_number":223,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_d89321a3","line":222,"range":{"start_line":222,"start_character":43,"end_line":222,"end_character":75},"updated":"2017-08-08 03:51:32.000000000","message":"This needs log translation:-\nraise exception.IRMCOperationError(operation\u003d_(\"set_secure_boot_mode\"), error\u003dirmc_exception)","commit_id":"5b6c4ff6ba7b7c3a84aa6e456681de6772b60f2c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"06c8f29ec30633624d6ce203d38e71b9e4ebd876","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":220,"context_line":"        LOG.error(\"Failed to set secure boot to %(flag)s for node %(node)s\","},{"line_number":221,"context_line":"                  {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":222,"context_line":"        raise exception.IRMCOperationError(operation\u003d\"set_secure_boot_mode\","},{"line_number":223,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f436f4f_c31b3671","line":222,"range":{"start_line":222,"start_character":43,"end_line":222,"end_character":75},"in_reply_to":"9f436f4f_d89321a3","updated":"2017-08-08 04:34:24.000000000","message":"Done","commit_id":"5b6c4ff6ba7b7c3a84aa6e456681de6772b60f2c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"a734e1ca9b58484373e9048aa178a443cf445407","unresolved":false,"context_lines":[{"line_number":203,"context_line":"def set_secure_boot_mode(node, enable):"},{"line_number":204,"context_line":"    \"\"\"Enable or disable UEFI Secure Boot"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    Enable or disable UEFI Secure Boot"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: An ironic node object."},{"line_number":209,"context_line":"    :param enable: Boolean value. True if the secure boot to be"}],"source_content_type":"text/x-python","patch_set":21,"id":"9f436f4f_139f0760","line":206,"range":{"start_line":206,"start_character":4,"end_line":206,"end_character":37},"updated":"2017-08-10 06:09:16.000000000","message":"nit: this line is redundant. Better to change the sentence or remove it.","commit_id":"802c86ef045a007adad7f087082928550268b623"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d7cf115296fcc93cd7fe8a3d4aa37a48359647d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":220,"context_line":"        LOG.error(\"Failed to set secure boot to %(flag)s for node %(node)s\","},{"line_number":221,"context_line":"                  {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":222,"context_line":"        raise exception.IRMCOperationError(operation\u003d_(\"set_secure_boot_mode\"),"},{"line_number":223,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":21,"id":"9f436f4f_26ee5d22","line":222,"range":{"start_line":222,"start_character":56,"end_line":222,"end_character":76},"updated":"2017-08-09 15:58:43.000000000","message":"nit: I wonder if it should be something more human-friendly, like \"setting secure boot mode\"","commit_id":"802c86ef045a007adad7f087082928550268b623"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"a734e1ca9b58484373e9048aa178a443cf445407","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    except scci.SCCIError as irmc_exception:"},{"line_number":220,"context_line":"        LOG.error(\"Failed to set secure boot to %(flag)s for node %(node)s\","},{"line_number":221,"context_line":"                  {\u0027flag\u0027: enable, \u0027node\u0027: node.uuid})"},{"line_number":222,"context_line":"        raise exception.IRMCOperationError(operation\u003d_(\"set_secure_boot_mode\"),"},{"line_number":223,"context_line":"                                           error\u003dirmc_exception)"}],"source_content_type":"text/x-python","patch_set":21,"id":"9f436f4f_b3927b4a","line":222,"range":{"start_line":222,"start_character":56,"end_line":222,"end_character":76},"in_reply_to":"9f436f4f_26ee5d22","updated":"2017-08-10 06:09:16.000000000","message":"+1. Also it is good to log the exception(SCIError) also at L220. Does the exception provide more information like what was the actual failure.","commit_id":"802c86ef045a007adad7f087082928550268b623"}],"ironic/tests/unit/drivers/modules/irmc/test_boot.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7dc64cf9847b5a074a60d4b0a6c3060a8e8b585","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                       autospec\u003dTrue)"},{"line_number":1118,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027clean_up_instance\u0027, spec_set\u003dTrue,"},{"line_number":1119,"context_line":"                       autospec\u003dTrue)"},{"line_number":1120,"context_line":"    def test_clean_up_instance_with_secure_boot(self, mock_clean_up_instance,"},{"line_number":1121,"context_line":"                                                mock_set_secure_boot_mode):"},{"line_number":1122,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1123,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1124,"context_line":"            task.node.instance_info \u003d {\u0027capabilities\u0027: {\"secure_boot\": \"true\"}}"},{"line_number":1125,"context_line":"            task.driver.boot.clean_up_instance(task)"},{"line_number":1126,"context_line":"            mock_set_secure_boot_mode.assert_called_once_with(task.node,"},{"line_number":1127,"context_line":"                                                              enable\u003dFalse)"},{"line_number":1128,"context_line":"            mock_clean_up_instance.assert_called_once_with("},{"line_number":1129,"context_line":"                task.driver.boot, task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_7a5e51ea","line":1129,"range":{"start_line":1120,"start_character":4,"end_line":1129,"end_character":39},"updated":"2017-07-07 13:02:58.000000000","message":"I think it is important to actually mock this through the state machine.  i.e. set secure_boot to true, in entry for an instance, then set the provision state for that instance to be deleted. You can mock the underlying calls, but that way you can ensure that something in the conductor or deployment behavior does not break this feature.  It might e good to do with both tests.  This means there would be four tests, but I think it would provide better overall testing and help ensure that a minor patch elsewhere does not break your driver.","commit_id":"bade1f6c6f9fc7028f540669ed651c28aa439d82"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"6b95ef93e6b6780dc9c922f5986aa8fb284b48c2","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                       autospec\u003dTrue)"},{"line_number":1118,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027clean_up_instance\u0027, spec_set\u003dTrue,"},{"line_number":1119,"context_line":"                       autospec\u003dTrue)"},{"line_number":1120,"context_line":"    def test_clean_up_instance_with_secure_boot(self, mock_clean_up_instance,"},{"line_number":1121,"context_line":"                                                mock_set_secure_boot_mode):"},{"line_number":1122,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1123,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1124,"context_line":"            task.node.instance_info \u003d {\u0027capabilities\u0027: {\"secure_boot\": \"true\"}}"},{"line_number":1125,"context_line":"            task.driver.boot.clean_up_instance(task)"},{"line_number":1126,"context_line":"            mock_set_secure_boot_mode.assert_called_once_with(task.node,"},{"line_number":1127,"context_line":"                                                              enable\u003dFalse)"},{"line_number":1128,"context_line":"            mock_clean_up_instance.assert_called_once_with("},{"line_number":1129,"context_line":"                task.driver.boot, task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_19ff1435","line":1129,"range":{"start_line":1120,"start_character":4,"end_line":1129,"end_character":39},"in_reply_to":"3f1d235d_7a5e51ea","updated":"2017-07-14 08:23:37.000000000","message":"I updated new patch add test case base on your suggestion?","commit_id":"bade1f6c6f9fc7028f540669ed651c28aa439d82"}],"ironic/tests/unit/drivers/modules/irmc/test_common.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fe4717dfd60d844efc9f7704c548bb46a7d5d39f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            self.assertRaises(exception.IRMCOperationError,"},{"line_number":242,"context_line":"                              irmc_common.set_secure_boot_mode,"},{"line_number":243,"context_line":"                              task.node, True)"},{"line_number":244,"context_line":"            self.assertEqual(1, mock_elcm.set_secure_boot_mode.call_count)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_651240b4","line":244,"range":{"start_line":244,"start_character":12,"end_line":244,"end_character":74},"updated":"2017-07-29 13:07:48.000000000","message":"nit: Do you need to check count here?\nmock_elcm.set_secure_boot_mode.assert_called_with(\n            info, True)","commit_id":"c1020587d4cb398ac75d8b98421da94e340c9f0b"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"ea2d56165dab1be84cd0fb1770aae824f0ca9008","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            self.assertRaises(exception.IRMCOperationError,"},{"line_number":242,"context_line":"                              irmc_common.set_secure_boot_mode,"},{"line_number":243,"context_line":"                              task.node, True)"},{"line_number":244,"context_line":"            self.assertEqual(1, mock_elcm.set_secure_boot_mode.call_count)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_be2f12f5","line":244,"range":{"start_line":244,"start_character":12,"end_line":244,"end_character":74},"in_reply_to":"df3967d1_651240b4","updated":"2017-07-31 02:09:05.000000000","message":"Done","commit_id":"c1020587d4cb398ac75d8b98421da94e340c9f0b"}],"releasenotes/notes/add-secure-boot-suport-irmc-2c1f09271f96424d.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f7a3b31b229bec5c3d30c3b42cb834ee34b9326","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - UEFI secure boot support was enabled for pxe_irmc"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_f5e8727c","line":3,"range":{"start_line":3,"start_character":44,"end_line":3,"end_character":53},"updated":"2017-07-06 04:49:09.000000000","message":"Mention boot interface \u0027irmc-pxe\u0027","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"0a8110cfffb907c63142342ca651e968992595b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - UEFI secure boot support was enabled for pxe_irmc"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_38122863","line":3,"range":{"start_line":3,"start_character":44,"end_line":3,"end_character":53},"in_reply_to":"3f1d235d_f5e8727c","updated":"2017-07-07 10:36:39.000000000","message":"Done","commit_id":"693863e3be4b657042091091b5ca4a1afe582206"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7dc64cf9847b5a074a60d4b0a6c3060a8e8b585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - UEFI secure boot support was enabled for irmc-pxe"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f1d235d_5a0835d8","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":53},"updated":"2017-07-07 13:02:58.000000000","message":"Perhaps \"Adds setting of UEFI Secure Boot for users of the irmc pxe boot interface\"?  We generally always want to start with \"Adds or Changes\" In this case, being the addition of a feature, it would be \"Adds\"","commit_id":"bade1f6c6f9fc7028f540669ed651c28aa439d82"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"6b95ef93e6b6780dc9c922f5986aa8fb284b48c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - UEFI secure boot support was enabled for irmc-pxe"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_d9f87c4a","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":53},"in_reply_to":"3f1d235d_5a0835d8","updated":"2017-07-14 08:23:37.000000000","message":"Done","commit_id":"bade1f6c6f9fc7028f540669ed651c28aa439d82"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fe4717dfd60d844efc9f7704c548bb46a7d5d39f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds setting of UEFI Secure Boot for users of the irmc-pxe boot interface"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df3967d1_c5056c7c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":77},"updated":"2017-07-29 13:07:48.000000000","message":"May be this could be reworded as :\n\u0027Adds support to provision an instance in UEFI secure boot for ``irmc-pxe`` boot interface.","commit_id":"c1020587d4cb398ac75d8b98421da94e340c9f0b"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"eddf4a2f664f855daa0875b8be515af2bfc3c8f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds setting of UEFI Secure Boot for users of the irmc-pxe boot interface"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df3967d1_225c2e4a","line":3,"range":{"start_line":3,"start_character":54,"end_line":3,"end_character":62},"updated":"2017-07-29 10:16:09.000000000","message":"``irmc-pxe``","commit_id":"c1020587d4cb398ac75d8b98421da94e340c9f0b"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"ea2d56165dab1be84cd0fb1770aae824f0ca9008","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds setting of UEFI Secure Boot for users of the irmc-pxe boot interface"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df3967d1_1ee61e46","line":3,"range":{"start_line":3,"start_character":54,"end_line":3,"end_character":62},"in_reply_to":"df3967d1_225c2e4a","updated":"2017-07-31 02:09:05.000000000","message":"Done","commit_id":"c1020587d4cb398ac75d8b98421da94e340c9f0b"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"ea2d56165dab1be84cd0fb1770aae824f0ca9008","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds setting of UEFI Secure Boot for users of the irmc-pxe boot interface"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df3967d1_7ed08a51","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":77},"in_reply_to":"df3967d1_c5056c7c","updated":"2017-07-31 02:09:05.000000000","message":"Done","commit_id":"c1020587d4cb398ac75d8b98421da94e340c9f0b"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"c501b7c8dd78d8fe0c00884f9cbac136dfa78587","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to provision an instance in UEFI secure boot for"},{"line_number":4,"context_line":"    ``irmc-pxe`` boot interface."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf3e73b7_11d734c2","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":5},"updated":"2017-08-07 04:15:29.000000000","message":"Add | to indicate multiple line string","commit_id":"5b6c4ff6ba7b7c3a84aa6e456681de6772b60f2c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"06c8f29ec30633624d6ce203d38e71b9e4ebd876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to provision an instance in UEFI secure boot for"},{"line_number":4,"context_line":"    ``irmc-pxe`` boot interface."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f436f4f_632c8a99","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":5},"in_reply_to":"9f436f4f_78b795da","updated":"2017-08-08 04:34:24.000000000","message":"Done","commit_id":"5b6c4ff6ba7b7c3a84aa6e456681de6772b60f2c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2aa22eb3a23b3a209fd30b78285df5d5c8af8a8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to provision an instance in UEFI secure boot for"},{"line_number":4,"context_line":"    ``irmc-pxe`` boot interface."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f436f4f_78b795da","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":5},"in_reply_to":"bf3e73b7_11d734c2","updated":"2017-08-08 03:51:32.000000000","message":"+1","commit_id":"5b6c4ff6ba7b7c3a84aa6e456681de6772b60f2c"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"06c8f29ec30633624d6ce203d38e71b9e4ebd876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to provision an instance in UEFI secure boot for"},{"line_number":4,"context_line":"    ``irmc-pxe`` boot interface."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9f436f4f_83276eb7","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":5},"in_reply_to":"bf3e73b7_11d734c2","updated":"2017-08-08 04:34:24.000000000","message":"Done","commit_id":"5b6c4ff6ba7b7c3a84aa6e456681de6772b60f2c"}]}