)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"638066ce8be696f7e466a72571850f171d7f1e82","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow updating interfaces on a node in available state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables to update interfaces on a node whose provision"},{"line_number":10,"context_line":"state is \u0027available\u0027. This operation doesn\u0027t cause any problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I428dd5905e6ab90c2c0b7867ba487482171b9496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_3d2a26da","line":9,"updated":"2017-07-19 16:35:42.000000000","message":"Enable being able to set the network interfaces for a node that is in the provision state \u0027available\u0027.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8a48236af806554cbba4df620cf25859712600d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow updating interfaces on a node in available state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables to update interfaces on a node whose provision"},{"line_number":10,"context_line":"state is \u0027available\u0027. This operation doesn\u0027t cause any problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I428dd5905e6ab90c2c0b7867ba487482171b9496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_6f78d68e","line":9,"in_reply_to":"1f1a1f67_3d2a26da","updated":"2017-07-20 02:39:06.000000000","message":"John, the change is all interfaces, as such I\u0027m a little confused by your comment. Could you elaborate?","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"664c1de01195107c03b0e79f50a4668b9d908426","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow updating interfaces on a node in available state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables to update interfaces on a node whose provision"},{"line_number":10,"context_line":"state is \u0027available\u0027. This operation doesn\u0027t cause any problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I428dd5905e6ab90c2c0b7867ba487482171b9496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_b9774509","line":9,"in_reply_to":"1f1a1f67_6f78d68e","updated":"2017-07-20 14:41:53.000000000","message":"Is it fine if \u0027network\u0027 is removed?","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49018e00831ab779375e95a285e1719c5a4ffca8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow updating interfaces on a node in available state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables to update interfaces on a node whose provision"},{"line_number":10,"context_line":"state is \u0027available\u0027. This operation doesn\u0027t cause any problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I428dd5905e6ab90c2c0b7867ba487482171b9496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_a7a39b00","line":9,"in_reply_to":"1f1a1f67_b9774509","updated":"2017-07-20 17:14:48.000000000","message":"Sure without \u0027network\u0027 is good. I thought it was only network.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"638066ce8be696f7e466a72571850f171d7f1e82","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow updating interfaces on a node in available state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables to update interfaces on a node whose provision"},{"line_number":10,"context_line":"state is \u0027available\u0027. This operation doesn\u0027t cause any problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I428dd5905e6ab90c2c0b7867ba487482171b9496"},{"line_number":13,"context_line":"Closes-Bug: #1704913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_fd1f0eb4","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":63},"updated":"2017-07-19 16:35:42.000000000","message":"I don\u0027t think we need this.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"664c1de01195107c03b0e79f50a4668b9d908426","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow updating interfaces on a node in available state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables to update interfaces on a node whose provision"},{"line_number":10,"context_line":"state is \u0027available\u0027. This operation doesn\u0027t cause any problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I428dd5905e6ab90c2c0b7867ba487482171b9496"},{"line_number":13,"context_line":"Closes-Bug: #1704913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_0b2dc3a7","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":63},"in_reply_to":"1f1a1f67_fd1f0eb4","updated":"2017-07-20 14:41:53.000000000","message":"Done","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"}],"ironic/conductor/manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"638066ce8be696f7e466a72571850f171d7f1e82","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if \u0027maintenance\u0027 in delta and not node_obj.maintenance:"},{"line_number":162,"context_line":"            node_obj.maintenance_reason \u003d None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # TODO(dtantsur): reconsider allowing changing some (but not all)"},{"line_number":165,"context_line":"        # interfaces for active nodes in the future."},{"line_number":166,"context_line":"        allowed_update_states \u003d [states.ENROLL, states.INSPECTING,"},{"line_number":167,"context_line":"                                 states.MANAGEABLE, states.AVAILABLE]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_bd64f64a","line":164,"updated":"2017-07-19 16:35:42.000000000","message":"Seems like this TODO message should be updated.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"664c1de01195107c03b0e79f50a4668b9d908426","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if \u0027maintenance\u0027 in delta and not node_obj.maintenance:"},{"line_number":162,"context_line":"            node_obj.maintenance_reason \u003d None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # TODO(dtantsur): reconsider allowing changing some (but not all)"},{"line_number":165,"context_line":"        # interfaces for active nodes in the future."},{"line_number":166,"context_line":"        allowed_update_states \u003d [states.ENROLL, states.INSPECTING,"},{"line_number":167,"context_line":"                                 states.MANAGEABLE, states.AVAILABLE]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_19c75948","line":164,"in_reply_to":"1f1a1f67_1415f748","updated":"2017-07-20 14:41:53.000000000","message":"This TODO seems to mention \u0027active\u0027 state[1]. I don\u0027t think updating is necessary.\n\n[1] https://review.openstack.org/#/c/336626/26/ironic/conductor/manager.py@148","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1cc546fae8070ae082629782c8c963a27f83ba80","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if \u0027maintenance\u0027 in delta and not node_obj.maintenance:"},{"line_number":162,"context_line":"            node_obj.maintenance_reason \u003d None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # TODO(dtantsur): reconsider allowing changing some (but not all)"},{"line_number":165,"context_line":"        # interfaces for active nodes in the future."},{"line_number":166,"context_line":"        allowed_update_states \u003d [states.ENROLL, states.INSPECTING,"},{"line_number":167,"context_line":"                                 states.MANAGEABLE, states.AVAILABLE]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_2790ab95","line":164,"in_reply_to":"1f1a1f67_19c75948","updated":"2017-07-20 17:16:44.000000000","message":"Okay.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8a48236af806554cbba4df620cf25859712600d2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if \u0027maintenance\u0027 in delta and not node_obj.maintenance:"},{"line_number":162,"context_line":"            node_obj.maintenance_reason \u003d None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # TODO(dtantsur): reconsider allowing changing some (but not all)"},{"line_number":165,"context_line":"        # interfaces for active nodes in the future."},{"line_number":166,"context_line":"        allowed_update_states \u003d [states.ENROLL, states.INSPECTING,"},{"line_number":167,"context_line":"                                 states.MANAGEABLE, states.AVAILABLE]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_1415f748","line":164,"in_reply_to":"1f1a1f67_bd64f64a","updated":"2017-07-20 02:39:06.000000000","message":"I personally think the TODO is still valid. We\u0027ve not reconsidered all states, like it might make sense to allow someone to change interfaces in an error state.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"07e3bb789d8871a9d0ff50b4edef354932eff9bb","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        self.assertEqual(existing_driver, node.driver)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    IFACE_UPDATE_DICT \u003d {"},{"line_number":573,"context_line":"        \u0027boot_interface\u0027: [None, \u0027fake\u0027],"},{"line_number":574,"context_line":"        \u0027console_interface\u0027: [None, \u0027fake\u0027],"},{"line_number":575,"context_line":"        \u0027deploy_interface\u0027: [None, \u0027fake\u0027],"},{"line_number":576,"context_line":"        \u0027inspect_interface\u0027: [None, \u0027fake\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_4442ae10","line":573,"range":{"start_line":573,"start_character":26,"end_line":573,"end_character":40},"updated":"2017-07-19 17:14:08.000000000","message":"Please document what is difference between item 0 and item 1\n\nMaybe a collections.namedtuple would be a good choice here?","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"664c1de01195107c03b0e79f50a4668b9d908426","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        self.assertEqual(existing_driver, node.driver)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    IFACE_UPDATE_DICT \u003d {"},{"line_number":573,"context_line":"        \u0027boot_interface\u0027: [None, \u0027fake\u0027],"},{"line_number":574,"context_line":"        \u0027console_interface\u0027: [None, \u0027fake\u0027],"},{"line_number":575,"context_line":"        \u0027deploy_interface\u0027: [None, \u0027fake\u0027],"},{"line_number":576,"context_line":"        \u0027inspect_interface\u0027: [None, \u0027fake\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_eb02870b","line":573,"range":{"start_line":573,"start_character":26,"end_line":573,"end_character":40},"in_reply_to":"1f1a1f67_4442ae10","updated":"2017-07-20 14:41:53.000000000","message":"Done with namedtuple. Thanks.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b2827fb3b7653e7b5ac314be042783d84afea1e7","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    def test_update_node_interface_in_maintenance(self):"},{"line_number":621,"context_line":"        self._test_update_node_interface_in_allowed_state(states.ACTIVE,"},{"line_number":622,"context_line":"                                                          maintenance\u003dTrue)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def _test_update_node_interface_not_allowed(self, node, iface_name,"},{"line_number":625,"context_line":"                                                new_iface):"},{"line_number":626,"context_line":"        old_iface \u003d getattr(node, iface_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_d15d8c79","line":623,"updated":"2017-07-18 15:42:08.000000000","message":"Can we merge the above test for different states?\n  for state in (states.ENROLL, states.ACTIVE, ...):\n    self._test_update_node_interface_in_allowed_state(state)","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"664c1de01195107c03b0e79f50a4668b9d908426","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    def test_update_node_interface_in_maintenance(self):"},{"line_number":621,"context_line":"        self._test_update_node_interface_in_allowed_state(states.ACTIVE,"},{"line_number":622,"context_line":"                                                          maintenance\u003dTrue)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def _test_update_node_interface_not_allowed(self, node, iface_name,"},{"line_number":625,"context_line":"                                                new_iface):"},{"line_number":626,"context_line":"        old_iface \u003d getattr(node, iface_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_b9d06555","line":623,"in_reply_to":"1f1a1f67_44d878ed","updated":"2017-07-20 14:41:53.000000000","message":"Though I wondered if it was better to test multiple cases in single test, it seems better to merge according to the comments.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"34eb73a57df7a1778d09f9e0e555c493556a4a48","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    def test_update_node_interface_in_maintenance(self):"},{"line_number":621,"context_line":"        self._test_update_node_interface_in_allowed_state(states.ACTIVE,"},{"line_number":622,"context_line":"                                                          maintenance\u003dTrue)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def _test_update_node_interface_not_allowed(self, node, iface_name,"},{"line_number":625,"context_line":"                                                new_iface):"},{"line_number":626,"context_line":"        old_iface \u003d getattr(node, iface_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_44d878ed","line":623,"in_reply_to":"1f1a1f67_d15d8c79","updated":"2017-07-19 13:01:37.000000000","message":"We should be able to, although the test immediately above would not be able to be in that test. I think it would make a good follow-up.","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"07e3bb789d8871a9d0ff50b4edef354932eff9bb","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def test_update_node_interface_invalid(self):"},{"line_number":659,"context_line":"        node \u003d self._create_node_with_interfaces(states.MANAGEABLE)"},{"line_number":660,"context_line":"        for iface_name, ifaces in self.IFACE_UPDATE_DICT.items():"},{"line_number":661,"context_line":"            self._test_update_node_interface_invalid(node, iface_name)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_c4dfde63","line":660,"updated":"2017-07-19 17:14:08.000000000","message":"Don\u0027t need to use items()\n\n for iface_name in self.IFACE_UPDATE_DICT:","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"664c1de01195107c03b0e79f50a4668b9d908426","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def test_update_node_interface_invalid(self):"},{"line_number":659,"context_line":"        node \u003d self._create_node_with_interfaces(states.MANAGEABLE)"},{"line_number":660,"context_line":"        for iface_name, ifaces in self.IFACE_UPDATE_DICT.items():"},{"line_number":661,"context_line":"            self._test_update_node_interface_invalid(node, iface_name)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_cefd9909","line":660,"in_reply_to":"1f1a1f67_c4dfde63","updated":"2017-07-20 14:41:53.000000000","message":"Done","commit_id":"baf156bdd303aa880c3875bde16c1d0dcf724be9"}],"releasenotes/notes/fix-set-interface-to-node-in-available-bd6f695620c2d77f.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"831e149233f97e616bb94276e37ea3d3ed0d2f20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug 1704913 so that hardware interfaces of a node whose provision"},{"line_number":5,"context_line":"    state is ``available`` can be set by a PATCH request to the endpoint"},{"line_number":6,"context_line":"    ``v1/nodes/{node_ident}``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f1a1f67_2248025a","line":4,"updated":"2017-07-18 08:31:10.000000000","message":"I don\u0027t quite agree that it\u0027s a bug. And the bug number is not particularly useful without a link to it. So if you want to keep it for reference, please use something like:\n\n features:\n   - |\n     Allows updating hardware interfaces on nodes in the ``available`` state (`bug 1704913 \u003chttps://bugs.launchpad.net/ironic/+bug/1704913`_).","commit_id":"1b65d70124ac0627a0fb6b664c6bdd50b302640c"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"eb701092c282e19b5fba909b2f7f22e4e8a01bcb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug 1704913 so that hardware interfaces of a node whose provision"},{"line_number":5,"context_line":"    state is ``available`` can be set by a PATCH request to the endpoint"},{"line_number":6,"context_line":"    ``v1/nodes/{node_ident}``."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f1a1f67_45dc23e3","line":4,"in_reply_to":"1f1a1f67_2248025a","updated":"2017-07-18 11:55:55.000000000","message":"I agree that this is not a bug. I removed the bug number since notes for features usually don\u0027t mention a bug number.","commit_id":"1b65d70124ac0627a0fb6b664c6bdd50b302640c"}]}
