)]}'
{"api-ref/source/baremetal-api-v1-nodes-ports.inc":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"070e59007bc2d00bc9c4df50782d0edc31ff3661","unresolved":false,"context_lines":[{"line_number":70,"context_line":"``pxe_enabled`` and ``local_link_connection`` response fields were added in API"},{"line_number":71,"context_line":"microversion 1.19."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"``portgroup`` query parameter and ``portgroup_uuid`` response field"},{"line_number":74,"context_line":"were added in API microversion 1.24."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"``physical_network`` response field was added in API microversion 1.34."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f1a1f67_d4f2b106","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":34},"updated":"2017-07-13 08:28:27.000000000","message":"this can be removed just like other places.","commit_id":"c75ae791ecc441840591bcae38457b3c5f7109f7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"03f4ab0cda2db72fe4d8025eb320a4cf00823f99","unresolved":false,"context_lines":[{"line_number":70,"context_line":"``pxe_enabled`` and ``local_link_connection`` response fields were added in API"},{"line_number":71,"context_line":"microversion 1.19."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"``portgroup`` query parameter and ``portgroup_uuid`` response field"},{"line_number":74,"context_line":"were added in API microversion 1.24."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"``physical_network`` response field was added in API microversion 1.34."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f1a1f67_0f8ff423","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":34},"in_reply_to":"1f1a1f67_d4f2b106","updated":"2017-07-13 09:03:34.000000000","message":"Done","commit_id":"c75ae791ecc441840591bcae38457b3c5f7109f7"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"0f6e52a128395b3e3e1ce30e1dde46ba20e9fd57","unresolved":false,"context_lines":[{"line_number":71,"context_line":"microversion 1.19."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"``portgroup_uuid`` response field was added in API microversion 1.24."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``physical_network`` response field was added in API microversion 1.34."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Normal response code: 200"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1f1a1f67_349eeeb8","line":74,"updated":"2017-07-18 15:50:23.000000000","message":"I have a minor suggestion about consistency.\nIt will be good to keep the sentence either active or passive.","commit_id":"6b5f82487cadece47932aa803d1b56ef9a0cc829"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"507aa85391668ce47d3d7a5df6306645bb86e707","unresolved":false,"context_lines":[{"line_number":71,"context_line":"microversion 1.19."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"``portgroup_uuid`` response field was added in API microversion 1.24."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``physical_network`` response field was added in API microversion 1.34."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Normal response code: 200"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1f1a1f67_ff972f39","line":74,"in_reply_to":"1f1a1f67_349eeeb8","updated":"2017-07-18 16:14:07.000000000","message":"Yes this annoyed me a little, just not quite enough to change!\n\nA quick survey suggests that active is predominant so I\u0027ll go with that.","commit_id":"6b5f82487cadece47932aa803d1b56ef9a0cc829"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1ac8a0b0e5dc9dcb1946a123deca67f1e1bd357b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"microversion 1.19."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"``portgroup_uuid`` response field was added in API microversion 1.24."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``physical_network`` response field was added in API microversion 1.34."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Normal response code: 200"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1f1a1f67_da810ac5","line":74,"in_reply_to":"1f1a1f67_ff972f39","updated":"2017-07-19 07:46:04.000000000","message":"Done","commit_id":"6b5f82487cadece47932aa803d1b56ef9a0cc829"}],"api-ref/source/baremetal-api-v1-portgroups-ports.inc":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"070e59007bc2d00bc9c4df50782d0edc31ff3661","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Return a list of bare metal Ports associated with ``portgroup_ident``."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"When specified, the ``fields`` Request parameter causes the content of the"},{"line_number":26,"context_line":"Response to include only the specified fields, rather than the default set."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"API microversion 1.34 added the ``physical_network`` field."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f1a1f67_d440710a","line":25,"updated":"2017-07-13 08:28:27.000000000","message":"the api microversion is not described here.","commit_id":"c75ae791ecc441840591bcae38457b3c5f7109f7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"03f4ab0cda2db72fe4d8025eb320a4cf00823f99","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Return a list of bare metal Ports associated with ``portgroup_ident``."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"When specified, the ``fields`` Request parameter causes the content of the"},{"line_number":26,"context_line":"Response to include only the specified fields, rather than the default set."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"API microversion 1.34 added the ``physical_network`` field."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f1a1f67_efbcb8bc","line":25,"in_reply_to":"1f1a1f67_d440710a","updated":"2017-07-13 09:03:34.000000000","message":"This endpoint was added in 1.24, so post-dates the addition of fields which was added in 1.8.","commit_id":"c75ae791ecc441840591bcae38457b3c5f7109f7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"800798b884c4e0d6a834e090787c4070d52038dc","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Return a list of bare metal Ports associated with ``portgroup_ident``."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"When specified, the ``fields`` Request parameter causes the content of the"},{"line_number":26,"context_line":"Response to include only the specified fields, rather than the default set."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"API microversion 1.34 added the ``physical_network`` field."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f1a1f67_aa9d8e5a","line":25,"in_reply_to":"1f1a1f67_efbcb8bc","updated":"2017-07-13 09:24:43.000000000","message":"That make sense, in fact I think there is no need to address \u0027fields\u0027 here, since it\u0027s a common feature not related to ports. I am fine whether keeping it or not.","commit_id":"c75ae791ecc441840591bcae38457b3c5f7109f7"}],"api-ref/source/baremetal-api-v1-ports.inc":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"19f0f6e77dc221b6d9dbaf8fe48e6328ae6ac767","unresolved":false,"context_lines":[{"line_number":35,"context_line":"API microversion 1.19 added the ``pxe_enabled`` and ``local_link_connection``"},{"line_number":36,"context_line":"fields."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. TODO: add pxe_enabled and local_link_connection to all sample files"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"API microversion 1.24 added the portgroup_uuid field."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1f1a1f67_63f85348","side":"PARENT","line":38,"updated":"2017-07-17 18:52:27.000000000","message":"I\u0027m being lazy; just want to confirm that you checked that these two fields were added to all sample files? (I suspect they had to be if you regenerated/added the physical_network field).","commit_id":"90272f149d2130ebb1fc1f5b3510e834c8f3c2ee"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e23d810556d697cc5ba74e6d83dca1105a898342","unresolved":false,"context_lines":[{"line_number":35,"context_line":"API microversion 1.19 added the ``pxe_enabled`` and ``local_link_connection``"},{"line_number":36,"context_line":"fields."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. TODO: add pxe_enabled and local_link_connection to all sample files"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"API microversion 1.24 added the portgroup_uuid field."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1f1a1f67_7fb451d1","side":"PARENT","line":38,"in_reply_to":"1f1a1f67_63f85348","updated":"2017-07-18 08:33:40.000000000","message":"Yes I did.","commit_id":"90272f149d2130ebb1fc1f5b3510e834c8f3c2ee"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"19f0f6e77dc221b6d9dbaf8fe48e6328ae6ac767","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"``portgroup_uuid`` response field was added in API microversion 1.24."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"``physical_network`` response field was added in API microversion 1.34."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Normal response code: 200"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1f1a1f67_03e87f79","line":262,"updated":"2017-07-17 18:52:27.000000000","message":"For the above -- the json patch in the request can include those fields as well, so maybe just remove s/response//","commit_id":"9a812b4bfe83fee92869ac6ac7d2bd71a5048881"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e23d810556d697cc5ba74e6d83dca1105a898342","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"``portgroup_uuid`` response field was added in API microversion 1.24."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"``physical_network`` response field was added in API microversion 1.34."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Normal response code: 200"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1f1a1f67_bf1ae9c8","line":262,"in_reply_to":"1f1a1f67_03e87f79","updated":"2017-07-18 08:33:40.000000000","message":"I changed to \u0027request and response\u0027 to be consistent with the rest of the file.","commit_id":"9a812b4bfe83fee92869ac6ac7d2bd71a5048881"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"0f6e52a128395b3e3e1ce30e1dde46ba20e9fd57","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"``physical_network`` request and response fields were added in API microversion"},{"line_number":92,"context_line":"1.34."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Normal response code: 201"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1f1a1f67_b4b1de49","line":93,"updated":"2017-07-18 15:50:23.000000000","message":"Ditto","commit_id":"6b5f82487cadece47932aa803d1b56ef9a0cc829"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1ac8a0b0e5dc9dcb1946a123deca67f1e1bd357b","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"``physical_network`` request and response fields were added in API microversion"},{"line_number":92,"context_line":"1.34."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Normal response code: 201"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"1f1a1f67_5a917af0","line":93,"in_reply_to":"1f1a1f67_b4b1de49","updated":"2017-07-19 07:46:04.000000000","message":"Done","commit_id":"6b5f82487cadece47932aa803d1b56ef9a0cc829"}]}