)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a9fa7fdbc422b309beffff819efeb48e17f16686","unresolved":false,"context_lines":[{"line_number":14,"context_line":"during deployment, so generating the boot script on start up should"},{"line_number":15,"context_line":"not harm any current functionality."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[0] Icfea16c62a753c77942107af287880f35f28c404"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id545d6cf93227cf1fc2ff0c05dbdceb8fb6aa5b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff346bd7_fbb0238e","line":17,"updated":"2017-07-21 19:42:45.000000000","message":"Please use git commit ids and not Change-Ids.\n\nThat way someone can just do:\n\n $ git show COMMIT_ID_VALUE\n\nOtherwise they need to grep the git log to figure out the commit.","commit_id":"87c8335efbae7937caabbf0fd66b361441f20a48"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"518b968ccf603b9895092d9a6b819e70e24eafac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"during deployment, so generating the boot script on start up should"},{"line_number":15,"context_line":"not harm any current functionality."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[0] Icfea16c62a753c77942107af287880f35f28c404"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id545d6cf93227cf1fc2ff0c05dbdceb8fb6aa5b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff346bd7_d8cbfe1b","line":17,"in_reply_to":"ff346bd7_fbb0238e","updated":"2017-07-24 12:25:27.000000000","message":"+1 since we effectively remove the effects of the merge.  We only want to note the changeid if we are crossing branches with a revert since our changeid will be the same.","commit_id":"87c8335efbae7937caabbf0fd66b361441f20a48"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6aafdada1ceea2c703be7100bd49e38ff4b0a5a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    # only write to file if its content is different from required,"},{"line_number":254,"context_line":"    # which should be rather rare"},{"line_number":255,"context_line":"    if (not os.path.isfile(bootfile_path) or"},{"line_number":256,"context_line":"        not utils.file_has_content(bootfile_path, boot_script)):"},{"line_number":257,"context_line":"        utils.write_to_file(bootfile_path, boot_script)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_816ce608","line":256,"updated":"2017-07-21 16:55:41.000000000","message":"I guess this is technically valid indentation, a little weird to read without the additional four spaces.  *shrugs*","commit_id":"87c8335efbae7937caabbf0fd66b361441f20a48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d2e36c23330f59ca7d3f4a9e4064f01b58b847e5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    # only write to file if its content is different from required,"},{"line_number":254,"context_line":"    # which should be rather rare"},{"line_number":255,"context_line":"    if (not os.path.isfile(bootfile_path) or"},{"line_number":256,"context_line":"        not utils.file_has_content(bootfile_path, boot_script)):"},{"line_number":257,"context_line":"        utils.write_to_file(bootfile_path, boot_script)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_9b4b57af","line":256,"in_reply_to":"1f1a1f67_816ce608","updated":"2017-07-21 19:41:16.000000000","message":"I prefer with the four extra spaces too :)","commit_id":"87c8335efbae7937caabbf0fd66b361441f20a48"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"3c783d5111957b0eb7e7cb4dc5186214b32c61b4","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        node \u003d task.node"},{"line_number":440,"context_line":"        deploy_utils.populate_storage_driver_internal_info(task)"},{"line_number":441,"context_line":"        if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":442,"context_line":"            # Adding the node to provisioning network so that the dhcp"},{"line_number":443,"context_line":"            # options get added for the provisioning port."},{"line_number":444,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":445,"context_line":"            if task.driver.storage.should_write_image(task):"},{"line_number":446,"context_line":"                # NOTE(vdrok): in case of rebuild, we have tenant network"},{"line_number":447,"context_line":"                # already configured, unbind tenant ports if present"},{"line_number":448,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":449,"context_line":"                task.driver.network.add_provisioning_network(task)"},{"line_number":450,"context_line":"            # Signal to storage driver to attach volumes"},{"line_number":451,"context_line":"            task.driver.storage.attach_volumes(task)"},{"line_number":452,"context_line":"            if not task.driver.storage.should_write_image(task):"},{"line_number":453,"context_line":"                # We have nothing else to do as this is handled in the"},{"line_number":454,"context_line":"                # backend storage system."},{"line_number":455,"context_line":"                return"},{"line_number":456,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":457,"context_line":"            # Call is due to conductor takeover"},{"line_number":458,"context_line":"            task.driver.boot.prepare_instance(task)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_9584ed5f","line":455,"range":{"start_line":442,"start_character":0,"end_line":455,"end_character":22},"updated":"2017-07-25 15:09:31.000000000","message":"Do we need to do the attach_volumes after the networks? If not then I would much prefer:\n\n manager_utils.node_power_action(task, states.POWER_OFF)\n task.driver.storage.attach_volumes(task)\n if not task.driver.storage.should_write_image(task):\n     return\n task.driver.network.unconfigure_tenant_networks(task)\n task.driver.network.add_provisioning_network(task)","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a9dbe186770206dd7880660e6a60c2497a4d1fae","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            if not task.driver.storage.should_write_image(task):"},{"line_number":453,"context_line":"                # We have nothing else to do as this is handled in the"},{"line_number":454,"context_line":"                # backend storage system."},{"line_number":455,"context_line":"                return"},{"line_number":456,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":457,"context_line":"            # Call is due to conductor takeover"},{"line_number":458,"context_line":"            task.driver.boot.prepare_instance(task)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_a39fdb4e","line":455,"updated":"2017-07-24 19:38:13.000000000","message":"Slight contextual addition: IF we are deploying, and we should not write an image, then we can return. This is in the same class of issue since we should only be calling this really during deployment logic, as it does not apply in other states, which is the class of bug that we encountered in prepare_ramdisk.\n\nNit: I feel like the commit message may want to mention this, but as-is, I\u0027m fine with it, but others may feel like some additional context is required here.","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afca140d290332f4a96d160411f5981246bad47c","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        node \u003d task.node"},{"line_number":440,"context_line":"        deploy_utils.populate_storage_driver_internal_info(task)"},{"line_number":441,"context_line":"        if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":442,"context_line":"            # Adding the node to provisioning network so that the dhcp"},{"line_number":443,"context_line":"            # options get added for the provisioning port."},{"line_number":444,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":445,"context_line":"            if task.driver.storage.should_write_image(task):"},{"line_number":446,"context_line":"                # NOTE(vdrok): in case of rebuild, we have tenant network"},{"line_number":447,"context_line":"                # already configured, unbind tenant ports if present"},{"line_number":448,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":449,"context_line":"                task.driver.network.add_provisioning_network(task)"},{"line_number":450,"context_line":"            # Signal to storage driver to attach volumes"},{"line_number":451,"context_line":"            task.driver.storage.attach_volumes(task)"},{"line_number":452,"context_line":"            if not task.driver.storage.should_write_image(task):"},{"line_number":453,"context_line":"                # We have nothing else to do as this is handled in the"},{"line_number":454,"context_line":"                # backend storage system."},{"line_number":455,"context_line":"                return"},{"line_number":456,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":457,"context_line":"            # Call is due to conductor takeover"},{"line_number":458,"context_line":"            task.driver.boot.prepare_instance(task)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_24b98de8","line":455,"range":{"start_line":442,"start_character":0,"end_line":455,"end_character":22},"in_reply_to":"ff346bd7_9584ed5f","updated":"2017-07-25 17:10:07.000000000","message":"Presently, we do not.  However we may reach the point with vendor drivers where we have BMCs that require the ability to validate connectivity when configured. I suspect if we change it, we will see someone change it again with a vendor driver.\n\nAnother case that pops in my head is if the operator has specific interfaces defined to be the connectors, where we might not have the IP addresses if they are neutron managed, which is supported in part by the deferred nova patch.","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"a0f4728e4f9a93885bcdaf2390492e8f0c7b42d1","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def __init__(self):"},{"line_number":377,"context_line":"        self.capabilities \u003d [\u0027iscsi_volume_boot\u0027]"},{"line_number":378,"context_line":"        if CONF.ipxe_enabled:"},{"line_number":379,"context_line":"            pxe_utils.create_ipxe_boot_script()"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_52631143","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":29},"updated":"2017-07-14 20:19:50.000000000","message":"Should be CONF.pxe.ipxe_enabled\n\nHence the huge amount of failures. Whoops!","commit_id":"3b0bdf528f5b4301bdfd3491d7b4c12230e1cc11"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6aafdada1ceea2c703be7100bd49e38ff4b0a5a","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                os.path.basename(CONF.pxe.ipxe_boot_script))"},{"line_number":469,"context_line":"            # NOTE(pas-ha) to prevent unneeded writes,"},{"line_number":470,"context_line":"            # only write to file if its content is different from required,"},{"line_number":471,"context_line":"            # which should be rather rare"},{"line_number":472,"context_line":"            if (not os.path.isfile(bootfile_path) or"},{"line_number":473,"context_line":"                not utils.file_has_content(bootfile_path, boot_script)):"},{"line_number":474,"context_line":"                    utils.write_to_file(bootfile_path, boot_script)"},{"line_number":475,"context_line":"            if not task.driver.storage.should_write_image(task):"},{"line_number":476,"context_line":"                return"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_640b1824","side":"PARENT","line":474,"range":{"start_line":471,"start_character":10,"end_line":474,"end_character":67},"updated":"2017-07-21 16:55:41.000000000","message":"This was here prior, and I kind of feel like it is still a good idea to assert the file exists just in case.  Truthfully, it has caused me some headaches with bifrost, and maybe this is going a bit far to keep doing it after init....","commit_id":"a1cbfa5be0a93d7a9ed644464af97d39479db28a"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d2e36c23330f59ca7d3f4a9e4064f01b58b847e5","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":539,"context_line":"    def test_create_ipxe_boot_script(self, render_mock, write_mock,"},{"line_number":540,"context_line":"                                     cmp_mock, isfile_mock):"},{"line_number":541,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":542,"context_line":"        self.assertFalse(cmp_mock.called)"},{"line_number":543,"context_line":"        pxe_utils.create_ipxe_boot_script()"},{"line_number":544,"context_line":"        write_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_1ba3e751","line":541,"updated":"2017-07-21 19:41:16.000000000","message":"Adding the line:\n\n render_mock.return_value \u003d \"foo\"\n\nWill fix the unit test error","commit_id":"87c8335efbae7937caabbf0fd66b361441f20a48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d2e36c23330f59ca7d3f4a9e4064f01b58b847e5","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        write_mock.assert_called_once_with("},{"line_number":545,"context_line":"            os.path.join(CONF.deploy.http_root,"},{"line_number":546,"context_line":"                         os.path.basename(CONF.pxe.ipxe_boot_script)),"},{"line_number":547,"context_line":"            \u0027foo\u0027)"},{"line_number":548,"context_line":"        render_mock.assert_called_once_with("},{"line_number":549,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":550,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_3be90b80","line":547,"updated":"2017-07-21 19:41:16.000000000","message":"If create a return value for render_mock, then can use that value here.","commit_id":"87c8335efbae7937caabbf0fd66b361441f20a48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        rmtree_mock.assert_called_once_with("},{"line_number":533,"context_line":"            os.path.join(CONF.pxe.tftp_root, self.node.uuid))"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":536,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":537,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":538,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_99856ab0","line":535,"updated":"2017-07-24 21:09:45.000000000","message":"nit: Can do this since aren\u0027t checking if it is called or not called.\n\n @mock.patch.object(os.path, \u0027isfile\u0027, lambda path: False)\n\nThe don\u0027t need to add it to the list of arguments and it will return True","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        rmtree_mock.assert_called_once_with("},{"line_number":533,"context_line":"            os.path.join(CONF.pxe.tftp_root, self.node.uuid))"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":536,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":537,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":538,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_b384c25f","line":535,"in_reply_to":"ff346bd7_99856ab0","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":538,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":539,"context_line":"    def test_create_ipxe_boot_script(self, render_mock, write_mock,"},{"line_number":540,"context_line":"                                     cmp_mock, isfile_mock):"},{"line_number":541,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":542,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":543,"context_line":"        self.assertFalse(cmp_mock.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_b976eed7","line":540,"range":{"start_line":540,"start_character":37,"end_line":540,"end_character":45},"updated":"2017-07-24 21:09:45.000000000","message":"Why is it named \u0027cmp_mock\u0027? the function is \u0027file_has_content\u0027","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":538,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":539,"context_line":"    def test_create_ipxe_boot_script(self, render_mock, write_mock,"},{"line_number":540,"context_line":"                                     cmp_mock, isfile_mock):"},{"line_number":541,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":542,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":543,"context_line":"        self.assertFalse(cmp_mock.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_93ec1e2a","line":540,"range":{"start_line":540,"start_character":37,"end_line":540,"end_character":45},"in_reply_to":"ff346bd7_b976eed7","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                                     cmp_mock, isfile_mock):"},{"line_number":541,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":542,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":543,"context_line":"        self.assertFalse(cmp_mock.called)"},{"line_number":544,"context_line":"        pxe_utils.create_ipxe_boot_script()"},{"line_number":545,"context_line":"        write_mock.assert_called_once_with("},{"line_number":546,"context_line":"            os.path.join(CONF.deploy.http_root,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_39955ee5","line":543,"updated":"2017-07-24 21:09:45.000000000","message":"Should be this I think:\n\n cmp_mock.assert_not_called()","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                                     cmp_mock, isfile_mock):"},{"line_number":541,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":542,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":543,"context_line":"        self.assertFalse(cmp_mock.called)"},{"line_number":544,"context_line":"        pxe_utils.create_ipxe_boot_script()"},{"line_number":545,"context_line":"        write_mock.assert_called_once_with("},{"line_number":546,"context_line":"            os.path.join(CONF.deploy.http_root,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_b3e9621b","line":543,"in_reply_to":"ff346bd7_39955ee5","updated":"2017-07-25 03:58:27.000000000","message":"Doesn\u0027t work.  It states that the function is not available on the attribute. *shrugs*","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b4fda20a7f8755b7fb1bb5b9a0b878a9795bc9e0","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                                     cmp_mock, isfile_mock):"},{"line_number":541,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":542,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":543,"context_line":"        self.assertFalse(cmp_mock.called)"},{"line_number":544,"context_line":"        pxe_utils.create_ipxe_boot_script()"},{"line_number":545,"context_line":"        write_mock.assert_called_once_with("},{"line_number":546,"context_line":"            os.path.join(CONF.deploy.http_root,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_a4c116e7","line":543,"in_reply_to":"ff346bd7_b3e9621b","updated":"2017-07-25 05:47:15.000000000","message":"Oh yeah I forgot about this bug :(\n\nhttps://bugs.python.org/issue28380","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":550,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":551,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":554,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":555,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":556,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_7992c6f8","line":553,"updated":"2017-07-24 21:09:45.000000000","message":"Same as line 535","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":550,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":551,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":554,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":555,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":556,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_93d53e46","line":553,"in_reply_to":"ff346bd7_7992c6f8","updated":"2017-07-25 03:58:27.000000000","message":"Well, True. :)","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":555,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":556,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":557,"context_line":"    def test_create_ipxe_boot_script_copy_file_different("},{"line_number":558,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":559,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":560,"context_line":"        cmp_mock.return_value \u003d False"},{"line_number":561,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_f96c7609","line":558,"range":{"start_line":558,"start_character":43,"end_line":558,"end_character":51},"updated":"2017-07-24 21:09:45.000000000","message":"Why is it named \u0027cmp_mock\u0027? the function is \u0027file_has_content\u0027","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":555,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":556,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":557,"context_line":"    def test_create_ipxe_boot_script_copy_file_different("},{"line_number":558,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":559,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":560,"context_line":"        cmp_mock.return_value \u003d False"},{"line_number":561,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_5344761b","line":558,"range":{"start_line":558,"start_character":43,"end_line":558,"end_character":51},"in_reply_to":"ff346bd7_f96c7609","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    def test_create_ipxe_boot_script_copy_file_different("},{"line_number":558,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":559,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":560,"context_line":"        cmp_mock.return_value \u003d False"},{"line_number":561,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":562,"context_line":"        self.assertFalse(cmp_mock.called)"},{"line_number":563,"context_line":"        pxe_utils.create_ipxe_boot_script()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_7980868c","line":560,"updated":"2017-07-24 21:09:45.000000000","message":"Should be this I think:\n\n cmp_mock.assert_not_called()","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":570,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":573,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":574,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":575,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_19c3baef","line":572,"updated":"2017-07-24 21:09:45.000000000","message":"Same as line 535","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":573,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":574,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":575,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":576,"context_line":"    def test_create_ipxe_boot_script_already_exists(self, render_mock,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_f9b7d685","line":573,"updated":"2017-07-24 21:09:45.000000000","message":"Same as line 535","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":575,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":576,"context_line":"    def test_create_ipxe_boot_script_already_exists(self, render_mock,"},{"line_number":577,"context_line":"                                                    write_mock, cmp_mock,"},{"line_number":578,"context_line":"                                                    isfile_mock):"},{"line_number":579,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":580,"context_line":"        cmp_mock.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_99ae8a2c","line":577,"range":{"start_line":577,"start_character":64,"end_line":577,"end_character":72},"updated":"2017-07-24 21:09:45.000000000","message":"Why is it named \u0027cmp_mock\u0027? the function is \u0027file_has_content\u0027","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6a4bdf4ad0cabd317688100aa696078ef54b0f4a","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":580,"context_line":"        cmp_mock.return_value \u003d True"},{"line_number":581,"context_line":"        pxe_utils.create_ipxe_boot_script()"},{"line_number":582,"context_line":"        self.assertFalse(write_mock.called)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    def test__get_pxe_mac_path(self):"},{"line_number":585,"context_line":"        mac \u003d \u002700:11:22:33:44:55:66\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_394c3e9d","line":582,"updated":"2017-07-24 21:09:45.000000000","message":"Should be this I think:\n\n write_mock.assert_not_called()","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6aafdada1ceea2c703be7100bd49e38ff4b0a5a","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            self.driver.prepare(task)"},{"line_number":449,"context_line":"            build_instance_info_mock.assert_not_called()"},{"line_number":450,"context_line":"            build_options_mock.assert_not_called()"},{"line_number":451,"context_line":"            pxe_prepare_ramdisk_mock.assert_called_once_with(task, None)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    @mock.patch(\u0027ironic.common.dhcp_factory.DHCPFactory._set_dhcp_provider\u0027)"},{"line_number":454,"context_line":"    @mock.patch(\u0027ironic.common.dhcp_factory.DHCPFactory.clean_dhcp\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_043584da","side":"PARENT","line":451,"updated":"2017-07-21 16:55:41.000000000","message":"I feel like most of the test is valid, although the pxe_prepare_ramdisk_mock with the called once check doesn\u0027t seem valid.","commit_id":"a1cbfa5be0a93d7a9ed644464af97d39479db28a"}],"ironic/tests/unit/drivers/modules/test_pxe.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6aafdada1ceea2c703be7100bd49e38ff4b0a5a","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            os.path.join("},{"line_number":996,"context_line":"                CONF.deploy.http_root,"},{"line_number":997,"context_line":"                os.path.basename(CONF.pxe.ipxe_boot_script)),"},{"line_number":998,"context_line":"            \u0027foo\u0027)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":1001,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_24a9a0dc","side":"PARENT","line":998,"updated":"2017-07-21 16:55:41.000000000","message":"Completely removing these tests doesn\u0027t seem intentional?  Looks like you started refactoring down and didn\u0027t add the tests back.","commit_id":"a1cbfa5be0a93d7a9ed644464af97d39479db28a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        self.node.save()"},{"line_number":881,"context_line":"        self._test_prepare_ramdisk(uefi\u003dTrue)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":884,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":885,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":886,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_79ac068c","line":883,"updated":"2017-07-24 21:05:50.000000000","message":"nit: Can do this since aren\u0027t checking if it is called or not called.\n\n @mock.patch.object(os.path, \u0027isfile\u0027, lambda path: True)\n\nThe don\u0027t need to add it to the list of arguments and it will return True","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7449c8453a2d65e40b47e420178f5baea384ce70","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        self.node.save()"},{"line_number":881,"context_line":"        self._test_prepare_ramdisk(uefi\u003dTrue)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":884,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":885,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":886,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_a47c76eb","line":883,"in_reply_to":"ff346bd7_535fd671","updated":"2017-07-25 05:40:23.000000000","message":"Ah, yeah. I was comparing revision 3 to 5. My mistake. Must have been a rebase in their.","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        self.node.save()"},{"line_number":881,"context_line":"        self._test_prepare_ramdisk(uefi\u003dTrue)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":884,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":885,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":886,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_535fd671","line":883,"in_reply_to":"ff346bd7_79ac068c","updated":"2017-07-25 03:58:27.000000000","message":"Gerrit is telling me that this was not changed, and thus really should have been addressed in another patch.","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        self._test_prepare_ramdisk(uefi\u003dTrue)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":884,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":885,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":886,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":887,"context_line":"    def test_prepare_ramdisk_ipxe_with_copy_file_different("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_b9270e13","line":884,"updated":"2017-07-24 21:05:50.000000000","message":"Same as line 883","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":885,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":886,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":887,"context_line":"    def test_prepare_ramdisk_ipxe_with_copy_file_different("},{"line_number":888,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":889,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":890,"context_line":"        self.node.save()"},{"line_number":891,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_59d702ef","line":888,"range":{"start_line":888,"start_character":43,"end_line":888,"end_character":51},"updated":"2017-07-24 21:05:50.000000000","message":"Why is it named \u0027cmp_mock\u0027? the function is \u0027file_has_content\u0027","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":885,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":886,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":887,"context_line":"    def test_prepare_ramdisk_ipxe_with_copy_file_different("},{"line_number":888,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":889,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":890,"context_line":"        self.node.save()"},{"line_number":891,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_1e0ef531","line":888,"range":{"start_line":888,"start_character":43,"end_line":888,"end_character":51},"in_reply_to":"ff346bd7_59d702ef","updated":"2017-07-25 03:58:27.000000000","message":"Uhh.. Yeah....","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":903,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":904,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":907,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":908,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":909,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_197e1ae4","line":906,"updated":"2017-07-24 21:05:50.000000000","message":"Same as line 883","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":903,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":904,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":907,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":908,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":909,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_93f3fe73","line":906,"in_reply_to":"ff346bd7_197e1ae4","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":908,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":909,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":910,"context_line":"    def test_prepare_ramdisk_ipxe_with_copy_no_file("},{"line_number":911,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":912,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":913,"context_line":"        self.node.save()"},{"line_number":914,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_190bba8e","line":911,"range":{"start_line":911,"start_character":43,"end_line":911,"end_character":51},"updated":"2017-07-24 21:05:50.000000000","message":"Why is it named \u0027cmp_mock\u0027? the function is \u0027file_has_content\u0027","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":908,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":909,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":910,"context_line":"    def test_prepare_ramdisk_ipxe_with_copy_no_file("},{"line_number":911,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":912,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":913,"context_line":"        self.node.save()"},{"line_number":914,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_1e3715e6","line":911,"range":{"start_line":911,"start_character":43,"end_line":911,"end_character":51},"in_reply_to":"ff346bd7_190bba8e","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        isfile_mock.return_value \u003d False"},{"line_number":917,"context_line":"        render_mock.return_value \u003d \u0027foo\u0027"},{"line_number":918,"context_line":"        self._test_prepare_ramdisk()"},{"line_number":919,"context_line":"        self.assertFalse(cmp_mock.called)"},{"line_number":920,"context_line":"        write_mock.assert_called_once_with("},{"line_number":921,"context_line":"            os.path.join("},{"line_number":922,"context_line":"                CONF.deploy.http_root,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_f9e91680","line":919,"updated":"2017-07-24 21:05:50.000000000","message":"Should be this I think:\n\n cmp_mock.assert_not_called()","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":926,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":927,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":930,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":931,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":932,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_3979defb","line":929,"updated":"2017-07-24 21:05:50.000000000","message":"Same as line 883","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":926,"context_line":"            CONF.pxe.ipxe_boot_script,"},{"line_number":927,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":930,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":931,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":932,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_7e7061a6","line":929,"in_reply_to":"ff346bd7_3979defb","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":930,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":931,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":932,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":933,"context_line":"    def test_prepare_ramdisk_ipxe_without_copy("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_7921a6fb","line":930,"updated":"2017-07-24 21:05:50.000000000","message":"Same as line 883","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            {\u0027ipxe_for_mac_uri\u0027: \u0027pxelinux.cfg/\u0027})"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, autospec\u003dTrue)"},{"line_number":930,"context_line":"    @mock.patch(\u0027ironic.common.utils.file_has_content\u0027, autospec\u003dTrue)"},{"line_number":931,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":932,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":933,"context_line":"    def test_prepare_ramdisk_ipxe_without_copy("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_be76c9a3","line":930,"in_reply_to":"ff346bd7_7921a6fb","updated":"2017-07-25 03:58:27.000000000","message":"Done","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":931,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":932,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":933,"context_line":"    def test_prepare_ramdisk_ipxe_without_copy("},{"line_number":934,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":935,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":936,"context_line":"        self.node.save()"},{"line_number":937,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_b9f94e81","line":934,"range":{"start_line":934,"start_character":43,"end_line":934,"end_character":51},"updated":"2017-07-24 21:05:50.000000000","message":"Why is it named \u0027cmp_mock\u0027? the function is \u0027file_has_content\u0027","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":931,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":932,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":933,"context_line":"    def test_prepare_ramdisk_ipxe_without_copy("},{"line_number":934,"context_line":"            self, render_mock, write_mock, cmp_mock, isfile_mock):"},{"line_number":935,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":936,"context_line":"        self.node.save()"},{"line_number":937,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_fe3571db","line":934,"range":{"start_line":934,"start_character":43,"end_line":934,"end_character":51},"in_reply_to":"ff346bd7_b9f94e81","updated":"2017-07-25 03:58:27.000000000","message":"Requested to be removed...","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":940,"context_line":"        cmp_mock.return_value \u003d True"},{"line_number":941,"context_line":"        self._test_prepare_ramdisk()"},{"line_number":942,"context_line":"        self.assertFalse(write_mock.called)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":945,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_39f0be67","line":942,"updated":"2017-07-24 21:05:50.000000000","message":"Should be this I think:\n\n write_mock.assert_not_called()","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5292f53d9a1752c85a97016b1d96e65633d375d0","unresolved":false,"context_lines":[{"line_number":939,"context_line":"        isfile_mock.return_value \u003d True"},{"line_number":940,"context_line":"        cmp_mock.return_value \u003d True"},{"line_number":941,"context_line":"        self._test_prepare_ramdisk()"},{"line_number":942,"context_line":"        self.assertFalse(write_mock.called)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":945,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_be4da973","line":942,"in_reply_to":"ff346bd7_39f0be67","updated":"2017-07-25 03:58:27.000000000","message":"skipping since this didn\u0027t work on the common utils change.","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        self.assertFalse(write_mock.called)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":945,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":946,"context_line":"    def test_prepare_ramdisk_ipxe_swift(self, render_mock, write_mock):"},{"line_number":947,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":948,"context_line":"        self.node.save()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_d98772d7","line":945,"updated":"2017-07-24 21:05:50.000000000","message":"Same as line 883","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8f34c1874cb1bd7f815f10fc006b7a9d2a0293","unresolved":false,"context_lines":[{"line_number":958,"context_line":"            \u0027foo\u0027)"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"    @mock.patch(\u0027ironic.common.utils.write_to_file\u0027, autospec\u003dTrue)"},{"line_number":961,"context_line":"    @mock.patch(\u0027ironic.common.utils.render_template\u0027, autospec\u003dTrue)"},{"line_number":962,"context_line":"    def test_prepare_ramdisk_ipxe_swift_whole_disk_image("},{"line_number":963,"context_line":"            self, render_mock, write_mock):"},{"line_number":964,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_b96cae36","line":961,"updated":"2017-07-24 21:05:50.000000000","message":"Same as line 883","commit_id":"afb7431cac1b6b9791dc98b0524bf76d2f4023fd"}]}
