)]}'
{"ironic/api/controllers/v1/portgroup.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3677179c1ce350c6b8bca1e66563cff382593c9b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    \"\"\"Indicates whether ports of this portgroup may be used as"},{"line_number":99,"context_line":"       single NIC ports\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    mode \u003d wtypes.Enum(str, *fields.PortgroupMode.ALL)"},{"line_number":102,"context_line":"    \"\"\"The mode for this portgroup. See linux bonding"},{"line_number":103,"context_line":"    documentation for details:"},{"line_number":104,"context_line":"    https://www.kernel.org/doc/Documentation/networking/bonding.txt\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_10f4d5ce","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":22},"updated":"2017-07-20 11:28:01.000000000","message":"i quite doubt it can be changed in this way, it\u0027s incompatible with old versions.\nand surely api microversion must be bumped.","commit_id":"c7f75b36074954d3c3dcda1a7f90a6fe244a28bb"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"98b7d802d125c6767c4b3f72b33b48b712fe82af","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    \"\"\"Indicates whether ports of this portgroup may be used as"},{"line_number":99,"context_line":"       single NIC ports\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    mode \u003d wtypes.Enum(str, *fields.PortgroupMode.ALL)"},{"line_number":102,"context_line":"    \"\"\"The mode for this portgroup. See linux bonding"},{"line_number":103,"context_line":"    documentation for details:"},{"line_number":104,"context_line":"    https://www.kernel.org/doc/Documentation/networking/bonding.txt\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_356435b9","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":22},"in_reply_to":"1f1a1f67_10f4d5ce","updated":"2017-07-21 11:36:14.000000000","message":"I will fix it in next patchset.","commit_id":"c7f75b36074954d3c3dcda1a7f90a6fe244a28bb"}],"ironic/objects/portgroup.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3677179c1ce350c6b8bca1e66563cff382593c9b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":46,"context_line":"        \u0027internal_info\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027standalone_ports_supported\u0027: object_fields.BooleanField(),"},{"line_number":48,"context_line":"        \u0027mode\u0027: object_fields.PortgroupModeField(nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027properties\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_306b5120","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":48},"updated":"2017-07-20 11:28:01.000000000","message":"field types cannot be changed, you can refer to the code contribution guide in ironic docs.\nrpc object version bump is also required, if changed.\nnow we have rolling upgrade, things are getting tough here, it seems to me that, keeping string type is capable to handle this bug, WDT?","commit_id":"c7f75b36074954d3c3dcda1a7f90a6fe244a28bb"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"98b7d802d125c6767c4b3f72b33b48b712fe82af","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":46,"context_line":"        \u0027internal_info\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027standalone_ports_supported\u0027: object_fields.BooleanField(),"},{"line_number":48,"context_line":"        \u0027mode\u0027: object_fields.PortgroupModeField(nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027properties\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_956c299d","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":48},"in_reply_to":"1f1a1f67_306b5120","updated":"2017-07-21 11:36:14.000000000","message":"No string type won\u0027t handle this case.\nI will read the doc and provide an update.","commit_id":"c7f75b36074954d3c3dcda1a7f90a6fe244a28bb"}]}