)]}'
{"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett Packard Development Company, LP"},{"line_number":2,"context_line":"# Copyright 2015 Universidade Federal de Campina Grande"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_7cfc5b6f","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":55},"updated":"2017-07-28 12:59:28.000000000","message":"# Copyright (2015-2017) Hewlett Packard Enterprise Development LP\n# Copyright (2015-2017) Universidade Federal de Campina Grande","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett Packard Development Company, LP"},{"line_number":2,"context_line":"# Copyright 2015 Universidade Federal de Campina Grande"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_ece2882f","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":55},"in_reply_to":"ff346bd7_7cfc5b6f","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"def update_ironic_port_mac(task, server_profile, server_hardware):"},{"line_number":232,"context_line":"    macs \u003d get_server_hardware_macs(server_hardware)"},{"line_number":233,"context_line":"    for connection in server_profile.connections:"},{"line_number":234,"context_line":"        for port in task.ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_9c293f38","line":231,"range":{"start_line":231,"start_character":4,"end_line":231,"end_character":26},"updated":"2017-07-28 12:59:28.000000000","message":"Please, add doctrings. Add the expected exceptions as well.","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"def update_ironic_port_mac(task, server_profile, server_hardware):"},{"line_number":232,"context_line":"    macs \u003d get_server_hardware_macs(server_hardware)"},{"line_number":233,"context_line":"    for connection in server_profile.connections:"},{"line_number":234,"context_line":"        for port in task.ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_ccd1045a","line":231,"range":{"start_line":231,"start_character":4,"end_line":231,"end_character":26},"in_reply_to":"ff346bd7_9c293f38","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                port.save()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"def get_server_hardware_macs(server_hardware):"},{"line_number":248,"context_line":"    macs \u003d {}"},{"line_number":249,"context_line":"    for device in server_hardware.port_map.get(\u0027deviceSlots\u0027):"},{"line_number":250,"context_line":"        device_location \u003d device.get(\u0027location\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_bc264367","line":247,"range":{"start_line":247,"start_character":4,"end_line":247,"end_character":28},"updated":"2017-07-28 12:59:28.000000000","message":"Too complex to don\u0027t have a docstring. Please, add them and a sample of the resultant dictionary.","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                port.save()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"def get_server_hardware_macs(server_hardware):"},{"line_number":248,"context_line":"    macs \u003d {}"},{"line_number":249,"context_line":"    for device in server_hardware.port_map.get(\u0027deviceSlots\u0027):"},{"line_number":250,"context_line":"        device_location \u003d device.get(\u0027location\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_acd6d04e","line":247,"range":{"start_line":247,"start_character":4,"end_line":247,"end_character":28},"in_reply_to":"ff346bd7_bc264367","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                for virtual_port in physical_port.get(\u0027virtualPorts\u0027):"},{"line_number":256,"context_line":"                    if virtual_port.get(\u0027portFunction\u0027) \u003d\u003d \u0027a\u0027:"},{"line_number":257,"context_line":"                        # aa:aa:bb: 1:1-a, aa:aa:bb: 1:2-a"},{"line_number":258,"context_line":"                        port_identifier \u003d str(device_location) + \u0027 \u0027 \\"},{"line_number":259,"context_line":"                            + str(slot_number) + \u0027:\u0027 + str(port_number) + \u0027-a\u0027"},{"line_number":260,"context_line":"                        macs[port_identifier] \u003d virtual_port.get(\u0027mac\u0027).lower()"},{"line_number":261,"context_line":"    return macs"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_bc3f6385","line":258,"range":{"start_line":258,"start_character":69,"end_line":258,"end_character":70},"updated":"2017-07-28 12:59:28.000000000","message":"Some time ago we have removed this from most part of ironic code. Let\u0027s avoid doing this and make the world a better place. :)","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                for virtual_port in physical_port.get(\u0027virtualPorts\u0027):"},{"line_number":256,"context_line":"                    if virtual_port.get(\u0027portFunction\u0027) \u003d\u003d \u0027a\u0027:"},{"line_number":257,"context_line":"                        # aa:aa:bb: 1:1-a, aa:aa:bb: 1:2-a"},{"line_number":258,"context_line":"                        port_identifier \u003d str(device_location) + \u0027 \u0027 \\"},{"line_number":259,"context_line":"                            + str(slot_number) + \u0027:\u0027 + str(port_number) + \u0027-a\u0027"},{"line_number":260,"context_line":"                        macs[port_identifier] \u003d virtual_port.get(\u0027mac\u0027).lower()"},{"line_number":261,"context_line":"    return macs"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_8ccb0ca4","line":258,"range":{"start_line":258,"start_character":69,"end_line":258,"end_character":70},"in_reply_to":"ff346bd7_bc3f6385","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"def remove_neutron_ports(task):"},{"line_number":265,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":266,"context_line":"        task.driver.network.remove_cleaning_network(task)"},{"line_number":267,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":268,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_9cf49ff2","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":57},"updated":"2017-07-28 12:59:28.000000000","message":"Considering ironic has flat, neutron and noop interfaces, I think it can bring us some unexpected behaviors if we don\u0027t check which interface is being used at this time. Currently, they have the same implementation, it may change in the future. Does it make sense?","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"def remove_neutron_ports(task):"},{"line_number":265,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":266,"context_line":"        task.driver.network.remove_cleaning_network(task)"},{"line_number":267,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":268,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_8c40ac09","line":266,"range":{"start_line":266,"start_character":8,"end_line":266,"end_character":57},"in_reply_to":"ff346bd7_9cf49ff2","updated":"2017-09-21 16:51:53.000000000","message":"It does make sense. Now it is updating the MAC address of the VIFs attached to the Ironic Ports, instead of removing and adding it.","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":266,"context_line":"        task.driver.network.remove_cleaning_network(task)"},{"line_number":267,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":268,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def add_neutron_ports(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_7cdfbb68","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":61},"updated":"2017-07-28 12:59:28.000000000","message":"ditto","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":266,"context_line":"        task.driver.network.remove_cleaning_network(task)"},{"line_number":267,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":268,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def add_neutron_ports(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_6c457817","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":61},"in_reply_to":"ff346bd7_7cdfbb68","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def add_neutron_ports(task):"},{"line_number":272,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":273,"context_line":"        task.driver.network.add_cleaning_network(task)"},{"line_number":274,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":275,"context_line":"        task.driver.network.remove_provisioning_network(task)"},{"line_number":276,"context_line":"        task.driver.network.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_3ce5b338","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":54},"updated":"2017-07-28 12:59:28.000000000","message":"ditto","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def add_neutron_ports(task):"},{"line_number":272,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":273,"context_line":"        task.driver.network.add_cleaning_network(task)"},{"line_number":274,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":275,"context_line":"        task.driver.network.remove_provisioning_network(task)"},{"line_number":276,"context_line":"        task.driver.network.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_4c4ab427","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":54},"in_reply_to":"ff346bd7_3ce5b338","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":273,"context_line":"        task.driver.network.add_cleaning_network(task)"},{"line_number":274,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":275,"context_line":"        task.driver.network.remove_provisioning_network(task)"},{"line_number":276,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"def node_has_server_profile(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_fcd4cb49","line":276,"range":{"start_line":275,"start_character":8,"end_line":276,"end_character":59},"updated":"2017-07-28 12:59:28.000000000","message":"ditto","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    if(task.node.provision_state in (states.CLEANING, states.CLEANWAIT)):"},{"line_number":273,"context_line":"        task.driver.network.add_cleaning_network(task)"},{"line_number":274,"context_line":"    elif(task.node.provision_state in (states.DEPLOYING, states.DEPLOYWAIT)):"},{"line_number":275,"context_line":"        task.driver.network.remove_provisioning_network(task)"},{"line_number":276,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"def node_has_server_profile(func):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_2c478020","line":276,"range":{"start_line":275,"start_character":8,"end_line":276,"end_character":59},"in_reply_to":"ff346bd7_fcd4cb49","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"}],"ironic/drivers/modules/oneview/deploy_utils.py":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development LP."},{"line_number":2,"context_line":"# Copyright 2016 Universidade Federal de Campina Grande"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_fc2debfd","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":22},"updated":"2017-07-28 12:59:28.000000000","message":"# Copyright (2015-2017) Hewlett Packard Enterprise Development LP\n# Copyright (2015-2017) Universidade Federal de Campina Grande","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"629ee6919f2ba1e46dd270e29e76167db1d6e00a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development LP."},{"line_number":2,"context_line":"# Copyright 2016 Universidade Federal de Campina Grande"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_ac3250a6","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":22},"in_reply_to":"ff346bd7_fc2debfd","updated":"2017-09-21 16:51:53.000000000","message":"Done","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":279,"context_line":"           name"},{"line_number":280,"context_line":"    :raises OneViewError: if an error occurs while allocating the Server"},{"line_number":281,"context_line":"            Hardware to ironic"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    node_in_use_by_oneview \u003d is_node_in_use_by_oneview("},{"line_number":285,"context_line":"        oneview_client, task.node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_5c3cf72d","line":282,"range":{"start_line":282,"start_character":0,"end_line":282,"end_character":0},"updated":"2017-07-28 12:59:28.000000000","message":"It may raise new exceptions, right?","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                server_profile_name, sh_uuid, spt_uuid"},{"line_number":330,"context_line":"            )"},{"line_number":331,"context_line":"            if applied_profile.macType \u003d\u003d \u0027Virtual\u0027:"},{"line_number":332,"context_line":"                LOG.warning(\u0027Server Profile is using virtual MAC. OneView \u0027"},{"line_number":333,"context_line":"                            \u0027will update the Ironic/Neutron port MAC.\u0027)"},{"line_number":334,"context_line":"                common.remove_neutron_ports(task)"},{"line_number":335,"context_line":"                common.update_ironic_port_mac("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_dcc10756","line":332,"range":{"start_line":332,"start_character":20,"end_line":332,"end_character":27},"updated":"2017-07-28 12:59:28.000000000","message":"nit: s/warning/info/?","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                server_profile_name, sh_uuid, spt_uuid"},{"line_number":330,"context_line":"            )"},{"line_number":331,"context_line":"            if applied_profile.macType \u003d\u003d \u0027Virtual\u0027:"},{"line_number":332,"context_line":"                LOG.warning(\u0027Server Profile is using virtual MAC. OneView \u0027"},{"line_number":333,"context_line":"                            \u0027will update the Ironic/Neutron port MAC.\u0027)"},{"line_number":334,"context_line":"                common.remove_neutron_ports(task)"},{"line_number":335,"context_line":"                common.update_ironic_port_mac("},{"line_number":336,"context_line":"                    task, applied_profile, server_hardware)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_fcd5eb1c","line":333,"range":{"start_line":332,"start_character":28,"end_line":333,"end_character":71},"updated":"2017-07-28 12:59:28.000000000","message":"nit: add the mac address to the message?","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                common.update_ironic_port_mac("},{"line_number":336,"context_line":"                    task, applied_profile, server_hardware)"},{"line_number":337,"context_line":"                common.add_neutron_ports(task)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"            _add_applied_server_profile_uri_field(task.node, applied_profile)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"            LOG.info("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_3ceff3e9","line":338,"range":{"start_line":338,"start_character":0,"end_line":338,"end_character":0},"updated":"2017-07-28 12:59:28.000000000","message":"What about a new log for logging the new mac address? I\u0027d like to see that.","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    :param node: an ironic node object"},{"line_number":364,"context_line":"    :raises OneViewError: if an error occurs while deallocating the Server"},{"line_number":365,"context_line":"            Hardware to ironic"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    \"\"\""},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    if is_node_in_use_by_ironic(oneview_client, task.node):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_fc160ba8","line":366,"range":{"start_line":366,"start_character":0,"end_line":366,"end_character":0},"updated":"2017-07-28 12:59:28.000000000","message":"ditto","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"26595a1c9222bd82a7dca7ffeaf25859b093c205","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            server_hardware \u003d oneview_client.get_server_hardware_by_uuid("},{"line_number":386,"context_line":"                sh_uuid)"},{"line_number":387,"context_line":"            if applied_profile.macType \u003d\u003d \u0027Virtual\u0027:"},{"line_number":388,"context_line":"                LOG.warning(\u0027Updating to physical MAC.\u0027)"},{"line_number":389,"context_line":"                common.remove_neutron_ports(task)"},{"line_number":390,"context_line":"                common.update_ironic_port_mac("},{"line_number":391,"context_line":"                    task, applied_profile, server_hardware)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_7cce9b63","line":388,"range":{"start_line":388,"start_character":20,"end_line":388,"end_character":27},"updated":"2017-07-28 12:59:28.000000000","message":"ditto","commit_id":"8bea6dd332f5b9cd56354e53cf9605abf6a561a5"}]}
