)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a27c1595398b5f3ac6269e87a26eead4ad2e68e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hardware type for HPE OneView"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds hardware type \u0027oneview\u0027 for HPE OneView supported"},{"line_number":10,"context_line":"servers. \u0027oneview\u0027 hardware type supports \u0027agent\u0027 and"},{"line_number":11,"context_line":"\u0027iscsi\u0027 deploy methods using \u0027pxe\u0027 boot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0e32f235d985016bac0272d4ad3c8edd9edda3c7"},{"line_number":14,"context_line":"Closes-Bug: #1705544"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff346bd7_c88ea8cf","line":11,"range":{"start_line":10,"start_character":9,"end_line":11,"end_character":22},"updated":"2017-07-22 11:32:16.000000000","message":"You mean :\n\u0027oneview\u0027 hardware type supports \u0027agent\u0027 and\n\u0027iscsi\u0027 _based_ deploy interfaces\u0027?\nMay be better to say :\n\"\u0027oneview\u0027 hardware type supports deploy interfaces viz. \u0027oneview-iscsi\u0027 and \u0027oneview-direct\u0027 based on \u0027iscsi\u0027 and \u0027direct\u0027 deploy interfaces respectively.\"","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a9379e01ac76112a88ee405865ab71cc18b6faa0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hardware type for HPE OneView"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds hardware type \u0027oneview\u0027 for HPE OneView supported"},{"line_number":10,"context_line":"servers. \u0027oneview\u0027 hardware type supports \u0027agent\u0027 and"},{"line_number":11,"context_line":"\u0027iscsi\u0027 deploy methods using \u0027pxe\u0027 boot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0e32f235d985016bac0272d4ad3c8edd9edda3c7"},{"line_number":14,"context_line":"Closes-Bug: #1705544"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff346bd7_5f85b0ac","line":11,"range":{"start_line":10,"start_character":9,"end_line":11,"end_character":22},"in_reply_to":"ff346bd7_c88ea8cf","updated":"2017-07-24 14:44:59.000000000","message":"Done","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"}],"ironic/drivers/oneview.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a27c1595398b5f3ac6269e87a26eead4ad2e68e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"},{"line_number":41,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":42,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":43,"context_line":"        return [deploy.OneViewIscsiDeploy, deploy.OneViewAgentDeploy]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_68b7bc88","line":42,"range":{"start_line":42,"start_character":29,"end_line":42,"end_character":33},"updated":"2017-07-22 11:32:16.000000000","message":"nit: s/boot/deploy","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a9379e01ac76112a88ee405865ab71cc18b6faa0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"},{"line_number":41,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":42,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":43,"context_line":"        return [deploy.OneViewIscsiDeploy, deploy.OneViewAgentDeploy]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_1f8f28cd","line":42,"range":{"start_line":42,"start_character":29,"end_line":42,"end_character":33},"in_reply_to":"ff346bd7_68b7bc88","updated":"2017-07-24 14:44:59.000000000","message":"Done","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"1d81c6dc8ddb56577d7cdd8dc9acdba75a199316","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ironic.drivers.modules import pxe"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class OneViewDriver(generic.GenericHardware):"},{"line_number":35,"context_line":"    \"\"\"OneView hardware type."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    OneView hardware type is targeted for OneView #################"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_efb91de9","line":34,"updated":"2017-07-25 19:12:15.000000000","message":"OneViewHardware seems more appropriate here.","commit_id":"94724ff6e009ff941f39a26c5741f2b7ff9051c2"}],"ironic/tests/unit/drivers/test_oneview.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"dfdb44573ef477568722868a821ec0278b8c8a5e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            self.assertIsInstance(task.driver.vendor,"},{"line_number":69,"context_line":"                                  noop.NoVendor)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_override_with_inspector(self):"},{"line_number":72,"context_line":"        self.config(enabled_inspect_interfaces\u003d[\u0027inspector\u0027, \u0027oneview\u0027])"},{"line_number":73,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":74,"context_line":"            self.context, driver\u003d\u0027oneview\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_a68357cc","line":71,"updated":"2017-08-01 11:31:22.000000000","message":"Unsure what this test is trying to check, is it \"test inspect interface is not overridden if inspector interface is enabled?\"","commit_id":"422e16906b594beb7970168d908bb42c0a6f26fd"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"f477a7a04419817fd105d6b891bb5b3f1d0efb16","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            self.assertIsInstance(task.driver.vendor,"},{"line_number":69,"context_line":"                                  noop.NoVendor)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_override_with_inspector(self):"},{"line_number":72,"context_line":"        self.config(enabled_inspect_interfaces\u003d[\u0027inspector\u0027, \u0027oneview\u0027])"},{"line_number":73,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":74,"context_line":"            self.context, driver\u003d\u0027oneview\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_fa7d6f1c","line":71,"in_reply_to":"df3967d1_a68357cc","updated":"2017-08-01 14:29:27.000000000","message":"Yes, since our hardware doesn\u0027t work with inspector, this test is to make sure that we using our inspect interface.","commit_id":"422e16906b594beb7970168d908bb42c0a6f26fd"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"aa4157c7d4b832f2c6bab814900e4910d3272429","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            self.assertIsInstance(task.driver.vendor,"},{"line_number":69,"context_line":"                                  noop.NoVendor)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_override_with_inspector(self):"},{"line_number":72,"context_line":"        self.config(enabled_inspect_interfaces\u003d[\u0027inspector\u0027, \u0027oneview\u0027])"},{"line_number":73,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":74,"context_line":"            self.context, driver\u003d\u0027oneview\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_bd4801cc","line":71,"in_reply_to":"df3967d1_dad50bb9","updated":"2017-08-01 15:01:10.000000000","message":"Makes sense, thanks.","commit_id":"422e16906b594beb7970168d908bb42c0a6f26fd"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"3f82899414c307d827a8f0db0724dd9dbc289857","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            self.assertIsInstance(task.driver.vendor,"},{"line_number":69,"context_line":"                                  noop.NoVendor)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_override_with_inspector(self):"},{"line_number":72,"context_line":"        self.config(enabled_inspect_interfaces\u003d[\u0027inspector\u0027, \u0027oneview\u0027])"},{"line_number":73,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":74,"context_line":"            self.context, driver\u003d\u0027oneview\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_dad50bb9","line":71,"in_reply_to":"df3967d1_fa7d6f1c","updated":"2017-08-01 14:38:56.000000000","message":"I don\u0027t think test_override_... is the right name for this test then, I think something like test_default_with_inspector_interface_enabled \n\njust to prevent the same confusion when someone else looks at this code.","commit_id":"422e16906b594beb7970168d908bb42c0a6f26fd"}],"releasenotes/notes/oneview-hardware-type-69bbb79da434871f.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a27c1595398b5f3ac6269e87a26eead4ad2e68e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new hardware type ``oneview`` for HPE OneView supported"},{"line_number":5,"context_line":"    servers. ``oneview`` hardware type will support PXE based"},{"line_number":6,"context_line":"    provisioning and deployment using agent directly and iscsi."},{"line_number":7,"context_line":"    It supports the following driver interfaces:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * boot: ``pxe``"},{"line_number":10,"context_line":"    * console: ``no-console``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_487198e0","line":7,"range":{"start_line":5,"start_character":52,"end_line":7,"end_character":20},"updated":"2017-07-22 11:32:16.000000000","message":"May be this is not required.","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a9379e01ac76112a88ee405865ab71cc18b6faa0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new hardware type ``oneview`` for HPE OneView supported"},{"line_number":5,"context_line":"    servers. ``oneview`` hardware type will support PXE based"},{"line_number":6,"context_line":"    provisioning and deployment using agent directly and iscsi."},{"line_number":7,"context_line":"    It supports the following driver interfaces:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * boot: ``pxe``"},{"line_number":10,"context_line":"    * console: ``no-console``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_bfb7fc86","line":7,"range":{"start_line":5,"start_character":52,"end_line":7,"end_character":20},"in_reply_to":"ff346bd7_487198e0","updated":"2017-07-24 14:44:59.000000000","message":"Done","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a27c1595398b5f3ac6269e87a26eead4ad2e68e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * boot: ``pxe``"},{"line_number":10,"context_line":"    * console: ``no-console``"},{"line_number":11,"context_line":"    * deploy: ``oneview-direct`` and ``oneview-iscsi``"},{"line_number":12,"context_line":"    * inspect: ``oneview`` and ``no-inspect``"},{"line_number":13,"context_line":"    * management: ``oneview``"},{"line_number":14,"context_line":"    * network: ``flat``, ``no-op`` and ``neutron``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_88678026","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":54},"updated":"2017-07-22 11:32:16.000000000","message":"May you can add here:\n\u0027(Based on \u0027direct\u0027 and \u0027iscsi\u0027 respectively.)\u0027","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a9379e01ac76112a88ee405865ab71cc18b6faa0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * boot: ``pxe``"},{"line_number":10,"context_line":"    * console: ``no-console``"},{"line_number":11,"context_line":"    * deploy: ``oneview-direct`` and ``oneview-iscsi``"},{"line_number":12,"context_line":"    * inspect: ``oneview`` and ``no-inspect``"},{"line_number":13,"context_line":"    * management: ``oneview``"},{"line_number":14,"context_line":"    * network: ``flat``, ``no-op`` and ``neutron``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_9fbc386a","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":54},"in_reply_to":"ff346bd7_88678026","updated":"2017-07-24 14:44:59.000000000","message":"Done","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a27c1595398b5f3ac6269e87a26eead4ad2e68e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    * deploy: ``oneview-direct`` and ``oneview-iscsi``"},{"line_number":12,"context_line":"    * inspect: ``oneview`` and ``no-inspect``"},{"line_number":13,"context_line":"    * management: ``oneview``"},{"line_number":14,"context_line":"    * network: ``flat``, ``no-op`` and ``neutron``"},{"line_number":15,"context_line":"    * power: ``oneview``"},{"line_number":16,"context_line":"    * raid: ``no-raid`` and ``agent``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_a84b6485","line":14,"range":{"start_line":14,"start_character":25,"end_line":14,"end_character":50},"updated":"2017-07-22 11:32:16.000000000","message":"nit: To maintain the precedence order:-\ns/ \"``no-op`` and ``neutron``\" /\"``neutron``\" and ``no-op``\n\"","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"a9379e01ac76112a88ee405865ab71cc18b6faa0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    * deploy: ``oneview-direct`` and ``oneview-iscsi``"},{"line_number":12,"context_line":"    * inspect: ``oneview`` and ``no-inspect``"},{"line_number":13,"context_line":"    * management: ``oneview``"},{"line_number":14,"context_line":"    * network: ``flat``, ``no-op`` and ``neutron``"},{"line_number":15,"context_line":"    * power: ``oneview``"},{"line_number":16,"context_line":"    * raid: ``no-raid`` and ``agent``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_7fb1948f","line":14,"range":{"start_line":14,"start_character":25,"end_line":14,"end_character":50},"in_reply_to":"ff346bd7_a84b6485","updated":"2017-07-24 14:44:59.000000000","message":"Done","commit_id":"7df9ac4a57c4f622841287fbe157cea23f518ab1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"19b71a9bf7b5274d50e7ab109f9241cdd7853b58","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new hardware type ``oneview`` for HPE OneView supported"},{"line_number":5,"context_line":"    servers. ``oneview`` hardware type will support following"},{"line_number":6,"context_line":"    driver interfaces:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * boot: ``pxe``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df3967d1_225f2a0f","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":43},"updated":"2017-08-02 12:47:42.000000000","message":"nit: Will is in the future as if this patch does not provide it.  Perhaps s/will/supplies/","commit_id":"00a979199cea2d32baae0d97c9a448e4ed027dc5"}]}
