)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"53e6977b2fe1820908463c23da9ac771ec586cf7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct BFV PXE logic and debugging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"One of the follow-up patches to BFV added a calls to"},{"line_number":10,"context_line":"the storage_interface should_write_image method in order"},{"line_number":11,"context_line":"prevent erronious calls into the PXE logic/validation code."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_59725ae5","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":49},"updated":"2017-07-21 04:00:25.000000000","message":"s/calls/call/","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1fdc6b900cb34a49a1f2152cbd60115dae32a7d8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct BFV PXE logic and debugging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"One of the follow-up patches to BFV added a calls to"},{"line_number":10,"context_line":"the storage_interface should_write_image method in order"},{"line_number":11,"context_line":"prevent erronious calls into the PXE logic/validation code."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_7493dda4","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":49},"in_reply_to":"1f1a1f67_59725ae5","updated":"2017-07-21 04:10:40.000000000","message":"It was actually calls.  One in validate, one in prepare_ramdisk","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"53e6977b2fe1820908463c23da9ac771ec586cf7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Correct BFV PXE logic and debugging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"One of the follow-up patches to BFV added a calls to"},{"line_number":10,"context_line":"the storage_interface should_write_image method in order"},{"line_number":11,"context_line":"prevent erronious calls into the PXE logic/validation code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is fine, between separate tasks being initiated as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_397f9eac","line":10,"range":{"start_line":10,"start_character":48,"end_line":10,"end_character":56},"updated":"2017-07-21 04:00:25.000000000","message":"in order to","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"53e6977b2fe1820908463c23da9ac771ec586cf7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"One of the follow-up patches to BFV added a calls to"},{"line_number":10,"context_line":"the storage_interface should_write_image method in order"},{"line_number":11,"context_line":"prevent erronious calls into the PXE logic/validation code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is fine, between separate tasks being initiated as"},{"line_number":14,"context_line":"each task initiates and lives with the database state,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_f94a4681","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":17},"updated":"2017-07-21 04:00:25.000000000","message":"erroneous","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"53e6977b2fe1820908463c23da9ac771ec586cf7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"sending it into cleaning... is not a good case."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Inadvertently, we broke the pxe calls to cleaning that"},{"line_number":19,"context_line":"full integration testing would failed upon."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"As such, the should_write_image logic should only return"},{"line_number":22,"context_line":"in cases where the logic is appropriate to change, i.e."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_795e3646","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":37},"updated":"2017-07-21 04:00:25.000000000","message":"would have failed","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"53e6977b2fe1820908463c23da9ac771ec586cf7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Inadvertently, we broke the pxe calls to cleaning that"},{"line_number":19,"context_line":"full integration testing would failed upon."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"As such, the should_write_image logic should only return"},{"line_number":22,"context_line":"in cases where the logic is appropriate to change, i.e."},{"line_number":23,"context_line":"in deploying and conductor takeover cases."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_d9342afe","line":21,"range":{"start_line":21,"start_character":45,"end_line":21,"end_character":56},"updated":"2017-07-21 04:00:25.000000000","message":"only return True","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"53e6977b2fe1820908463c23da9ac771ec586cf7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"troubleshoot the issue."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I46b374104ea2cb9a68581a99a9db431ef4444c1b"},{"line_number":29,"context_line":"Depends-On: Idb9e9259bcd49787c704bc5c0c98f240924abe37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_f9180685","line":29,"updated":"2017-07-21 04:00:25.000000000","message":"We will need to remove this at some point","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c33ef3f3d1bd377e27e8a2020267e55f0c6353ac","unresolved":false,"context_lines":[{"line_number":26,"context_line":"troubleshoot the issue."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I46b374104ea2cb9a68581a99a9db431ef4444c1b"},{"line_number":29,"context_line":"Depends-On: Idb9e9259bcd49787c704bc5c0c98f240924abe37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_f487ed60","line":29,"in_reply_to":"1f1a1f67_74651de1","updated":"2017-07-21 04:08:24.000000000","message":"And I thought you were commenting on the other patch.  Same thoughts apply I guess, although we likely need to go ahead and just merge this first.","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"553d56f6b13543d4ab6c6d979577144b5ff63df0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"troubleshoot the issue."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I46b374104ea2cb9a68581a99a9db431ef4444c1b"},{"line_number":29,"context_line":"Depends-On: Idb9e9259bcd49787c704bc5c0c98f240924abe37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_74651de1","line":29,"in_reply_to":"1f1a1f67_f9180685","updated":"2017-07-21 04:06:51.000000000","message":"Eh... not really.  It will merge if it is there.  But really, I just wanted the speculative merge to occur to make sure this didn\u0027t break more since the other patch _should_ pass the tempest test if I understand the issue correctly.","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"76c16f3027be15d64bd9930ca55d755203b75852","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct BFV PXE logic and debugging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"One of the follow-up patches to BFV added a calls to"},{"line_number":10,"context_line":"the storage_interface should_write_image method in order to"},{"line_number":11,"context_line":"prevent erroneous calls into the PXE logic/validation code."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f1a1f67_4fb72c3c","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":49},"updated":"2017-07-21 04:51:14.000000000","message":"added calls","commit_id":"972e1439bc4f6f94baecdf4e2406e1c062380902"}],"ironic/drivers/modules/storage/cinder.py":[{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"97c184f39572c4007f1cce1d4d6418a48aa75e93","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                        # like cleaning. This may also be called as a"},{"line_number":370,"context_line":"                        # result of conductor takeover."},{"line_number":371,"context_line":"                        LOG.debug(\u0027Ignoring cinder storage_interface \u0027"},{"line_number":372,"context_line":"                                  \u0027should_write_check check outside of \u0027"},{"line_number":373,"context_line":"                                  \u0027%(state)s for node %(node)s.\u0027,"},{"line_number":374,"context_line":"                                  {\u0027state\u0027: node.provision_state,"},{"line_number":375,"context_line":"                                   \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_e125dfac","line":372,"range":{"start_line":372,"start_character":35,"end_line":372,"end_character":53},"updated":"2017-07-21 13:42:25.000000000","message":"nit - should_write_image","commit_id":"6d7eb100b8f583debf544bf6c8e807611293b128"}]}