)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2961da0a443cdea8b004e7b69d64819796fb7c0e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sam Betts \u003csam@code-smash.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-21 12:55:47 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware types to support Cisco UCS Servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib0db11f3e43d17c34278453cdc3e34907034b46f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff346bd7_435e19e7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":47},"updated":"2017-07-22 11:51:29.000000000","message":"Add \u0027Closes-Bug\u0027 with RFE bug Id.","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"}],"ironic/drivers/cisco_ucs.py":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"ab70ca528a12579eca79235c53bbdcf5d9805701","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_158259c9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":73},"updated":"2017-07-21 11:53:17.000000000","message":"No mention for Cisco on the header?","commit_id":"c266caac4fbe297c60e062887131c4588e8b47fc"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"ab70ca528a12579eca79235c53bbdcf5d9805701","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from ironic.drivers import ipmi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.drivers.modules.cimc import management as cimc_mgmt"},{"line_number":20,"context_line":"from ironic.drivers.modules.cimc import power as cimc_power"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ironic.drivers.modules.ucs import management as ucs_mgmt"},{"line_number":23,"context_line":"from ironic.drivers.modules.ucs import power as ucs_power"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_3518b5d1","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":61},"updated":"2017-07-21 11:53:17.000000000","message":"vim  ironic/drivers/cisco_ucs.py +21\ndd\n:wq\n# :)","commit_id":"c266caac4fbe297c60e062887131c4588e8b47fc"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"ab70ca528a12579eca79235c53bbdcf5d9805701","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def supported_power_interfaces(self):"},{"line_number":37,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":38,"context_line":"        parent_power \u003d super(CiscoUCSStandalone, self).supported_power_interfaces()"},{"line_number":39,"context_line":"        return [cimc_power.Power()] + parent_power"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CiscoUCSManaged(CiscoUCSStandalone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_150db98f","line":39,"range":{"start_line":39,"start_character":32,"end_line":39,"end_character":34},"updated":"2017-07-21 11:53:17.000000000","message":"Shouldn\u0027t this be `cimc_power.Power` instead?","commit_id":"c266caac4fbe297c60e062887131c4588e8b47fc"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"ab70ca528a12579eca79235c53bbdcf5d9805701","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def supported_power_interfaces(self):"},{"line_number":53,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":54,"context_line":"        parent_power \u003d super(CiscoUCSManaged, self).supported_power_interfaces()"},{"line_number":55,"context_line":"        return [ucs_power.Power()] + parent_power"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_f5111dae","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":33},"updated":"2017-07-21 11:53:17.000000000","message":"ditto","commit_id":"c266caac4fbe297c60e062887131c4588e8b47fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e00123d33e462fd89bc273ead54da596bd536cab","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        return [cimc_power.Power] + power"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CiscoUCSManaged(CiscoUCSStandalone):"},{"line_number":43,"context_line":"    \"\"\"Cisco UCS under UCSM management\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_e88273c8","line":42,"updated":"2017-07-24 10:47:03.000000000","message":"I believe that Sam is right. Hardware type means a family of hardware with similar management capabilities. We cannot call two machines the same type, if they don\u0027t support the same capabilities.\n\nI\u0027m not sure the iLO license is a good example. If I get it right, it\u0027s more of a configuration rather than principal difference between hardware. E.g. I suspect I can buy an advanced license for hardware I already have, no?","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2961da0a443cdea8b004e7b69d64819796fb7c0e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        return [cimc_power.Power] + power"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CiscoUCSManaged(CiscoUCSStandalone):"},{"line_number":43,"context_line":"    \"\"\"Cisco UCS under UCSM management\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_4313b90e","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":42},"updated":"2017-07-22 11:51:29.000000000","message":"We do not need two hardware type here. You could achieve this by adding one class as below. Any reasons for two?\n\nclass CiscoUCS(ipmi.IPMIHardware):\n\n    @property\n    def supported_management_interfaces(self):\n        \"\"\"List of supported management interfaces.\"\"\"\n        mgmt \u003d super(CiscoUCSStandalone, self).supported_management_interfaces\n        return [ucs_mgmt.UcsManagement, cimc_mgmt.CIMCManagement] + mgmt\n\n    @property\n    def supported_power_interfaces(self):\n        \"\"\"List of supported power interfaces.\"\"\"\n        power \u003d super(CiscoUCSStandalone, self).supported_power_interfaces\n        return [ucs_power.Power, cimc_power.Power] + power","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e307c23716bdcfe2fb28d6bb499375b04e449e77","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        return [cimc_power.Power] + power"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CiscoUCSManaged(CiscoUCSStandalone):"},{"line_number":43,"context_line":"    \"\"\"Cisco UCS under UCSM management\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_9da20b9a","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":42},"in_reply_to":"ff346bd7_22bc1adb","updated":"2017-07-24 10:12:17.000000000","message":"Ok. I was just thinking would it be better to handle it through documentation? In  the sense, indicating not to use ucsm based interfaces if server is not integrated with UCS Manager. \nI felt it is similar to some iLO based hardwares where in one can use virtual media functionalities only with the \u0027advanced license\u0027.","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a6a080ceb36208613e9624d09e57abd0d2bc2296","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        return [cimc_power.Power] + power"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CiscoUCSManaged(CiscoUCSStandalone):"},{"line_number":43,"context_line":"    \"\"\"Cisco UCS under UCSM management\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_22bc1adb","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":42},"in_reply_to":"ff346bd7_4313b90e","updated":"2017-07-24 09:33:27.000000000","message":"This is done deliberately because UCS servers in standalone can not use the UCSM based drivers.","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cdf52184b8a0d9c26e175faeba3e6a8ffbbf444c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        return [cimc_power.Power] + power"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CiscoUCSManaged(CiscoUCSStandalone):"},{"line_number":43,"context_line":"    \"\"\"Cisco UCS under UCSM management\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_4347204d","line":42,"in_reply_to":"ff346bd7_e88273c8","updated":"2017-07-24 10:59:04.000000000","message":"Yes. One can buy the \u0027advanced licence\u0027 for the same server and enhance its manageability capacities.\nI suppose UCSM is an additional hardware. I assumed its software component. Thanks for clarification.","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"}],"releasenotes/notes/add-cisco-ucs-hardware-types-ee597ff0416f158f.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7fc537c32fa7cff4e294f66c906c437714140e3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add two new hardware types to support Cisco UCS Servers,"},{"line_number":5,"context_line":"    cisco_ucs_standalone and cisco_ucs_managed. cisco_ucs_standalone supports"},{"line_number":6,"context_line":"    driver interfaces for controlling UCS servers in standalone mode via either"},{"line_number":7,"context_line":"    CIMC APIs or via IPMI. cisco_ucs_managed is a superset of"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df3967d1_5f8ad269","line":4,"updated":"2017-08-03 19:34:10.000000000","message":"nit s/Add/Adds/","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e00123d33e462fd89bc273ead54da596bd536cab","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add two new hardware types to support Cisco UCS Servers,"},{"line_number":5,"context_line":"    cisco_ucs_standalone and cisco_ucs_managed. cisco_ucs_standalone supports"},{"line_number":6,"context_line":"    driver interfaces for controlling UCS servers in standalone mode via either"},{"line_number":7,"context_line":"    CIMC APIs or via IPMI. cisco_ucs_managed is a superset of"},{"line_number":8,"context_line":"    cisco_ucs_standalone and supports additional driver interfaces for"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff346bd7_087ed7e3","line":5,"updated":"2017-07-24 10:47:03.000000000","message":"nit: `` around entry point names","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7fc537c32fa7cff4e294f66c906c437714140e3b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add two new hardware types to support Cisco UCS Servers,"},{"line_number":5,"context_line":"    cisco_ucs_standalone and cisco_ucs_managed. cisco_ucs_standalone supports"},{"line_number":6,"context_line":"    driver interfaces for controlling UCS servers in standalone mode via either"},{"line_number":7,"context_line":"    CIMC APIs or via IPMI. cisco_ucs_managed is a superset of"},{"line_number":8,"context_line":"    cisco_ucs_standalone and supports additional driver interfaces for"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df3967d1_bae0ac27","line":5,"in_reply_to":"ff346bd7_087ed7e3","updated":"2017-08-03 19:34:10.000000000","message":"do you mean ``cisco_ucs_standalone`` ?","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7fc537c32fa7cff4e294f66c906c437714140e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df3967d1_bfe3fe33","line":10,"updated":"2017-08-03 19:34:10.000000000","message":"do you also want to mention the cisco-specific interfaces too? cimc \u0026 ucsm power \u0026 management?","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb89381fceaf5cc34c502e40015b9e4b56c7cc56","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.management:IloManagement"},{"line_number":115,"context_line":"    ipmitool \u003d ironic.drivers.modules.ipmitool:IPMIManagement"},{"line_number":116,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.management:IRMCManagement"},{"line_number":117,"context_line":"    redfish \u003d ironic.drivers.modules.redfish.management:RedfishManagement"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"ironic.hardware.interfaces.network \u003d"},{"line_number":120,"context_line":"    flat \u003d ironic.drivers.modules.network.flat:FlatNetwork"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1f1a1f67_9201dfb2","line":117,"updated":"2017-07-21 10:54:44.000000000","message":"you need to add your entry points here, otherwise users won\u0027t be able to reference your management interfaces","commit_id":"c266caac4fbe297c60e062887131c4588e8b47fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb89381fceaf5cc34c502e40015b9e4b56c7cc56","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.power:IloPower"},{"line_number":127,"context_line":"    ipmitool \u003d ironic.drivers.modules.ipmitool:IPMIPower"},{"line_number":128,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.power:IRMCPower"},{"line_number":129,"context_line":"    redfish \u003d ironic.drivers.modules.redfish.power:RedfishPower"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"ironic.hardware.interfaces.raid \u003d"},{"line_number":132,"context_line":"    agent \u003d ironic.drivers.modules.agent:AgentRAID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1f1a1f67_522d8744","line":129,"updated":"2017-07-21 10:54:44.000000000","message":"ditto for power","commit_id":"c266caac4fbe297c60e062887131c4588e8b47fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e00123d33e462fd89bc273ead54da596bd536cab","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.power:IRMCPower"},{"line_number":131,"context_line":"    redfish \u003d ironic.drivers.modules.redfish.power:RedfishPower"},{"line_number":132,"context_line":"    cimc \u003d ironic.drivers.modules.cimc.power:Power"},{"line_number":133,"context_line":"    ucsm \u003d ironic.drivers.modules.ucs.power:Power"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"ironic.hardware.interfaces.raid \u003d"},{"line_number":136,"context_line":"    agent \u003d ironic.drivers.modules.agent:AgentRAID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"ff346bd7_c887afd7","line":133,"updated":"2017-07-24 10:47:03.000000000","message":"ditto","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e00123d33e462fd89bc273ead54da596bd536cab","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    manual-management \u003d ironic.drivers.generic:ManualManagementHardware"},{"line_number":159,"context_line":"    redfish \u003d ironic.drivers.redfish:RedfishHardware"},{"line_number":160,"context_line":"    cisco_ucs_standalone \u003d ironic.drivers.cisco_ucs:CiscoUCSStandalone"},{"line_number":161,"context_line":"    cisco_ucs_managed \u003d ironic.drivers.cisco_ucs:CiscoUCSManaged"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"ironic.database.migration_backend \u003d"},{"line_number":164,"context_line":"    sqlalchemy \u003d ironic.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"ff346bd7_a86c6b36","line":161,"updated":"2017-07-24 10:47:03.000000000","message":"ditto","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7fc537c32fa7cff4e294f66c906c437714140e3b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    manual-management \u003d ironic.drivers.generic:ManualManagementHardware"},{"line_number":159,"context_line":"    redfish \u003d ironic.drivers.redfish:RedfishHardware"},{"line_number":160,"context_line":"    cisco_ucs_standalone \u003d ironic.drivers.cisco_ucs:CiscoUCSStandalone"},{"line_number":161,"context_line":"    cisco_ucs_managed \u003d ironic.drivers.cisco_ucs:CiscoUCSManaged"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"ironic.database.migration_backend \u003d"},{"line_number":164,"context_line":"    sqlalchemy \u003d ironic.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"df3967d1_7f9c76bf","line":161,"in_reply_to":"ff346bd7_a86c6b36","updated":"2017-08-03 19:34:10.000000000","message":"I\u0027m not sure what Dmitry means here. But what I want to say is that to be consistent (I\u0027m assuming someone decided this), the names should have hyphens, not underscores. So s/cisco_ucs_standalone/cisco-ucs-standalone/, etc.\n\nWould have been nice to have them in alphabetical order too...","commit_id":"c247ef6c1aa3962de94034426eb2d76511fa6995"}]}