)]}'
{"devstack/upgrade/settings":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"39ca71d33c448b10dfc6f306353c31223d332e73","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    UPGRADE_PROJECTS\u003d$(echo $UPGRADE_PROJECTS | sed -e \u0027s/\\s*nova//g\u0027 )"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":33,"context_line":"CELLSV2_SETUP\u003d\"singleconductor\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff346bd7_cf7f2bde","line":32,"updated":"2017-07-27 15:27:44.000000000","message":"Should we do something like this?\n\nhttps://github.com/openstack/ironic/blob/759ed5d2ea949783f22bc4331906fc8493b8d1dc/devstack/upgrade/settings#L26-L30","commit_id":"f7c2f7cbe24adc26c4ae7f81238f3ddf8e87e9d7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5977bbbafd0553a11ec748c84a1f390d1ebf7b00","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    UPGRADE_PROJECTS\u003d$(echo $UPGRADE_PROJECTS | sed -e \u0027s/\\s*nova//g\u0027 )"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":33,"context_line":"CELLSV2_SETUP\u003d\"singleconductor\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff346bd7_12c43a5e","line":32,"in_reply_to":"ff346bd7_cf7f2bde","updated":"2017-07-27 15:47:08.000000000","message":"I\u0027d say that we\u0027s better to always set this, as Matt says build retries are not supported ATM in multicell case, and also as it seems to me multicell does not make much sense in ironic case as all computes, no matter which cell, would see all the ironic nodes. As for the last part, I may need to read more on cellsv2 :) but the first thing seems more important.","commit_id":"f7c2f7cbe24adc26c4ae7f81238f3ddf8e87e9d7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"921c8767830bbc03f58a999790eccdf50493010d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":33,"context_line":"CELLSV2_SETUP\u003d\"singleconductor\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff346bd7_75ded06d","line":33,"updated":"2017-07-27 16:06:28.000000000","message":"Hm, I still see http://logs.openstack.org/58/487458/5/check/gate-grenade-dsvm-ironic-ubuntu-xenial/f1fd08b/logs/grenade.sh.txt.gz#_2017-07-27_15_59_36_717. maybe I need to export this one?","commit_id":"f7c2f7cbe24adc26c4ae7f81238f3ddf8e87e9d7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0ec65c5070297fc0b43c3e1a309b9a3ef3e69b62","unresolved":false,"context_lines":[{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":33,"context_line":"CELLSV2_SETUP\u003d\"singleconductor\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ff346bd7_b53e7888","line":33,"in_reply_to":"ff346bd7_75ded06d","updated":"2017-07-27 16:07:52.000000000","message":"at the same time I see http://logs.openstack.org/58/487458/5/check/gate-grenade-dsvm-ironic-ubuntu-xenial/f1fd08b/logs/grenade.sh.txt.gz#_2017-07-27_15_58_24_805","commit_id":"f7c2f7cbe24adc26c4ae7f81238f3ddf8e87e9d7"}],"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a5864258ddd5613f3df15285d11ee34c4a7225ec","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# may cause nova-compute failure due to LP1537076"},{"line_number":107,"context_line":"stop_nova_compute || true"},{"line_number":108,"context_line":"wait_for_keystone"},{"line_number":109,"context_line":"start_nova_compute nomulticell"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"if [[ -n \"$ensure_stopped\" ]]; then"},{"line_number":112,"context_line":"    ensure_services_stopped $ensure_stopped"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff346bd7_2366a72b","side":"PARENT","line":109,"range":{"start_line":109,"start_character":18,"end_line":109,"end_character":30},"updated":"2017-07-28 17:09:44.000000000","message":"just to double-check: this is no longer needed?","commit_id":"338fdb94fc3b031e8d91bc7131cb4cadf05d7b92"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b587008b1d7edc8ae46e2d15f86f4c9e7541d2a9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# may cause nova-compute failure due to LP1537076"},{"line_number":107,"context_line":"stop_nova_compute || true"},{"line_number":108,"context_line":"wait_for_keystone"},{"line_number":109,"context_line":"start_nova_compute nomulticell"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"if [[ -n \"$ensure_stopped\" ]]; then"},{"line_number":112,"context_line":"    ensure_services_stopped $ensure_stopped"}],"source_content_type":"text/x-sh","patch_set":7,"id":"df3967d1_9118dc75","side":"PARENT","line":109,"range":{"start_line":109,"start_character":18,"end_line":109,"end_character":30},"in_reply_to":"ff346bd7_2366a72b","updated":"2017-07-28 17:21:28.000000000","message":"I believe so because of:\n\nhttps://review.openstack.org/#/c/487458/7/devstack/settings@14","commit_id":"338fdb94fc3b031e8d91bc7131cb4cadf05d7b92"}]}