)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"914c0e04ae54e2825b3d11568c1462e6e49b541f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-15 11:38:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM/WIP: Add \u0027hardware type\u0027 for Dell EMC iDRACs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ironic project is engaged in a driver composition reform [0] which"},{"line_number":10,"context_line":"introduces dynamic drivers. That reform places hardware vendors in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_c0f7e78a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2017-08-15 15:41:45.000000000","message":"please remove this, as this is quite ready for merge","commit_id":"6c0bc786ffb35cbdeec620237ebab188153dd27c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"7b1ae38cb184b202bc9ee8cda57814834c3e611b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-15 11:38:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM/WIP: Add \u0027hardware type\u0027 for Dell EMC iDRACs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ironic project is engaged in a driver composition reform [0] which"},{"line_number":10,"context_line":"introduces dynamic drivers. That reform places hardware vendors in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_20d0f3c8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"9f436f4f_c0f7e78a","updated":"2017-08-15 15:58:04.000000000","message":"agree","commit_id":"6c0bc786ffb35cbdeec620237ebab188153dd27c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"7b1ae38cb184b202bc9ee8cda57814834c3e611b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ironic project is engaged in a driver composition reform [0] which"},{"line_number":10,"context_line":"introduces dynamic drivers. That reform places hardware vendors in"},{"line_number":11,"context_line":"charge of defining a new form of drivers for their hardware. The new"},{"line_number":12,"context_line":"form is called \u0027hardware type\u0027. The reform will deprecate [1] the"},{"line_number":13,"context_line":"existing ironic drivers, which are now referred to as \u0027classic drivers\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change adds a single new \u0027hardware type\u0027, \u0027idrac\u0027, for servers"},{"line_number":16,"context_line":"controlled by Dell EMC integrated Dell Remote Access Controllers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_c07487d1","line":13,"range":{"start_line":12,"start_character":32,"end_line":13,"end_character":71},"updated":"2017-08-15 15:58:04.000000000","message":"since this comes at the end of pike cycle does that mean that in queens cycle we will have both classic and new driver and deprecate classic in rocky?\nAnother words, shift deprecation once cycle to the right compare to basic proposal in [1]","commit_id":"6c0bc786ffb35cbdeec620237ebab188153dd27c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4a0733161660e34baf25f110a31931193d7649e6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ironic project is engaged in a driver composition reform [0] which"},{"line_number":10,"context_line":"introduces dynamic drivers. That reform places hardware vendors in"},{"line_number":11,"context_line":"charge of defining a new form of drivers for their hardware. The new"},{"line_number":12,"context_line":"form is called \u0027hardware type\u0027. The reform will deprecate [1] the"},{"line_number":13,"context_line":"existing ironic drivers, which are now referred to as \u0027classic drivers\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change adds a single new \u0027hardware type\u0027, \u0027idrac\u0027, for servers"},{"line_number":16,"context_line":"controlled by Dell EMC integrated Dell Remote Access Controllers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_03adf999","line":13,"range":{"start_line":12,"start_character":32,"end_line":13,"end_character":71},"in_reply_to":"9f436f4f_633165a3","updated":"2017-08-15 16:05:43.000000000","message":"as long as we have 1 release of overlap I am good.\nThanks","commit_id":"6c0bc786ffb35cbdeec620237ebab188153dd27c"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"0316ce0a101d5d3745ecaaf40b339d1d50bfa8d1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ironic project is engaged in a driver composition reform [0] which"},{"line_number":10,"context_line":"introduces dynamic drivers. That reform places hardware vendors in"},{"line_number":11,"context_line":"charge of defining a new form of drivers for their hardware. The new"},{"line_number":12,"context_line":"form is called \u0027hardware type\u0027. The reform will deprecate [1] the"},{"line_number":13,"context_line":"existing ironic drivers, which are now referred to as \u0027classic drivers\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change adds a single new \u0027hardware type\u0027, \u0027idrac\u0027, for servers"},{"line_number":16,"context_line":"controlled by Dell EMC integrated Dell Remote Access Controllers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_633165a3","line":13,"range":{"start_line":12,"start_character":32,"end_line":13,"end_character":71},"in_reply_to":"9f436f4f_c07487d1","updated":"2017-08-15 16:03:18.000000000","message":"not really. The deprecation plan outlined in [1] concerns all drivers, so yes, during Queens we will deprecate classic drivers, but they still be available in the Queens release.","commit_id":"6c0bc786ffb35cbdeec620237ebab188153dd27c"}],"ironic/drivers/drac.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"81574c3cbc49a08e8d9dc07a6280c99569a0d991","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":46,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":47,"context_line":"        return [deploy.DracDeploy, iscsi_deploy.ISCSIDeploy, agent.AgentDeploy]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_a6dc9e74","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":35},"updated":"2017-08-07 15:43:12.000000000","message":"We should get rid of this. Generally, the drivers should use the existing deploy interfaces. A preferred approach is to modify the boot interfaces instead. However, in your case, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/deploy.py#L46-L52 is something we could make generic, not Dell-specific.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"510180438cfa5cd371b5fa1d5746bfb57049f4c1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":46,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":47,"context_line":"        return [deploy.DracDeploy, iscsi_deploy.ISCSIDeploy, agent.AgentDeploy]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_9a86f1b8","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":35},"in_reply_to":"9f436f4f_9943a86c","updated":"2017-08-15 12:36:32.000000000","message":"A fix to bug \"double manage/provide cycle cause trace for pxe_drac\" (https://bugs.launchpad.net/ironic/+bug/1676387) has been proposed and is in process. The change is https://review.openstack.org/#/c/493421. As Pavlo commented, it removes DracDeploy.\n\nThis change has been rebased to depend on that bug fix via their Git commits\u0027 parent-child relationship.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"79d00418518fc0520c4cfbd576c38eac853c0ec3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":46,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":47,"context_line":"        return [deploy.DracDeploy, iscsi_deploy.ISCSIDeploy, agent.AgentDeploy]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_9943a86c","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":35},"in_reply_to":"bf3e73b7_a6dc9e74","updated":"2017-08-15 06:37:34.000000000","message":"+1, the approved fix for classic driver already removed the DracDeploy altogether","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"81574c3cbc49a08e8d9dc07a6280c99569a0d991","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def supported_management_interfaces(self):"},{"line_number":51,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":52,"context_line":"        return [drac_management.DracManagement,"},{"line_number":53,"context_line":"                redfish_management.RedfishManagement]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_c6d0c253","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":52},"updated":"2017-08-07 15:43:12.000000000","message":"Is it supported on *all* hardware that this hardware type supports? If not, you need to hardware types: one base with only Drac, and one newer, subclassing it, with also Redfish support.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"510180438cfa5cd371b5fa1d5746bfb57049f4c1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def supported_management_interfaces(self):"},{"line_number":51,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":52,"context_line":"        return [drac_management.DracManagement,"},{"line_number":53,"context_line":"                redfish_management.RedfishManagement]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_5aa52946","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":52},"in_reply_to":"9f436f4f_ec167449","updated":"2017-08-15 12:36:32.000000000","message":"Support for Redfish has been removed. For now, this \u0027hardware type\u0027 will only support what the iDRAC \u0027classic drivers\u0027 support.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"79d00418518fc0520c4cfbd576c38eac853c0ec3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def supported_management_interfaces(self):"},{"line_number":51,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":52,"context_line":"        return [drac_management.DracManagement,"},{"line_number":53,"context_line":"                redfish_management.RedfishManagement]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_ec167449","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":52},"in_reply_to":"bf3e73b7_c6d0c253","updated":"2017-08-15 06:37:34.000000000","message":"I\u0027m not even sure one needs a special dell+redfish hw type, as it would be needed only when:\n\n- someone wants to use drac power + redfish mgmt or vice versa (why?)\n- use redfish with other drac-specific interfaces (inspect? raid? vendor?)\n\nAnd a general question - can a redfish-compliant Dell system be configured to expose both iDRAC and RedFish API and be managed by both simultaneously? (only \u0027yes\u0027 answer would justify a Drac+RedFish HW type IMO)","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"81574c3cbc49a08e8d9dc07a6280c99569a0d991","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # AgentRAID requires RAID bits on the IPA image that are not"},{"line_number":74,"context_line":"        # shipped by default. Hence, even if AgentRAID is enabled,"},{"line_number":75,"context_line":"        # NoRAID has a higher priority."},{"line_number":76,"context_line":"        return [raid.DracRAID, noop.NoRAID, agent.AgentRAID]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def supported_vendor_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_66e6b647","line":76,"range":{"start_line":76,"start_character":42,"end_line":76,"end_character":59},"updated":"2017-08-07 15:43:12.000000000","message":"Does Dell hardware support in-band RAID? If not, this one can be removed.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"510180438cfa5cd371b5fa1d5746bfb57049f4c1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # AgentRAID requires RAID bits on the IPA image that are not"},{"line_number":74,"context_line":"        # shipped by default. Hence, even if AgentRAID is enabled,"},{"line_number":75,"context_line":"        # NoRAID has a higher priority."},{"line_number":76,"context_line":"        return [raid.DracRAID, noop.NoRAID, agent.AgentRAID]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @property"},{"line_number":79,"context_line":"    def supported_vendor_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_1a20c1ab","line":76,"range":{"start_line":76,"start_character":42,"end_line":76,"end_character":59},"in_reply_to":"bf3e73b7_66e6b647","updated":"2017-08-15 12:36:32.000000000","message":"The idea behind this was to not exclude in-band RAID developed by a third party from being supported. As far as we are aware, no such capability exists and there are no plans to develop it. Therefore, it has been removed.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"d19d6aa555f382cdb3745260a587bad48d0c9606","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class IDRACHardware(generic.GenericHardware):"},{"line_number":36,"context_line":"    \"\"\"Dell integrated Dell Remote Access Controller hardware type\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Required hardware interfaces"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_8549e9b7","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":66},"updated":"2017-08-15 20:01:43.000000000","message":"Nit pick.\nDo we need first Dell?\nWhy not just integrated Dell Remote Access Controller hardware type?","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2f79d0cfd112a3b962bc705490b918447b616d8c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class IDRACHardware(generic.GenericHardware):"},{"line_number":36,"context_line":"    \"\"\"Dell integrated Dell Remote Access Controller hardware type\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Required hardware interfaces"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_896fc329","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":66},"in_reply_to":"9f436f4f_8549e9b7","updated":"2017-08-15 20:58:46.000000000","message":"Super good point. +1 :)","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"00024ab8dc373098e839ee0bc49e2a835c36e7ff","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class IDRACHardware(generic.GenericHardware):"},{"line_number":36,"context_line":"    \"\"\"Dell integrated Dell Remote Access Controller hardware type\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Required hardware interfaces"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_7d24555e","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":66},"in_reply_to":"9f436f4f_896fc329","updated":"2017-08-16 00:22:36.000000000","message":"I wanted this line to be the following, s/^Dell/Dell EMC/:\n\n\"\"\"Dell EMC integrated Dell Remote Access Controller hardware type\"\"\"\n\nHowever, the line length would have exceeded what is specified by PEP 8 for docstrings, 72 characters. Please refer to https://www.python.org/dev/peps/pep-0008/#maximum-line-length.\n\nI have removed the first \u0027Dell\u0027.","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"}],"ironic/tests/unit/drivers/test_drac.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f71702f727c7a90a0a5b76a35afe2aeac873f02d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def test_override_with_agent(self):"},{"line_number":116,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027idrac\u0027,"},{"line_number":117,"context_line":"                                          deploy_interface\u003d\u0027direct\u0027,"},{"line_number":118,"context_line":"                                          inspect_interface\u003d\u0027inspector\u0027)"},{"line_number":119,"context_line":"        with task_manager.acquire(self.context, node.id) as task:"},{"line_number":120,"context_line":"            self._validate_interfaces(task.driver,"},{"line_number":121,"context_line":"                                      console\u003dnoop.NoConsole,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_cf3ef0b6","line":118,"updated":"2017-08-15 18:10:11.000000000","message":"nit, do you want to do this if this test is to override with agent?","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2132c7888a5018726beac44d9b85278a2c8c5187","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def test_override_with_agent(self):"},{"line_number":116,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027idrac\u0027,"},{"line_number":117,"context_line":"                                          deploy_interface\u003d\u0027direct\u0027,"},{"line_number":118,"context_line":"                                          inspect_interface\u003d\u0027inspector\u0027)"},{"line_number":119,"context_line":"        with task_manager.acquire(self.context, node.id) as task:"},{"line_number":120,"context_line":"            self._validate_interfaces(task.driver,"},{"line_number":121,"context_line":"                                      console\u003dnoop.NoConsole,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_f2d7544a","line":118,"in_reply_to":"9f436f4f_cf3ef0b6","updated":"2017-08-16 00:20:26.000000000","message":"The intent is that this test case be as all in with the IPA as possible, given what this hardware type supports. It does illustrate how to configure it for that. I am willing to trade-off the redundant test of overriding the inspect interface for the test\u0027s example value, so I am going to leave it as is. :)","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f71702f727c7a90a0a5b76a35afe2aeac873f02d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                      console\u003dnoop.NoConsole,"},{"line_number":122,"context_line":"                                      deploy\u003dagent.AgentDeploy,"},{"line_number":123,"context_line":"                                      inspect\u003dinspector.Inspector)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@mock.patch.object(importutils, \u0027try_import\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":127,"context_line":"class DracClassicDriversTestCase(BaseIDRACTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_6f9ee4b9","line":124,"updated":"2017-08-15 18:10:11.000000000","message":"I suppose you could add a test that overrides raid","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2132c7888a5018726beac44d9b85278a2c8c5187","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                      console\u003dnoop.NoConsole,"},{"line_number":122,"context_line":"                                      deploy\u003dagent.AgentDeploy,"},{"line_number":123,"context_line":"                                      inspect\u003dinspector.Inspector)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@mock.patch.object(importutils, \u0027try_import\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":127,"context_line":"class DracClassicDriversTestCase(BaseIDRACTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_f23cf493","line":124,"in_reply_to":"9f436f4f_6f9ee4b9","updated":"2017-08-16 00:20:26.000000000","message":"Added.","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f71702f727c7a90a0a5b76a35afe2aeac873f02d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                      deploy\u003dagent.AgentDeploy,"},{"line_number":123,"context_line":"                                      inspect\u003dinspector.Inspector)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@mock.patch.object(importutils, \u0027try_import\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":127,"context_line":"class DracClassicDriversTestCase(BaseIDRACTestCase):"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_2fa45c07","line":125,"updated":"2017-08-15 18:10:11.000000000","message":"network \u0026 storage are the other two, but you are inheriting them so it is probably fine that you don\u0027t test them.","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"2132c7888a5018726beac44d9b85278a2c8c5187","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                      deploy\u003dagent.AgentDeploy,"},{"line_number":123,"context_line":"                                      inspect\u003dinspector.Inspector)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@mock.patch.object(importutils, \u0027try_import\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":127,"context_line":"class DracClassicDriversTestCase(BaseIDRACTestCase):"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_32b95c14","line":125,"in_reply_to":"9f436f4f_2fa45c07","updated":"2017-08-16 00:20:26.000000000","message":"I like leverage :)","commit_id":"58f5eb3edd62a16857ad4bfc608a12ce36800a83"}],"releasenotes/notes/idrac-hardware-type-54383960af3459d0.yaml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"79d00418518fc0520c4cfbd576c38eac853c0ec3","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * boot: ``pxe``"},{"line_number":9,"context_line":"    * console: ``no-console``"},{"line_number":10,"context_line":"    * deploy: ``idrac``, ``iscsi``, and ``direct``"},{"line_number":11,"context_line":"    * inspect: ``idrac``, ``inspector``, and ``no-inspect``"},{"line_number":12,"context_line":"    * management: ``idrac`` and ``redfish``"},{"line_number":13,"context_line":"    * network: ``flat``, ``neutron``, and ``no-op``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f436f4f_b9378cff","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":25},"updated":"2017-08-15 06:37:34.000000000","message":"remove this","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"510180438cfa5cd371b5fa1d5746bfb57049f4c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * boot: ``pxe``"},{"line_number":9,"context_line":"    * console: ``no-console``"},{"line_number":10,"context_line":"    * deploy: ``idrac``, ``iscsi``, and ``direct``"},{"line_number":11,"context_line":"    * inspect: ``idrac``, ``inspector``, and ``no-inspect``"},{"line_number":12,"context_line":"    * management: ``idrac`` and ``redfish``"},{"line_number":13,"context_line":"    * network: ``flat``, ``neutron``, and ``no-op``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f436f4f_7d90e795","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":25},"in_reply_to":"9f436f4f_b9378cff","updated":"2017-08-15 12:36:32.000000000","message":"Done.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4a4558923d122973a308c4961fa926c0396b6355","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * deploy: ``iscsi`` and ``direct``"},{"line_number":11,"context_line":"    * inspect: ``idrac``, ``inspector``, and ``no-inspect``"},{"line_number":12,"context_line":"    * management: ``idrac``"},{"line_number":13,"context_line":"    * network: ``flat``, ``neutron``, and ``no-op``"},{"line_number":14,"context_line":"    * power:  ``idrac``"},{"line_number":15,"context_line":"    * raid: ``idrac`` and ``no-raid``"},{"line_number":16,"context_line":"    * storage: ``noop`` and ``cinder``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_000e14e4","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":49},"updated":"2017-08-15 13:04:29.000000000","message":"s/no-op/noop/\n\nNoop is do nothing. no-* is the feature just doesn\u0027t exist.  One just has pass, the other raises an exception if memory serves.","commit_id":"357a202bbb2050ccaa0ac2b339003c03c9af702b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"54de321a51aa15e9c93b3efd0e77cef05947a276","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * deploy: ``iscsi`` and ``direct``"},{"line_number":11,"context_line":"    * inspect: ``idrac``, ``inspector``, and ``no-inspect``"},{"line_number":12,"context_line":"    * management: ``idrac``"},{"line_number":13,"context_line":"    * network: ``flat``, ``neutron``, and ``no-op``"},{"line_number":14,"context_line":"    * power:  ``idrac``"},{"line_number":15,"context_line":"    * raid: ``idrac`` and ``no-raid``"},{"line_number":16,"context_line":"    * storage: ``noop`` and ``cinder``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_008294c8","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":49},"in_reply_to":"9f436f4f_000e14e4","updated":"2017-08-15 13:16:15.000000000","message":"+1","commit_id":"357a202bbb2050ccaa0ac2b339003c03c9af702b"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"e0d8d43a9f77b71d8c80d55a0e01e81ab781704a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * deploy: ``iscsi`` and ``direct``"},{"line_number":11,"context_line":"    * inspect: ``idrac``, ``inspector``, and ``no-inspect``"},{"line_number":12,"context_line":"    * management: ``idrac``"},{"line_number":13,"context_line":"    * network: ``flat``, ``neutron``, and ``no-op``"},{"line_number":14,"context_line":"    * power:  ``idrac``"},{"line_number":15,"context_line":"    * raid: ``idrac`` and ``no-raid``"},{"line_number":16,"context_line":"    * storage: ``noop`` and ``cinder``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_207d936d","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":49},"in_reply_to":"9f436f4f_008294c8","updated":"2017-08-15 15:39:45.000000000","message":"Nice catch! Thank you.\n\nDone.","commit_id":"357a202bbb2050ccaa0ac2b339003c03c9af702b"}],"setup.cfg":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"79d00418518fc0520c4cfbd576c38eac853c0ec3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":98,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":99,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":100,"context_line":"    idrac \u003d ironic.drivers.modules.drac.deploy:DracDeploy"},{"line_number":101,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":102,"context_line":"    oneview-direct \u003d ironic.drivers.modules.oneview.deploy:OneViewAgentDeploy"},{"line_number":103,"context_line":"    oneview-iscsi \u003d ironic.drivers.modules.oneview.deploy:OneViewIscsiDeploy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"9f436f4f_5961c004","line":100,"updated":"2017-08-15 06:37:34.000000000","message":"this has to be removed as well since\n\nhttps://review.openstack.org/#/c/493421\n\nwas already approved","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"510180438cfa5cd371b5fa1d5746bfb57049f4c1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":98,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":99,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":100,"context_line":"    idrac \u003d ironic.drivers.modules.drac.deploy:DracDeploy"},{"line_number":101,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":102,"context_line":"    oneview-direct \u003d ironic.drivers.modules.oneview.deploy:OneViewAgentDeploy"},{"line_number":103,"context_line":"    oneview-iscsi \u003d ironic.drivers.modules.oneview.deploy:OneViewIscsiDeploy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"9f436f4f_fd5857fa","line":100,"in_reply_to":"9f436f4f_5961c004","updated":"2017-08-15 12:36:32.000000000","message":"Done.","commit_id":"1e12476a52709664a02cb9e57b2374b43bdab6a9"}]}