)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"67ad6eb54f9dff925914effac8315687628effff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"in Ocata release."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9bf56a7088281bbe20b8b6c2e47c6ab6559bfea4"},{"line_number":17,"context_line":"Close-Bug: #1619339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_5669b3f6","line":17,"updated":"2017-09-07 10:52:33.000000000","message":"Closes-Bug","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a4d40fee3d17c56e3ecbef6db03b17125032715","unresolved":false,"context_lines":[{"line_number":14,"context_line":"in Ocata release."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9bf56a7088281bbe20b8b6c2e47c6ab6559bfea4"},{"line_number":17,"context_line":"Close-Bug: #1619339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_09430c15","line":17,"in_reply_to":"7f287b81_5669b3f6","updated":"2017-09-07 11:14:55.000000000","message":"Done","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"}],"devstack/lib/ironic":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c0a2e64a3081551e8f72bf83a818e81ee8d2f77d","unresolved":false,"context_lines":[{"line_number":460,"context_line":"fi"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":463,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":464,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027netboot\u0027 ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027local\u0027 ]; then"},{"line_number":465,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""},{"line_number":466,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f2577a7_dc188282","line":463,"updated":"2017-09-12 12:26:45.000000000","message":"It seems this breaks partitioned jobs, as grub is not installed in cirros","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7211e03373c798407f81071a59a1ada0c19aaf32","unresolved":false,"context_lines":[{"line_number":460,"context_line":"fi"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":463,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":464,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027netboot\u0027 ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027local\u0027 ]; then"},{"line_number":465,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""},{"line_number":466,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f2577a7_a1544b22","line":463,"in_reply_to":"5f2577a7_88a4efba","updated":"2017-09-13 10:40:45.000000000","message":"Have raised review in project-config","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"436e226212f454f2184b5753f12a21e7e333ac3f","unresolved":false,"context_lines":[{"line_number":460,"context_line":"fi"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":463,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":464,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027netboot\u0027 ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027local\u0027 ]; then"},{"line_number":465,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""},{"line_number":466,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f2577a7_88a4efba","line":463,"in_reply_to":"5f2577a7_dc188282","updated":"2017-09-12 15:31:36.000000000","message":"Yes. Should we revert this back to the \u0027netboot\u0027 or change it in the jenkins job? I suppose better to change in the jenkins job. If you agree, can you please let me know how can I change the jenkins job?","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2067b202a80ff8093d5c16af949242b347106adc","unresolved":false,"context_lines":[{"line_number":462,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":463,"context_line":"# TODO(stendulker): Will change this in separate patch as it needs corresponding"},{"line_number":464,"context_line":"# changes in the Ironic jenkins jobs."},{"line_number":465,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-netboot}"},{"line_number":466,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027netboot\u0027 ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \u0027local\u0027 ]; then"},{"line_number":467,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""},{"line_number":468,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f2577a7_07fbd346","line":465,"range":{"start_line":465,"start_character":60,"end_line":465,"end_character":61},"updated":"2017-09-18 08:14:38.000000000","message":"we need to test partitioned image with local boot on CI, please put this change on hold unless CI part is done (me working on this with good progress)","commit_id":"5fe2084fc350ec40ad6353e0bfebfed544d699df"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"437ab0fcd12f56d45c157793ff20fcf04f70bf78","unresolved":false,"context_lines":[{"line_number":571,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":572,"context_line":"# TODO(stendulker): Will change this in separate patch as it needs corresponding"},{"line_number":573,"context_line":"# changes in the Ironic jenkins jobs."},{"line_number":574,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-netboot}"},{"line_number":575,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"netboot\" ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"local\" ]; then"},{"line_number":576,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""},{"line_number":577,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"3fa7e38b_dd566bce","line":574,"range":{"start_line":574,"start_character":57,"end_line":574,"end_character":64},"updated":"2020-02-19 02:47:55.000000000","message":"it seems we can replace this with local now, if every job is updated.","commit_id":"07c616d7d57dd4e959cde24610f3ebcb18d57c4f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b793db5f188f547d4090dc10d742b3f084188b3","unresolved":false,"context_lines":[{"line_number":572,"context_line":"fi"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":575,"context_line":"# TODO(stendulker): Will change this in separate patch as it needs corresponding"},{"line_number":576,"context_line":"# changes in the Ironic jenkins jobs."},{"line_number":577,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":578,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"netboot\" ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"local\" ]; then"},{"line_number":579,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"df33271e_088c5934","line":576,"range":{"start_line":575,"start_character":0,"end_line":576,"end_character":37},"updated":"2020-03-30 14:38:07.000000000","message":"I don\u0027t think I get this comment. What exactly will be changed separately?","commit_id":"8d9714c804bc1ad465823369ad92a1758c115d7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"60e8695695cab3df6dd11e311f378e2b1cd4278b","unresolved":false,"context_lines":[{"line_number":572,"context_line":"fi"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":575,"context_line":"# TODO(stendulker): Will change this in separate patch as it needs corresponding"},{"line_number":576,"context_line":"# changes in the Ironic jenkins jobs."},{"line_number":577,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":578,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"netboot\" ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"local\" ]; then"},{"line_number":579,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"df33271e_f4d3d05e","line":576,"range":{"start_line":575,"start_character":0,"end_line":576,"end_character":37},"in_reply_to":"df33271e_088c5934","updated":"2020-03-30 17:14:33.000000000","message":"I don\u0027t think it corresponds, we\u0027ve already changed jobs accordingly.. at least afaik.","commit_id":"8d9714c804bc1ad465823369ad92a1758c115d7a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3be7a7ad6d7b7453073083a7ee8570465fe585ce","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    fi"},{"line_number":572,"context_line":"fi"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":575,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":576,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"netboot\" ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"local\" ]; then"},{"line_number":577,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""}],"source_content_type":"application/x-shellscript","patch_set":30,"id":"df33271e_aa6a6a16","line":574,"updated":"2020-03-31 13:46:19.000000000","message":"I think this TODO can also be removed","commit_id":"78ade3e64902deaac004a666541fca31584e318a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3bc54c4f3829b578cefe6de56bab2096b667a919","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    fi"},{"line_number":572,"context_line":"fi"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# TODO(dtantsur): change this when we change the default value."},{"line_number":575,"context_line":"IRONIC_DEFAULT_BOOT_OPTION\u003d${IRONIC_DEFAULT_BOOT_OPTION:-local}"},{"line_number":576,"context_line":"if [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"netboot\" ] \u0026\u0026 [ $IRONIC_DEFAULT_BOOT_OPTION !\u003d \"local\" ]; then"},{"line_number":577,"context_line":"    die $LINENO \"Supported values for IRONIC_DEFAULT_BOOT_OPTION are \u0027netboot\u0027 and \u0027local\u0027 only.\""}],"source_content_type":"application/x-shellscript","patch_set":30,"id":"df33271e_85e799ac","line":574,"in_reply_to":"df33271e_aa6a6a16","updated":"2020-03-31 14:18:13.000000000","message":"Yes, it does seem that way.","commit_id":"78ade3e64902deaac004a666541fca31584e318a"}],"ironic/conf/deploy.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4b3299419a49d748e65050df3d29ba0220557dfc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":67,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027default_boot_option\u0027,"},{"line_number":69,"context_line":"               choices\u003d[\u0027netboot\u0027, \u0027local\u0027],"},{"line_number":70,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":71,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Currently the \u0027"},{"line_number":72,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_96f71b5a","line":69,"updated":"2017-09-07 10:52:18.000000000","message":"why not add default\u003dlocal here?","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a4d40fee3d17c56e3ecbef6db03b17125032715","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":67,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027default_boot_option\u0027,"},{"line_number":69,"context_line":"               choices\u003d[\u0027netboot\u0027, \u0027local\u0027],"},{"line_number":70,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":71,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Currently the \u0027"},{"line_number":72,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_894edc35","line":69,"in_reply_to":"7f287b81_96f71b5a","updated":"2017-09-07 11:14:55.000000000","message":"Done","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4f048d64bf62194cc03619bcf3629ab4e405689b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               choices\u003d[\u0027local\u0027, \u0027netboot\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Currently the \u0027"},{"line_number":73,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"},{"line_number":74,"context_line":"                      \u0027default was \"netboot\". This can be changed on the \u0027"},{"line_number":75,"context_line":"                      \u0027node level via the \"boot_option\" parameter.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_0c48ba84","line":72,"range":{"start_line":72,"start_character":23,"end_line":72,"end_character":55},"updated":"2017-09-07 12:12:06.000000000","message":"I can not find in the code where boot option handled via driver_info.","commit_id":"8230211e56b9070e777642d70ff412bcac152a7e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"67306a775295c68916d7430e33782c8eb06eaab4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               choices\u003d[\u0027local\u0027, \u0027netboot\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Currently the \u0027"},{"line_number":73,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"},{"line_number":74,"context_line":"                      \u0027default was \"netboot\". This can be changed on the \u0027"},{"line_number":75,"context_line":"                      \u0027node level via the \"boot_option\" parameter.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_9665d0b7","line":72,"range":{"start_line":72,"start_character":23,"end_line":72,"end_character":55},"in_reply_to":"7f287b81_0c48ba84","updated":"2017-09-07 16:24:57.000000000","message":"Oops, It should be \u0027capabilities\u0027.","commit_id":"8230211e56b9070e777642d70ff412bcac152a7e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f423e18b5e0dfc455586529cf26474a32c883606","unresolved":false,"context_lines":[{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s capabilities. Currently the \u0027"},{"line_number":73,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"},{"line_number":74,"context_line":"                      \u0027default was \"netboot\". This can be changed on the \u0027"},{"line_number":75,"context_line":"                      \u0027node level via the \"boot_option\" capability.\u0027)),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":77,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_05987272","line":74,"range":{"start_line":73,"start_character":56,"end_line":74,"end_character":43},"updated":"2017-09-08 09:15:47.000000000","message":"This sentence is not needed because there are only two values.","commit_id":"eca62bdb503a8117a50fadc7deaca416f9f17a37"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6cd07cb0a598e8b04d21b2f59ed8a3556d698021","unresolved":false,"context_lines":[{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s capabilities. Currently the \u0027"},{"line_number":73,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"},{"line_number":74,"context_line":"                      \u0027default was \"netboot\". This can be changed on the \u0027"},{"line_number":75,"context_line":"                      \u0027node level via the \"boot_option\" capability.\u0027)),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":77,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_65dbb6ec","line":74,"range":{"start_line":73,"start_character":56,"end_line":74,"end_character":43},"in_reply_to":"7f287b81_05987272","updated":"2017-09-08 09:24:03.000000000","message":"Done","commit_id":"eca62bdb503a8117a50fadc7deaca416f9f17a37"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f423e18b5e0dfc455586529cf26474a32c883606","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s capabilities. Currently the \u0027"},{"line_number":73,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"},{"line_number":74,"context_line":"                      \u0027default was \"netboot\". This can be changed on the \u0027"},{"line_number":75,"context_line":"                      \u0027node level via the \"boot_option\" capability.\u0027)),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":77,"context_line":"                default\u003dFalse,"},{"line_number":78,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_a5807ef8","line":75,"range":{"start_line":74,"start_character":46,"end_line":75,"end_character":67},"updated":"2017-09-08 09:15:47.000000000","message":"Probably this can be merged with first sentence.","commit_id":"eca62bdb503a8117a50fadc7deaca416f9f17a37"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6cd07cb0a598e8b04d21b2f59ed8a3556d698021","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s capabilities. Currently the \u0027"},{"line_number":73,"context_line":"                      \u0027default is \"local\" as of Queens. The previous \u0027"},{"line_number":74,"context_line":"                      \u0027default was \"netboot\". This can be changed on the \u0027"},{"line_number":75,"context_line":"                      \u0027node level via the \"boot_option\" capability.\u0027)),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":77,"context_line":"                default\u003dFalse,"},{"line_number":78,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_85d222d0","line":75,"range":{"start_line":74,"start_character":46,"end_line":75,"end_character":67},"in_reply_to":"7f287b81_a5807ef8","updated":"2017-09-08 09:24:03.000000000","message":"Done","commit_id":"eca62bdb503a8117a50fadc7deaca416f9f17a37"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"4e6117044c7c16329fdb5bf8013b84d03612f668","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               choices\u003d[\u0027local\u0027, \u0027netboot\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s \"boot_option\" capability. \u0027"},{"line_number":73,"context_line":"                      \u0027Currently the default is \"local\" as of Queens.\u0027)),"},{"line_number":74,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":75,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_3afadd74","line":72,"range":{"start_line":72,"start_character":45,"end_line":72,"end_character":56},"updated":"2017-09-12 18:51:42.000000000","message":"nit:s/boot_option/default_boot_option, just to be consistent and not confuse the user","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc62786297f50c2feef11e9748bccd852b6eec64","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               choices\u003d[\u0027local\u0027, \u0027netboot\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":72,"context_line":"                      \u0027requested in node\\\u0027s \"boot_option\" capability. \u0027"},{"line_number":73,"context_line":"                      \u0027Currently the default is \"local\" as of Queens.\u0027)),"},{"line_number":74,"context_line":"    cfg.BoolOpt(\u0027configdrive_use_object_store\u0027,"},{"line_number":75,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_b5992d7a","line":72,"range":{"start_line":72,"start_character":45,"end_line":72,"end_character":56},"in_reply_to":"5f2577a7_3afadd74","updated":"2017-09-13 05:11:16.000000000","message":"\u0027boot_option\u0027 is the name of the capability that can be set on the individual node to override conductor level setting of  \u0027default_boot_option\u0027.","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34c90d602574e7070e30c09525b7fd3981738461","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Stein release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_4267e54e","line":86,"range":{"start_line":86,"start_character":46,"end_line":86,"end_character":51},"updated":"2019-07-08 15:03:29.000000000","message":"Train","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9aa94cc717c5eaf381061570b6ff10c2f36f9b8a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Stein release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_4dd81f52","line":86,"range":{"start_line":86,"start_character":46,"end_line":86,"end_character":51},"in_reply_to":"7faddb67_4267e54e","updated":"2019-08-19 21:24:37.000000000","message":"Done","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"72d01636aeb31636d11f0105ae3b8b4743db2b16","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Train release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_1c7d29b1","line":86,"range":{"start_line":86,"start_character":24,"end_line":86,"end_character":30},"updated":"2020-02-07 09:25:34.000000000","message":"nit: local","commit_id":"f07a40054ca9ea0c19f497e2353d337f8b470f36"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b6426bee727103b1dbaa6d07d9c750df693c62df","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Train release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_0c0486c4","line":86,"updated":"2019-12-24 07:39:06.000000000","message":"s/locall/local/","commit_id":"e5d7dea5c73b84d8a453af82fff4d56058bd21e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dca161ba374967f18746ad8da38f4b0ce3713633","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Train release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_cc64b1b6","line":86,"in_reply_to":"3fa7e38b_0c0486c4","updated":"2020-02-15 03:48:07.000000000","message":"Done","commit_id":"e5d7dea5c73b84d8a453af82fff4d56058bd21e4"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b6426bee727103b1dbaa6d07d9c750df693c62df","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Train release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"},{"line_number":90,"context_line":"                        (boot_modes.LEGACY_BIOS, _(\u0027Legacy BIOS boot mode\u0027))],"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_cc0d0ee8","line":87,"range":{"start_line":86,"start_character":33,"end_line":87,"end_character":38},"updated":"2019-12-24 07:39:06.000000000","message":"Is it needed to mention that netboot was the default earlier?","commit_id":"e5d7dea5c73b84d8a453af82fff4d56058bd21e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dca161ba374967f18746ad8da38f4b0ce3713633","unresolved":false,"context_lines":[{"line_number":83,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":84,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":85,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Defaults to \u0027"},{"line_number":86,"context_line":"                      \u0027\"locall\". Prior to the Train release, the default \u0027"},{"line_number":87,"context_line":"                      \u0027was \"netboot\".\u0027)),"},{"line_number":88,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":89,"context_line":"               choices\u003d[(boot_modes.UEFI, _(\u0027UEFI boot mode\u0027)),"},{"line_number":90,"context_line":"                        (boot_modes.LEGACY_BIOS, _(\u0027Legacy BIOS boot mode\u0027))],"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_2c6a2581","line":87,"range":{"start_line":86,"start_character":33,"end_line":87,"end_character":38},"in_reply_to":"3fa7e38b_cc0d0ee8","updated":"2020-02-15 03:48:07.000000000","message":"likely, we kind of announced we would change this back in kilo....","commit_id":"e5d7dea5c73b84d8a453af82fff4d56058bd21e4"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a5c18c5ac551e5a8b5f387f1e0e7a5c867746c95","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                # TODO(stendulker): Fail here once the default boot"},{"line_number":550,"context_line":"                # option is local."},{"line_number":551,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":552,"context_line":"                # masks the failure as it can be percieved as both an"},{"line_number":553,"context_line":"                # invalid configuration and a resulting default for people"},{"line_number":554,"context_line":"                # that people that do not tune the setting."},{"line_number":555,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_a22499c7","line":552,"range":{"start_line":552,"start_character":49,"end_line":552,"end_character":58},"updated":"2019-07-08 15:15:26.000000000","message":"nit: perceived","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9aa94cc717c5eaf381061570b6ff10c2f36f9b8a","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                # TODO(stendulker): Fail here once the default boot"},{"line_number":550,"context_line":"                # option is local."},{"line_number":551,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":552,"context_line":"                # masks the failure as it can be percieved as both an"},{"line_number":553,"context_line":"                # invalid configuration and a resulting default for people"},{"line_number":554,"context_line":"                # that people that do not tune the setting."},{"line_number":555,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_0d9a2761","line":552,"range":{"start_line":552,"start_character":49,"end_line":552,"end_character":58},"in_reply_to":"7faddb67_a22499c7","updated":"2019-08-19 21:24:37.000000000","message":"Done.","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a5c18c5ac551e5a8b5f387f1e0e7a5c867746c95","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":552,"context_line":"                # masks the failure as it can be percieved as both an"},{"line_number":553,"context_line":"                # invalid configuration and a resulting default for people"},{"line_number":554,"context_line":"                # that people that do not tune the setting."},{"line_number":555,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":556,"context_line":"                    instance_info \u003d node.instance_info"},{"line_number":557,"context_line":"                    capabilities \u003d utils.parse_instance_info_capabilities(node)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_d52151a1","line":554,"updated":"2019-07-08 15:15:26.000000000","message":"mmm a bit confusing for me :/","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9aa94cc717c5eaf381061570b6ff10c2f36f9b8a","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":552,"context_line":"                # masks the failure as it can be percieved as both an"},{"line_number":553,"context_line":"                # invalid configuration and a resulting default for people"},{"line_number":554,"context_line":"                # that people that do not tune the setting."},{"line_number":555,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":556,"context_line":"                    instance_info \u003d node.instance_info"},{"line_number":557,"context_line":"                    capabilities \u003d utils.parse_instance_info_capabilities(node)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_ada2f398","line":554,"in_reply_to":"7faddb67_d52151a1","updated":"2019-08-19 21:24:37.000000000","message":"Reworded, even I\u0027m moderately confused but I know what I was trying to get across.","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"72d01636aeb31636d11f0105ae3b8b4743db2b16","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                # option is local."},{"line_number":558,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":559,"context_line":"                # masks the failure as the lack of a user definition"},{"line_number":560,"context_line":"                # can be perceived as both an invalid configuraiton and"},{"line_number":561,"context_line":"                # reliance upon the default configuration. The reality"},{"line_number":562,"context_line":"                # being that in most scenarios, users do not want network"},{"line_number":563,"context_line":"                # booting, so the changed default should be valid."}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_3c7825bf","line":560,"range":{"start_line":560,"start_character":54,"end_line":560,"end_character":67},"updated":"2020-02-07 09:25:34.000000000","message":"nit: configuration","commit_id":"f07a40054ca9ea0c19f497e2353d337f8b470f36"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b6426bee727103b1dbaa6d07d9c750df693c62df","unresolved":false,"context_lines":[{"line_number":552,"context_line":"                # option is local."},{"line_number":553,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":554,"context_line":"                # masks the failure as the lack of a user definition"},{"line_number":555,"context_line":"                # can be perceived as both an invalid configuraiton and"},{"line_number":556,"context_line":"                # reliance upon the default configuration. The reality"},{"line_number":557,"context_line":"                # being that in most scenarios, users do not want network"},{"line_number":558,"context_line":"                # booting, so the changed default should be valid."}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_6cf41ad1","line":555,"range":{"start_line":555,"start_character":54,"end_line":555,"end_character":67},"updated":"2019-12-24 07:39:06.000000000","message":"s/configuraiton/configuration/","commit_id":"e5d7dea5c73b84d8a453af82fff4d56058bd21e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dca161ba374967f18746ad8da38f4b0ce3713633","unresolved":false,"context_lines":[{"line_number":552,"context_line":"                # option is local."},{"line_number":553,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":554,"context_line":"                # masks the failure as the lack of a user definition"},{"line_number":555,"context_line":"                # can be perceived as both an invalid configuraiton and"},{"line_number":556,"context_line":"                # reliance upon the default configuration. The reality"},{"line_number":557,"context_line":"                # being that in most scenarios, users do not want network"},{"line_number":558,"context_line":"                # booting, so the changed default should be valid."}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_4c0681ce","line":555,"range":{"start_line":555,"start_character":54,"end_line":555,"end_character":67},"in_reply_to":"3fa7e38b_6cf41ad1","updated":"2020-02-15 03:48:07.000000000","message":"Done","commit_id":"e5d7dea5c73b84d8a453af82fff4d56058bd21e4"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"437ab0fcd12f56d45c157793ff20fcf04f70bf78","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                # can be perceived as both an invalid configuration and"},{"line_number":548,"context_line":"                # reliance upon the default configuration. The reality"},{"line_number":549,"context_line":"                # being that in most scenarios, users do not want network"},{"line_number":550,"context_line":"                # booting, so the changed default should be valid."},{"line_number":551,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":552,"context_line":"                    instance_info \u003d node.instance_info"},{"line_number":553,"context_line":"                    capabilities \u003d utils.parse_instance_info_capabilities(node)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_dd3d0b8e","line":550,"updated":"2020-02-19 02:47:55.000000000","message":"It seems we only validate network for agent, but not iscsi, is this a historical reason?","commit_id":"07c616d7d57dd4e959cde24610f3ebcb18d57c4f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5382be35b6222cff9d53cc16feae63dc1a99f058","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                # can be perceived as both an invalid configuration and"},{"line_number":548,"context_line":"                # reliance upon the default configuration. The reality"},{"line_number":549,"context_line":"                # being that in most scenarios, users do not want network"},{"line_number":550,"context_line":"                # booting, so the changed default should be valid."},{"line_number":551,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":552,"context_line":"                    instance_info \u003d node.instance_info"},{"line_number":553,"context_line":"                    capabilities \u003d utils.parse_instance_info_capabilities(node)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_2c2090f9","line":550,"in_reply_to":"3fa7e38b_dd3d0b8e","updated":"2020-02-20 19:33:20.000000000","message":"Somewhat yes, but I honestly don\u0027t remember what drove this note. Agent came from a larger distributed environment where performance for deployment was key as well as concurrency. Iscsi remained the focus of the smaller \"initial installation\" cases. Iscsi has also remained largely focused on partition image deployment which is where the boot setting begins to cause us all sorts of issues. Trying to get away from netbooting has long been a goal for me and that just also makes CI a bit better because then we don\u0027t hit as many network booting issues in CI.","commit_id":"07c616d7d57dd4e959cde24610f3ebcb18d57c4f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cfdce65777809431660901e9e1cf723764972515","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                # \u0027instance_info\u0027 to \u0027local for backward compatibility."},{"line_number":564,"context_line":"                # TODO(stendulker): Fail here once the default boot"},{"line_number":565,"context_line":"                # option is local."},{"line_number":566,"context_line":"                # NOTE(TheJulia): Fixing the default boot mode only"},{"line_number":567,"context_line":"                # masks the failure as the lack of a user definition"},{"line_number":568,"context_line":"                # can be perceived as both an invalid configuration and"},{"line_number":569,"context_line":"                # reliance upon the default configuration. The reality"}],"source_content_type":"text/x-python","patch_set":33,"id":"3f4c43b2_e40ef5e3","line":566,"range":{"start_line":566,"start_character":58,"end_line":566,"end_character":62},"updated":"2020-04-14 04:08:42.000000000","message":"s/ mode / option /","commit_id":"4a4730e530d5a2452771f88c410a2b4719e4322b"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4b3299419a49d748e65050df3d29ba0220557dfc","unresolved":false,"context_lines":[{"line_number":923,"context_line":""},{"line_number":924,"context_line":"def get_default_boot_option():"},{"line_number":925,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":926,"context_line":"    return CONF.deploy.default_boot_option or \u0027local\u0027"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"def get_boot_option(node):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b68fb7cb","line":926,"range":{"start_line":926,"start_character":47,"end_line":926,"end_character":52},"updated":"2017-09-07 10:52:18.000000000","message":"not needed if set default for default_boot_option in config option.","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a4d40fee3d17c56e3ecbef6db03b17125032715","unresolved":false,"context_lines":[{"line_number":923,"context_line":""},{"line_number":924,"context_line":"def get_default_boot_option():"},{"line_number":925,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":926,"context_line":"    return CONF.deploy.default_boot_option or \u0027local\u0027"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"def get_boot_option(node):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_2957e8cc","line":926,"range":{"start_line":926,"start_character":47,"end_line":926,"end_character":52},"in_reply_to":"7f287b81_b68fb7cb","updated":"2017-09-07 11:14:55.000000000","message":"Done","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c0a2e64a3081551e8f72bf83a818e81ee8d2f77d","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        partition table has not changed)."},{"line_number":359,"context_line":"    :param configdrive: Optional. Base64 encoded Gzipped configdrive content"},{"line_number":360,"context_line":"                        or configdrive HTTP URL."},{"line_number":361,"context_line":"    :param boot_option: Can be \"local\" or \"netboot\". \"netboot\" by default."},{"line_number":362,"context_line":"    :param boot_mode: Can be \"bios\" or \"uefi\". \"bios\" by default."},{"line_number":363,"context_line":"    :param disk_label: The disk label to be used when creating the"},{"line_number":364,"context_line":"        partition table. Valid values are: \"msdos\", \"gpt\" or None; If None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_bc0db63f","line":361,"range":{"start_line":361,"start_character":53,"end_line":361,"end_character":73},"updated":"2017-09-12 12:26:45.000000000","message":"not a default anymore.","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"436e226212f454f2184b5753f12a21e7e333ac3f","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        partition table has not changed)."},{"line_number":359,"context_line":"    :param configdrive: Optional. Base64 encoded Gzipped configdrive content"},{"line_number":360,"context_line":"                        or configdrive HTTP URL."},{"line_number":361,"context_line":"    :param boot_option: Can be \"local\" or \"netboot\". \"netboot\" by default."},{"line_number":362,"context_line":"    :param boot_mode: Can be \"bios\" or \"uefi\". \"bios\" by default."},{"line_number":363,"context_line":"    :param disk_label: The disk label to be used when creating the"},{"line_number":364,"context_line":"        partition table. Valid values are: \"msdos\", \"gpt\" or None; If None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_6884230d","line":361,"range":{"start_line":361,"start_character":53,"end_line":361,"end_character":73},"in_reply_to":"5f2577a7_bc0db63f","updated":"2017-09-12 15:31:36.000000000","message":"Yes. Will change in the next patch.","commit_id":"d5fc1eaadbac85574bc3f90db66d9cb812abcc16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34c90d602574e7070e30c09525b7fd3981738461","unresolved":false,"context_lines":[{"line_number":843,"context_line":"            \"%(properties)s\") % {\u0027image\u0027: image_href, \u0027properties\u0027: props})"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"def get_default_boot_option():"},{"line_number":847,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":848,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Train."},{"line_number":849,"context_line":"    return CONF.deploy.default_boot_option or \u0027local\u0027"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"def get_boot_option(node):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_22c74915","line":849,"range":{"start_line":846,"start_character":0,"end_line":849,"end_character":53},"updated":"2019-07-08 15:03:29.000000000","message":"This is not needed at all, just use the CONF value (it cannot be None any more)","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4fb480e8de3d9754d9d8da4779a71e229c0c6b63","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"def get_default_boot_option():"},{"line_number":846,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":847,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Train."},{"line_number":848,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3fa7e38b_0a961ff0","line":847,"range":{"start_line":847,"start_character":47,"end_line":847,"end_character":52},"updated":"2020-02-17 13:26:37.000000000","message":"nit: Ussuri ?","commit_id":"8dbbd12046212fbf56f3d1cfd5f357c5fa5ce25f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"992cb5781bfc5d60e3a75f8d6d26c3ca7e10c7ff","unresolved":false,"context_lines":[{"line_number":844,"context_line":""},{"line_number":845,"context_line":"def get_default_boot_option():"},{"line_number":846,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":847,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Train."},{"line_number":848,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3fa7e38b_507fd9dd","line":847,"range":{"start_line":847,"start_character":47,"end_line":847,"end_character":52},"in_reply_to":"3fa7e38b_0a961ff0","updated":"2020-02-18 02:10:14.000000000","message":"yeah... I\u0027ve been trying to get this merged since? before stein?","commit_id":"8dbbd12046212fbf56f3d1cfd5f357c5fa5ce25f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b793db5f188f547d4090dc10d742b3f084188b3","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"def get_default_boot_option():"},{"line_number":499,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":500,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Ussuri."},{"line_number":501,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"df33271e_4897813b","line":500,"range":{"start_line":500,"start_character":0,"end_line":500,"end_character":54},"updated":"2020-03-30 14:38:07.000000000","message":"Why not remove now? If you assume 3rdparty drivers are using it, let\u0027s issue a warning.","commit_id":"8d9714c804bc1ad465823369ad92a1758c115d7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"60e8695695cab3df6dd11e311f378e2b1cd4278b","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"def get_default_boot_option():"},{"line_number":499,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":500,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Ussuri."},{"line_number":501,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"df33271e_74c7c097","line":500,"range":{"start_line":500,"start_character":0,"end_line":500,"end_character":54},"in_reply_to":"df33271e_4897813b","updated":"2020-03-30 17:14:33.000000000","message":"I\u0027ll follow-up with a warning.","commit_id":"8d9714c804bc1ad465823369ad92a1758c115d7a"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"54cb53189292012c580a34b7a50d10a9cf720c6c","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"def get_default_boot_option():"},{"line_number":499,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":500,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Ussuri."},{"line_number":501,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"3f4c43b2_c92674b8","line":500,"range":{"start_line":500,"start_character":22,"end_line":500,"end_character":54},"updated":"2020-04-14 01:57:57.000000000","message":"Not sure about this, it means we will deprecate the CONF.deploy.default_boot_option or just this method?\nSince this patch does deprecate the configuration option, I will take latter case as granted.","commit_id":"4a4730e530d5a2452771f88c410a2b4719e4322b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"147f1867b6d1ad421ede2dc6362bb47917caccaf","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"def get_default_boot_option():"},{"line_number":499,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":500,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Ussuri."},{"line_number":501,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"3f4c43b2_3da2a49b","line":500,"range":{"start_line":500,"start_character":22,"end_line":500,"end_character":54},"in_reply_to":"3f4c43b2_04f5e1cb","updated":"2020-04-14 13:28:08.000000000","message":"I think the idea would be deprecate this and only use get_boot_option...In the follow-up there is a change to add a warning here\n\n@Julia maybe you missed the deploy_utils.get_default_boot_option() in ironic/drivers/modules/iscsi_deploy.py","commit_id":"4a4730e530d5a2452771f88c410a2b4719e4322b"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"71864634c5a4bcc00d870dacf85e28efb51f4f5a","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"def get_default_boot_option():"},{"line_number":499,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":500,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Ussuri."},{"line_number":501,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"3f4c43b2_cc73ed7f","line":500,"range":{"start_line":500,"start_character":22,"end_line":500,"end_character":54},"in_reply_to":"3f4c43b2_3da2a49b","updated":"2020-04-16 08:21:45.000000000","message":"It will be covered by unittests, so I think we won\u0027t miss it.","commit_id":"4a4730e530d5a2452771f88c410a2b4719e4322b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cfdce65777809431660901e9e1cf723764972515","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"def get_default_boot_option():"},{"line_number":499,"context_line":"    \"\"\"Gets the default boot option.\"\"\""},{"line_number":500,"context_line":"    # TODO(TheJulia): Deprecated: Remove after Ussuri."},{"line_number":501,"context_line":"    return CONF.deploy.default_boot_option"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"3f4c43b2_04f5e1cb","line":500,"range":{"start_line":500,"start_character":22,"end_line":500,"end_character":54},"in_reply_to":"3f4c43b2_c92674b8","updated":"2020-04-14 04:08:42.000000000","message":"I did not get it either. This patch does not deprecate CONF.deploy.default_boot_option, it is just changing the default value. I suppose one can still go ahead and change the value of CONF.deploy.default_boot_option to \u0027netboot\u0027.","commit_id":"4a4730e530d5a2452771f88c410a2b4719e4322b"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a5c18c5ac551e5a8b5f387f1e0e7a5c867746c95","unresolved":false,"context_lines":[{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"    def test_get_instance_image_info(self):"},{"line_number":1163,"context_line":"        # Tests when \u0027is_whole_disk_image\u0027 exists in driver_internal_info"},{"line_number":1164,"context_line":"        # NOTE(TheJulia): The method being tested is primarilly geared for"},{"line_number":1165,"context_line":"        # only netboot operation as the information should only need to be"},{"line_number":1166,"context_line":"        # looked up again during network booting."},{"line_number":1167,"context_line":"        self.config(group\u003d\"deploy\", default_boot_option\u003d\"netboot\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_35046515","line":1164,"range":{"start_line":1164,"start_character":53,"end_line":1164,"end_character":63},"updated":"2019-07-08 15:15:26.000000000","message":"nit: primarily","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a5c18c5ac551e5a8b5f387f1e0e7a5c867746c95","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        self._test_get_instance_image_info()"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    def test_get_instance_image_info_without_is_whole_disk_image(self):"},{"line_number":1171,"context_line":"        # NOTE(TheJulia): The method being tested is primarilly geared for"},{"line_number":1172,"context_line":"        # only netboot operation as the information should only need to be"},{"line_number":1173,"context_line":"        # looked up again during network booting."},{"line_number":1174,"context_line":"        self.config(group\u003d\"deploy\", default_boot_option\u003d\"netboot\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_f50d6d37","line":1171,"range":{"start_line":1171,"start_character":53,"end_line":1171,"end_character":63},"updated":"2019-07-08 15:15:26.000000000","message":"nit: primarily","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"}],"releasenotes/notes/change-default-boot-option-to-local-8c326077770ab672.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4b3299419a49d748e65050df3d29ba0220557dfc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The default value of ``[deploy]/default_boot_option`` is changed from"},{"line_number":9,"context_line":"    ``netboot`` to ``local``. See"},{"line_number":10,"context_line":"    `bug 1619339 \u003chttps://bugs.launchpad.net/ironic/+bug/1619339\u003e`_ for details."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_f6b2df93","line":9,"updated":"2017-09-07 10:52:18.000000000","message":"we can\u0027t mention RFE as fixed bug as it is not actually bug.","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a4d40fee3d17c56e3ecbef6db03b17125032715","unresolved":false,"context_lines":[{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The default value of ``[deploy]/default_boot_option`` is changed from"},{"line_number":9,"context_line":"    ``netboot`` to ``local``. See"},{"line_number":10,"context_line":"    `bug 1619339 \u003chttps://bugs.launchpad.net/ironic/+bug/1619339\u003e`_ for details."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_a96ab87d","line":9,"in_reply_to":"7f287b81_f6b2df93","updated":"2017-09-07 11:14:55.000000000","message":"Done","commit_id":"1746517a1fa522d86bb059c30d1799e06fe342e8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34c90d602574e7070e30c09525b7fd3981738461","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default value of ``[deploy]/default_boot_option`` is changed from"},{"line_number":5,"context_line":"    ``netboot`` to ``local``."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_02d6cdc6","line":5,"updated":"2019-07-08 15:03:29.000000000","message":"Maybe elaborate on what it means for end users? E.g. partition images must have Grub2?","commit_id":"6b18f4858e78c1ef47017dfaad4b37abd6f08839"}],"zuul.d/ironic-jobs.yaml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"39e7fb84b5f415aac65361c6eb50ade3f51c5723","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        s-proxy: True"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"- job:"},{"line_number":138,"context_line":"    name: ironic-tempest-partition-bios-redfish-pxe"},{"line_number":139,"context_line":"    description: \"Deploy ironic node over PXE using BIOS boot mode\""},{"line_number":140,"context_line":"    parent: ironic-base"},{"line_number":141,"context_line":"    timeout: 5400"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_e11cba7d","line":138,"range":{"start_line":138,"start_character":10,"end_line":138,"end_character":51},"updated":"2020-02-21 05:57:14.000000000","message":"it appears this job is missing required netboot override.","commit_id":"d24864658539e02183a7a43a40bed2be28dbfd1a"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"39e7fb84b5f415aac65361c6eb50ade3f51c5723","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        IRONIC_AUTOMATED_CLEAN_ENABLED: False"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"- job:"},{"line_number":153,"context_line":"    name: ironic-tempest-partition-uefi-redfish-vmedia"},{"line_number":154,"context_line":"    description: \"Deploy ironic node over Redfish virtual media using UEFI boot mode\""},{"line_number":155,"context_line":"    parent: ironic-tempest-partition-bios-redfish-pxe"},{"line_number":156,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_a126c2cb","line":153,"range":{"start_line":153,"start_character":10,"end_line":153,"end_character":54},"updated":"2020-02-21 05:57:14.000000000","message":"ditto","commit_id":"d24864658539e02183a7a43a40bed2be28dbfd1a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b793db5f188f547d4090dc10d742b3f084188b3","unresolved":false,"context_lines":[{"line_number":232,"context_line":"      devstack_localrc:"},{"line_number":233,"context_line":"        IRONIC_ENABLED_HARDWARE_TYPES: snmp"},{"line_number":234,"context_line":"        IRONIC_DEPLOY_DRIVER: snmp"},{"line_number":235,"context_line":"        IRONIC_DEFAULT_BOOT_OPTION: netboot"},{"line_number":236,"context_line":"        IRONIC_TEMPEST_WHOLE_DISK_IMAGE: True"},{"line_number":237,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 0"},{"line_number":238,"context_line":"        IRONIC_AUTOMATED_CLEAN_ENABLED: False"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"df33271e_e8e3f5d7","line":235,"updated":"2020-03-30 14:38:07.000000000","message":"This is a whole disk image job, why is it using netboot?","commit_id":"8d9714c804bc1ad465823369ad92a1758c115d7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"60e8695695cab3df6dd11e311f378e2b1cd4278b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"      devstack_localrc:"},{"line_number":233,"context_line":"        IRONIC_ENABLED_HARDWARE_TYPES: snmp"},{"line_number":234,"context_line":"        IRONIC_DEPLOY_DRIVER: snmp"},{"line_number":235,"context_line":"        IRONIC_DEFAULT_BOOT_OPTION: netboot"},{"line_number":236,"context_line":"        IRONIC_TEMPEST_WHOLE_DISK_IMAGE: True"},{"line_number":237,"context_line":"        IRONIC_VM_EPHEMERAL_DISK: 0"},{"line_number":238,"context_line":"        IRONIC_AUTOMATED_CLEAN_ENABLED: False"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"df33271e_d43dec8f","line":235,"in_reply_to":"df33271e_e8e3f5d7","updated":"2020-03-30 17:14:33.000000000","message":"Great question! :(","commit_id":"8d9714c804bc1ad465823369ad92a1758c115d7a"}]}