)]}'
{"devstack/upgrade/resources.sh":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cf3b2cd02c9f7d2e040270d46b8a1cf61d3c3ed5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        create"},{"line_number":140,"context_line":"        ;;"},{"line_number":141,"context_line":"    \"verify_noapi\")"},{"line_number":142,"context_line":"        verify_noapi $2"},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify $2"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9f436f4f_b776706f","line":142,"updated":"2017-08-15 11:03:07.000000000","message":"we don\u0027t use it yet, but still pass it inside, just in case","commit_id":"c9fb0cc3410975972d74c0f4a0d6dd08671bf4cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d250e2e583b1dd7b5c308b6dd82d351af98c03f8","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        create"},{"line_number":140,"context_line":"        ;;"},{"line_number":141,"context_line":"    \"verify_noapi\")"},{"line_number":142,"context_line":"        verify_noapi $2"},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify $2"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f436f4f_ea1b6f70","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":23},"updated":"2017-08-20 18:23:19.000000000","message":"this function does not accept arguments","commit_id":"d9082c7ec493594c0918056c2e5a6bcc2bbf58b7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"34c7a65d7f21ab2bd26d6001e6e048fccc6a24c5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        create"},{"line_number":140,"context_line":"        ;;"},{"line_number":141,"context_line":"    \"verify_noapi\")"},{"line_number":142,"context_line":"        verify_noapi $2"},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify $2"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f436f4f_c6a09fa8","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":23},"in_reply_to":"9f436f4f_ea1b6f70","updated":"2017-08-21 10:01:49.000000000","message":"It does not yet, but if we ever implement it, the same param gets passed, the stage name. so i\u0027d prefer leaving it","commit_id":"d9082c7ec493594c0918056c2e5a6bcc2bbf58b7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f1887bf35eb5ebf47ec70516072eae398fd2c4f3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        verify_noapi $2"},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify $2"},{"line_number":146,"context_line":"        ;;"},{"line_number":147,"context_line":"    \"destroy\")"},{"line_number":148,"context_line":"        destroy"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f436f4f_b0083191","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":17},"updated":"2017-08-21 07:48:54.000000000","message":"nit: better to wrap it with \"\" to make sure argument variable with spaces passed correctly.","commit_id":"d9082c7ec493594c0918056c2e5a6bcc2bbf58b7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"34c7a65d7f21ab2bd26d6001e6e048fccc6a24c5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        verify_noapi $2"},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify $2"},{"line_number":146,"context_line":"        ;;"},{"line_number":147,"context_line":"    \"destroy\")"},{"line_number":148,"context_line":"        destroy"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f436f4f_0417bf47","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":17},"in_reply_to":"9f436f4f_b0083191","updated":"2017-08-21 10:01:49.000000000","message":"Done","commit_id":"d9082c7ec493594c0918056c2e5a6bcc2bbf58b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"679324247d9b712a73256efebf4a993bb1b7492b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        create"},{"line_number":140,"context_line":"        ;;"},{"line_number":141,"context_line":"    \"verify_noapi\")"},{"line_number":142,"context_line":"        verify_noapi \"$2\""},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify \"$2\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9f436f4f_89a4e809","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":25},"updated":"2017-08-21 09:31:17.000000000","message":"verify_noapi does not accept arguments","commit_id":"1220ee82d8220be4fe903bf621e96561de38dbf4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"18e64a90abce876788f77a177c7d5a0dbbbff99f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        create"},{"line_number":140,"context_line":"        ;;"},{"line_number":141,"context_line":"    \"verify_noapi\")"},{"line_number":142,"context_line":"        verify_noapi \"$2\""},{"line_number":143,"context_line":"        ;;"},{"line_number":144,"context_line":"    \"verify\")"},{"line_number":145,"context_line":"        verify \"$2\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9f436f4f_490de03c","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":25},"in_reply_to":"9f436f4f_89a4e809","updated":"2017-08-21 10:01:22.000000000","message":"adding a note","commit_id":"1220ee82d8220be4fe903bf621e96561de38dbf4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"939e6321bc64655b476348a9649417c74e0330b4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        verify_noapi \"$2\""},{"line_number":146,"context_line":"        ;;"},{"line_number":147,"context_line":"    \"verify\")"},{"line_number":148,"context_line":"        verify \"$2\""},{"line_number":149,"context_line":"        ;;"},{"line_number":150,"context_line":"    \"destroy\")"},{"line_number":151,"context_line":"        destroy"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9f436f4f_246d2398","line":148,"updated":"2017-08-21 10:09:42.000000000","message":"than better to pass here all arguments that we receive like to all functions ${@:2}","commit_id":"a4833c4663a2503119e3af19e4ef027432463535"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"05e3093710c01738a37976f20a38b1a8cbcb09c3","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        verify_noapi \"$2\""},{"line_number":146,"context_line":"        ;;"},{"line_number":147,"context_line":"    \"verify\")"},{"line_number":148,"context_line":"        verify \"$2\""},{"line_number":149,"context_line":"        ;;"},{"line_number":150,"context_line":"    \"destroy\")"},{"line_number":151,"context_line":"        destroy"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9f436f4f_441ca712","line":148,"in_reply_to":"9f436f4f_246d2398","updated":"2017-08-21 10:12:05.000000000","message":"I\u0027m sorry to pass arguments with spaces should use \"${@:2}\"","commit_id":"a4833c4663a2503119e3af19e4ef027432463535"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d31e98e3bda72d122e196920856989c39720272c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        verify_noapi \"$2\""},{"line_number":146,"context_line":"        ;;"},{"line_number":147,"context_line":"    \"verify\")"},{"line_number":148,"context_line":"        verify \"$2\""},{"line_number":149,"context_line":"        ;;"},{"line_number":150,"context_line":"    \"destroy\")"},{"line_number":151,"context_line":"        destroy"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9f436f4f_24c9a377","line":148,"in_reply_to":"9f436f4f_441ca712","updated":"2017-08-21 10:15:14.000000000","message":"Done","commit_id":"a4833c4663a2503119e3af19e4ef027432463535"}]}