)]}'
{"ironic/tests/unit/drivers/test_drac.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1eae168f4bbf4a63b89f50b1e41b5b45e3f280e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_5da77abe","line":1,"range":{"start_line":1,"start_character":31,"end_line":1,"end_character":51},"updated":"2017-08-14 18:15:16.000000000","message":"Am I the only one that finds this a little... worrisome?","commit_id":"cd030930a91c95b8b289467ce19bff9e2cf23dd9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1eae168f4bbf4a63b89f50b1e41b5b45e3f280e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            driver.inspect,"},{"line_number":62,"context_line":"            kwargs.get(\u0027inspect\u0027, drac.inspect.DracInspect))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # iDRAC classic drivers do not have a network interface."},{"line_number":65,"context_line":"        if \u0027network\u0027 in driver.all_interfaces:"},{"line_number":66,"context_line":"            self.assertIsInstance("},{"line_number":67,"context_line":"                driver.network,"},{"line_number":68,"context_line":"                kwargs.get(\u0027network\u0027, flat_net.FlatNetwork))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertIsInstance("},{"line_number":71,"context_line":"            driver.raid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_f83cfc2f","line":68,"range":{"start_line":64,"start_character":0,"end_line":68,"end_character":60},"updated":"2017-08-14 18:15:16.000000000","message":"I\u0027m not sure what your really attempting to achieve here with a dynamic interface, aside from this will need to be changed if the overall network value default is changed, or the base test classes get new settings that cause different drivers to be created.","commit_id":"cd030930a91c95b8b289467ce19bff9e2cf23dd9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"daf4ff790975161bd7be38b643d9cfe34aba7b1e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            driver.inspect,"},{"line_number":62,"context_line":"            kwargs.get(\u0027inspect\u0027, drac.inspect.DracInspect))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # iDRAC classic drivers do not have a network interface."},{"line_number":65,"context_line":"        if \u0027network\u0027 in driver.all_interfaces:"},{"line_number":66,"context_line":"            self.assertIsInstance("},{"line_number":67,"context_line":"                driver.network,"},{"line_number":68,"context_line":"                kwargs.get(\u0027network\u0027, flat_net.FlatNetwork))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertIsInstance("},{"line_number":71,"context_line":"            driver.raid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_7d9107f1","line":68,"range":{"start_line":64,"start_character":0,"end_line":68,"end_character":60},"in_reply_to":"9f436f4f_f83cfc2f","updated":"2017-08-15 12:49:25.000000000","message":"This base class has been designed and implemented to be used by the iDRAC \u0027classic driver\u0027 and \u0027hardware type\u0027 test cases. They both use this method, _validate_interfaces(). While the \u0027classic drivers\u0027 do not have a network interface, the \u0027hardware type\u0027 does. This takes that into account.\n\nPlease see change \"DNM/WIP: Add \u0027hardware type\u0027 for Dell EMC iDRACs\", https://review.openstack.org/#/c/491263/, for more details.","commit_id":"cd030930a91c95b8b289467ce19bff9e2cf23dd9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1eae168f4bbf4a63b89f50b1e41b5b45e3f280e1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            driver.raid,"},{"line_number":72,"context_line":"            kwargs.get(\u0027raid\u0027, drac.raid.DracRAID))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # iDRAC classic drivers do not have a storage interface."},{"line_number":75,"context_line":"        if \u0027storage\u0027 in driver.all_interfaces:"},{"line_number":76,"context_line":"            self.assertIsInstance("},{"line_number":77,"context_line":"                driver.storage,"},{"line_number":78,"context_line":"                kwargs.get(\u0027storage\u0027, noop_storage.NoopStorage))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.assertIsInstance("},{"line_number":81,"context_line":"            driver.vendor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_d845b8b5","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":64},"updated":"2017-08-14 18:15:16.000000000","message":"Same as above.","commit_id":"cd030930a91c95b8b289467ce19bff9e2cf23dd9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"daf4ff790975161bd7be38b643d9cfe34aba7b1e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            driver.raid,"},{"line_number":72,"context_line":"            kwargs.get(\u0027raid\u0027, drac.raid.DracRAID))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # iDRAC classic drivers do not have a storage interface."},{"line_number":75,"context_line":"        if \u0027storage\u0027 in driver.all_interfaces:"},{"line_number":76,"context_line":"            self.assertIsInstance("},{"line_number":77,"context_line":"                driver.storage,"},{"line_number":78,"context_line":"                kwargs.get(\u0027storage\u0027, noop_storage.NoopStorage))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        self.assertIsInstance("},{"line_number":81,"context_line":"            driver.vendor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_ddb91379","line":78,"range":{"start_line":74,"start_character":0,"end_line":78,"end_character":64},"in_reply_to":"9f436f4f_d845b8b5","updated":"2017-08-15 12:49:25.000000000","message":"Ditto :)","commit_id":"cd030930a91c95b8b289467ce19bff9e2cf23dd9"}]}