)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0d70df54549117685130b76a9efd8188e2af2f5d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"It also fixes a capability name for fibre channel volume boot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib26236a6b65ea56f7d72e45c5bf6e3f4e52a2694"},{"line_number":15,"context_line":"Closes-Bug: #1677436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f436f4f_8aeacca9","line":15,"updated":"2017-08-18 07:14:08.000000000","message":"not sure Closes-Bug is correct for follow-up patches, please use Related-Bug instead.","commit_id":"f68a650d84f3f5b333374d01a8846b1991a1bc9b"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"09ce50f58fc86a00f40504c328dec36fb58c67a4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0027irmc_storage_network_size\u0027:"},{"line_number":70,"context_line":"        _(\"Size of the network for iSCSI storage network. This is the size of \""},{"line_number":71,"context_line":"          \"the IPv4 subnet mask that the storage network is configured to \""},{"line_number":72,"context_line":"          \"utilize, in a range between 1 and 32. This is necessary for \""},{"line_number":73,"context_line":"          \"booting a node from a remote iSCSI volume. Optional.\"),"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_bbd5f2e7","line":72,"updated":"2017-08-17 18:28:11.000000000","message":"it doesn\u0027t include 32, right? Better to mention either \u00271 and 31 inclusive\u0027, or \u00271 and 32 (not including 32)\u0027.","commit_id":"9421ac0b73195d2a2029ccbcff9d484e41456c23"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"09ce50f58fc86a00f40504c328dec36fb58c67a4","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fibre_channel_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_9b122eb4","line":867,"updated":"2017-08-17 18:28:11.000000000","message":"you also changed from \u0027fc_volume_boot\u0027 to \u0027fibre_channel_volume_boot\u0027; I didn\u0027t see anything about that in the original patch?","commit_id":"9421ac0b73195d2a2029ccbcff9d484e41456c23"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3781f796cf8bc6ce8ad889114f4847c44726d895","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fibre_channel_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_f4549723","line":867,"range":{"start_line":867,"start_character":42,"end_line":867,"end_character":67},"updated":"2017-08-18 10:16:31.000000000","message":"I\u0027m not sure about how this is used, but I see https://github.com/openstack/ironic/blob/6f1cf41ffea9fdc6e34f779cf29487a92b2d5934/ironic/tests/unit/drivers/modules/test_deploy_utils.py#L2493 in unit test. would be worth fixing as well","commit_id":"b45b37ef5350b71a99d800658d9cce0ed95bf660"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"2b81e22c7ab1cd6785c0e870aea84fc2aa0ce490","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fibre_channel_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_41881ec5","line":867,"range":{"start_line":867,"start_character":42,"end_line":867,"end_character":67},"in_reply_to":"9f436f4f_1ae166d1","updated":"2017-08-21 06:02:12.000000000","message":"Sure. I will fix the tag with another patch.","commit_id":"b45b37ef5350b71a99d800658d9cce0ed95bf660"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"11bc6c7c54c7ed68c03a080facc37990840661b6","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fibre_channel_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_1ae166d1","line":867,"range":{"start_line":867,"start_character":42,"end_line":867,"end_character":67},"in_reply_to":"9f436f4f_7f907b4f","updated":"2017-08-20 01:04:28.000000000","message":"So I pulled up the spec and it does not define the capability tag for fc boot.  I think what is proposed is actually more correct, and since it is the first implementation of fibrechannel support, I think this wins, but we likely need to fix the tag elsewhere.","commit_id":"b45b37ef5350b71a99d800658d9cce0ed95bf660"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"49a689832f70d02684e96bf07ccfe005f78bc9b8","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fibre_channel_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_7f907b4f","line":867,"range":{"start_line":867,"start_character":42,"end_line":867,"end_character":67},"in_reply_to":"9f436f4f_f4549723","updated":"2017-08-18 12:51:14.000000000","message":"Agreed, We can back land/backport once we figure it out.  Whatever the spec says is correct, and I\u0027m not sure which is correct at the moment.  We can always do a point release down the road with this.","commit_id":"b45b37ef5350b71a99d800658d9cce0ed95bf660"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7cf34e3669479e59ba128c04f03b0257f0cfc2ce","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fc_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_496cc035","line":867,"updated":"2017-08-21 09:48:26.000000000","message":"I\u0027d prefer the capability fixed in the same patch, but this is fine too","commit_id":"832f325f23e8074448b1202287a21f17c6b9d244"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b7e549444e798baefd527b1c6c66ad974d2e2af1","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fc_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_9021ada2","line":867,"range":{"start_line":867,"start_character":21,"end_line":867,"end_character":56},"updated":"2017-08-21 07:30:17.000000000","message":"Same comment as given in https://review.openstack.org/495736","commit_id":"832f325f23e8074448b1202287a21f17c6b9d244"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a95c25f6c3dfb2058099495e294ca32fec62ba60","unresolved":false,"context_lines":[{"line_number":864,"context_line":"class IRMCVirtualMediaBoot(base.BootInterface, IRMCVolumeBootMixIn):"},{"line_number":865,"context_line":"    \"\"\"iRMC Virtual Media boot-related actions.\"\"\""},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027fc_volume_boot\u0027]"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def __init__(self):"},{"line_number":870,"context_line":"        \"\"\"Constructor of IRMCVirtualMediaBoot."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_9313f766","line":867,"range":{"start_line":867,"start_character":21,"end_line":867,"end_character":56},"in_reply_to":"9f436f4f_9021ada2","updated":"2017-08-21 08:43:12.000000000","message":"I think the spec needs revisit for the fc related capability because i dont see the fc_volume_boot or fibre_channel_volume_boot defined there.","commit_id":"832f325f23e8074448b1202287a21f17c6b9d244"}]}
