)]}'
{"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"3757f2aacf2f0392e224036770c1d2d0cd6baba5","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        :returns: A physical ID of a volume connector, or None if not set."},{"line_number":589,"context_line":"        \"\"\""},{"line_number":590,"context_line":"        for vc in task.volume_connectors:"},{"line_number":591,"context_line":"            if vc.type not in types:"},{"line_number":592,"context_line":"                continue"},{"line_number":593,"context_line":"            pid \u003d task.node.driver_info[\u0027irmc_pci_physical_ids\u0027].get(vc.uuid)"},{"line_number":594,"context_line":"            if not pid:"},{"line_number":595,"context_line":"                continue"},{"line_number":596,"context_line":"            try:"},{"line_number":597,"context_line":"                viom.validate_physical_port_id(pid)"},{"line_number":598,"context_line":"            except scci.SCCIInvalidInputError as e:"},{"line_number":599,"context_line":"                raise exception.InvalidParameterValue("},{"line_number":600,"context_line":"                    _(\u0027Physical port information of volume connector \u0027"},{"line_number":601,"context_line":"                      \u0027%(connector)s is invalid: %(error)\u0027) %"},{"line_number":602,"context_line":"                    {\u0027connector\u0027: vc.uuid, \u0027error\u0027: e})"},{"line_number":603,"context_line":"            return pid"},{"line_number":604,"context_line":"        return None"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def _validate_iscsi_connectors(self, task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_9dd6aff1","line":603,"range":{"start_line":591,"start_character":1,"end_line":603,"end_character":22},"updated":"2017-08-22 11:52:22.000000000","message":"Nit-ish: if this for-loop block suppose to find the first matching vc, I\u0027d move the validation block out of the searching as it is not retried with any other items:\n\n\n   pid \u003d None  # not needed\n   for vc in task.volume_connectors:\n       if not vc.type in types:\n          continue\n       pid \u003d task.node.driver_info[\u0027irmc_pci_physical_ids\u0027].get(vc.uuid)\n       if pid:\n          break\n   else:\n       return None\n\n   try:\n     viom.validate_physical_port_id(pid)\n   ...","commit_id":"d7da7b52bec46f32685da0f1c5e12a666f70cb38"}]}