)]}'
{"doc/source/admin/troubleshooting.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":81,"context_line":"       the flavor and the node properties match exactly."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   .. note::"},{"line_number":84,"context_line":"       This requirement will be dropped in the Queens release."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#. The Nova flavor that you are using does not match any properties of the"},{"line_number":87,"context_line":"   available Ironic nodes. Use"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_f6902298","line":84,"updated":"2017-08-22 21:43:21.000000000","message":"which \u0027requirement\u0027 is this referring to?","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":81,"context_line":"       the flavor and the node properties match exactly."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   .. note::"},{"line_number":84,"context_line":"       This requirement will be dropped in the Queens release."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#. The Nova flavor that you are using does not match any properties of the"},{"line_number":87,"context_line":"   available Ironic nodes. Use"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_41e3a034","line":84,"in_reply_to":"7f287b81_23fd473a","updated":"2017-08-23 11:40:57.000000000","message":"+1 for \"capability\" and it should probably be a .. warning:: if anything the warning above should be a note and this a warning.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"       the flavor and the node properties match exactly."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   .. note::"},{"line_number":84,"context_line":"       This requirement will be dropped in the Queens release."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#. The Nova flavor that you are using does not match any properties of the"},{"line_number":87,"context_line":"   available Ironic nodes. Use"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_5d3119a2","line":84,"in_reply_to":"7f287b81_41e3a034","updated":"2017-08-24 16:41:05.000000000","message":"I meant that this whole bullet point is not required.. but it may be redundant","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10530e1448ace4500c5f6ac72b45c447823e21f9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"       the flavor and the node properties match exactly."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   .. note::"},{"line_number":84,"context_line":"       This requirement will be dropped in the Queens release."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#. The Nova flavor that you are using does not match any properties of the"},{"line_number":87,"context_line":"   available Ironic nodes. Use"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_23fd473a","line":84,"in_reply_to":"7f287b81_f6902298","updated":"2017-08-22 23:21:20.000000000","message":"could \u0027capability\u0027 be the right word?","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   Maintenance mode will be also set on a node if automated cleaning has"},{"line_number":48,"context_line":"   failed for it previously."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. Starting with the Pike release, make sure that all your nodes have the"},{"line_number":51,"context_line":"   ``resource_class`` field set using the following command::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"       openstack --os-baremetal-api-version 1.21 baremetal node list --fields uuid name resource_class"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_1e1547e5","line":50,"range":{"start_line":50,"start_character":35,"end_line":50,"end_character":44},"updated":"2017-08-30 10:09:04.000000000","message":"s/make sure/check\n\n\"make sure\" makes this sentence read like you should be doing a node update to ensure a resource class is set.","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   Maintenance mode will be also set on a node if automated cleaning has"},{"line_number":48,"context_line":"   failed for it previously."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. Starting with the Pike release, make sure that all your nodes have the"},{"line_number":51,"context_line":"   ``resource_class`` field set using the following command::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"       openstack --os-baremetal-api-version 1.21 baremetal node list --fields uuid name resource_class"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_ba15184b","line":50,"range":{"start_line":50,"start_character":35,"end_line":50,"end_character":44},"in_reply_to":"7f287b81_1e1547e5","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"       openstack --os-baremetal-api-version 1.21 baremetal node list --fields uuid name resource_class"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   Then make sure that the flavor(s) are configured to request these resource"},{"line_number":56,"context_line":"   classes via their properties::"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"       openstack flavor show \u003cFLAVOR NAME\u003e -f value -c properties"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_ded8df53","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":17},"updated":"2017-08-30 10:09:04.000000000","message":"ditto","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"       openstack --os-baremetal-api-version 1.21 baremetal node list --fields uuid name resource_class"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   Then make sure that the flavor(s) are configured to request these resource"},{"line_number":56,"context_line":"   classes via their properties::"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"       openstack flavor show \u003cFLAVOR NAME\u003e -f value -c properties"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_9a101c59","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":17},"in_reply_to":"7f287b81_ded8df53","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   set to ``1``. See :doc:`/install/configure-nova-flavors` for more"},{"line_number":63,"context_line":"   details on the correct configuration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"#. If you do not use scheduling based on resource classes, then inspection"},{"line_number":66,"context_line":"   should have succeeded for you before, or you should have entered the"},{"line_number":67,"context_line":"   required Ironic node properties manually. For each node with ``available``"},{"line_number":68,"context_line":"   state make sure that the ``properties`` JSON field has valid values"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_7ee9ebe3","line":65,"range":{"start_line":65,"start_character":59,"end_line":65,"end_character":63},"updated":"2017-08-30 10:09:04.000000000","message":"s/then/then either","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   set to ``1``. See :doc:`/install/configure-nova-flavors` for more"},{"line_number":63,"context_line":"   details on the correct configuration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"#. If you do not use scheduling based on resource classes, then inspection"},{"line_number":66,"context_line":"   should have succeeded for you before, or you should have entered the"},{"line_number":67,"context_line":"   required Ironic node properties manually. For each node with ``available``"},{"line_number":68,"context_line":"   state make sure that the ``properties`` JSON field has valid values"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_1502bd0a","line":65,"range":{"start_line":65,"start_character":59,"end_line":65,"end_character":63},"in_reply_to":"7f287b81_7ee9ebe3","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   details on the correct configuration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"#. If you do not use scheduling based on resource classes, then inspection"},{"line_number":66,"context_line":"   should have succeeded for you before, or you should have entered the"},{"line_number":67,"context_line":"   required Ironic node properties manually. For each node with ``available``"},{"line_number":68,"context_line":"   state make sure that the ``properties`` JSON field has valid values"},{"line_number":69,"context_line":"   for the keys ``cpus``, ``cpu_arch``, ``memory_mb`` and ``local_gb``."},{"line_number":70,"context_line":"   Example of valid properties::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_1e71c744","line":67,"range":{"start_line":66,"start_character":3,"end_line":67,"end_character":44},"updated":"2017-08-30 10:09:04.000000000","message":"the first part about inspection seems incomplete, perhaps reword this whole thing too:\n\n... then the node\u0027s properties must have been set either manually or via inspection.","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   details on the correct configuration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"#. If you do not use scheduling based on resource classes, then inspection"},{"line_number":66,"context_line":"   should have succeeded for you before, or you should have entered the"},{"line_number":67,"context_line":"   required Ironic node properties manually. For each node with ``available``"},{"line_number":68,"context_line":"   state make sure that the ``properties`` JSON field has valid values"},{"line_number":69,"context_line":"   for the keys ``cpus``, ``cpu_arch``, ``memory_mb`` and ``local_gb``."},{"line_number":70,"context_line":"   Example of valid properties::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_f52df194","line":67,"range":{"start_line":66,"start_character":3,"end_line":67,"end_character":44},"in_reply_to":"7f287b81_1e71c744","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"}],"doc/source/install/configure-compute.rst":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      #scheduler_host_subset_size\u003d1"},{"line_number":70,"context_line":"      scheduler_host_subset_size\u003d9999999"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    If you have not migrated to make use of :ref:`scheduling-resource-classes`,"},{"line_number":73,"context_line":"    then the following should be set as well:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a14a4424","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":28},"updated":"2017-08-23 11:40:57.000000000","message":"NIT: I\u0027m not sure I like the use of \"migrated\" here just because its an overloaded term with DB migrations etc etc. I would s/migrated/switched but that might be just me.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"143bb72b6d1d9ce65839a70cb3ea17477be8730b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      #scheduler_host_subset_size\u003d1"},{"line_number":70,"context_line":"      scheduler_host_subset_size\u003d9999999"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    If you have not migrated to make use of :ref:`scheduling-resource-classes`,"},{"line_number":73,"context_line":"    then the following should be set as well:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_7dd2955e","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":28},"in_reply_to":"7f287b81_a14a4424","updated":"2017-08-24 16:15:00.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10530e1448ace4500c5f6ac72b45c447823e21f9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      #scheduler_use_baremetal_filters\u003dFalse"},{"line_number":82,"context_line":"      scheduler_use_baremetal_filters\u003dTrue"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    This option is deprecated and has to be removed from the configuration file"},{"line_number":85,"context_line":"    after migration to resource classes."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"#. Change these configuration options in the ``ironic`` section."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a39ed704","line":84,"range":{"start_line":84,"start_character":34,"end_line":84,"end_character":37},"updated":"2017-08-22 23:21:20.000000000","message":"nit: s/has to/must/","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"143bb72b6d1d9ce65839a70cb3ea17477be8730b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      #scheduler_use_baremetal_filters\u003dFalse"},{"line_number":82,"context_line":"      scheduler_use_baremetal_filters\u003dTrue"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    This option is deprecated and has to be removed from the configuration file"},{"line_number":85,"context_line":"    after migration to resource classes."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"#. Change these configuration options in the ``ironic`` section."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_5dd59942","line":84,"range":{"start_line":84,"start_character":34,"end_line":84,"end_character":37},"in_reply_to":"7f287b81_a39ed704","updated":"2017-08-24 16:15:00.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      scheduler_use_baremetal_filters\u003dTrue"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    This option is deprecated and has to be removed from the configuration file"},{"line_number":85,"context_line":"    after migration to resource classes."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"#. Change these configuration options in the ``ironic`` section."},{"line_number":88,"context_line":"   Replace:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a1736480","line":85,"range":{"start_line":85,"start_character":10,"end_line":85,"end_character":19},"updated":"2017-08-23 11:40:57.000000000","message":"s/migration/migrating  or s/migration/switching if you go with my suggestion above.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"143bb72b6d1d9ce65839a70cb3ea17477be8730b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      scheduler_use_baremetal_filters\u003dTrue"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    This option is deprecated and has to be removed from the configuration file"},{"line_number":85,"context_line":"    after migration to resource classes."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"#. Change these configuration options in the ``ironic`` section."},{"line_number":88,"context_line":"   Replace:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_1dcf11b1","line":85,"range":{"start_line":85,"start_character":10,"end_line":85,"end_character":19},"in_reply_to":"7f287b81_a1736480","updated":"2017-08-24 16:15:00.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"}],"doc/source/install/configure-nova-flavors.rst":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bc01ac7acb7d87280c63439fb6badd99c0c4ea9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. note:: This is not required for standalone deployments, only for those using"},{"line_number":46,"context_line":"          the Compute service for provisioning bare metal instances."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"As of the Pike release, a Compute service flavor is able to use this field"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_1f8509ae","line":45,"updated":"2017-08-22 18:20:53.000000000","message":"not sure this note is required as this is part of nova flavor documentation, those who using standalone deployment will not read/use it. better to move it to the enrollment documentation https://review.openstack.org/#/c/496309/2/doc/source/install/enrollment.rst","commit_id":"c97f593b42d49134fad11500ceffe374d5c933d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Scheduling based on resource classes"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_16704e72","line":41,"updated":"2017-08-22 21:43:21.000000000","message":"nit s/the//","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10530e1448ace4500c5f6ac72b45c447823e21f9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Scheduling based on resource classes"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_4385f3ac","line":41,"in_reply_to":"7f287b81_16704e72","updated":"2017-08-22 23:21:20.000000000","message":"I\u0027m kind of -1 to removing the, since it seems to read a little awkwardly without it.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Scheduling based on resource classes"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_bdda3d14","line":41,"in_reply_to":"7f287b81_218f7424","updated":"2017-08-24 16:41:05.000000000","message":"I like Sam\u0027s idea, yeah. But we cannot link to API references for a field, unfortunately.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Scheduling based on resource classes"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_218f7424","line":41,"in_reply_to":"7f287b81_4385f3ac","updated":"2017-08-23 11:40:57.000000000","message":"\"Starting with Bare Metal API version 1.21, ...\"\n\nor potentially change the whole first/second paragraph to something like:\n\nAs of the Pike release, a Compute service flavor is able to use the node resource_class field \u003clink to API reference (which includes all the API version information etc so we don\u0027t duplicate it here)\u003e\nfor scheduling, instead of the CPU, RAM, and disk properties defined in\nthe flavor above. A flavor can request *exactly one* instance of a bare metal\nresource class.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As of the Pike release, a Compute service flavor is able to use this field"},{"line_number":46,"context_line":"for scheduling, instead of the CPU, RAM, and disk properties defined in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_f676e23e","line":43,"updated":"2017-08-22 21:43:21.000000000","message":"that link describes how to populate, not *why* it has to be populated. So... why does it have to be populated? Why can\u0027t people continue to schedule based on properties? Is there a doc eg nova doc that has more details? I see that it sez \u0027Scheduling based on resource classes will replace scheduling based on properties in the Queens release.\u0027\n\nSo maybe we should say something here, that it has to be populated for all nodes because if it isn\u0027t, an upgrade to Queen\u0027s will break or something like that? Do deployments have to actually switch to use scheduling based on resource classes in Pike? We should think through the upgrade scenario.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As of the Pike release, a Compute service flavor is able to use this field"},{"line_number":46,"context_line":"for scheduling, instead of the CPU, RAM, and disk properties defined in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_1d1151ad","line":43,"in_reply_to":"7f287b81_a13ec426","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As of the Pike release, a Compute service flavor is able to use this field"},{"line_number":46,"context_line":"for scheduling, instead of the CPU, RAM, and disk properties defined in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a13ec426","line":43,"in_reply_to":"7f287b81_a33a57e4","updated":"2017-08-23 11:40:57.000000000","message":"++++++++ I vote just remove this sentence, and cover it in upgrade guide or something like:\n\n\"All ironic nodes must have a resource class before upgrading from Pike to Queens, because scheduling based on properties is removed. So we highly recommend that you populate that field and switch to resource class scheduling during Pike, to make the transition to Queens simpler.\"","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10530e1448ace4500c5f6ac72b45c447823e21f9","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Starting with the version 1.21 of the Bare Metal API, the ``resource_class``"},{"line_number":42,"context_line":"field is available on nodes. Starting with the Pike release, it has to be"},{"line_number":43,"context_line":"populated for all nodes, as explained in :ref:`enrollment-scheduling`."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As of the Pike release, a Compute service flavor is able to use this field"},{"line_number":46,"context_line":"for scheduling, instead of the CPU, RAM, and disk properties defined in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a33a57e4","line":43,"in_reply_to":"7f287b81_f676e23e","updated":"2017-08-22 23:21:20.000000000","message":"+++++++++++++++++\n\n+infinity","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"559726e25941999588cc3a85a15fcb909e98fb19","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. code-block:: console"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:VCPU\u003d0"},{"line_number":66,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:MEMORY_MB\u003d0"},{"line_number":67,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:DISK_GB\u003d0"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. warning::"},{"line_number":70,"context_line":"   The last step will be mandatory in the Queens release, as the Compute"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_e7217ca1","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":67},"updated":"2017-08-23 11:45:20.000000000","message":"Just discoverd that even though we do this to \"zero out\" the normal flavor properties, we in fact need to still be aware about what we\u0027re setting the flavors VCPU/DISK_GB/MEMORY_MB too because they are still passed through to ironic as part of the instance_info and are used for validating things like will the image fit onto baremetal: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L88\n\nSo we should provide a recomendation that when using resource classes the falvor\u0027s VCPU/DISK_GB/MEMORY_MB are set to the  lowest amount of each supported by the pool of hardware backed by the resource class.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. code-block:: console"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:VCPU\u003d0"},{"line_number":66,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:MEMORY_MB\u003d0"},{"line_number":67,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:DISK_GB\u003d0"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. warning::"},{"line_number":70,"context_line":"   The last step will be mandatory in the Queens release, as the Compute"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_e8124158","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":67},"in_reply_to":"7f287b81_e7217ca1","updated":"2017-08-24 16:41:05.000000000","message":"I\u0027ll give it a try","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":41,"context_line":"As of the Pike release, a Compute service flavor is able to use the node\u0027s"},{"line_number":42,"context_line":"``resource_class`` field (available starting with Bare Metal API version 1.21)"},{"line_number":43,"context_line":"for scheduling, instead of the CPU, RAM, and disk properties defined in"},{"line_number":44,"context_line":"the flavor above. A flavor can request *exactly one* instance of a bare metal"},{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_2ac20f5a","line":44,"updated":"2017-08-29 19:26:21.000000000","message":"nit, is it easy to link the \u0027above\u0027 word to the \"Scheduling based on properties\" section?","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"As of the Pike release, a Compute service flavor is able to use the node\u0027s"},{"line_number":42,"context_line":"``resource_class`` field (available starting with Bare Metal API version 1.21)"},{"line_number":43,"context_line":"for scheduling, instead of the CPU, RAM, and disk properties defined in"},{"line_number":44,"context_line":"the flavor above. A flavor can request *exactly one* instance of a bare metal"},{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_f5529112","line":44,"in_reply_to":"7f287b81_2ac20f5a","updated":"2017-08-30 14:55:14.000000000","message":"I think I\u0027ll remove the \"above\", as we have a link in the next paragraph","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":44,"context_line":"the flavor above. A flavor can request *exactly one* instance of a bare metal"},{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_4aa43bba","line":47,"updated":"2017-08-29 19:26:21.000000000","message":"nit s/what described/what is described/","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6796736708fd214bd418d8515aed2f28c4310161","unresolved":false,"context_lines":[{"line_number":44,"context_line":"the flavor above. A flavor can request *exactly one* instance of a bare metal"},{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_44f7795a","line":47,"in_reply_to":"7f287b81_1ebf87aa","updated":"2017-08-30 13:40:21.000000000","message":"if you use \u0027same\u0027, it\u0027d be something like in \u0027the same way as described in..\u0027\n\nHmm. I just looked at that section. What do you mean? Is it the same steps, just that cpu, ram_mb and disk_gb aren\u0027t actually going to be used for scheduling?","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"the flavor above. A flavor can request *exactly one* instance of a bare metal"},{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_159e3db8","line":47,"in_reply_to":"7f287b81_44f7795a","updated":"2017-08-30 14:55:14.000000000","message":"yep","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"the flavor above. A flavor can request *exactly one* instance of a bare metal"},{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_1ebf87aa","line":47,"in_reply_to":"7f287b81_4aa43bba","updated":"2017-08-30 10:09:04.000000000","message":"s/similar/same ??","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_3e2003f7","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":42},"updated":"2017-08-30 10:09:04.000000000","message":"s/However, the/The/","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"resource class."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_55904595","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":42},"in_reply_to":"7f287b81_3e2003f7","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_fe7b9bf1","line":49,"range":{"start_line":49,"start_character":58,"end_line":49,"end_character":63},"updated":"2017-08-30 10:09:04.000000000","message":"s/.the/but, the","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Start with creating the flavor in a similar way to what described in"},{"line_number":48,"context_line":"`Scheduling based on properties`_. However, the ``CPU``, ``RAM_MB`` and"},{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_358b7968","line":49,"range":{"start_line":49,"start_character":58,"end_line":49,"end_character":63},"in_reply_to":"7f287b81_fe7b9bf1","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."},{"line_number":53,"context_line":"A name of the custom resource class is the name of node\u0027s resource class,"},{"line_number":54,"context_line":"but upper-cased, with ``CUSTOM_`` prefix prepended, and all punctuation"},{"line_number":55,"context_line":"replaced with an underscore:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_ea852708","line":52,"updated":"2017-08-29 19:26:21.000000000","message":"I don\u0027t know why we want to mention \u0027custom resource class\u0027. Is it different from \u0027resource class\u0027? Or maybe nova refers to them as \u0027custom resource class\u0027.","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."},{"line_number":53,"context_line":"A name of the custom resource class is the name of node\u0027s resource class,"},{"line_number":54,"context_line":"but upper-cased, with ``CUSTOM_`` prefix prepended, and all punctuation"},{"line_number":55,"context_line":"replaced with an underscore:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_95dfcd67","line":52,"in_reply_to":"7f287b81_7e58cb86","updated":"2017-08-30 14:55:14.000000000","message":"++ to what Sam said","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"``DISK_GB`` values are not going to be used for scheduling. The ``DISK_GB``"},{"line_number":50,"context_line":"value will still be used to determine the root partition size."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."},{"line_number":53,"context_line":"A name of the custom resource class is the name of node\u0027s resource class,"},{"line_number":54,"context_line":"but upper-cased, with ``CUSTOM_`` prefix prepended, and all punctuation"},{"line_number":55,"context_line":"replaced with an underscore:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_7e58cb86","line":52,"in_reply_to":"7f287b81_ea852708","updated":"2017-08-30 10:09:04.000000000","message":"its custom because its not one of the standard 3 resource classes listed at L66-68, I think in the future they are likely to all just become \"resource classes\" when old type flavors are deprecated/removed, and resource classes are the standard way to do scheduling.","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."},{"line_number":53,"context_line":"A name of the custom resource class is the name of node\u0027s resource class,"},{"line_number":54,"context_line":"but upper-cased, with ``CUSTOM_`` prefix prepended, and all punctuation"},{"line_number":55,"context_line":"replaced with an underscore:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. code-block:: console"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_8a20e3f8","line":55,"updated":"2017-08-29 19:26:21.000000000","message":"Maybe (if I understand it):\n\nThe name of a Compute service\u0027s custom resource class that corresponds to a node\u0027s resource class (in the Bare Metal service) is:\n- the bare metal node\u0027s resource class all upper-cased\n- prefixed with ``CUSTOM_``\n- all punctuation replaced with an underscore\n\nFor example, if the resource class is named \"something-kewl\", associate the flavor with this custom resource class via:\n\n  nova flavor-key my-baremetal-flavor set resources:CUSTOM_SOMETHING_KEWL\u003d1\n\n(I\u0027m not sure I\u0027d use something-kewl but that\u0027s what popped into my head.)","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."},{"line_number":53,"context_line":"A name of the custom resource class is the name of node\u0027s resource class,"},{"line_number":54,"context_line":"but upper-cased, with ``CUSTOM_`` prefix prepended, and all punctuation"},{"line_number":55,"context_line":"replaced with an underscore:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. code-block:: console"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_95fb4dbf","line":55,"in_reply_to":"7f287b81_3e47e3be","updated":"2017-08-30 14:55:14.000000000","message":"Done","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"After creation, associate each flavor with one custom resource class."},{"line_number":53,"context_line":"A name of the custom resource class is the name of node\u0027s resource class,"},{"line_number":54,"context_line":"but upper-cased, with ``CUSTOM_`` prefix prepended, and all punctuation"},{"line_number":55,"context_line":"replaced with an underscore:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. code-block:: console"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_3e47e3be","line":55,"in_reply_to":"7f287b81_8a20e3f8","updated":"2017-08-30 10:09:04.000000000","message":"Correct. I like the idea of splitting this out in to a bullet list like you\u0027ve done in your comment.\n\nAn example like you just gave is @L83-94 but perhaps an explicit one would be better given here?","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:VCPU\u003d0"},{"line_number":67,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:MEMORY_MB\u003d0"},{"line_number":68,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:DISK_GB\u003d0"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. warning::"},{"line_number":71,"context_line":"   The last step will be mandatory in the Queens release, as the Compute"},{"line_number":72,"context_line":"   service will stop providing standard resources for bare metal nodes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_0a5bd386","line":69,"updated":"2017-08-29 19:26:21.000000000","message":"Sam had some comments in previous patch set about the flavor properties being passed through to ironic. Were you going to add that here? (or was that in L49?)","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1437a324bf797ac305cb2a3589098dab3e62844d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:VCPU\u003d0"},{"line_number":67,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:MEMORY_MB\u003d0"},{"line_number":68,"context_line":"      $ nova flavor-key my-baremetal-flavor set resources:DISK_GB\u003d0"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. warning::"},{"line_number":71,"context_line":"   The last step will be mandatory in the Queens release, as the Compute"},{"line_number":72,"context_line":"   service will stop providing standard resources for bare metal nodes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_bee8737b","line":69,"in_reply_to":"7f287b81_0a5bd386","updated":"2017-08-30 10:09:04.000000000","message":"I think what Dmitry has put at L49 is good enough for now, I just didn\u0027t want people to get confused by the fact we\u0027re \"zeroing\" out the DISK_GB for scheduling here, but that doesn\u0027t affect the fact you must set it correctly in the flavor in order to define the root partition size.","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"}],"doc/source/install/enrollment.rst":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bc01ac7acb7d87280c63439fb6badd99c0c4ea9","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"   .. warning::"},{"line_number":317,"context_line":"      If scheduling based on resource classes is not used, the three properties"},{"line_number":318,"context_line":"      ``cpus``, ``memory_mb`` and ``local_gb`` much match ones defined on the"},{"line_number":319,"context_line":"      flavor created when :doc:`configure-nova-flavors`."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"   .. warning::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_dfef81ae","line":318,"range":{"start_line":318,"start_character":47,"end_line":318,"end_character":51},"updated":"2017-08-22 18:20:53.000000000","message":"must","commit_id":"c97f593b42d49134fad11500ceffe374d5c933d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":262,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"#. Assign a *resource class* to the node. Resource classes will be used for"},{"line_number":265,"context_line":"   scheduling bare metal instances in the future. A *resource class* should"},{"line_number":266,"context_line":"   represent a class of hardware in your data center, that roughly corresponds"},{"line_number":267,"context_line":"   to a Compute flavor."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_f6c4a242","line":265,"updated":"2017-08-22 21:43:21.000000000","message":"by \"in the future\", can\u0027t they be used for scheduling in Pike?","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":262,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"#. Assign a *resource class* to the node. Resource classes will be used for"},{"line_number":265,"context_line":"   scheduling bare metal instances in the future. A *resource class* should"},{"line_number":266,"context_line":"   represent a class of hardware in your data center, that roughly corresponds"},{"line_number":267,"context_line":"   to a Compute flavor."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_c83665e8","line":265,"in_reply_to":"7f287b81_a127e412","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":262,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"#. Assign a *resource class* to the node. Resource classes will be used for"},{"line_number":265,"context_line":"   scheduling bare metal instances in the future. A *resource class* should"},{"line_number":266,"context_line":"   represent a class of hardware in your data center, that roughly corresponds"},{"line_number":267,"context_line":"   to a Compute flavor."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a127e412","line":265,"in_reply_to":"7f287b81_f6c4a242","updated":"2017-08-23 11:40:57.000000000","message":"+1 I vote just remove that second sentence","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":266,"context_line":"   represent a class of hardware in your data center, that roughly corresponds"},{"line_number":267,"context_line":"   to a Compute flavor."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"   For example, you may split hardware into three classes:"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   #. nodes with a lot of RAM and powerful CPU for computational tasks,"},{"line_number":272,"context_line":"   #. nodes with powerful GPU for OpenCL computing,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_f6d94222","line":269,"updated":"2017-08-22 21:43:21.000000000","message":"maybe \n\nFor example, let\u0027s split hardware into these three classes:","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":266,"context_line":"   represent a class of hardware in your data center, that roughly corresponds"},{"line_number":267,"context_line":"   to a Compute flavor."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"   For example, you may split hardware into three classes:"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   #. nodes with a lot of RAM and powerful CPU for computational tasks,"},{"line_number":272,"context_line":"   #. nodes with powerful GPU for OpenCL computing,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_4850350b","line":269,"in_reply_to":"7f287b81_2162d43f","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":266,"context_line":"   represent a class of hardware in your data center, that roughly corresponds"},{"line_number":267,"context_line":"   to a Compute flavor."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"   For example, you may split hardware into three classes:"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   #. nodes with a lot of RAM and powerful CPU for computational tasks,"},{"line_number":272,"context_line":"   #. nodes with powerful GPU for OpenCL computing,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_2162d43f","line":269,"in_reply_to":"7f287b81_f6d94222","updated":"2017-08-23 11:40:57.000000000","message":"to align with rloo\u0027s suggestion for the next paragraph s/classes/groups/","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":272,"context_line":"   #. nodes with powerful GPU for OpenCL computing,"},{"line_number":273,"context_line":"   #. smaller nodes for development and testing."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"   These would correspond to three resource classes, which you can name"},{"line_number":276,"context_line":"   arbitrary, e.g. ``large-cpu``, ``large-gpu`` and ``small``."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_76ff9267","line":275,"updated":"2017-08-22 21:43:21.000000000","message":"We\u0027ll add three resource classes to reflect these hardware groups, named large-cpu, large-gpu and small respectively. Then, for each node in each of the hardware groups, we\u0027ll set their resource_class appropriately via:","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":272,"context_line":"   #. nodes with powerful GPU for OpenCL computing,"},{"line_number":273,"context_line":"   #. smaller nodes for development and testing."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"   These would correspond to three resource classes, which you can name"},{"line_number":276,"context_line":"   arbitrary, e.g. ``large-cpu``, ``large-gpu`` and ``small``."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_687651a7","line":275,"in_reply_to":"7f287b81_019a3813","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":272,"context_line":"   #. nodes with powerful GPU for OpenCL computing,"},{"line_number":273,"context_line":"   #. smaller nodes for development and testing."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"   These would correspond to three resource classes, which you can name"},{"line_number":276,"context_line":"   arbitrary, e.g. ``large-cpu``, ``large-gpu`` and ``small``."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_019a3813","line":275,"in_reply_to":"7f287b81_76ff9267","updated":"2017-08-23 11:40:57.000000000","message":"I like rloo\u0027s suggestion, with one change,\n\ns/We\u0027ll add three resource classes/We can define/\n\nonly because \"we\u0027ll add\" makes it sound like we need to make API calls to add something to Ironic.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"10530e1448ace4500c5f6ac72b45c447823e21f9","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"   .. code-block:: console"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    $ ironic --ironic-api-version\u003d1.21 node-update $NODE_UUID \\"},{"line_number":281,"context_line":"        replace resource_class\u003d$CLASS_NAME"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"   To use resource classes for scheduling you need to update your flavors as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_630d8f3d","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":12},"updated":"2017-08-22 23:21:20.000000000","message":"nit: We should have this as the OSC command.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"   .. code-block:: console"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    $ ironic --ironic-api-version\u003d1.21 node-update $NODE_UUID \\"},{"line_number":281,"context_line":"        replace resource_class\u003d$CLASS_NAME"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"   To use resource classes for scheduling you need to update your flavors as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_e15bac84","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":12},"in_reply_to":"7f287b81_630d8f3d","updated":"2017-08-23 11:40:57.000000000","message":"+1000","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"   .. code-block:: console"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    $ ironic --ironic-api-version\u003d1.21 node-update $NODE_UUID \\"},{"line_number":281,"context_line":"        replace resource_class\u003d$CLASS_NAME"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"   To use resource classes for scheduling you need to update your flavors as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_48795591","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":12},"in_reply_to":"7f287b81_e15bac84","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":278,"context_line":"   .. code-block:: console"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    $ ironic --ironic-api-version\u003d1.21 node-update $NODE_UUID \\"},{"line_number":281,"context_line":"        replace resource_class\u003d$CLASS_NAME"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"   To use resource classes for scheduling you need to update your flavors as"},{"line_number":284,"context_line":"   described in :doc:`configure-nova-flavors`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_36f90a80","line":281,"updated":"2017-08-22 21:43:21.000000000","message":"I\u0027d actually prefer s/replace/add/\n\nWe don\u0027t really want them changing the resource class value after it has been set (cuz we don\u0027t allow it if the node is active).","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      This is not required for standalone deployments, only for those using"},{"line_number":292,"context_line":"      the Compute service for provisioning bare metal instances."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"#. Update the node\u0027s properties to match the actual hardware of the node:"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"   .. code-block:: console"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_1624ce0c","line":294,"updated":"2017-08-22 21:43:21.000000000","message":"Do we have to do this if we do #1 (use resource classes)?","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      This is not required for standalone deployments, only for those using"},{"line_number":292,"context_line":"      the Compute service for provisioning bare metal instances."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"#. Update the node\u0027s properties to match the actual hardware of the node:"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"   .. code-block:: console"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_ac559b52","line":294,"in_reply_to":"7f287b81_1624ce0c","updated":"2017-08-23 11:40:57.000000000","message":"I have a concern around these properties, especially local_gb and our validation about whether an image will fit onto a baremetal server, I feel like we had some checks in place that check the image size against local_gb.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"      This is not required for standalone deployments, only for those using"},{"line_number":292,"context_line":"      the Compute service for provisioning bare metal instances."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"#. Update the node\u0027s properties to match the actual hardware of the node:"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"   .. code-block:: console"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_a86319dc","line":294,"in_reply_to":"7f287b81_ac559b52","updated":"2017-08-24 16:41:05.000000000","message":"yeah..","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"18f96274411399ddf26b85e8b22961a258225126","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        properties/local_gb\u003d$DISK_GB \\"},{"line_number":302,"context_line":"        properties/cpu_arch\u003d$ARCH"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"   As above, these can also be specified at node creation by passing the **-p**"},{"line_number":305,"context_line":"   option to ``node-create`` multiple times:"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_b6785af8","line":304,"updated":"2017-08-22 21:43:21.000000000","message":"This is true for the resource class too? Maybe add something like this after L 281?","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        properties/local_gb\u003d$DISK_GB \\"},{"line_number":302,"context_line":"        properties/cpu_arch\u003d$ARCH"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"   As above, these can also be specified at node creation by passing the **-p**"},{"line_number":305,"context_line":"   option to ``node-create`` multiple times:"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_48871563","line":304,"in_reply_to":"7f287b81_6ce453ad","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        properties/local_gb\u003d$DISK_GB \\"},{"line_number":302,"context_line":"        properties/cpu_arch\u003d$ARCH"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"   As above, these can also be specified at node creation by passing the **-p**"},{"line_number":305,"context_line":"   option to ``node-create`` multiple times:"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_6ce453ad","line":304,"in_reply_to":"7f287b81_b6785af8","updated":"2017-08-23 11:40:57.000000000","message":"I think personally if we\u0027re recommending that people specify a resource class for all nodes in Ironic, then doing it at create/enroll time makes the most sense.","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"59470f1cb9db5739592fbaed3834287a09be2f47","unresolved":false,"context_lines":[{"line_number":332,"context_line":"      :ref:`root-device-hints`), the ``local_gb`` value should match the size"},{"line_number":333,"context_line":"      of picked target disk."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"   .. note::"},{"line_number":336,"context_line":"      Properties-based approach to scheduling will be replaced by scheduling"},{"line_number":337,"context_line":"      based on custom resource classes in the Queens release."},{"line_number":338,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_ac035b42","line":335,"range":{"start_line":335,"start_character":6,"end_line":335,"end_character":10},"updated":"2017-08-23 11:40:57.000000000","message":"IMO this is a deprecation *warning*","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a46d670dab22c84635862fba4fc32f222acccf9","unresolved":false,"context_lines":[{"line_number":332,"context_line":"      :ref:`root-device-hints`), the ``local_gb`` value should match the size"},{"line_number":333,"context_line":"      of picked target disk."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"   .. note::"},{"line_number":336,"context_line":"      Properties-based approach to scheduling will be replaced by scheduling"},{"line_number":337,"context_line":"      based on custom resource classes in the Queens release."},{"line_number":338,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_c892e59f","line":335,"range":{"start_line":335,"start_character":6,"end_line":335,"end_character":10},"in_reply_to":"7f287b81_ac035b42","updated":"2017-08-24 16:41:05.000000000","message":"Done","commit_id":"e0eef4913c89b239f0c914542385c1dd98fe71d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"   .. code-block:: console"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    $ openstack --os-baremetal-api-version 1.21 baremetal node set $NODE_UUID \\"},{"line_number":282,"context_line":"        --resource-class $CLASS_NAME"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"   .. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_452b0c82","line":281,"updated":"2017-08-29 19:26:21.000000000","message":"i agree we should be using openstack baremetal, but you realize that the rest of the commands here are \u0027ironic\u0027 ones? :)","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"   .. code-block:: console"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    $ openstack --os-baremetal-api-version 1.21 baremetal node set $NODE_UUID \\"},{"line_number":282,"context_line":"        --resource-class $CLASS_NAME"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"   .. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_d5267568","line":281,"in_reply_to":"7f287b81_452b0c82","updated":"2017-08-30 14:55:14.000000000","message":"Yeah, I think we should just switch all to OSC really soon","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da445b830a79c6d69bbda218cf4b9f221924207","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        --resource-class $CLASS_NAME"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"   .. note::"},{"line_number":285,"context_line":"      The ``--resource-class`` argument can also be used when creating a node."},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"   To use resource classes for scheduling you need to update your flavors as"},{"line_number":288,"context_line":"   described in :doc:`configure-nova-flavors`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_2505a011","line":285,"updated":"2017-08-29 19:26:21.000000000","message":"nit. I don\u0027t like notes unless they are really necessary. It seems sufficient to just say something like \n\nThe resource class can also be specified at node creation by specifying the ``--resource-class``. And look, we can even link now. OK, outside the scope of this patch :)\n\n[1] https://docs.openstack.org/python-ironicclient/latest/cli/osc/v1/index.html#baremetal-node-create","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"225843e438395ffbfd98057d7662b4bbde5972fb","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        --resource-class $CLASS_NAME"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"   .. note::"},{"line_number":285,"context_line":"      The ``--resource-class`` argument can also be used when creating a node."},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"   To use resource classes for scheduling you need to update your flavors as"},{"line_number":288,"context_line":"   described in :doc:`configure-nova-flavors`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_75cd8183","line":285,"in_reply_to":"7f287b81_2505a011","updated":"2017-08-30 14:55:14.000000000","message":"Done. Good point about the links, but I think it\u0027s worth a new patch. We should insert them in many places.","commit_id":"b7c78be7e17fbd454b47eaaf83bf223840c99061"}]}
