)]}'
{"ironic/db/api.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1179b26327a63362e27bc7695b54c15a4d60f50","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                         \u0027hostname\u0027: the unique hostname which identifies"},{"line_number":483,"context_line":"                                     this Conductor service."},{"line_number":484,"context_line":"                         \u0027drivers\u0027: a list of supported drivers."},{"line_number":485,"context_line":"                         \u0027version\u0027: the version of the object.Conductor"},{"line_number":486,"context_line":"                        }"},{"line_number":487,"context_line":"        :param update_existing: When false, registration will raise an"},{"line_number":488,"context_line":"                                exception when a conflicting online record"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_48519f0e","line":485,"updated":"2017-09-19 22:39:51.000000000","message":"Is this just a doc update, or should code be updated?","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                         \u0027hostname\u0027: the unique hostname which identifies"},{"line_number":483,"context_line":"                                     this Conductor service."},{"line_number":484,"context_line":"                         \u0027drivers\u0027: a list of supported drivers."},{"line_number":485,"context_line":"                         \u0027version\u0027: the version of the object.Conductor"},{"line_number":486,"context_line":"                        }"},{"line_number":487,"context_line":"        :param update_existing: When false, registration will raise an"},{"line_number":488,"context_line":"                                exception when a conflicting online record"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_ee1ba970","line":485,"in_reply_to":"bf57530f_48519f0e","updated":"2017-09-20 13:44:05.000000000","message":"Sorry, code was updated in Ic366f771491774f9708c9a81ab76dc13757d852b, which once upon a time had been a dependency for this. If I had known it would have taken this long I would have added this in a separate patch because yes, it isn\u0027t totally related to this patch.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1179b26327a63362e27bc7695b54c15a4d60f50","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        populated (backfilled) the version column for all objects."},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        Unfortunately, in the Pike release, we forgot to set the value for the"},{"line_number":911,"context_line":"        conductor\u0027s version column. For this Queens release, we are setting"},{"line_number":912,"context_line":"        the conductor version, however, we still need to backfill in case new"},{"line_number":913,"context_line":"        conductors were added between the time the operator ran Pike\u0027s"},{"line_number":914,"context_line":"        \u0027ironic-dbsync online_data_migrations\u0027 and their upgrade to Queens."}],"source_content_type":"text/x-python","patch_set":3,"id":"df6247ed_89c1d931","line":911,"range":{"start_line":911,"start_character":40,"end_line":911,"end_character":44},"updated":"2017-09-19 22:39:51.000000000","message":"nit: I like how you changed \u0027this\u0027 to \u0027the\u0027 above.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        populated (backfilled) the version column for all objects."},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        Unfortunately, in the Pike release, we forgot to set the value for the"},{"line_number":911,"context_line":"        conductor\u0027s version column. For this Queens release, we are setting"},{"line_number":912,"context_line":"        the conductor version, however, we still need to backfill in case new"},{"line_number":913,"context_line":"        conductors were added between the time the operator ran Pike\u0027s"},{"line_number":914,"context_line":"        \u0027ironic-dbsync online_data_migrations\u0027 and their upgrade to Queens."}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_4ed07551","line":911,"range":{"start_line":911,"start_character":40,"end_line":911,"end_character":44},"in_reply_to":"df6247ed_89c1d931","updated":"2017-09-20 13:44:05.000000000","message":"that\u0027s cuz this code isn\u0027t going into \u0027this pike release\u0027, it is going into \u0027this queens release\u0027. but i can change it to \u0027the\u0027.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"800ab694252324ac41be61a66b9de1fc1308f5a3","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        total_migrated \u003d 0"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        # backfill only the Conductor"},{"line_number":1192,"context_line":"        sql_models \u003d [model for model in models.Base.__subclasses__()"},{"line_number":1193,"context_line":"                      if model.__name__ \u003d\u003d \u0027Conductor\u0027]"},{"line_number":1194,"context_line":"        for model in sql_models:"},{"line_number":1195,"context_line":"            query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1196,"context_line":"            total_to_migrate +\u003d query.count()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a6759e9a","line":1193,"range":{"start_line":1192,"start_character":1,"end_line":1193,"end_character":55},"updated":"2017-09-04 13:00:40.000000000","message":"why not\n\n sql_model \u003d models.Conductor\n\n?","commit_id":"8f0dca7496a340d326f36b3ec0f5716ffa40e4cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9f5c24fad8744defa73f8b78295d64eca131d2d4","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        total_migrated \u003d 0"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        # backfill only the Conductor"},{"line_number":1192,"context_line":"        sql_models \u003d [model for model in models.Base.__subclasses__()"},{"line_number":1193,"context_line":"                      if model.__name__ \u003d\u003d \u0027Conductor\u0027]"},{"line_number":1194,"context_line":"        for model in sql_models:"},{"line_number":1195,"context_line":"            query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1196,"context_line":"            total_to_migrate +\u003d query.count()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_8a2dea47","line":1193,"range":{"start_line":1192,"start_character":1,"end_line":1193,"end_character":55},"in_reply_to":"7f287b81_a6759e9a","updated":"2017-09-05 16:30:39.000000000","message":"Cuz I was being lazy and thought I\u0027d just reuse as much code as possible. It is cleaner to just do as you suggested :)","commit_id":"8f0dca7496a340d326f36b3ec0f5716ffa40e4cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"800ab694252324ac41be61a66b9de1fc1308f5a3","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                    query \u003d model_query(model).filter(model.id.in_(ids))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"                num_migrated \u003d query.update("},{"line_number":1231,"context_line":"                    {model.version: mapping[model.__name__][0]},"},{"line_number":1232,"context_line":"                    synchronize_session\u003dFalse)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"            total_migrated +\u003d num_migrated"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_864f4269","line":1231,"updated":"2017-09-04 13:00:40.000000000","message":"ugh. this must have query.filter(model.version.is_(None)) here (yes, again). otherwise something may update the records while the transaction is running, and we\u0027ll overwrite them.","commit_id":"8f0dca7496a340d326f36b3ec0f5716ffa40e4cb"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"23db5acb86abc83c5e9ab958686631bedcdb8ff1","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                    query \u003d model_query(model).filter(model.id.in_(ids))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"                num_migrated \u003d query.update("},{"line_number":1231,"context_line":"                    {model.version: mapping[model.__name__][0]},"},{"line_number":1232,"context_line":"                    synchronize_session\u003dFalse)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"            total_migrated +\u003d num_migrated"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_af1331b8","line":1231,"in_reply_to":"7f287b81_864f4269","updated":"2017-09-04 15:26:40.000000000","message":"+1","commit_id":"8f0dca7496a340d326f36b3ec0f5716ffa40e4cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9f5c24fad8744defa73f8b78295d64eca131d2d4","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                    query \u003d model_query(model).filter(model.id.in_(ids))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"                num_migrated \u003d query.update("},{"line_number":1231,"context_line":"                    {model.version: mapping[model.__name__][0]},"},{"line_number":1232,"context_line":"                    synchronize_session\u003dFalse)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"            total_migrated +\u003d num_migrated"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_ea1b4e19","line":1231,"in_reply_to":"7f287b81_af1331b8","updated":"2017-09-05 16:30:39.000000000","message":"UGH. Good catch. That is a problem. We\u0027ll need to fix in stable/ocata.","commit_id":"8f0dca7496a340d326f36b3ec0f5716ffa40e4cb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1179b26327a63362e27bc7695b54c15a4d60f50","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        total_migrated \u003d 0"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        # backfill only the Conductor"},{"line_number":1192,"context_line":"        model \u003d models.Conductor"},{"line_number":1193,"context_line":"        query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1194,"context_line":"        total_to_migrate +\u003d query.count()"},{"line_number":1195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_6827c3b8","line":1192,"updated":"2017-09-19 22:39:51.000000000","message":"I wonder if should just keep it as sql_models\n\n sql_models \u003d [models.Conductor]\n\nThen the rest of the code wouldn\u0027t need to change. Unless I\u0027m missing something.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        total_migrated \u003d 0"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        # backfill only the Conductor"},{"line_number":1192,"context_line":"        model \u003d models.Conductor"},{"line_number":1193,"context_line":"        query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1194,"context_line":"        total_to_migrate +\u003d query.count()"},{"line_number":1195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_23855aae","line":1192,"in_reply_to":"bf57530f_6827c3b8","updated":"2017-09-20 13:44:05.000000000","message":"Yeah, that was one of my choices. I was going to do that, but then I thought that someone would want me to go further and do what I have now :-(  (See patch set 1 for my minimal-changes-version.)","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1179b26327a63362e27bc7695b54c15a4d60f50","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"        # backfill only the Conductor"},{"line_number":1192,"context_line":"        model \u003d models.Conductor"},{"line_number":1193,"context_line":"        query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1194,"context_line":"        total_to_migrate +\u003d query.count()"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        if not total_to_migrate:"},{"line_number":1197,"context_line":"            return total_to_migrate, 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_8818b775","line":1194,"updated":"2017-09-19 22:39:51.000000000","message":"nit: This could just be:\n\n total_to_migrate \u003d query.count()\n\nAnd could delete line 1188","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"        # backfill only the Conductor"},{"line_number":1192,"context_line":"        model \u003d models.Conductor"},{"line_number":1193,"context_line":"        query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1194,"context_line":"        total_to_migrate +\u003d query.count()"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        if not total_to_migrate:"},{"line_number":1197,"context_line":"            return total_to_migrate, 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_c34b1e85","line":1194,"in_reply_to":"bf57530f_8818b775","updated":"2017-09-20 13:44:05.000000000","message":"Yup, and that means changing this code from the original even further. The more changes, the more chance of breaking something. Sigh.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3dba62a1b09338725ae53f61ce5f540dca6132d1","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"        num_migrated \u003d 0"},{"line_number":1216,"context_line":"        with _session_for_write():"},{"line_number":1217,"context_line":"            query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1218,"context_line":"            if max_to_migrate \u003c query.count():"},{"line_number":1219,"context_line":"                # Only want to update max_to_migrate objects; cannot use"},{"line_number":1220,"context_line":"                # sql\u0027s limit(), so we generate a new query with"},{"line_number":1221,"context_line":"                # max_to_migrate objects."}],"source_content_type":"text/x-python","patch_set":3,"id":"ff5d4b2f_8c99d520","line":1218,"updated":"2017-09-19 16:43:59.000000000","message":"note for myself: we have to be careful with these things and not assume that query.count() won\u0027t change between invocations","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"        num_migrated \u003d 0"},{"line_number":1216,"context_line":"        with _session_for_write():"},{"line_number":1217,"context_line":"            query \u003d model_query(model).filter(model.version.is_(None))"},{"line_number":1218,"context_line":"            if max_to_migrate \u003c query.count():"},{"line_number":1219,"context_line":"                # Only want to update max_to_migrate objects; cannot use"},{"line_number":1220,"context_line":"                # sql\u0027s limit(), so we generate a new query with"},{"line_number":1221,"context_line":"                # max_to_migrate objects."}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_235c3a4a","line":1218,"in_reply_to":"ff5d4b2f_8c99d520","updated":"2017-09-20 13:44:05.000000000","message":"You know, maybe I should add a comment about that.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3dba62a1b09338725ae53f61ce5f540dca6132d1","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"                           synchronize_session\u003dFalse))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        total_migrated +\u003d num_migrated"},{"line_number":1239,"context_line":"        max_to_migrate -\u003d num_migrated"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        return total_to_migrate, total_migrated"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff5d4b2f_6c9ea108","line":1239,"updated":"2017-09-19 16:43:59.000000000","message":"this line is not needed, its result is no longer used","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"                           synchronize_session\u003dFalse))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        total_migrated +\u003d num_migrated"},{"line_number":1239,"context_line":"        max_to_migrate -\u003d num_migrated"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        return total_to_migrate, total_migrated"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_03593659","line":1239,"in_reply_to":"ff5d4b2f_6c9ea108","updated":"2017-09-20 13:44:05.000000000","message":"true.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"}],"ironic/tests/unit/db/test_api.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"d894b94cc43ba9661c5781b06f2d5fb9dd92dcbc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            conductor \u003d self.dbapi.get_conductor(hostname)"},{"line_number":85,"context_line":"            self.assertEqual(self.conductor_ver, conductor.version)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _create_conductors(self, num, version\u003dNone):"},{"line_number":88,"context_line":"        conductors \u003d []"},{"line_number":89,"context_line":"        for i in range(0, num):"},{"line_number":90,"context_line":"            conductor \u003d utils.create_test_conductor("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_93fe9f03","line":87,"range":{"start_line":87,"start_character":38,"end_line":87,"end_character":50},"updated":"2017-10-10 10:55:38.000000000","message":"Is this parameter necessary? If it is specified, the assertion in line 97 fails.","commit_id":"f981abeed47b9a4c7fc323e5921da2350bb4eca5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3bbe369991520700086392b4ab3958a6d9eb693e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            conductor \u003d self.dbapi.get_conductor(hostname)"},{"line_number":85,"context_line":"            self.assertEqual(self.conductor_ver, conductor.version)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _create_conductors(self, num, version\u003dNone):"},{"line_number":88,"context_line":"        conductors \u003d []"},{"line_number":89,"context_line":"        for i in range(0, num):"},{"line_number":90,"context_line":"            conductor \u003d utils.create_test_conductor("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_0b2ee6a4","line":87,"range":{"start_line":87,"start_character":38,"end_line":87,"end_character":50},"in_reply_to":"5f4e5783_7018ab80","updated":"2017-10-10 18:09:21.000000000","message":"I decided to leave this, and changed L97. Change is in patch set 7.","commit_id":"f981abeed47b9a4c7fc323e5921da2350bb4eca5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f060e679abd78d4ec7f7d0a5509d93ac6e5f073f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            conductor \u003d self.dbapi.get_conductor(hostname)"},{"line_number":85,"context_line":"            self.assertEqual(self.conductor_ver, conductor.version)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _create_conductors(self, num, version\u003dNone):"},{"line_number":88,"context_line":"        conductors \u003d []"},{"line_number":89,"context_line":"        for i in range(0, num):"},{"line_number":90,"context_line":"            conductor \u003d utils.create_test_conductor("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_7018ab80","line":87,"range":{"start_line":87,"start_character":38,"end_line":87,"end_character":50},"in_reply_to":"5f4e5783_93fe9f03","updated":"2017-10-10 17:38:17.000000000","message":"Good catch. That\u0027s a copy/paste from the original _create_nodes(), which has the same problem.","commit_id":"f981abeed47b9a4c7fc323e5921da2350bb4eca5"}],"releasenotes/notes/conductor-version-backfill-9d06f2ad81aebec3.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3dba62a1b09338725ae53f61ce5f540dca6132d1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As the last step in upgrading, the command"},{"line_number":5,"context_line":"    ``ironic-dbsync online_data_migrations`` must be run to ensure that"},{"line_number":6,"context_line":"    the database table for conductors has its version column populated."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff5d4b2f_ac9499e9","line":6,"updated":"2017-09-19 16:43:59.000000000","message":"Not a -1, but I think we should assume that this command is always run in the end of an upgrade, it\u0027s our documented upgrade procedure. Rather, I\u0027d say something like \"The version column is populated as part of data migration.\"","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179cc8d69fa015d30f20bb93a667ec0663b0ceb5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As the last step in upgrading, the command"},{"line_number":5,"context_line":"    ``ironic-dbsync online_data_migrations`` must be run to ensure that"},{"line_number":6,"context_line":"    the database table for conductors has its version column populated."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf57530f_a3994a20","line":6,"in_reply_to":"ff5d4b2f_ac9499e9","updated":"2017-09-20 13:44:05.000000000","message":"Good point.","commit_id":"1b440343a61c416f65f4ed6e911b0fe4e4310e03"}]}
