)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0574690542dea32b3250cda51ebecad5b5b4c966","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Test ironic-dbsync online_data_migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Run ironic-dbsync online_data_migrations on single node grenade"},{"line_number":10,"context_line":"ringht after usual dbsync."},{"line_number":11,"context_line":"Do not set pin_relase_version for single node grenade as we"},{"line_number":12,"context_line":"do cold upgrade and it is not required."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_1b86c467","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"updated":"2017-08-27 05:29:43.000000000","message":"nit: spelling","commit_id":"526852325b292a70b26eeb2efd6c1a90155fe055"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd002b961f1052353e0734480c669a2757dbc6d3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Do not set pin_relase_version for single node grenade as we"},{"line_number":12,"context_line":"do cold upgrade and it is not required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2e331252aeb66376c2d6cc3c16b6de0aefca5434"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_dde81ee3","line":14,"updated":"2017-08-28 15:03:15.000000000","message":"I wouldn\u0027t mind a related bug, we could use the same rolling upgrades bug: 1526283, or the online-data-migrations one 1502887","commit_id":"526852325b292a70b26eeb2efd6c1a90155fe055"}],"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd002b961f1052353e0734480c669a2757dbc6d3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"if [[ \"${HOST_TOPOLOGY}\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":79,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT pin_release_version ${BASE_DEVSTACK_BRANCH#*/}"},{"line_number":80,"context_line":"else"},{"line_number":81,"context_line":"    ironic-dbsync online_data_migrations"},{"line_number":82,"context_line":"fi"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ensure_started\u003d\u0027ironic-conductor nova-compute \u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_9d8f3674","line":81,"updated":"2017-08-28 15:03:15.000000000","message":"this will / should work if called here.","commit_id":"526852325b292a70b26eeb2efd6c1a90155fe055"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd002b961f1052353e0734480c669a2757dbc6d3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"fi"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ensure_services_started $ensure_started"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# We need these steps only in case of flat-network"},{"line_number":125,"context_line":"# NOTE(vsaienko) starting from Ocata when Neutron is restarted there is no guarantee that"},{"line_number":126,"context_line":"# internal tag, that was assigned to network will be the same. As result we need to update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_1d58e6f7","line":123,"updated":"2017-08-28 15:03:15.000000000","message":"i wonder if it might be more interesting to make the online_data_migrations call here, after the services are running. The only issue may be if it wants to update an object, eg a node that is locked by the conductor. So maybe we want to take the safe way, at least for now. Unless we want to loop/make the online_data_migrations call until it succeeds but I think that complicates testing...","commit_id":"526852325b292a70b26eeb2efd6c1a90155fe055"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6896b094598f69daee723cf13d3c1468c3769d19","unresolved":false,"context_lines":[{"line_number":120,"context_line":"fi"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ensure_services_started $ensure_started"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# We need these steps only in case of flat-network"},{"line_number":125,"context_line":"# NOTE(vsaienko) starting from Ocata when Neutron is restarted there is no guarantee that"},{"line_number":126,"context_line":"# internal tag, that was assigned to network will be the same. As result we need to update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_3854d0fe","line":123,"in_reply_to":"7f287b81_1d58e6f7","updated":"2017-08-28 15:21:55.000000000","message":"yeah, would be good to actually check that all data is migrated... OTOH we dont have much of the objects in grenade, so should be fine as a first step.","commit_id":"526852325b292a70b26eeb2efd6c1a90155fe055"}]}