)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"21bfb6098b835b0e5064445b90d45e72af44b324","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For a \"GET /nodes?limit\u003d1\u0026instance_uuid\u003d\u003cuuid\u003e\" request that has a"},{"line_number":10,"context_line":"node that matches, the response would include a \u0027next\u0027 link"},{"line_number":11,"context_line":"(which is incorrect -- that link would return any nodes). However,"},{"line_number":12,"context_line":"at most one node can match the specified instance UUID, so"},{"line_number":13,"context_line":"we should not be returning any \u0027next\u0027 link. This fixes it so no"},{"line_number":14,"context_line":"\u0027next\u0027 link is returned."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f5c4f37_dbbbfce2","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":38},"updated":"2017-09-21 15:19:32.000000000","message":"nit - wouldn\u0027t","commit_id":"8eed047b85b96bef58ac672fb43f5d06f082c368"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"056115f74e0daaeb6391e590cf0d928596b48125","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For a \"GET /nodes?limit\u003d1\u0026instance_uuid\u003d\u003cuuid\u003e\" request that has a"},{"line_number":10,"context_line":"node that matches, the response would include a \u0027next\u0027 link"},{"line_number":11,"context_line":"(which is incorrect -- that link would return any nodes). However,"},{"line_number":12,"context_line":"at most one node can match the specified instance UUID, so"},{"line_number":13,"context_line":"we should not be returning any \u0027next\u0027 link. This fixes it so no"},{"line_number":14,"context_line":"\u0027next\u0027 link is returned."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f5c4f37_36c22f87","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":38},"in_reply_to":"9f5c4f37_dbbbfce2","updated":"2017-09-21 15:50:04.000000000","message":"no, that incorrect link would return any nodes, not just the node associated with the instance. guess i need to reword it or just delete this incorrect part.","commit_id":"8eed047b85b96bef58ac672fb43f5d06f082c368"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6e82f3d340df69e53b64000882aedf02b171d1f4","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"        if instance_uuid:"},{"line_number":1314,"context_line":"            # The other query parameters are ignored if instance_uuid is"},{"line_number":1315,"context_line":"            # specified."},{"line_number":1316,"context_line":"            parameters \u003d {}"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"            # There will be at most one node that has this instance_uuid."},{"line_number":1319,"context_line":"            nodes \u003d self._get_nodes_by_instance(instance_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f5c4f37_6c88d81e","line":1316,"updated":"2017-09-21 16:52:54.000000000","message":"This seems like a change in behavior.\n\nWhat if they specified an instance_uuid and a condition that the instance did not satisfy. So I assume it would return nothing. But now it returns the node.","commit_id":"026a12bf0b7877b3670ca7f842bcdb0772d06b49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7b77ad13a08b265f25eb12baa99847b2a6039112","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"        if instance_uuid:"},{"line_number":1314,"context_line":"            # The other query parameters are ignored if instance_uuid is"},{"line_number":1315,"context_line":"            # specified."},{"line_number":1316,"context_line":"            parameters \u003d {}"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"            # There will be at most one node that has this instance_uuid."},{"line_number":1319,"context_line":"            nodes \u003d self._get_nodes_by_instance(instance_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f5c4f37_47128f5a","line":1316,"in_reply_to":"9f5c4f37_6c39f83f","updated":"2017-09-21 17:11:53.000000000","message":"parameters are *only* used for generating the \u0027next\u0027 link. I changed to code to make it clearer that in the instance_uuid case, parameters should be empty because NO \u0027next\u0027 link should be generated.\n\nMaybe what is confusing is that the comment is a general comment about this if case, not specifically about this line.\n\nHmm, let me change things around.","commit_id":"026a12bf0b7877b3670ca7f842bcdb0772d06b49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"86b0d1f83a1d9e7a9b95e49b4c258edfe0628649","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"        if instance_uuid:"},{"line_number":1314,"context_line":"            # The other query parameters are ignored if instance_uuid is"},{"line_number":1315,"context_line":"            # specified."},{"line_number":1316,"context_line":"            parameters \u003d {}"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"            # There will be at most one node that has this instance_uuid."},{"line_number":1319,"context_line":"            nodes \u003d self._get_nodes_by_instance(instance_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f5c4f37_ace130d3","line":1316,"in_reply_to":"9f5c4f37_6c88d81e","updated":"2017-09-21 16:54:25.000000000","message":"Nope, it isn\u0027t a change in behaviour. Well, it is fixing a bug. parameters are only used for generating the \u0027next\u0027 link. which we don\u0027t want to return if instance_uuid is specified in the request.","commit_id":"026a12bf0b7877b3670ca7f842bcdb0772d06b49"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e5a61143df2c55d676ec7db2d8b606e91fb389bf","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"        if instance_uuid:"},{"line_number":1314,"context_line":"            # The other query parameters are ignored if instance_uuid is"},{"line_number":1315,"context_line":"            # specified."},{"line_number":1316,"context_line":"            parameters \u003d {}"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"            # There will be at most one node that has this instance_uuid."},{"line_number":1319,"context_line":"            nodes \u003d self._get_nodes_by_instance(instance_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f5c4f37_6c39f83f","line":1316,"in_reply_to":"9f5c4f37_6c88d81e","updated":"2017-09-21 16:59:21.000000000","message":"So now we are ignoring the \u0027maintenance\u0027 and \u0027associated\u0027 fields.","commit_id":"026a12bf0b7877b3670ca7f842bcdb0772d06b49"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f096ca250279dfa73ec63036b6335c794f062fa8","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        if instance_uuid:"},{"line_number":1317,"context_line":"            # NOTE(rloo) if instance_uuid is specified, the other query"},{"line_number":1318,"context_line":"            # parameters are ignored. Since there can be at most one node that"},{"line_number":1319,"context_line":"            # has this nstance_uuid, we do not want to generate a \u0027next\u0027 link."},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"            nodes \u003d self._get_nodes_by_instance(instance_uuid)"},{"line_number":1322,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_d8375ab0","line":1319,"range":{"start_line":1319,"start_character":23,"end_line":1319,"end_character":35},"updated":"2017-09-27 16:35:14.000000000","message":"nit: s/nstance_uuid/instance_uuid/","commit_id":"18426f2d1f62bd0f3d0cc5ee7257f8c22269e32c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f34d5a136254788b7f5ff730a5ca81853dee4f56","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        if instance_uuid:"},{"line_number":1317,"context_line":"            # NOTE(rloo) if instance_uuid is specified, the other query"},{"line_number":1318,"context_line":"            # parameters are ignored. Since there can be at most one node that"},{"line_number":1319,"context_line":"            # has this nstance_uuid, we do not want to generate a \u0027next\u0027 link."},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"            nodes \u003d self._get_nodes_by_instance(instance_uuid)"},{"line_number":1322,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_8e302aea","line":1319,"range":{"start_line":1319,"start_character":23,"end_line":1319,"end_character":35},"in_reply_to":"7f515b1d_d8375ab0","updated":"2017-09-27 16:56:10.000000000","message":"Whoops, good catch. Thx.","commit_id":"18426f2d1f62bd0f3d0cc5ee7257f8c22269e32c"}]}