)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"75178f385e26915661ef993dba5878b125bed266","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-25 08:44:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[docs] descibe vendor passthru in hw types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add a `Vendor` section to `Upgrade to Hardware Types` page"},{"line_number":10,"context_line":"that describes changes to take when migrating a classic driver that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_58d7f8ee","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"updated":"2017-09-25 09:21:26.000000000","message":"describe","commit_id":"b8a92bebd0e900623169d4dc8a9d6a11252bb239"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"20bace5ce3376ea3485d9f5f39296c384fcfd6b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-25 08:44:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[docs] descibe vendor passthru in hw types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add a `Vendor` section to `Upgrade to Hardware Types` page"},{"line_number":10,"context_line":"that describes changes to take when migrating a classic driver that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_b8b14c92","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"in_reply_to":"7f515b1d_58d7f8ee","updated":"2017-09-25 09:27:14.000000000","message":"Done","commit_id":"b8a92bebd0e900623169d4dc8a9d6a11252bb239"}],"doc/source/admin/upgrade-to-hardware-types.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"75178f385e26915661ef993dba5878b125bed266","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Vendor"},{"line_number":220,"context_line":"~~~~~~"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Classic drivers allowed to use a ``VendorMixin`` functionality"},{"line_number":223,"context_line":"to combine and expose several node or driver vendor passthru methods"},{"line_number":224,"context_line":"from different vendor interface implementations in one driver."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_180bc08e","line":222,"range":{"start_line":222,"start_character":16,"end_line":222,"end_character":23},"updated":"2017-09-25 09:21:26.000000000","message":"were/are allowed","commit_id":"b8a92bebd0e900623169d4dc8a9d6a11252bb239"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"20bace5ce3376ea3485d9f5f39296c384fcfd6b1","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Vendor"},{"line_number":220,"context_line":"~~~~~~"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Classic drivers allowed to use a ``VendorMixin`` functionality"},{"line_number":223,"context_line":"to combine and expose several node or driver vendor passthru methods"},{"line_number":224,"context_line":"from different vendor interface implementations in one driver."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_98ae902c","line":222,"range":{"start_line":222,"start_character":16,"end_line":222,"end_character":23},"in_reply_to":"7f515b1d_180bc08e","updated":"2017-09-25 09:27:14.000000000","message":"Done","commit_id":"b8a92bebd0e900623169d4dc8a9d6a11252bb239"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Vendor"},{"line_number":220,"context_line":"~~~~~~"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Classic drivers are allowed to use a ``VendorMixin`` functionality"},{"line_number":223,"context_line":"to combine and expose several node or driver vendor passthru methods"},{"line_number":224,"context_line":"from different vendor interface implementations in one driver."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_10262918","line":222,"updated":"2017-10-03 20:34:41.000000000","message":"nit, maybe s/use a/use the/","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Vendor"},{"line_number":220,"context_line":"~~~~~~"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Classic drivers are allowed to use a ``VendorMixin`` functionality"},{"line_number":223,"context_line":"to combine and expose several node or driver vendor passthru methods"},{"line_number":224,"context_line":"from different vendor interface implementations in one driver."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_317e9ee4","line":222,"in_reply_to":"7f515b1d_10262918","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"**This is no longer possible with hardware types.**"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"With hardware types, a vendor interface can have only single active"},{"line_number":229,"context_line":"implementation from the list of vendor interfaces supported by a given"},{"line_number":230,"context_line":"hardware type."},{"line_number":231,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_d01f71b5","line":228,"updated":"2017-10-03 20:34:41.000000000","message":"nit s/only/only a/","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"**This is no longer possible with hardware types.**"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"With hardware types, a vendor interface can have only single active"},{"line_number":229,"context_line":"implementation from the list of vendor interfaces supported by a given"},{"line_number":230,"context_line":"hardware type."},{"line_number":231,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_f187e6d6","line":228,"in_reply_to":"7f515b1d_d01f71b5","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"implementation from the list of vendor interfaces supported by a given"},{"line_number":230,"context_line":"hardware type."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"While there are no drivers (both classic and hardware types) left in-tree that"},{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support, if you are using an"},{"line_number":234,"context_line":"out-of-tree classic driver that depends on it, there is a certain change in the"},{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_f0670d51","line":232,"updated":"2017-10-03 20:34:41.000000000","message":"maybe \n\ns/While/Although/\n\ns/drivers (..) left in-tree/in-tree drivers (..)/","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":229,"context_line":"implementation from the list of vendor interfaces supported by a given"},{"line_number":230,"context_line":"hardware type."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"While there are no drivers (both classic and hardware types) left in-tree that"},{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support, if you are using an"},{"line_number":234,"context_line":"out-of-tree classic driver that depends on it, there is a certain change in the"},{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_b1696e26","line":232,"in_reply_to":"7f515b1d_f0670d51","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"While there are no drivers (both classic and hardware types) left in-tree that"},{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support, if you are using an"},{"line_number":234,"context_line":"out-of-tree classic driver that depends on it, there is a certain change in the"},{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_f0d5cdb8","line":234,"updated":"2017-10-03 20:34:41.000000000","message":"\u0027there is a certain change in the workflow\u0027 is awkward.  Maybe\n\n..driver that depends on it, you\u0027ll need to do the following in order to use vendor passthru methods from different vendor passthru implementations:","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"While there are no drivers (both classic and hardware types) left in-tree that"},{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support, if you are using an"},{"line_number":234,"context_line":"out-of-tree classic driver that depends on it, there is a certain change in the"},{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_91767206","line":234,"in_reply_to":"7f515b1d_f0d5cdb8","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support, if you are using an"},{"line_number":234,"context_line":"out-of-tree classic driver that depends on it, there is a certain change in the"},{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"#. While migrating your classic driver to a hardware type, specify"},{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_305fe573","line":236,"updated":"2017-10-03 20:34:41.000000000","message":"It might be good to split the above into two or more sentences; it is a very long single sentence. Maybe something like\n\nThere are no in-tree drivers... However, if you are using an out-of-tree...","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support, if you are using an"},{"line_number":234,"context_line":"out-of-tree classic driver that depends on it, there is a certain change in the"},{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"#. While migrating your classic driver to a hardware type, specify"},{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_7173f616","line":236,"in_reply_to":"7f515b1d_305fe573","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"de39f26448a45a97ddf55a74434adc46abfb7923","unresolved":false,"context_lines":[{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"#. While migrating your classic driver to a hardware type, specify"},{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"},{"line_number":240,"context_line":"   as supported vendor interfaces."},{"line_number":241,"context_line":"#. Ensure all required vendor interfaces are enabled in the ironic"},{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_826e6bc6","line":240,"range":{"start_line":238,"start_character":59,"end_line":240,"end_character":34},"updated":"2017-10-02 14:04:19.000000000","message":"This point gives impression that we need to so something to add vendor interfaces  somewhere. Essentially the point below is the action to add them in the enabled_vendor_interfaces`. If we could club these two points it would simplify.","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"#. While migrating your classic driver to a hardware type, specify"},{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"},{"line_number":240,"context_line":"   as supported vendor interfaces."},{"line_number":241,"context_line":"#. Ensure all required vendor interfaces are enabled in the ironic"},{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_e0e14d00","line":240,"range":{"start_line":238,"start_character":59,"end_line":240,"end_character":34},"in_reply_to":"7f515b1d_105e2945","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"workflow to use vendor passthru methods from different vendor passthru"},{"line_number":236,"context_line":"implementations:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"#. While migrating your classic driver to a hardware type, specify"},{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"},{"line_number":240,"context_line":"   as supported vendor interfaces."},{"line_number":241,"context_line":"#. Ensure all required vendor interfaces are enabled in the ironic"},{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_105e2945","line":240,"range":{"start_line":238,"start_character":59,"end_line":240,"end_character":34},"in_reply_to":"7f515b1d_826e6bc6","updated":"2017-10-03 20:34:41.000000000","message":"No, I think Pavlo means that in the new hardware type, they need to add the vendor implementations to [1] GenericHardware.supported_vendor_interfaces(). \n\nPavlo, given that their classic driver is out of tree, it is possible that they\u0027ll need to create an out-of-tree hardware type. (And if they are using an intree hardware type, they might want to subclass it, in order to do the .supported_vendor_interfaces() thing.\n\n[1] https://docs.openstack.org/ironic/latest/_modules/ironic/drivers/generic.html#GenericHardware","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"de39f26448a45a97ddf55a74434adc46abfb7923","unresolved":false,"context_lines":[{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"},{"line_number":240,"context_line":"   as supported vendor interfaces."},{"line_number":241,"context_line":"#. Ensure all required vendor interfaces are enabled in the ironic"},{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."},{"line_number":244,"context_line":"#. Before invoking a specific vendor passthru method via the"},{"line_number":245,"context_line":"   ironic API, ensure that current active vendor interface is"},{"line_number":246,"context_line":"   the one that exposes this given method."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_4224f35d","line":243,"range":{"start_line":242,"start_character":32,"end_line":243,"end_character":10},"updated":"2017-10-02 14:04:19.000000000","message":"You may also need to explain \u0027[DEFAULT]/default_vendor_interface\u0027.","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":239,"context_line":"   all vendor interface implementations your classic driver was using"},{"line_number":240,"context_line":"   as supported vendor interfaces."},{"line_number":241,"context_line":"#. Ensure all required vendor interfaces are enabled in the ironic"},{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."},{"line_number":244,"context_line":"#. Before invoking a specific vendor passthru method via the"},{"line_number":245,"context_line":"   ironic API, ensure that current active vendor interface is"},{"line_number":246,"context_line":"   the one that exposes this given method."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_80f059cb","line":243,"range":{"start_line":242,"start_character":32,"end_line":243,"end_character":10},"in_reply_to":"7f515b1d_4224f35d","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7d02cc8ff4588ec032ee7326f683ea05a469d5e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."},{"line_number":244,"context_line":"#. Before invoking a specific vendor passthru method via the"},{"line_number":245,"context_line":"   ironic API, ensure that current active vendor interface is"},{"line_number":246,"context_line":"   the one that exposes this given method."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"   - Example of CLI command:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_e364e5e7","line":245,"updated":"2017-10-03 20:34:41.000000000","message":"How about something like\n\nBefore invoking a specific vendor passthru method, make sure that the node\u0027s vendor interface is set to the interface with the desired vendor passthru method.\n\nFor example, if you want to invoke the vendor passthru method \u0027passmethod()\u0027 from \u0027zvendor\u0027 vendor interface:\n\n1. set the vendor interface to zvendor:\n   openstack --os-baremetal... baremetal node set ... vendora\n2. invoke the method:\n  openstack baremetal node passthru call \u003cnode\u003e passmethod","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":242,"context_line":"   configuration file under the ``[DEFAULT]enabled_vendor_interfaces``"},{"line_number":243,"context_line":"   option."},{"line_number":244,"context_line":"#. Before invoking a specific vendor passthru method via the"},{"line_number":245,"context_line":"   ironic API, ensure that current active vendor interface is"},{"line_number":246,"context_line":"   the one that exposes this given method."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"   - Example of CLI command:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_20940537","line":245,"in_reply_to":"7f515b1d_e364e5e7","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"de39f26448a45a97ddf55a74434adc46abfb7923","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"     .. code-block:: shell"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        openstack --os-baremetal-api-version latest baremetal node set \u003cnode-ident\u003e --vendor-interface \u003cvendor-interface\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_c2910349","line":252,"range":{"start_line":252,"start_character":45,"end_line":252,"end_character":51},"updated":"2017-10-02 14:04:19.000000000","message":"Better to mention exact version.\nexport OS_BAREMETAL_API_VERSION\u003d1.31\nopenstack baremetal node set \u003cnode-ident\u003e --vendor-interface \u003cvendor-interface\u003e","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e0848148f3773db68d8c79b5ed136bd4588e4b6","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"     .. code-block:: shell"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        openstack --os-baremetal-api-version latest baremetal node set \u003cnode-ident\u003e --vendor-interface \u003cvendor-interface\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f4e5783_0099096d","line":252,"range":{"start_line":252,"start_character":45,"end_line":252,"end_character":51},"in_reply_to":"7f515b1d_c2910349","updated":"2017-10-11 11:24:46.000000000","message":"Done","commit_id":"5416534cb851771137dbfbd7cc7a1ad49594c077"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fcc25c735396bb2d9a04684de7e503cd1fbb895b","unresolved":false,"context_lines":[{"line_number":230,"context_line":"hardware type."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Ironic has no in-tree drivers (both classic and hardware types) that"},{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support any longer."},{"line_number":234,"context_line":"However if you are using an out-of-tree classic driver that depends on it,"},{"line_number":235,"context_line":"you\u0027ll need to do the following in order to use vendor"},{"line_number":236,"context_line":"passthru methods from different vendor passthru implementations:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_af27be12","line":233,"updated":"2017-10-11 14:16:40.000000000","message":"nit, maybe \u0027Ironic no longer has any in-tree drivers... support.\u0027","commit_id":"e6d519d45631a92aa5abf334bc030528bf2df3cc"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9c70832c36703e2258ea367e3ef504b3bac1cc1f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"hardware type."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Ironic has no in-tree drivers (both classic and hardware types) that"},{"line_number":233,"context_line":"rely on this ``VendorMixin`` functionality support any longer."},{"line_number":234,"context_line":"However if you are using an out-of-tree classic driver that depends on it,"},{"line_number":235,"context_line":"you\u0027ll need to do the following in order to use vendor"},{"line_number":236,"context_line":"passthru methods from different vendor passthru implementations:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_f03b40ce","line":233,"in_reply_to":"5f4e5783_af27be12","updated":"2017-10-12 08:44:35.000000000","message":"Done","commit_id":"e6d519d45631a92aa5abf334bc030528bf2df3cc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fcc25c735396bb2d9a04684de7e503cd1fbb895b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"   make sure that the node\u0027s vendor interface is set to the interface"},{"line_number":251,"context_line":"   with the desired vendor passthru method."},{"line_number":252,"context_line":"   For example, if you want to invoke the vendor passthru method"},{"line_number":253,"context_line":"   ``passmethodZ()`` from ``vendorZ`` vendor interface:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"     .. code-block:: shell"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_4f8f2acc","line":253,"updated":"2017-10-11 14:16:40.000000000","message":"nit: I don\u0027t think we\u0027d ever use uppercase for the method name or interface. although i have no idea whether using it in an example would confuse users or not.","commit_id":"e6d519d45631a92aa5abf334bc030528bf2df3cc"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9c70832c36703e2258ea367e3ef504b3bac1cc1f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"   make sure that the node\u0027s vendor interface is set to the interface"},{"line_number":251,"context_line":"   with the desired vendor passthru method."},{"line_number":252,"context_line":"   For example, if you want to invoke the vendor passthru method"},{"line_number":253,"context_line":"   ``passmethodZ()`` from ``vendorZ`` vendor interface:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"     .. code-block:: shell"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_90308cea","line":253,"in_reply_to":"5f4e5783_4f8f2acc","updated":"2017-10-12 08:44:35.000000000","message":"switched to \"_foo\" suffix :)","commit_id":"e6d519d45631a92aa5abf334bc030528bf2df3cc"}]}