)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c781cbde9e2ab319c0005b9c47eb7ad574ca3c04","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch switch ironic to run under uwsgi."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: #1719260"},{"line_number":12,"context_line":"Co-Autored-By: anascko \u003covoshchana@mirantis.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9ef3aa48db6efe8e2216af785cc13fdb7f754a02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5f4e5783_e1b5817f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":13},"updated":"2017-10-13 18:16:46.000000000","message":"Co-Authored-By:","commit_id":"66ddd182861fb8d789753a06f8d32d636d832434"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch switch ironic to run under uwsgi."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"It also affectively moves all jobs except grenade ones to"},{"line_number":12,"context_line":"run ironic-api under UWSGI as we start to honor the devstack\u0027s"},{"line_number":13,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES variable (which is True by default)."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa0c359_fd46f14f","line":11,"updated":"2018-02-05 16:04:47.000000000","message":"nit s/affectively/effectively/","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"84c850490f762857bec38d6fc9553ebd70ff1db8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch switch ironic to run under uwsgi."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"It also affectively moves all jobs except grenade ones to"},{"line_number":12,"context_line":"run ironic-api under UWSGI as we start to honor the devstack\u0027s"},{"line_number":13,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES variable (which is True by default)."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9f6a8fd7_8ef0b892","line":11,"in_reply_to":"3fa0c359_fd46f14f","updated":"2018-04-17 16:27:30.000000000","message":"Done","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e59203af03a373ae7143fa04ed33f3c0662ff9ac","unresolved":false,"context_lines":[{"line_number":11,"context_line":"It also affectively moves all jobs except grenade ones to"},{"line_number":12,"context_line":"run ironic-api under UWSGI as we start to honor the devstack\u0027s"},{"line_number":13,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES variable (which is True by default)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1719260"},{"line_number":16,"context_line":"Co-Authored-By: anascko \u003covoshchana@mirantis.com\u003e"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa0c359_a894a9e9","line":14,"updated":"2018-02-05 16:19:45.000000000","message":"I don\u0027t know if we do renos for devstack changes, so I guess we shouldn\u0027t start now.\n\nBut I think it is worth adding a comment here, that our devstack set up no longer supports running ironic under mod-wsgi (even though ironic can be run under mod-wsgi).","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"84c850490f762857bec38d6fc9553ebd70ff1db8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"It also affectively moves all jobs except grenade ones to"},{"line_number":12,"context_line":"run ironic-api under UWSGI as we start to honor the devstack\u0027s"},{"line_number":13,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES variable (which is True by default)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1719260"},{"line_number":16,"context_line":"Co-Authored-By: anascko \u003covoshchana@mirantis.com\u003e"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9f6a8fd7_6ef3e49f","line":14,"in_reply_to":"3fa0c359_a894a9e9","updated":"2018-04-17 16:27:30.000000000","message":"Done","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6be6d1f56c1204d83b8df3b1ca0fbeab2f8eb59a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"It also affectively moves all jobs except grenade ones to"},{"line_number":12,"context_line":"run ironic-api under UWSGI as we start to honor the devstack\u0027s"},{"line_number":13,"context_line":"ENABLE_HTTPD_MOD_WSGI_SERVICES variable (which is True by default)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1719260"},{"line_number":16,"context_line":"Co-Authored-By: anascko \u003covoshchana@mirantis.com\u003e"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa0c359_e353b2e1","line":14,"in_reply_to":"3fa0c359_a894a9e9","updated":"2018-02-05 18:36:01.000000000","message":"yes, forgot about that, will add","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"}],"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"367532fbd1b5923d88dab49f87ae7ffac08977ac","unresolved":false,"context_lines":[{"line_number":65,"context_line":"IRONIC_ROOTWRAP_CONF\u003d$IRONIC_CONF_DIR/rootwrap.conf"},{"line_number":66,"context_line":"IRONIC_POLICY_JSON\u003d$IRONIC_CONF_DIR/policy.json"},{"line_number":67,"context_line":"if [[ \"$ENABLE_HTTPD_MOD_WSGI_SERVICES\" \u003d\u003d \"True\" ]]; then"},{"line_number":68,"context_line":"    IRONIC_USE_MOD_WSGI\u003d${IRONIC_USE_MOD_WSGI:-True}"},{"line_number":69,"context_line":"else"},{"line_number":70,"context_line":"    IRONIC_USE_MOD_WSGI\u003d$(trueorfalse False IRONIC_USE_MOD_WSGI)"},{"line_number":71,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f515b1d_9ccc1662","line":68,"updated":"2017-09-26 13:05:28.000000000","message":"I think you pass this through trueorfalse too..","commit_id":"058722ed4374efe1708e4d0e157a2aca0457fd93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"367532fbd1b5923d88dab49f87ae7ffac08977ac","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    IRONIC_USE_MOD_WSGI\u003d${IRONIC_USE_MOD_WSGI:-True}"},{"line_number":69,"context_line":"else"},{"line_number":70,"context_line":"    IRONIC_USE_MOD_WSGI\u003d$(trueorfalse False IRONIC_USE_MOD_WSGI)"},{"line_number":71,"context_line":"fi"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Deploy callback timeout can be changed from its default (1800), if required."},{"line_number":74,"context_line":"IRONIC_CALLBACK_TIMEOUT\u003d${IRONIC_CALLBACK_TIMEOUT:-}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f515b1d_7cdb9a1a","line":71,"updated":"2017-09-26 13:05:28.000000000","message":"might be a bit more readable:\n\n IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)","commit_id":"058722ed4374efe1708e4d0e157a2aca0457fd93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"367532fbd1b5923d88dab49f87ae7ffac08977ac","unresolved":false,"context_lines":[{"line_number":281,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":282,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":283,"context_line":"else"},{"line_number":284,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":285,"context_line":"fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f515b1d_5cd69ef3","line":284,"updated":"2017-09-26 13:05:28.000000000","message":"this should be used with uWSGI too (i.e. /baremetal instead of the port).","commit_id":"058722ed4374efe1708e4d0e157a2aca0457fd93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"367532fbd1b5923d88dab49f87ae7ffac08977ac","unresolved":false,"context_lines":[{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"    # Adds ironic site for IPXE"},{"line_number":1022,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]]; then"},{"line_number":1023,"context_line":"        _config_ironic_apache_ipxe"},{"line_number":1024,"context_line":"    fi"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"    # Adds uWSGI for Ironic API"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f515b1d_3c076285","line":1023,"updated":"2017-09-26 13:05:28.000000000","message":"I wonder if we should move away from apache here too..","commit_id":"058722ed4374efe1708e4d0e157a2aca0457fd93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"367532fbd1b5923d88dab49f87ae7ffac08977ac","unresolved":false,"context_lines":[{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":1348,"context_line":"        run_process \"ir-api\" \"$IRONIC_BIN_DIR/uwsgi --procname-prefix ironic-api --ini $IRONIC_UWSGI_CONF\""},{"line_number":1349,"context_line":"        ironic_url\u003d$service_protocol://$SERVICE_HOST/baremetal"},{"line_number":1350,"context_line":"    else"},{"line_number":1351,"context_line":"        run_process ir-api \"$IRONIC_BIN_DIR/ironic-api --config-file\u003d$IRONIC_CONF_FILE\""},{"line_number":1352,"context_line":"        ironic_url\u003d$service_protocol://$SERVICE_HOST:$service_port"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f515b1d_1c0a6689","line":1349,"updated":"2017-09-26 13:05:28.000000000","message":"this has to work for uWSGI too - see above","commit_id":"058722ed4374efe1708e4d0e157a2aca0457fd93"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2df9b9ac72ad94eb69d302e2b1d2fa0f50260ad","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Deploy Ironic API under a wsgi server. The default to use uwsgi."},{"line_number":72,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":73,"context_line":"# can happen on grenade runs."},{"line_number":74,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Deploy callback timeout can be changed from its default (1800), if required."},{"line_number":77,"context_line":"IRONIC_CALLBACK_TIMEOUT\u003d${IRONIC_CALLBACK_TIMEOUT:-}"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"7f96bb07_ab90c74f","line":74,"updated":"2018-01-15 16:38:24.000000000","message":"OH. I just read the comment above again. If this flag is meant to indicate that *a* wsgi server is being used, we need to rename it. I thought that if True, it meant that mod_wsgi\u0027 was being used.\n\nHow do we distinguish using mod_wsgi vs uwsgi? Or are we not allowing the use of mod_wsgi any more? mod_wsgi still works with ironic, right, but we\u0027ve deprecated it? If so, then shouldn\u0027t we wait til remove support in ironic, before removing support in devstack?","commit_id":"813cea00d6f896e0d4ab50d08fc3aa43e17609bb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"912073745a0d208bdf5e2e5dedbdd14a3dee5e1f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Deploy Ironic API under a wsgi server. The default to use uwsgi."},{"line_number":72,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":73,"context_line":"# can happen on grenade runs."},{"line_number":74,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Deploy callback timeout can be changed from its default (1800), if required."},{"line_number":77,"context_line":"IRONIC_CALLBACK_TIMEOUT\u003d${IRONIC_CALLBACK_TIMEOUT:-}"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3fa0c359_72e1b5fe","line":74,"in_reply_to":"7f96bb07_ab90c74f","updated":"2018-02-05 10:19:05.000000000","message":"Ironic works with both uwsgi and mod_wsgi, the choice us up to the deployer/operator.\n\nIn devstack, we\u0027ll support uwsgi only, as this is much more convenient for development (logs are easier to inspect, and no need for complete apache restart in order just to restart a single API service).\n\nUnfortunately the names in the main devstack scripts are a bit messy:\n- there\u0027s a general ENABLE_HTTPD_MOD_WSGI_SERVICES (which we should honor) [0]\n- other services are expected to be toggled by \"\u003cSERVICE\u003e_USE_MOD_WSGI\" vars [0]\n- but there\u0027s also a WSGI_MODE var, defaulting to \u0027uwsgi\u0027 and a comment \u0027mod_wsgi is deprecated, don\u0027t use it\u0027 [1]\n\nSo for clarity (?) I could add yet another layer of indirection each defaulting to a previous one, like\nENABLE_HTTPD_MOD_WSGI_SERVICES -\u003e IRONIC_USE_MOD_WSGI -\u003e IRONIC_USE_WSGI\n\nWe also use the current IRONIC_USE_MOD_WSGI var in job definitions, so I\u0027d probably keep it as it is still, and get rid of this var in a followup change.","commit_id":"813cea00d6f896e0d4ab50d08fc3aa43e17609bb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IRONIC_CONF_DIR\u003d${IRONIC_CONF_DIR:-/etc/ironic}"},{"line_number":68,"context_line":"IRONIC_CONF_FILE\u003d$IRONIC_CONF_DIR/ironic.conf"},{"line_number":69,"context_line":"IRONIC_ROOTWRAP_CONF\u003d$IRONIC_CONF_DIR/rootwrap.conf"},{"line_number":70,"context_line":"# Deploy Ironic API under a wsgi server. Devstack only supports uwsgi."},{"line_number":71,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_fd5031d7","line":70,"updated":"2018-02-05 16:04:47.000000000","message":"nit maybe \u0027Deploy Ironic API under a uwsgi server (not mod_wsgi) because Devstack only supports uwsgi.\u0027","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"81b89f885bf9a7ea9a807b2713d11af0b09762b1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IRONIC_CONF_DIR\u003d${IRONIC_CONF_DIR:-/etc/ironic}"},{"line_number":68,"context_line":"IRONIC_CONF_FILE\u003d$IRONIC_CONF_DIR/ironic.conf"},{"line_number":69,"context_line":"IRONIC_ROOTWRAP_CONF\u003d$IRONIC_CONF_DIR/rootwrap.conf"},{"line_number":70,"context_line":"# Deploy Ironic API under a wsgi server. Devstack only supports uwsgi."},{"line_number":71,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9f6a8fd7_4e8f002a","line":70,"in_reply_to":"3fa0c359_092efca4","updated":"2018-04-17 16:20:46.000000000","message":"Done","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"495207aee487f497c2f0c94d7b52d172e81dd163","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IRONIC_CONF_DIR\u003d${IRONIC_CONF_DIR:-/etc/ironic}"},{"line_number":68,"context_line":"IRONIC_CONF_FILE\u003d$IRONIC_CONF_DIR/ironic.conf"},{"line_number":69,"context_line":"IRONIC_ROOTWRAP_CONF\u003d$IRONIC_CONF_DIR/rootwrap.conf"},{"line_number":70,"context_line":"# Deploy Ironic API under a wsgi server. Devstack only supports uwsgi."},{"line_number":71,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_092efca4","line":70,"in_reply_to":"3fa0c359_83af4e93","updated":"2018-02-05 19:32:00.000000000","message":"Oh. So \u0027Devstack only supports uwsgi\u0027 isn\u0027t quite right. How about:\n\nDeploy Ironic API under uwsgi server (not mode_wsgi) because devstack plans to get rid of support for mod-wsgi and doesn\u0027t want ironic to use it in devstack.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6be6d1f56c1204d83b8df3b1ca0fbeab2f8eb59a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IRONIC_CONF_DIR\u003d${IRONIC_CONF_DIR:-/etc/ironic}"},{"line_number":68,"context_line":"IRONIC_CONF_FILE\u003d$IRONIC_CONF_DIR/ironic.conf"},{"line_number":69,"context_line":"IRONIC_ROOTWRAP_CONF\u003d$IRONIC_CONF_DIR/rootwrap.conf"},{"line_number":70,"context_line":"# Deploy Ironic API under a wsgi server. Devstack only supports uwsgi."},{"line_number":71,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_83af4e93","line":70,"in_reply_to":"3fa0c359_fd5031d7","updated":"2018-02-05 18:36:01.000000000","message":"its not that devstack does not support mod_wsgi, but AFAIK it plans to get rid of such support eventually and asks not to use it.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Deploy Ironic API under a wsgi server. Devstack only supports uwsgi."},{"line_number":71,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_bda5c9b7","line":73,"updated":"2018-02-05 16:04:47.000000000","message":"so IRONIC_USE_MOD_WSGI is True if we want ironic to run under a WSGI server (regardless of implementation, mod_wsgi, uwsgi, or some new-fangledXWSGI)\n\nBut it is poorly named :-(","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6be6d1f56c1204d83b8df3b1ca0fbeab2f8eb59a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Deploy Ironic API under a wsgi server. Devstack only supports uwsgi."},{"line_number":71,"context_line":"# If set to False that will fall back to use the eventlet server that"},{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_c38eb62d","line":73,"in_reply_to":"3fa0c359_bda5c9b7","updated":"2018-02-05 18:36:01.000000000","message":"yes. What\u0027s more, we need the same name to be supported by stable/* branches to be able to disable it in grenade.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1b5241e3d54dfe3a4907838d735fb75b03f63553","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# can happen on grenade runs."},{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_489e4c08","line":75,"range":{"start_line":75,"start_character":52,"end_line":75,"end_character":57},"updated":"2018-02-05 11:51:19.000000000","message":"oldest","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1b5241e3d54dfe3a4907838d735fb75b03f63553","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"},{"line_number":79,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_c8581c58","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":18},"updated":"2018-02-05 11:51:19.000000000","message":"we might get rid of it earlier with the cost of providing different grenade settings per given upgrade (ocata-\u003epike and pike-\u003equeens vs queens-\u003emaster).\nAlso, in \u0027S\u0027 (or already in Rocky?) we might consider to start testing upgrades with api under WSGI on.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"},{"line_number":79,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_fd73514c","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":18},"in_reply_to":"3fa0c359_c8581c58","updated":"2018-02-05 16:04:47.000000000","message":"so we can remove it when our grenade job is from stable/rocky to master?","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"495207aee487f497c2f0c94d7b52d172e81dd163","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"},{"line_number":79,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_690a2027","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":18},"in_reply_to":"3fa0c359_ce36dab5","updated":"2018-02-05 19:32:00.000000000","message":"/me so sad.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6be6d1f56c1204d83b8df3b1ca0fbeab2f8eb59a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# The (confusing) name IRONIC_USE_MOD_WSGI is left for backward compatibility,"},{"line_number":74,"context_line":"# for example during grenade runs"},{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"},{"line_number":79,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_ce36dab5","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":18},"in_reply_to":"3fa0c359_fd73514c","updated":"2018-02-05 18:36:01.000000000","message":"not really, we\u0027ll still have grenade jobs from stable to stable.\n\nGrenade itself is branchless, but I am not completely sure how it processes settings file (I know it sources it before even installing old, but from which branch...)","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Deploy callback timeout can be changed from its default (1800), if required."},{"line_number":81,"context_line":"IRONIC_CALLBACK_TIMEOUT\u003d${IRONIC_CALLBACK_TIMEOUT:-}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_9db7add9","line":78,"updated":"2018-02-05 16:04:47.000000000","message":"IRONIC_USE_WSGI is a replacement for IRONIC_USE_MOD_WSGI, it is True if we should use an WSGI server (regardless of which implementation, mod_wsgi, uwsgi, ...)","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"81b89f885bf9a7ea9a807b2713d11af0b09762b1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# TODO(pas-ha) remove IRONIC_USE_MOD_WSGI var after older supported stable branch"},{"line_number":76,"context_line":"# is stable/queens"},{"line_number":77,"context_line":"IRONIC_USE_MOD_WSGI\u003d$(trueorfalse $ENABLE_HTTPD_MOD_WSGI_SERVICES IRONIC_USE_MOD_WSGI)"},{"line_number":78,"context_line":"IRONIC_USE_WSGI\u003d$(trueorfalse $IRONIC_USE_MOD_WSGI IRONIC_USE_WSGI)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Deploy callback timeout can be changed from its default (1800), if required."},{"line_number":81,"context_line":"IRONIC_CALLBACK_TIMEOUT\u003d${IRONIC_CALLBACK_TIMEOUT:-}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9f6a8fd7_8e9bd870","line":78,"in_reply_to":"3fa0c359_9db7add9","updated":"2018-04-17 16:20:46.000000000","message":"Done","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":860,"context_line":"    fi"},{"line_number":861,"context_line":"}"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"# _cleanup_ironic_apache_wsgi() - Remove wsgi files, disable and remove apache vhost file"},{"line_number":864,"context_line":"function _cleanup_ironic_apache_wsgi {"},{"line_number":865,"context_line":"    sudo rm -rf $IRONIC_HTTP_DIR"},{"line_number":866,"context_line":"    disable_apache_site ipxe-ironic"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_bd7dc9e8","line":863,"updated":"2018-02-05 16:04:47.000000000","message":"i wonder if we should be explicit and s/wsgi/uwsgi/\nand/or add more text to indicate that this only supports uwsgi.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"81b89f885bf9a7ea9a807b2713d11af0b09762b1","unresolved":false,"context_lines":[{"line_number":860,"context_line":"    fi"},{"line_number":861,"context_line":"}"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"# _cleanup_ironic_apache_wsgi() - Remove wsgi files, disable and remove apache vhost file"},{"line_number":864,"context_line":"function _cleanup_ironic_apache_wsgi {"},{"line_number":865,"context_line":"    sudo rm -rf $IRONIC_HTTP_DIR"},{"line_number":866,"context_line":"    disable_apache_site ipxe-ironic"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9f6a8fd7_0eb028f4","line":863,"in_reply_to":"3fa0c359_bd7dc9e8","updated":"2018-04-17 16:20:46.000000000","message":"Done","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f31eca513733e07ccbe55c9b34cefd8b6840579","unresolved":false,"context_lines":[{"line_number":865,"context_line":"    sudo rm -rf $IRONIC_HTTP_DIR"},{"line_number":866,"context_line":"    disable_apache_site ipxe-ironic"},{"line_number":867,"context_line":"    sudo rm -f $(apache_site_config_for ipxe-ironic)"},{"line_number":868,"context_line":"    remove_uwsgi_config \"$IRONIC_UWSGI_CONF\" \"$IRONIC_UWSGI\""},{"line_number":869,"context_line":"    restart_apache_server"},{"line_number":870,"context_line":"}"},{"line_number":871,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3fa0c359_88ebedae","line":868,"updated":"2018-02-05 16:04:47.000000000","message":"do we want to add this check before removing? (See L1072)\n\nif [[ \"$IRONIC_USE_WSGI\" \u003d\u003d \"True\" ]]; then\n\nBUT if we do that, shouldn\u0027t we do a similar thing above for ipxe-ironic:     if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]]; then\n\nSIGH. Guess it would be good to add a comment as to why we aren\u0027t checking... and I guess this function is somewhat poorly named... maybe _cleanup_apache_ironic_additions() or something like that.","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"81b89f885bf9a7ea9a807b2713d11af0b09762b1","unresolved":false,"context_lines":[{"line_number":865,"context_line":"    sudo rm -rf $IRONIC_HTTP_DIR"},{"line_number":866,"context_line":"    disable_apache_site ipxe-ironic"},{"line_number":867,"context_line":"    sudo rm -f $(apache_site_config_for ipxe-ironic)"},{"line_number":868,"context_line":"    remove_uwsgi_config \"$IRONIC_UWSGI_CONF\" \"$IRONIC_UWSGI\""},{"line_number":869,"context_line":"    restart_apache_server"},{"line_number":870,"context_line":"}"},{"line_number":871,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9f6a8fd7_4ea620c4","line":868,"in_reply_to":"3fa0c359_88ebedae","updated":"2018-04-17 16:20:46.000000000","message":"Done","commit_id":"77ddaf5322e7ee71cac80266a7f0efd376badb28"}],"devstack/upgrade/settings":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7b559fe7807a9d6cfa42a27cfeb5b04035222b6e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":31,"context_line":"export CELLSV2_SETUP\u003d\"singleconductor\""},{"line_number":32,"context_line":"# NOTE(vsaienko) Do not run ironic-api under wsgi after upgrade"},{"line_number":33,"context_line":"export IRONIC_USE_MOD_WSGI\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3f4b6375_e3abd3d2","line":33,"range":{"start_line":33,"start_character":27,"end_line":33,"end_character":32},"updated":"2017-10-27 14:05:21.000000000","message":"what if it was true before upgrade? I understand that it was not, but maybe let\u0027s have a variable in grenade job controlling this? or use the existing devstack var?","commit_id":"1456be8ebfeb9ee499d073d333c63a4cfa0b4757"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6fc1943cee489d7d78da185c51317d881641cecd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":31,"context_line":"export CELLSV2_SETUP\u003d\"singleconductor\""},{"line_number":32,"context_line":"# NOTE(vsaienko) Do not run ironic-api under wsgi after upgrade"},{"line_number":33,"context_line":"export IRONIC_USE_MOD_WSGI\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"9f91af0f_abed9426","line":33,"range":{"start_line":33,"start_character":27,"end_line":33,"end_character":32},"in_reply_to":"3f4b6375_e3abd3d2","updated":"2017-12-28 15:09:07.000000000","message":"since this file is used by grenade only and may be different for different branches, I\u0027d think this is how we will control the job, as we do not run several sets of grenades for all the combinations and know more or less exactly what is the setting in the \u0027old\u0027 phase for given branch-to-branch upgrade.\n\nEventually though I\u0027d like to switch to wsgi in all gates by default in Queens, and then test Queens-\u003eRocky upgrades with this turned on already.","commit_id":"1456be8ebfeb9ee499d073d333c63a4cfa0b4757"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2df9b9ac72ad94eb69d302e2b1d2fa0f50260ad","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":31,"context_line":"export CELLSV2_SETUP\u003d\"singleconductor\""},{"line_number":32,"context_line":"# NOTE(vsaienko) Do not run ironic-api under wsgi after upgrade"},{"line_number":33,"context_line":"export IRONIC_USE_MOD_WSGI\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7f96bb07_0b2f7b3f","line":33,"range":{"start_line":33,"start_character":27,"end_line":33,"end_character":32},"in_reply_to":"9f91af0f_abed9426","updated":"2018-01-15 16:38:24.000000000","message":"I think what vdrok is suggesting makes sense, but that could be an add-on later when/if it is determined that it is needed.\n\nHow\u0027s that for a non-opinionated answer? :)","commit_id":"1456be8ebfeb9ee499d073d333c63a4cfa0b4757"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd30dd40629b02573871670b91f2065c82b93e49","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(vdrok): Do not setup multicell during upgrade"},{"line_number":31,"context_line":"export CELLSV2_SETUP\u003d\"singleconductor\""},{"line_number":32,"context_line":"# NOTE(vsaienko) Do not run ironic-api under wsgi after upgrade"},{"line_number":33,"context_line":"export IRONIC_USE_MOD_WSGI\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"5f7c97a3_cb66e2bb","line":33,"updated":"2018-05-16 13:35:43.000000000","message":"at some point we want to get rid of IRONIC_USE_MOD_WSGI, so shouldn\u0027t we set this and IRONIC_USE_WSGI\u003dFalse?","commit_id":"b27396db660e1fbef82f5dc20c7fd74d09fa9598"}]}
