)]}'
{"ironic/conductor/utils.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d5f0ad921a853f70f7ab4a023999cab3c6e2c6db","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # get_power_state() call"},{"line_number":130,"context_line":"    if new_state not in (states.POWER_ON, states.POWER_OFF,"},{"line_number":131,"context_line":"                         states.SOFT_POWER_OFF):"},{"line_number":132,"context_line":"        return False"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    node \u003d task.node"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_f55d2979","line":132,"updated":"2017-10-09 13:15:23.000000000","message":"Shouldn\u0027t this change go back into the previous patch where the functions are split??","commit_id":"b5c5ce9c1e6989190cd87a5281934ef6b507fa10"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e8e95ca3ae0fb66388b62c4b73b7934f86b7cb50","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # get_power_state() call"},{"line_number":130,"context_line":"    if new_state not in (states.POWER_ON, states.POWER_OFF,"},{"line_number":131,"context_line":"                         states.SOFT_POWER_OFF):"},{"line_number":132,"context_line":"        return False"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    node \u003d task.node"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_f6201efa","line":132,"in_reply_to":"5f4e5783_71ed36ee","updated":"2017-10-18 15:40:54.000000000","message":"I\u0027m personally okay if we need to do a double revert at some point, but doubt we will need to.","commit_id":"b5c5ce9c1e6989190cd87a5281934ef6b507fa10"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1d80ba319cb4e6ab282c1761f80b23844e8dcd0b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # get_power_state() call"},{"line_number":130,"context_line":"    if new_state not in (states.POWER_ON, states.POWER_OFF,"},{"line_number":131,"context_line":"                         states.SOFT_POWER_OFF):"},{"line_number":132,"context_line":"        return False"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    node \u003d task.node"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_71ed36ee","line":132,"in_reply_to":"5f4e5783_903a07e5","updated":"2017-10-11 09:56:14.000000000","message":"It just seemed like this change goes along with the addition of the _can_skip_state_change function which happens in the previous patch, but if we want to maintain exactly the same behaviour in that patch then adding this change in after is fine, but it does exceed the scope of fixing the bug in the ipmitool driver which means if we have to revert the patch for any reason then both changes will get reverted even if there is no need to revert this part.","commit_id":"b5c5ce9c1e6989190cd87a5281934ef6b507fa10"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d432459dff1d31a0be030b3cbf6b0aac6bcaa5fc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # get_power_state() call"},{"line_number":130,"context_line":"    if new_state not in (states.POWER_ON, states.POWER_OFF,"},{"line_number":131,"context_line":"                         states.SOFT_POWER_OFF):"},{"line_number":132,"context_line":"        return False"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    node \u003d task.node"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_903a07e5","line":132,"in_reply_to":"7f515b1d_f55d2979","updated":"2017-10-10 17:37:33.000000000","message":"No, the previous patch was only to reduce the complexity without any change to functionality. This changes the functionality by not doing a read of the power state if we aren\u0027t going to use that value.","commit_id":"b5c5ce9c1e6989190cd87a5281934ef6b507fa10"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2df907ae7ac837424cc3194ac304fe646cf1f4de","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # get_power_state() call"},{"line_number":130,"context_line":"    if new_state not in (states.POWER_ON, states.POWER_OFF,"},{"line_number":131,"context_line":"                         states.SOFT_POWER_OFF):"},{"line_number":132,"context_line":"        return False"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    node \u003d task.node"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_b00983de","line":132,"in_reply_to":"7f515b1d_f55d2979","updated":"2017-10-10 17:19:19.000000000","message":"You mean https://review.openstack.org/#/c/508321/2/ironic/conductor/utils.py? No, unless we merge both of them into one patch (is that what you mean?)","commit_id":"b5c5ce9c1e6989190cd87a5281934ef6b507fa10"}]}