)]}'
{"doc/source/admin/drivers/oneview.rst":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1534f2b296e31227f12fc96174473fc8db05c6f","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  - ``server_hardware_uri``: URI of the ``Server Hardware`` on OneView."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin OneView ML2 Driver [11]_ to perform these"},{"line_number":349,"context_line":"     validations on the ironic node port configuration to maintain consistency"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_4da3f800","line":346,"range":{"start_line":346,"start_character":5,"end_line":346,"end_character":27},"updated":"2017-10-03 07:00:28.000000000","message":"is this available on pypi? if yes, i think the version of the repo should be mentioned here (like from when is the feature available in the repo).","commit_id":"9564e2b5bc11c271ccbe2441bd967dd4a5aa454a"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"aa2830cd9e68ad6506c78889cf2fd34bc27c7196","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  - ``server_hardware_uri``: URI of the ``Server Hardware`` on OneView."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin OneView ML2 Driver [11]_ to perform these"},{"line_number":349,"context_line":"     validations on the ironic node port configuration to maintain consistency"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_3cfeac6a","line":346,"range":{"start_line":346,"start_character":5,"end_line":346,"end_character":27},"in_reply_to":"7f515b1d_4da3f800","updated":"2017-10-03 11:47:13.000000000","message":"Done","commit_id":"9564e2b5bc11c271ccbe2441bd967dd4a5aa454a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1534f2b296e31227f12fc96174473fc8db05c6f","unresolved":false,"context_lines":[{"line_number":447,"context_line":".. [8] ironic-oneview-cli - https://pypi.python.org/pypi/ironic-oneview-cli/"},{"line_number":448,"context_line":".. [9] ironic-inspector - https://docs.openstack.org/ironic-inspector/latest/"},{"line_number":449,"context_line":".. [10] ironic-inspector install - https://docs.openstack.org/ironic-inspector/latest/install/index.html"},{"line_number":450,"context_line":".. [11] OneView ML2 Driver - https://github.com/HewlettPackard/ironic-driver-oneview#oneview-ml2-mechanism-driver-for-ironic-neutron-integration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_ed94e48c","line":450,"range":{"start_line":450,"start_character":8,"end_line":450,"end_character":143},"updated":"2017-10-03 07:00:28.000000000","message":"IMO, this should be part of some pypi library, and that should be mentioned here as well.","commit_id":"9564e2b5bc11c271ccbe2441bd967dd4a5aa454a"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"aa2830cd9e68ad6506c78889cf2fd34bc27c7196","unresolved":false,"context_lines":[{"line_number":447,"context_line":".. [8] ironic-oneview-cli - https://pypi.python.org/pypi/ironic-oneview-cli/"},{"line_number":448,"context_line":".. [9] ironic-inspector - https://docs.openstack.org/ironic-inspector/latest/"},{"line_number":449,"context_line":".. [10] ironic-inspector install - https://docs.openstack.org/ironic-inspector/latest/install/index.html"},{"line_number":450,"context_line":".. [11] OneView ML2 Driver - https://github.com/HewlettPackard/ironic-driver-oneview#oneview-ml2-mechanism-driver-for-ironic-neutron-integration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_dc7af821","line":450,"range":{"start_line":450,"start_character":8,"end_line":450,"end_character":143},"in_reply_to":"7f515b1d_ed94e48c","updated":"2017-10-03 11:47:13.000000000","message":"Done","commit_id":"9564e2b5bc11c271ccbe2441bd967dd4a5aa454a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"19523f5b7d028ff6da3e43bda4892bfed7138d87","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin OneView ML2 Driver version \u003e\u003d 0.3.0 [11]_"},{"line_number":349,"context_line":"     to perform these validations on the ironic node port configuration to maintain"},{"line_number":350,"context_line":"     consistency with OneView."},{"line_number":351,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_d5402a38","line":348,"range":{"start_line":348,"start_character":37,"end_line":348,"end_character":55},"updated":"2017-10-06 07:14:39.000000000","message":"s/OneView ML2 Driver/networking-oneview/","commit_id":"215888a9e43e96614f54ce8770009040ddb96060"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"19523f5b7d028ff6da3e43bda4892bfed7138d87","unresolved":false,"context_lines":[{"line_number":447,"context_line":".. [8] ironic-oneview-cli - https://pypi.python.org/pypi/ironic-oneview-cli/"},{"line_number":448,"context_line":".. [9] ironic-inspector - https://docs.openstack.org/ironic-inspector/latest/"},{"line_number":449,"context_line":".. [10] ironic-inspector install - https://docs.openstack.org/ironic-inspector/latest/install/index.html"},{"line_number":450,"context_line":".. [11] OneView ML2 Driver - https://pypi.python.org/pypi/networking-oneview/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_352bfe82","line":450,"range":{"start_line":450,"start_character":57,"end_line":450,"end_character":77},"updated":"2017-10-06 07:14:39.000000000","message":"This needs to be added to driver-requirements.txt","commit_id":"215888a9e43e96614f54ce8770009040ddb96060"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  - ``server_hardware_uri``: URI of the ``Server Hardware`` on OneView."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin networking-oneview version \u003e\u003d 0.3.0 [11]_"},{"line_number":349,"context_line":"     to perform these validations on the ironic node port configuration to maintain"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f4e5783_4eb7993b","line":346,"range":{"start_line":346,"start_character":67,"end_line":346,"end_character":79},"updated":"2017-10-17 13:47:56.000000000","message":"Should we have this since we have mentioned its a boolean value?","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  - ``server_hardware_uri``: URI of the ``Server Hardware`` on OneView."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin networking-oneview version \u003e\u003d 0.3.0 [11]_"},{"line_number":349,"context_line":"     to perform these validations on the ironic node port configuration to maintain"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f4e5783_71d8faed","line":346,"range":{"start_line":346,"start_character":67,"end_line":346,"end_character":79},"in_reply_to":"5f4e5783_4eb7993b","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin networking-oneview version \u003e\u003d 0.3.0 [11]_"},{"line_number":349,"context_line":"     to perform these validations on the ironic node port configuration to maintain"},{"line_number":350,"context_line":"     consistency with OneView."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"* In ``properties/capabilities``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f4e5783_ce3f0985","line":349,"range":{"start_line":348,"start_character":78,"end_line":349,"end_character":5},"updated":"2017-10-17 13:47:56.000000000","message":"s/[11]_ to perform/[11]_ . The plugin performs/","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"  - ``use_oneview_ml2_driver``: Boolean value to enable or disable (True/False)"},{"line_number":347,"context_line":"     extra validations for the given node. If this parameter is set, the driver"},{"line_number":348,"context_line":"     will consider the use of plugin networking-oneview version \u003e\u003d 0.3.0 [11]_"},{"line_number":349,"context_line":"     to perform these validations on the ironic node port configuration to maintain"},{"line_number":350,"context_line":"     consistency with OneView."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"* In ``properties/capabilities``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f4e5783_51e3bea4","line":349,"range":{"start_line":348,"start_character":78,"end_line":349,"end_character":5},"in_reply_to":"5f4e5783_ce3f0985","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"}],"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1534f2b296e31227f12fc96174473fc8db05c6f","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    return oneview_info"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"def validate_oneview_connection(oneview_client, task):"},{"line_number":233,"context_line":"    \"\"\"Validate if the node port configuration is consistent with OneView."},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_0d43c043","line":231,"updated":"2017-10-03 07:00:28.000000000","message":"Frankly it looks that this atleast needs a RFE and RFE needs to have much more details than what is present in the bug currently.","commit_id":"9564e2b5bc11c271ccbe2441bd967dd4a5aa454a"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"aa2830cd9e68ad6506c78889cf2fd34bc27c7196","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    return oneview_info"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"def validate_oneview_connection(oneview_client, task):"},{"line_number":233,"context_line":"    \"\"\"Validate if the node port configuration is consistent with OneView."},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_5c94c836","line":231,"in_reply_to":"7f515b1d_0d43c043","updated":"2017-10-03 11:47:13.000000000","message":"You\u0027re right, I\u0027ll update the bug.","commit_id":"9564e2b5bc11c271ccbe2441bd967dd4a5aa454a"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from oslo_serialization import jsonutils"},{"line_number":18,"context_line":"from oslo_utils import importutils"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"from six.moves.urllib import parse"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_2e67bdb9","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":10},"updated":"2017-10-17 13:47:56.000000000","message":"move this import to the top","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from oslo_serialization import jsonutils"},{"line_number":18,"context_line":"from oslo_utils import importutils"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"from six.moves.urllib import parse"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_b1eb1276","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":10},"in_reply_to":"5f4e5783_2e67bdb9","updated":"2017-10-17 18:03:26.000000000","message":"This is the correct order, it must be in alphabetical order.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":44,"context_line":"    \u0027server_hardware_uri\u0027: _(\"Server Hardware URI. Required in driver_info.\"),"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_11a426b9","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":23},"updated":"2017-10-17 13:47:56.000000000","message":"should we add the new `use_oneview_ml2_driver` flag here?","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":40,"context_line":"client_exception \u003d importutils.try_import(\u0027hpOneView.exceptions\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":44,"context_line":"    \u0027server_hardware_uri\u0027: _(\"Server Hardware URI. Required in driver_info.\"),"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_f4a058f6","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":23},"in_reply_to":"5f4e5783_11a426b9","updated":"2017-10-17 18:03:26.000000000","message":"Done. Maybe we forgot to add `applied_server_profile_uri` too.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"5d20dc4e88d197da808a13318194288c764f9903","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    This method calls hpOneView client functions to validate if the node"},{"line_number":235,"context_line":"    port configuration is consistent with the OneView resources it represents."},{"line_number":236,"context_line":"    Also checks if the node is enabled with the OneView ML2 Driver to perform"},{"line_number":237,"context_line":"    extra validations. These validation is called only in the deploy interface."},{"line_number":238,"context_line":"    If any validation fails, the driver will raise an appropriate OneViewError."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    :param oneview_client: an instance of the OneView client"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_0ed64129","line":237,"range":{"start_line":237,"start_character":29,"end_line":237,"end_character":42},"updated":"2017-10-17 13:39:08.000000000","message":"nit: validations are","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    This method calls hpOneView client functions to validate if the node"},{"line_number":235,"context_line":"    port configuration is consistent with the OneView resources it represents."},{"line_number":236,"context_line":"    Also checks if the node is enabled with the OneView ML2 Driver to perform"},{"line_number":237,"context_line":"    extra validations. These validation is called only in the deploy interface."},{"line_number":238,"context_line":"    If any validation fails, the driver will raise an appropriate OneViewError."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    :param oneview_client: an instance of the OneView client"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_f42df894","line":237,"range":{"start_line":237,"start_character":29,"end_line":237,"end_character":42},"in_reply_to":"5f4e5783_0ed64129","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"5d20dc4e88d197da808a13318194288c764f9903","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        raise exception.OneViewError(message)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"def validate_connections(oneview_client, ports, oneview_info):"},{"line_number":520,"context_line":"    \"\"\"Validate all ports to OneView node."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    :param: oneview_client: the HP OneView Client"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_6ea01591","line":519,"range":{"start_line":519,"start_character":4,"end_line":519,"end_character":24},"updated":"2017-10-17 13:39:08.000000000","message":"Do we need this method? Could we move its body to validate_oneview_connection?","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        raise exception.OneViewError(message)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"def validate_connections(oneview_client, ports, oneview_info):"},{"line_number":520,"context_line":"    \"\"\"Validate all ports to OneView node."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    :param: oneview_client: the HP OneView Client"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_949a44b6","line":519,"range":{"start_line":519,"start_character":4,"end_line":519,"end_character":24},"in_reply_to":"5f4e5783_6ea01591","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            oneview_client, oneview_info)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"def _validate_node_port_mac_server_hardware(oneview_client,"},{"line_number":540,"context_line":"                                            oneview_info, ports):"},{"line_number":541,"context_line":"    \"\"\"Validate if a port matches the node\u0027s Server Hardware\u0027s MAC."},{"line_number":542,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_b15b12f4","line":539,"range":{"start_line":539,"start_character":4,"end_line":539,"end_character":43},"updated":"2017-10-17 13:47:56.000000000","message":"I think we should add a log in all validate_* methods to helping us to debugging, saying which validations are being performed. What you folks think?","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            oneview_client, oneview_info)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"def _validate_node_port_mac_server_hardware(oneview_client,"},{"line_number":540,"context_line":"                                            oneview_info, ports):"},{"line_number":541,"context_line":"    \"\"\"Validate if a port matches the node\u0027s Server Hardware\u0027s MAC."},{"line_number":542,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_d4331c61","line":539,"range":{"start_line":539,"start_character":4,"end_line":539,"end_character":43},"in_reply_to":"5f4e5783_b15b12f4","updated":"2017-10-17 18:03:26.000000000","message":"It\u0027s not a valuable information for us.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":572,"context_line":"    raise exception.OneViewError(message)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"def _validate_server_profile_template_mac_type(oneview_client, oneview_info):"},{"line_number":576,"context_line":"    \"\"\"Validate if the node\u0027s Server Profile Template\u0027s MAC type is physical."},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    :param: oneview_client: the HP OneView Client"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_b110b201","line":575,"range":{"start_line":575,"start_character":4,"end_line":575,"end_character":46},"updated":"2017-10-17 13:47:56.000000000","message":"ditto","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":572,"context_line":"    raise exception.OneViewError(message)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"def _validate_server_profile_template_mac_type(oneview_client, oneview_info):"},{"line_number":576,"context_line":"    \"\"\"Validate if the node\u0027s Server Profile Template\u0027s MAC type is physical."},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    :param: oneview_client: the HP OneView Client"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_944124ac","line":575,"range":{"start_line":575,"start_character":4,"end_line":575,"end_character":46},"in_reply_to":"5f4e5783_b110b201","updated":"2017-10-17 18:03:26.000000000","message":"ditto.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        raise exception.OneViewError(message)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"def _validate_node_and_port_server_hardware_id(oneview_info, ports):"},{"line_number":593,"context_line":"    \"\"\"Validate if the ports\u0027 Server Hardware ID are the same of node."},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    :param: oneview_info: the OneView related info in an Ironic node"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_314e0238","line":592,"range":{"start_line":592,"start_character":4,"end_line":592,"end_character":46},"updated":"2017-10-17 13:47:56.000000000","message":"ditto","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        raise exception.OneViewError(message)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"def _validate_node_and_port_server_hardware_id(oneview_info, ports):"},{"line_number":593,"context_line":"    \"\"\"Validate if the ports\u0027 Server Hardware ID are the same of node."},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    :param: oneview_info: the OneView related info in an Ironic node"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_344270ac","line":592,"range":{"start_line":592,"start_character":4,"end_line":592,"end_character":46},"in_reply_to":"5f4e5783_314e0238","updated":"2017-10-17 18:03:26.000000000","message":"ditto.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            raise exception.OneViewError(message)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"def _validate_connection_mac(oneview_client, oneview_info, ports):"},{"line_number":614,"context_line":"    \"\"\"Validate if the ports match their MAC addresses with a server hardware."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    Validate if the ports match their MAC addresses with a server hardware in"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_f1650ab6","line":613,"range":{"start_line":613,"start_character":4,"end_line":613,"end_character":28},"updated":"2017-10-17 13:47:56.000000000","message":"ditto","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            raise exception.OneViewError(message)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"def _validate_connection_mac(oneview_client, oneview_info, ports):"},{"line_number":614,"context_line":"    \"\"\"Validate if the ports match their MAC addresses with a server hardware."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    Validate if the ports match their MAC addresses with a server hardware in"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_f41978d6","line":613,"range":{"start_line":613,"start_character":4,"end_line":613,"end_character":28},"in_reply_to":"5f4e5783_f1650ab6","updated":"2017-10-17 18:03:26.000000000","message":"ditto.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"5d20dc4e88d197da808a13318194288c764f9903","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"def _get_switch_info(port):"},{"line_number":713,"context_line":"    \"\"\"Get the switch info of a Ironic node port."},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    Gets the switch_info data contained in the local link information of an"},{"line_number":716,"context_line":"    Ironic node port."}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_ee19a5d6","line":713,"range":{"start_line":713,"start_character":30,"end_line":713,"end_character":31},"updated":"2017-10-17 13:39:08.000000000","message":"nit: an","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"5d20dc4e88d197da808a13318194288c764f9903","unresolved":false,"context_lines":[{"line_number":776,"context_line":"    If the ports is a list of physical ports, the macs returned"},{"line_number":777,"context_line":"    will be physical macs, if they are virtual ports, the macs are virtual."},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    :param: oneview_ports: list of OneView ports"},{"line_number":780,"context_line":"    :returns: a list of macs"},{"line_number":781,"context_line":"    \"\"\""},{"line_number":782,"context_line":"    macs \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_ceb6e98a","line":779,"range":{"start_line":779,"start_character":12,"end_line":779,"end_character":25},"updated":"2017-10-17 13:39:08.000000000","message":"nit: ports","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"}],"ironic/tests/unit/drivers/modules/oneview/test_common.py":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                          oneview_info, [fake_port])"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    @mock.patch.object(common, \u0027get_hponeview_client\u0027, autospec\u003dTrue)"},{"line_number":500,"context_line":"    def test_validate_server_profile_template_mac_type_virtual("},{"line_number":501,"context_line":"        self, mock_hponeview"},{"line_number":502,"context_line":"    ):"},{"line_number":503,"context_line":"        oneview_client \u003d mock_hponeview()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_4e767940","line":500,"range":{"start_line":500,"start_character":8,"end_line":500,"end_character":62},"updated":"2017-10-17 13:47:56.000000000","message":"ditto","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                          oneview_info, [fake_port])"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    @mock.patch.object(common, \u0027get_hponeview_client\u0027, autospec\u003dTrue)"},{"line_number":500,"context_line":"    def test_validate_server_profile_template_mac_type_virtual("},{"line_number":501,"context_line":"        self, mock_hponeview"},{"line_number":502,"context_line":"    ):"},{"line_number":503,"context_line":"        oneview_client \u003d mock_hponeview()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_b410a001","line":500,"range":{"start_line":500,"start_character":8,"end_line":500,"end_character":62},"in_reply_to":"5f4e5783_4e767940","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                          oneview_client, oneview_info)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @mock.patch.object(common, \u0027get_hponeview_client\u0027, autospec\u003dTrue)"},{"line_number":513,"context_line":"    def test_validate_node_port_mac_server_hardware_invalid("},{"line_number":514,"context_line":"        self, mock_hponeview"},{"line_number":515,"context_line":"    ):"},{"line_number":516,"context_line":"        oneview_client \u003d mock_hponeview()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_ce826900","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":59},"updated":"2017-10-17 13:47:56.000000000","message":"s/test_validate_node_port_mac_server_hardware_invalid/test__validate_node_port_mac_server_hardware_invalid/\n\nsince the method new is not public anymore...","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                          oneview_client, oneview_info)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @mock.patch.object(common, \u0027get_hponeview_client\u0027, autospec\u003dTrue)"},{"line_number":513,"context_line":"    def test_validate_node_port_mac_server_hardware_invalid("},{"line_number":514,"context_line":"        self, mock_hponeview"},{"line_number":515,"context_line":"    ):"},{"line_number":516,"context_line":"        oneview_client \u003d mock_hponeview()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_f40a98cf","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":59},"in_reply_to":"5f4e5783_ce826900","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"}],"releasenotes/notes/add_oneview_ml2_validations-a368b0c65f99653e.yaml":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_ae84cdd3","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":73},"updated":"2017-10-17 13:47:56.000000000","message":"s/driver/plugin/?","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_9497e448","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":73},"in_reply_to":"5f4e5783_ae84cdd3","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_2ea69dac","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":35},"updated":"2017-10-17 13:47:56.000000000","message":"s/alsa/also/","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_6ec93557","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":61},"updated":"2017-10-17 13:47:56.000000000","message":"s/driver_info/`driver_info`/","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_2ea57d47","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":24},"updated":"2017-10-17 13:47:56.000000000","message":"s/of node/set to the node/?","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_f4a618c1","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":24},"in_reply_to":"5f4e5783_2ea57d47","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_d4a9dc8f","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":35},"in_reply_to":"5f4e5783_2ea69dac","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_14a414b9","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":61},"in_reply_to":"5f4e5783_6ec93557","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"313afb8932cb07965ab5a6a0c4a86cf97c46713a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_0e1761a6","line":8,"range":{"start_line":6,"start_character":26,"end_line":8,"end_character":33},"updated":"2017-10-17 13:47:56.000000000","message":"Suggestion: Adds also a new flag `use_oneview_ml2_driver` to `driver_info` for the case OneView ML2 plugin is used during the bare metal deployment.","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"23ccd720f860005de81831557ea04da75ad41f32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new validations for connection when using the OneView ML2 driver,"},{"line_number":5,"context_line":"    verifying if the Server Hardware ID and MAC addresses of the Ironic port"},{"line_number":6,"context_line":"    are the same of node. Adds alsa a new flag in driver_info of the node"},{"line_number":7,"context_line":"    `use_oneview_ml2_driver` to check if the node is using the OneView ML2"},{"line_number":8,"context_line":"    driver in the deploy process."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f4e5783_54c84c72","line":8,"range":{"start_line":6,"start_character":26,"end_line":8,"end_character":33},"in_reply_to":"5f4e5783_0e1761a6","updated":"2017-10-17 18:03:26.000000000","message":"Done","commit_id":"f7b68658b0e11c6bb8bc0c17e564c75e4e6487ec"}]}