)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b9997446f803441855938de623819cef335b8a49","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Proposing adding [H210] hacking check in tox.ini to require ‘autospec’,"},{"line_number":10,"context_line":"‘spec’, or ‘spec_set’ in mock.patch/mock.patch.object calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds missing \u0027autospec\u0027 to unit tests in /tests/unit/dhcp/."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More patches to follow to cover all the unit tests to enable [H210] in"},{"line_number":15,"context_line":"tox.ini."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_c16f7a90","line":12,"updated":"2017-10-05 02:01:24.000000000","message":"Would be good to give an explanation for why some of them are \u0027autospec\u003dFalse\u0027 in the commit message.","commit_id":"ad27ed42af9f97ed6a44a156768335ed46138d18"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"8cffc7f701b6116bec4e846d3e6f3a6bf7c7e378","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Proposing adding [H210] hacking check in tox.ini to require ‘autospec’,"},{"line_number":10,"context_line":"‘spec’, or ‘spec_set’ in mock.patch/mock.patch.object calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds missing \u0027autospec\u0027 to unit tests in /tests/unit/dhcp/."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More patches to follow to cover all the unit tests to enable [H210] in"},{"line_number":15,"context_line":"tox.ini."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_e63d6fbb","line":12,"in_reply_to":"7f515b1d_c16f7a90","updated":"2017-10-09 22:27:43.000000000","message":"Done","commit_id":"ad27ed42af9f97ed6a44a156768335ed46138d18"}],"ironic/tests/unit/dhcp/test_neutron.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b9997446f803441855938de623819cef335b8a49","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            api.provider.update_port_dhcp_opts,"},{"line_number":82,"context_line":"            port_id, opts)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts\u0027,"},{"line_number":85,"context_line":"                autospec\u003dFalse)"},{"line_number":86,"context_line":"    @mock.patch(\u0027ironic.common.network.get_node_vif_ids\u0027,"},{"line_number":87,"context_line":"                autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_61bb26e5","line":84,"updated":"2017-10-05 02:01:24.000000000","message":"Why is this False? I tried it and seemed to work. Just need to update the assertion on line 96.\n\n mock_updo.assert_called_once_with(mock.ANY, \u0027vif-uuid\u0027, opts)","commit_id":"ad27ed42af9f97ed6a44a156768335ed46138d18"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"8cffc7f701b6116bec4e846d3e6f3a6bf7c7e378","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            api.provider.update_port_dhcp_opts,"},{"line_number":82,"context_line":"            port_id, opts)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts\u0027,"},{"line_number":85,"context_line":"                autospec\u003dFalse)"},{"line_number":86,"context_line":"    @mock.patch(\u0027ironic.common.network.get_node_vif_ids\u0027,"},{"line_number":87,"context_line":"                autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_667bbf8b","line":84,"in_reply_to":"7f515b1d_61bb26e5","updated":"2017-10-09 22:27:43.000000000","message":"Thanks John. I updated the patch with mock.ANY.","commit_id":"ad27ed42af9f97ed6a44a156768335ed46138d18"}]}