)]}'
{"driver-requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The Redfish hardware type uses the Sushy library"},{"line_number":20,"context_line":"sushy"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Ansible-deploy interface"},{"line_number":23,"context_line":"ansible\u003e\u003d2.4"}],"source_content_type":"text/plain","patch_set":8,"id":"ff82abbf_233e058c","line":22,"updated":"2017-11-24 17:49:01.000000000","message":"We might want to note how ansible is licensed...\n\nI guess my other concern is not everyone may want ansible pulled in to their system if they do pip install -r driver-requirements.txt","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/conf/ansible.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6dc5609388e0870db154fb00b52cd04e4caff1dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"},{"line_number":45,"context_line":"               default\u003dos.path.join("},{"line_number":46,"context_line":"                   os.path.dirname(__file__), \u0027playbooks\u0027, \u0027ansible.cfg\u0027),"},{"line_number":47,"context_line":"               help\u003d_(\u0027Path to ansible configuration file. If set to empty, \u0027"},{"line_number":48,"context_line":"                      \u0027system default will be used.\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retries\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_dd86dd13","line":46,"updated":"2017-10-14 12:24:49.000000000","message":"this won\u0027t work, looks for file relative to conf/ dir","commit_id":"62f729ef3654ea275e31540e148adbf1f1745a6b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f2a02974c562305cb542b66ccd332c848f54409e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \u0027Provide the full path when ansible-playbook is not in \u0027"},{"line_number":43,"context_line":"                      \u0027$PATH or installed in not default location.\u0027)),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027playbooks_path\u0027,"},{"line_number":45,"context_line":"               default\u003dDEFAULT_PLAYBOOKS_PATH,"},{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_5fc4da3f","line":45,"updated":"2017-10-26 13:32:40.000000000","message":"Let\u0027s allow relative paths here, and use a relative path by default to avoid /opt/stack in ironic.conf.sample","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \u0027Provide the full path when ansible-playbook is not in \u0027"},{"line_number":43,"context_line":"                      \u0027$PATH or installed in not default location.\u0027)),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027playbooks_path\u0027,"},{"line_number":45,"context_line":"               default\u003dDEFAULT_PLAYBOOKS_PATH,"},{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_b71ab014","line":45,"in_reply_to":"3f4b6375_1a49c9b5","updated":"2017-11-09 10:41:02.000000000","message":"I\u0027ve found a magic option CONF.pybasedir in our config, that can be referenced as $pybasedir by other options. I will use it here and below, hopefully this will solve both your concerns.","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \u0027Provide the full path when ansible-playbook is not in \u0027"},{"line_number":43,"context_line":"                      \u0027$PATH or installed in not default location.\u0027)),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027playbooks_path\u0027,"},{"line_number":45,"context_line":"               default\u003dDEFAULT_PLAYBOOKS_PATH,"},{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_d9d65828","line":45,"in_reply_to":"3f4b6375_5fc4da3f","updated":"2017-10-30 17:34:10.000000000","message":"If it is only to avoid \u0027/opt/stack\u0027 in the config sample, I\u0027d rather go with what Vasyl suggests (using sample_default)","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \u0027Provide the full path when ansible-playbook is not in \u0027"},{"line_number":43,"context_line":"                      \u0027$PATH or installed in not default location.\u0027)),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027playbooks_path\u0027,"},{"line_number":45,"context_line":"               default\u003dDEFAULT_PLAYBOOKS_PATH,"},{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_1a49c9b5","line":45,"in_reply_to":"3f4b6375_5fc4da3f","updated":"2017-10-26 19:42:32.000000000","message":"lets add sample_default here, to make sure value is the same on different host \n\nhttps://github.com/openstack/ironic/blob/92047176ca355589ab71dd58ff93c100d89deb7c/ironic/conf/default.py#L220","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               default\u003dDEFAULT_PLAYBOOKS_PATH,"},{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"},{"line_number":49,"context_line":"               default\u003dos.path.join(DEFAULT_PLAYBOOKS_PATH, \u0027ansible.cfg\u0027),"},{"line_number":50,"context_line":"               help\u003d_(\u0027Path to ansible configuration file. If set to empty, \u0027"},{"line_number":51,"context_line":"                      \u0027system default will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_fac94d25","line":48,"updated":"2017-10-26 19:42:32.000000000","message":"ditto","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               default\u003dDEFAULT_PLAYBOOKS_PATH,"},{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"},{"line_number":49,"context_line":"               default\u003dos.path.join(DEFAULT_PLAYBOOKS_PATH, \u0027ansible.cfg\u0027),"},{"line_number":50,"context_line":"               help\u003d_(\u0027Path to ansible configuration file. If set to empty, \u0027"},{"line_number":51,"context_line":"                      \u0027system default will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_37dc8045","line":48,"in_reply_to":"3f4b6375_fac94d25","updated":"2017-11-09 10:41:02.000000000","message":"Done","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f2a02974c562305cb542b66ccd332c848f54409e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"},{"line_number":49,"context_line":"               default\u003dos.path.join(DEFAULT_PLAYBOOKS_PATH, \u0027ansible.cfg\u0027),"},{"line_number":50,"context_line":"               help\u003d_(\u0027Path to ansible configuration file. If set to empty, \u0027"},{"line_number":51,"context_line":"                      \u0027system default will be used.\u0027)),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retries\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_3fbfdeaa","line":49,"updated":"2017-10-26 13:32:40.000000000","message":"ditto","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               help\u003d_(\u0027Path to directory with playbooks, roles and \u0027"},{"line_number":47,"context_line":"                      \u0027local inventory.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027config_file_path\u0027,"},{"line_number":49,"context_line":"               default\u003dos.path.join(DEFAULT_PLAYBOOKS_PATH, \u0027ansible.cfg\u0027),"},{"line_number":50,"context_line":"               help\u003d_(\u0027Path to ansible configuration file. If set to empty, \u0027"},{"line_number":51,"context_line":"                      \u0027system default will be used.\u0027)),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retries\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_d7e2cc01","line":49,"in_reply_to":"3f4b6375_3fbfdeaa","updated":"2017-11-09 10:41:02.000000000","message":"Done","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d6,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Number of times to retry getting power state to check \u0027"},{"line_number":56,"context_line":"                      \u0027if bare metal node has been powered off after a soft \u0027"},{"line_number":57,"context_line":"                      \u0027power off.\u0027)),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retry_interval\u0027,"},{"line_number":59,"context_line":"               min\u003d0,"},{"line_number":60,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_9ad259d0","line":57,"updated":"2017-10-26 19:42:32.000000000","message":"0 is unlimited?","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d6,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Number of times to retry getting power state to check \u0027"},{"line_number":56,"context_line":"                      \u0027if bare metal node has been powered off after a soft \u0027"},{"line_number":57,"context_line":"                      \u0027power off.\u0027)),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retry_interval\u0027,"},{"line_number":59,"context_line":"               min\u003d0,"},{"line_number":60,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_4c8e532f","line":57,"in_reply_to":"3f4b6375_1a0e1fe5","updated":"2017-11-09 10:41:02.000000000","message":"Done","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d6,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Number of times to retry getting power state to check \u0027"},{"line_number":56,"context_line":"                      \u0027if bare metal node has been powered off after a soft \u0027"},{"line_number":57,"context_line":"                      \u0027power off.\u0027)),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retry_interval\u0027,"},{"line_number":59,"context_line":"               min\u003d0,"},{"line_number":60,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_b49de10b","line":57,"in_reply_to":"3f4b6375_9ad259d0","updated":"2017-10-30 17:34:10.000000000","message":"nope, in fact as I tested the \"retrying.retry\", the 0 and 1 seems to be equal in behavior (executing the code once), so I\u0027ll change the min to 1\n\nwe might in fact have some semantic wording problem here though (and in the rest of ironic in [agent] section), as the name of the option should rather be \"*_attempts\" then \u0027*_retries\". Value of 1 means it will \"try\" one time, not that it will *re-try* one time after first failure. But at least the help string is correct...","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4de43b8e09ac71d6ee2fad4720bab3d1faec302d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               default\u003d6,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Number of times to retry getting power state to check \u0027"},{"line_number":56,"context_line":"                      \u0027if bare metal node has been powered off after a soft \u0027"},{"line_number":57,"context_line":"                      \u0027power off.\u0027)),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027post_deploy_get_power_state_retry_interval\u0027,"},{"line_number":59,"context_line":"               min\u003d0,"},{"line_number":60,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_1a0e1fe5","line":57,"in_reply_to":"3f4b6375_b49de10b","updated":"2017-10-30 17:39:17.000000000","message":"strike the previous comment, we do +\u003d1 in the code, so this is really a number of re-tries. in this context 0 means \"do not retry, fail after first unsuccessful attempt\".\n\nwill add to the description to avoid confusion.","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027to image store. \u0027"},{"line_number":86,"context_line":"                      \u0027Is not used by default playbooks included with \u0027"},{"line_number":87,"context_line":"                      \u0027the driver. \u0027"},{"line_number":88,"context_line":"                      \u0027Can be used in custom playbooks and Ansible\u003e\u003d2.4.\u0027)),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027image_store_keyfile\u0027,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Client key to use for SSL connections \u0027"},{"line_number":91,"context_line":"                      \u0027to image store. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_9aeb7976","line":88,"updated":"2017-10-26 19:42:32.000000000","message":"no need to mention it here, in driver requiremen 2.4 is minimal required version","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027to image store. \u0027"},{"line_number":86,"context_line":"                      \u0027Is not used by default playbooks included with \u0027"},{"line_number":87,"context_line":"                      \u0027the driver. \u0027"},{"line_number":88,"context_line":"                      \u0027Can be used in custom playbooks and Ansible\u003e\u003d2.4.\u0027)),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027image_store_keyfile\u0027,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Client key to use for SSL connections \u0027"},{"line_number":91,"context_line":"                      \u0027to image store. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_2c831707","line":88,"in_reply_to":"3f4b6375_9aeb7976","updated":"2017-11-09 10:41:02.000000000","message":"Done","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027to image store. \u0027"},{"line_number":86,"context_line":"                      \u0027Is not used by default playbooks included with \u0027"},{"line_number":87,"context_line":"                      \u0027the driver. \u0027"},{"line_number":88,"context_line":"                      \u0027Can be used in custom playbooks and Ansible\u003e\u003d2.4.\u0027)),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027image_store_keyfile\u0027,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Client key to use for SSL connections \u0027"},{"line_number":91,"context_line":"                      \u0027to image store. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_e398451c","line":88,"in_reply_to":"3f4b6375_9aeb7976","updated":"2017-10-30 17:34:10.000000000","message":"will fix","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                      \u0027to image store. \u0027"},{"line_number":92,"context_line":"                      \u0027Is not used by default playbooks included with \u0027"},{"line_number":93,"context_line":"                      \u0027the driver. \u0027"},{"line_number":94,"context_line":"                      \u0027Can be used in custom playbooks and Ansible\u003e\u003d2.4.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_7a067d54","line":94,"updated":"2017-10-26 19:42:32.000000000","message":"ditto","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                      \u0027to image store. \u0027"},{"line_number":92,"context_line":"                      \u0027Is not used by default playbooks included with \u0027"},{"line_number":93,"context_line":"                      \u0027the driver. \u0027"},{"line_number":94,"context_line":"                      \u0027Can be used in custom playbooks and Ansible\u003e\u003d2.4.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f485f77_0c885b1d","line":94,"in_reply_to":"3f4b6375_7a067d54","updated":"2017-11-09 10:41:02.000000000","message":"Done","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                      \u0027to image store. \u0027"},{"line_number":92,"context_line":"                      \u0027Is not used by default playbooks included with \u0027"},{"line_number":93,"context_line":"                      \u0027the driver. \u0027"},{"line_number":94,"context_line":"                      \u0027Can be used in custom playbooks and Ansible\u003e\u003d2.4.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_439159f1","line":94,"in_reply_to":"3f4b6375_7a067d54","updated":"2017-10-30 17:34:10.000000000","message":"will fix","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"}],"ironic/drivers/ipmi.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dc5aacfaeb5ca7e8d42dbe3f281d771270db10bd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @property"},{"line_number":38,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":39,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":40,"context_line":"        return super(IPMIHardware, self).supported_deploy_interfaces + ["},{"line_number":41,"context_line":"            ansible_deploy.AnsibleDeploy]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @property"},{"line_number":44,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_fcb96878","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":41},"updated":"2017-10-17 09:18:48.000000000","message":"please move this change to GenericHardware","commit_id":"174257ed50cc8034c746577e50578b4d197d8d99"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b080d5810ee6a29d920bfb602755cd0ca5c159a3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @property"},{"line_number":38,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":39,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":40,"context_line":"        return super(IPMIHardware, self).supported_deploy_interfaces + ["},{"line_number":41,"context_line":"            ansible_deploy.AnsibleDeploy]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @property"},{"line_number":44,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_7517cba5","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":41},"in_reply_to":"5f4e5783_fcb96878","updated":"2017-10-17 11:28:04.000000000","message":"Done","commit_id":"174257ed50cc8034c746577e50578b4d197d8d99"}],"ironic/drivers/modules/ansible/deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f2a02974c562305cb542b66ccd332c848f54409e","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def _run_playbook(name, extra_vars, key, tags\u003dNone, notags\u003dNone):"},{"line_number":123,"context_line":"    \"\"\"Execute ansible-playbook.\"\"\""},{"line_number":124,"context_line":"    playbook \u003d os.path.join(CONF.ansible.playbooks_path, name)"},{"line_number":125,"context_line":"    ironic_vars \u003d {\u0027ironic\u0027: extra_vars}"},{"line_number":126,"context_line":"    args \u003d [CONF.ansible.ansible_playbook_script, playbook,"},{"line_number":127,"context_line":"            \u0027-i\u0027, INVENTORY_FILE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_7fc9d656","line":124,"updated":"2017-10-26 13:32:40.000000000","message":"mmm, let\u0027s maybe allow also absolute paths here?","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def _run_playbook(name, extra_vars, key, tags\u003dNone, notags\u003dNone):"},{"line_number":123,"context_line":"    \"\"\"Execute ansible-playbook.\"\"\""},{"line_number":124,"context_line":"    playbook \u003d os.path.join(CONF.ansible.playbooks_path, name)"},{"line_number":125,"context_line":"    ironic_vars \u003d {\u0027ironic\u0027: extra_vars}"},{"line_number":126,"context_line":"    args \u003d [CONF.ansible.ansible_playbook_script, playbook,"},{"line_number":127,"context_line":"            \u0027-i\u0027, INVENTORY_FILE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_e34f2590","line":124,"in_reply_to":"3f4b6375_7fc9d656","updated":"2017-10-30 17:34:10.000000000","message":"os.path.join will already do this when the last path is absolute:\n\n  \u003e\u003e\u003e os.path.join(\u0027/opt/stack/ironic\u0027, \u0027etc/ironic/ironic.conf\u0027)\n  \u0027/opt/stack/ironic/etc/ironic/ironic.conf\u0027\n\n  \u003e\u003e\u003e os.path.join(\u0027/opt/stack/ironic\u0027, \u0027/etc/ironic/ironic.conf\u0027)\n  \u0027/etc/ironic/ironic.conf\u0027\n\nI may add more description to the node \"ansible_*_playbook\"s properties to note that absolute paths are taken as-is and relative are relative to a configured folder","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def _get_configdrive_path(basename):"},{"line_number":104,"context_line":"    return os.path.join(CONF.tempdir, basename + \u0027.cndrive\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def _get_node_ip(task):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_23da854b","line":104,"updated":"2017-11-24 17:49:01.000000000","message":"Nit: shouldn\u0027t we use a longer file extension?  Not sure it really matters though.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b3fc86042aa59cf7acd3016be289d89fa4749570","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def _get_configdrive_path(basename):"},{"line_number":104,"context_line":"    return os.path.join(CONF.tempdir, basename + \u0027.cndrive\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def _get_node_ip(task):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_28cecb81","line":104,"in_reply_to":"ff82abbf_23da854b","updated":"2017-11-27 15:49:44.000000000","message":"not sure, what do you thinks can clash here? we use node\u0027s uuid as basename, and that should be unique","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    def prepare(self, task):"},{"line_number":440,"context_line":"        \"\"\"Prepare the deployment environment for this node.\"\"\""},{"line_number":441,"context_line":"        node \u003d task.node"},{"line_number":442,"context_line":"        # TODO(pas-ha) investigate takeover scenario"},{"line_number":443,"context_line":"        if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":444,"context_line":"            # adding network-driver dependent provisioning ports"},{"line_number":445,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_23a8458b","line":442,"updated":"2017-11-24 17:49:01.000000000","message":"I think you might be covered in mid-deployment conductor failover if you just update the conditional below to include  DEPLOY_WAIT as well, although maybe skipping powering off the node?","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/drivers/modules/ansible/playbooks/ansible.cfg":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# this is using supplied callback_plugin to interleave ansible event logs"},{"line_number":6,"context_line":"# into Ironic-conductor log as set in ironic configuration file,"},{"line_number":7,"context_line":"# see callback_plugin/ironic_log.ini for some options to set"},{"line_number":8,"context_line":"# (DevStack _needs_ some tweaks)"},{"line_number":9,"context_line":"callback_whitelist \u003d ironic_log"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# For better security, bake SSH host keys into bootstrap image,"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"ff82abbf_43d8e91c","line":8,"updated":"2017-11-24 17:49:01.000000000","message":"Is this explicitly documented? If so, we should likely point to it from here.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b3fc86042aa59cf7acd3016be289d89fa4749570","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# this is using supplied callback_plugin to interleave ansible event logs"},{"line_number":6,"context_line":"# into Ironic-conductor log as set in ironic configuration file,"},{"line_number":7,"context_line":"# see callback_plugin/ironic_log.ini for some options to set"},{"line_number":8,"context_line":"# (DevStack _needs_ some tweaks)"},{"line_number":9,"context_line":"callback_whitelist \u003d ironic_log"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# For better security, bake SSH host keys into bootstrap image,"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"ff82abbf_e81543e6","line":8,"in_reply_to":"ff82abbf_43d8e91c","updated":"2017-11-27 15:49:44.000000000","message":"actually already with the default devstack setup that uses systemd/journald, not tweaks should be needed.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# and set the host_key_checking to True (or comment it out, it is the default)"},{"line_number":15,"context_line":"host_key_checking \u003d False"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# uncomment if you have problem with ramdisk locale on ansible \u003e\u003d 2.1"},{"line_number":18,"context_line":"#module_set_locale\u003dFalse"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# This sets the interval (in seconds) of Ansible internal processes polling"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"ff82abbf_63d5ede4","line":17,"range":{"start_line":17,"start_character":66,"end_line":17,"end_character":69},"updated":"2017-11-24 17:49:01.000000000","message":"nit: might be worth revising this note, since we say 2.4 is the minimum.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# pipelining greatly increases speed of deployment, disable it only when"},{"line_number":30,"context_line":"# your version of ssh client on ironic node or server in bootstrap image"},{"line_number":31,"context_line":"# do not support it or if you can not disable \"requiretty\" for the"},{"line_number":32,"context_line":"# passwordless sudoer user in the bootstrap image."},{"line_number":33,"context_line":"# See Ansible documentation for more info:"},{"line_number":34,"context_line":"# http://docs.ansible.com/ansible/intro_configuration.html#pipelining"},{"line_number":35,"context_line":"pipelining \u003d True"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"ff82abbf_23328560","line":32,"range":{"start_line":32,"start_character":1,"end_line":32,"end_character":14},"updated":"2017-11-24 17:49:01.000000000","message":"nit: password-less\nnit: sudo as I believe your talking about the user, not the sudoers file.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/drivers/modules/ansible/playbooks/callback_plugins/ironic_log.ini":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#config_file \u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Force usage of journald"},{"line_number":7,"context_line":"# use_journal \u003d True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Force usage of syslog"},{"line_number":10,"context_line":"#use_syslog \u003d False"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3f4b6375_5574b2ce","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":2},"updated":"2017-10-26 19:42:32.000000000","message":"extra space","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c5815a0f3f8f067f60d363469d3e38026cd025e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#config_file \u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Force usage of journald"},{"line_number":7,"context_line":"# use_journal \u003d True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Force usage of syslog"},{"line_number":10,"context_line":"#use_syslog \u003d False"}],"source_content_type":"text/x-properties","patch_set":7,"id":"1f485f77_ecce1f82","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":2},"in_reply_to":"3f4b6375_5574b2ce","updated":"2017-11-09 10:41:02.000000000","message":"Done","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#config_file \u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Force usage of journald"},{"line_number":7,"context_line":"# use_journal \u003d True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Force usage of syslog"},{"line_number":10,"context_line":"#use_syslog \u003d False"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3f4b6375_4375d9f9","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":2},"in_reply_to":"3f4b6375_5574b2ce","updated":"2017-10-30 17:34:10.000000000","message":"will fix :)","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"}],"ironic/drivers/modules/ansible/playbooks/library/root_hints.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    if not devices_wwn:"},{"line_number":77,"context_line":"        extra \u003d set(hints) \u0026 EXTRA_PARAMS"},{"line_number":78,"context_line":"        if extra:"},{"line_number":79,"context_line":"            module.fail_json(msg\u003d\u0027Extra hints (supported by additional ansible\u0027"},{"line_number":80,"context_line":"                             \u0027 module) are set but this information can not be\u0027"},{"line_number":81,"context_line":"                             \u0027 collected. Extra hints: %s\u0027 % \u0027, \u0027.join(extra))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_c39cf90f","line":79,"range":{"start_line":79,"start_character":59,"end_line":79,"end_character":60},"updated":"2017-11-24 17:49:01.000000000","message":"nit: s/additional/an additional/","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        extra \u003d set(hints) \u0026 EXTRA_PARAMS"},{"line_number":78,"context_line":"        if extra:"},{"line_number":79,"context_line":"            module.fail_json(msg\u003d\u0027Extra hints (supported by additional ansible\u0027"},{"line_number":80,"context_line":"                             \u0027 module) are set but this information can not be\u0027"},{"line_number":81,"context_line":"                             \u0027 collected. Extra hints: %s\u0027 % \u0027, \u0027.join(extra))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    devices_info \u003d merge_devices_info(devices, devices_wwn or {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_e3a1fd47","line":80,"range":{"start_line":80,"start_character":31,"end_line":80,"end_character":38},"updated":"2017-11-24 17:49:01.000000000","message":"Nit: Reading this I\u0027m wondering what module it is actually referring to, perhaps it might be good to revise this text later on to reference the ?missing? module?","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b3fc86042aa59cf7acd3016be289d89fa4749570","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        extra \u003d set(hints) \u0026 EXTRA_PARAMS"},{"line_number":78,"context_line":"        if extra:"},{"line_number":79,"context_line":"            module.fail_json(msg\u003d\u0027Extra hints (supported by additional ansible\u0027"},{"line_number":80,"context_line":"                             \u0027 module) are set but this information can not be\u0027"},{"line_number":81,"context_line":"                             \u0027 collected. Extra hints: %s\u0027 % \u0027, \u0027.join(extra))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    devices_info \u003d merge_devices_info(devices, devices_wwn or {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_28f7abd5","line":80,"range":{"start_line":80,"start_character":31,"end_line":80,"end_character":38},"in_reply_to":"ff82abbf_e3a1fd47","updated":"2017-11-27 15:49:44.000000000","message":"this is referring to \u0027facts_wwn\u0027 module, bundled here. will change","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/drivers/modules/ansible/playbooks/roles/clean/tasks/shred.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: clean block devices"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  command: shred -f -z /dev/{{ item.key }}"},{"line_number":4,"context_line":"  async: 3600"},{"line_number":5,"context_line":"  poll: 30"},{"line_number":6,"context_line":"  with_dict: \"{{ ansible_devices }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_43fb0946","line":3,"updated":"2017-11-24 17:49:01.000000000","message":"Nit: It might be worth putting a note in the yaml file explicitly detailing what the shred flags that are being called do.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b3fc86042aa59cf7acd3016be289d89fa4749570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: clean block devices"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  command: shred -f -z /dev/{{ item.key }}"},{"line_number":4,"context_line":"  async: 3600"},{"line_number":5,"context_line":"  poll: 30"},{"line_number":6,"context_line":"  with_dict: \"{{ ansible_devices }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_e84ea336","line":3,"in_reply_to":"ff82abbf_43fb0946","updated":"2017-11-27 15:49:44.000000000","message":"will do","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/drivers/modules/ansible/playbooks/roles/deploy/tasks/configdrive.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: write configdrive"},{"line_number":43,"context_line":"  become: yes"},{"line_number":44,"context_line":"  command: dd if\u003d/tmp/{{ inventory_hostname }}.cndrive of\u003d{{ ironic_configdrive_target }} bs\u003d64K oflag\u003ddirect"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_1e8b1a6e","line":44,"updated":"2017-11-24 17:49:01.000000000","message":"\\o/ for O_DIRECT use... except we still need to issue a sync.\n\nSome raid controllers will still buffer the data stream in the controller RAM and perform a lazy write, and with our 5 second wait and power-off immediately following... we could end up with a partially written config drive. An alternative may be to try and wait upwards of 15 seconds, model dependent of course.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3554675bcc10c3241b045f58b43526e04e5ac6ac","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: write configdrive"},{"line_number":43,"context_line":"  become: yes"},{"line_number":44,"context_line":"  command: dd if\u003d/tmp/{{ inventory_hostname }}.cndrive of\u003d{{ ironic_configdrive_target }} bs\u003d64K oflag\u003ddirect"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_ebc9ba58","line":44,"in_reply_to":"ff82abbf_084c2740","updated":"2017-11-27 15:55:14.000000000","message":"Agreed, I kind of still wish it was visibly here, but *shrugs*","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b3fc86042aa59cf7acd3016be289d89fa4749570","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: write configdrive"},{"line_number":43,"context_line":"  become: yes"},{"line_number":44,"context_line":"  command: dd if\u003d/tmp/{{ inventory_hostname }}.cndrive of\u003d{{ ironic_configdrive_target }} bs\u003d64K oflag\u003ddirect"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_084c2740","line":44,"in_reply_to":"ff82abbf_1e8b1a6e","updated":"2017-11-27 15:49:44.000000000","message":"the explicit \u0027sync\u0027 is a post_task in the \u0027deploy.yaml\u0027 playbook, so I think we are covered.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/drivers/modules/ansible/playbooks/roles/deploy/tasks/write.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  command: qemu-img convert -t directsync -O host_device /tmp/{{ inventory_hostname }}.img {{ ironic_image_target }}"},{"line_number":4,"context_line":"  async: 1200"},{"line_number":5,"context_line":"  poll: 10"},{"line_number":6,"context_line":"  when: ironic.image.disk_format !\u003d \u0027raw\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: stream to target"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_87a32100","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":10},"updated":"2017-10-26 19:42:32.000000000","message":"this is to often","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  command: qemu-img convert -t directsync -O host_device /tmp/{{ inventory_hostname }}.img {{ ironic_image_target }}"},{"line_number":4,"context_line":"  async: 1200"},{"line_number":5,"context_line":"  poll: 10"},{"line_number":6,"context_line":"  when: ironic.image.disk_format !\u003d \u0027raw\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: stream to target"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_c381c9c5","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":10},"in_reply_to":"3f4b6375_87a32100","updated":"2017-10-30 17:34:10.000000000","message":"well, this will effectively become a minimal time this task is taking to complete. what value do you suggest?","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"}],"ironic/drivers/modules/ansible/playbooks/roles/prepare/tasks/parted.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# this is to handle no autocleaning in ironic"},{"line_number":2,"context_line":"- name: erase partition table"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: dd if\u003d/dev/zero of\u003d{{ ironic_root_device }} bs\u003d512 count\u003d36"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_fe00b603","line":1,"updated":"2017-11-24 17:49:01.000000000","message":"Is this bug worthy?","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b3fc86042aa59cf7acd3016be289d89fa4749570","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# this is to handle no autocleaning in ironic"},{"line_number":2,"context_line":"- name: erase partition table"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  command: dd if\u003d/dev/zero of\u003d{{ ironic_root_device }} bs\u003d512 count\u003d36"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_e8b9c314","line":1,"in_reply_to":"ff82abbf_fe00b603","updated":"2017-11-27 15:49:44.000000000","message":"not really. This is effectively a poor man cleaning, for the case when autocleaning is explicitly disabled in ironic config, I\u0027ll try to reword the comment to make it clear\n\nAFAIU IPA does more or less that too - https://github.com/openstack/ironic-lib/blob/27282521db0519a5b45cd153cfe6d1c9b1525791/ironic_lib/disk_utils.py#L483","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}],"ironic/drivers/modules/ansible/playbooks/roles/shutdown/tasks/main.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"52d10a23f9030ca76dc163b6f5c685b3e90c99c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: soft power off"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  shell: sleep 5 \u0026\u0026 poweroff"},{"line_number":4,"context_line":"  async: 1"},{"line_number":5,"context_line":"  poll: 0"},{"line_number":6,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_27ac6deb","line":3,"updated":"2017-10-26 19:42:32.000000000","message":"why need a sleep here?","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4d60275498b80ac3f0238862450e5e5e1e90aba5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: soft power off"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  shell: sleep 5 \u0026\u0026 poweroff"},{"line_number":4,"context_line":"  async: 1"},{"line_number":5,"context_line":"  poll: 0"},{"line_number":6,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_8d16f448","line":3,"in_reply_to":"3f4b6375_031361ba","updated":"2017-11-02 17:38:20.000000000","message":"apparently the sleep is still needed, otherwise \u0027poweroff\u0027 closes SSH connection so fast that Ansible does not close it itself and counts it as an error which actually even \u0027ignore_errors\u0027 would not catch.\n\nOTOH I can remove the \u0027ignore_error\u0027 (let it fail faster if for some reason we could not even start this command and let it be handled by oob poweroff in conductor),\nand add a comment describing what this sleep is for\n\nBTW, on a more complete OS (like ubuntu) one could do\n\n  command: shutdown +1\n\nw/o sleeps (but that would make it wait for 1 minute instead of seconds),\nand specifically on tinycore one can do\n\n  command: poweroff -d 1\n\nto delay powering off by 1 second.\n\nUnfortunately on non-busybox systems \u0027-d\u0027 means different thing (not a delay), so using sleep is a more universal approach.","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"25ac5bb6376b10d038ccf64b3879b587e9a956e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: soft power off"},{"line_number":2,"context_line":"  become: yes"},{"line_number":3,"context_line":"  shell: sleep 5 \u0026\u0026 poweroff"},{"line_number":4,"context_line":"  async: 1"},{"line_number":5,"context_line":"  poll: 0"},{"line_number":6,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_031361ba","line":3,"in_reply_to":"3f4b6375_27ac6deb","updated":"2017-10-30 17:34:10.000000000","message":"I think we don\u0027t need it any more, as we ignore the error from this task any way, and use it in the context checking out-of-band if the power went off\n\nwill test and try to simplify","commit_id":"0a0aaba8f247c7104b85539fd66a4c6ba1222566"}],"releasenotes/notes/ansible-deploy-15da234580ca0c30.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bea8fdd2ea1b88f59fe2796a24e769e6f2584e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new ``ansible`` deploy interface. It targets mostly undercloud"},{"line_number":5,"context_line":"    use-case by allowing greater customization of provisioning process."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    This new deploy interface is usable only with hardware types."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_feeaf60c","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":73},"updated":"2017-11-24 17:49:01.000000000","message":"nit: I\u0027d prefer that we avoid the expression \"undercloud\", because the actual target is more customized deploy than what is generally provided for.","commit_id":"9b1a7ceb4b32089ccec2e9aca530699ae5e7cedb"}]}
