)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a8e45d89e262dbd8026cdc7bb857e53e8af7f9ce","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"    @periodics.periodic("},{"line_number":1531,"context_line":"        spacing\u003dCONF.conductor.sync_local_state_interval)"},{"line_number":1532,"context_line":"    def _sync_console_node_deleted(self):"},{"line_number":1533,"context_line":"        \"\"\"When node is deleted, stop console process on the all conductors\"\"\""},{"line_number":1534,"context_line":"        # get all node in DB."},{"line_number":1535,"context_line":"        node_in_db \u003d self.dbapi.get_nodeinfo_list(columns\u003d[\u0027uuid\u0027])"},{"line_number":1536,"context_line":"        node_list \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_37cac96c","line":1533,"updated":"2017-10-13 10:34:41.000000000","message":"We already stop console when delete a node please have look https://github.com/openstack/ironic/blob/f16e7cdf41701159704697775c436e9b7ffc0013/ironic/conductor/manager.py#L1632","commit_id":"9dfde79603937a2ffdb936ecdefd1510c41c1821"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"4515be34456887ded8f7fc643b6aaf8230bfef9f","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"    @periodics.periodic("},{"line_number":1531,"context_line":"        spacing\u003dCONF.conductor.sync_local_state_interval)"},{"line_number":1532,"context_line":"    def _sync_console_node_deleted(self):"},{"line_number":1533,"context_line":"        \"\"\"When node is deleted, stop console process on the all conductors\"\"\""},{"line_number":1534,"context_line":"        # get all node in DB."},{"line_number":1535,"context_line":"        node_in_db \u003d self.dbapi.get_nodeinfo_list(columns\u003d[\u0027uuid\u0027])"},{"line_number":1536,"context_line":"        node_list \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_7da92922","line":1533,"in_reply_to":"5f4e5783_37cac96c","updated":"2017-10-15 07:03:28.000000000","message":"only one console will be stopped, the others still running. Because there are more than one console running, when hash_distribution_replicas is bigger than one.","commit_id":"9dfde79603937a2ffdb936ecdefd1510c41c1821"},{"author":{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},"change_message_id":"4901ee97ebca506b3a1000e15266cd180e07dc4a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"from ironic.conductor import task_manager"},{"line_number":71,"context_line":"from ironic.conductor import utils"},{"line_number":72,"context_line":"from ironic.conf import CONF"},{"line_number":73,"context_line":"from ironic.drivers.modules import console_utils"},{"line_number":74,"context_line":"from ironic.drivers import base as drivers_base"},{"line_number":75,"context_line":"from ironic.drivers import hardware_type"},{"line_number":76,"context_line":"from ironic import objects"},{"line_number":77,"context_line":"from ironic.objects import base as objects_base"},{"line_number":78,"context_line":"from ironic.objects import fields"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_a818f780","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":40},"updated":"2017-10-19 04:40:10.000000000","message":"H203 error, should be like this:\nfrom ironic.drivers import base as drivers_base\nfrom ironic.drivers import hardware_type\nfrom ironic.drivers.modules import console_utils","commit_id":"b74c09372cdbf95cd768f73ba1aafca802231ad1"},{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"e283db1dfdd83d87ceafc89e697e14b08a157ae1","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        spacing\u003dCONF.conductor.sync_local_state_interval)"},{"line_number":1532,"context_line":"    def _sync_console_node_deleted(self):"},{"line_number":1533,"context_line":"        \"\"\"When node is deleted, stop console process on the all conductors\"\"\""},{"line_number":1534,"context_line":"        # get all node in DB."},{"line_number":1535,"context_line":"        node_in_db \u003d self.dbapi.get_nodeinfo_list(columns\u003d[\u0027uuid\u0027])"},{"line_number":1536,"context_line":"        node_list \u003d []"},{"line_number":1537,"context_line":"        for item in node_in_db:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_6d1dc272","line":1534,"range":{"start_line":1534,"start_character":18,"end_line":1534,"end_character":22},"updated":"2017-10-26 03:03:07.000000000","message":"nodes","commit_id":"c427f65a18024f3aee4afcb24bff186a0afda249"},{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"e283db1dfdd83d87ceafc89e697e14b08a157ae1","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"        for item in node_in_db:"},{"line_number":1538,"context_line":"            node_list.append(item[0])"},{"line_number":1539,"context_line":""},{"line_number":1540,"context_line":"        # Get all node uuid which console process is running"},{"line_number":1541,"context_line":"        uuid_console_running \u003d console_utils.get_all_running_console_uuid()"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        # Stop console process on these node"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_0d164e56","line":1540,"range":{"start_line":1540,"start_character":18,"end_line":1540,"end_character":22},"updated":"2017-10-26 03:03:07.000000000","message":"nodes\u0027","commit_id":"c427f65a18024f3aee4afcb24bff186a0afda249"},{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"e283db1dfdd83d87ceafc89e697e14b08a157ae1","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        # Get all node uuid which console process is running"},{"line_number":1541,"context_line":"        uuid_console_running \u003d console_utils.get_all_running_console_uuid()"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        # Stop console process on these node"},{"line_number":1544,"context_line":"        dest_node \u003d list(set(uuid_console_running) - set(node_list))"},{"line_number":1545,"context_line":"        for node_uuid in dest_node:"},{"line_number":1546,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_0d3d2edc","line":1543,"range":{"start_line":1543,"start_character":34,"end_line":1543,"end_character":44},"updated":"2017-10-26 03:03:07.000000000","message":"these nodes","commit_id":"c427f65a18024f3aee4afcb24bff186a0afda249"}],"ironic/drivers/modules/console_utils.py":[{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"e283db1dfdd83d87ceafc89e697e14b08a157ae1","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"def get_all_running_console_uuid():"},{"line_number":375,"context_line":"    \"\"\"Get all node uuid which console process is running\"\"\""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    uuid_console_running \u003d []"},{"line_number":378,"context_line":"    pid_dir \u003d _get_console_pid_dir()"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_6802500c","line":375,"range":{"start_line":375,"start_character":15,"end_line":375,"end_character":19},"updated":"2017-10-26 03:03:07.000000000","message":"nodes\u0027","commit_id":"c427f65a18024f3aee4afcb24bff186a0afda249"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"63c598158ac58e884243c993fc4ebb27e023c884","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from ironic.conductor import utils as conductor_utils"},{"line_number":44,"context_line":"from ironic.db import api as dbapi"},{"line_number":45,"context_line":"from ironic.drivers import base as drivers_base"},{"line_number":46,"context_line":"from ironic.drivers.modules import console_utils"},{"line_number":47,"context_line":"from ironic.drivers.modules import fake"},{"line_number":48,"context_line":"from ironic.drivers.modules.network import flat as n_flat"},{"line_number":49,"context_line":"from ironic import objects"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_4de1b1d0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":48},"updated":"2017-10-18 08:00:14.000000000","message":"wrong alphabetical order of the import.","commit_id":"089200dbf9cc7bb8202e9af115ac481cdf4adc5a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"63c598158ac58e884243c993fc4ebb27e023c884","unresolved":false,"context_lines":[{"line_number":6478,"context_line":"                                      target_provision_state\u003dstates.NOSTATE)"},{"line_number":6479,"context_line":"        self.columns \u003d [\u0027uuid\u0027]"},{"line_number":6480,"context_line":""},{"line_number":6481,"context_line":""},{"line_number":6482,"context_line":"    def _assert_get_nodeinfo_args(self, get_nodeinfo_mock):"},{"line_number":6483,"context_line":"        get_nodeinfo_mock.assert_called_once_with("},{"line_number":6484,"context_line":"            columns\u003dself.columns)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8d9a096c","line":6481,"updated":"2017-10-18 08:00:14.000000000","message":"PEP8 failed: There should be 1 blank line here.","commit_id":"089200dbf9cc7bb8202e9af115ac481cdf4adc5a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"63c598158ac58e884243c993fc4ebb27e023c884","unresolved":false,"context_lines":[{"line_number":6505,"context_line":"        log_mock.warning.assert_not_called()"},{"line_number":6506,"context_line":""},{"line_number":6507,"context_line":"    def test_uuid_none(self, stop_console_mock, get_all_running_uuid_mock,"},{"line_number":6508,"context_line":"                  get_nodeinfo_mock, log_mock):"},{"line_number":6509,"context_line":"        get_nodeinfo_mock.return_value \u003d ["},{"line_number":6510,"context_line":"            [\u0027742f25d9-9374-4921-bbc5-b5a70141e1cc\u0027,\u0027ipmitool\u0027],"},{"line_number":6511,"context_line":"            [\u002788ce7c05-9b44-44c3-8b66-038075b83f9e\u0027,\u0027ipmitool\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_0d88591d","line":6508,"range":{"start_line":6508,"start_character":0,"end_line":6508,"end_character":18},"updated":"2017-10-18 08:00:14.000000000","message":"PEP8 failed: wrong indent.","commit_id":"089200dbf9cc7bb8202e9af115ac481cdf4adc5a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"63c598158ac58e884243c993fc4ebb27e023c884","unresolved":false,"context_lines":[{"line_number":6507,"context_line":"    def test_uuid_none(self, stop_console_mock, get_all_running_uuid_mock,"},{"line_number":6508,"context_line":"                  get_nodeinfo_mock, log_mock):"},{"line_number":6509,"context_line":"        get_nodeinfo_mock.return_value \u003d ["},{"line_number":6510,"context_line":"            [\u0027742f25d9-9374-4921-bbc5-b5a70141e1cc\u0027,\u0027ipmitool\u0027],"},{"line_number":6511,"context_line":"            [\u002788ce7c05-9b44-44c3-8b66-038075b83f9e\u0027,\u0027ipmitool\u0027],"},{"line_number":6512,"context_line":"        ]"},{"line_number":6513,"context_line":"        get_all_running_uuid_mock.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_2d98b568","line":6510,"range":{"start_line":6510,"start_character":51,"end_line":6510,"end_character":52},"updated":"2017-10-18 08:00:14.000000000","message":"need a space after \u0027,\u0027.","commit_id":"089200dbf9cc7bb8202e9af115ac481cdf4adc5a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"63c598158ac58e884243c993fc4ebb27e023c884","unresolved":false,"context_lines":[{"line_number":6508,"context_line":"                  get_nodeinfo_mock, log_mock):"},{"line_number":6509,"context_line":"        get_nodeinfo_mock.return_value \u003d ["},{"line_number":6510,"context_line":"            [\u0027742f25d9-9374-4921-bbc5-b5a70141e1cc\u0027,\u0027ipmitool\u0027],"},{"line_number":6511,"context_line":"            [\u002788ce7c05-9b44-44c3-8b66-038075b83f9e\u0027,\u0027ipmitool\u0027],"},{"line_number":6512,"context_line":"        ]"},{"line_number":6513,"context_line":"        get_all_running_uuid_mock.return_value \u003d []"},{"line_number":6514,"context_line":"        stop_console_mock.side_effect \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_eda17d97","line":6511,"range":{"start_line":6511,"start_character":51,"end_line":6511,"end_character":52},"updated":"2017-10-18 08:00:14.000000000","message":"need a space after \u0027,\u0027.","commit_id":"089200dbf9cc7bb8202e9af115ac481cdf4adc5a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"63c598158ac58e884243c993fc4ebb27e023c884","unresolved":false,"context_lines":[{"line_number":6521,"context_line":"        stop_console_mock.assert_not_called()"},{"line_number":6522,"context_line":""},{"line_number":6523,"context_line":"    def test_stop_failed(self, stop_console_mock, get_all_running_uuid_mock,"},{"line_number":6524,"context_line":"                  get_nodeinfo_mock, log_mock):"},{"line_number":6525,"context_line":"        get_nodeinfo_mock.return_value \u003d ["},{"line_number":6526,"context_line":"            [\u0027742f25d9-9374-4921-bbc5-b5a70141e1cc\u0027, \u0027ipmitool\u0027],"},{"line_number":6527,"context_line":"            [\u002788ce7c05-9b44-44c3-8b66-038075b83f9e\u0027, \u0027ipmitool\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_4dbc11bb","line":6524,"range":{"start_line":6524,"start_character":0,"end_line":6524,"end_character":18},"updated":"2017-10-18 08:00:14.000000000","message":"wrong indent.","commit_id":"089200dbf9cc7bb8202e9af115ac481cdf4adc5a"}],"ironic/tests/unit/drivers/modules/test_console_utils.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"31baf502d5106bc2a14d93afbc107f27c16298ac","unresolved":false,"context_lines":[{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        mock_get_console_pid_dir.return_value \u003d \u0027/tmp\u0027"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        mock_listdir.return_value \u003d \\"},{"line_number":584,"context_line":"            [\u002712345.pid\u0027, \u0027742f25d9-9374-4921-bbc5-b5a70141e1cc.pid\u0027,"},{"line_number":585,"context_line":"             \u0027123456.pid\u0027, \u0027fc240f1c-549d-4b69-86b1-b61f0872e8ee.pid\u0027,"},{"line_number":586,"context_line":"             \u0027test.txt\u0027, \u0027aaaaa\u0027]"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        uuid \u003d console_utils.get_all_running_console_uuid()"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_8238ef9f","line":586,"range":{"start_line":583,"start_character":0,"end_line":586,"end_character":33},"updated":"2017-10-16 06:48:42.000000000","message":"You should indent like this:\n\n        mock_listdir.return_value \u003d [\n            \u002712345.pid\u0027, \u0027742f25d9-9374-4921-bbc5-b5a70141e1cc.pid\u0027,\n            \u0027123456.pid\u0027, \u0027fc240f1c-549d-4b69-86b1-b61f0872e8ee.pid\u0027,\n            \u0027test.txt\u0027, \u0027aaaaa\u0027\n        ]","commit_id":"c3450672b4bf41730bcd4b2c3ba9a992e8bf43c0"},{"author":{"_account_id":25284,"name":"fupingxie","email":"xiefp88@sina.com","username":"fpxie"},"change_message_id":"d7dbfb8da1bea9664f6f3eb612b745a3aff2648c","unresolved":false,"context_lines":[{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        mock_get_console_pid_dir.return_value \u003d \u0027/tmp\u0027"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        mock_listdir.return_value \u003d \\"},{"line_number":584,"context_line":"            [\u002712345.pid\u0027, \u0027742f25d9-9374-4921-bbc5-b5a70141e1cc.pid\u0027,"},{"line_number":585,"context_line":"             \u0027123456.pid\u0027, \u0027fc240f1c-549d-4b69-86b1-b61f0872e8ee.pid\u0027,"},{"line_number":586,"context_line":"             \u0027test.txt\u0027, \u0027aaaaa\u0027]"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        uuid \u003d console_utils.get_all_running_console_uuid()"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_854eb96c","line":586,"range":{"start_line":583,"start_character":0,"end_line":586,"end_character":33},"in_reply_to":"5f4e5783_8238ef9f","updated":"2017-10-17 07:06:16.000000000","message":"OK。 Thanks,I will fix at once","commit_id":"c3450672b4bf41730bcd4b2c3ba9a992e8bf43c0"}]}