)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"42f659180a9819cacc1d5f0be0891e8ac6c4d74e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Simplify the logic of validate_network_port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"osl.utils provides method is_valid_port to check port, we can"},{"line_number":10,"context_line":"leaverage it to make code more clear. Note is_valid_port accepts"},{"line_number":11,"context_line":"0 as valid port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I60cb36a042fd808edca66b07d7248213debd4dff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_76784a2a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2017-11-01 18:05:56.000000000","message":"nit: leverage","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"5f6964c09c5dd446240b35c3bcb34146db720a21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Simplify the logic of validate_network_port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"osl.utils provides method is_valid_port to check port, we can"},{"line_number":10,"context_line":"leaverage it to make code more clear. Note is_valid_port accepts"},{"line_number":11,"context_line":"0 as valid port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I60cb36a042fd808edca66b07d7248213debd4dff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_4e648ee5","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"3f4b6375_76784a2a","updated":"2017-11-02 02:06:04.000000000","message":"Done","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e856350feb5b998cecc78e36b6fb57c28c8f646d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"osl.utils provides method is_valid_port to check port, we can"},{"line_number":10,"context_line":"leaverage it to make code more clear. Note is_valid_port accepts"},{"line_number":11,"context_line":"0 as valid port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I60cb36a042fd808edca66b07d7248213debd4dff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_4b8ff222","line":11,"updated":"2017-11-01 13:30:23.000000000","message":"I think we should make this more explicit; that the code here was incorrect in accepting 1-65535, and this change fixes it to also include 0.","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"5f6964c09c5dd446240b35c3bcb34146db720a21","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"osl.utils provides method is_valid_port to check port, we can"},{"line_number":10,"context_line":"leaverage it to make code more clear. Note is_valid_port accepts"},{"line_number":11,"context_line":"0 as valid port."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I60cb36a042fd808edca66b07d7248213debd4dff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_ce9d1ebc","line":11,"in_reply_to":"3f4b6375_4b8ff222","updated":"2017-11-02 02:06:04.000000000","message":"Done","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"}],"ironic/common/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e856350feb5b998cecc78e36b6fb57c28c8f646d","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":479,"context_line":"            \u0027%(port_name)s \"%(port)s\" is not a valid integer.\u0027) %"},{"line_number":480,"context_line":"            {\u0027port_name\u0027: port_name, \u0027port\u0027: port})"},{"line_number":481,"context_line":"    if port \u003c 1 or port \u003e 65535:"},{"line_number":482,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":483,"context_line":"            \u0027%(port_name)s \"%(port)s\" is out of range. Valid port \u0027"},{"line_number":484,"context_line":"            \u0027numbers must be between 1 and 65535.\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_8b6dea99","side":"PARENT","line":481,"updated":"2017-11-01 13:30:23.000000000","message":"I hope there was no \u0027odd\u0027 reason that ironic didn\u0027t want to accept port 0.","commit_id":"2780a5f17002d0b6fc98a36d0d20c62cfd746118"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e856350feb5b998cecc78e36b6fb57c28c8f646d","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    :raises: InvalidParameterValue, if the port is invalid."},{"line_number":474,"context_line":"    \"\"\""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if netutils.is_valid_port(port):"},{"line_number":477,"context_line":"        return int(port)"},{"line_number":478,"context_line":"    else:"},{"line_number":479,"context_line":"        raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_0b845a0b","line":476,"updated":"2017-11-01 13:30:23.000000000","message":"Our original code changed for the value in the range 1-65535 inclusive. This method checks for the range 0-65535 inclusive, which is correct as far as I can tell.\n\nI took a look at the original commit [1] and it was 1.. with no one commenting about why it wasn\u0027t 0 or why it needed to be 1. The bug associated with it, did specify 0-65535, so I\u0027m assuming the original code was incorrect.\n\n[1] e905d7fa618d8fecb9005a6b4169f0dd4f700979","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"5f6964c09c5dd446240b35c3bcb34146db720a21","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    :raises: InvalidParameterValue, if the port is invalid."},{"line_number":474,"context_line":"    \"\"\""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if netutils.is_valid_port(port):"},{"line_number":477,"context_line":"        return int(port)"},{"line_number":478,"context_line":"    else:"},{"line_number":479,"context_line":"        raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_8e804648","line":476,"in_reply_to":"3f4b6375_0b845a0b","updated":"2017-11-02 02:06:04.000000000","message":"thanks for digging this.","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"42f659180a9819cacc1d5f0be0891e8ac6c4d74e","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if netutils.is_valid_port(port):"},{"line_number":477,"context_line":"        return int(port)"},{"line_number":478,"context_line":"    else:"},{"line_number":479,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":480,"context_line":"            \u0027%(port_name)s \"%(port)s\" is not a valid port.\u0027) %"},{"line_number":481,"context_line":"            {\u0027port_name\u0027: port_name, \u0027port\u0027: port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_769dea55","line":478,"updated":"2017-11-01 18:05:56.000000000","message":"nit: else is not needed","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"5f6964c09c5dd446240b35c3bcb34146db720a21","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if netutils.is_valid_port(port):"},{"line_number":477,"context_line":"        return int(port)"},{"line_number":478,"context_line":"    else:"},{"line_number":479,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":480,"context_line":"            \u0027%(port_name)s \"%(port)s\" is not a valid port.\u0027) %"},{"line_number":481,"context_line":"            {\u0027port_name\u0027: port_name, \u0027port\u0027: port})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_4e924ea1","line":478,"in_reply_to":"3f4b6375_769dea55","updated":"2017-11-02 02:06:04.000000000","message":"Done","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"}],"ironic/tests/unit/common/test_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"42f659180a9819cacc1d5f0be0891e8ac6c4d74e","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def test_validate_network_port(self):"},{"line_number":548,"context_line":"        port \u003d utils.validate_network_port(\u00271\u0027, \u0027message\u0027)"},{"line_number":549,"context_line":"        self.assertEqual(1, port)"},{"line_number":550,"context_line":"        port \u003d utils.validate_network_port(\u002765535\u0027)"},{"line_number":551,"context_line":"        self.assertEqual(65535, port)"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_f6df9a09","line":549,"updated":"2017-11-01 18:05:56.000000000","message":"Can we change this to 0? Since the comment is talking about how now 0 is a valid value, but we aren\u0027t showing that is true without a unit test.","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"5f6964c09c5dd446240b35c3bcb34146db720a21","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def test_validate_network_port(self):"},{"line_number":548,"context_line":"        port \u003d utils.validate_network_port(\u00271\u0027, \u0027message\u0027)"},{"line_number":549,"context_line":"        self.assertEqual(1, port)"},{"line_number":550,"context_line":"        port \u003d utils.validate_network_port(\u002765535\u0027)"},{"line_number":551,"context_line":"        self.assertEqual(65535, port)"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_0ee1f62a","line":549,"in_reply_to":"3f4b6375_f6df9a09","updated":"2017-11-02 02:06:04.000000000","message":"Done","commit_id":"d82a7dc755c209cbea0c25191184c211ee96b0d1"}]}