)]}'
{"ironic/tests/unit/objects/test_objects.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1836862041d57021616fc4edb6a363824aede9e","unresolved":false,"context_lines":[{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    @mock.patch.object(base.IronicObject, \u0027convert_to_version\u0027, autospec\u003dTrue)"},{"line_number":856,"context_line":"    @mock.patch.object(base.IronicObject, \u0027get_target_version\u0027,"},{"line_number":857,"context_line":"                       spec_set\u003dtypes.FunctionType)"},{"line_number":858,"context_line":"    def test_serialize_entity_unpinned_conductor(self, mock_version,"},{"line_number":859,"context_line":"                                                 mock_convert):"},{"line_number":860,"context_line":"        \"\"\"Test single element serializer with no backport, unpinned.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_65716ba8","line":857,"updated":"2017-11-03 21:40:49.000000000","message":"I don\u0027t quite get why this patch is somewhat inconsistent. What was the reason to use spec_set here but autospec on a similar line above? It feels to me that all mocks here can just use autospec..","commit_id":"3513a5d79a378c01082f4089b4a4e674b22173e4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"2b742004dfe1ee6a3962ee75e2a87b1cb6ea8ca7","unresolved":false,"context_lines":[{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    @mock.patch.object(base.IronicObject, \u0027convert_to_version\u0027, autospec\u003dTrue)"},{"line_number":856,"context_line":"    @mock.patch.object(base.IronicObject, \u0027get_target_version\u0027,"},{"line_number":857,"context_line":"                       spec_set\u003dtypes.FunctionType)"},{"line_number":858,"context_line":"    def test_serialize_entity_unpinned_conductor(self, mock_version,"},{"line_number":859,"context_line":"                                                 mock_convert):"},{"line_number":860,"context_line":"        \"\"\"Test single element serializer with no backport, unpinned.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_059bd772","line":857,"in_reply_to":"3f4b6375_65716ba8","updated":"2017-11-03 22:15:33.000000000","message":"Hi Dmitry, used spec_set because autospec\u003dTrue gives  TypeError: \u0027NonCallableMagicMock\u0027 object is not callable.","commit_id":"3513a5d79a378c01082f4089b4a4e674b22173e4"}],"ironic/tests/unit/objects/test_volume_target.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8e18e9e269d13748bde775acb0d291fdd5aeb6b3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(TestVolumeTargetObject, self).setUp()"},{"line_number":32,"context_line":"        self.volume_target_dict \u003d db_utils.get_test_volume_target()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # NOTE(rama_y): autospec doesn\u0027t work on staticmethods."},{"line_number":35,"context_line":"    # reference: https://bugs.python.org/issue23078"},{"line_number":36,"context_line":"    @mock.patch(\u0027ironic.objects.VolumeTarget.get_by_uuid\u0027,"},{"line_number":37,"context_line":"                spec_set\u003dtypes.FunctionType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_5763e142","line":34,"updated":"2017-11-02 21:06:16.000000000","message":"I\u0027d prefer to not have this comment. If were setting it to autospec\u003dFalse and that was it, then the comment would be good.\n\nBut since using spec_set, I don\u0027t think it is needed.","commit_id":"23206aae56d69e2b536dff0664d79cc258a7586d"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"4b3090507d970652cc88024ca05158f400723f78","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(TestVolumeTargetObject, self).setUp()"},{"line_number":32,"context_line":"        self.volume_target_dict \u003d db_utils.get_test_volume_target()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    # NOTE(rama_y): autospec doesn\u0027t work on staticmethods."},{"line_number":35,"context_line":"    # reference: https://bugs.python.org/issue23078"},{"line_number":36,"context_line":"    @mock.patch(\u0027ironic.objects.VolumeTarget.get_by_uuid\u0027,"},{"line_number":37,"context_line":"                spec_set\u003dtypes.FunctionType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_18a359a0","line":34,"in_reply_to":"3f4b6375_5763e142","updated":"2017-11-02 23:03:46.000000000","message":"Thanks John. updated the patch.","commit_id":"23206aae56d69e2b536dff0664d79cc258a7586d"}]}