)]}'
{"ironic/common/exception.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"db65a3dc3881ff3426500d96c10e405d32357d8e","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class ConductorAlreadyRegistered(IronicException):"},{"line_number":290,"context_line":"    message \u003d _(\"Conductor %(hostname)s already registered.\")"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"class PowerStateFailure(InvalidState):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKXA%3D","line":290,"updated":"2013-10-22 09:05:08.000000000","message":"Not a big deal but wouldn\u0027t be better to call it %(conductor)s here as well, just to be more consistent with the ConductorNotFound exception above.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa45b962975d020b1bb07f55f1835e4162e562e2","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class ConductorAlreadyRegistered(IronicException):"},{"line_number":290,"context_line":"    message \u003d _(\"Conductor %(hostname)s already registered.\")"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"class PowerStateFailure(InvalidState):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FIWM%3D","line":290,"in_reply_to":"AAAATH%2F%2FKXA%3D","updated":"2013-10-22 20:29:09.000000000","message":"Done","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"}],"ironic/conductor/manager.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"},{"line_number":63,"context_line":"        super(ConductorManager, self).__init__(host, topic,"},{"line_number":64,"context_line":"                                               serializer\u003dserializer)"},{"line_number":65,"context_line":"        resource_manager.NodeManager._init_driver_factory()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def start(self):"},{"line_number":68,"context_line":"        super(ConductorManager, self).start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgnU%3D","line":65,"updated":"2013-10-15 08:23:32.000000000","message":"Maybe better rename this method w/o \u0027_\u0027.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"703281c56354fff6b1dfd56643d2ae6f0bdc91fa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(ConductorManager, self).start()"},{"line_number":69,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        drivers \u003d resource_manager.NodeManager._driver_factory.names"},{"line_number":72,"context_line":"        self.dbapi.register_conductor(self.host, drivers)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgTk%3D","line":71,"updated":"2013-10-15 10:22:48.000000000","message":"s/names/names()/\n\n.names is a method \u003cbound method DriverFactory.names of  ironic.common.driver_factory.DriverFactory object at 0x18ee2d0\u003e\u003e\n\nBtw, what about using the DriverFactory class here instead of accessing a \"private\" ( prefixed with _ ) attribute from outside?","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(ConductorManager, self).start()"},{"line_number":69,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        drivers \u003d resource_manager.NodeManager._driver_factory.names"},{"line_number":72,"context_line":"        self.dbapi.register_conductor(self.host, drivers)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfJE%3D","line":71,"in_reply_to":"AAAATH%2F%2FgTk%3D","updated":"2013-10-15 15:13:41.000000000","message":"Yep! Your DriverFactory class makes much more sense here.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        drivers \u003d resource_manager.NodeManager._driver_factory.names"},{"line_number":72,"context_line":"        self.dbapi.register_conductor(self.host, drivers)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def initialize_service_hook(self, service):"},{"line_number":75,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FglE%3D","line":72,"updated":"2013-10-15 08:23:32.000000000","message":"drivers is a list or string? (for db api)","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        drivers \u003d resource_manager.NodeManager._driver_factory.names"},{"line_number":72,"context_line":"        self.dbapi.register_conductor(self.host, drivers)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def initialize_service_hook(self, service):"},{"line_number":75,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfI8%3D","line":72,"in_reply_to":"AAAATH%2F%2FgTY%3D","updated":"2013-10-15 15:13:41.000000000","message":"Yes, as Lucas said. List of strings.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"703281c56354fff6b1dfd56643d2ae6f0bdc91fa","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        drivers \u003d resource_manager.NodeManager._driver_factory.names"},{"line_number":72,"context_line":"        self.dbapi.register_conductor(self.host, drivers)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def initialize_service_hook(self, service):"},{"line_number":75,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgTY%3D","line":72,"in_reply_to":"AAAATH%2F%2FglE%3D","updated":"2013-10-15 10:22:48.000000000","message":"It\u0027s a list with drivers name. eg: [\u0027fake_ipminative\u0027, \u0027pxe_ipminative\u0027, \u0027fake\u0027, \u0027fake_ssh\u0027, \u0027fake_ipmitool\u0027, \u0027fake_pxe\u0027, \u0027pxe_ssh\u0027, \u0027pxe_ipmitool\u0027]","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c5255b0c1bd2d027229edf956a1b8a3aefde0726","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        super(ConductorManager, self).start()"},{"line_number":70,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        drivers \u003d resource_manager.NodeManager._driver_factory.names()"},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FeKc%3D","line":72,"updated":"2013-10-15 19:07:31.000000000","message":"TODO -- access DriverFactory once that is implemented, instead of accessing this private method....","commit_id":"facec3b6e3037cbf7718eb117ca897f02af09d0a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"04d607da0e472ca0dfa8975313b7c755f0cb8dfa","unresolved":false,"context_lines":[{"line_number":57,"context_line":"class ConductorManager(service.PeriodicService):"},{"line_number":58,"context_line":"    \"\"\"Ironic Conductor service main class.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    RPC_API_VERSION \u003d \u00271.4\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, host, topic):"},{"line_number":63,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FbvM%3D","line":60,"updated":"2013-10-16 09:06:12.000000000","message":"quick q. I think you don\u0027t need to but lemme ask. Do you have to bump this version here? You added a new method _conductor_service_record_keepalive but as it\u0027s an internal method I don\u0027t know, I think that since you didn\u0027t change the API you don\u0027t need to bump it, is that correct?","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7297d6410f2537fd0dc1a8551aa0049b68705e11","unresolved":false,"context_lines":[{"line_number":57,"context_line":"class ConductorManager(service.PeriodicService):"},{"line_number":58,"context_line":"    \"\"\"Ironic Conductor service main class.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    RPC_API_VERSION \u003d \u00271.4\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, host, topic):"},{"line_number":63,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ%2FM%3D","line":60,"in_reply_to":"AAAATH%2F%2FbvM%3D","updated":"2013-10-16 15:59:33.000000000","message":"correct -- RPC_API_VERSION only changes when the API changes in a way that would be incompatible (eg, new method, changed method params, etc).","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0b04f263b5ddfc699fdb7e738aef4c5aeab14c1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        drivers \u003d df.names()"},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fb5o%3D","line":75,"updated":"2013-10-16 08:21:00.000000000","message":"1) IMO bad idea to catch db_exc.DBDuplicateError on this level.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0b04f263b5ddfc699fdb7e738aef4c5aeab14c1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fb5A%3D","line":76,"updated":"2013-10-16 08:21:00.000000000","message":"2) Why insert-or-update code not used in db api, like:\n\ndef register_conductor():\n    try:\n        _create_conductor()\n    except db_exc.DBDuplicateError:\n        _update_conductor()","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b03cdf56d35ec1ba71a7430e3892c9d182047271","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZyU%3D","line":76,"in_reply_to":"AAAATH%2F%2FZ9s%3D","updated":"2013-10-16 16:34:05.000000000","message":"IMO better hide this code in db api method and do LOG warning from there. This does not look as \u0027high level\u0027 code.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FYvI%3D","line":76,"in_reply_to":"AAAATH%2F%2FZyU%3D","updated":"2013-10-16 20:49:26.000000000","message":"I disagree -- if there is no exception visible at the ConductorManager layer, then it looks like there is no error, when in fact, there is a problem at startup.\n\nImagine what would happen if a deployer accidentally names two hosts the same. They might see a DB warning, but I think they should see a Conductor warning.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7297d6410f2537fd0dc1a8551aa0049b68705e11","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ9s%3D","line":76,"in_reply_to":"AAAATH%2F%2Fb5A%3D","updated":"2013-10-16 15:59:33.000000000","message":"actually, I think conductor.manager should LOG a warning here, that it overwrote another record which is presumably left from a crash. I\u0027ll add an exception and handle it.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"04d607da0e472ca0dfa8975313b7c755f0cb8dfa","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def initialize_service_hook(self, service):"},{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FbqY%3D","line":78,"updated":"2013-10-16 09:06:12.000000000","message":"I think that we need a way to unregister the conductor when it\u0027s shutdown as well. In case a conductor has a specific driver and it\u0027s shutdown at some point, that driver will still be shown in the /drivers list which is not ideal since that driver is not really available at that point.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7297d6410f2537fd0dc1a8551aa0049b68705e11","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        except db_exc.DBDuplicateError:"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def initialize_service_hook(self, service):"},{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ%2BQ%3D","line":78,"in_reply_to":"AAAATH%2F%2FbqY%3D","updated":"2013-10-16 15:59:33.000000000","message":"a) yes, there should be a shutdown hook. I\u0027ll add that as a TODO.\nb) the /drivers list should handle a crashed or dead conductor that didn\u0027t clean up\nc) the dbapi method that gets a list of drivers already takes (b) into account by only returning drivers whose conductor checked in within the last interval (default 5 minute -- should be configurable but isn\u0027t in this patch).","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e47a2c2d8890dc6cf71f8987a5abd3a02e761286","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        df \u003d driver_factory.DriverFactory()"},{"line_number":71,"context_line":"        drivers \u003d df.names()"},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":74,"context_line":"        except exception.ConductorAlreadyRegistered as e:"},{"line_number":75,"context_line":"            LOG.warn(_(\"Error registering conductor during startup: %s\") % e)"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKGo%3D","line":73,"updated":"2013-10-22 10:31:32.000000000","message":"You should pass a dictionary like {\u0027hostname\u0027: self.host, \u0027drivers\u0027: drivers} to register_conductor() instead of 2 separeted parameters.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"db65a3dc3881ff3426500d96c10e405d32357d8e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except exception.ConductorAlreadyRegistered as e:"},{"line_number":75,"context_line":"            LOG.warn(_(\"Error registering conductor during startup: %s\") % e)"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(deva): add stop() to call unregister_conductor"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKV0%3D","line":77,"updated":"2013-10-22 09:05:08.000000000","message":"This exception handle will make more sense once we have the stop() function calling unregister_conductor. In the moment I don\u0027t think we should log an \"Error ...\" message here since that\u0027s the expected behavior if you restart the conductor, I think we should just log an info by now saying \"Conductor already registered, updating it\" or something like that.\n\nThoughts?","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e47a2c2d8890dc6cf71f8987a5abd3a02e761286","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except exception.ConductorAlreadyRegistered as e:"},{"line_number":75,"context_line":"            LOG.warn(_(\"Error registering conductor during startup: %s\") % e)"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(deva): add stop() to call unregister_conductor"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKHk%3D","line":77,"updated":"2013-10-22 10:31:32.000000000","message":"same comment about the parameters up there.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa45b962975d020b1bb07f55f1835e4162e562e2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except exception.ConductorAlreadyRegistered as e:"},{"line_number":75,"context_line":"            LOG.warn(_(\"Error registering conductor during startup: %s\") % e)"},{"line_number":76,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":77,"context_line":"            self.dbapi.register_conductor(self.host, drivers)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(deva): add stop() to call unregister_conductor"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FIXU%3D","line":77,"in_reply_to":"AAAATH%2F%2FKV0%3D","updated":"2013-10-22 20:29:09.000000000","message":"Good point. I\u0027ve even got LOG.warn() up there!","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9df818e249455a1b48070d1bd7ea1f511b010c13","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        df \u003d driver_factory.DriverFactory()"},{"line_number":71,"context_line":"        drivers \u003d df.names()"},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            self.dbapi.register_conductor({\u0027hostname\u0027: self.host,"},{"line_number":74,"context_line":"                                           \u0027drivers\u0027: drivers})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2FEY%3D","line":71,"updated":"2013-10-23 09:27:06.000000000","message":".names is a property.\n\nI didn\u0027t catch it on the previous review cause before the DriverFactory class was inherited from dispatch.NameDispatchExtensionManager, so names() existed and the property on DriverFactory was called .drivers.\n\nTraceback:\n\n  File \"/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py\", line 194, in main\n    result \u003d function(*args, **kwargs)\n  File \"/opt/stack/ironic/ironic/openstack/common/service.py\", line 65, in run_service\n    service.start()\n  File \"/opt/stack/ironic/ironic/conductor/manager.py\", line 71, in start\n    drivers \u003d df.names()\nTypeError: \u0027list\u0027 object is not callable","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        df \u003d driver_factory.DriverFactory()"},{"line_number":71,"context_line":"        drivers \u003d df.names()"},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            self.dbapi.register_conductor({\u0027hostname\u0027: self.host,"},{"line_number":74,"context_line":"                                           \u0027drivers\u0027: drivers})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BUM%3D","line":71,"in_reply_to":"AAAATX%2F%2F%2FEY%3D","updated":"2013-10-23 17:44:06.000000000","message":"Ah! Yep, thanks","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9df818e249455a1b48070d1bd7ea1f511b010c13","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":80,"context_line":"            self.dbapi.register_conductor({\u0027hostname\u0027: self.host,"},{"line_number":81,"context_line":"                                           \u0027drivers\u0027: drivers})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    # TODO(deva): add stop() to call unregister_conductor"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2FDU%3D","line":82,"updated":"2013-10-23 09:27:06.000000000","message":"Also, I think we need som tests on this start method, before it was quite simple but now there\u0027s a good chunk of logic here.","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            self.dbapi.unregister_conductor(self.host)"},{"line_number":80,"context_line":"            self.dbapi.register_conductor({\u0027hostname\u0027: self.host,"},{"line_number":81,"context_line":"                                           \u0027drivers\u0027: drivers})"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    # TODO(deva): add stop() to call unregister_conductor"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def initialize_service_hook(self, service):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9XI%3D","line":82,"in_reply_to":"AAAATX%2F%2F%2FDU%3D","updated":"2013-10-23 17:44:06.000000000","message":"Done","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"}],"ironic/db/api.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"703281c56354fff6b1dfd56643d2ae6f0bdc91fa","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":322,"context_line":"        \"\"\"Retrieve a list of drivers supported by the resitered conductors."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        :param interval: Time since last check-in of a conductori."},{"line_number":325,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgTU%3D","line":324,"updated":"2013-10-15 10:22:48.000000000","message":"typo s/conductori/conductor/","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":322,"context_line":"        \"\"\"Retrieve a list of drivers supported by the resitered conductors."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        :param interval: Time since last check-in of a conductori."},{"line_number":325,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfGI%3D","line":324,"in_reply_to":"AAAATH%2F%2FgTU%3D","updated":"2013-10-15 15:13:41.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9df818e249455a1b48070d1bd7ea1f511b010c13","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        \u0027drivers\u0027: a list of supported drivers."},{"line_number":294,"context_line":"                       }"},{"line_number":295,"context_line":"        :returns: A conductor."},{"line_number":296,"context_line":"        :raises: DBDuplicateEntry"},{"line_number":297,"context_line":"        \"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2FK8%3D","line":296,"updated":"2013-10-23 09:27:06.000000000","message":"Missed it in the previous review, sorry, a small nit here.\n\n:raises: ConductorAlreadyRegistered","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        \u0027drivers\u0027: a list of supported drivers."},{"line_number":294,"context_line":"                       }"},{"line_number":295,"context_line":"        :returns: A conductor."},{"line_number":296,"context_line":"        :raises: DBDuplicateEntry"},{"line_number":297,"context_line":"        \"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BUI%3D","line":296,"in_reply_to":"AAAATX%2F%2F%2FK8%3D","updated":"2013-10-23 17:44:06.000000000","message":"Done","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @abc.abstractmethod"},{"line_number":325,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":326,"context_line":"        \"\"\"Retrieve a list of drivers supported by the resitered conductors."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :param interval: Time since last check-in of a conductor."},{"line_number":329,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2B0o%3D","line":326,"updated":"2013-10-23 13:24:11.000000000","message":"Typo here: resitered, should be registered","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"6637e3b5fb2ce6aef91bc1939d1358ac832f03e9","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @abc.abstractmethod"},{"line_number":325,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":326,"context_line":"        \"\"\"Retrieve a list of drivers supported by the resitered conductors."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :param interval: Time since last check-in of a conductor."},{"line_number":329,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F%2BVE%3D","line":326,"updated":"2013-10-24 12:32:57.000000000","message":"s/resitered/registered","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2a6f294f44133d0d0523d518f1aa3c245170215c","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @abc.abstractmethod"},{"line_number":325,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":326,"context_line":"        \"\"\"Retrieve a list of drivers supported by the resitered conductors."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :param interval: Time since last check-in of a conductor."},{"line_number":329,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F9H0%3D","line":326,"in_reply_to":"AAAATn%2F%2F%2BVE%3D","updated":"2013-10-24 17:30:57.000000000","message":"Done","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"69817a98924706a090dbc2999a785c6ca758fcfe","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        \u0027drivers\u0027: a list of supported drivers."},{"line_number":294,"context_line":"                       }"},{"line_number":295,"context_line":"        :returns: A conductor."},{"line_number":296,"context_line":"        :raises: ConductorNotFound"},{"line_number":297,"context_line":"        \"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2F84w%3D","line":296,"updated":"2013-10-24 17:56:07.000000000","message":"s/ConductorNotFound/ConductorAlreadyRegistered","commit_id":"f1e0d29b0e5d1728c459c8b07b20d20a606eeaf5"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"4d5d388fe04bcdd5697410099ad34197f30f62f0","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                        \u0027drivers\u0027: a list of supported drivers."},{"line_number":294,"context_line":"                       }"},{"line_number":295,"context_line":"        :returns: A conductor."},{"line_number":296,"context_line":"        :raises: ConductorNotFound"},{"line_number":297,"context_line":"        \"\"\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2F7ww%3D","line":296,"in_reply_to":"AAAATn%2F%2F84w%3D","updated":"2013-10-25 00:23:26.000000000","message":"Done","commit_id":"f1e0d29b0e5d1728c459c8b07b20d20a606eeaf5"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"69817a98924706a090dbc2999a785c6ca758fcfe","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @abc.abstractmethod"},{"line_number":325,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":326,"context_line":"        \"\"\"Retrieve a list of drivers supported by the regitered conductors."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :param interval: Time since last check-in of a conductor."},{"line_number":329,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2F84o%3D","line":326,"updated":"2013-10-24 17:56:07.000000000","message":"s/regitered/registered\n\nI believe the second shot will be successful\u003d)","commit_id":"f1e0d29b0e5d1728c459c8b07b20d20a606eeaf5"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"4d5d388fe04bcdd5697410099ad34197f30f62f0","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @abc.abstractmethod"},{"line_number":325,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":326,"context_line":"        \"\"\"Retrieve a list of drivers supported by the regitered conductors."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        :param interval: Time since last check-in of a conductor."},{"line_number":329,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2F7w0%3D","line":326,"in_reply_to":"AAAATn%2F%2F84o%3D","updated":"2013-10-25 00:23:26.000000000","message":".... LOL .... :(","commit_id":"f1e0d29b0e5d1728c459c8b07b20d20a606eeaf5"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":464,"context_line":"            count \u003d query.delete()"},{"line_number":465,"context_line":"            if count !\u003d 1:"},{"line_number":466,"context_line":"                raise exception.ChassisNotFound(chassis\u003dchassis)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    @objects.objectify(objects.Conductor)"},{"line_number":469,"context_line":"    def register_conductor(self, hostname, drivers):"},{"line_number":470,"context_line":"        session \u003d get_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FguU%3D","line":467,"updated":"2013-10-15 08:23:32.000000000","message":"Please add tests in tests.db.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    def register_conductor(self, hostname, drivers):"},{"line_number":470,"context_line":"        session \u003d get_session()"},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            with session.begin():"},{"line_number":473,"context_line":"                cdr \u003d models.Conductor()"},{"line_number":474,"context_line":"                cdr.update({\u0027hostname\u0027: hostname,"},{"line_number":475,"context_line":"                            \u0027drivers\u0027: drivers})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FguM%3D","line":472,"updated":"2013-10-15 08:23:32.000000000","message":"AFAIK session not needed here.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b56afbe26c43091cc96474d609329156f9c1f14c","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    def register_conductor(self, hostname, drivers):"},{"line_number":470,"context_line":"        session \u003d get_session()"},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            with session.begin():"},{"line_number":473,"context_line":"                cdr \u003d models.Conductor()"},{"line_number":474,"context_line":"                cdr.update({\u0027hostname\u0027: hostname,"},{"line_number":475,"context_line":"                            \u0027drivers\u0027: drivers})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fe1M%3D","line":472,"in_reply_to":"AAAATH%2F%2FguM%3D","updated":"2013-10-15 16:23:42.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"703281c56354fff6b1dfd56643d2ae6f0bdc91fa","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        session \u003d get_session()"},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            with session.begin():"},{"line_number":473,"context_line":"                cdr \u003d models.Conductor()"},{"line_number":474,"context_line":"                cdr.update({\u0027hostname\u0027: hostname,"},{"line_number":475,"context_line":"                            \u0027drivers\u0027: drivers})"},{"line_number":476,"context_line":"                cdr.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgSA%3D","line":473,"updated":"2013-10-15 10:22:48.000000000","message":"if drivers:\n    drivers \u003d \u0027,\u0027.join(drivers)","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        session \u003d get_session()"},{"line_number":471,"context_line":"        try:"},{"line_number":472,"context_line":"            with session.begin():"},{"line_number":473,"context_line":"                cdr \u003d models.Conductor()"},{"line_number":474,"context_line":"                cdr.update({\u0027hostname\u0027: hostname,"},{"line_number":475,"context_line":"                            \u0027drivers\u0027: drivers})"},{"line_number":476,"context_line":"                cdr.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfIQ%3D","line":473,"in_reply_to":"AAAATH%2F%2FgSA%3D","updated":"2013-10-15 15:13:41.000000000","message":"good catch, thanks","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":490,"context_line":"        session \u003d get_session()"},{"line_number":491,"context_line":"        with session.begin():"},{"line_number":492,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession)"},{"line_number":493,"context_line":"            count \u003d query.delete()"},{"line_number":494,"context_line":"            if count !\u003d 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgtU%3D","line":491,"updated":"2013-10-15 08:23:32.000000000","message":"AFAIK session not needed here.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":490,"context_line":"        session \u003d get_session()"},{"line_number":491,"context_line":"        with session.begin():"},{"line_number":492,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession)"},{"line_number":493,"context_line":"            count \u003d query.delete()"},{"line_number":494,"context_line":"            if count !\u003d 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfIE%3D","line":491,"in_reply_to":"AAAATH%2F%2FgtU%3D","updated":"2013-10-15 15:13:41.000000000","message":"Session needed here to handle the case of \u003e1 row deleted --\u003e rollback.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":490,"context_line":"        session \u003d get_session()"},{"line_number":491,"context_line":"        with session.begin():"},{"line_number":492,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession)"},{"line_number":493,"context_line":"            count \u003d query.delete()"},{"line_number":494,"context_line":"            if count !\u003d 1:"},{"line_number":495,"context_line":"                raise exception.ConductorNotFound(hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgtA%3D","line":492,"updated":"2013-10-15 08:23:32.000000000","message":"You forgot hostname here.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":490,"context_line":"        session \u003d get_session()"},{"line_number":491,"context_line":"        with session.begin():"},{"line_number":492,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession)"},{"line_number":493,"context_line":"            count \u003d query.delete()"},{"line_number":494,"context_line":"            if count !\u003d 1:"},{"line_number":495,"context_line":"                raise exception.ConductorNotFound(hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfIA%3D","line":492,"in_reply_to":"AAAATH%2F%2FgS0%3D","updated":"2013-10-15 15:13:41.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"703281c56354fff6b1dfd56643d2ae6f0bdc91fa","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":490,"context_line":"        session \u003d get_session()"},{"line_number":491,"context_line":"        with session.begin():"},{"line_number":492,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession)"},{"line_number":493,"context_line":"            count \u003d query.delete()"},{"line_number":494,"context_line":"            if count !\u003d 1:"},{"line_number":495,"context_line":"                raise exception.ConductorNotFound(hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgS0%3D","line":492,"in_reply_to":"AAAATH%2F%2FgtA%3D","updated":"2013-10-15 10:22:48.000000000","message":"+1...\n\n.filter_by(hostname\u003dhostname)","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession).\\"},{"line_number":501,"context_line":"                        filter_by(hostname\u003dhostname)"},{"line_number":502,"context_line":"            if drivers is not None:"},{"line_number":503,"context_line":"                drivers \u003d \u0027,\u0027.join(drivers)"},{"line_number":504,"context_line":"                count \u003d query.update({\u0027drivers\u0027: drivers,"},{"line_number":505,"context_line":"                                      \u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":506,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgo8%3D","line":503,"updated":"2013-10-15 08:23:32.000000000","message":"In line 469 drivers is string, there is a list. Maybe to unify?","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b56afbe26c43091cc96474d609329156f9c1f14c","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession).\\"},{"line_number":501,"context_line":"                        filter_by(hostname\u003dhostname)"},{"line_number":502,"context_line":"            if drivers is not None:"},{"line_number":503,"context_line":"                drivers \u003d \u0027,\u0027.join(drivers)"},{"line_number":504,"context_line":"                count \u003d query.update({\u0027drivers\u0027: drivers,"},{"line_number":505,"context_line":"                                      \u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":506,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fe1E%3D","line":503,"in_reply_to":"AAAATH%2F%2Fgo8%3D","updated":"2013-10-15 16:23:42.000000000","message":"Yep. It should be passed as a list to all db/api methods. That it is stored as a string is a db implementation detail, and all the conversion should be happening inside slqlachemy/api.py","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            if drivers is not None:"},{"line_number":503,"context_line":"                drivers \u003d \u0027,\u0027.join(drivers)"},{"line_number":504,"context_line":"                count \u003d query.update({\u0027drivers\u0027: drivers,"},{"line_number":505,"context_line":"                                      \u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":506,"context_line":"            else:"},{"line_number":507,"context_line":"                count \u003d query.update({\u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":508,"context_line":"            if count !\u003d 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgsg%3D","line":505,"updated":"2013-10-15 08:23:32.000000000","message":"Not need manually update \u0027updated_at\u0027, this work do oslo db code.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            if drivers is not None:"},{"line_number":503,"context_line":"                drivers \u003d \u0027,\u0027.join(drivers)"},{"line_number":504,"context_line":"                count \u003d query.update({\u0027drivers\u0027: drivers,"},{"line_number":505,"context_line":"                                      \u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":506,"context_line":"            else:"},{"line_number":507,"context_line":"                count \u003d query.update({\u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":508,"context_line":"            if count !\u003d 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfH4%3D","line":505,"in_reply_to":"AAAATH%2F%2Fgsg%3D","updated":"2013-10-15 15:13:41.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            else:"},{"line_number":507,"context_line":"                count \u003d query.update({\u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":508,"context_line":"            if count !\u003d 1:"},{"line_number":509,"context_line":"                raise exception.ConductorNotFound(hostname\u003dhostname)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def list_active_conductor_drivers(self, interval\u003d300):"},{"line_number":512,"context_line":"        session \u003d get_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgr0%3D","line":509,"updated":"2013-10-15 08:23:32.000000000","message":"Are you added this exception?","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            else:"},{"line_number":507,"context_line":"                count \u003d query.update({\u0027updated_at\u0027: timeutils.utcnow()})"},{"line_number":508,"context_line":"            if count !\u003d 1:"},{"line_number":509,"context_line":"                raise exception.ConductorNotFound(hostname\u003dhostname)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def list_active_conductor_drivers(self, interval\u003d300):"},{"line_number":512,"context_line":"        session \u003d get_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfHw%3D","line":509,"in_reply_to":"AAAATH%2F%2Fgr0%3D","updated":"2013-10-15 15:13:41.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        with session.begin():"},{"line_number":514,"context_line":"            limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":515,"context_line":"            result \u003d model_query(models.Conductor.drivers, session\u003dsession).\\"},{"line_number":516,"context_line":"                        filter_by(models.Conductor.updated_at \u003e limit).\\"},{"line_number":517,"context_line":"                        all()"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        driver_list \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgq0%3D","line":516,"updated":"2013-10-15 08:23:32.000000000","message":"AFAIK filter() needed here, hot filter_by()","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        with session.begin():"},{"line_number":514,"context_line":"            limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":515,"context_line":"            result \u003d model_query(models.Conductor.drivers, session\u003dsession).\\"},{"line_number":516,"context_line":"                        filter_by(models.Conductor.updated_at \u003e limit).\\"},{"line_number":517,"context_line":"                        all()"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        driver_list \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfHk%3D","line":516,"in_reply_to":"AAAATH%2F%2Fgq0%3D","updated":"2013-10-15 15:13:41.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        driver_list \u003d []"},{"line_number":520,"context_line":"        for row in result:"},{"line_number":521,"context_line":"            driver_list.extend(row[0].split(\u0027,\u0027))"},{"line_number":522,"context_line":"        return list(set(driver_list))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgqc%3D","line":521,"updated":"2013-10-15 08:23:32.000000000","message":"row[\u0027drivers\u0027]?","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        driver_list \u003d []"},{"line_number":520,"context_line":"        for row in result:"},{"line_number":521,"context_line":"            driver_list.extend(row[0].split(\u0027,\u0027))"},{"line_number":522,"context_line":"        return list(set(driver_list))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfHc%3D","line":521,"in_reply_to":"AAAATH%2F%2Fgqc%3D","updated":"2013-10-15 15:13:41.000000000","message":"No, because I queried models.Conductor.drivers, not model.Conductor.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9fd8edfd3c55cba04de7818d0e6457b30663459e","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    def register_conductor(self, values):"},{"line_number":469,"context_line":"        # NOTE(deva): we convert drivers from list to string locally only"},{"line_number":470,"context_line":"        if values.get(\u0027drivers\u0027):"},{"line_number":471,"context_line":"            values[\u0027drivers\u0027] \u003d \u0027,\u0027.join(values[\u0027drivers\u0027])"},{"line_number":472,"context_line":"        else:"},{"line_number":473,"context_line":"            values[\u0027drivers\u0027] \u003d \u0027\u0027"},{"line_number":474,"context_line":"        conductor \u003d models.Conductor()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ90%3D","line":471,"updated":"2013-10-16 16:07:28.000000000","message":"looks like, that values[\u0027drivers\u0027] it\u0027s should be (empty) list. So `if ... else` construction do not required here, because ` \u0027, \u0027.join([]) ` returns empty string","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    def register_conductor(self, values):"},{"line_number":469,"context_line":"        # NOTE(deva): we convert drivers from list to string locally only"},{"line_number":470,"context_line":"        if values.get(\u0027drivers\u0027):"},{"line_number":471,"context_line":"            values[\u0027drivers\u0027] \u003d \u0027,\u0027.join(values[\u0027drivers\u0027])"},{"line_number":472,"context_line":"        else:"},{"line_number":473,"context_line":"            values[\u0027drivers\u0027] \u003d \u0027\u0027"},{"line_number":474,"context_line":"        conductor \u003d models.Conductor()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FY28%3D","line":471,"in_reply_to":"AAAATH%2F%2FZ90%3D","updated":"2013-10-16 20:49:26.000000000","message":"Actually, I can use a JsonEncodedDict here and let it happen transparently at the sqlalchemy layer :)","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0b04f263b5ddfc699fdb7e738aef4c5aeab14c1","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        conductor \u003d models.Conductor()"},{"line_number":475,"context_line":"        conductor.update(values)"},{"line_number":476,"context_line":"        conductor.save()"},{"line_number":477,"context_line":"        conductor.drivers \u003d conductor.drivers.split(\u0027,\u0027)"},{"line_number":478,"context_line":"        return conductor"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @objects.objectify(objects.Conductor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fb6c%3D","line":477,"updated":"2013-10-16 08:21:00.000000000","message":"conductor.drivers \u003d values[\u0027drivers\u0027]?","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        conductor \u003d models.Conductor()"},{"line_number":475,"context_line":"        conductor.update(values)"},{"line_number":476,"context_line":"        conductor.save()"},{"line_number":477,"context_line":"        conductor.drivers \u003d conductor.drivers.split(\u0027,\u0027)"},{"line_number":478,"context_line":"        return conductor"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @objects.objectify(objects.Conductor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FYvQ%3D","line":477,"in_reply_to":"AAAATH%2F%2FZ9U%3D","updated":"2013-10-16 20:49:26.000000000","message":"... but this is clarified by using a JsonEncodedDict anyway.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"04d607da0e472ca0dfa8975313b7c755f0cb8dfa","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        conductor \u003d models.Conductor()"},{"line_number":475,"context_line":"        conductor.update(values)"},{"line_number":476,"context_line":"        conductor.save()"},{"line_number":477,"context_line":"        conductor.drivers \u003d conductor.drivers.split(\u0027,\u0027)"},{"line_number":478,"context_line":"        return conductor"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @objects.objectify(objects.Conductor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fbug%3D","line":477,"in_reply_to":"AAAATH%2F%2Fb6c%3D","updated":"2013-10-16 09:06:12.000000000","message":"+1","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7297d6410f2537fd0dc1a8551aa0049b68705e11","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        conductor \u003d models.Conductor()"},{"line_number":475,"context_line":"        conductor.update(values)"},{"line_number":476,"context_line":"        conductor.save()"},{"line_number":477,"context_line":"        conductor.drivers \u003d conductor.drivers.split(\u0027,\u0027)"},{"line_number":478,"context_line":"        return conductor"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @objects.objectify(objects.Conductor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ9U%3D","line":477,"in_reply_to":"AAAATH%2F%2Fb6c%3D","updated":"2013-10-16 15:59:33.000000000","message":"Nope. Because values[\u0027drivers\u0027] was modified above so that the string could be passed to conductor.update(values). We need to return a list here, not a string.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"4bfeb25b8a510748da75fca35f2fee97ae0e191b","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":488,"context_line":"        session \u003d get_session()"},{"line_number":489,"context_line":"        with session.begin():"},{"line_number":490,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession).\\"},{"line_number":491,"context_line":"                                        filter_by(hostname\u003dhostname)"},{"line_number":492,"context_line":"            count \u003d query.delete()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FWWM%3D","line":489,"updated":"2013-10-18 09:04:32.000000000","message":"Single question - is session really required here?","commit_id":"a4ec4cb992a947ec18184bab1d2d9720e23a6922"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"b2c8030692568ad1a23511372e04fe54a0afd502","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":488,"context_line":"        session \u003d get_session()"},{"line_number":489,"context_line":"        with session.begin():"},{"line_number":490,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession).\\"},{"line_number":491,"context_line":"                                        filter_by(hostname\u003dhostname)"},{"line_number":492,"context_line":"            count \u003d query.delete()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FMa8%3D","line":489,"in_reply_to":"AAAATH%2F%2FMmM%3D","updated":"2013-10-23 09:31:25.000000000","message":"`nova style` allows us to use query.delete() without session. See \nhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L899","commit_id":"a4ec4cb992a947ec18184bab1d2d9720e23a6922"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"76d855de0faa7f4c319c5609edca1d067437c35c","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def unregister_conductor(self, hostname):"},{"line_number":488,"context_line":"        session \u003d get_session()"},{"line_number":489,"context_line":"        with session.begin():"},{"line_number":490,"context_line":"            query \u003d model_query(models.Conductor, session\u003dsession).\\"},{"line_number":491,"context_line":"                                        filter_by(hostname\u003dhostname)"},{"line_number":492,"context_line":"            count \u003d query.delete()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FMmM%3D","line":489,"in_reply_to":"AAAATH%2F%2FWWM%3D","updated":"2013-10-21 15:32:24.000000000","message":"I\u0027m switching this to \"\u003d\u003d 0\" instead of \"!\u003d 1\" to be more explicit. However, the session usage is consistent with Nova\u0027s style so I feel it should stay.","commit_id":"a4ec4cb992a947ec18184bab1d2d9720e23a6922"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3857bf007d8e7a8dc60307eae21e195bc778b48b","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            if count \u003d\u003d 0:"},{"line_number":504,"context_line":"                raise exception.ConductorNotFound(conductor\u003dhostname)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":507,"context_line":"        limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":508,"context_line":"        result \u003d model_query(models.Conductor).\\"},{"line_number":509,"context_line":"                    filter(models.Conductor.updated_at \u003e\u003d limit).\\"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKGU%3D","line":506,"updated":"2013-10-22 11:20:07.000000000","message":"Having a default interval would make sense no?","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fc0e21addf575180df9e52624a9b9bf08cec8ba5","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            if count \u003d\u003d 0:"},{"line_number":504,"context_line":"                raise exception.ConductorNotFound(conductor\u003dhostname)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":507,"context_line":"        limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":508,"context_line":"        result \u003d model_query(models.Conductor).\\"},{"line_number":509,"context_line":"                    filter(models.Conductor.updated_at \u003e\u003d limit).\\"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATX%2F%2F%2FNE%3D","line":506,"in_reply_to":"AAAATH%2F%2FIMc%3D","updated":"2013-10-23 08:51:57.000000000","message":"Yes, having it at a higher layer makes sense.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa45b962975d020b1bb07f55f1835e4162e562e2","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            if count \u003d\u003d 0:"},{"line_number":504,"context_line":"                raise exception.ConductorNotFound(conductor\u003dhostname)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":507,"context_line":"        limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":508,"context_line":"        result \u003d model_query(models.Conductor).\\"},{"line_number":509,"context_line":"                    filter(models.Conductor.updated_at \u003e\u003d limit).\\"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FIMc%3D","line":506,"in_reply_to":"AAAATH%2F%2FKGU%3D","updated":"2013-10-22 20:29:09.000000000","message":"Yes, but I think it should be configurable, as this functions as a timeout, and it shouldn\u0027t be set at the db/sqla/api layer, but at a higher layer. Perhaps in the API or perhaps in the conductor?","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3857bf007d8e7a8dc60307eae21e195bc778b48b","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":507,"context_line":"        limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":508,"context_line":"        result \u003d model_query(models.Conductor).\\"},{"line_number":509,"context_line":"                    filter(models.Conductor.updated_at \u003e\u003d limit).\\"},{"line_number":510,"context_line":"                    all()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        driver_list \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKAw%3D","line":509,"updated":"2013-10-22 11:20:07.000000000","message":"I don\u0027t think it\u0027s a big problem but just mentioning... Just after the conductor get registered the update_at field will be None so this query it won\u0027t return any result.\n\nDo you think we address it? Maybe by checking if updated_at is None or populating the updated_at  with utcnow() when registering the conductor?","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa45b962975d020b1bb07f55f1835e4162e562e2","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    def list_active_conductor_drivers(self, interval):"},{"line_number":507,"context_line":"        limit \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dinterval)"},{"line_number":508,"context_line":"        result \u003d model_query(models.Conductor).\\"},{"line_number":509,"context_line":"                    filter(models.Conductor.updated_at \u003e\u003d limit).\\"},{"line_number":510,"context_line":"                    all()"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        driver_list \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FIWY%3D","line":509,"in_reply_to":"AAAATH%2F%2FKAw%3D","updated":"2013-10-22 20:29:09.000000000","message":"I find it odd that sqla isn\u0027t initializing this column.... that seems like a bug to me. I\u0027ve added a workarouind and a note.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3857bf007d8e7a8dc60307eae21e195bc778b48b","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        driver_list \u003d []"},{"line_number":513,"context_line":"        for row in result:"},{"line_number":514,"context_line":"            driver_list.extend(row[\u0027drivers\u0027])"},{"line_number":515,"context_line":"        return list(set(driver_list))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKDE%3D","line":514,"updated":"2013-10-22 11:20:07.000000000","message":"I think we should remove the ones duplicated here.\n\nimport itertools\n\ndriver_list \u003d []\nfor row in result:\n     driver_list \u003d list(set(itertools.chain(driver_list, row[\u0027drivers\u0027])))\nreturn driver_list","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fc0e21addf575180df9e52624a9b9bf08cec8ba5","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        driver_list \u003d []"},{"line_number":513,"context_line":"        for row in result:"},{"line_number":514,"context_line":"            driver_list.extend(row[\u0027drivers\u0027])"},{"line_number":515,"context_line":"        return list(set(driver_list))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATX%2F%2F%2FLs%3D","line":514,"in_reply_to":"AAAATH%2F%2FIWg%3D","updated":"2013-10-23 08:51:57.000000000","message":"Yes also, but the idea here is to return a list of supported drivers, e.g \"what r the drivers that can be used on this deployment\", so having no duplication will return a more readable list for that.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa45b962975d020b1bb07f55f1835e4162e562e2","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        driver_list \u003d []"},{"line_number":513,"context_line":"        for row in result:"},{"line_number":514,"context_line":"            driver_list.extend(row[\u0027drivers\u0027])"},{"line_number":515,"context_line":"        return list(set(driver_list))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FIWg%3D","line":514,"in_reply_to":"AAAATH%2F%2FKDE%3D","updated":"2013-10-22 20:29:09.000000000","message":"I can see there being a slight benefit to this, in that it avoids building a potentially very long list (if there were really that many conductors).","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ec0bf68b74cef7dafca8375ec4f590165a719558","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        driver_list \u003d []"},{"line_number":513,"context_line":"        for row in result:"},{"line_number":514,"context_line":"            driver_list.extend(row[\u0027drivers\u0027])"},{"line_number":515,"context_line":"        return list(set(driver_list))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATX%2F%2F%2BUg%3D","line":514,"in_reply_to":"AAAATX%2F%2F%2FLs%3D","updated":"2013-10-23 13:18:39.000000000","message":"FWIW, the original code here did perform deduplication, it just did it in a single pass outside the for loop.","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            conductor.save()"},{"line_number":482,"context_line":"            return conductor"},{"line_number":483,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":484,"context_line":"            raise exception.ConductorAlreadyRegistered(values[\u0027hostname\u0027])"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    @objects.objectify(objects.Conductor)"},{"line_number":487,"context_line":"    def get_conductor(self, hostname):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2B4U%3D","line":484,"updated":"2013-10-23 13:24:11.000000000","message":"Probably need to write ConductorAlreadyRegistered(conductor\u003dvalues[\u0027hostname\u0027]) here since the format string expects this keyword","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            conductor.save()"},{"line_number":482,"context_line":"            return conductor"},{"line_number":483,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":484,"context_line":"            raise exception.ConductorAlreadyRegistered(values[\u0027hostname\u0027])"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    @objects.objectify(objects.Conductor)"},{"line_number":487,"context_line":"    def get_conductor(self, hostname):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Wk%3D","line":484,"in_reply_to":"AAAATX%2F%2F%2B4U%3D","updated":"2013-10-23 17:44:06.000000000","message":"Done","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        for row in result:"},{"line_number":524,"context_line":"            driver_list \u003d list(set(itertools.chain(driver_list,"},{"line_number":525,"context_line":"                                                   row[\u0027drivers\u0027])))"},{"line_number":526,"context_line":"        return driver_list"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BzA%3D","line":526,"updated":"2013-10-23 13:24:11.000000000","message":"This is not critical, but from my point of view this can be done in more clear way like this:\ndriver_set \u003d set()\nfor row in result:\n         driver_set.update(set(row[\u0027drivers\u0027]))\nreturn list(driver_set)\nSorry if I\u0027m missing something, but since we end with list() there are no need for itertools\nP.S. don\u0027t forget to remove the import if you decide to apply this comment\u003d)","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        for row in result:"},{"line_number":524,"context_line":"            driver_list \u003d list(set(itertools.chain(driver_list,"},{"line_number":525,"context_line":"                                                   row[\u0027drivers\u0027])))"},{"line_number":526,"context_line":"        return driver_list"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9U4%3D","line":526,"in_reply_to":"AAAATX%2F%2F%2BzA%3D","updated":"2013-10-23 17:44:06.000000000","message":"Done","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"}],"ironic/db/sqlalchemy/migrate_repo/versions/001_init.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1a04f8ee4129feab4554da19d1adb25478370a4f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            table.create()"},{"line_number":70,"context_line":"        except Exception:"},{"line_number":71,"context_line":"            LOG.info(repr(table))"},{"line_number":72,"context_line":"            LOG.exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":73,"context_line":"            raise"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    indexes \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F9uo%3D","line":72,"updated":"2013-10-24 14:43:03.000000000","message":"I guess, this change is unrelated to current patch","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2a6f294f44133d0d0523d518f1aa3c245170215c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            table.create()"},{"line_number":70,"context_line":"        except Exception:"},{"line_number":71,"context_line":"            LOG.info(repr(table))"},{"line_number":72,"context_line":"            LOG.exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":73,"context_line":"            raise"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    indexes \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F9HY%3D","line":72,"in_reply_to":"AAAATn%2F%2F9uo%3D","updated":"2013-10-24 17:30:57.000000000","message":"Yep. This change was pointed out to me in 012_ and so I also fixed it here. Splitting to another patch.","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"}],"ironic/db/sqlalchemy/migrate_repo/versions/012_add_conductor_table.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CHARSET \u003d \u0027utf8\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def upgrade(migrate_engine):"},{"line_number":28,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    conductor \u003d Table(\u0027condcutor\u0027, meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgvM%3D","line":27,"updated":"2013-10-15 08:23:32.000000000","message":"Please add migration test to test_migrations.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b56afbe26c43091cc96474d609329156f9c1f14c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CHARSET \u003d \u0027utf8\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def upgrade(migrate_engine):"},{"line_number":28,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    conductor \u003d Table(\u0027condcutor\u0027, meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fe4I%3D","line":27,"in_reply_to":"AAAATH%2F%2FgvM%3D","updated":"2013-10-15 16:23:42.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def upgrade(migrate_engine):"},{"line_number":28,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    conductor \u003d Table(\u0027condcutor\u0027, meta,"},{"line_number":31,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":32,"context_line":"        Column(\u0027hostname\u0027, String(length\u003d255), nullable\u003dFalse),"},{"line_number":33,"context_line":"        Column(\u0027drivers\u0027, String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgvc%3D","line":30,"updated":"2013-10-15 08:23:32.000000000","message":"type error","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def upgrade(migrate_engine):"},{"line_number":28,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    conductor \u003d Table(\u0027condcutor\u0027, meta,"},{"line_number":31,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":32,"context_line":"        Column(\u0027hostname\u0027, String(length\u003d255), nullable\u003dFalse),"},{"line_number":33,"context_line":"        Column(\u0027drivers\u0027, String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfHQ%3D","line":30,"in_reply_to":"AAAATH%2F%2Fgvc%3D","updated":"2013-10-15 15:13:41.000000000","message":"Done","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9fd8edfd3c55cba04de7818d0e6457b30663459e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"},{"line_number":50,"context_line":"                          name\u003d\u0027uniq_conductor0hostname\u0027)"},{"line_number":51,"context_line":"    uc.create()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ7E%3D","line":50,"updated":"2013-10-16 16:07:28.000000000","message":"Wrong UC name.\n\nShould be \nname\u003d\u0027uniq_conductors0hostname\u0027","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"},{"line_number":50,"context_line":"                          name\u003d\u0027uniq_conductor0hostname\u0027)"},{"line_number":51,"context_line":"    uc.create()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FYus%3D","line":50,"in_reply_to":"AAAATH%2F%2FZ7E%3D","updated":"2013-10-16 20:49:26.000000000","message":"Done","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"04d607da0e472ca0dfa8975313b7c755f0cb8dfa","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def downgrade(migrate_engine):"},{"line_number":55,"context_line":"    raise NotImplementedError(\u0027Downgrade from version 012 is unsupported.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fbxo%3D","line":55,"updated":"2013-10-16 09:06:12.000000000","message":"Wondering if we should i18n here as well","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7297d6410f2537fd0dc1a8551aa0049b68705e11","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def downgrade(migrate_engine):"},{"line_number":55,"context_line":"    raise NotImplementedError(\u0027Downgrade from version 012 is unsupported.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ8c%3D","line":55,"in_reply_to":"AAAATH%2F%2Fbxo%3D","updated":"2013-10-16 15:59:33.000000000","message":"compared to Nova for reference -- yes, we should. That should be added to the other migrations, too","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"4bfeb25b8a510748da75fca35f2fee97ae0e191b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        conductor.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        LOG.info(repr(conductor))"},{"line_number":46,"context_line":"        LOG.Exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FSuo%3D","line":46,"updated":"2013-10-18 09:04:32.000000000","message":"must be LOG.exception(...)","commit_id":"a4ec4cb992a947ec18184bab1d2d9720e23a6922"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"b2c8030692568ad1a23511372e04fe54a0afd502","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        conductor.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        LOG.info(repr(conductor))"},{"line_number":46,"context_line":"        LOG.Exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATX%2F%2F%2FCE%3D","line":46,"in_reply_to":"AAAATH%2F%2FMwY%3D","updated":"2013-10-23 09:31:25.000000000","message":"see also https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/migrate_repo/versions/001_init.py#L72\n\nOr I can fix it.","commit_id":"a4ec4cb992a947ec18184bab1d2d9720e23a6922"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"76d855de0faa7f4c319c5609edca1d067437c35c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        conductor.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        LOG.info(repr(conductor))"},{"line_number":46,"context_line":"        LOG.Exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FMwY%3D","line":46,"in_reply_to":"AAAATH%2F%2FSuo%3D","updated":"2013-10-21 15:32:24.000000000","message":"Woops! thanks :)","commit_id":"a4ec4cb992a947ec18184bab1d2d9720e23a6922"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        conductor.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        LOG.info(repr(conductor))"},{"line_number":46,"context_line":"        LOG.exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BwI%3D","line":46,"updated":"2013-10-23 13:24:11.000000000","message":"Probably missed \"raise\" here. Further UC will fail too if exception occur","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        conductor.create()"},{"line_number":44,"context_line":"    except Exception:"},{"line_number":45,"context_line":"        LOG.info(repr(conductor))"},{"line_number":46,"context_line":"        LOG.exception(_(\u0027Exception while creating table.\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    uc \u003d UniqueConstraint(\u0027hostname\u0027,"},{"line_number":49,"context_line":"                          table\u003dconductor,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Ug%3D","line":46,"in_reply_to":"AAAATX%2F%2F%2BwI%3D","updated":"2013-10-23 17:44:06.000000000","message":"Ah, yep. Thanks!","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d67721b53b387409b2a054ee8b349b16681851ba","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":105,"context_line":"    drivers \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class Node(Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgmM%3D","line":105,"updated":"2013-10-15 08:23:32.000000000","message":"Maybe drivers as separate table?","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8a960115db406fd7273e06dfb3e090ccc9ece988","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":105,"context_line":"    drivers \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class Node(Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FfGk%3D","line":105,"in_reply_to":"AAAATH%2F%2FgRw%3D","updated":"2013-10-15 15:13:41.000000000","message":"I thought about 3NF here -- a separate table for drivers with a surrogate key / foreign key between the tables. If we do that, it suggests we should add a separate RPC object model for \"drivers\". Does this make sense? Do we need to pass an object representation of a driver between API and Conductor, or merely the string representing that driver\u0027s name / entrypoint?","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"703281c56354fff6b1dfd56643d2ae6f0bdc91fa","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":105,"context_line":"    drivers \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class Node(Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgRw%3D","line":105,"in_reply_to":"AAAATH%2F%2FgmM%3D","updated":"2013-10-15 10:22:48.000000000","message":"-1\n\nI think having a list of drivers for each conductor on the same table looks good and simpler. You look at the table and you\u0027ll see what are the supported drivers for each conductor.","commit_id":"a2eda75299cc2bfe3c0857455be10fc97d0b5429"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9fd8edfd3c55cba04de7818d0e6457b30663459e","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    __tablename__ \u003d \u0027conductors\u0027"},{"line_number":100,"context_line":"    __table_args__ \u003d ("},{"line_number":101,"context_line":"        schema.UniqueConstraint(\u0027hostname\u0027, name\u003d\u0027uniq_conductor0hostname\u0027),"},{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ68%3D","line":101,"updated":"2013-10-16 16:07:28.000000000","message":"wrong UC name\n\nname\u003d\u0027uniq_conductors0hostname\u0027","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    __tablename__ \u003d \u0027conductors\u0027"},{"line_number":100,"context_line":"    __table_args__ \u003d ("},{"line_number":101,"context_line":"        schema.UniqueConstraint(\u0027hostname\u0027, name\u003d\u0027uniq_conductor0hostname\u0027),"},{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FYug%3D","line":101,"in_reply_to":"AAAATH%2F%2FZ68%3D","updated":"2013-10-16 20:49:26.000000000","message":"Done","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"04d607da0e472ca0dfa8975313b7c755f0cb8dfa","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":105,"context_line":"    drivers \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class Node(Base):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fbr8%3D","line":105,"updated":"2013-10-16 09:06:12.000000000","message":"Do you think that 255 for drivers is enough? Maybe using a bigger length just in case?","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7297d6410f2537fd0dc1a8551aa0049b68705e11","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":105,"context_line":"    drivers \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class Node(Base):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ7o%3D","line":105,"in_reply_to":"AAAATH%2F%2Fbr8%3D","updated":"2013-10-16 15:59:33.000000000","message":"Done","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"9011d47308388526f95ad173046ff1dc4f6e4f0d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":104,"context_line":"    hostname \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":105,"context_line":"    drivers \u003d Column(JSONEncodedDict)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class Node(Base):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F%2F6ok%3D","line":105,"updated":"2013-10-25 09:24:19.000000000","message":"Every other place, drivers entry is treated like a list, and not as a json dict. Is this on purpose?","commit_id":"d40f8e3935e12ef625ddf57d204a0805307f47de"}],"ironic/objects/conductor.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"db65a3dc3881ff3426500d96c10e405d32357d8e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def save(self, context):"},{"line_number":53,"context_line":"        \"\"\"Save is not supported by Conductor objects.\"\"\""},{"line_number":54,"context_line":"        raise NotImplementedError(\u0027Cannot update a conductor record directly.\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @base.remotable"},{"line_number":57,"context_line":"    def refresh(self, context):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FKVQ%3D","line":54,"updated":"2013-10-22 09:05:08.000000000","message":"i18n","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa45b962975d020b1bb07f55f1835e4162e562e2","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def save(self, context):"},{"line_number":53,"context_line":"        \"\"\"Save is not supported by Conductor objects.\"\"\""},{"line_number":54,"context_line":"        raise NotImplementedError(\u0027Cannot update a conductor record directly.\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @base.remotable"},{"line_number":57,"context_line":"    def refresh(self, context):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FIWQ%3D","line":54,"in_reply_to":"AAAATH%2F%2FKVQ%3D","updated":"2013-10-22 20:29:09.000000000","message":"Done","commit_id":"6c0d59762d8c58c6c45b84ab742252aaf7a951b0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"            \u0027id\u0027: int,"},{"line_number":29,"context_line":"            \u0027drivers\u0027: utils.list_or_none,"},{"line_number":30,"context_line":"            \u0027hostname\u0027: utils.str_or_none,"},{"line_number":31,"context_line":"            }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BmA%3D","line":30,"updated":"2013-10-23 13:24:11.000000000","message":"Not sure if it matters, but is it okay that we use str_or_none here but the DB model (ironic/db/sqlalchemy/models.py Conductor) does not allow hostname to be Null?","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"            \u0027id\u0027: int,"},{"line_number":29,"context_line":"            \u0027drivers\u0027: utils.list_or_none,"},{"line_number":30,"context_line":"            \u0027hostname\u0027: utils.str_or_none,"},{"line_number":31,"context_line":"            }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9TQ%3D","line":30,"in_reply_to":"AAAATX%2F%2F%2BmA%3D","updated":"2013-10-23 17:44:06.000000000","message":"The RPC object\u0027s value will be coming from the DB, so it will always be not null. This could possibly be \"str\" instead of \"utils.str_or_none\". Changing it shouldn\u0027t hurt, and is more clear.","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"}],"ironic/objects/utils.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9fd8edfd3c55cba04de7818d0e6457b30663459e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if val is None:"},{"line_number":78,"context_line":"        return []"},{"line_number":79,"context_line":"    elif isinstance(val, str):"},{"line_number":80,"context_line":"        return list(ast.literal_eval(val))"},{"line_number":81,"context_line":"    else:"},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return list(val)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FZ5Q%3D","line":80,"updated":"2013-10-16 16:07:28.000000000","message":"I guess, we need try ... except block here also. Something like \n\ntry:\n    return list(ast.literal_eval(val))\nexcept:\n    return []\n\nOr maybe it makes a sense just split this string?","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if val is None:"},{"line_number":78,"context_line":"        return []"},{"line_number":79,"context_line":"    elif isinstance(val, str):"},{"line_number":80,"context_line":"        return list(ast.literal_eval(val))"},{"line_number":81,"context_line":"    else:"},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            return list(val)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FYtg%3D","line":80,"in_reply_to":"AAAATH%2F%2FZ5Q%3D","updated":"2013-10-16 20:49:26.000000000","message":"What exception are you expecting from list(ast.literal_eval(val))? If we need a try: here, we probably need it in dict_or_none as well, yes?","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"}],"ironic/tests/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        conductor.insert().values(conductor_data).execute()"},{"line_number":694,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":695,"context_line":"                          conductor.insert().execute,"},{"line_number":696,"context_line":"                          conductor_data)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2Beo%3D","line":696,"updated":"2013-10-23 13:24:11.000000000","message":"1. We could also add a column type asserts to be consistent with previous tests for the new tables (_check_001, _check_003 for example). Sorry beforehand if the team already decided to deprecate such asserts for further tests. Personally I consider those type asserts not very usefull, but I would follow the common style if it\u0027s still actual.\n\n2. Also would be great here to test that inserting a row without a hostname raises an error too.","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        conductor.insert().values(conductor_data).execute()"},{"line_number":694,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":695,"context_line":"                          conductor.insert().execute,"},{"line_number":696,"context_line":"                          conductor_data)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Pw%3D","line":696,"in_reply_to":"AAAATX%2F%2F%2Beo%3D","updated":"2013-10-23 17:44:06.000000000","message":"1. I find them also not useful.\n\n2. good point, though we lack the not-null checks for other columns, it\u0027s good to start now :)","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"039e7df69e17f10f3b951360875bf8aa0628b243","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":695,"context_line":"                          conductor.insert().execute,"},{"line_number":696,"context_line":"                          conductor_data)"},{"line_number":697,"context_line":"        self.assertRaises(sqlalchemy.exc.OperationalError,"},{"line_number":698,"context_line":"                          conductor.insert().execute,"},{"line_number":699,"context_line":"                          {\u0027hostname\u0027: None})"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2F%2F5s%3D","line":697,"updated":"2013-10-24 02:31:42.000000000","message":"Devananda, I helped you check the test logs, maybe we should assert IntegrityError exception here, how do you think?","commit_id":"6f6594e132e37ee858e62f0b8a39716444b78a5f"}],"ironic/tests/db/test_conductor.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0b04f263b5ddfc699fdb7e738aef4c5aeab14c1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        t \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d10)"},{"line_number":69,"context_line":"        # add tzinfo to t"},{"line_number":70,"context_line":"        t \u003d obj_utils.datetime_or_none(t)"},{"line_number":71,"context_line":"        with mock.patch.object(timeutils, \u0027utcnow\u0027,"},{"line_number":72,"context_line":"                               autospec\u003dTrue) as mock_utcnow:"},{"line_number":73,"context_line":"            mock_utcnow.return_value \u003d t"},{"line_number":74,"context_line":"            self.dbapi.touch_conductor(c[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2Fb0w%3D","line":71,"updated":"2013-10-16 08:21:00.000000000","message":"There is TimeOverride fixture for tests.","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ad30919a6bc163c8b119f83f86574affed932d16","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        t \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d10)"},{"line_number":69,"context_line":"        # add tzinfo to t"},{"line_number":70,"context_line":"        t \u003d obj_utils.datetime_or_none(t)"},{"line_number":71,"context_line":"        with mock.patch.object(timeutils, \u0027utcnow\u0027,"},{"line_number":72,"context_line":"                               autospec\u003dTrue) as mock_utcnow:"},{"line_number":73,"context_line":"            mock_utcnow.return_value \u003d t"},{"line_number":74,"context_line":"            self.dbapi.touch_conductor(c[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FYnc%3D","line":71,"in_reply_to":"AAAATH%2F%2Fb0w%3D","updated":"2013-10-16 20:49:26.000000000","message":"Done","commit_id":"55047c9c543ed59116e81b0d82626434a4880e42"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                exception.ConductorAlreadyRegistered,"},{"line_number":46,"context_line":"                self._create_test_cdr,"},{"line_number":47,"context_line":"                id\u003d2)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_conductor(self):"},{"line_number":50,"context_line":"        c1 \u003d self._create_test_cdr()"},{"line_number":51,"context_line":"        c2 \u003d self.dbapi.get_conductor(c1[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BbY%3D","line":48,"updated":"2013-10-23 13:24:11.000000000","message":"How do you think do we need to handle and wrap DB error in case when we create conductor without hostname? If so then we would need a unit test for this too.","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                exception.ConductorAlreadyRegistered,"},{"line_number":46,"context_line":"                self._create_test_cdr,"},{"line_number":47,"context_line":"                id\u003d2)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_conductor(self):"},{"line_number":50,"context_line":"        c1 \u003d self._create_test_cdr()"},{"line_number":51,"context_line":"        c2 \u003d self.dbapi.get_conductor(c1[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9O8%3D","line":48,"in_reply_to":"AAAATX%2F%2F%2BbY%3D","updated":"2013-10-23 17:44:06.000000000","message":"How would a conductor be created without a hostname? At worst, hostname would be an empty string, since it is coming from a config option. See common/service.py:\n\n  35     cfg.StrOpt(\u0027host\u0027,\n  36                default\u003dsocket.getfqdn(),","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"37d26094ba547222fecca658d5613eb4f57b39fe","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                exception.ConductorAlreadyRegistered,"},{"line_number":46,"context_line":"                self._create_test_cdr,"},{"line_number":47,"context_line":"                id\u003d2)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_conductor(self):"},{"line_number":50,"context_line":"        c1 \u003d self._create_test_cdr()"},{"line_number":51,"context_line":"        c2 \u003d self.dbapi.get_conductor(c1[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F%2BWQ%3D","line":48,"in_reply_to":"AAAATX%2F%2F9O8%3D","updated":"2013-10-24 12:32:37.000000000","message":"Agree. Thank you for the rationale","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d7200)"},{"line_number":112,"context_line":"        res.sort()"},{"line_number":113,"context_line":"        drivers \u003d d1 + d2 + d3"},{"line_number":114,"context_line":"        drivers.sort()"},{"line_number":115,"context_line":"        self.assertEqual(drivers, res)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BZ8%3D","line":114,"updated":"2013-10-23 13:24:11.000000000","message":"Possible improvement - there is handy assertItemsEqual method to compare lists despide their order:\nhttp://docs.python.org/2/library/unittest.html#unittest.TestCase.assertItemsEqual","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d7200)"},{"line_number":112,"context_line":"        res.sort()"},{"line_number":113,"context_line":"        drivers \u003d d1 + d2 + d3"},{"line_number":114,"context_line":"        drivers.sort()"},{"line_number":115,"context_line":"        self.assertEqual(drivers, res)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Oo%3D","line":114,"in_reply_to":"AAAATX%2F%2F%2BZ8%3D","updated":"2013-10-23 17:44:06.000000000","message":"Ahh - I had grep\u0027d for this, but only found cases where folks created their own list and object comparators.","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"039e7df69e17f10f3b951360875bf8aa0628b243","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # verify that res contains d2 and d3, but not the old d1"},{"line_number":104,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d60)"},{"line_number":105,"context_line":"        drivers \u003d d2 + d3"},{"line_number":106,"context_line":"        self.assertItemsEqual(drivers, res)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # change the interval, and verify that d1 appears"},{"line_number":109,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d7200)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2F%2F5g%3D","line":106,"updated":"2013-10-24 02:31:42.000000000","message":"I helped you checked, according to the UT log output, we found \"AttributeError: \u0027DbConductorTestCase\u0027 object has no attribute \u0027assertItemsEqual\u0027\", so we can not use assertItemsEqual here.","commit_id":"6f6594e132e37ee858e62f0b8a39716444b78a5f"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22d45256acf9a13c329dbf47348ed78fb28e99b6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # verify that res contains d2 and d3, but not the old d1"},{"line_number":104,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d60)"},{"line_number":105,"context_line":"        drivers \u003d d2 + d3"},{"line_number":106,"context_line":"        self.assertItemsEqual(drivers, res)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # change the interval, and verify that d1 appears"},{"line_number":109,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d7200)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F%2FX0%3D","line":106,"updated":"2013-10-24 06:33:34.000000000","message":"Devananda, I checked the API document - http://docs.python.org/2/library/unittest.html#unittest.TestCase.assertItemsEqual\nLooks like assertItemsEqual is introduced from Python 2.7, but our community code have to support both 2.6 and 2.7. So I think we will keep to call sort() with assertEqual","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2a6f294f44133d0d0523d518f1aa3c245170215c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # verify that res contains d2 and d3, but not the old d1"},{"line_number":104,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d60)"},{"line_number":105,"context_line":"        drivers \u003d d2 + d3"},{"line_number":106,"context_line":"        self.assertItemsEqual(drivers, res)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # change the interval, and verify that d1 appears"},{"line_number":109,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d7200)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F9Fg%3D","line":106,"in_reply_to":"AAAATn%2F%2F%2FOM%3D","updated":"2013-10-24 17:30:57.000000000","message":"Interesting. This may explain why other projects aren\u0027t using assertItemsEqual.\n\nI checked with Infra team -- unittest2 is being deprecated and should not be used. I will use assertEqual(sorted(), sorted()) instead.","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"2c50625294145e4ce64acc88dceafd2b1018699b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # verify that res contains d2 and d3, but not the old d1"},{"line_number":104,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d60)"},{"line_number":105,"context_line":"        drivers \u003d d2 + d3"},{"line_number":106,"context_line":"        self.assertItemsEqual(drivers, res)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # change the interval, and verify that d1 appears"},{"line_number":109,"context_line":"        res \u003d self.dbapi.list_active_conductor_drivers(interval\u003d7200)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F%2FOM%3D","line":106,"in_reply_to":"AAAATn%2F%2F%2FX0%3D","updated":"2013-10-24 07:43:52.000000000","message":"@Devananda you should use assertItemsEqual() method from unittest2 module in python 2.6","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"}],"ironic/tests/objects/test_conductor.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9d0e2c090c251da5c10978fd8db005a5449a6c73","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            c.hostname \u003d \u0027another-hostname\u0027"},{"line_number":54,"context_line":"            self.assertRaises(NotImplementedError,"},{"line_number":55,"context_line":"                              c.save, self.context)"},{"line_number":56,"context_line":"            mock_get_cdr.assert_called_once_with(host)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_touch(self):"},{"line_number":59,"context_line":"        host \u003d self.fake_conductor[\u0027hostname\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2BXg%3D","line":56,"updated":"2013-10-23 13:24:11.000000000","message":"Maybe we can drop this assert here, it copies one from the previous test. Similar comment for the test_touch","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d20339f3b5b0ec0d7b5968907e1d8cabcb2ddec2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            c.hostname \u003d \u0027another-hostname\u0027"},{"line_number":54,"context_line":"            self.assertRaises(NotImplementedError,"},{"line_number":55,"context_line":"                              c.save, self.context)"},{"line_number":56,"context_line":"            mock_get_cdr.assert_called_once_with(host)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_touch(self):"},{"line_number":59,"context_line":"        host \u003d self.fake_conductor[\u0027hostname\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9MU%3D","line":56,"in_reply_to":"AAAATX%2F%2F%2BXg%3D","updated":"2013-10-23 17:44:06.000000000","message":"Since these three tests are mocking the same method but using it in different ways, I would still prefer to assert what we expect to be done in each case. I think it\u0027s more clear, even if it is redundant.","commit_id":"464ecf5b63f20a6251e3b7e8adbc848f1cba64f0"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"2c50625294145e4ce64acc88dceafd2b1018699b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import datetime"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.openstack.common import timeutils"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F%2FNw%3D","line":19,"updated":"2013-10-24 07:43:52.000000000","message":"Maybe I wrong, but, afaik, mock - it is third part library, so it\u0027s should be in separate import group.","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2a6f294f44133d0d0523d518f1aa3c245170215c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import datetime"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.openstack.common import timeutils"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F9Cs%3D","line":19,"in_reply_to":"AAAATn%2F%2F%2FNw%3D","updated":"2013-10-24 17:30:57.000000000","message":"Done","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"2c50625294145e4ce64acc88dceafd2b1018699b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.openstack.common import timeutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from ironic.db import api as db_api"},{"line_number":24,"context_line":"from ironic.db.sqlalchemy import models"},{"line_number":25,"context_line":"from ironic import objects"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2F%2FNo%3D","line":22,"updated":"2013-10-24 07:43:52.000000000","message":"this empty line is redundant.","commit_id":"bd7d2a606d361de37361ae06e34cf2ef14bc648f"}]}
