)]}'
{"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b698715973c905492afe41e26cf5c3226a92c0cb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        pending_boot_mode \u003d system.boot.mode"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":68,"context_line":"        error_msg \u003d (_(\u0027Redfish getting boot mode failed for node %(node)s. \u0027"},{"line_number":69,"context_line":"                       \u0027Error: %(error)s\u0027) % {\u0027node\u0027: node.uuid,"},{"line_number":70,"context_line":"                                              \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_6a695d89","line":67,"updated":"2017-11-23 14:03:04.000000000","message":"I cannot see how system.boot.mode can raise an exception. this field is populated on get_system","commit_id":"fc51a9365b3b9ba66f1ae16f958edbcc208c233f"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"efe8aeb3f1037ec2111baddce33de142cc8ba81d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        pending_boot_mode \u003d system.boot.mode"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":68,"context_line":"        error_msg \u003d (_(\u0027Redfish getting boot mode failed for node %(node)s. \u0027"},{"line_number":69,"context_line":"                       \u0027Error: %(error)s\u0027) % {\u0027node\u0027: node.uuid,"},{"line_number":70,"context_line":"                                              \u0027error\u0027: e})"},{"line_number":71,"context_line":"        LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_cc1d2c10","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":66},"updated":"2017-11-23 10:34:29.000000000","message":"Redfish here looks not right. Can you rephrase it to?\n  Failed to get boot mode for node ...","commit_id":"fc51a9365b3b9ba66f1ae16f958edbcc208c233f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b698715973c905492afe41e26cf5c3226a92c0cb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    node.instance_info \u003d instance_info"},{"line_number":93,"context_line":"    node.save()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    LOG.debug(\"Node %(uuid)s boot mode is being set to %(boot_mode)s\","},{"line_number":96,"context_line":"              {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: pending_boot_mode})"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_0a0691cf","line":95,"updated":"2017-11-23 14:03:04.000000000","message":"This may be confusing, you don\u0027t modify the actual system. Maybe something like \"Cached actual boot mode %(boot_mode)s on the node %(uuid)s\"","commit_id":"fc51a9365b3b9ba66f1ae16f958edbcc208c233f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b698715973c905492afe41e26cf5c3226a92c0cb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"              {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: pending_boot_mode})"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class RedfishPXEBoot(pxe.PXEBoot):"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __init__(self):"},{"line_number":102,"context_line":"        \"\"\"Initialize the Redfish boot interface."}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_2a0915dc","line":99,"updated":"2017-11-23 14:03:04.000000000","message":"SIGH. I wanted us to avoid doing this, to be honest. As discussed at the PTG, let\u0027s introduce (in a separate patch) update_boot_mode to ManagementInterface and call it from the generic PXEBoot. We should not really introduce more flavors of PXEBoot..","commit_id":"fc51a9365b3b9ba66f1ae16f958edbcc208c233f"}],"ironic/drivers/redfish.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b698715973c905492afe41e26cf5c3226a92c0cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @property"},{"line_number":26,"context_line":"    def supported_boot_interfaces(self):"},{"line_number":27,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":28,"context_line":"        return [boot.RedfishPXEBoot]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_ca0f49df","line":28,"updated":"2017-11-23 14:03:04.000000000","message":"this is breaking backwards compatibility. Anyway, let\u0027s avoid creating more boot interfaces - see my comments above (and sorry for making you do more work!)","commit_id":"fc51a9365b3b9ba66f1ae16f958edbcc208c233f"}]}