)]}'
{"ironic/cmd/dbsync.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6e86fbb324b1248c0e35cee22c6bca8d527daa5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # TODO(rloo): remove in Rocky"},{"line_number":63,"context_line":"    # NOTE(vdrok): Do not access attribute yet, as it will trigger the load"},{"line_number":64,"context_line":"    # of the whole dbapi object. Use method names here and do getattr when"},{"line_number":65,"context_line":"    # the actual object is needed"},{"line_number":66,"context_line":"    \u0027backfill_version_column\u0027,"},{"line_number":67,"context_line":")"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_182166fc","line":65,"updated":"2017-12-02 21:43:02.000000000","message":"let\u0027s move this comment to before ONLINE_MIGRATIONS? Otherwise it seems to apply only to this migration, and it shadows the migration-related comments above.","commit_id":"5c7f638216413bfdc4770dd4e4c38f9b64007840"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0e0c59dc6622477d9ff4273bb611ec0534c774a6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # TODO(rloo): remove in Rocky"},{"line_number":63,"context_line":"    # NOTE(vdrok): Do not access attribute yet, as it will trigger the load"},{"line_number":64,"context_line":"    # of the whole dbapi object. Use method names here and do getattr when"},{"line_number":65,"context_line":"    # the actual object is needed"},{"line_number":66,"context_line":"    \u0027backfill_version_column\u0027,"},{"line_number":67,"context_line":")"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_90066f86","line":65,"in_reply_to":"df87a7cf_182166fc","updated":"2017-12-05 18:47:49.000000000","message":"+1, cuz the above two comments only apply to backfill_version_column.","commit_id":"5c7f638216413bfdc4770dd4e4c38f9b64007840"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f40948db0f069712a510106f245215c91f2d000c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        total_migrated \u003d 0"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        for migration_func_name in ONLINE_MIGRATIONS:"},{"line_number":136,"context_line":"            migration_func \u003d getattr(dbapi, migration_func_name)"},{"line_number":137,"context_line":"            num_to_migrate \u003d max_count - total_migrated"},{"line_number":138,"context_line":"            try:"},{"line_number":139,"context_line":"                total_to_do, num_migrated \u003d migration_func(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_f3458544","line":136,"updated":"2017-12-05 19:09:00.000000000","message":"I just remembered, that we shouldn\u0027t assume that it comes from dbapi. Eg: this one uses functions in port \u0026 portgroup: https://review.openstack.org/#/c/511636/6/ironic/cmd/dbsync.py","commit_id":"5c7f638216413bfdc4770dd4e4c38f9b64007840"}]}